Konrad Rzeszutek Wilk writes ("[PATCH v4 08/34] vmap: Make the while loop less
fishy."):
> error:
> -while ( i-- )
> -free_domheap_page(mfn_to_page(mfn_x(mfn[i])));
> +while ( i )
> +free_domheap_page(mfn_to_page(mfn_x(mfn[--i])));
I quite strongly dislike this. It is g
The human running this script might want to update a suite-specific
value, or the global value. Print an example of the suite-specific
value too.
No functional change other than to example config output.
Signed-off-by: Ian Jackson
---
mg-debian-installer-update |1 +
1 file changed, 1
Jan Beulich writes ("Re: [Xen-devel] [RFC Design Doc] Add vNVDIMM support for
Xen"):
> So that again leaves unaddressed the question of what you
> imply to do when a guest elects to use such a page as page
> table. I'm afraid any attempt of yours to invent something that
> is not struct page_info
t
> silently exits.
>
> Remove this, and let the block script perform its duplicate checking
> function.
>
> Signed-off-by: George Dunlap
> ---
> NOTE: It's likely that the duplicate checking for physical devices has
> never been run under libxl (at least since t
David Vrabel writes ("Re: [Xen-devel] [RFC PATCH] blkif.h: document
scsi/0x12/0x83 node"):
> On 17/03/16 11:12, Ian Jackson wrote:
> > David Vrabel writes ("Re: [Xen-devel] [RFC PATCH] blkif.h: document
> > scsi/0x12/0x83 node"):
> >> On 16/03/16 13:5
Konrad Rzeszutek Wilk writes ("Re: [PATCH v11 20/27] Support colo mode for qemu
disk"):
> On Fri, Mar 04, 2016 at 05:52:09PM +, Ian Jackson wrote:
> > How can this be made to work with PV guests ?
>
> QEMU can also serve PV guests (qdisk).
Yes.
> I think you
osstest service owner writes ("[linux-3.4 test] 86823: regressions - FAIL"):
> flight 86823 linux-3.4 real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/86823/
>
> Regressions :-(
>
> Tests which did not succeed and are blocking,
> including tests which could not be run:
> build-amd6
Paul Durrant writes ("RE: [Xen-devel] [RFC PATCH] blkif.h: document
scsi/0x12/0x83 node"):
> AFAIK XenServer still very much makes use of it.
Can you answer, for XenServer's use case, some of the questions that
David and I have asked ?
Ian.
___
Xen-de
David Vrabel writes ("Re: [Xen-devel] [RFC PATCH] blkif.h: document
scsi/0x12/0x83 node"):
> On 22/03/16 14:10, Konrad Rzeszutek Wilk wrote:
> > Just think of it as a black box.
>
> This isn't sufficient.
>
> You are presenting a solution but have not properly described the
> problem so no one c
Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] [RFC PATCH] blkif.h: document
scsi/0x12/0x83 node"):
> > I don't think this is a sterile academic conversation which would (if
> > satisfactorily answered) have no real implications. Rather, if we
> > understood the use case properly, there would pro
Paul Durrant writes ("RE: [Xen-devel] [RFC PATCH] blkif.h: document
scsi/0x12/0x83 node"):
> It's getting hard to parse the thread at this point but, as I've
> mentioned in a previous response in the thread, Windows basically
> assumes disks are SCSI and it's up to the controller driver to make
>
created, so that cr-daily-branch would crash for
most branches because the (largely irrelevant) invocation of
`./ap-fetch-version-old xen-unstable-coverity' would fail.
Signed-off-by: Ian Jackson
---
cri-getprevxenbranch |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
;.
After this patch `git-grep smoked' produces no output, as it did in
d94637b6~.
Signed-off-by: Ian Jackson
---
ap-fetch-version |2 +-
ap-fetch-version-old |2 +-
ap-push |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/ap-fetch-version b/ap-f
Paul Durrant writes ("RE: [PATCH] blkif.h: document scsi/0x12/0x node"):
> > From: Bob Liu [mailto:bob@oracle.com]
> > Sent: 23 March 2016 11:48
> > To: xen-devel@lists.xen.org
> > Cc: Paul Durrant; Ian Jackson; konrad.w...@oracle.com; jgr...@suse.com;
> &
Jim Fehlig writes ("[Xen-devel] [PATCH] tools: Restrict configuration of qemu
processes"):
> Commit 6ef823fd added '-nodefaults' to the qemu args created by
> libxl, which is a good step in restricting qemu's default
> configuration. This change takes another step by adding
> -no-user-config, whic
Changlong Xie writes ("[PATCH v12 11/26] tools/libxl: add back channel support
to read stream"):
> From: Wen Congyang
>
> This is used by primay to read records sent by secondary.
Acked-by: Ian Jackson
___
Xen-devel mai
I think this will want a review from Andrew Coooper.
etc. I don't see any contributions from Andrew in this thread. In
the absence of a review from Andrew, I don't want to stall this any
further.
Acked-by: Ian Jackson
Thanks,
Ian.
__
Changlong Xie writes ("[PATCH v12 07/26] docs/libxl: Introduce
CHECKPOINT_CONTEXT to support migration v2 colo streams"):
> From: Wen Congyang
Thanks for the additional information in the comments.
Acked-by: Ian Jackson
___
Xen-devel
ith
the interleaving of the colo-specific functionality in the middle of
the restore code, as you have done it. Personally I think it seems
like it's probably the best way, but it may merit questioning, at
least.
Andrew has not replied to object. So I am content that we can
go fo
Changlong Xie writes ("[PATCH v12 16/26] libxc/save: support COLO save"):
> From: Wen Congyang
>
> After suspend primary vm, get dirty bitmap on secondary vm,
> and send pages both dirty on primary/secondary to secondary.
Changlong Xie writes ("[PATCH v12 12/26] secondary vm suspend/resume/checkpoint
code"):
> From: Wen Congyang
Thanks.
This is all fine except for one small thing:
>
> +/* COLO only supports HVM now because it does not work very
> + * well with pv drivers:
> + * 1. We need to resume
Changlong Xie writes ("[PATCH v12 13/26] libxl_internal: move stream read
manipulations to right place"):
> No functional changes and this cleanup will make the later
> patch called "primary vm suspend/resume/checkpoint code" not
> too complicated.
Thanks for split
ddition of a new option to
> 'xl remus' command.
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Changlong Xie writes ("[PATCH v12 14/26] primary vm suspend/resume/checkpoint
code"):
> From: Wen Congyang
...
Thanks. Most of this seems plausible (although I have done a review
of rather limited depth):
However, there are several instances like this:
> +out:
> +libxl__ao_complete(egc, a
Changlong Xie writes ("[PATCH v12 26/26] cmdline switches and config vars to
control colo-proxy"):
> From: Wen Congyang
>
> Add cmdline switches to 'xl migrate-receive' command to specify
> a domain-specific hotplug script to setup COLO proxy.
> +if (nic->forwarddev) {
> +flexarray_
between primary and secondary.
>
> Signed-off-by: Wen Congyang
> Signed-off-by: Yang Hongyang
> Signed-off-by: Changlong Xie
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Changlong Xie writes ("[PATCH v12 24/26] setup and control colo proxy on
primary side"):
> From: Wen Congyang
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Changlong Xie writes ("[PATCH v12 00/26] COarse-grain LOck-stepping Virtual
Machines for Non-stop Service"):
> This patchset implemented the COLO feature for Xen.
> For detail/install/use of COLO feature, refer to:
> http://wiki.xen.org/wiki/COLO_-_Coarse_Grain_Lock_Stepping
Thanks for this resen
colo-proxy module:
> http://www.spinics.net/lists/netdev/msg333520.html
> https://github.com/wencongyang/colo-proxy
> How to use:
> http://wiki.xen.org/wiki/COLO_-_Coarse_Grain_Lock_Stepping
Thanks for the references.
Acked-by: Ian Jackson
___
Changlong Xie writes ("[PATCH v12 25/26] setup and control colo proxy on
secondary side"):
> From: Wen Congyang
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Wen Congyang writes ("Re: [PATCH v11 20/27] Support colo mode for qemu disk"):
> On 03/18/2016 01:18 AM, Ian Jackson wrote:
> > If so, what software, where, arranges for the management of the
> > different qcow2 `layers' ? Ie, what creates the layers; what resynch
ree is identical.
However, the style problems are abolished by the next patch, and the
next patch is now readable, so this is a relatively minor complaint.
Accordingly, even if you do not improve it as I suggeest:
Acked-by: Ian Jackson
If you do impr
Changlong Xie writes ("[PATCH v12 23/26] COLO nic: implement COLO nic subkind"):
> From: Wen Congyang
>
> implement COLO nic subkind.
...
> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index a206d68..a8be078 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libx
to send some records back.
Sorry, missed this one.
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Wei Liu writes ("Re: [PATCH v12 00/26] COarse-grain LOck-stepping Virtual
Machines for Non-stop Service"):
> On Thu, Mar 24, 2016 at 04:21:36PM +, Ian Jackson wrote:
> > Fixing this will involve some code rearrangement and new code. I am
> > worried that this might
rary intermediate file.
> >
> > [0] http://pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html
> >
> > Signed-off-by: Roger Pau Monné
> > Cc: Ian Jackson
> > Cc: Wei Liu
>
> Sorry for breaking this.
>
> Reviewed-by: Andrew Cooper
Committed-by: Ian J
e if it
(a) works and (b) helps.
Ian.
From 162b04ac0dc05e18509caa143c9cb00690193afd Mon Sep 17 00:00:00 2001
From: Ian Jackson
Date: Wed, 30 Mar 2016 11:33:01 +0100
Subject: [OSSTEST PATCH] TestSupport: Move cfg_tftp_di_version from Debian.pm
Strictly speaking this is a Debian-specific function. But i
OINT_END
>
> Signed-off-by: Wen Congyang
> Signed-off-by: Yang Hongyang
> Signed-off-by: Changlong Xie
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
but the general pattern looks
plausible AFAICT.
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Changlong Xie writes ("[PATCH v13.1 20/26] Support colo mode for qemu disk"):
> From 468ff9fb2f6699314c28f30a7d7d09eac9aa6756 Mon Sep 17 00:00:00 2001
> From: Wen Congyang
> Date: Mon, 21 Mar 2016 15:38:30 +0800
> Subject: [PATCH v13.1 20/26] Support colo mode for qemu disk
>
> Usage: disk =
>
Changlong Xie writes ("[PATCH v13.1 23/26] COLO nic: implement COLO nic
subkind"):
> From 699f20d46fcce0bcce8fd7f7063551088a425254 Mon Sep 17 00:00:00 2001
> From: Wen Congyang
> Date: Wed, 15 Jul 2015 17:18:53 +0800
> Subject: [PATCH v13.1 23/26] COLO nic: implement COLO nic subkind
>
> implem
Changlong Xie writes ("[PATCH v13 25/26] setup and control colo proxy on
secondary side"):
> From: Wen Congyang
>
> Signed-off-by: Yang Hongyang
> Signed-off-by: Wen Congyang
> Signed-off-by: Changlong Xie
I think I acked this in v12. I guess you probably overlooked that,
but your v13 00/25
Changlong Xie writes ("[PATCH v13.1 26/26] cmdline switches and config vars to
control colo-proxy"):
> From 1bfd14622455635c6cae6130396250996e49facc Mon Sep 17 00:00:00 2001
> From: Wen Congyang
> Date: Wed, 15 Jul 2015 17:18:56 +0800
> Subject: [PATCH v13.1 26/26] cmdline switches and config va
PATCH v13.1 20/26] Support colo mode for qemu disk
I found a proper copy of this in:
https://github.com/Pating/xen.git#c8284df4eb79
That commit is
Acked-by: Ian Jackson
Ian.
From c8284df4eb79e2f0e2bc82a7f784b4c3d4464f05 Mon Sep 17 00:00:00 2001
From: Wen Congyang
Date: Wed, 15 Jul 2
ne switches and config vars to control
> colo-proxy
I found a proper copy of this in:
https://github.com/Pating/xen.git#27e64fe8a495
That commit is
Acked-by: Ian Jackson
Ian.
From 27e64fe8a4954b5a5628696160471f89a9e6ae6e Mon Sep 17 00:00:00 2001
From: Wen Congyang
Date: Wed, 15 Jul 20
disk
I found a proper copy of this in:
https://github.com/Pating/xen.git#b226be1b0751
That commit is
Acked-by: Ian Jackson
Ian.
From b226be1b0751d675dcd604c4a1dbeec5757bb051 Mon Sep 17 00:00:00 2001
From: Wen Congyang
Date: Mon, 21 Mar 2016 15:38:30 +0800
Subject: [PATCH 21/28] Support colo mod
Ian Jackson writes ("Re: [PATCH v13.1 23/26] COLO nic: implement COLO nic
subkind"):
Sorry, this mail was unclear. I meant to refer to this:
> Changlong Xie writes ("[PATCH v13.1 23/26] COLO nic: implement COLO nic
> subkind"):
> > From 699f20d46fcce0bcce8fd7
Changlong Xie writes ("[PATCH v13 00/26] COarse-grain LOck-stepping Virtual
Machines for Non-stop Service"):
> This patchset implemented the COLO feature for Xen.
> For detail/install/use of COLO feature, refer to:
> http://wiki.xen.org/wiki/COLO_-_Coarse_Grain_Lock_Stepping
>
> You can get the c
Changlong Xie writes ("Re: [PATCH v13 00/26] COarse-grain LOck-stepping Virtual
Machines for Non-stop Service"):
> On 03/25/2016 11:51 PM, Wei Liu wrote:
> > I went over those unacked patches. The major thing I found is that you
> > didn't add in the warning text as Ian suggested. I've pointed out
Joao Martins writes ("[PATCH v2 1/6] public/xen.h: add flags field to
vcpu_time_info"):
> This field has two possible flags (as of latest pvclock ABI
> shared with KVM).
>
> flags: bits in this field indicate extended capabilities
> coordinated between the guest and the hypervisor. Specifically
Doug Goldstein writes ("Re: [PATCH 2/2] tools: detect appropriate debug
optimization level"):
> On 3/8/16 9:38 AM, Wei Liu wrote:
> > On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug Goldstein wrote:
> >> The build should not use -O0 as that results in miscompilations. There
> >
> > This needs some
Ian Jackson writes ("Re: [PATCH 2/2] tools: detect appropriate debug
optimization level"):
> My initial reaction is that I any actual problems are bugs either in
> the compiler or in Xen, which should be fixed.
>
> There should be nothing wrong with lack of inlining or d
Jan Beulich writes ("Re: [Xen-devel] [xen-unstable test] 88047: regressions -
FAIL"):
> On 01.04.16 at 08:12, wrote:
> > Tests which did not succeed and are blocking,
> > including tests which could not be run:
> > test-amd64-i386-libvirt-pair 21 guest-migrate/src_host/dst_host fail REGR.
> > v
Wei Liu writes ("Re: [Xen-users] DomU fails to reboot with storage driver
domain"):
> On Fri, Apr 01, 2016 at 01:04:42PM +0200, Roger Pau Monné wrote:
> > TBH, I don't see an easy way to solve this, I've thought about fetching
> > the "backend" node from the xenstore frontend path of each device,
Wei Liu writes ("[PATCH 0/2] Remaining prerequisite patches for COLO"):
> Konrad Rzeszutek Wilk (1):
> libxc: Document xc_domain_resume
>
> Wen Congyang (1):
> libxc: support to resume uncooperative HVM guests
Committed-by: Ian Jackson
__
Changlong Xie writes ("Re: [PATCH v13 00/26] COarse-grain LOck-stepping Virtual
Machines for Non-stop Service"):
> https://github.com/Pating/xen/tree/changlox/colo_v14
>
> Just add A-B for p12,p14,20,p23,p25,p26 in this version, no other changes.
>
> *Note*, dont merge
> https://github.com/Pati
t but not include relevant header,
> it will cause compile errors just like below:
Thanks for this. I have applied Olaf's version of this patch.
Acked-by: Ian Jackson
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Dario Faggioli writes ("git branch for checking-in leftover patches [was: Re:
[Xen-devel] [PATCH 1/3] xenalyze: handle DOM0 operaions events]"):
> git://xenbits.xen.org/people/dariof/xen.git
> tracing/sched-events-improvements-leftover
> http://xenbits.xen.org/gitweb/?p=people/dariof/xen.git;a=
.
>
> This patch also removes the duplication of code found in the libxc ELF
> loader, since the libelf symtab/strtab loading code will also handle this
> case without having to duplicate it.
>
> Signed-off-by: Roger Pau Monné
> Acked-by: Ian Jackson
Queued, thanks.
Ia
Roger Pau Monné writes ("Re: [PATCH v7] libxl: allow 'phy' backend to use empty
files"):
> This check is done inside of a switch branch that's only used by
> LIBXL_DISK_BACKEND_PHY, so it doesn't assume that every backend can handle
> empty files.
...
> I can move the check to a lower place (aft
Roger Pau Monne writes ("[PATCH v3 4/8] libxl: add support for disk hotplug
scripts on FreeBSD"):
> Allow FreeBSD to execute hotplug scripts when attaching disk devices.
I am going to commit the FreeBSD-only patches without detailed
review, on the basis that you're the expert.
Thanks,
Ian.
the domain type is known. For HVM
> > guests the default value is LIBXL_VGA_INTERFACE_TYPE_CIRRUS while for
> > HVMlite the default value is LIBXL_VGA_INTERFACE_TYPE_NONE.
> >
> > Signed-off-by: Roger Pau Monné
> > ---
> > Cc: Ian Jackson
> > Cc: Ian Campb
t;.
> Pygrub will call this function with "qdisk_direct" set to "false",
> since it can't interpret QDISK backends; this will result in it doing
> a local attach instead.
Thanks for the explanation.
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
h (modifying it so that it's accurate at that point in time)
> and then have this patch update it.
>
> CC: Ian Jackson
> CC: Roger Pau Monne
> CC: Wei Liu
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
> whether to check for qdisk direct access.
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
is can be done either by accessing the local
> disk directly, or by plugging the target disk into dom0 to allow
> access.
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
x27;t initialize dls->disk unless we actually end up doing a local
> attach.
>
> Signed-off-by: George Dunlap
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
n custom hotplug scripts
> and the script called for raw physical devices and files
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
follow-up patches.
>
> Signed-off-by: George Dunlap
> ---
> Changes since v1:
> - Move qemuu disk argument refactoring into a separate patch
Acked-by: Ian Jackson
However, I think that this is going to have a conflict with the colo
series...
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
ed in
to qemu, most likely resulting in qemu exiting with an error. This
will be fixed in follow-up patches.
Signed-off-by: George Dunlap
Signed-off-by: Ian Jackson
---
Changes since v1:
- Move qemuu disk argument refactoring into a separate patch
CC: Ian Jackson
CC: Wei Liu
CC: Stefano Stab
(Firstly, did you not intend to CC tools maintainers on your 0/9 ?)
George Dunlap writes ("[Xen-devel] [PATCH v3 0/9] tools: Allow HVM domains
emulated access to disks provided by hotplug scripts"):
> In order for HVM domains to provide emulated access to disks provided
> by hotplug scripts, qemu
Juergen Gross writes ("[PATCH 0/2] doc: Update
docs/misc/xenstore-paths.markdown"):
> Update some Xenstore path related stuff.
Thanks, pushed.
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Wei Liu writes ("[PATCH 2/2] libxc: use PRIx64 to print out pfn"):
> Pfn is always 64 bit long. Use PRIx64 to avoid truncation.
..
> {
> -PERROR("Invalid pfn 0x%" PRIpfn "", (unsigned long)pfn );
> +PERROR("Invalid pfn 0x%" PRIx64, pfn);
Err, sorry.
Applied both o
Dario Faggioli writes ("Re: [Xen-devel] [xen-unstable test] 88047: regressions
- FAIL"):
> On Fri, 2016-04-01 at 07:44 -0600, Jan Beulich wrote:
> > Might it be worth trying whether that's a deep C-state issue (by
> > temporarily limiting their use of deep C states)?
I'm happy to try this.
> IIR
Wei Liu writes ("[PATCH 1/2] libxc: xc_domain_resume_hvm is used by x86 only"):
> The call site is enclosed by x86 define guards.
>
> Without this patch:
>
> [ 334s] xc_resume.c:112:12: error: 'xc_domain_resume_hvm' defined but not
> used [-Werror=unused-function]
> [ 334s] static int xc_doma
Olaf Hering writes ("[PATCH v10 4/5] libxl: add support for vscsi"):
> Port pvscsi support from xend to libxl:
>
> vscsi=['pdev,vdev{,options}']
> xl scsi-attach
> xl scsi-detach
> xl scsi-list
Thanks for this contribution. I have tried to review it, although I
don't fully understand the und
Olaf Hering writes ("Re: [PATCH v10 4/5] libxl: add support for vscsi"):
> On Fri, Apr 01, Ian Jackson wrote:
> > I'm not sure that this sysfs parsing ought to be in xl rather than
> > libxl. Also, this is Linux-specific code. So it needs to be made
> > condit
libxl_save_helper.c - both of which already have xenctrl.h) I think
I prefer to perhpas-duplicate some #include lines to adding a new
facility to the Perl script (which I would like to keep no more
complex than necessary).
* Better patch title.
Thanks,
Ian.
From ca9654206863224cbf2cc998d8f6a
Ian Jackson writes ("Re: [PATCH] libxl: fix compilation on ARM"):
> Following discussion on irc, here is a v2:
I forgot to update the commit message.
Ian.
From 4cbc583020642d6c333d07e297c52594bb88b542 Mon Sep 17 00:00:00 2001
From: Ian Jackson
Date: Mon, 4 Apr 2016 11:41:19
Wei Liu writes ("Re: [PATCH] libxl: fix compilation on ARM"):
> Acked-by: Wei Liu
Thanks, pushed. Hopefully this will unblock the smoke test.
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Wei Liu writes ("Policy for force pushing smoke branch Was: Re: [Xen-devel]
[xen-unstable-smoke test] 88656: regressions - FAIL"):
> On Mon, Apr 04, 2016 at 01:15:53PM +, osstest service owner wrote:
> > flight 88656 xen-unstable-smoke real [real]
> > http://logs.test-lab.xenproject.org/osstes
Coverity is complaining (eg, CID 1358114) about this code in
_libxl_types.c:
*** CID 1358114: Code maintainability issues (UNUSED_VALUE)
/tools/libxl/_libxl_types.c: 11035 in libxl__device_usbdev_parse_json()
11029 x = libxl__json_map_get("hostaddr", x, JSON_INTEGER);
11030 if (x) {
Coverity complains, rightly, as follows:
> *** CID 1358110: Incorrect expression (SIZEOF_MISMATCH)
> /tools/libxl/libxl_pvusb.c: 1068 in bind_usbintf()
> 1062 if (fd < 0) {
> 1063 LOGE(ERROR, "open file failed: '%s'", path);
> 1064 rc = ERROR_FAIL;
> 1065
In libxl_usb.c, usbintf_get_drvpath calls stat(2) on the driver sysfs
path, and then realpath on the same path.
And bind_usbintf calls stat(2) on the driver directory path, and then
open(2) on a file in that directory.
It seems to be that in both cases, libxl could simply directly access
the targ
scan-ad...@coverity.com writes ("New Defects reported by Coverity Scan for
XenProject"):
> Please find the latest report on new defect(s) introduced to XenProject found
> with Coverity Scan.
>
> 35 new defect(s) introduced to XenProject found with Coverity Scan.
> 2 defect(s), reported by Coverit
Bug introduced in bc023ecd
"libxl_utils: add internal function to read sysfs file contents"
CID: 1358108
Signed-off-by: Ian Jackson
CC: cover...@xenproject.org
CC: Chunyan Liu
---
tools/libxl/libxl_utils.c |1 +
1 file changed, 1 insertion(+)
diff --git a/tools/libxl/libxl_utils
We must set rc before using `goto out'.
Bug introduced in bf7628f0 "libxl: add pvusb API".
CID: 1358113
Signed-off-by: Ian Jackson
CC: cover...@xenproject.org
CC: Simon Cao
CC: George Dunlap
CC: Chunyan Liu
---
tools/libxl/libxl_pvusb.c |1 +
1 file changed, 1 insertion(+
Ian Jackson writes ("Policy for force pushing smoke branch Was: Re: [Xen-devel]
[xen-unstable-smoke test] 88656: regressions - FAIL"):
> Wei Liu writes ("Policy for force pushing smoke branch Was: Re: [Xen-devel]
> [xen-unstable-smoke test] 88656: regressions - FAIL"
George Dunlap writes ("Re: [PATCH v3 5/9] libxl: Rearrange qemu upstream disk
argument code"):
> I looked through the patch in the branch provided in your reply to 0/9
> [1], and it looks correct; morever, I tested it and it and the basic
> functionality (using the "dummy" block script) still work
Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] XSM permissive by default."):
> I presume this patch would be to folks +1:
>
> From 3373a50f386b41eea6ecede4b430e4fa09b2fe7e Mon Sep 17 00:00:00 2001
> From: Konrad Rzeszutek Wilk
> Date: Thu, 10 Mar 2016 12:05:29 -0500
> Subject: [PATCH] flask: By d
Ian Jackson writes ("Policy for force pushing smoke branch Was: Re: [Xen-devel]
[xen-unstable-smoke test] 88656: regressions - FAIL [and 1 more messages]"):
> I'll do a force push to xen.git#master if this is the only blocker,
> too. Also, any necessary force push of the o
Wei Liu writes ("Re: [PATCH] libxl: libxl_domain_create_restore has an extra
argument"):
> CC Jim as well
>
> On Tue, Apr 05, 2016 at 03:20:12PM +0100, Wei Liu wrote:
> > In the latest libxenlight code, libxl_domain_create_restore accepts a
> > new argument. Update libvirt's libxl driver for that
tlink.
>
> Signed-off-by: Wei Liu
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
gt;libxl_internal.h.
>
> Signed-off-by: Wei Liu
Acked-by: Ian Jackson
On the basis that I believe you that this is just code motion.
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
gt;
> > The behaviour that triggers this bug has only been seen on FreeBSD so far.
> >
> > Signed-off-by: Roger Pau Monné
> > Suggested-by: Ian Jackson
>
> Acked-by: Wei Liu
Queued, thanks.
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
ed configure changes as well. Feel free to rerun autogen.sh.
Acked-by: Ian Jackson
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
t; Provide necessary stub functions in case COLO is disabled. This should
> fix build on FreeBSD because there is no netlink there. It would also
> make libxl build properly when netlink is not present on a Linux
> system.
Acked-by: Ian Jackson
__
Andrew Cooper writes ("Re: [PATCH 1/1] libxl: Fix uninitialized pointer when
passing an empty cdrom"):
> On 06/04/16 12:34, George Dunlap wrote:
> > Commit 3fec17d4bb56567d139d7806392f4d8702d3f6a7 introduced a bug where
> > an empty cdrom would cause target_path to be uninitialized. Initialize
>
to make it
> obvious that:
Acked-by: Ian Jackson
And queued, thanks.
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
ibxl: colo: fix indentation of abort()
> libxl: colo: remove dead code in colo_save_setup_script_cb
All five
Acked-by: Ian Jackson
and queued.
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
1 - 100 of 4993 matches
Mail list logo
