Changlong Xie writes ("[PATCH v12 15/26] libxc/restore: support COLO restore"): > From: Wen Congyang <we...@cn.fujitsu.com> > > a. call callbacks resume/checkpoint/suspend while secondary vm > status is consistent with primary > b. send dirty pfn list to primary when checkpoint under colo > c. send store gfn and console gfn to xl before resuming secondary vm
I have reread this and I think the general approach is fine. I'm going to take the detailed semantics on trust. Previously I asked: I'd like some opinion from Andrew Cooper about whether he's happy with the interleaving of the colo-specific functionality in the middle of the restore code, as you have done it. Personally I think it seems like it's probably the best way, but it may merit questioning, at least. Andrew has not replied to object. So I am content that we can go forward with this approach. Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel