[Xen-devel] [linux-4.9 test] 113640: regressions - trouble: blocked/broken/fail/pass

2017-09-21 Thread osstest service owner
flight 113640 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/113640/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt broken build-armhf-pvops

Re: [Xen-devel] [PATCH v8 13/15] xen: make grant resource limits per domain

2017-09-21 Thread Juergen Gross
On 21/09/17 08:15, Jan Beulich wrote: On 21.09.17 at 06:35, wrote: >> On 20/09/17 17:35, Jan Beulich wrote: >> On 20.09.17 at 14:44, wrote: On 20/09/17 13:48, Jan Beulich wrote: On 20.09.17 at 13:10, wrote: >> I thought about a cap and TBH I'm not sure which would be s

[Xen-devel] [PATCH] xen: support 52 bit physical addresses in pv guests

2017-09-21 Thread Juergen Gross
Physical addresses on processors supporting 5 level paging can be up to 52 bits wide. For a Xen pv guest running on such a machine those physical addresses have to be supported in order to be able to use any memory on the machine even if the guest itself does not support 5 level paging. So when re

[Xen-devel] [xen-unstable test] 113638: regressions - FAIL

2017-09-21 Thread osstest service owner
flight 113638 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/113638/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 15 guest-saverestorefail REGR. vs. 113387 Tests which are fa

[Xen-devel] [ovmf baseline-only test] 72134: all pass

2017-09-21 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 72134 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72134/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 947f3737abf65fda63f3ffd97fddfa6986986868 baseline v

[Xen-devel] [distros-debian-wheezy test] 72135: tolerable trouble: broken/pass

2017-09-21 Thread Platform Team regression test user
flight 72135 distros-debian-wheezy real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72135/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: build-arm64 2 hosts-allocate broken like 72105 build-arm64-pvops

[Xen-devel] [PATCH v1] x86: fix bug caused by commit 0ade5e

2017-09-21 Thread Yi Sun
Commit 0ade5e causes a bug that only the psr features presented in cmdline cannot be correctly enumerated. 1. If there is only 'psr=', the CMT is enumerated which is not right. 2. If cmdline is 'psr=cmt,cat,cdp,mba', only the last feature is enumerated. This patch fixes the issues. Signed-off-by:

Re: [Xen-devel] [PATCH qemu-traditional] switch to the new ioreq server API

2017-09-21 Thread Vitaly Kuznetsov
Paul Durrant writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: 06 September 2017 10:29 >> To: xen-devel@lists.xen.org >> Cc: Paul Durrant ; Ian Jackson >> >> Subject: [PATCH qemu-traditional] switch to the new ioreq server API >> >> Instead of

Re: [Xen-devel] [PATCH v3] xen: credit2: fix spinlock irq-safety violation

2017-09-21 Thread Roger Pau Monné
On Thu, Sep 21, 2017 at 02:30:37AM +0200, Dario Faggioli wrote: > In commit ad4b3e1e9df34 ("xen: credit2: implement > utilization cap") xfree() was being called (for > deallocating the budget replenishment timer, during > domain destruction) inside an IRQ disabled critical > section. > > That must

Re: [Xen-devel] pci-passthrough loses msi-x interrupts ability after domain destroy

2017-09-21 Thread Roger Pau Monné
On Wed, Sep 20, 2017 at 03:50:35PM -0400, Jérôme Oufella wrote: > Hi Xen-devel, > > I'm using PCI pass-through to map a PCIe (intel i210) controller into > a HVM domain. The system uses xen-pciback to hide the appropriate PCI > device from Dom0. > > When creating the HVM domain after an hyper

Re: [Xen-devel] [PATCH v1] x86: fix bug caused by commit 0ade5e

2017-09-21 Thread Juergen Gross
On 21/09/17 10:11, Yi Sun wrote: > Commit 0ade5e causes a bug that only the psr features presented in cmdline > cannot be correctly enumerated. > 1. If there is only 'psr=', the CMT is enumerated which is not right. > 2. If cmdline is 'psr=cmt,cat,cdp,mba', only the last feature is enumerated. > >

[Xen-devel] [qemu-mainline test] 113646: regressions - FAIL

2017-09-21 Thread osstest service owner
flight 113646 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/113646/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-amd64 22 leak-check/check fail REGR. vs. 113626 Regressions which

Re: [Xen-devel] [PATCH v3] xen: credit2: fix spinlock irq-safety violation

2017-09-21 Thread George Dunlap
On 09/21/2017 01:30 AM, Dario Faggioli wrote: > In commit ad4b3e1e9df34 ("xen: credit2: implement > utilization cap") xfree() was being called (for > deallocating the budget replenishment timer, during > domain destruction) inside an IRQ disabled critical > section. > > That must not happen, as it

Re: [Xen-devel] [PATCH v12 1/4] x86emul: New return code for unimplemented instruction

2017-09-21 Thread Paul Durrant
> -Original Message- > From: Petre Pircalabu [mailto:ppircal...@bitdefender.com] > Sent: 21 September 2017 06:12 > To: xen-devel@lists.xen.org > Cc: Ian Jackson ; Wei Liu ; > Andrew Cooper ; George Dunlap > ; jbeul...@suse.com; konrad.w...@oracle.com; > sstabell...@kernel.org; Tim (Xen.org)

Re: [Xen-devel] [RFC PATCH V3 1/3] Xen: Increase hap/shadow page pool size to support more vcpus support

2017-09-21 Thread Lan Tianyu
On 2017年09月20日 23:13, Wei Liu wrote: > On Tue, Sep 19, 2017 at 11:06:26AM +0800, Lan Tianyu wrote: >> Hi Wei: >> >> On 2017年09月18日 21:06, Wei Liu wrote: >>> On Wed, Sep 13, 2017 at 12:52:47AM -0400, Lan Tianyu wrote: This patch is to increase page pool size when max vcpu number is larger

Re: [Xen-devel] [PATCH v3] xen: credit2: fix spinlock irq-safety violation

2017-09-21 Thread Wei Liu
On Thu, Sep 21, 2017 at 02:30:37AM +0200, Dario Faggioli wrote: > In commit ad4b3e1e9df34 ("xen: credit2: implement > utilization cap") xfree() was being called (for > deallocating the budget replenishment timer, during > domain destruction) inside an IRQ disabled critical > section. > > That must

Re: [Xen-devel] [PATCH v4 06/11] mkhex: Move it to tools/misc

2017-09-21 Thread Wei Liu
On Wed, Sep 20, 2017 at 06:31:43PM -0400, Konrad Rzeszutek Wilk wrote: > It makes more sense to put a tool to be used by other subsystems > to be in 'tools/misc' along 'mkrpm','mkdeb', etc. > > The patch titled "xen/livepatch/x86/arm32: Force .livepatch.depends > section to be uint32_t aligned" us

Re: [Xen-devel] [PATCH v12 4/4] x86emul: Raise #UD when emulating an unrecognized instruction.

2017-09-21 Thread Paul Durrant
> -Original Message- > From: Petre Pircalabu [mailto:ppircal...@bitdefender.com] > Sent: 21 September 2017 06:12 > To: xen-devel@lists.xen.org > Cc: Ian Jackson ; Wei Liu ; > Andrew Cooper ; George Dunlap > ; jbeul...@suse.com; konrad.w...@oracle.com; > sstabell...@kernel.org; Tim (Xen.org)

[Xen-devel] [ovmf test] 113654: regressions - trouble: blocked/broken/fail/pass

2017-09-21 Thread osstest service owner
flight 113654 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/113654/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-pvopsbroken build-amd64-pvops 4 host-install(4)

Re: [Xen-devel] [PULL 0/2] xen-20170920-tag

2017-09-21 Thread Peter Maydell
On 21 September 2017 at 03:21, Stefano Stabellini wrote: > The following changes since commit b62b7ed0fc9c58e373b8946c9bd2e193be98dae6: > > Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging > (2017-09-20 20:33:48 +0100) > > are available in the git repository at: > > >

[Xen-devel] [libvirt test] 113652: tolerable all pass - PUSHED

2017-09-21 Thread osstest service owner
flight 113652 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/113652/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail like 113616 test-armhf-armhf-libvirt 14 saveresto

Re: [Xen-devel] [PATCH v2 02/21] libxl: introduce a way to mark fields as deprecated in the idl

2017-09-21 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v2 02/21] libxl: introduce a way to mark fields as deprecated in the idl"): > On Wed, Sep 20, 2017 at 04:46:16PM +0100, Ian Jackson wrote: ... > > We discussed how this might be done better. To me it seems like the > > only really plausible alternative was to replace t

[Xen-devel] [ovmf test] 113658: regressions - FAIL

2017-09-21 Thread osstest service owner
flight 113658 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/113658/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 113647 build-i386-xsm

Re: [Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

2017-09-21 Thread Julien Grall
Hi Sameer, On 21/09/17 01:37, Goel, Sameer wrote: [...] diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h index 995a85a..3785fae 100644 --- a/xen/include/xen/lib.h +++ b/xen/include/xen/lib.h @@ -9,7 +9,12 @@ #include #define BUG_ON(p) do { if (unlikely(p)) BUG(); } while (

Re: [Xen-devel] [PATCH v2 2/3] Introduce migration precopy policy

2017-09-21 Thread Roger Pau Monné
On Wed, Sep 20, 2017 at 05:18:16PM +0100, Jennifer Herbert wrote: > On 20/09/17 11:20, Roger Pau Monné wrote: > > On Tue, Sep 19, 2017 at 07:06:26PM +0100, Jennifer Herbert wrote: > > > +? XGS_POLICY_STOP_AND_COPY > > > +: XGS_POLICY_CONTINUE_PRECOPY; > > > +} > > > + > > > +/* > >

Re: [Xen-devel] [PATCH v2 2/3] Introduce migration precopy policy

2017-09-21 Thread Wei Liu
On Thu, Sep 21, 2017 at 12:08:04PM +0100, Roger Pau Monné wrote: > On Wed, Sep 20, 2017 at 05:18:16PM +0100, Jennifer Herbert wrote: > > On 20/09/17 11:20, Roger Pau Monné wrote: > > > On Tue, Sep 19, 2017 at 07:06:26PM +0100, Jennifer Herbert wrote: > > > > +? XGS_POLICY_STOP_AND_COPY > >

[Xen-devel] [PATCH v4] xen: grant-table: Simplify get_paged_frame

2017-09-21 Thread Julien Grall
The implementation of get_paged_frame is currently different whether the architecture support sharing memory or paging memory. Both version are extremely similar so it is possible to consolidate in a single implementation. The main difference is the x86 version will allow grant on foreign page whe

Re: [Xen-devel] [RFC PATCH V3 1/3] Xen: Increase hap/shadow page pool size to support more vcpus support

2017-09-21 Thread Jan Beulich
>>> On 21.09.17 at 10:50, wrote: > On 2017年09月20日 23:13, Wei Liu wrote: >> On Tue, Sep 19, 2017 at 11:06:26AM +0800, Lan Tianyu wrote: >>> Hi Wei: >>> >>> On 2017年09月18日 21:06, Wei Liu wrote: On Wed, Sep 13, 2017 at 12:52:47AM -0400, Lan Tianyu wrote: > This patch is to increase page pool

Re: [Xen-devel] [PATCH v8 13/15] xen: make grant resource limits per domain

2017-09-21 Thread Jan Beulich
>>> On 21.09.17 at 09:53, wrote: > On 21/09/17 08:15, Jan Beulich wrote: > On 21.09.17 at 06:35, wrote: >>> On 20/09/17 17:35, Jan Beulich wrote: >>> On 20.09.17 at 14:44, wrote: > On 20/09/17 13:48, Jan Beulich wrote: > On 20.09.17 at 13:10, wrote: >>> I thought about a

[Xen-devel] [PATCH] xen/perfc: Fix build after commit fc32575968 when CONFIG_PERF_COUNTERS=y

2017-09-21 Thread Julien Grall
The commit fc32575968 "public/sysctl: drop unnecessary typedefs and handles" went a bit too far by replacing all xen_systcl_*_t type to struct xen_sysctl_*. However, xen_sysctl_perfc_val_t was a typedef on uint32_t and therefore is not associated to a structure. Use xen_sysctl_perfc_val_t to fix

Re: [Xen-devel] [PATCH v8 13/15] xen: make grant resource limits per domain

2017-09-21 Thread Juergen Gross
On 21/09/17 13:31, Jan Beulich wrote: On 21.09.17 at 09:53, wrote: >> On 21/09/17 08:15, Jan Beulich wrote: >> On 21.09.17 at 06:35, wrote: On 20/09/17 17:35, Jan Beulich wrote: On 20.09.17 at 14:44, wrote: >> On 20/09/17 13:48, Jan Beulich wrote: >> On 20.09.1

Re: [Xen-devel] [PATCH] xen/perfc: Fix build after commit fc32575968 when CONFIG_PERF_COUNTERS=y

2017-09-21 Thread Wei Liu
On Thu, Sep 21, 2017 at 12:35:17PM +0100, Julien Grall wrote: > The commit fc32575968 "public/sysctl: drop unnecessary typedefs and > handles" went a bit too far by replacing all xen_systcl_*_t type to > struct xen_sysctl_*. > > However, xen_sysctl_perfc_val_t was a typedef on uint32_t and therefo

[Xen-devel] About evtchn and netfront/netback changes

2017-09-21 Thread Kun Cheng
Hello guys, I'm porting some legacy code initially developed in Xen 4.0 and Linux 2.6 to longterm support kernels 3.2.93 and 4.4.88, and Xen 4.6 or 4.8 (not decided yet but that's not the key issue). My legacy work involves dealing with event channel and xen-netfront/netback drivers. However, I fo

Re: [Xen-devel] [PATCH v8 13/15] xen: make grant resource limits per domain

2017-09-21 Thread Jan Beulich
>>> On 21.09.17 at 13:39, wrote: > On 21/09/17 13:31, Jan Beulich wrote: > On 21.09.17 at 09:53, wrote: >>> On 21/09/17 08:15, Jan Beulich wrote: >>> On 21.09.17 at 06:35, wrote: > On 20/09/17 17:35, Jan Beulich wrote: > On 20.09.17 at 14:44, wrote: >>> On 20/09/17 13:48

Re: [Xen-devel] [PATCH v8 13/15] xen: make grant resource limits per domain

2017-09-21 Thread Juergen Gross
On 21/09/17 13:48, Jan Beulich wrote: On 21.09.17 at 13:39, wrote: >> On 21/09/17 13:31, Jan Beulich wrote: >> On 21.09.17 at 09:53, wrote: On 21/09/17 08:15, Jan Beulich wrote: On 21.09.17 at 06:35, wrote: >> On 20/09/17 17:35, Jan Beulich wrote: >> On 20.09.1

Re: [Xen-devel] [PATCH 1/3] python: Add binding for xs_fileno()

2017-09-21 Thread Wei Liu
On Fri, Sep 15, 2017 at 05:35:34PM +0100, Euan Harris wrote: > xs_fileno() returns a file descriptor which receives events when Xenstore > watches fire. Exposing this in the Python bindings is a prerequisite > for writing event-driven clients in Python. > > Signed-off-by: Euan Harris Reviewed-

Re: [Xen-devel] [PATCH 2/3] python: Extract registered watch search logic from xspy_read_watch()

2017-09-21 Thread Wei Liu
On Fri, Sep 15, 2017 at 05:35:35PM +0100, Euan Harris wrote: > tools/python/xen/lowlevel/xs/xs.c | 61 > --- > 1 file changed, 38 insertions(+), 23 deletions(-) > > diff --git a/tools/python/xen/lowlevel/xs/xs.c > b/tools/python/xen/lowlevel/xs/xs.c > index 9

Re: [Xen-devel] [PATCH 3/3] python: Add binding for non-blocking xs_check_watch()

2017-09-21 Thread Wei Liu
On Fri, Sep 15, 2017 at 05:35:36PM +0100, Euan Harris wrote: > xs_check_watch() checks for watch notifications without blocking. > Together with the binding for xs_fileno(), this makes it possible > to write event-driven clients in Python. > > Signed-off-by: Euan Harris Reviewed-by: Wei Liu __

Re: [Xen-devel] [PATCH v4 03/11] livepatch: Include sizes when an mismatch occurs

2017-09-21 Thread Jan Beulich
>>> On 21.09.17 at 00:31, wrote: > If the .bug.frames.X or .livepatch.funcs sizes are different > than what the hypervisor expects - we fail the payload. To help > in diagnosing this include the expected and the payload > sizes. > > Also make it more natural by having "Multiples" in the warning.

Re: [Xen-devel] [PATCH v4 05/11] alternative/x86/arm32: Align altinstructions (and altinstr_replacement) sections.

2017-09-21 Thread Jan Beulich
>>> On 21.09.17 at 00:31, wrote: > @@ -73,6 +75,7 @@ int apply_alternatives(const struct alt_instr *start, const > struct alt_instr *en > #include > > .macro altinstruction_entry orig_offset alt_offset feature orig_len alt_len > + .p2align 2 > .word \orig_offset - . > .word \

Re: [Xen-devel] [PATCH v4 08/11] livepatch/arm/x86: Rename note_depends symbol from test-cases.

2017-09-21 Thread Jan Beulich
>>> On 21.09.17 at 00:31, wrote: > --- a/xen/test/livepatch/Makefile > +++ b/xen/test/livepatch/Makefile > @@ -53,6 +53,7 @@ xen_hello_world.o: config.h livepatch_depends.h > .PHONY: $(LIVEPATCH) > $(LIVEPATCH): xen_hello_world_func.o xen_hello_world.o > $(LD) $(LDFLAGS) $(build_id_linker)

Re: [Xen-devel] [PATCH v4 10/11] livepatch/arm[32, 64]: Modify .livepatch.funcs section to be RW when patching

2017-09-21 Thread Jan Beulich
>>> On 21.09.17 at 00:31, wrote: > @@ -43,7 +46,29 @@ int arch_livepatch_quiesce(void) > return -ENOMEM; > } > > -return 0; > +if ( nfuncs ) > +{ > +unsigned long va = (unsigned long)func; > +unsigned int offs = va & (PAGE_SIZE - 1); > +unsigned

[Xen-devel] [linux-linus test] 113650: regressions - FAIL

2017-09-21 Thread osstest service owner
flight 113650 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/113650/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-examine 5 xen-install fail REGR. vs. 113629 test-amd64-amd64-xl

[Xen-devel] [ovmf test] 113661: regressions - FAIL

2017-09-21 Thread osstest service owner
flight 113661 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/113661/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 113647 build-i386-xsm

[Xen-devel] [PATCH v2 01/16] xen/x86: p2m-pod: Clean-up includes

2017-09-21 Thread Julien Grall
A lot of the headers are not necessary. At the same time, order them in the alphabetical order. Signed-off-by: Julien Grall Acked-by: Andrew Cooper --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Changes in v2: - Add Andrew's acked-by --- xen/arch/x86/mm/p2m-pod.c | 11

[Xen-devel] [PATCH v2 05/16] xen/x86: p2m-pod: Avoid redundant assignments in p2m_pod_demand_populate

2017-09-21 Thread Julien Grall
gfn_aligned is assigned 3 times with the exact same formula. All the variables used are not modified, so consolidate in a single assignment at the beginning of the function. Signed-off-by: Julien Grall Acked-by: Andrew Cooper --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Chan

[Xen-devel] [PATCH v2 11/16] xen/x86: p2m-pod: Clean-up p2m_pod_zero_check

2017-09-21 Thread Julien Grall
Signed-off-by: Julien Grall Acked-by: Andrew Cooper --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Changes in v2: - Add Andrew's acked-by --- xen/arch/x86/mm/p2m-pod.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/mm/p2m-po

[Xen-devel] [PATCH v2 09/16] xen/x86: p2m: Use typesafe GFN in p2m_set_entry

2017-09-21 Thread Julien Grall
Signed-off-by: Julien Grall Acked-by: Andrew Cooper Acked-by: Tamas K Lengyel --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Cc: Tamas K Lengyel Changes in v2: - Add Andrew & Tamas' acked-by - Rename the variable gfn_t to gfn_ to avoid shadowing the type

[Xen-devel] [PATCH v2 15/16] xen/x86: p2m-pod: Rework prototype of p2m_pod_demand_populate

2017-09-21 Thread Julien Grall
- Switch the return type to bool - Remove the parameter p2m_query_t q as it is not used Signed-off-by: Julien Grall Acked-by: Andrew Cooper --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Changes in v2: - Add Andrew's acked-by --- xen/arch/x86/mm/p2m-ept.c | 4

[Xen-devel] [PATCH v2 07/16] xen/x86: p2m-pod: Use typesafe gfn in p2m_pod_decrease_reservation

2017-09-21 Thread Julien Grall
Signed-off-by: Julien Grall Acked-by: Andrew Cooper --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Changes in v2: - Add Andrew's acked-by --- xen/arch/arm/p2m.c | 3 +-- xen/arch/x86/mm/p2m-pod.c| 20 +--- xen/common/memory.c |

[Xen-devel] [PATCH v2 14/16] xen/x86: p2m-pod: Use typesafe gfn for the fields reclaim_single and max_guest

2017-09-21 Thread Julien Grall
Signed-off-by: Julien Grall Acked-by: Andrew Cooper --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Changes in v2: - Add Andrew's acked-by --- xen/arch/x86/mm/p2m-pod.c | 11 +-- xen/include/asm-x86/p2m.h | 4 ++-- 2 files changed, 7 insertions(+), 8 deletions(

[Xen-devel] [PATCH v2 08/16] xen/x86: p2m: Use typesafe gfn for the P2M callbacks get_entry and set_entry

2017-09-21 Thread Julien Grall
Signed-off-by: Julien Grall Acked-by: Andrew Cooper Reviewed-by: Kevin Tian --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Razvan Cojocaru Cc: Tamas K Lengyel Cc: George Dunlap Cc: Jun Nakajima Cc: Kevin Tian Changes in v2: - Add Andre's acked - Add Kevin's reviewed (EPT

[Xen-devel] [PATCH v2 02/16] xen/x86: p2m-pod: Remove trailing whitespaces

2017-09-21 Thread Julien Grall
Signed-off-by: Julien Grall Acked-by: Andrew Cooper --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Changes in v2: - Add Andrew's acked-by --- xen/arch/x86/mm/p2m-pod.c | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-

[Xen-devel] [PATCH v2 06/16] xen/x86: p2m-pod: Clean-up use of typesafe MFN

2017-09-21 Thread Julien Grall
Some unboxing/boxing can be avoided by using mfn_add(...) instead. Signed-off-by: Julien Grall Acked-by: Andrew Cooper --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Changes in v2: - Add Andrew's acked-by --- xen/arch/x86/mm/p2m-pod.c | 10 +- 1 file changed,

[Xen-devel] [PATCH v2 13/16] xen/x86: p2m-pod: Use typesafe gfn in p2m_pod_demand_populate

2017-09-21 Thread Julien Grall
Signed-off-by: Julien Grall Acked-by: Andrew Cooper --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Changes in v2: - Add Andrew's acked-by - Variable gfn_t was renamed to gfn_ in a previous patch. So use the new name --- xen/arch/x86/mm/p2m-ept.c | 5 ++

[Xen-devel] [PATCH v2 10/16] xen/x86: p2m-pod: Use typesafe GFN in pod_eager_record

2017-09-21 Thread Julien Grall
Signed-off-by: Julien Grall Acked-by: Andrew Cooper --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Changes in v2: - Add Andrew's acked-by --- xen/arch/x86/mm/p2m-pod.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/mm/p2m-po

[Xen-devel] [PATCH v2 00/16] xen/x86: Clean-up the PoD code

2017-09-21 Thread Julien Grall
Hi all, I have been attempting to use the PoD code on Arm (it will be sent in a separate series) and spent sometimes to clean-up and switch to typesafe gfn the current code. The PoD code has been tested on Arm (the vervision is slightly different, mostly renaming) and the x86 part as only been bu

[Xen-devel] [PATCH v2 12/16] xen/x86: p2m-pod: Use typesafe gfn in p2m_pod_zero_check

2017-09-21 Thread Julien Grall
At the same time make the array gfns const has it is not modified within the function. Signed-off-by: Julien Grall Acked-by: Andrew Cooper --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Changes in v2: - Add Andrew's acked-by --- xen/arch/x86/mm/p2m-pod.c | 37

[Xen-devel] [PATCH v2 16/16] xen/x86: mem_access: Fix mis-indented line

2017-09-21 Thread Julien Grall
Signed-off-by: Julien Grall --- Cc: Razvan Cojocaru Cc: Tamas K Lengyel Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Changes in v2: - Patch added --- xen/arch/x86/mm/mem_access.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/mm/mem_acc

Re: [Xen-devel] [PATCH v12 1/4] x86emul: New return code for unimplemented instruction

2017-09-21 Thread Jan Beulich
>>> On 21.09.17 at 07:12, wrote: > --- a/xen/arch/x86/x86_emulate/x86_emulate.c > +++ b/xen/arch/x86/x86_emulate/x86_emulate.c > @@ -6195,7 +6196,7 @@ x86_emulate( > /* vpsll{w,d} $imm8,{x,y}mm,{x,y}mm */ > break; > default: > -goto cannot_emulate

Re: [Xen-devel] [PATCH v12 4/4] x86emul: Raise #UD when emulating an unrecognized instruction.

2017-09-21 Thread Jan Beulich
>>> On 21.09.17 at 10:57, wrote: >> From: Petre Pircalabu [mailto:ppircal...@bitdefender.com] >> Sent: 21 September 2017 06:12 >> --- a/xen/arch/x86/hvm/vmx/realmode.c >> +++ b/xen/arch/x86/hvm/vmx/realmode.c >> @@ -106,12 +106,21 @@ void vmx_realmode_emulate_one(struct >> hvm_emulate_ctxt *hvmemu

[Xen-devel] [PATCH v2 04/16] xen/x86: p2m-pod: Fix coding style

2017-09-21 Thread Julien Grall
Also take the opportunity to: - move from 1 << * to 1UL << *. - use unsigned when possible - move from unsigned int -> unsigned long for some induction variables Signed-off-by: Julien Grall Acked-by: Andrew Cooper --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper

[Xen-devel] [PATCH v2 03/16] xen/x86: p2m-pod: Fix coding style for comments

2017-09-21 Thread Julien Grall
Signed-off-by: Julien Grall Acked-by: Andrew Cooper --- Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Changes in v2: - Add Andrew's acked-by --- xen/arch/x86/mm/p2m-pod.c | 154 ++ 1 file changed, 102 insertions(+), 52 deletions

[Xen-devel] [xen-unstable-smoke test] 113662: tolerable all pass - PUSHED

2017-09-21 Thread osstest service owner
flight 113662 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/113662/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [Xen-devel] [PATCH v2 16/16] xen/x86: mem_access: Fix mis-indented line

2017-09-21 Thread Razvan Cojocaru
On 09/21/2017 03:40 PM, Julien Grall wrote: > Signed-off-by: Julien Grall > > --- > > Cc: Razvan Cojocaru > Cc: Tamas K Lengyel > Cc: George Dunlap > Cc: Jan Beulich > Cc: Andrew Cooper Acked-by: Razvan Cojocaru Thanks, Razvan ___ Xen-devel m

Re: [Xen-devel] [PATCH v1] x86: fix bug caused by commit 0ade5e

2017-09-21 Thread Jan Beulich
>>> On 21.09.17 at 10:11, wrote: A better title for the patch is needed. > Commit 0ade5e causes a bug that only the psr features presented in cmdline > cannot be correctly enumerated. To me it looks like either the "only" is wrong here, or the "cannot" was meant to be "can"; the way it's now I

Re: [Xen-devel] [PATCH] xen/perfc: Fix build after commit fc32575968 when CONFIG_PERF_COUNTERS=y

2017-09-21 Thread Jan Beulich
>>> On 21.09.17 at 13:35, wrote: > The commit fc32575968 "public/sysctl: drop unnecessary typedefs and > handles" went a bit too far by replacing all xen_systcl_*_t type to > struct xen_sysctl_*. > > However, xen_sysctl_perfc_val_t was a typedef on uint32_t and therefore > is not associated to a

Re: [Xen-devel] [PATCH v2 16/16] xen/x86: mem_access: Fix mis-indented line

2017-09-21 Thread Jan Beulich
>>> On 21.09.17 at 14:40, wrote: > --- a/xen/arch/x86/mm/mem_access.c > +++ b/xen/arch/x86/mm/mem_access.c > @@ -274,7 +274,7 @@ int p2m_set_altp2m_mem_access(struct domain *d, struct > p2m_domain *hp2m, > } > > return ap2m->set_entry(ap2m, gfn, mfn, PAGE_ORDER_4K, t, a, > -

Re: [Xen-devel] [PATCH 1/2] common/efi: bail if dom0 fails the shim verification step

2017-09-21 Thread Jan Beulich
>>> On 20.09.17 at 22:57, wrote: > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -1226,9 +1226,13 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE > *SystemTable) > efi_bs->FreePool(name.w); > > if ( !EFI_ERROR(efi_bs->LocateProtocol(&shim_lock_guid, NULL

Re: [Xen-devel] [PATCH 2/2] common/efi: give people some time to read messages when debugging

2017-09-21 Thread Jan Beulich
>>> On 20.09.17 at 22:57, wrote: > From: Tamas K Lengyel > > The EFI messages flash by so fast that it is impossible to catch them without > a serial debugger attached. Sometimes though we don't have that available so > having some time to read the messages off the screen is valuable. > > Signe

Re: [Xen-devel] pci-passthrough loses msi-x interrupts ability after domain destroy

2017-09-21 Thread Jan Beulich
>>> On 20.09.17 at 21:50, wrote: > - On Dom0, 'lspci -vv' on that PCIe device between the "working" and > the "muted interrupts" states, I noted a difference between the > MSI-X caps: > > - Capabilities: [70] MSI-X: Enable- Count=5 Masked- <-- IRQs will work if > domain started > + Capabilit

[Xen-devel] [PATCH v4 3/5] ARM: ITS: Deny hardware domain access to ITS

2017-09-21 Thread mjaggi
From: Manish Jaggi This patch extends the gicv3_iomem_deny_access functionality by adding support for ITS region as well. Add function gicv3_its_deny_access. Signed-off-by: Manish Jaggi --- xen/arch/arm/gic-v3-its.c| 22 ++ xen/arch/arm/gic-v3.c| 3 +++

[Xen-devel] [PATCH v4 1/5] ARM: ITS: Introduce common function add_to_host_its_list

2017-09-21 Thread mjaggi
From: Manish Jaggi add_to_host_its_list will update the host_its_list. This common function to be invoked from gicv3_its_dt_init and gic_v3_its_acpi_probe. Signed-off-by: Manish Jaggi Reviewed-by: Andre Przywara Acked-by: Julien Grall --- xen/arch/arm/gic-v3-its.c | 32 --

[Xen-devel] [PATCH v4 0/5] ARM: ACPI: ITS: Add ITS Support for ACPI hardware domain

2017-09-21 Thread mjaggi
From: Manish Jaggi This patch is split into 5 patches. First two add support for updating host_its_list from ACPI MADT table. The rest patches provide support to update the hardware domain MADT table with ITS information. Changes since v3 - Set GICV3_ITS_SIZE as 128K - updated gicv2_get_hwdom_ma

[Xen-devel] [PATCH v4 2/5] ARM: ITS: Populate host_its_list from ACPI MADT Table

2017-09-21 Thread mjaggi
From: Manish Jaggi Added gicv3_its_acpi_init to update host_its_list from MADT table. For ACPI, host_its structure stores dt_node as NULL. Signed-off-by: Manish Jaggi --- xen/arch/arm/gic-v3-its.c| 24 xen/arch/arm/gic-v3.c| 2 ++ xen/include/asm-

[Xen-devel] [PATCH v4 5/5] ARM: ITS: Expose ITS in the MADT table

2017-09-21 Thread mjaggi
From: Manish Jaggi Add gicv3_its_make_hwdom_madt to update hwdom MADT ITS information. Signed-off-by: Manish Jaggi --- xen/arch/arm/gic-v3-its.c| 19 +++ xen/arch/arm/gic-v3.c| 1 + xen/include/asm-arm/gic_v3_its.h | 8 3 files changed, 28 inserti

[Xen-devel] [PATCH v4 4/5] ARM: Introduce get_hwdom_madt_size in gic_hw_operations

2017-09-21 Thread mjaggi
From: Manish Jaggi estimate_acpi_efi_size needs to be updated to provide correct size of hardware domains MADT, which now adds ITS information as well. Introducing gic_get_hwdom_madt_size. Signed-off-by: Manish Jaggi --- xen/arch/arm/domain_build.c | 7 +-- xen/arch/arm/gic-v2.c |

Re: [Xen-devel] [PATCH v6 02/11] vpci: introduce basic handlers to trap accesses to the PCI config space

2017-09-21 Thread Wei Liu
On Tue, Sep 19, 2017 at 04:29:27PM +0100, Roger Pau Monne wrote: > This functionality is going to reside in vpci.c (and the corresponding > vpci.h header), and should be arch-agnostic. The handlers introduced > in this patch setup the basic functionality required in order to trap > accesses to the

Re: [Xen-devel] [PATCH v6 07/11] xen: introduce rangeset_consume_ranges

2017-09-21 Thread Wei Liu
On Tue, Sep 19, 2017 at 04:29:32PM +0100, Roger Pau Monne wrote: > This function allows to iterate over a rangeset while removing the > processed regions. > > It will be used by the following patches in order to store memory > regions in rangesets, and remove them while iterating. > > Signed-off-

Re: [Xen-devel] [PATCH] xen: support 52 bit physical addresses in pv guests

2017-09-21 Thread Boris Ostrovsky
On 09/21/2017 04:01 AM, Juergen Gross wrote: Physical addresses on processors supporting 5 level paging can be up to 52 bits wide. For a Xen pv guest running on such a machine those physical addresses have to be supported in order to be able to use any memory on the machine even if the guest it

Re: [Xen-devel] [PATCH] x86/hvm: Remove unnecessary is_hvm_domain() test in construct_vmcs()

2017-09-21 Thread Roger Pau Monné
On Wed, Sep 20, 2017 at 03:50:27PM -0400, Boris Ostrovsky wrote: > It's a leftover from PVHv1 days. > > Signed-off-by: Boris Ostrovsky Reviewed-by: Roger Pau Monné Thanks, Roger. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.o

Re: [Xen-devel] [PATCH] xen: support 52 bit physical addresses in pv guests

2017-09-21 Thread Juergen Gross
On 21/09/17 16:14, Boris Ostrovsky wrote: > > > On 09/21/2017 04:01 AM, Juergen Gross wrote: >> Physical addresses on processors supporting 5 level paging can be up to >> 52 bits wide. For a Xen pv guest running on such a machine those >> physical addresses have to be supported in order to be abl

Re: [Xen-devel] [PATCH v6 07/11] xen: introduce rangeset_consume_ranges

2017-09-21 Thread Roger Pau Monné
On Thu, Sep 21, 2017 at 02:53:54PM +0100, Wei Liu wrote: > On Tue, Sep 19, 2017 at 04:29:32PM +0100, Roger Pau Monne wrote: > > This function allows to iterate over a rangeset while removing the > > processed regions. > > > > It will be used by the following patches in order to store memory > > re

Re: [Xen-devel] [PATCH v2 2/3] Introduce migration precopy policy

2017-09-21 Thread Roger Pau Monné
On Thu, Sep 21, 2017 at 12:13:55PM +0100, Wei Liu wrote: > On Thu, Sep 21, 2017 at 12:08:04PM +0100, Roger Pau Monné wrote: > > On Wed, Sep 20, 2017 at 05:18:16PM +0100, Jennifer Herbert wrote: > > > On 20/09/17 11:20, Roger Pau Monné wrote: > > > > On Tue, Sep 19, 2017 at 07:06:26PM +0100, Jennife

Re: [Xen-devel] [PATCH v5 06/10] arm: smccc: handle SMCs according to SMCCC

2017-09-21 Thread Julien Grall
On 20/09/17 21:26, Volodymyr Babchuk wrote: On 20.09.17 23:02, Julien Grall wrote: On 20/09/2017 19:11, Volodymyr Babchuk wrote: On 20.09.17 20:21, Julien Grall wrote: On 19/09/17 22:44, Volodymyr Babchuk wrote: Hi Julien, Hi Volodymyr, On 13.09.17 14:11, Julien Grall wrote: Hi,

Re: [Xen-devel] [PATCH v2 02/16] xen/x86: p2m-pod: Remove trailing whitespaces

2017-09-21 Thread Wei Liu
On Thu, Sep 21, 2017 at 01:40:21PM +0100, Julien Grall wrote: > Signed-off-by: Julien Grall > Acked-by: Andrew Cooper > Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 01/16] xen/x86: p2m-pod: Clean-up includes

2017-09-21 Thread Wei Liu
On Thu, Sep 21, 2017 at 01:40:20PM +0100, Julien Grall wrote: > A lot of the headers are not necessary. At the same time, order them in the > alphabetical order. > > Signed-off-by: Julien Grall > Acked-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-

Re: [Xen-devel] [PATCH v2 03/16] xen/x86: p2m-pod: Fix coding style for comments

2017-09-21 Thread Wei Liu
On Thu, Sep 21, 2017 at 01:40:22PM +0100, Julien Grall wrote: > Signed-off-by: Julien Grall > Acked-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 04/16] xen/x86: p2m-pod: Fix coding style

2017-09-21 Thread Wei Liu
On Thu, Sep 21, 2017 at 01:40:23PM +0100, Julien Grall wrote: > Also take the opportunity to: > - move from 1 << * to 1UL << *. > - use unsigned when possible > - move from unsigned int -> unsigned long for some induction > variables > > Signed-off-by: Julien Grall > Acked-by: And

Re: [Xen-devel] [PATCH v2 05/16] xen/x86: p2m-pod: Avoid redundant assignments in p2m_pod_demand_populate

2017-09-21 Thread Wei Liu
On Thu, Sep 21, 2017 at 01:40:24PM +0100, Julien Grall wrote: > gfn_aligned is assigned 3 times with the exact same formula. All the > variables used are not modified, so consolidate in a single assignment > at the beginning of the function. > > Signed-off-by: Julien Grall > Acked-by: Andrew Coop

Re: [Xen-devel] [PATCH v2 06/16] xen/x86: p2m-pod: Clean-up use of typesafe MFN

2017-09-21 Thread Wei Liu
On Thu, Sep 21, 2017 at 01:40:25PM +0100, Julien Grall wrote: > Some unboxing/boxing can be avoided by using mfn_add(...) instead. > > Signed-off-by: Julien Grall > Acked-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@li

Re: [Xen-devel] [PATCH v4 10/11] livepatch/arm[32, 64]: Modify .livepatch.funcs section to be RW when patching

2017-09-21 Thread Julien Grall
Hi Jan, On 21/09/17 13:16, Jan Beulich wrote: On 21.09.17 at 00:31, wrote: @@ -43,7 +46,29 @@ int arch_livepatch_quiesce(void) return -ENOMEM; } -return 0; +if ( nfuncs ) +{ +unsigned long va = (unsigned long)func; +unsigned int offs = va & (PAGE

Re: [Xen-devel] [PATCH 1/2] common/efi: bail if dom0 fails the shim verification step

2017-09-21 Thread Tamas K Lengyel
On Thu, Sep 21, 2017 at 7:03 AM, Jan Beulich wrote: On 20.09.17 at 22:57, wrote: >> --- a/xen/common/efi/boot.c >> +++ b/xen/common/efi/boot.c >> @@ -1226,9 +1226,13 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE >> *SystemTable) >> efi_bs->FreePool(name.w); >> >> i

Re: [Xen-devel] [PATCH v4 10/11] livepatch/arm[32, 64]: Modify .livepatch.funcs section to be RW when patching

2017-09-21 Thread Jan Beulich
>>> On 21.09.17 at 16:58, wrote: > Do you foresee potentially issue of temporarily modifying permissions of > a mapping? It's generally not a good idea imo, but perhaps it's fine here. I assume the page permissions can't be adversely affected despite their hard coding in the function invocations

Re: [Xen-devel] [PATCH v2 16/24] xen/arm: page: Use ARMv8 naming to improve readability

2017-09-21 Thread Julien Grall
Hi, On 20/09/17 00:45, Stefano Stabellini wrote: diff --git a/xen/include/asm-arm/page.h b/xen/include/asm-arm/page.h index 30fcfa0778..899fd1801a 100644 --- a/xen/include/asm-arm/page.h +++ b/xen/include/asm-arm/page.h @@ -26,14 +26,14 @@ * LPAE entry; the 8-bit fields are packed little-endi

Re: [Xen-devel] [PATCH v2 07/16] xen/x86: p2m-pod: Use typesafe gfn in p2m_pod_decrease_reservation

2017-09-21 Thread Wei Liu
On Thu, Sep 21, 2017 at 01:40:26PM +0100, Julien Grall wrote: > Signed-off-by: Julien Grall > Acked-by: Andrew Cooper I wonder how gfn_lock work with the new time without any change, but it appears gfn_lock ignores gfn completely. :-) Reviewed-by: Wei Liu _

Re: [Xen-devel] [PATCH v2 08/16] xen/x86: p2m: Use typesafe gfn for the P2M callbacks get_entry and set_entry

2017-09-21 Thread Wei Liu
On Thu, Sep 21, 2017 at 01:40:27PM +0100, Julien Grall wrote: > Signed-off-by: Julien Grall > Acked-by: Andrew Cooper > Reviewed-by: Kevin Tian > Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-deve

Re: [Xen-devel] [PATCH v2 09/16] xen/x86: p2m: Use typesafe GFN in p2m_set_entry

2017-09-21 Thread Wei Liu
On Thu, Sep 21, 2017 at 01:40:28PM +0100, Julien Grall wrote: > Signed-off-by: Julien Grall > Acked-by: Andrew Cooper > Acked-by: Tamas K Lengyel > Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-de

Re: [Xen-devel] [PATCH v2 10/16] xen/x86: p2m-pod: Use typesafe GFN in pod_eager_record

2017-09-21 Thread Wei Liu
On Thu, Sep 21, 2017 at 01:40:29PM +0100, Julien Grall wrote: > Signed-off-by: Julien Grall > Acked-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 11/16] xen/x86: p2m-pod: Clean-up p2m_pod_zero_check

2017-09-21 Thread Wei Liu
On Thu, Sep 21, 2017 at 01:40:30PM +0100, Julien Grall wrote: > Signed-off-by: Julien Grall > Acked-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

  1   2   >