[Xen-devel] minimum Python version

2017-09-20 Thread Jan Beulich
Hello, for quite a while (apparently as of Marek's series in February) I've been seeing xen/lowlevel/xc/xc.c: In function ‘pyxc_dom_extract_cpuid’: xen/lowlevel/xc/xc.c:692:13: error: implicit declaration of function ‘PyBytes_AS_STRING’ [-Werror=implicit-function-declaration] xen/lowlevel/xc/xc.

Re: [Xen-devel] [PATCH v3 04/15] x86: implement data structure and CPU init flow for MBA

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 05:22, wrote: > On 17-09-19 09:55:28, Roger Pau Monn wrote: >> On Tue, Sep 05, 2017 at 05:32:26PM +0800, Yi Sun wrote: >> > @@ -1389,6 +1480,7 @@ static void psr_cpu_init(void) >> > unsigned int socket, cpu = smp_processor_id(); >> > struct feat_node *feat; >> > s

Re: [Xen-devel] minimum Python version

2017-09-20 Thread Juergen Gross
On 20/09/17 09:00, Jan Beulich wrote: > Hello, > > for quite a while (apparently as of Marek's series in February) I've > been seeing > > xen/lowlevel/xc/xc.c: In function ‘pyxc_dom_extract_cpuid’: > xen/lowlevel/xc/xc.c:692:13: error: implicit declaration of function > ‘PyBytes_AS_STRING’ [-Wer

Re: [Xen-devel] [PATCH v3 14/15] tools: implement new generic set value interface and MBA set value command

2017-09-20 Thread Yi Sun
On 17-09-19 12:30:59, Roger Pau Monn� wrote: > > int libxl_psr_cat_get_cbm(libxl_ctx *ctx, uint32_t domid, > > @@ -458,7 +432,33 @@ int libxl_psr_set_val(libxl_ctx *ctx, uint32_t domid, > >libxl_psr_type type, libxl_bitmap *target_map, > >uint64_t va

Re: [Xen-devel] [PATCH v3 15/15] docs: add MBA description in docs

2017-09-20 Thread Yi Sun
On 17-09-19 12:37:24, Roger Pau Monn� wrote: > On Tue, Sep 05, 2017 at 05:32:37PM +0800, Yi Sun wrote: > > +Intel Skylake and later server platforms offer capabilities to configure > > and > > +make use of the Memory Bandwidth Allocation (MBA) mechanisms, which > > provides > > +OS/VMMs the abili

Re: [Xen-devel] [PATCH v3 04/15] x86: implement data structure and CPU init flow for MBA

2017-09-20 Thread Yi Sun
On 17-09-20 01:11:50, Jan Beulich wrote: > >>> On 20.09.17 at 05:22, wrote: > > On 17-09-19 09:55:28, Roger Pau Monn wrote: > >> On Tue, Sep 05, 2017 at 05:32:26PM +0800, Yi Sun wrote: > >> > @@ -1389,6 +1480,7 @@ static void psr_cpu_init(void) > >> > unsigned int socket, cpu = smp_processor_

Re: [Xen-devel] [RFC] Unicore Subproject Proposal

2017-09-20 Thread Felipe Huici
Hi Lars, Great news, thanks! We sent v2 to the mailing list on the 18th, 2 days ago. When you say “post v2 first”, should we be posting it somewhere else too? Thanks, — Felipe Dr. Felipe Huici Chief Researcher, Networked Systems and D

Re: [Xen-devel] minimum Python version

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 09:20, wrote: > For your case: what about adding a configure option to disable building > the python bindings (and any dependencies like e.g. pygrub) instead of > doing so in case of a version mismatch? This would avoid any surprises > in case someone didn't notice that the bind

Re: [Xen-devel] [PATCH v1] x86/vvmx: add hvm_intsrc_vector support to nvmx_intr_intercept()

2017-09-20 Thread Tian, Kevin
> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] > Sent: Wednesday, September 13, 2017 9:01 PM > > Under the following circumstances: > > 1. L1 doesn't enable PAUSE exiting or PAUSE-loop exiting controls > 2. L2 executes PAUSE in a loop with RFLAGS.IE == 0 > > L1's PV IPI through

[Xen-devel] [distros-debian-squeeze test] 72130: tolerable trouble: broken/fail/pass

2017-09-20 Thread Platform Team regression test user
flight 72130 distros-debian-squeeze real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72130/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: build-arm64-pvops 2 hosts-allocate broken like 72101 build-arm64

Re: [Xen-devel] [PATCH v4 1/1] public/io/netif.h: add gref mapping control messages

2017-09-20 Thread Paul Durrant
> -Original Message- > From: Joao Martins [mailto:joao.m.mart...@oracle.com] > Sent: 19 September 2017 20:08 > To: Xen-devel > Cc: Wei Liu ; Paul Durrant ; > Konrad Rzeszutek Wilk ; Joao Martins > > Subject: [PATCH v4 1/1] public/io/netif.h: add gref mapping control messages > > Adds 3 m

Re: [Xen-devel] [PATCH v8 03/15] xen: add new domctl hypercall to set grant table resource limits

2017-09-20 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of > Juergen Gross > Sent: 20 September 2017 07:34 > To: xen-de...@lists.xenproject.org > Cc: Juergen Gross ; sstabell...@kernel.org; Wei Liu > ; George Dunlap ; > Andrew Cooper ; Ian Jackson > ; Tim (

Re: [Xen-devel] [PATCH] vt-d: use two 32-bit writes to update DMAR fault address registers

2017-09-20 Thread Roger Pau Monné
On Mon, Sep 11, 2017 at 02:00:48PM +0800, Haozhong Zhang wrote: > The 64-bit DMAR fault address is composed of two 32 bits registers > DMAR_FEADDR_REG and DMAR_FEUADDR_REG. According to VT-d spec: > "Software is expected to access 32-bit registers as aligned doublewords", > a hypervisor should use

Re: [Xen-devel] [PATCH v2 2/3] Introduce migration precopy policy

2017-09-20 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of > Jennifer Herbert > Sent: 19 September 2017 19:06 > To: Ian Jackson ; Wei Liu ; > xen-de...@lists.xenproject.org; jto...@uwaterloo.ca > Cc: Jennifer Herbert > Subject: [Xen-devel] [PATCH v2 2/3] I

Re: [Xen-devel] [PATCH v3 01/15] docs: create Memory Bandwidth Allocation (MBA) feature document

2017-09-20 Thread Roger Pau Monné
On Wed, Sep 20, 2017 at 11:06:57AM +0800, Yi Sun wrote: > On 17-09-18 18:16:40, Roger Pau Monn� wrote: > > On Tue, Sep 05, 2017 at 05:32:23PM +0800, Yi Sun wrote: > > > +* xl interfaces: > > > + > > > + 1. `psr-mba-show [domain-id]`: > > > > Is this limited to domain-id, or one can also use the d

Re: [Xen-devel] [PATCH v3 06/15] x86: implement get value interface for MBA

2017-09-20 Thread Roger Pau Monné
On Wed, Sep 20, 2017 at 01:09:06PM +0800, Yi Sun wrote: > On 17-09-19 10:15:42, Roger Pau Monn� wrote: > > On Tue, Sep 05, 2017 at 05:32:28PM +0800, Yi Sun wrote: > > > diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c > > > index 696eff2..7902af7 100644 > > > --- a/xen/arch/x86/domctl.c >

Re: [Xen-devel] minimum Python version

2017-09-20 Thread Juergen Gross
On 20/09/17 09:55, Jan Beulich wrote: On 20.09.17 at 09:20, wrote: >> For your case: what about adding a configure option to disable building >> the python bindings (and any dependencies like e.g. pygrub) instead of >> doing so in case of a version mismatch? This would avoid any surprises >>

Re: [Xen-devel] [PATCH v8 03/15] xen: add new domctl hypercall to set grant table resource limits

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 10:26, wrote: >> -Original Message- >> From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of >> Juergen Gross >> Sent: 20 September 2017 07:34 >> To: xen-de...@lists.xenproject.org >> Cc: Juergen Gross ; sstabell...@kernel.org; Wei Liu >> ; George Dunla

Re: [Xen-devel] [PATCH v2 12/13] [RFC] iommu: VT-d: Squash map_pages/unmap_pages with map_page/unmap_page

2017-09-20 Thread Tian, Kevin
this patch alone looks OK to me. but I haven't found time to review the whole series to judge whether below change is necessary. > From: Oleksandr Tyshchenko [mailto:olekst...@gmail.com] > Sent: Tuesday, September 12, 2017 10:44 PM > > Hi. > > Gentle reminder. > > On Mon, Aug 21, 2017 at 7:44 P

Re: [Xen-devel] [PATCH v3 13/15] tools: implement new generic get value interface and MBA get value command

2017-09-20 Thread Roger Pau Monné
On Wed, Sep 20, 2017 at 02:46:24PM +0800, Yi Sun wrote: > On 17-09-19 12:02:08, Roger Pau Monn� wrote: > > On Tue, Sep 05, 2017 at 05:32:35PM +0800, Yi Sun wrote: > > > +}; > > > char *msg; > > > > > > switch (err) { > > > case ENODEV: > > > -msg = "CAT is not supported

Re: [Xen-devel] [PATCH v8 04/15] xen: add function for obtaining highest possible memory address

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 08:34, wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -6312,6 +6312,17 @@ int pv_ro_page_fault(unsigned long addr, struct > cpu_user_regs *regs) > return 0; > } > > +unsigned long arch_get_upper_mfn_bound(void) > +{ > +unsigned long max_mfn; > + > +

Re: [Xen-devel] [PATCH v8 04/15] xen: add function for obtaining highest possible memory address

2017-09-20 Thread Juergen Gross
On 20/09/17 10:57, Jan Beulich wrote: On 20.09.17 at 08:34, wrote: >> --- a/xen/arch/x86/mm.c >> +++ b/xen/arch/x86/mm.c >> @@ -6312,6 +6312,17 @@ int pv_ro_page_fault(unsigned long addr, struct >> cpu_user_regs *regs) >> return 0; >> } >> >> +unsigned long arch_get_upper_mfn_bound(v

Re: [Xen-devel] [PATCH v8 05/15] xen: add max possible mfn to struct xen_sysctl_physinfo

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 08:34, wrote: > Add the maximum possible mfn to struct xen_sysctl_physinfo in order to > enable Xen tools to size the grant table frame limits for a domU. > > Signed-off-by: Juergen Gross > --- > xen/common/sysctl.c | 1 + > xen/include/public/sysctl.h | 2 ++ > 2 fil

Re: [Xen-devel] [PATCH v8 05/15] xen: add max possible mfn to struct xen_sysctl_physinfo

2017-09-20 Thread Juergen Gross
On 20/09/17 10:58, Jan Beulich wrote: On 20.09.17 at 08:34, wrote: >> Add the maximum possible mfn to struct xen_sysctl_physinfo in order to >> enable Xen tools to size the grant table frame limits for a domU. >> >> Signed-off-by: Juergen Gross >> --- >> xen/common/sysctl.c | 1 + >>

Re: [Xen-devel] [PATCH v3 01/15] docs: create Memory Bandwidth Allocation (MBA) feature document

2017-09-20 Thread Yi Sun
On 17-09-20 09:36:13, Roger Pau Monn� wrote: > On Wed, Sep 20, 2017 at 11:06:57AM +0800, Yi Sun wrote: > > On 17-09-18 18:16:40, Roger Pau Monn� wrote: > > > On Tue, Sep 05, 2017 at 05:32:23PM +0800, Yi Sun wrote: > > > > +* xl interfaces: > > > > + > > > > + 1. `psr-mba-show [domain-id]`: > > >

Re: [Xen-devel] [PATCH v3 13/15] tools: implement new generic get value interface and MBA get value command

2017-09-20 Thread Yi Sun
On 17-09-20 09:57:59, Roger Pau Monn� wrote: > On Wed, Sep 20, 2017 at 02:46:24PM +0800, Yi Sun wrote: > > On 17-09-19 12:02:08, Roger Pau Monn� wrote: > > > On Tue, Sep 05, 2017 at 05:32:35PM +0800, Yi Sun wrote: > > > > +}; > > > > char *msg; > > > > > > > > switch (err) { > > > >

[Xen-devel] [qemu-mainline test] 113613: regressions - FAIL

2017-09-20 Thread osstest service owner
flight 113613 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/113613/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-win7-amd64 18 guest-start/win.repeat fail REGR. vs. 113302 Regressions

Re: [Xen-devel] [PATCH] xen: credit2: fix spinlock irq-safety violation

2017-09-20 Thread Roger Pau Monné
On Tue, Sep 19, 2017 at 04:11:28AM +0200, Dario Faggioli wrote: > In commit ad4b3e1e9df34 ("xen: credit2: implement > utilization cap") xfree() was being called (for > deallocating the budget replenishment timer, during > domain destruction) inside an IRQ disabled critical > section. > > That must

Re: [Xen-devel] [PATCH] xen: credit2: fix spinlock irq-safety violation

2017-09-20 Thread George Dunlap
On 09/19/2017 03:11 AM, Dario Faggioli wrote: > In commit ad4b3e1e9df34 ("xen: credit2: implement > utilization cap") xfree() was being called (for > deallocating the budget replenishment timer, during > domain destruction) inside an IRQ disabled critical > section. > > That must not happen, as it

[Xen-devel] [PATCH v4 0/3] Various XSA followups

2017-09-20 Thread Alexandru Isaila
XSA-219 was discovered while trying to implement the bugfix in patch 3. Andrew Cooper (3): [RFC] x86/hvm: Rename enum hvm_copy_result to hvm_translation_result x86/hvm: Break out __hvm_copy()'s translation logic x86/hvm: Implement hvmemul_write() using real mappings Alexandru Isaila (2): x86/

[Xen-devel] [PATCH v4 2/3] x86/hvm: Break out __hvm_copy()'s translation logic

2017-09-20 Thread Alexandru Isaila
From: Andrew Cooper It will be reused by later changes. Signed-off-by: Andrew Cooper Signed-off-by: Alexandru Isaila Reviewed-by: Paul Durrant Acked-by: Jan Beulich --- xen/arch/x86/hvm/hvm.c| 144 +++--- xen/include/asm-x86/hvm/support.h | 12 ++

[Xen-devel] [PATCH v4 3/3] x86/hvm: Implement hvmemul_write() using real mappings

2017-09-20 Thread Alexandru Isaila
From: Andrew Cooper An access which crosses a page boundary is performed atomically by x86 hardware, albeit with a severe performance penalty. An important corner case is when a straddled access hits two pages which differ in whether a translation exists, or in net access rights. The use of hvm

[Xen-devel] [PATCH v4 1/3] x86/hvm: Rename enum hvm_copy_result to hvm_translation_result

2017-09-20 Thread Alexandru Isaila
From: Andrew Cooper Signed-off-by: Andrew Cooper Acked-by: Tim Deegan Acked-by: Jan Beulich Reviewed-by: Kevin Tian Acked-by: George Dunlap --- xen/arch/x86/hvm/dom0_build.c | 2 +- xen/arch/x86/hvm/emulate.c| 40 ++-- xen/arch/x86/hvm/hvm.c|

Re: [Xen-devel] [PATCH v8 11/15] xen: delay allocation of grant table sub structures

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 08:34, wrote: > @@ -3381,75 +3425,21 @@ grant_table_create( > struct domain *d) > { > struct grant_table *t; > -unsigned int i, j; > > if ( (t = xzalloc(struct grant_table)) == NULL ) > -goto no_mem_0; > +return -ENOMEM; > > /* Simple

Re: [Xen-devel] [PATCH v3 06/15] x86: implement get value interface for MBA

2017-09-20 Thread Yi Sun
On 17-09-20 09:43:40, Roger Pau Monn� wrote: > On Wed, Sep 20, 2017 at 01:09:06PM +0800, Yi Sun wrote: > > On 17-09-19 10:15:42, Roger Pau Monn� wrote: > > > On Tue, Sep 05, 2017 at 05:32:28PM +0800, Yi Sun wrote: > > > > diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c > > > > index 696e

Re: [Xen-devel] [PATCH v8 12/15] xen/arm: move arch specific grant table bits into grant_table.c

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 08:34, wrote: > Instead of attaching the ARM specific grant table data to the domain > structure add it to struct grant_table. Add the needed arch functions > to the asm-*/grant_table.h includes. > > Signed-off-by: Juergen Gross > Reviewed-by: Paul Durrant Non-ARM parts Acke

Re: [Xen-devel] minimum Python version

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 10:49, wrote: > What about the following idea: maybe we could add an option to configure > to make it fail instead of disabling components in case some > requirements for that component are not met? The default could be to > just disable the components and with the option specif

Re: [Xen-devel] [PATCH v4 3/3] x86/hvm: Implement hvmemul_write() using real mappings

2017-09-20 Thread Paul Durrant
> -Original Message- > From: Alexandru Isaila [mailto:aisa...@bitdefender.com] > Sent: 20 September 2017 10:23 > To: xen-devel@lists.xen.org > Cc: Tim (Xen.org) ; George Dunlap > ; jbeul...@suse.com; Andrew Cooper > ; Ian Jackson ; > konrad.w...@oracle.com; sstabell...@kernel.org; Wei Liu >

Re: [Xen-devel] [PATCH v8 04/15] xen: add function for obtaining highest possible memory address

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 10:58, wrote: > On 20/09/17 10:57, Jan Beulich wrote: > On 20.09.17 at 08:34, wrote: >>> --- a/xen/arch/x86/mm.c >>> +++ b/xen/arch/x86/mm.c >>> @@ -6312,6 +6312,17 @@ int pv_ro_page_fault(unsigned long addr, struct > cpu_user_regs *regs) >>> return 0; >>> } >>> >>

Re: [Xen-devel] [PATCH v8 04/15] xen: add function for obtaining highest possible memory address

2017-09-20 Thread Juergen Gross
On 20/09/17 11:32, Jan Beulich wrote: On 20.09.17 at 10:58, wrote: >> On 20/09/17 10:57, Jan Beulich wrote: >> On 20.09.17 at 08:34, wrote: --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -6312,6 +6312,17 @@ int pv_ro_page_fault(unsigned long addr, struct >> cpu_user_r

Re: [Xen-devel] [PATCH v4 1/3] x86/hvm: Rename enum hvm_copy_result to hvm_translation_result

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 11:22, wrote: > From: Andrew Cooper > > Signed-off-by: Andrew Cooper > Acked-by: Tim Deegan > Acked-by: Jan Beulich > Reviewed-by: Kevin Tian > Acked-by: George Dunlap I'm sorry to say that, but this time you've lost Paul's R-b. Please pay more attention to such aspects

Re: [Xen-devel] [PATCH v8 11/15] xen: delay allocation of grant table sub structures

2017-09-20 Thread Juergen Gross
On 20/09/17 11:22, Jan Beulich wrote: On 20.09.17 at 08:34, wrote: >> @@ -3381,75 +3425,21 @@ grant_table_create( >> struct domain *d) >> { >> struct grant_table *t; >> -unsigned int i, j; >> >> if ( (t = xzalloc(struct grant_table)) == NULL ) >> -goto no_mem_0;

Re: [Xen-devel] [PATCH v8 11/15] xen: delay allocation of grant table sub structures

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 11:44, wrote: > On 20/09/17 11:22, Jan Beulich wrote: > On 20.09.17 at 08:34, wrote: >>> @@ -3381,75 +3425,21 @@ grant_table_create( >>> struct domain *d) >>> { >>> struct grant_table *t; >>> -unsigned int i, j; >>> >>> if ( (t = xzalloc(struct grant_t

Re: [Xen-devel] [PATCH v8 11/15] xen: delay allocation of grant table sub structures

2017-09-20 Thread Juergen Gross
On 20/09/17 12:02, Jan Beulich wrote: On 20.09.17 at 11:44, wrote: >> On 20/09/17 11:22, Jan Beulich wrote: >> On 20.09.17 at 08:34, wrote: @@ -3381,75 +3425,21 @@ grant_table_create( struct domain *d) { struct grant_table *t; -unsigned int i, j; >

Re: [Xen-devel] [PATCH] xen: credit2: fix spinlock irq-safety violation

2017-09-20 Thread George Dunlap
On 09/20/2017 10:19 AM, George Dunlap wrote: > On 09/19/2017 03:11 AM, Dario Faggioli wrote: >> In commit ad4b3e1e9df34 ("xen: credit2: implement >> utilization cap") xfree() was being called (for >> deallocating the budget replenishment timer, during >> domain destruction) inside an IRQ disabled c

Re: [Xen-devel] [PATCH v8 13/15] xen: make grant resource limits per domain

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 08:34, wrote: > --- a/xen/common/compat/grant_table.c > +++ b/xen/common/compat/grant_table.c > @@ -157,21 +157,14 @@ int compat_grant_table_op(unsigned int cmd, > unsigned int max_frame_list_size_in_page = > (COMPAT_ARG_XLAT_SIZE - sizeof(*

Re: [Xen-devel] [PATCH 1/2] public/domctl: drop unnecessary typedefs and handles

2017-09-20 Thread George Dunlap
On Tue, Sep 12, 2017 at 4:08 PM, Jan Beulich wrote: > By virtue of the struct xen_domctl container structure, most of them > are really just cluttering the name space. > > While doing so, > - convert an enum typed (pt_irq_type_t) structure field to a fixed > width type, > - make x86's paging_dom

Re: [Xen-devel] [PATCH 2/2] public/sysctl: drop unnecessary typedefs and handles

2017-09-20 Thread George Dunlap
On Tue, Sep 12, 2017 at 4:10 PM, Jan Beulich wrote: > By virtue of the struct xen_sysctl container structure, most of them > are really just cluttering the name space. > > Signed-off-by: Jan Beulich Acked-by: George Dunlap > > --- a/tools/libxc/include/xenctrl.h > +++ b/tools/libxc/include/xen

[Xen-devel] [xen-unstable-coverity test] 113625: all pass - PUSHED

2017-09-20 Thread osstest service owner
flight 113625 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/113625/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 64cf3181e4d469a8bd7e7dee8ff2d3bf5b45f4b0 baseline version: xen abd9

Re: [Xen-devel] [PATCH v2 2/3] Introduce migration precopy policy

2017-09-20 Thread Roger Pau Monné
On Tue, Sep 19, 2017 at 07:06:26PM +0100, Jennifer Herbert wrote: > This Patch allows a migration precopy policy to be specified. > > The precopy phase of the xc_domain_save() live migration algorithm has > historically been implemented to run until either a) (almost) no pages > are dirty or b) so

Re: [Xen-devel] [PATCH 0/2] public/*ctl: drop unnecessary typedefs and handles

2017-09-20 Thread Julien Grall
Hi, On 12/09/17 15:25, Jan Beulich wrote: 1: public/domctl: drop unnecessary typedefs and handles 2: public/sysctl: drop unnecessary typedefs and handles Signed-off-by: Jan Beulich For the ARM changes: Acked-by: Julien Grall Cheers, -- Julien Grall __

Re: [Xen-devel] [PATCH v8 13/15] xen: make grant resource limits per domain

2017-09-20 Thread Juergen Gross
On 20/09/17 12:34, Jan Beulich wrote: On 20.09.17 at 08:34, wrote: >> --- a/xen/common/compat/grant_table.c >> +++ b/xen/common/compat/grant_table.c >> @@ -157,21 +157,14 @@ int compat_grant_table_op(unsigned int cmd, >> unsigned int max_frame_list_size_in_page = >>

Re: [Xen-devel] minimum Python version

2017-09-20 Thread Ian Jackson
Jan Beulich writes ("minimum Python version"): > for quite a while (apparently as of Marek's series in February) I've > been seeing > > xen/lowlevel/xc/xc.c: In function ‘pyxc_dom_extract_cpuid’: > xen/lowlevel/xc/xc.c:692:13: error: implicit declaration of function > ‘PyBytes_AS_STRING’ [-Werror

Re: [Xen-devel] minimum Python version

2017-09-20 Thread Ian Jackson
Jan Beulich writes ("Re: [Xen-devel] minimum Python version"): > On 20.09.17 at 10:49, wrote: > > What about the following idea: maybe we could add an option to configure > > to make it fail instead of disabling components in case some > > requirements for that component are not met? The default c

Re: [Xen-devel] [PATCH v2 3/3] RFC: migration: defer precopy policy to libxl

2017-09-20 Thread Roger Pau Monné
On Tue, Sep 19, 2017 at 07:06:27PM +0100, Jennifer Herbert wrote: > Provide an implementation of the old policy as a callback in > libxl and plumb it through the IPC machinery to libxc. > > This serves as an example for defining a libxl policy, > and provides no advantage over the default policy i

Re: [Xen-devel] [PATCH v2] xen: grant-table: Simplify get_paged_frame

2017-09-20 Thread Julien Grall
Hi Roger, On 19/09/17 12:40, Roger Pau Monné wrote: On Tue, Sep 19, 2017 at 10:44:53AM +0100, Julien Grall wrote: Hi, On 19/09/17 08:13, Roger Pau Monné wrote: On Mon, Sep 18, 2017 at 06:32:22PM +0100, Julien Grall wrote: Hi Roger, On 18/09/17 17:58, Roger Pau Monné wrote: On Mon, Sep 18,

Re: [Xen-devel] [PATCH 0/2] public/*ctl: drop unnecessary typedefs and handles

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 13:07, wrote: > On 12/09/17 15:25, Jan Beulich wrote: >> 1: public/domctl: drop unnecessary typedefs and handles >> 2: public/sysctl: drop unnecessary typedefs and handles >> >> Signed-off-by: Jan Beulich > > For the ARM changes: > > Acked-by: Julien Grall Thanks, but I ha

Re: [Xen-devel] [PATCH] xen: credit2: fix spinlock irq-safety violation

2017-09-20 Thread Dario Faggioli
On Wed, 2017-09-20 at 11:04 +0100, George Dunlap wrote: > On 09/20/2017 10:19 AM, George Dunlap wrote: > > > diff --git a/xen/common/sched_credit2.c > > > b/xen/common/sched_credit2.c > > > index 32234ac..7a550db 100644 > > > --- a/xen/common/sched_credit2.c > > > +++ b/xen/common/sched_credit2.c >

Re: [Xen-devel] [PATCH v8 13/15] xen: make grant resource limits per domain

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 13:10, wrote: > On 20/09/17 12:34, Jan Beulich wrote: > On 20.09.17 at 08:34, wrote: >>> --- a/xen/common/compat/grant_table.c >>> +++ b/xen/common/compat/grant_table.c >>> @@ -157,21 +157,14 @@ int compat_grant_table_op(unsigned int cmd, >>> unsigned int m

[Xen-devel] [libvirt test] 113616: tolerable all pass - PUSHED

2017-09-20 Thread osstest service owner
flight 113616 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/113616/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail like 113592 test-armhf-armhf-libvirt 14 saveresto

Re: [Xen-devel] [PATCH] xen: credit2: fix spinlock irq-safety violation

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 13:44, wrote: > IAC, if you're concerned about that, I'd much rather put both > kill_timer() and xfree() before the critical section, rather than > after, like in the attached patch. Hmm, killing the timer upfront is certainly fine, but is freeing the data before removing the e

Re: [Xen-devel] [PATCH v8 14/15] xen: make grant table limits boot parameters dom0 only

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 08:34, wrote: > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -2098,7 +2098,7 @@ static void __init find_gnttab_region(struct domain *d, > kinfo->gnttab_size = (_etext - _stext) & PAGE_MASK; > > /* Make sure the grant table will fit in th

Re: [Xen-devel] [PATCH v8 15/15] xen: add new Xen cpuid node for max address width info

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 08:34, wrote: > On very large hosts a guest needs to know whether it will have to ... a PV guest ... > handle frame numbers larger than 32 bits in order to select the > appropriate grant interface version. > > Add a new Xen specific CPUID node to contain the maximum guest add

[Xen-devel] [linux-linus test] 113615: regressions - FAIL

2017-09-20 Thread osstest service owner
flight 113615 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/113615/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-vhd 6 xen-install fail REGR. vs. 113605 Regressions which a

Re: [Xen-devel] [PATCH v4 3/3] x86/hvm: Implement hvmemul_write() using real mappings

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 11:22, wrote: > +static void *hvmemul_map_linear_addr( > +unsigned long linear, unsigned int bytes, uint32_t pfec, > +struct hvm_emulate_ctxt *hvmemul_ctxt) > +{ > +struct vcpu *curr = current; > +void *err, *mapping; > + > +/* First and final gfns which need

[Xen-devel] Ping: [PATCH v4 1/3] x86/hvm: Rename enum hvm_copy_result to hvm_translation_result

2017-09-20 Thread Jan Beulich
>>> On 20.09.17 at 11:22, wrote: > From: Andrew Cooper > > Signed-off-by: Andrew Cooper > Acked-by: Tim Deegan > Acked-by: Jan Beulich > Reviewed-by: Kevin Tian > Acked-by: George Dunlap > --- > xen/arch/x86/hvm/dom0_build.c | 2 +- > xen/arch/x86/hvm/emulate.c| 40 +++

Re: [Xen-devel] [PATCH v4 3/3] x86/hvm: Implement hvmemul_write() using real mappings

2017-09-20 Thread Alexandru Stefan ISAILA
On Mi, 2017-09-20 at 06:24 -0600, Jan Beulich wrote: > > > > > > > > > > > > > On 20.09.17 at 11:22, wrote: > > +static void *hvmemul_map_linear_addr( > > +unsigned long linear, unsigned int bytes, uint32_t pfec, > > +struct hvm_emulate_ctxt *hvmemul_ctxt) > > +{ > > +struct vcpu *curr

Re: [Xen-devel] [PATCH v8 01/15] xen: move XENMAPSPACE_grant_table code into grant_table.c

2017-09-20 Thread Julien Grall
Hi Juergen, On 20/09/17 07:34, Juergen Gross wrote: The x86 and arm versions of XENMAPSPACE_grant_table handling are nearly identical. Move the code into a function in grant_table.c and add an architecture dependant hook to handle the differences. Switch to mfn_t in order to be more type safe.

Re: [Xen-devel] [PATCH v8 13/15] xen: make grant resource limits per domain

2017-09-20 Thread Juergen Gross
On 20/09/17 13:48, Jan Beulich wrote: On 20.09.17 at 13:10, wrote: >> On 20/09/17 12:34, Jan Beulich wrote: >> On 20.09.17 at 08:34, wrote: --- a/xen/common/compat/grant_table.c +++ b/xen/common/compat/grant_table.c @@ -1777,13 +1784,15 @@ active_alloc_failed:

Re: [Xen-devel] [PATCH v8 14/15] xen: make grant table limits boot parameters dom0 only

2017-09-20 Thread Juergen Gross
On 20/09/17 14:07, Jan Beulich wrote: On 20.09.17 at 08:34, wrote: >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -2098,7 +2098,7 @@ static void __init find_gnttab_region(struct domain *d, >> kinfo->gnttab_size = (_etext - _stext) & PAGE_MASK; >> >>

Re: [Xen-devel] [PATCH v8 04/15] xen: add function for obtaining highest possible memory address

2017-09-20 Thread Julien Grall
Hi Juergen, Sorry for the late comment. On 20/09/17 07:34, Juergen Gross wrote: Add a function for obtaining the highest possible physical memory address of the system. This value is influenced by: - hypervisor configuration (CONFIG_BIGMEM) - processor capability (max. addressable physical mem

Re: [Xen-devel] [PATCH v8 05/15] xen: add max possible mfn to struct xen_sysctl_physinfo

2017-09-20 Thread Julien Grall
Hi Juergen, On 20/09/17 07:34, Juergen Gross wrote: Add the maximum possible mfn to struct xen_sysctl_physinfo in order to enable Xen tools to size the grant table frame limits for a domU Signed-off-by: Juergen Gross --- xen/common/sysctl.c | 1 + xen/include/public/sysctl.h | 2 ++

Re: [Xen-devel] [PATCH v11 3/5] x86emul: Add return code information to error messages

2017-09-20 Thread Petre Ovidiu PIRCALABU
On Ma, 2017-09-19 at 09:22 -0600, Jan Beulich wrote: > > > > > > > > > > > > > On 12.09.17 at 16:32, wrote: > > --- a/xen/arch/x86/hvm/emulate.c > > +++ b/xen/arch/x86/hvm/emulate.c > > @@ -2055,7 +2055,7 @@ int hvm_emulate_one_mmio(unsigned long mfn, > > unsigned long gla) > >  { > >  

Re: [Xen-devel] [PATCH v8 15/15] xen: add new Xen cpuid node for max address width info

2017-09-20 Thread Juergen Gross
On 20/09/17 14:18, Jan Beulich wrote: On 20.09.17 at 08:34, wrote: >> On very large hosts a guest needs to know whether it will have to > > ... a PV guest ... What about a HVM guest with (potentially) more than 16TB? >> handle frame numbers larger than 32 bits in order to select the >> app

Re: [Xen-devel] [PATCH v8 15/15] xen: add new Xen cpuid node for max address width info

2017-09-20 Thread Julien Grall
Hi Juergen, On 20/09/17 07:34, Juergen Gross wrote: On very large hosts a guest needs to know whether it will have to handle frame numbers larger than 32 bits in order to select the appropriate grant interface version. Can you explain why you decided to have an arch specific interface rather

Re: [Xen-devel] Ping: [PATCH v4 1/3] x86/hvm: Rename enum hvm_copy_result to hvm_translation_result

2017-09-20 Thread Boris Ostrovsky
On 09/20/2017 08:29 AM, Jan Beulich wrote: On 20.09.17 at 11:22, wrote: >> From: Andrew Cooper >> >> Signed-off-by: Andrew Cooper >> Acked-by: Tim Deegan >> Acked-by: Jan Beulich >> Reviewed-by: Kevin Tian >> Acked-by: George Dunlap >> --- >> xen/arch/x86/hvm/dom0_build.c | 2 +- >

Re: [Xen-devel] [PATCH v8 05/15] xen: add max possible mfn to struct xen_sysctl_physinfo

2017-09-20 Thread Juergen Gross
On 20/09/17 14:53, Julien Grall wrote: > Hi Juergen, > > On 20/09/17 07:34, Juergen Gross wrote: >> Add the maximum possible mfn to struct xen_sysctl_physinfo in order to >> enable Xen tools to size the grant table frame limits for a domU >> >> Signed-off-by: Juergen Gross >> --- >>   xen/common/

Re: [Xen-devel] [PATCH v8 04/15] xen: add function for obtaining highest possible memory address

2017-09-20 Thread Juergen Gross
On 20/09/17 14:51, Julien Grall wrote: > Hi Juergen, > > Sorry for the late comment. > > On 20/09/17 07:34, Juergen Gross wrote: >> Add a function for obtaining the highest possible physical memory >> address of the system. This value is influenced by: >> >> - hypervisor configuration (CONFIG_BIG

Re: [Xen-devel] [PATCH] xen: credit2: fix spinlock irq-safety violation

2017-09-20 Thread George Dunlap
On 09/20/2017 12:59 PM, Jan Beulich wrote: On 20.09.17 at 13:44, wrote: >> IAC, if you're concerned about that, I'd much rather put both >> kill_timer() and xfree() before the critical section, rather than >> after, like in the attached patch. > > Hmm, killing the timer upfront is certainly

Re: [Xen-devel] [PATCH v3 06/17] xen/livepatch/x86/arm32: Force .livepatch.depends section to be uint32_t aligned.

2017-09-20 Thread Wei Liu
On Tue, Sep 19, 2017 at 12:05:16PM +0100, Julien Grall wrote: > Hi Konrad, > > On 19/09/17 01:32, Konrad Rzeszutek Wilk wrote: > > > > +.PHONY: livepatch_depends.h > > > > +livepatch_depends.h: note.bin > > > > + $(shell (../../../tools/firmware/hvmloader/mkhex > > > > $(NOTE_DEPENDS) $^ >

Re: [Xen-devel] [PATCH v8 04/15] xen: add function for obtaining highest possible memory address

2017-09-20 Thread Julien Grall
Hi Juergen, On 20/09/17 14:08, Juergen Gross wrote: On 20/09/17 14:51, Julien Grall wrote: Hi Juergen, Sorry for the late comment. On 20/09/17 07:34, Juergen Gross wrote: Add a function for obtaining the highest possible physical memory address of the system. This value is influenced by: -

Re: [Xen-devel] [PATCH v8 12/15] xen/arm: move arch specific grant table bits into grant_table.c

2017-09-20 Thread Julien Grall
Hi Juergen, On 20/09/17 07:34, Juergen Gross wrote: diff --git a/xen/include/asm-arm/grant_table.h b/xen/include/asm-arm/grant_table.h index 0a248a765a..0870b5b782 100644 --- a/xen/include/asm-arm/grant_table.h +++ b/xen/include/asm-arm/grant_table.h @@ -6,6 +6,10 @@ #define INITIAL_NR_GRA

Re: [Xen-devel] [PATCH v8 04/15] xen: add function for obtaining highest possible memory address

2017-09-20 Thread Juergen Gross
On 20/09/17 16:24, Julien Grall wrote: > Hi Juergen, > > On 20/09/17 14:08, Juergen Gross wrote: >> On 20/09/17 14:51, Julien Grall wrote: >>> Hi Juergen, >>> >>> Sorry for the late comment. >>> >>> On 20/09/17 07:34, Juergen Gross wrote: Add a function for obtaining the highest possible phys

Re: [Xen-devel] [PATCH v8 13/15] xen: make grant resource limits per domain

2017-09-20 Thread Julien Grall
Hi Jan, On 20/09/17 11:34, Jan Beulich wrote: On 20.09.17 at 08:34, wrote: --- a/xen/include/asm-arm/grant_table.h +++ b/xen/include/asm-arm/grant_table.h @@ -26,8 +26,8 @@ static inline int replace_grant_supported(void) return 1; } -#define gnttab_init_arch(gt)

Re: [Xen-devel] [PATCH 1/2] public/domctl: drop unnecessary typedefs and handles

2017-09-20 Thread Tamas K Lengyel
On Tue, Sep 12, 2017 at 9:08 AM, Jan Beulich wrote: > By virtue of the struct xen_domctl container structure, most of them > are really just cluttering the name space. > > While doing so, > - convert an enum typed (pt_irq_type_t) structure field to a fixed > width type, > - make x86's paging_dom

Re: [Xen-devel] [PATCH v2 03/21] libxl/xl: use the new domain_build_info fields position

2017-09-20 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v2 03/21] libxl/xl: use the new domain_build_info fields position"): > This is required because those options will be used by the new PVH > guest type, and thus need to be shared between PV and HVM. ... > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > inde

Re: [Xen-devel] [PATCH v2 04/21] xl: introduce a domain type option

2017-09-20 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v2 04/21] xl: introduce a domain type option"): > Introduce a new type option to xl configuration files in order to > specify the domain type. This supersedes the current builder option. ...> > Th > libxl_defbool_set(&c_info->run_hotplug_scripts, run_hotplug_sc

Re: [Xen-devel] [PATCH v2 05/21] xl: introduce a firmware option

2017-09-20 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v2 05/21] xl: introduce a firmware option"): > The new firmware option aims to provide a coherent way to set the > firmware for the different kind of guests Xen supports. ... > +=head3 Non direct Kernel Boot > + > +Non direct kernel boot allows booting guests with a

Re: [Xen-devel] [PATCH 1/2] xen: add a global indicator for grant copy being available

2017-09-20 Thread Anthony PERARD
On Tue, Sep 19, 2017 at 01:50:54PM +0200, Juergen Gross wrote: > The Xen qdisk backend needs to test whether grant copy operations is > available in the kernel. Unfortunately this collides with using > xengnttab_set_max_grants() on some kernels as this operation has to > be the first one after open

Re: [Xen-devel] [PATCH 2/2] xen: dont try setting max grants multiple times

2017-09-20 Thread Anthony PERARD
On Tue, Sep 19, 2017 at 01:50:55PM +0200, Juergen Gross wrote: > Trying to call xengnttab_set_max_grants() with the same file handle > might fail on some kernels, as this operation is allowed only once. > > This is a problem for the qdisk backend as blk_connect() can be > called multiple times for

Re: [Xen-devel] [PATCH] libxl: provide typedefs for device framework functions

2017-09-20 Thread Wei Liu
On Fri, Sep 15, 2017 at 12:01:56PM +0100, Wei Liu wrote: > Use the new typedefs to avoid copy-n-paste everywhere. > > No functional change. > > Signed-off-by: Wei Liu I'm going to wait until Friday to apply this patch. ___ Xen-devel mailing list Xen-

[Xen-devel] [PATCH] x86/PV: fix/generalize guest nul selector handling

2017-09-20 Thread Jan Beulich
FS/GS base (and limit) aren't being cleared by the loading of a nul selector into the segment register on AMD CPUs. Therefore, if an outgoing vCPU has a non-null base in one of these registers and the subsequent incoming vCPU has a non-zero but nul selector in the respective register(s), the select

Re: [Xen-devel] [PATCH] build: propagate runstatedir

2017-09-20 Thread Wei Liu
On Wed, Sep 13, 2017 at 10:11:25AM +0100, Wei Liu wrote: > On Wed, Sep 13, 2017 at 11:07:15AM +0200, Juergen Gross wrote: > > On 13/09/17 10:52, Wei Liu wrote: > > > Debian Stretch's autoconf has a new variable called runstatedir. Add > > > that to Paths.mk.in. > > > > > > Signed-off-by: Wei Liu

Re: [Xen-devel] [PATCH v2 3/5] xen/livepatch/ARM32: Don't load and crash on livepatches loaded with wrong alignment.

2017-09-20 Thread Konrad Rzeszutek Wilk
On Tue, Sep 19, 2017 at 09:04:44AM -0600, Jan Beulich wrote: > >>> On 18.09.17 at 21:37, wrote: > > On Tue, Sep 12, 2017 at 02:57:04AM -0600, Jan Beulich wrote: > >> >>> On 12.09.17 at 02:22, wrote: > >> > If I compile the test-case under ARM32 it works OK (as the > >> > .livepatch.depends ends u

Re: [Xen-devel] [RFC PATCH V3 1/3] Xen: Increase hap/shadow page pool size to support more vcpus support

2017-09-20 Thread Wei Liu
On Tue, Sep 19, 2017 at 11:06:26AM +0800, Lan Tianyu wrote: > Hi Wei: > > On 2017年09月18日 21:06, Wei Liu wrote: > > On Wed, Sep 13, 2017 at 12:52:47AM -0400, Lan Tianyu wrote: > >> This patch is to increase page pool size when max vcpu number is larger > >> than 128. > >> > >> Signed-off-by: Lan Ti

[Xen-devel] [ovmf test] 113621: all pass - PUSHED

2017-09-20 Thread osstest service owner
flight 113621 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/113621/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 70dc3ec5a72e0e3fc3ea8f63baecdeafd1110db8 baseline version: ovmf 424a5ec33b3d5a842bff3

Re: [Xen-devel] Booting signed xen.efi through shim

2017-09-20 Thread Tamas K Lengyel
On Wed, Sep 20, 2017 at 12:30 AM, Jan Beulich wrote: On 20.09.17 at 00:23, wrote: >> On Mon, Sep 18, 2017 at 2:58 AM, Jan Beulich wrote: >> On 14.09.17 at 18:20, wrote: Of course, you can grab them from here: https://drive.google.com/drive/folders/0B5duyI9SzNtWaXE0cjM1QzZJbVk

Re: [Xen-devel] [PATCH 10/22] xentoolcore_restrict_all: Implement for libxenforeignmemory

2017-09-20 Thread Wei Liu
On Tue, Sep 19, 2017 at 12:08:27PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH 10/22] xentoolcore_restrict_all: Implement for > libxenforeignmemory"): > > Sure that's fine. > > I have this now: > > * If called again with the same domid, it may succeed, or it may > * fail (even thou

Re: [Xen-devel] [PATCH 03/22] xentoolcore, _restrict_all: Introduce new library and implementation

2017-09-20 Thread Wei Liu
On Tue, Sep 19, 2017 at 12:04:42PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH 03/22] xentoolcore, _restrict_all: Introduce new > library and implementation"): > > The impression I get from the name and parameter from this API is that > > the following use case is allowed: a device mod

Re: [Xen-devel] [PATCH 22/22] RFC: tools: xentoolcore_restrict_all: use domid_t

2017-09-20 Thread Wei Liu
On Tue, Sep 19, 2017 at 12:01:15PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH 22/22] RFC: tools: xentoolcore_restrict_all: use > domid_t"): > > On Fri, Sep 15, 2017 at 07:48:59PM +0100, Ian Jackson wrote: > > > This is an RFC because it does not currently compile, because not all > >

  1   2   3   >