Re: [Xen-devel] [PATCH 22/27 v8] xen/arm: vpl011: Add support for vuart console in xenconsole

2017-09-12 Thread Bhupinder Thakur
Hi Wei, On 7 September 2017 at 14:38, Wei Liu wrote: > On Wed, Sep 06, 2017 at 10:59:05PM +0530, Bhupinder Thakur wrote: >> On 5 September 2017 at 15:01, Wei Liu wrote: >> > On Mon, Sep 04, 2017 at 09:58:07PM +0530, Bhupinder Thakur wrote: >> >> Hi Jan, >> >> >> >> >> >> On 28 August 2017 at 14:

[Xen-devel] [ovmf test] 113346: regressions - FAIL

2017-09-12 Thread osstest service owner
flight 113346 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/113346/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 113143 build-amd64-xsm

Re: [Xen-devel] [PATCH v5 05/11] mm: move modify_identity_mmio to global file and drop __init

2017-09-12 Thread Roger Pau Monné
On Tue, Sep 05, 2017 at 09:01:57AM -0600, Jan Beulich wrote: > >>> On 14.08.17 at 16:28, wrote: > > +int modify_mmio(struct domain *d, gfn_t gfn, mfn_t mfn, unsigned long > > nr_pages, > > +bool map) > > +{ > > +int rc; > > + > > +/* > > + * ATM this function should on

Re: [Xen-devel] [alsa-devel] [PATCH RESEND1 00/12] ALSA: vsnd: Add Xen para-virtualized frontend driver

2017-09-12 Thread Oleksandr Grytsov
On Tue, Sep 5, 2017 at 10:24 AM, Clemens Ladisch wrote: > Oleksandr Andrushchenko wrote: We understand that emulated interrupt on the frontend side is completely not acceptable > > Allow me to expand on that: Proper synchronization requires that the > exact position is communicate

[Xen-devel] USB passthrough with Xen on ARM

2017-09-12 Thread Roger Quadros
Hi, I'm running Xen v4.9 on DRA7 (OMAP5/ArmV7) with Linux kernel v3.14 (yikes!!) on dom0 and domU. I'm struggling to get USB passthrough working using pvUSB. My domU config file contains usb = 1 usbctrl = ['type=qusb,version=2,ports=4', 'type=qusb,version=1, ports=4', ] I can see the vus

Re: [Xen-devel] [PATCH RFC] Add SUPPORT.md

2017-09-12 Thread Dario Faggioli
On Mon, 2017-09-11 at 15:16 +0100, George Dunlap wrote: > On 09/07/2017 10:54 PM, Stefano Stabellini wrote: > > On Thu, 31 Aug 2017, George Dunlap wrote: > > > > > > +### Null Scheduler > > > + > > > +Status: Experimental > > > + > > > > > Can we say more than Experimental? I think it should

Re: [Xen-devel] [PATCH 22/27 v8] xen/arm: vpl011: Add support for vuart console in xenconsole

2017-09-12 Thread Wei Liu
On Tue, Sep 12, 2017 at 12:55:23PM +0530, Bhupinder Thakur wrote: > Hi Wei, > > On 7 September 2017 at 14:38, Wei Liu wrote: > > On Wed, Sep 06, 2017 at 10:59:05PM +0530, Bhupinder Thakur wrote: > >> On 5 September 2017 at 15:01, Wei Liu wrote: > >> > On Mon, Sep 04, 2017 at 09:58:07PM +0530, Bh

Re: [Xen-devel] [PATCH v2 3/5] xen/livepatch/ARM32: Don't load and crash on livepatches loaded with wrong alignment.

2017-09-12 Thread Jan Beulich
>>> On 12.09.17 at 02:22, wrote: > On Mon, Sep 11, 2017 at 03:01:15AM -0600, Jan Beulich wrote: >> Hmm, as long as the relocation isn't required to be against aligned >> fields only (mandated by the processor ABI) I think the code doing >> the relocations would instead need to split the access, ra

Re: [Xen-devel] [PATCH v5 05/11] mm: move modify_identity_mmio to global file and drop __init

2017-09-12 Thread Jan Beulich
>>> On 12.09.17 at 09:49, wrote: > On Tue, Sep 05, 2017 at 09:01:57AM -0600, Jan Beulich wrote: >> >>> On 14.08.17 at 16:28, wrote: >> > +int modify_mmio(struct domain *d, gfn_t gfn, mfn_t mfn, unsigned long > nr_pages, >> > +bool map) >> > +{ >> > +int rc; >> > + >> > +/

[Xen-devel] [xen-unstable test] 113331: regressions - FAIL

2017-09-12 Thread osstest service owner
flight 113331 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/113331/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 16 guest-start/debian.repeat fail REGR. vs. 113266 Tests which did no

Re: [Xen-devel] [PATCH v10 2/3] x86emul: New return code for unimplemented instruction

2017-09-12 Thread Jan Beulich
>>> On 11.09.17 at 17:52, wrote: > On Jo, 2017-09-07 at 09:08 -0600, Jan Beulich wrote: >> > >> > > >> > > > >> > > > On 07.09.17 at 16:26, wrote: >> > After discussing with Andrew I'm willing to agree with the changes >> > you do here, with one extra requirement: At least on non-debug >> > bu

Re: [Xen-devel] [PATCH v2 1/4] x86/shadow: Use ERR_PTR infrastructure for sh_emulate_map_dest()

2017-09-12 Thread Wei Liu
On Fri, Sep 08, 2017 at 07:05:33PM +0300, Alexandru Isaila wrote: > From: Andrew Cooper > > sh_emulate_map_dest() predates the introduction of the generic ERR_PTR() > infrastructure, but take the opportunity to avoid opencoding it. > > The chosen error constants require need to be negative to wo

Re: [Xen-devel] [PATCH] hvmloader: cast to avoid potential overflow in shadow_gs_test

2017-09-12 Thread Wei Liu
On Mon, Sep 11, 2017 at 09:20:58AM -0600, Jan Beulich wrote: > >>> On 11.09.17 at 17:01, wrote: > > On Mon, Sep 11, 2017 at 08:55:53AM -0600, Jan Beulich wrote: > >> >>> On 11.09.17 at 16:07, wrote: > >> > e2fc5bb5cb4 ("hvmloader: dynamically determine scratch memory range > >> > for tests") make

Re: [Xen-devel] [PATCH RFC v2] Add SUPPORT.md

2017-09-12 Thread Jan Beulich
>>> On 11.09.17 at 19:53, wrote: > As for practical limits, I don't think its reasonable to claim anything > which we can't test. What are the specs in the MA colo? I don't think the MA colo's limits ought to be the only ones applicable here, and it looks like you think this way too: >> +### Vi

Re: [Xen-devel] [PATCH RFC v2] Add SUPPORT.md

2017-09-12 Thread Wei Liu
On Mon, Sep 11, 2017 at 06:53:55PM +0100, Andrew Cooper wrote: > On 11/09/17 18:01, George Dunlap wrote: > > +### x86/PV > > + > > +Status: Supported > > + > > +Traditional Xen Project PV guest > > What's a "Xen Project" PV guest? Just Xen here. > > Also, a perhaps a statement of "No hardwar

Re: [Xen-devel] [PATCH v5 08/11] vpci/bars: add handlers to map the BARs

2017-09-12 Thread Roger Pau Monné
On Thu, Sep 07, 2017 at 03:53:07AM -0600, Jan Beulich wrote: > >>> On 14.08.17 at 16:28, wrote: > > + > > +/* > > + * The PCI Local Bus Specification suggests writing ~0 to both the high > > + * and the low part of the BAR registers before attempting to read back > > + * the size.

[Xen-devel] [qemu-upstream-unstable test] 113336: trouble: broken/fail/pass

2017-09-12 Thread osstest service owner
flight 113336 qemu-upstream-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/113336/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvh-amd broken test-armhf

Re: [Xen-devel] USB passthrough with Xen on ARM

2017-09-12 Thread Juergen Gross
On 12/09/17 10:13, Roger Quadros wrote: > Hi, > > I'm running Xen v4.9 on DRA7 (OMAP5/ArmV7) with Linux kernel v3.14 (yikes!!) > on dom0 and domU. > I'm struggling to get USB passthrough working using pvUSB. > > My domU config file contains >usb = 1 >usbctrl = ['type=qusb,version=2,ports

Re: [Xen-devel] [PATCH v2 2/4] x86/hvm: Rename enum hvm_copy_result to hvm_translation_result

2017-09-12 Thread George Dunlap
On 09/11/2017 02:39 PM, Andrew Cooper wrote: > On 11/09/17 14:27, George Dunlap wrote: >> On 09/08/2017 05:05 PM, Alexandru Isaila wrote: >>> diff --git a/xen/include/asm-x86/hvm/support.h >>> b/xen/include/asm-x86/hvm/support.h >>> index b18dbb6..e3b035d 100644 >>> --- a/xen/include/asm-x86/hvm/s

[Xen-devel] [PATCH v2 02/24] xen/mm: Use typesafe MFN for alloc_boot_pages return

2017-09-12 Thread Julien Grall
At the moment, most of the callers will have to use mfn_x. However follow-up patches will remove some of them by propagating the typesafe a bit further. Signed-off-by: Julien Grall --- Changes in v2: - Push down a bit some mfn_t to convert some unsigned long local variables to mfn_t. Cc

[Xen-devel] [PATCH v2 22/24] xen/arm: mm: Embed permission in the flags

2017-09-12 Thread Julien Grall
Currently, it is not possible to specify the permission of a new mapping. It would be necessary to use the function modify_xen_mappings with a different set of flags. Introduce a couple of new flags for the permissions (Non-eXecutable, Read-Only) and also provides definition that combine the memor

[Xen-devel] [PATCH v2 14/24] xen/arm: page: Use directly BUFFERABLE and drop DEV_WC

2017-09-12 Thread Julien Grall
DEV_WC is only used for PAGE_HYPERVISOR_WC and does not bring much improvement. Signed-off-by: Julien Grall Reviewed-by: Andre Przywara --- Changes in v2: - Remove DEV_WC from the comment as well - Add Andre's reviewed-by --- xen/include/asm-arm/page.h | 5 + 1 file ch

[Xen-devel] [PATCH v2 11/24] xen/arm: traps: Improve logging for data/prefetch abort fault

2017-09-12 Thread Julien Grall
Walk the hypervisor page table for data/prefetch abort fault to help diagnostics error in the page tables. Signed-off-by: Julien Grall Reviewed-by: Andre Przywara --- Andre, I assumed you were happy with changes you suggested, so I kept your reviewed-by. Changes in v2: - Ad

[Xen-devel] [PATCH v2 20/24] xen/arm: mm: Rename 'ai' into 'flags' in create_xen_entries

2017-09-12 Thread Julien Grall
The parameter 'ai' is used either for attribute index or for permissions. Follow-up patch will rework that parameters to carry more information. So rename the parameter to 'flags'. Signed-off-by: Julien Grall Reviewed-by: Andre Przywara --- Changes in v2: - Add Andre's reviewed-by

[Xen-devel] [PATCH v2 17/24] xen/arm: page: Clean-up the definition of MAIRVAL

2017-09-12 Thread Julien Grall
Currently MAIRVAL is defined in term of MAIR0VAL and MAIR1VAL which are both hardcoded value. This makes quite difficult to understand the value written in both registers. Rework the definition by using value of each attribute shifted by their associated index. Signed-off-by: Julien Grall ---

[Xen-devel] [PATCH v2 16/24] xen/arm: page: Use ARMv8 naming to improve readability

2017-09-12 Thread Julien Grall
This is based on the Linux ARMv8 naming scheme (see arch/arm64/mm/proc.S). Each type will contain "NORMAL" or "DEVICE" to make clear whether each attribute targets device or normal memory. Signed-off-by: Julien Grall --- Changes in v2: * Move the patch before "xen/arm: page: Clean-u

[Xen-devel] [PATCH v2 21/24] xen/arm: page: Describe the layout of flags used to update page tables

2017-09-12 Thread Julien Grall
Currently, the flags used to update page tables (i.e PAGE_HYPERVISOR_*) only contains the memory attribute index. Follow-up patches will add more information in it. So document the current layout. At the same time introduce PAGE_AI_MASK to get the memory attribute index easily. Signed-off-by: Jul

[Xen-devel] [PATCH v2 05/24] xen/arm: hsr_iabt: Document RES0 field

2017-09-12 Thread Julien Grall
Signed-off-by: Julien Grall Reviewed-by: Andre Przywara --- Note that the missing FnV bits present ARMv8 will be added in a follow-up patch. Changes in v2: - Add Andre's reviewed-by --- xen/include/asm-arm/processor.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

[Xen-devel] [PATCH v2 03/24] xen/mm: Use __virt_to_mfn in map_domain_page instead of virt_to_mfn

2017-09-12 Thread Julien Grall
virt_to_mfn may by overridden by the source files, for improving locally typesafe. Therefore map_domain_page has to use __virt_to_mfn to prevent any compilation issue in sources files that override the helper. Signed-off-by: Julien Grall Acked-by: Jan Beulich --- Changes in v2: - Add Jan's

[Xen-devel] [PATCH v2 13/24] xen/arm: page: Remove unused attributes DEV_NONSHARED and DEV_CACHED

2017-09-12 Thread Julien Grall
They were imported from non-LPAE Linux, but Xen is LPAE only. It is time to do some clean-up in the memory attribute and keep only what make sense for Xen. Follow-up patch will do more clean-up. Also, update the comment saying our attribute matches Linux. Signed-off-by: Julien Grall Reviewed-by:

[Xen-devel] [PATCH v2 01/24] xen/x86: mm: Introduce {G, M}FN <-> {G, M}ADDR helpers

2017-09-12 Thread Julien Grall
The new wrappers will add more safety when converting an address to a frame number (either machine or guest). They are already existing for Arm and could be useful in common code. Signed-off-by: Julien Grall --- Changes in v2: - Implement it in arch specific rather than in common code. Hence

[Xen-devel] [PATCH v2 09/24] xen/arm: Introduce hsr_xabt to gather common bits between hsr_dabt and

2017-09-12 Thread Julien Grall
This will allow to consolidate some part of the data abort and prefetch abort handling in a single function later on. Signed-off-by: Julien Grall Reviewed-by: Andre Przywara --- Changes in v2: - Add Andre's reviewed-by --- xen/include/asm-arm/processor.h | 13 + 1 file

[Xen-devel] [PATCH v2 12/24] xen/arm: Replace ioremap_attr(PAGE_HYPERVISOR_NOCACHE) call by ioremap_nocache

2017-09-12 Thread Julien Grall
ioremap_cache is a wrapper of ioremap_attr(...). Signed-off-by: Julien Grall Reviewed-by: Andre Przywara --- Changes in v2: - Add Andre's reviewed-by --- xen/arch/arm/platforms/exynos5.c | 2 +- xen/arch/arm/platforms/omap5.c | 6 ++ 2 files changed, 3 insertions(+), 5 delet

[Xen-devel] [PATCH v2 00/24] xen/arm: Memory subsystem clean-up

2017-09-12 Thread Julien Grall
Hi all, This patch series contains clean-up for the ARM memory subsystem in preparation of reworking the page tables handling. A branch with the patches can be found on xenbits: https://xenbits.xen.org/git-http/people/julieng/xen-unstable.git branch mm-cleanup-v2 For all the changes see in each

[Xen-devel] [PATCH v2 18/24] xen/arm: mm: Rename and clarify AP[1] in the stage-1 page table

2017-09-12 Thread Julien Grall
The description of AP[1] in Xen is based on testing rather than the ARM ARM. Per the ARM ARM, on EL2 stage-1 page table, AP[1] is RES1 as the translation regime applies to only one exception level (see D4.4.4 and G4.6.1 in ARM DDI 0487B.a). Update the comment and also rename the field to match th

[Xen-devel] [PATCH v2 04/24] xen/arm: mm: Redefine mfn_to_virt to use typesafe

2017-09-12 Thread Julien Grall
This add a bit more safety in the memory subsystem code. Signed-off-by: Julien Grall --- xen/arch/arm/mm.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 965d0573a4..5716ef1123 100644 --- a/xen/arch/arm/mm.c +++ b/

[Xen-devel] [PATCH v2 07/24] xen/arm: arm32: Don't define FAR_EL1

2017-09-12 Thread Julien Grall
Aliasing FAR_EL1 to IFAR is wrong because on ARMv8 FAR_EL1[31:0] is architecturally mapped to DFAR and FAR_EL1[63:32] to IFAR. As FAR_EL1 is not currently used in ARM32 code, remove it. Signed-off-by: Julien Grall Reviewed-by: Andre Przywara --- Changes in v2: - Fix register name i

[Xen-devel] [PATCH v2 08/24] xen/arm: Add FnV field in hsr_*abt

2017-09-12 Thread Julien Grall
FnV (FAR not Valid) bit was introduced by ARMv8 in both AArch32 and AArch64 (See D7-2275, D7-2277, G6-4958, G6-4962 in ARM DDI 0487B.a). Note the new revision of ARMv8 defined more bits in HSR. They haven't been added at the moment because we have no use of them in Xen. Signed-off-by: Julien Gral

[Xen-devel] [PATCH v2 10/24] xen/arm: traps: Introduce a helper to read the hypersivor fault register

2017-09-12 Thread Julien Grall
While ARM32 has 2 distinct registers for the hypervisor fault register (one for prefetch abort, the other for data abort), AArch64 has only one. Currently, the logic is open-code but a follow-up patch will require to read it too. So move the logic in a separate helper and use it instead of open-co

[Xen-devel] [PATCH v2 23/24] xen/arm: mm: Handle permission flags when adding a new mapping

2017-09-12 Thread Julien Grall
Currently, all the new mappings will be read-write non-executable. Allow the caller to use other permissions. Signed-off-by: Julien Grall --- Changes in v2: - Switch the runtime check to a BUG_ON() --- xen/arch/arm/mm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch

[Xen-devel] [PATCH v2 19/24] xen/arm: Switch to SYS_STATE_boot just after end_boot_allocator()

2017-09-12 Thread Julien Grall
We should consider the early boot period to end when we stop using the boot allocator. This is inline with x86 and will be helpful to know whether we should allocate memory from the boot allocator or xenheap. Signed-off-by: Julien Grall Reviewed-by: Andre Przywara --- Changes in v2:

[Xen-devel] [PATCH v2 24/24] xen/arm: mm: Use memory flags for modify_xen_mappings rather than custom one

2017-09-12 Thread Julien Grall
This will help to consolidate the page-table code and avoid different path depending on the action to perform. Signed-off-by: Julien Grall Reviewed-by: Andre Przywara --- Cc: Konrad Rzeszutek Wilk Cc: Ross Lagerwall arch_livepatch_secure is now the same as on x86. It might be possib

[Xen-devel] [PATCH v2 15/24] xen/arm: page: Prefix memory types with MT_

2017-09-12 Thread Julien Grall
This will avoid confusion in the code when using them. Signed-off-by: Julien Grall Reviewed-by: Andre Przywara --- Changes in v2: - Add Andre's reviewed-by --- xen/arch/arm/kernel.c | 2 +- xen/arch/arm/mm.c | 28 ++-- xen/arch/

[Xen-devel] [PATCH v2 06/24] xen/arm: traps: Don't define FAR_EL2 for ARM32

2017-09-12 Thread Julien Grall
Aliasing FAR_EL2 to HIFAR makes the code confusing because on ARMv8 FAR_EL2[31:0] is architecturally mapped to HDFAR and FAR_EL2[63:32] to HIFAR. See D7.2.30 in ARM DDI 0487B.a. Open-code the alias instead. Signed-off-by: Julien Grall Reviewed-by: Andre Przywara --- Changes in v2: -

Re: [Xen-devel] [PATCH v5 08/11] vpci/bars: add handlers to map the BARs

2017-09-12 Thread Jan Beulich
>>> On 12.09.17 at 11:54, wrote: > On Thu, Sep 07, 2017 at 03:53:07AM -0600, Jan Beulich wrote: >> >>> On 14.08.17 at 16:28, wrote: >> > + >> > +/* >> > + * The PCI Local Bus Specification suggests writing ~0 to both the >> > high >> > + * and the low part of the BAR registers before

[Xen-devel] [ovmf test] 113355: regressions - FAIL

2017-09-12 Thread osstest service owner
flight 113355 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/113355/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 113143 build-amd64-xsm

Re: [Xen-devel] [PATCH v2 01/24] xen/x86: mm: Introduce {G, M}FN <-> {G, M}ADDR helpers

2017-09-12 Thread Andrew Cooper
On 12/09/17 11:03, Julien Grall wrote: > The new wrappers will add more safety when converting an address to a > frame number (either machine or guest). They are already existing for > Arm and could be useful in common code. > > Signed-off-by: Julien Grall Reviewed-by: Andrew Cooper ___

Re: [Xen-devel] [PATCH v5 02/12] libxl: add generic functions to get and free device list

2017-09-12 Thread Wei Liu
On Mon, Sep 11, 2017 at 08:14:52PM +0300, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Add libxl__device_list and libxl__device_list_free > functions to handle device list using the device > framework. > > Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu _

Re: [Xen-devel] [PATCH v5 01/12] libxl: add generic function to add device

2017-09-12 Thread Wei Liu
On Mon, Sep 11, 2017 at 08:14:51PM +0300, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Add libxl__device_add to simple write XenStore device conifg > and libxl__device_add_async to update domain configuration > and write XenStore device config asynchroniously. > Almost all devices have

Re: [Xen-devel] [PATCH v5 03/12] libxl: add vdispl device

2017-09-12 Thread Wei Liu
On Mon, Sep 11, 2017 at 08:14:53PM +0300, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v5 06/12] libxl: change p9 to use generec add function

2017-09-12 Thread Wei Liu
On Mon, Sep 11, 2017 at 08:14:56PM +0300, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v5 07/12] libxl: change vkb to use generec add function

2017-09-12 Thread Wei Liu
On Mon, Sep 11, 2017 at 08:14:57PM +0300, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 02/24] xen/mm: Use typesafe MFN for alloc_boot_pages return

2017-09-12 Thread Jan Beulich
>>> On 12.09.17 at 12:03, wrote: > At the moment, most of the callers will have to use mfn_x. However > follow-up patches will remove some of them by propagating the typesafe a > bit further. > > Signed-off-by: Julien Grall Non-ARM pieces Acked-by: Jan Beulich __

Re: [Xen-devel] [PATCH v5 09/12] libxl: change disk to use generic getting list functions

2017-09-12 Thread Wei Liu
On Mon, Sep 11, 2017 at 08:14:59PM +0300, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu With one nit: > --- > tools/libxl/libxl.h | 9 +++- > tools/libxl/libxl_checkpoint_device.c | 7 ++- > tools/libxl/libxl_cre

Re: [Xen-devel] [PATCH v5 10/12] libxl: change nic to use generec add function

2017-09-12 Thread Wei Liu
On Mon, Sep 11, 2017 at 08:15:00PM +0300, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 03/24] xen/mm: Use __virt_to_mfn in map_domain_page instead of virt_to_mfn

2017-09-12 Thread Wei Liu
On Tue, Sep 12, 2017 at 11:03:09AM +0100, Julien Grall wrote: > virt_to_mfn may by overridden by the source files, for improving locally > typesafe. > > Therefore map_domain_page has to use __virt_to_mfn to prevent any > compilation issue in sources files that override the helper. > > Signed-off-

Re: [Xen-devel] [PATCH v2 01/24] xen/x86: mm: Introduce {G, M}FN <-> {G, M}ADDR helpers

2017-09-12 Thread Wei Liu
On Tue, Sep 12, 2017 at 11:03:07AM +0100, Julien Grall wrote: > The new wrappers will add more safety when converting an address to a > frame number (either machine or guest). They are already existing for > Arm and could be useful in common code. > > Signed-off-by: Julien Grall Reviewed-by: Wei

Re: [Xen-devel] [PATCH v2 02/24] xen/mm: Use typesafe MFN for alloc_boot_pages return

2017-09-12 Thread Wei Liu
On Tue, Sep 12, 2017 at 11:03:08AM +0100, Julien Grall wrote: > At the moment, most of the callers will have to use mfn_x. However > follow-up patches will remove some of them by propagating the typesafe a > bit further. > > Signed-off-by: Julien Grall Reviewed-by: Wei Liu

[Xen-devel] [PATCH v2 5/7] xen/arm: Move co-processor emulation outside of traps.c

2017-09-12 Thread Julien Grall
The co-processor emulation is quite big and pretty much standalone. Move it in a separate file to shrink down the size of traps.c. At the same time remove unused cpregs.h. No functional change. Signed-off-by: Julien Grall --- xen/arch/arm/Makefile | 1 + xen/arch/arm/traps.c| 4

[Xen-devel] [PATCH v2 3/7] xen/arm: traps: Export a bunch of helpers to handle emulation

2017-09-12 Thread Julien Grall
A follow-up patch will move some parts of traps.c in separate files. The will require to use helpers that are currently statically defined. Export the following helpers: - inject_undef64_exception - inject_undef_exception - check_conditional_instr - advance_pc - handle_raz_wi

[Xen-devel] [PATCH v2 2/7] xen/arm: Move arch/arm/vtimer.h to include/asm-arm/vtimer.h

2017-09-12 Thread Julien Grall
It will be necessary to include vtimer.h from subdirectory making the inclusion a bit awkward. Signed-off-by: Julien Grall --- xen/arch/arm/domain.c | 2 +- xen/arch/arm/traps.c | 2 +- xen/{arch/arm => include/asm-arm}/vtimer.h | 0 3 files changed, 2

[Xen-devel] [PATCH v2 6/7] xen/arm: Move sysregs.h in arm64 sub-directory

2017-09-12 Thread Julien Grall
sysregs.h contains only code protected by #ifdef CONFIG_ARM_64. Move it in arm64 sub-directory to reflect that and remove the #ifdef. At the same time, fixup the guards. Signed-off-by: Julien Grall --- xen/include/asm-arm/arm64/processor.h | 2 ++ xen/include/asm-arm/{ => arm64}/sysregs.h

[Xen-devel] [PATCH v2 7/7] xen/arm: Limit the scope of cpregs.h

2017-09-12 Thread Julien Grall
Currently, cpregs.h is included in pretty much every files even for arm64. However, the only use for arm64 is when emulating co-processors. For arm32, all users of processor.h expect cpregs.h to be included in order to access co-processors. So move the inclusion in asm-arm/arm32/processor.h. cpre

[Xen-devel] [PATCH v2 1/7] xen/arm: traps: Re-order the includes alphabetically

2017-09-12 Thread Julien Grall
Signed-off-by: Julien Grall Acked-by: Bhupinder Thakur --- Changes in v2: - Fix alphabetical order - Add Bhupinder's acked-by --- xen/arch/arm/traps.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/xen/arch/arm/

[Xen-devel] [PATCH v2 0/7] xen/arm: Clean-up traps.c

2017-09-12 Thread Julien Grall
Hi all, xen/arch/arm/traps.c is beginning to get very big. This series is moving out the co-processor and sysreg emulation in separate files. This will avoid to grow traps.c when adding more registers emulation (coming soon). A branch with this series has been pushed: https://xenbits.xen.org/git

[Xen-devel] [PATCH v2 4/7] xen/arm: Move sysreg emulation outside of traps.c

2017-09-12 Thread Julien Grall
The sysreg emulation is 64-bit specific and surrounded by #ifdef. Move them in a separate file arm/arm64/vsysreg.c to shrink down a bit traps.c No functional change. Signed-off-by: Julien Grall --- xen/arch/arm/arm64/Makefile | 1 + xen/arch/arm/arm64/vsysreg.c | 229 ++

Re: [Xen-devel] [PATCH v5 00/12] libxl: add PV display device driver interface

2017-09-12 Thread Wei Liu
On Mon, Sep 11, 2017 at 08:14:50PM +0300, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Changes since V4: > * Use new LIBXL_DEFINE_UPDATE_DEVID for all device types; > * Align device setdefault function parameters with set_default > device type callback; > * revert libxl_mac_to

Re: [Xen-devel] [PATCH RFC v2] Add SUPPORT.md

2017-09-12 Thread Roger Pau Monné
On Mon, Sep 11, 2017 at 06:01:59PM +0100, George Dunlap wrote: > +## Toolstack > + > +### xl > + > +Status: Supported > + > +### Direct-boot kernel image format > + > +Supported, x86: bzImage ELF > +Supported, ARM32: zImage > +Supported, ARM64: Image > + > +Format which the toolst

Re: [Xen-devel] [PATCH v5 02/11] vpci: introduce basic handlers to trap accesses to the PCI config space

2017-09-12 Thread Julien Grall
Hi Roger, On 14/08/17 15:28, Roger Pau Monne wrote: This functionality is going to reside in vpci.c (and the corresponding vpci.h header), and should be arch-agnostic. The handlers introduced in this patch setup the basic functionality required in order to trap accesses to the PCI config space,

Re: [Xen-devel] [PATCH v5 10/12] libxl: change nic to use generec add function

2017-09-12 Thread Wei Liu
On Mon, Sep 11, 2017 at 08:15:00PM +0300, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Signed-off-by: Oleksandr Grytsov > --- > tools/libxl/libxl.h | 9 +- > tools/libxl/libxl_checkpoint_device.c | 9 +- > tools/libxl/libxl_colo_save.c | 4 +- > tools/l

Re: [Xen-devel] USB passthrough with Xen on ARM

2017-09-12 Thread Roger Quadros
 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 12/09/17 13:00, Juergen Gross wrote: > On 12/09/17 10:13, Roger Quadros wrote: >> Hi, >> >> I'm running Xen v4.9 on DRA7 (OMAP5/ArmV7) with Linux kernel v3.14 (yike

Re: [Xen-devel] [PATCH v5 05/11] mm: move modify_identity_mmio to global file and drop __init

2017-09-12 Thread Julien Grall
Hi Roger, On 14/08/17 15:28, Roger Pau Monne wrote: And also allow it to do non-identity mappings by adding a new parameter. This function will be needed in order to map the BARs from PCI devices into the Dom0 p2m (and is also used by the x86 Dom0 builder). While there fix the function to use g

[Xen-devel] [qemu-mainline baseline-only test] 72094: regressions - trouble: blocked/broken/fail/pass

2017-09-12 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 72094 qemu-mainline real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72094/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm

Re: [Xen-devel] USB passthrough with Xen on ARM

2017-09-12 Thread Julien Grall
Hi, On 12/09/17 11:00, Juergen Gross wrote: On 12/09/17 10:13, Roger Quadros wrote: Hi, I'm running Xen v4.9 on DRA7 (OMAP5/ArmV7) with Linux kernel v3.14 (yikes!!) on dom0 and domU. I'm struggling to get USB passthrough working using pvUSB. My domU config file contains usb = 1 usbct

Re: [Xen-devel] [PATCH v5 02/11] vpci: introduce basic handlers to trap accesses to the PCI config space

2017-09-12 Thread Roger Pau Monné
On Tue, Sep 12, 2017 at 11:42:38AM +0100, Julien Grall wrote: > Hi Roger, > > On 14/08/17 15:28, Roger Pau Monne wrote: > > This functionality is going to reside in vpci.c (and the corresponding > > vpci.h header), and should be arch-agnostic. The handlers introduced > > in this patch setup the ba

Re: [Xen-devel] [PATCH v5 02/11] vpci: introduce basic handlers to trap accesses to the PCI config space

2017-09-12 Thread Julien Grall
On 12/09/17 11:58, Roger Pau Monné wrote: On Tue, Sep 12, 2017 at 11:42:38AM +0100, Julien Grall wrote: Hi Roger, On 14/08/17 15:28, Roger Pau Monne wrote: This functionality is going to reside in vpci.c (and the corresponding vpci.h header), and should be arch-agnostic. The handlers introdu

Re: [Xen-devel] [PATCH v5 10/12] libxl: change nic to use generec add function

2017-09-12 Thread Wei Liu
On Tue, Sep 12, 2017 at 11:52:17AM +0100, Wei Liu wrote: > On Mon, Sep 11, 2017 at 08:15:00PM +0300, Oleksandr Grytsov wrote: > > From: Oleksandr Grytsov > > > > Signed-off-by: Oleksandr Grytsov > > --- > > tools/libxl/libxl.h | 9 +- > > tools/libxl/libxl_checkpoint_device.

Re: [Xen-devel] USB passthrough with Xen on ARM

2017-09-12 Thread Juergen Gross
On 12/09/17 12:52, Roger Quadros wrote: > > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > On 12/09/17 13:00, Juergen Gross wrote: >> On 12/09/17 10:13, Roger Quadros wrote: >>> Hi, >>> >>> I'm running Xen v

Re: [Xen-devel] USB passthrough with Xen on ARM

2017-09-12 Thread Roger Quadros
 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 12/09/17 13:57, Julien Grall wrote: > Hi, > > On 12/09/17 11:00, Juergen Gross wrote: >> On 12/09/17 10:13, Roger Quadros wrote: >>> Hi, >>> >>> I'm running Xen v4.

Re: [Xen-devel] [RFC 6/6] acpi:arm64: Add support for parsing IORT table

2017-09-12 Thread Julien Grall
Hi Sameer, On 28/08/17 23:21, Goel, Sameer wrote: On 6/12/2017 7:24 AM, Julien Grall wrote: static int arm_smmu_iort_xlate(struct device *dev, u32 streamid, struct fwnode_handle *fwnode, const struct iommu_ops *ops) @@ -523,29 +563,24 @@ static int ar

Re: [Xen-devel] [PATCH v5 05/11] mm: move modify_identity_mmio to global file and drop __init

2017-09-12 Thread Roger Pau Monné
On Tue, Sep 12, 2017 at 03:04:02AM -0600, Jan Beulich wrote: > >>> On 12.09.17 at 09:49, wrote: > > On Tue, Sep 05, 2017 at 09:01:57AM -0600, Jan Beulich wrote: > >> >>> On 14.08.17 at 16:28, wrote: > >> > +int modify_mmio(struct domain *d, gfn_t gfn, mfn_t mfn, unsigned long > > nr_pages, > >>

[Xen-devel] [distros-debian-snapshot test] 72095: tolerable trouble: blocked/broken/fail/pass

2017-09-12 Thread Platform Team regression test user
flight 72095 distros-debian-snapshot real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72095/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-armhf-daily-netboot-pygrub 1 build-check(1) blocked n/a build-arm64-pvops

Re: [Xen-devel] [PATCH v5 10/12] libxl: change nic to use generec add function

2017-09-12 Thread Oleksandr Grytsov
On Tue, Sep 12, 2017 at 2:08 PM, Wei Liu wrote: > On Tue, Sep 12, 2017 at 11:52:17AM +0100, Wei Liu wrote: >> On Mon, Sep 11, 2017 at 08:15:00PM +0300, Oleksandr Grytsov wrote: >> > From: Oleksandr Grytsov >> > >> > Signed-off-by: Oleksandr Grytsov >> > --- >> > tools/libxl/libxl.h

Re: [Xen-devel] [PATCH v5 05/11] mm: move modify_identity_mmio to global file and drop __init

2017-09-12 Thread Roger Pau Monné
On Tue, Sep 12, 2017 at 11:53:49AM +0100, Julien Grall wrote: > Hi Roger, > > On 14/08/17 15:28, Roger Pau Monne wrote: > > And also allow it to do non-identity mappings by adding a new > > parameter. > > > > This function will be needed in order to map the BARs from PCI devices > > into the Dom0

Re: [Xen-devel] [PATCH v5 08/11] vpci/bars: add handlers to map the BARs

2017-09-12 Thread Roger Pau Monné
On Tue, Sep 12, 2017 at 04:06:13AM -0600, Jan Beulich wrote: > >>> On 12.09.17 at 11:54, wrote: > > On Thu, Sep 07, 2017 at 03:53:07AM -0600, Jan Beulich wrote: > >> >>> On 14.08.17 at 16:28, wrote: > >> > + > >> > +/* > >> > + * The PCI Local Bus Specification suggests writing ~0 to both

[Xen-devel] Xen Security Advisory 233 (CVE-2017-14317) - cxenstored: Race in domain cleanup

2017-09-12 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2017-14317 / XSA-233 version 3 cxenstored: Race in domain cleanup UPDATES IN VERSION 3 Added metadata file Public release. ISSUE DESCRIPT

[Xen-devel] Xen Security Advisory 231 (CVE-2017-14316) - Missing NUMA node parameter verification

2017-09-12 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2017-14316 / XSA-231 version 3 Missing NUMA node parameter verification UPDATES IN VERSION 3 Updated metadata file Public release. ISSUE DES

[Xen-devel] Xen Security Advisory 232 (CVE-2017-14318) - Missing check for grant table

2017-09-12 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2017-14318 / XSA-232 version 4 Missing check for grant table UPDATES IN VERSION 4 Added metadata file Public release. ISSUE DESCRIPTIO

[Xen-devel] Xen Security Advisory 234 (CVE-2017-14319) - insufficient grant unmapping checks for x86 PV guests

2017-09-12 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2017-14319 / XSA-234 version 3 insufficient grant unmapping checks for x86 PV guests UPDATES IN VERSION 3 Added metadata file Public release. ISS

[Xen-devel] [PATCH 0/7] x86/mm: Post XSA-234 cleanup

2017-09-12 Thread Andrew Cooper
Simplification of the PV grant code Andrew Cooper (7): x86/mm: Improvements to PV l1e mapping helpers x86/mm: Factor out the grant flags to pte flags conversion logic x86/mm: Misc cleanup to {create,replace}_grant_host_mapping() x86/mm: Combine create_grant_{pte,va}_mapping() x86/mm: Car

[Xen-devel] [PATCH 4/7] x86/mm: Combine create_grant_{pte, va}_mapping()

2017-09-12 Thread Andrew Cooper
create_grant_{pte,va}_mapping() are nearly identical; all that is really different between them is how they convert their addr parameter to the pte to install the grant into. Reimplement their logic in create_grant_pv_mapping() in a mostly common way. No (intended) change in behaviour from a gues

[Xen-devel] [PATCH 3/7] x86/mm: Misc cleanup to {create, replace}_grant_host_mapping()

2017-09-12 Thread Andrew Cooper
The purpose of this patch is solely to simplify the resulting diff of later changes. * Factor out curr and currd at the start of the functions. * Rename pte to nl1e. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu --- xen/arch/x86/mm.c | 18 ++

[Xen-devel] [PATCH 7/7] x86/mm: Prevent 32bit PV guests using out-of-range linear addresses

2017-09-12 Thread Andrew Cooper
The grant ABI uses 64 bit values, and allows a PV guest to specify linear addresses. There is nothing interesting a 32bit PV guest can reference which will pass an __addr_ok() check, but it should still get an error for trying. Signed-off-by: Andrew Cooper --- CC: Jan Beulich --- xen/arch/x86/

[Xen-devel] [PATCH 5/7] x86/mm: Carve steal_linear_address() out of replace_grant_host_mapping()

2017-09-12 Thread Andrew Cooper
Document its curious semantics. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu --- xen/arch/x86/mm.c | 105 ++ 1 file changed, 58 insertions(+), 47 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x

[Xen-devel] [PATCH 1/7] x86/mm: Improvements to PV l1e mapping helpers

2017-09-12 Thread Andrew Cooper
Drop guest_unmap_l1e() and use unmap_domain_page() directly. This will simplify future cleanup. Rename guest_map_l1e() to map_guest_l1e() to closer match the mapping nomenclature. Switch map_guest_l1e() to using mfn_t. Correct the comment to indicate that it takes a linear address (not a virtua

[Xen-devel] [PATCH 6/7] x86/mm: Combine {destroy, replace}_grant_{pte, va}_mapping()

2017-09-12 Thread Andrew Cooper
As with the create side of things, these are largely identical. Most cases are actually destroying the mapping rather than replacing it with a stolen entry. Reimplement their logic in replace_grant_pv_mapping() in a mostly common way. No (intended) change in behaviour from a guests point of view

[Xen-devel] [PATCH 2/7] x86/mm: Factor out the grant flags to pte flags conversion logic

2017-09-12 Thread Andrew Cooper
This fixes a bug where the requested AVAIL* flags were not honoured in an unmap_and_replace operation. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu --- xen/arch/x86/mm.c | 43 ++- 1 file changed, 18 insertions(+), 25 deletions(-) diff --

[Xen-devel] [libvirt test] 113350: tolerable all pass - PUSHED

2017-09-12 Thread osstest service owner
flight 113350 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/113350/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-xsm 14 saverestore-support-checkfail like 113159 test-armhf-armhf-libvirt 14 saveresto

Re: [Xen-devel] [PATCH 1/7] x86/mm: Improvements to PV l1e mapping helpers

2017-09-12 Thread Wei Liu
On Tue, Sep 12, 2017 at 01:14:40PM +0100, Andrew Cooper wrote: > Drop guest_unmap_l1e() and use unmap_domain_page() directly. This will > simplify future cleanup. Rename guest_map_l1e() to map_guest_l1e() to closer > match the mapping nomenclature. > > Switch map_guest_l1e() to using mfn_t. Cor

[Xen-devel] [qemu-mainline test] 113345: regressions - FAIL

2017-09-12 Thread osstest service owner
flight 113345 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/113345/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-win7-amd64 16 guest-localmigrate/x10 fail REGR. vs. 113302 test-amd64-

  1   2   3   >