On Tue, Sep 12, 2017 at 12:55:23PM +0530, Bhupinder Thakur wrote: > Hi Wei, > > On 7 September 2017 at 14:38, Wei Liu <wei.l...@citrix.com> wrote: > > On Wed, Sep 06, 2017 at 10:59:05PM +0530, Bhupinder Thakur wrote: > >> On 5 September 2017 at 15:01, Wei Liu <wei.l...@citrix.com> wrote: > >> > On Mon, Sep 04, 2017 at 09:58:07PM +0530, Bhupinder Thakur wrote: > >> >> Hi Jan, > >> >> > >> >> > >> >> On 28 August 2017 at 14:41, Jan Beulich <jbeul...@suse.com> wrote: > >> >> >>>> On 28.08.17 at 10:56, <bhupinder.tha...@linaro.org> wrote: > >> >> >> --- a/config/arm32.mk > >> >> >> +++ b/config/arm32.mk > >> >> >> @@ -1,5 +1,6 @@ > >> >> >> CONFIG_ARM := y > >> >> >> CONFIG_ARM_32 := y > >> >> >> +CONFIG_VUART_CONSOLE := y > >> >> >> CONFIG_ARM_$(XEN_OS) := y > >> >> >> > >> >> >> CONFIG_XEN_INSTALL_SUFFIX := > >> >> >> diff --git a/config/arm64.mk b/config/arm64.mk > >> >> >> index aa45772..861d0a4 100644 > >> >> >> --- a/config/arm64.mk > >> >> >> +++ b/config/arm64.mk > >> >> >> @@ -1,5 +1,6 @@ > >> >> >> CONFIG_ARM := y > >> >> >> CONFIG_ARM_64 := y > >> >> >> +CONFIG_VUART_CONSOLE := y > >> >> >> CONFIG_ARM_$(XEN_OS) := y > >> >> > > >> >> > I think this wants to be solved better than by starting to again > >> >> > introduce CONFIG_* values here. > >> >> > >> >> I think I can remove this flag from here since it is used currently > >> >> for xenconsole only to enable VUART console support for ARM. I can > >> >> directly define the flag in the tools/console Makefile based on > >> >> CONFIG_ARM option. > >> > > >> > Just use CONFIG_ARM directly? > >> > >> I believe I cannot use CONFIG_ARM directly in > >> tools/console/daemon/io.c as it is a makefile variable. > >> > > > > You should be able to. I think CONFIG_ARM/X86 are passed on to gcc. > > > > And I just tested with CONFIG_X86, which worked. > > I tried using CONFIG_ARM or CONFIG_ARM_64 in daemon/io.c but these > flags are not defined. > > I think I can define it the way, it is defined in libacpi/Makefile: > > MKDSDT_CFLAGS-$(CONFIG_ARM_64) = -DCONFIG_ARM_64 > > Similarly I can define: > > CONSOLE_CFLAGS-$(CONFIG_ARM) = -DCONFIG_ARM >
Fine by me. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
