Re: [Xen-devel] new dma-mapping tree, was Re: clean up and modularize arch dma_mapping interface V2

2017-06-26 Thread Christoph Hellwig
On Wed, Jun 21, 2017 at 03:32:39PM +0200, Marek Szyprowski wrote: > linux-next > was a side effect of that. I think that for now it can be dropped in favor > of > Christoph's tree. I can also do some review and help in maintainers work if > needed, although I was recently busy with other stuff. >

Re: [Xen-devel] live migration of HVM domUs with more than 32vcpus fails

2017-06-26 Thread Olaf Hering
On Fri, Jun 23, Ankur Arora wrote: > There was an earlier version of this patch by Konrad -- which takes > care of the migration failure: https://patchwork.kernel.org/patch/6768031/ Thanks so much. That one actually works. Olaf signature.asc Description: PGP signature

[Xen-devel] [xen-4.6-testing test] 111038: tolerable FAIL - PUSHED

2017-06-26 Thread osstest service owner
flight 111038 xen-4.6-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/111038/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 12 guest-start fail like 110899 test-xtf-amd64-amd64-2 46 xt

Re: [Xen-devel] [PATCH v4 8/9] arm/mem_access: Add short-descriptor based gpt

2017-06-26 Thread Sergej Proskurin
Hi Julien, [...] + +/* + * As we have considered up to 2 MSBs of the GVA for mapping the first + * level translation table, we need to make sure that we limit the table + * offset that is is indexed by GVA<31-n:20> to max 10 bits to avoid >

[Xen-devel] [PATCH v4 09/11] xen/mce: add support of vLMCE injection to XEN_MC_inject_v2

2017-06-26 Thread Haozhong Zhang
Signed-off-by: Haozhong Zhang Reviewed-by: Jan Beulich --- Cc: Jan Beulich Cc: Andrew Cooper Changes in v4: (Take Jan's R-b with following changes.) * Adjust error messages. --- xen/arch/x86/cpu/mcheck/mce.c | 24 +++- xen/include/public/arch-x86/xen-mca.h | 1 +

[Xen-devel] [PATCH v4 08/11] x86/vmce, tools/libxl: expose LMCE capability in guest MSR_IA32_MCG_CAP

2017-06-26 Thread Haozhong Zhang
If LMCE is supported by host and ' mca_caps = [ "lmce" ] ' is present in xl config, the LMCE capability will be exposed in guest MSR_IA32_MCG_CAP. By default, LMCE is not exposed to guest so as to keep the backwards migration compatibility. Signed-off-by: Haozhong Zhang Reviewed-by: Jan Beulich

[Xen-devel] [PATCH v4 11/11] tools/xen-mceinj: add support of injecting LMCE

2017-06-26 Thread Haozhong Zhang
If option '-l' or '--lmce' is specified and the host supports LMCE, xen-mceinj will inject LMCE to CPU specified by '-c' (or CPU0 if '-c' is not present). Signed-off-by: Haozhong Zhang Acked-by: Wei Liu --- Cc: Ian Jackson Cc: Wei Liu --- tools/tests/mce-test/tools/xen-mceinj.c | 50 +

[Xen-devel] [PATCH v4 10/11] tools/libxc: add support of injecting MC# to specified CPUs

2017-06-26 Thread Haozhong Zhang
Though XEN_MC_inject_v2 allows injecting MC# to specified CPUs, the current xc_mca_op() does not use this feature and not provide an interface to callers. This commit add a new xc_mca_op_inject_v2() that receives a cpumap providing the set of target CPUs. Signed-off-by: Haozhong Zhang Acked-by: W

[Xen-devel] [PATCH v4 06/11] x86/vmce: emulate MSR_IA32_MCG_EXT_CTL

2017-06-26 Thread Haozhong Zhang
If MCG_LMCE_P is present in guest MSR_IA32_MCG_CAP, then allow guest to read/write MSR_IA32_MCG_EXT_CTL. Signed-off-by: Haozhong Zhang Reviewed-by: Jan Beulich --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/cpu/mcheck/vmce.c | 34 +- xen/include

[Xen-devel] [PATCH v4 01/11] xen/mce: fix comment of struct mc_telem_cpu_ctl

2017-06-26 Thread Haozhong Zhang
struct mc_telem_cpu_ctl is now used as the type of per-cpu variables, rather than a globla variable shared by all CPUs, so some of its comment do not apply any more. Signed-off-by: Haozhong Zhang --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/cpu/mcheck/mctelem.c | 4 +--- 1 file chang

[Xen-devel] [PATCH v4 00/11] Add LMCE support

2017-06-26 Thread Haozhong Zhang
v3 can be found at https://lists.xenproject.org/archives/html/xen-devel/2017-03/msg04118.html. Changes in v4: * Patch 1 is new and fixes some comment. * Changes to MCE barriers in v3 Patch 1 "x86/mce: handle LMCE locally" is moved out a separated v4 Patch 2. The rest of v3 Patch 1 becomes

[Xen-devel] [PATCH v4 07/11] x86/vmce: enable injecting LMCE to guest on Intel host

2017-06-26 Thread Haozhong Zhang
Inject LMCE to guest if the host MCE is LMCE and the affected vcpu is known. Otherwise, broadcast MCE to all vcpus on Intel host. Signed-off-by: Haozhong Zhang Reviewed-by: Jan Beulich --- Cc: Jan Beulich Cc: Andrew Cooper Changes in v4: (Take Jan's R-b with following changes.) * Change typ

[Xen-devel] [PATCH v4 03/11] x86/mce: handle host LMCE

2017-06-26 Thread Haozhong Zhang
A round of mce_softirq() may handle multiple deferred MCE's. 1/ If all of them are LMCE's, then mce_softirq() is called on one CPU and should not wait for others. 2/ If at least one of them is non-local MCE, then mce_softirq() should sync with other CPUs. mce_softirq() should check those

[Xen-devel] [PATCH v4 02/11] xen/mce: allow mce_barrier_{enter, exit} to return without waiting

2017-06-26 Thread Haozhong Zhang
Add a 'nowait' argument to mce_barrier_{enter,exit}() to allow them return immediately without waiting mce_barrier_{enter,exit}() on other CPUs. This is useful when handling LMCE, where mce_barrier_{enter,exit} are called only on one CPU. Signed-off-by: Haozhong Zhang --- Cc: Jan Beulich Cc: And

[Xen-devel] [PATCH v4 05/11] x86/vmx: expose LMCE feature via guest MSR_IA32_FEATURE_CONTROL

2017-06-26 Thread Haozhong Zhang
If MCG_LMCE_P is present in guest MSR_IA32_MCG_CAP, then set LMCE and LOCK bits in guest MSR_IA32_FEATURE_CONTROL. Intel SDM requires those bits are set before SW can enable LMCE. Signed-off-by: Haozhong Zhang Reviewed-by: Kevin Tian Reviewed-by: Jan Beulich --- Cc: Jan Beulich Cc: Andrew Coop

[Xen-devel] [PATCH v4 04/11] x86/mce_intel: detect and enable LMCE on Intel host

2017-06-26 Thread Haozhong Zhang
Enable LMCE if it's supported by the host CPU. If Xen boot parameter "mce_fb = 1" is present, LMCE will be disabled forcibly. Signed-off-by: Haozhong Zhang Reviewed-by: Jan Beulich --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/cpu/mcheck/mce_intel.c | 46 +

Re: [Xen-devel] [PATCH for-4.9 v3 3/3] xen/livepatch: Don't crash on encountering STN_UNDEF relocations

2017-06-26 Thread Julien Grall
On 26/06/17 02:02, Konrad Rzeszutek Wilk wrote: On Sat, Jun 24, 2017 at 06:28:16PM +0100, Julien Grall wrote: Hi Konrad, On 06/23/2017 03:46 PM, Konrad Rzeszutek Wilk wrote: On Fri, Jun 23, 2017 at 03:36:51PM +0100, Julien Grall wrote: On 23/06/17 15:35, Konrad Rzeszutek Wilk wrote: On F

[Xen-devel] [PATCH v6.1 1/3] x86/vioapic: make gsi_vioapic private

2017-06-26 Thread Roger Pau Monne
And introduce vioapic_get_{mask/vector} in order to replace it's usage. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich --- Cc: Jan Beulich Cc: Andrew Cooper --- Changes since v6: - Constify domain parameter. Changes since v5: - New in this version. --- xen/arch/x86/hvm/vioapic.c

Re: [Xen-devel] clean up and modularize arch dma_mapping interface V2

2017-06-26 Thread Christoph Hellwig
On Sat, Jun 24, 2017 at 10:36:56AM -0500, Benjamin Herrenschmidt wrote: > I think we still need to do it. For example we have a bunch new "funky" > cases. I have no plan to do away with the selection - I just want a better interface than the current one. __

[Xen-devel] [PATCH v6.1 2/3] x86/pt: enable binding of GSIs to a PVH Dom0

2017-06-26 Thread Roger Pau Monne
Achieve this by expanding pt_irq_create_bind in order to support mapping interrupts of type PT_IRQ_TYPE_PCI to a PVH Dom0. GSIs bound to Dom0 are always identity bound, which means the all the fields inside of the u.pci sub-struct are ignored, and only the machine_irq is actually used in order to d

[Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-26 Thread Razvan Cojocaru
Pending livepatch code wants to check if the vm_event wait queues are active, and this is made harder by the fact that they were previously only initialized some time after the domain was created, in vm_event_enable(). This patch initializes the lists immediately after xzalloc()ating the vm_event m

Re: [Xen-devel] [PATCH RFC] Live migration for VMs with QEMU backed local storage

2017-06-26 Thread George Dunlap
On Fri, Jun 23, 2017 at 9:03 AM, Roger Pau Monné wrote: > On Fri, Jun 23, 2017 at 03:42:20AM -0400, Bruno Alvisio wrote: >> This patch is the first attempt on adding live migration of instances with >> local >> storage to Xen. This patch just handles very restricted case of fully >> virtualized H

Re: [Xen-devel] [RFC v2] Proposal: Fuzzing the Hypervisor

2017-06-26 Thread George Dunlap
On Sat, Jun 24, 2017 at 7:42 AM, Felix Schmoll wrote: > Hi, > > here a new version of my proposal for fuzzing the hypervisor. The original > can be found here: [1]. > > == > 1. Motivation and Description > == > Fuzzing is a recent tre

[Xen-devel] [PATCH v1 1/6] vmx: add struct vmx_msr_policy

2017-06-26 Thread Sergey Dyasli
This structure provides a convenient way of accessing contents of VMX MSRs: every bit value is accessible by its name. Bit names match existing Xen's definitions as close as possible. The structure also contains the bitmap of available MSRs since not all of them may be available on a particular H

[Xen-devel] [PATCH v1 0/6] VMX MSRs policy for Nested Virt: part 1

2017-06-26 Thread Sergey Dyasli
The end goal of having VMX MSRs policy is to be able to manage L1 VMX features. This patch series is the first part of this work. There is no functional change to what L1 sees in VMX MSRs at this point. But each domain will have a policy object which allows to sensibly query what VMX features the d

[Xen-devel] [PATCH v1 5/6] vvmx: add per domain vmx msr policy

2017-06-26 Thread Sergey Dyasli
Having a policy per domain allows to sensibly query what VMX features the domain has, which unblocks some other nested virt work items. For now, make policy for each domain equal to hvm_max_vmx_msr_policy. In the future it should be possible to independently configure the policy for each domain.

[Xen-devel] [DEBUG PATCH 6/6] vmx: print H/W VMX MSRs values during startup

2017-06-26 Thread Sergey Dyasli
This is a debug patch I used when developing this series. It's not intended for merging, I post it because it might be useful to someone. Signed-off-by: Sergey Dyasli --- xen/arch/x86/hvm/vmx/vmcs.c | 405 1 file changed, 405 insertions(+) diff --git

[Xen-devel] [PATCH v1 3/6] vmx: refactor vmx_init_vmcs_config()

2017-06-26 Thread Sergey Dyasli
1. Remove RDMSRs of VMX MSRs since all values are already available in raw_vmx_msr_policy. 2. Replace bit operations involving VMX bitmasks with accessing VMX features by name and using vmx_msr_available() where appropriate. Signed-off-by: Sergey Dyasli --- xen/arch/x86/hvm/vmx/vmcs.c | 56

[Xen-devel] [PATCH v1 2/6] vmx: add raw_vmx_msr_policy

2017-06-26 Thread Sergey Dyasli
Add calculate_raw_policy() which fills raw_vmx_msr_policy (the actual contents of H/W VMX MSRs) on the boot CPU. On secondary CPUs, this function checks that contents of VMX MSRs match the boot CPU's contents. Remove lesser version of same-contents-check from vmx_init_vmcs_config(). Signed-off-b

[Xen-devel] [PATCH v1 4/6] vvmx: add hvm_max_vmx_msr_policy

2017-06-26 Thread Sergey Dyasli
Currently, when nested virt is enabled, the set of L1 VMX features is fixed and calculated by nvmx_msr_read_intercept() as an intersection between the full set of Xen's supported L1 VMX features, the set of actual H/W features and, for MSR_IA32_VMX_EPT_VPID_CAP, the set of features that Xen uses.

Re: [Xen-devel] DomU can't start after recompiling DomU(PV) OS kernel

2017-06-26 Thread Juergen Gross
On 06/26/2017 08:37 AM, 謝 東曄 wrote: Xen Version:4.5.5 Guest OS(DomU OS):Ubuntu 14.04 Old kernel: 4.4.0 new recompile Kernel : 4.4.31 // Install DomU OS in image file first, i use dd if=/dev/zero of=test.img bs=1M count=20480 to create 20G empty image file. then use xl create vm.cfg command to

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-26 Thread Konrad Rzeszutek Wilk
On June 26, 2017 5:48:17 AM EDT, Razvan Cojocaru wrote: >Pending livepatch code wants to check if the vm_event wait queues >are active, and this is made harder by the fact that they were Hmm, it wants to? Is there an missing patch that hasn't been posted for this? If you mean to post this _bef

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-26 Thread Razvan Cojocaru
On 06/26/2017 02:39 PM, Konrad Rzeszutek Wilk wrote: > On June 26, 2017 5:48:17 AM EDT, Razvan Cojocaru > wrote: >> Pending livepatch code wants to check if the vm_event wait queues >> are active, and this is made harder by the fact that they were > > > Hmm, it wants to? Is there an missing pat

[Xen-devel] [PATCH] x86/mm: revert to int type in get_spage_pages

2017-06-26 Thread Wei Liu
2b8eb379930 changed the type of i to be unsigned, but the inner loop depends on it being a signed type. Coverity-ID: 1413017 Signed-off-by: Wei Liu --- Cc: Tim Deegan Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [Xen-devel] [PATCH v3 6/9] xen/vpci: trap access to the list of PCI capabilities

2017-06-26 Thread Roger Pau Monne
On Tue, May 23, 2017 at 06:49:50AM -0600, Jan Beulich wrote: > >>> On 27.04.17 at 16:35, wrote: > > Add traps to each capability PCI_CAP_LIST_NEXT field in order to mask them > > on > > request. > > > > All capabilities from the device are fetched and stored in an internal list, > > that's later

Re: [Xen-devel] [PATCH] rombios: prevent building with PIC

2017-06-26 Thread Jan Beulich
>>> Olaf Hering 06/26/17 8:47 AM >>> >Am Mon, 26 Jun 2017 00:30:50 -0600 >schrieb "Jan Beulich" : > >> In the description you also talk about PIE, but you deal with PIC only here. >> Is that intentional? If so, please say why in the description. > >Thats what the URL says. Unclear what the connec

[Xen-devel] [PATCH] x86/mm: Fix infinite loop in get_spage_pages()

2017-06-26 Thread Andrew Cooper
c/s 2b8eb37 switched int i to being unsigned, but the undo logic on failure relied in i being signed. As i being unsigned in still preforable, adjust the undo logic to work with an unsigned i. Coverity-ID: 1413017 Signed-off-by: Andrew Cooper --- CC: Jan Beulich --- xen/arch/x86/mm.c | 2 +- 1

Re: [Xen-devel] [PATCH] x86: xen: remove unnecessary variable in xen_foreach_remap_area()

2017-06-26 Thread Juergen Groß
On 06/24/2017 12:01 AM, Gustavo A. R. Silva wrote: Remove unnecessary variable mfn in function xen_foreach_remap_area() and, refactor the code. Variable mfn at line 518:mfn = xen_remap_buf.mfns[i]; is only being used to store a value to be passed as an argument to the xen_update_mem_tables() fun

Re: [Xen-devel] [PATCH] x86/xen: allow userspace access during hypercalls

2017-06-26 Thread Juergen Groß
On 06/23/2017 02:47 PM, Marek Marczykowski-Górecki wrote: Userspace application can do a hypercall through /dev/xen/privcmd, and some for some hypercalls argument is a pointers to user-provided structure. When SMAP is supported and enabled, hypervisor can't access. So, lets allow it. What about

Re: [Xen-devel] [PATCH] x86/mm: Fix infinite loop in get_spage_pages()

2017-06-26 Thread Konrad Rzeszutek Wilk
On June 26, 2017 7:59:02 AM EDT, Andrew Cooper wrote: >c/s 2b8eb37 switched int i to being unsigned, but the undo logic on >failure >relied in i being signed. As i being unsigned in still preforable, >adjust the >undo logic to work with an unsigned i. > >Coverity-ID: 1413017 >Signed-off-by: Andr

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-26 Thread Andrew Cooper
On 26/06/17 12:39, Konrad Rzeszutek Wilk wrote: > On June 26, 2017 5:48:17 AM EDT, Razvan Cojocaru > wrote: >> Pending livepatch code wants to check if the vm_event wait queues >> are active, and this is made harder by the fact that they were > > Hmm, it wants to? Is there an missing patch that h

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-26 Thread Razvan Cojocaru
On 06/26/2017 03:14 PM, Andrew Cooper wrote: > Razvan: I'd reword this to not mention livepatching. Simply having > list_empty() working is a good enough reason alone. Fair enough, I'll change the patch description as soon as we hear from Tamas, so that I might address as many comments as possibl

[Xen-devel] [xen-4.8-testing test] 111043: tolerable trouble: blocked/broken/fail/pass - PUSHED

2017-06-26 Thread osstest service owner
flight 111043 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/111043/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-

Re: [Xen-devel] [PATCH] x86/xen: allow userspace access during hypercalls

2017-06-26 Thread Marek Marczykowski-Górecki
On Mon, Jun 26, 2017 at 02:05:48PM +0200, Juergen Groß wrote: > On 06/23/2017 02:47 PM, Marek Marczykowski-Górecki wrote: > > Userspace application can do a hypercall through /dev/xen/privcmd, and > > some for some hypercalls argument is a pointers to user-provided > > structure. When SMAP is suppo

[Xen-devel] [PATCH v2] x86/xen: allow userspace access during hypercalls

2017-06-26 Thread Marek Marczykowski-Górecki
Userspace application can do a hypercall through /dev/xen/privcmd, and some for some hypercalls argument is a pointers to user-provided structure. When SMAP is supported and enabled, hypervisor can't access. So, lets allow it. The same applies to HYPERVISOR_dm_op, where additionally privcmd driver

Re: [Xen-devel] [PATCH v2] x86/xen: allow userspace access during hypercalls

2017-06-26 Thread Juergen Groß
On 06/26/2017 02:49 PM, Marek Marczykowski-Górecki wrote: Userspace application can do a hypercall through /dev/xen/privcmd, and some for some hypercalls argument is a pointers to user-provided structure. When SMAP is supported and enabled, hypervisor can't access. So, lets allow it. The same ap

[Xen-devel] [PATCH v2] rombios: prevent building with PIC/PIE

2017-06-26 Thread Olaf Hering
If the default compiler silently defaults to to -fPIC/-fPIE building rombios fails: ld -melf_i386 -s -r 32bitbios.o tcgbios/tcgbiosext.o util.o pmm.o -o 32bitbios_all.o There are undefined symbols in the BIOS: U _GLOBAL_OFFSET_TABLE_ make[10]: *** [Makefile:26: 32bitbios_all.o] Error

Re: [Xen-devel] [PATCH] rombios: prevent building with PIC

2017-06-26 Thread Olaf Hering
Am Mon, 26 Jun 2017 05:55:17 -0600 schrieb "Jan Beulich" : > Unlike PIC, PIE was introduced later, yet might still be defaulted to. Hence > it may be necessary to also deal with that, instead of just addressing one > half. There is now v2 which uses cc-option-add > In the unstable staging tree

[Xen-devel] [distros-debian-sid test] 71599: tolerable trouble: blocked/broken/fail/pass

2017-06-26 Thread Platform Team regression test user
flight 71599 distros-debian-sid real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/71599/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-i386-sid-netboot-pvgrub 10 guest-start fail blocked in 71584 test-amd64-amd64-am

Re: [Xen-devel] [PATCH v2] rombios: prevent building with PIC/PIE

2017-06-26 Thread Andrew Cooper
On 26/06/17 13:55, Olaf Hering wrote: > If the default compiler silently defaults to to -fPIC/-fPIE building > rombios fails: > > ld -melf_i386 -s -r 32bitbios.o tcgbios/tcgbiosext.o util.o pmm.o -o > 32bitbios_all.o > There are undefined symbols in the BIOS: > U _GLOBAL_OFFSET_TABLE_

Re: [Xen-devel] [PATCH] x86/boot: re-arrange how/when we do disk I/O

2017-06-26 Thread Julien Grall
Hi, On 12/06/17 17:59, Julien Grall wrote: Hi Jan, On 12/06/17 16:27, Jan Beulich wrote: On 12.06.17 at 17:11, wrote: We place the trampoline no lower than at 256k, so we have ample space to read the MBRs of BIOS disks into an aligned buffer right below the trampoline (not doing so has been

Re: [Xen-devel] [RFC v2] Proposal: Fuzzing the Hypervisor

2017-06-26 Thread Wei Liu
Nice write-up. Overall this is in line with what we discussed, so I don't really have more comments. On Sat, Jun 24, 2017 at 08:42:50AM +0200, Felix Schmoll wrote: [...] > == > 3.3 Fuzzer > == > The idea is to create some dictionary

Re: [Xen-devel] [PATCH] x86/xen: allow userspace access during hypercalls

2017-06-26 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of > Marek Marczykowski-Górecki > Sent: 26 June 2017 13:45 > To: Juergen Groß > Cc: Andrew Cooper ; x...@kernel.org; linux- > ker...@vger.kernel.org; sta...@vger.kernel.org; xen- > de...@lists.xenproj

Re: [Xen-devel] [PATCH v2 01/16] xen/mm: Don't use _{g, m}fn for defining INVALID_{G, M}FN

2017-06-26 Thread Julien Grall
Hi, On 23/06/17 10:31, Jan Beulich wrote: On 23.06.17 at 11:24, wrote: At 03:18 -0600 on 23 Jun (1498187924), Jan Beulich wrote: How about: - keep INVALID_MFN as an inline function call for most uses; - #define INVALID_MFN_INITIALIZER { ~0UL } for when we need a real constant initializer

[Xen-devel] [xen-4.7-testing baseline-only test] 71598: tolerable trouble: blocked/broken/fail/pass

2017-06-26 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 71598 xen-4.7-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/71598/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-qemuu-nested-intel 16 debian-hvm-ins

Re: [Xen-devel] [PATCH] x86/xen: allow userspace access during hypercalls

2017-06-26 Thread 'Marek Marczykowski-Górecki'
On Mon, Jun 26, 2017 at 01:09:58PM +, Paul Durrant wrote: > > -Original Message- > > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of > > Marek Marczykowski-Górecki > > Sent: 26 June 2017 13:45 > > To: Juergen Groß > > Cc: Andrew Cooper ; x...@kernel.org; linux- >

Re: [Xen-devel] [PATCH] x86/xen: allow userspace access during hypercalls

2017-06-26 Thread Paul Durrant
> -Original Message- > From: 'Marek Marczykowski-Górecki' > [mailto:marma...@invisiblethingslab.com] > Sent: 26 June 2017 14:22 > To: Paul Durrant > Cc: Juergen Groß ; Andrew Cooper > ; x...@kernel.org; linux- > ker...@vger.kernel.org; sta...@vger.kernel.org; xen- > de...@lists.xenproject.

Re: [Xen-devel] [PATCH] x86/mm: Fix infinite loop in get_spage_pages()

2017-06-26 Thread Wei Liu
On Mon, Jun 26, 2017 at 12:59:02PM +0100, Andrew Cooper wrote: > c/s 2b8eb37 switched int i to being unsigned, but the undo logic on failure > relied in i being signed. As i being unsigned in still preforable, adjust the > undo logic to work with an unsigned i. > > Coverity-ID: 1413017 > Signed-o

[Xen-devel] [PATCH] mini-os: link to libgcc.a to fix build with gcc7

2017-06-26 Thread Olaf Hering
gcc7 generates a call to __udivmoddi4 ... stubdom/mini-os-x86_32-grub/mini-os.o: In function `_strtoll_r': stubdom/newlib-x86_32/i686-xen-elf/newlib/libc/stdlib/../../../../../newlib-1.16.0/newlib/libc/stdlib/strtoll_r.c:110: undefined reference to `__udivmoddi4' make[2]: *** [Makefile:167: stubd

[Xen-devel] [qemu-upstream-4.6-testing test] 111045: regressions - FAIL

2017-06-26 Thread osstest service owner
flight 111045 qemu-upstream-4.6-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/111045/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-vhd 10 debian-di-installfail REGR. vs. 106835 Regre

Re: [Xen-devel] [PATCH v2] rombios: prevent building with PIC/PIE

2017-06-26 Thread Andrew Cooper
On 26/06/17 14:00, Andrew Cooper wrote: > On 26/06/17 13:55, Olaf Hering wrote: >> If the default compiler silently defaults to to -fPIC/-fPIE building >> rombios fails: >> >> ld -melf_i386 -s -r 32bitbios.o tcgbios/tcgbiosext.o util.o pmm.o -o >> 32bitbios_all.o >> There are undefined symbols i

Re: [Xen-devel] [PATCH v3 7/9] vpci: add a priority field to the vPCI register initializer

2017-06-26 Thread Roger Pau Monne
On Tue, May 23, 2017 at 06:52:42AM -0600, Jan Beulich wrote: > >>> On 27.04.17 at 16:35, wrote: > > +#define REGISTER_VPCI_INIT(f, p)\ > > + static const struct vpci_register_init\ > > + x##_entry __used_

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-26 Thread Tamas K Lengyel
On Mon, Jun 26, 2017 at 3:48 AM, Razvan Cojocaru wrote: > Pending livepatch code wants to check if the vm_event wait queues > are active, and this is made harder by the fact that they were > previously only initialized some time after the domain was created, > in vm_event_enable(). This patch init

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-26 Thread Andrew Cooper
On 26/06/17 15:52, Tamas K Lengyel wrote: > On Mon, Jun 26, 2017 at 3:48 AM, Razvan Cojocaru > wrote: >> Pending livepatch code wants to check if the vm_event wait queues >> are active, and this is made harder by the fact that they were >> previously only initialized some time after the domain was

Re: [Xen-devel] [PATCH] x86/boot: re-arrange how/when we do disk I/O

2017-06-26 Thread Paul Durrant
> -Original Message- > From: Julien Grall [mailto:julien.gr...@arm.com] > Sent: 26 June 2017 14:04 > To: Jan Beulich > Cc: Andrew Cooper ; Paul Durrant > ; xen-devel ; > Lars Kurth > Subject: Re: [PATCH] x86/boot: re-arrange how/when we do disk I/O > > Hi, > > On 12/06/17 17:59, Julien

[Xen-devel] [PATCH for-4.9] livepatch: Declare live patching as a supported feature

2017-06-26 Thread Ross Lagerwall
Xen Live Patching has been available as tech preview feature since Xen 4.7 and has now had a couple of releases to stabilize. Xen Live patching has been used by multiple vendors to fix several real-world security issues without any severe bugs encountered. Additionally, there are now tests in OSSTe

[Xen-devel] [ovmf test] 111067: all pass - PUSHED

2017-06-26 Thread osstest service owner
flight 111067 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/111067/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 578dbd52b70061fd3442dc5b050479e4f13b9585 baseline version: ovmf 16bad1fbaf897ecd93fb5

Re: [Xen-devel] [PATCH v7 34/36] x86/mm: Add support to encrypt the kernel in-place

2017-06-26 Thread Borislav Petkov
On Fri, Jun 23, 2017 at 12:44:46PM -0500, Tom Lendacky wrote: > Normally the __p4d() macro would be used and that would be ok whether > CONFIG_X86_5LEVEL is defined or not. But since __p4d() is part of the > paravirt ops path I have to use native_make_p4d(). So __p4d is in !CONFIG_PARAVIRT path.

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-26 Thread Tamas K Lengyel
On Mon, Jun 26, 2017 at 9:09 AM, Andrew Cooper wrote: > On 26/06/17 15:52, Tamas K Lengyel wrote: >> On Mon, Jun 26, 2017 at 3:48 AM, Razvan Cojocaru >> wrote: >>> Pending livepatch code wants to check if the vm_event wait queues >>> are active, and this is made harder by the fact that they were

[Xen-devel] [PATCH v5 08/13] x86/traps: factor out pv_trap_init

2017-06-26 Thread Wei Liu
Factor out pv_trap_init and call it at the beginning of trap_init. We then need to tune the code to generate stub handlers in entry.S. Take the chance to tune init_irq_data so that 0x80 and 0x82 can be used in !CONFIG_PV case. While at it, fix some coding style issues in init_irq_data and replace

[Xen-devel] [PATCH v5 04/13] x86: move compat_set_trap_table along side the non-compat variant

2017-06-26 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/pv/callback.c | 47 ++ xen/arch/x86/x86_64/compat/traps.c | 44 --- 2 files changed, 47 insertions(+), 44 deletions(-) diff --git a/xen/arch/x86/pv/callback.c b/xen/arch/x86/pv/cal

[Xen-devel] [PATCH v5 09/13] xen: move do_nmi_op and make it x86 only

2017-06-26 Thread Wei Liu
Since ARM doesn't need do_nmi_op, move the hypercall handler from common/kernel.c to pv/callback.c. Drop the stubs in ARM. Delete the common and ARM nmi.h and adjust header inclusions in various files. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Stefano Stabellini Cc: Juli

[Xen-devel] [PATCH v5 01/13] x86: move callback_op code to pv/callback.c

2017-06-26 Thread Wei Liu
Take the chance to change v to curr. Signed-off-by: Wei Liu --- xen/arch/x86/pv/Makefile| 1 + xen/arch/x86/pv/callback.c | 183 xen/arch/x86/x86_64/traps.c | 148 --- 3 files changed, 184 insertions(+), 148 dele

[Xen-devel] [PATCH v5 02/13] x86: move the compat callback ops next to the non-compat variant

2017-06-26 Thread Wei Liu
Take the chance to change v to curr. Signed-off-by: Wei Liu --- xen/arch/x86/pv/callback.c | 142 xen/arch/x86/x86_64/compat/traps.c | 143 - 2 files changed, 142 insertions(+), 143 deletions(-) diff --git a/xen/ar

[Xen-devel] [PATCH v5 03/13] x86: move do_set_trap_table to pv/callback.c

2017-06-26 Thread Wei Liu
That hypercall is used to set guest callbacks for traps. Signed-off-by: Wei Liu --- xen/arch/x86/pv/callback.c | 50 ++ xen/arch/x86/traps.c | 50 -- 2 files changed, 50 insertions(+), 50 deletions(-)

[Xen-devel] [PATCH v5 05/13] x86: remove the now empty x86_64/compat/traps.c

2017-06-26 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/arch/x86/x86_64/compat/traps.c | 15 --- xen/arch/x86/x86_64/traps.c| 2 -- 2 files changed, 17 deletions(-) delete mode 100644 xen/arch/x86/x86_64/compat/traps.c diff --git a/xen/arch/x86/x86_64/compat/traps.c b/xen/arch/x86/x86_64/compat/tr

[Xen-devel] [PATCH v5 07/13] x86/traps: simplify and rename send_guest_trap

2017-06-26 Thread Wei Liu
Rename it to pv_raise_interrupt. Simplify the code by using the vcpu structure already at hand in the caller. Signed-off-by: Wei Liu --- xen/arch/x86/traps.c | 13 - xen/include/asm-x86/pv/traps.h | 8 xen/include/asm-x86/traps.h| 9 - 3 files change

[Xen-devel] [PATCH v5 06/13] x86: simplify guest_has_trap_callback

2017-06-26 Thread Wei Liu
There is only one caller for that function. Simplify the function, move it close to the caller and rename it. Signed-off-by: Wei Liu --- xen/arch/x86/cpu/mcheck/vmce.c | 11 ++- xen/arch/x86/traps.c | 18 -- xen/include/asm-x86/traps.h| 8 3 files

[Xen-devel] [PATCH v5 00/13] x86: refactor trap handling code

2017-06-26 Thread Wei Liu
This series can also be found on my xenbits/xen.git wip.move-traps-v5 Wei Liu (13): x86: move callback_op code to pv/callback.c x86: move the compat callback ops next to the non-compat variant x86: move do_set_trap_table to pv/callback.c x86: move compat_set_trap_table along side the non-c

Re: [Xen-devel] [PATCH v7 34/36] x86/mm: Add support to encrypt the kernel in-place

2017-06-26 Thread Tom Lendacky
On 6/26/2017 10:45 AM, Borislav Petkov wrote: On Fri, Jun 23, 2017 at 12:44:46PM -0500, Tom Lendacky wrote: Normally the __p4d() macro would be used and that would be ok whether CONFIG_X86_5LEVEL is defined or not. But since __p4d() is part of the paravirt ops path I have to use native_make_p4d(

[Xen-devel] [PATCH] xen/x86: Don't BUG on CPU0 offlining

2017-06-26 Thread Vitaly Kuznetsov
CONFIG_BOOTPARAM_HOTPLUG_CPU0 allows to offline CPU0 but Xen HVM guests BUG() in xen_teardown_timer(). Remove the BUG_ON(), this is probably a leftover from ancient times when CPU0 hotplug was impossible, it works just fine for HVM. Signed-off-by: Vitaly Kuznetsov --- - CPU0 hotplug is currently

Re: [Xen-devel] [PATCH for-4.9] livepatch: Declare live patching as a supported feature

2017-06-26 Thread Andrew Cooper
On 26/06/17 16:36, Ross Lagerwall wrote: > Xen Live Patching has been available as tech preview feature since Xen > 4.7 and has now had a couple of releases to stabilize. Xen Live patching > has been used by multiple vendors to fix several real-world security > issues without any severe bugs encoun

Re: [Xen-devel] [PATCH v5 01/13] x86: move callback_op code to pv/callback.c

2017-06-26 Thread Andrew Cooper
On 26/06/17 17:28, Wei Liu wrote: > Take the chance to change v to curr. > > Signed-off-by: Wei Liu Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [xen-unstable-smoke test] 111075: tolerable trouble: broken/pass - PUSHED

2017-06-26 Thread osstest service owner
flight 111075 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/111075/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 13 mig

[Xen-devel] [PATCH v5 11/13] x86/callback.c: slightly change {un, }register_guest_nmi_callback

2017-06-26 Thread Wei Liu
Make register_guest_nmi_callback return int and make unregister_guest_nmi_callback void. Adjust the callers where necessary. Signed-off-by: Wei Liu --- Can be squashed into previous patch. --- xen/arch/x86/pv/callback.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) d

[Xen-devel] [PATCH v5 10/13] x86/traps: move {un, }register_guest_nmi_callback to pv/callback.c

2017-06-26 Thread Wei Liu
Move these helper functions along side their users. Now all users of these functions are within the same file, make them static. Take the chance to change v to curr and remove some unneeded parentheses. Signed-off-by: Wei Liu --- xen/arch/x86/pv/callback.c | 37 +

[Xen-devel] [PATCH v5 12/13] x86/traps: move some PV specific functions to pv/traps.c

2017-06-26 Thread Wei Liu
Those functions must be moved at the same time. Also move softirq_trap because it is only used there. Fix some coding style issues while moving code. Signed-off-by: Wei Liu --- xen/arch/x86/pv/traps.c | 104 xen/arch/x86/traps.c| 88

[Xen-devel] [PATCH v5 13/13] x86/traps.h: remove unused declaration of cpu_user_regs

2017-06-26 Thread Wei Liu
Signed-off-by: Wei Liu --- xen/include/asm-x86/traps.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/include/asm-x86/traps.h b/xen/include/asm-x86/traps.h index 8d903ec91b..bed25290d7 100644 --- a/xen/include/asm-x86/traps.h +++ b/xen/include/asm-x86/traps.h @@ -19,8 +19,6 @@ #ifndef

Re: [Xen-devel] [PATCH for-4.9] livepatch: Declare live patching as a supported feature

2017-06-26 Thread George Dunlap
On 26/06/17 17:39, Andrew Cooper wrote: >> * Bugs which allow a guest to prevent the application of a livepatch: >> A guest should not be able to prevent the application of a live >> patch. If an unprivileged guest can prevent the application of a >> live patch, it shall be treated as a

Re: [Xen-devel] [PATCH for-4.9] livepatch: Declare live patching as a supported feature

2017-06-26 Thread Ross Lagerwall
On 06/26/2017 05:39 PM, Andrew Cooper wrote: On 26/06/17 16:36, Ross Lagerwall wrote: snip * Unprivileged access to live patching operations: Live patching operations should only be accessible to privileged guests and it shall be treated as a security issue if this is not the cas

Re: [Xen-devel] [PATCH v5 02/13] x86: move the compat callback ops next to the non-compat variant

2017-06-26 Thread Andrew Cooper
On 26/06/17 17:28, Wei Liu wrote: > Take the chance to change v to curr. > > Signed-off-by: Wei Liu Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.9] livepatch: Declare live patching as a supported feature

2017-06-26 Thread Ian Jackson
George Dunlap writes ("Re: [PATCH for-4.9] livepatch: Declare live patching as a supported feature"): > I agree that as long as the patch can be applied after "xl pause", then > the domain cannot be said to be preventing the application of the > livepatch. But if either 'xl pause' doesn't work, o

Re: [Xen-devel] [PATCH v5 03/13] x86: move do_set_trap_table to pv/callback.c

2017-06-26 Thread Andrew Cooper
On 26/06/17 17:28, Wei Liu wrote: > That hypercall is used to set guest callbacks for traps. > > Signed-off-by: Wei Liu Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v5 04/13] x86: move compat_set_trap_table along side the non-compat variant

2017-06-26 Thread Andrew Cooper
On 26/06/17 17:28, Wei Liu wrote: > Signed-off-by: Wei Liu Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v5 05/13] x86: remove the now empty x86_64/compat/traps.c

2017-06-26 Thread Andrew Cooper
On 26/06/17 17:28, Wei Liu wrote: > Signed-off-by: Wei Liu Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v5 06/13] x86: simplify guest_has_trap_callback

2017-06-26 Thread Andrew Cooper
On 26/06/17 17:28, Wei Liu wrote: > There is only one caller for that function. Simplify the function, > move it close to the caller and rename it. > > Signed-off-by: Wei Liu Good improvement. In principle, Reviewed-by: Andrew Cooper , although... > --- > xen/arch/x86/cpu/mcheck/vmce.c | 11 ++

Re: [Xen-devel] [PATCH for-4.9] livepatch: Declare live patching as a supported feature

2017-06-26 Thread George Dunlap
On 26/06/17 16:36, Ross Lagerwall wrote: > Xen Live Patching has been available as tech preview feature since Xen > 4.7 and has now had a couple of releases to stabilize. Xen Live patching > has been used by multiple vendors to fix several real-world security > issues without any severe bugs encoun

Re: [Xen-devel] [PATCH for-4.9] livepatch: Declare live patching as a supported feature

2017-06-26 Thread Andrew Cooper
On 26/06/17 17:50, Ross Lagerwall wrote: > On 06/26/2017 05:39 PM, Andrew Cooper wrote: >> On 26/06/17 16:36, Ross Lagerwall wrote: >> >>> >>> * Bugs which allow a guest to prevent the application of a livepatch: >>> A guest should not be able to prevent the application of a live >>> patc

Re: [Xen-devel] [PATCH for-4.9] livepatch: Declare live patching as a supported feature

2017-06-26 Thread Andrew Cooper
On 26/06/17 17:50, George Dunlap wrote: > On 26/06/17 17:39, Andrew Cooper wrote: >>> * Bugs which allow a guest to prevent the application of a livepatch: >>> A guest should not be able to prevent the application of a live >>> patch. If an unprivileged guest can prevent the application of

[Xen-devel] [qemu-upstream-4.8-testing test] 111049: tolerable trouble: blocked/broken/fail/pass - PUSHED

2017-06-26 Thread osstest service owner
flight 111049 qemu-upstream-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/111049/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl

  1   2   >