Re: [Xen-devel] [PATCH v7 0/7] Xen transport for 9pfs frontend driver

2017-04-10 Thread Juergen Gross
On 05/04/17 21:03, Stefano Stabellini wrote: > Hi all, > > This patch series implements a new transport for 9pfs, aimed at Xen > systems. > > The transport is based on a traditional Xen frontend and backend drivers > pair. This patch series implements the frontend, which typically runs in > a reg

Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-10 Thread Christian Lindig
> On 7. Apr 2017, at 14:27, Jonathan Davies wrote: > > tools/ocaml/xenstored/domain.ml| 4 ++-- > tools/ocaml/xenstored/store.ml | 8 +++- > tools/ocaml/xenstored/xenstored.ml | 10 ++ The OCaml code is looking good and I’d be happy to take it as it is. I noticed that the (

Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-10 Thread Christian Lindig
> On 10. Apr 2017, at 09:33, Wei Liu wrote: > > On Mon, Apr 10, 2017 at 09:10:15AM +0100, Christian Lindig wrote: >> >>> On 7. Apr 2017, at 14:27, Jonathan Davies >>> wrote: >>> >>> tools/ocaml/xenstored/domain.ml| 4 ++-- >>> tools/ocaml/xenstored/store.ml | 8 +++- >>> tools/oc

Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-10 Thread Wei Liu
On Mon, Apr 10, 2017 at 09:10:15AM +0100, Christian Lindig wrote: > > > On 7. Apr 2017, at 14:27, Jonathan Davies > > wrote: > > > > tools/ocaml/xenstored/domain.ml| 4 ++-- > > tools/ocaml/xenstored/store.ml | 8 +++- > > tools/ocaml/xenstored/xenstored.ml | 10 ++ > > The

Re: [Xen-devel] [PATCH for-4.9] xsm: fix clang 3.5 build after c47d1d

2017-04-10 Thread Jan Beulich
>>> On 09.04.17 at 21:01, wrote: > On 04/07/2017 03:54 PM, Jan Beulich wrote: > On 07.04.17 at 16:34, wrote: >>> The changes introduced on c47d1d broke the clang build due to undefined >>> references to __xsm_action_mismatch_detected, because clang hasn't optimized >>> the code properly. >>

Re: [Xen-devel] [PATCH for-4.9] xsm: fix clang 3.5 build after c47d1d

2017-04-10 Thread Roger Pau Monne
On Fri, Apr 07, 2017 at 08:54:59AM -0600, Jan Beulich wrote: > >>> On 07.04.17 at 16:34, wrote: > > The changes introduced on c47d1d broke the clang build due to undefined > > references to __xsm_action_mismatch_detected, because clang hasn't optimized > > the code properly. > > This starts to be

[Xen-devel] [PATCH for-4.9 v2 1/2] xsm: fix clang 3.5 build after c47d1d

2017-04-10 Thread Roger Pau Monne
The changes introduced on c47d1d broke the clang build due to undefined references to __xsm_action_mismatch_detected, because clang hasn't optimized the code properly. The following patch allows the clang build to work again, while keeping the same functionality. Signed-off-by: Roger Pau Monné --

Re: [Xen-devel] [PATCH v5 for-4.9 1/4] hvm/dmop: Box dmop_bufs rather than passing two parameters around

2017-04-10 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: 07 April 2017 20:36 > To: Xen-devel > Cc: Jennifer Herbert ; Andrew Cooper > ; Jan Beulich ; Paul > Durrant ; Julien Grall > Subject: [PATCH v5 for-4.9 1/4] hvm/dmop: Box dmop_bufs rather than > passing

[Xen-devel] [PATCH for-4.9 v2 2/2] x86/dm: fix clang build

2017-04-10 Thread Roger Pau Monne
The current code in dm_op breaks clang build with: dm.c:411:21: error: 'break' is bound to loop, GCC binds it to switch [-Werror,-Wgcc-compat] while ( read_atomic(&p2m->ioreq.entry_count) && ^ xen/include/asm/atomic.h:53:43: note: expanded from macro 'read_atomic'

Re: [Xen-devel] [PATCH v5 for-4.9 3/4] hvm/dmop: Implement copy_{to, from}_guest_buf_offset() helpers

2017-04-10 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: 07 April 2017 20:36 > To: Xen-devel > Cc: Andrew Cooper ; Jan Beulich > ; Paul Durrant ; Julien Grall > > Subject: [PATCH v5 for-4.9 3/4] hvm/dmop: Implement > copy_{to,from}_guest_buf_offset() helpers >

[Xen-devel] [distros-debian-sid test] 71167: tolerable trouble: blocked/broken/fail/pass

2017-04-10 Thread Platform Team regression test user
flight 71167 distros-debian-sid real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/71167/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-i386-sid-netboot-pvgrub 10 guest-start fail blocked in 71143 test-amd64-amd64-i3

Re: [Xen-devel] [PATCH for-4.9 v2 1/2] xsm: fix clang 3.5 build after c47d1d

2017-04-10 Thread Jan Beulich
>>> On 10.04.17 at 11:01, wrote: > The changes introduced on c47d1d broke the clang build due to undefined > references to __xsm_action_mismatch_detected, because clang hasn't optimized > the code properly. The following patch allows the clang build to work again, > while keeping the same function

Re: [Xen-devel] [PATCH for-4.9 v2 2/2] x86/dm: fix clang build

2017-04-10 Thread Jan Beulich
>>> On 10.04.17 at 11:01, wrote: > --- a/xen/arch/x86/hvm/dm.c > +++ b/xen/arch/x86/hvm/dm.c > @@ -408,9 +408,16 @@ static int dm_op(domid_t domid, > { > struct p2m_domain *p2m = p2m_get_hostp2m(d); > > -while ( read_atomic(&p2m->ioreq.entry_count) && > -

Re: [Xen-devel] [PATCH v5 for-4.9 1/4] hvm/dmop: Box dmop_bufs rather than passing two parameters around

2017-04-10 Thread Andrew Cooper
On 10/04/17 10:04, Paul Durrant wrote: >> -Original Message- >> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] >> Sent: 07 April 2017 20:36 >> To: Xen-devel >> Cc: Jennifer Herbert ; Andrew Cooper >> ; Jan Beulich ; Paul >> Durrant ; Julien Grall >> Subject: [PATCH v5 for-4.9 1/4]

Re: [Xen-devel] [PATCH v5 for-4.9 3/4] hvm/dmop: Implement copy_{to, from}_guest_buf_offset() helpers

2017-04-10 Thread Andrew Cooper
On 10/04/17 10:11, Paul Durrant wrote: >> -Original Message- >> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] >> Sent: 07 April 2017 20:36 >> To: Xen-devel >> Cc: Andrew Cooper ; Jan Beulich >> ; Paul Durrant ; Julien Grall >> >> Subject: [PATCH v5 for-4.9 3/4] hvm/dmop: Implemen

Re: [Xen-devel] [PATCH v5 for-4.9 1/4] hvm/dmop: Box dmop_bufs rather than passing two parameters around

2017-04-10 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 10 April 2017 10:29 > To: Paul Durrant ; Xen-devel de...@lists.xen.org> > Cc: Jennifer Herbert ; Jan Beulich > ; Julien Grall > Subject: Re: [PATCH v5 for-4.9 1/4] hvm/dmop: Box dmop_bufs rather than > passing two parameters around > > O

Re: [Xen-devel] [PATCH v5 for-4.9 1/4] hvm/dmop: Box dmop_bufs rather than passing two parameters around

2017-04-10 Thread Jan Beulich
>>> On 07.04.17 at 21:35, wrote: > --- a/xen/arch/x86/hvm/dm.c > +++ b/xen/arch/x86/hvm/dm.c > @@ -25,6 +25,18 @@ > > #include > > +struct dmop_bufs { > +/* > + * Small sanity limit. Enough for all current hypercalls. > + */ > +#define MAX_NR_BUFS 2 > + > +struct xen_dm_op_buf buf[MAX_NR

[Xen-devel] [PATCH] tests/xen-access: Added vm_event emulation tests

2017-04-10 Thread Razvan Cojocaru
This patch adds support for testing instruction emulation when required by the vm_event reply sent for MEM_ACCESS events. To this end, it adds the "emulate_write" and "emulate_exec" parameters that behave like the old "write" and "exec" parameters, except instead of allowing writes / executes for a

Re: [Xen-devel] [PATCH for-4.9 v2 2/2] x86/dm: fix clang build

2017-04-10 Thread Roger Pau Monne
On Mon, Apr 10, 2017 at 03:27:35AM -0600, Jan Beulich wrote: > >>> On 10.04.17 at 11:01, wrote: > > --- a/xen/arch/x86/hvm/dm.c > > +++ b/xen/arch/x86/hvm/dm.c > > @@ -408,9 +408,16 @@ static int dm_op(domid_t domid, > > { > > struct p2m_domain *p2m = p2m_get_hostp2m(d); > >

Re: [Xen-devel] [PATCH v5 for-4.9 2/4] hvm/dmop: Implement copy_{to, from}_guest_buf() in terms of raw accessors

2017-04-10 Thread Jan Beulich
>>> On 07.04.17 at 21:35, wrote: > --- a/xen/arch/x86/hvm/dm.c > +++ b/xen/arch/x86/hvm/dm.c > @@ -37,36 +37,48 @@ struct dmop_bufs { > #undef MAX_NR_BUFS > }; > > -static bool copy_buf_from_guest(const xen_dm_op_buf_t bufs[], > -unsigned int nr_bufs, void *dst,

Re: [Xen-devel] [PATCH v5 for-4.9 3/4] hvm/dmop: Implement copy_{to, from}_guest_buf_offset() helpers

2017-04-10 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 10 April 2017 10:36 > To: Paul Durrant ; Xen-devel de...@lists.xen.org> > Cc: Jan Beulich ; Julien Grall > Subject: Re: [PATCH v5 for-4.9 3/4] hvm/dmop: Implement > copy_{to,from}_guest_buf_offset() helpers > > On 10/04/17 10:11, Paul Du

Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-10 Thread Wei Liu
Cc Julien These are small bug fixes that can be safely committed, IMHO. On Fri, Apr 07, 2017 at 02:27:17PM +0100, Jonathan Davies wrote: > In order to make oxenstored restartable, we need to save internal state > to a file on exit and restore from this file on startup. > > Much of the infrastru

Re: [Xen-devel] [PATCH v5 for-4.9 3/4] hvm/dmop: Implement copy_{to, from}_guest_buf_offset() helpers

2017-04-10 Thread Andrew Cooper
On 10/04/17 10:52, Paul Durrant wrote: >> -Original Message- >> From: Andrew Cooper >> Sent: 10 April 2017 10:36 >> To: Paul Durrant ; Xen-devel > de...@lists.xen.org> >> Cc: Jan Beulich ; Julien Grall >> Subject: Re: [PATCH v5 for-4.9 3/4] hvm/dmop: Implement >> copy_{to,from}_guest_buf_o

Re: [Xen-devel] [PATCH for-4.9 v2 2/2] x86/dm: fix clang build

2017-04-10 Thread Jan Beulich
>>> On 10.04.17 at 11:46, wrote: > On Mon, Apr 10, 2017 at 03:27:35AM -0600, Jan Beulich wrote: >> >>> On 10.04.17 at 11:01, wrote: >> > --- a/xen/arch/x86/hvm/dm.c >> > +++ b/xen/arch/x86/hvm/dm.c >> > @@ -408,9 +408,16 @@ static int dm_op(domid_t domid, >> > { >> > struct

Re: [Xen-devel] [PATCH v5 for-4.9 1/4] hvm/dmop: Box dmop_bufs rather than passing two parameters around

2017-04-10 Thread Andrew Cooper
On 10/04/17 10:40, Paul Durrant wrote: >> >>> Why is this a good thing? Passing two parameters around allowed for them >> to be in registers. I preferred the code as it was before. >> >> a) It will always be inlined, so registers aren't relevant. > Why? I see nothing forcing the compiler to make it

Re: [Xen-devel] [PATCH v5 for-4.9 3/4] hvm/dmop: Implement copy_{to, from}_guest_buf_offset() helpers

2017-04-10 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 10 April 2017 10:57 > To: Paul Durrant ; Xen-devel de...@lists.xen.org> > Cc: Jan Beulich ; Julien Grall > Subject: Re: [PATCH v5 for-4.9 3/4] hvm/dmop: Implement > copy_{to,from}_guest_buf_offset() helpers > > On 10/04/17 10:52, Paul Du

Re: [Xen-devel] [PATCH v5 for-4.9 1/4] hvm/dmop: Box dmop_bufs rather than passing two parameters around

2017-04-10 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 10 April 2017 11:04 > To: Paul Durrant ; Xen-devel de...@lists.xen.org> > Cc: Jennifer Herbert ; Jan Beulich > ; Julien Grall > Subject: Re: [PATCH v5 for-4.9 1/4] hvm/dmop: Box dmop_bufs rather than > passing two parameters around > > O

Re: [Xen-devel] [PATCH RFC] x86/emulate: implement hvmemul_cmpxchg() with an actual CMPXCHG

2017-04-10 Thread Jan Beulich
>>> On 09.04.17 at 00:15, wrote: > On 04/03/2017 09:36 PM, Razvan Cojocaru wrote: >> On 04/03/2017 09:20 PM, Razvan Cojocaru wrote: >>> On 04/01/2017 07:56 PM, Razvan Cojocaru wrote: On 03/31/2017 06:04 PM, Jan Beulich wrote: On 31.03.17 at 17:01, wrote: >> On 03/31/2017 05:46 P

Re: [Xen-devel] [PATCH v5 for-4.9 1/4] hvm/dmop: Box dmop_bufs rather than passing two parameters around

2017-04-10 Thread Paul Durrant
> -Original Message- > From: Jennifer Herbert [mailto:jennifer.herb...@citrix.com] > Sent: 10 April 2017 11:06 > To: Paul Durrant ; Andrew Cooper > ; Xen-devel > Cc: Jan Beulich ; Julien Grall > Subject: Re: [PATCH v5 for-4.9 1/4] hvm/dmop: Box dmop_bufs rather than > passing two paramete

Re: [Xen-devel] [PATCH v5 for-4.9 1/4] hvm/dmop: Box dmop_bufs rather than passing two parameters around

2017-04-10 Thread Jennifer Herbert
On 10/04/17 10:40, Paul Durrant wrote: -Original Message- From: Andrew Cooper Sent: 10 April 2017 10:29 To: Paul Durrant ; Xen-devel Cc: Jennifer Herbert ; Jan Beulich ; Julien Grall Subject: Re: [PATCH v5 for-4.9 1/4] hvm/dmop: Box dmop_bufs rather than passing two parameters around

[Xen-devel] [xen-4.7-testing test] 107319: trouble: blocked/broken/fail/pass

2017-04-10 Thread osstest service owner
flight 107319 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/107319/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale 2 hosts-allocate broken REGR. vs. 10

Re: [Xen-devel] [PATCH for-4.9 v2 2/2] x86/dm: fix clang build

2017-04-10 Thread Roger Pau Monne
On Mon, Apr 10, 2017 at 04:02:37AM -0600, Jan Beulich wrote: > >>> On 10.04.17 at 11:46, wrote: > > On Mon, Apr 10, 2017 at 03:27:35AM -0600, Jan Beulich wrote: > >> >>> On 10.04.17 at 11:01, wrote: > >> > --- a/xen/arch/x86/hvm/dm.c > >> > +++ b/xen/arch/x86/hvm/dm.c > >> > @@ -408,9 +408,16 @@

Re: [Xen-devel] [xen-4.8-testing test] 107259: trouble: blocked/broken/fail/pass

2017-04-10 Thread Ian Jackson
osstest service owner writes ("[xen-4.8-testing test] 107259: trouble: blocked/broken/fail/pass"): > flight 107259 xen-4.8-testing real [real] > http://logs.test-lab.xenproject.org/osstest/logs/107259/ > > Failures and problems with tests :-( > > Tests which did not succeed and are blocking, > i

Re: [Xen-devel] [PATCH for-4.9 v2 1/2] xsm: fix clang 3.5 build after c47d1d

2017-04-10 Thread Julien Grall
Hi Roger, On 10/04/17 10:01, Roger Pau Monne wrote: > The changes introduced on c47d1d broke the clang build due to undefined > references to __xsm_action_mismatch_detected, because clang hasn't optimized > the code properly. The following patch allows the clang build to work again, > while keepin

Re: [Xen-devel] [linux-arm-xen test] 107256: trouble: broken/pass

2017-04-10 Thread Ian Jackson
Julien Grall writes ("Re: [Xen-devel] [linux-arm-xen test] 107256: trouble: broken/pass"): > IIRC Ian decommissioned the Arndale on Friday on my request because they > are too unreliable for testing (we are using a dongle for network that > often fail). Unfortunately, I have found that decommis

Re: [Xen-devel] [PATCH for-4.9 v2 2/2] x86/dm: fix clang build

2017-04-10 Thread Jan Beulich
>>> On 10.04.17 at 12:34, wrote: > On Mon, Apr 10, 2017 at 04:02:37AM -0600, Jan Beulich wrote: >> >>> On 10.04.17 at 11:46, wrote: >> > On Mon, Apr 10, 2017 at 03:27:35AM -0600, Jan Beulich wrote: >> >> >>> On 10.04.17 at 11:01, wrote: >> >> > --- a/xen/arch/x86/hvm/dm.c >> >> > +++ b/xen/arch/

Re: [Xen-devel] [PATCH for-4.9 v2 1/2] xsm: fix clang 3.5 build after c47d1d

2017-04-10 Thread Jan Beulich
>>> On 10.04.17 at 12:39, wrote: > Hi Roger, > > On 10/04/17 10:01, Roger Pau Monne wrote: >> The changes introduced on c47d1d broke the clang build due to undefined >> references to __xsm_action_mismatch_detected, because clang hasn't optimized >> the code properly. The following patch allows th

[Xen-devel] Starting by making a small contribution

2017-04-10 Thread shivani ahuja
Hello, As, its my first day to work for XEN - Hypervisor Project, I need a little guidance on how so I start making my contribution and work along with the project. I have read all the info available on outreachy wiki page. I have to setup my system to work accordingly. Please help me to reach out

Re: [Xen-devel] [PATCH for-4.9 v2 1/2] xsm: fix clang 3.5 build after c47d1d

2017-04-10 Thread Julien Grall
On 10/04/17 11:50, Jan Beulich wrote: On 10.04.17 at 12:39, wrote: Hi Roger, On 10/04/17 10:01, Roger Pau Monne wrote: The changes introduced on c47d1d broke the clang build due to undefined references to __xsm_action_mismatch_detected, because clang hasn't optimized the code properly. The

[Xen-devel] [PATCH] x86emul: add "unblock NMI" retire flag

2017-04-10 Thread Jan Beulich
No matter that we emulate IRET for (guest) real more only right now, we should get its effect on (virtual) NMI delivery right. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -1955,25 +1955,32 @@ static int _hvm_emulate_one(struct hvm_e me

Re: [Xen-devel] [PATCH v1 0/2] libxl: add PV display device driver interface

2017-04-10 Thread Oleksandr Grytsov
Hi Ian, After internal discussion we think that putting positions and z-orders of virtual connectors to the Xen store and libxl configuration is not so good idea. Because their composition depends on an application and usage. We consider automotive usage. For example one of domain drives navigatio

Re: [Xen-devel] [PATCH] tools/golang: Add myself as maintainer

2017-04-10 Thread George Dunlap
On 06/04/17 20:52, Konrad Rzeszutek Wilk wrote: > On Thu, Apr 06, 2017 at 03:57:06PM +0100, George Dunlap wrote: >> Signed-off-by: George Dunlap >> --- >> Andrew Cooper >> Ian Jackson >> Jan Beulich >> Konrad Rzeszutek Wilk >> Stefano Stabellini >> Tim Deegan >> Wei Liu >> --- >> MAINTAINE

Re: [Xen-devel] [PATCH] x86emul: add "unblock NMI" retire flag

2017-04-10 Thread Andrew Cooper
On 10/04/17 11:58, Jan Beulich wrote: > No matter that we emulate IRET for (guest) real more only right now, we > should get its effect on (virtual) NMI delivery right. > > Signed-off-by: Jan Beulich At a minimum, you need to mask unblock_nmi out of the assertion in x86_emulate_wrapper(), as we n

Re: [Xen-devel] [PATCH] x86emul: add "unblock NMI" retire flag

2017-04-10 Thread Jan Beulich
>>> On 10.04.17 at 13:01, wrote: > On 10/04/17 11:58, Jan Beulich wrote: >> No matter that we emulate IRET for (guest) real more only right now, we >> should get its effect on (virtual) NMI delivery right. >> >> Signed-off-by: Jan Beulich > > At a minimum, you need to mask unblock_nmi out of the

Re: [Xen-devel] [PATCH v2 03/10] x86: assembly, use SYM_FUNC_END for functions

2017-04-10 Thread Jiri Slaby
On 03/22/2017, 04:44 PM, Jiri Slaby wrote: > On 03/22/2017, 03:26 PM, Josh Poimboeuf wrote: >> On Mon, Mar 20, 2017 at 01:32:15PM +0100, Jiri Slaby wrote: >>> Somewhere END was used to end a function, elsewhere, nothing was used. >>> So unify it and mark them all by SYM_FUNC_END. >>> >>> Signed-off

[Xen-devel] PCI passthrough will cause unknown device appearance in device manager of Windows OS via xenstore keys

2017-04-10 Thread lidonglin
Hi all: I have one question about PCI passthrough. I found that if I created a VM with host pci device(cfg file as below), there were some xenstore keys exsiting in /local/domain/0 and /local/domain/DomID/. Besides I found one unknown device in device manager of Windows OS with C

Re: [Xen-devel] [PATCH] tools/golang: Add myself as maintainer

2017-04-10 Thread George Dunlap
On 10/04/17 11:37, George Dunlap wrote: > On 06/04/17 20:52, Konrad Rzeszutek Wilk wrote: >> On Thu, Apr 06, 2017 at 03:57:06PM +0100, George Dunlap wrote: >>> Signed-off-by: George Dunlap >>> --- >>> Andrew Cooper >>> Ian Jackson >>> Jan Beulich >>> Konrad Rzeszutek Wilk >>> Stefano Stabellin

Re: [Xen-devel] [PATCH for-4.9] x86/emul: Drop more redundant ctxt.event_pending checks

2017-04-10 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: 10 April 2017 13:15 > To: Xen-devel > Cc: Andrew Cooper ; Jan Beulich > ; Tim (Xen.org) ; Paul Durrant > ; Jun Nakajima ; Kevin > Tian ; Julien Grall > Subject: [PATCH for-4.9] x86/emul: Drop more redund

Re: [Xen-devel] [PATCH for-4.9] x86/emul: Drop more redundant ctxt.event_pending checks

2017-04-10 Thread Andrew Cooper
On 10/04/17 13:24, Paul Durrant wrote: >> -Original Message- >> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] >> Sent: 10 April 2017 13:15 >> To: Xen-devel >> Cc: Andrew Cooper ; Jan Beulich >> ; Tim (Xen.org) ; Paul Durrant >> ; Jun Nakajima ; Kevin >> Tian ; Julien Grall >> Sub

Re: [Xen-devel] [PATCH] xen: Remove event channel notification through Xen PCI platform device

2017-04-10 Thread Raslan, KarimAllah
Unfortunately, this commit is potentially a candidate for reverting. After a lengthy qualification I realized that there is a function called: "xen_strict_xenbus_quirk()" that is being called in the offending path that short-circuits the offending code! So at the moment any domU kernel with this c

Re: [Xen-devel] [PATCH v10 05/25] x86: refactor psr: L3 CAT: implement CPU init and free flow.

2017-04-10 Thread Yi Sun
On 17-04-10 11:27:04, Yi Sun wrote: > On 17-04-07 03:46:42, Jan Beulich wrote: > > >>> On 07.04.17 at 11:08, wrote: > > > On 17-04-07 02:48:40, Jan Beulich wrote: > > >> >>> On 07.04.17 at 07:17, wrote: > > >> > On 17-04-06 08:02:15, Jan Beulich wrote: > > >> >> Okay, so not the context switch pa

Re: [Xen-devel] PCI passthrough will cause unknown device appearance in device manager of Windows OS via xenstore keys

2017-04-10 Thread Andrew Cooper
On 10/04/17 12:24, lidonglin wrote: > > Hi all: > > I have one question about PCI passthrough. I found > that if I created a VM with host pci device(cfg file as below), there > were some xenstore keys exsiting in /local/domain/0 and > /local/domain/DomID/. Besides I found one unknow

[Xen-devel] [PATCH for-4.9] x86/emul: Drop more redundant ctxt.event_pending checks

2017-04-10 Thread Andrew Cooper
Since c/s 92cf67888a, x86_emulate_wrapper() asserts stricter behaviour about the relationship between X86EMUL_EXCEPTION and ctxt.event_pending. These removals should have been included in the aforementioned changeset, and were only omitted due an oversight. Signed-off-by: Andrew Cooper --- CC: J

Re: [Xen-devel] [PATCH] tools/golang: Add myself as maintainer

2017-04-10 Thread Konrad Rzeszutek Wilk
On Mon, Apr 10, 2017 at 12:21:01PM +0100, George Dunlap wrote: > On 10/04/17 11:37, George Dunlap wrote: > > On 06/04/17 20:52, Konrad Rzeszutek Wilk wrote: > >> On Thu, Apr 06, 2017 at 03:57:06PM +0100, George Dunlap wrote: > >>> Signed-off-by: George Dunlap > >>> --- > >>> Andrew Cooper > >>> I

Re: [Xen-devel] [PATCH for-4.9] x86/emul: Drop more redundant ctxt.event_pending checks

2017-04-10 Thread Jan Beulich
>>> On 10.04.17 at 14:14, wrote: > Since c/s 92cf67888a, x86_emulate_wrapper() asserts stricter behaviour about > the relationship between X86EMUL_EXCEPTION and ctxt.event_pending. > > These removals should have been included in the aforementioned changeset, and > were only omitted due an oversig

Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-10 Thread Julien Grall
Hi Wei, On 10/04/17 10:47, Wei Liu wrote: Cc Julien These are small bug fixes that can be safely committed, IMHO. Release-acked-by: Julien Grall Cheers, On Fri, Apr 07, 2017 at 02:27:17PM +0100, Jonathan Davies wrote: In order to make oxenstored restartable, we need to save internal sta

Re: [Xen-devel] PCI passthrough will cause unknown device appearance in device manager of Windows OS via xenstore keys

2017-04-10 Thread Konrad Rzeszutek Wilk
On Mon, Apr 10, 2017 at 01:46:20PM +0100, Andrew Cooper wrote: > On 10/04/17 12:24, lidonglin wrote: > > > > Hi all: > > > > I have one question about PCI passthrough. I found > > that if I created a VM with host pci device(cfg file as below), there > > were some xenstore keys exsit

Re: [Xen-devel] [PATCH 1/2] xen, input: add xen-kbdfront module parameter for setting resolution

2017-04-10 Thread Oleksandr Andrushchenko
Hi, Juergen! On 03/21/2017 07:19 PM, Juergen Gross wrote: Add a parameter for setting the resolution of xen-kbdfront in order to be able to cope with a (virtual) frame buffer of arbitrary resolution. Signed-off-by: Juergen Gross --- drivers/input/misc/xen-kbdfront.c | 10 -- 1 file

Re: [Xen-devel] Please apply "partially revert "xen: Remove event channel..."

2017-04-10 Thread Boris Ostrovsky
On 04/07/2017 06:11 PM, Stefano Stabellini wrote: > On Fri, 7 Apr 2017, Boris Ostrovsky wrote: >> On 04/07/2017 01:36 PM, Stefano Stabellini wrote: >>> On Fri, 7 Apr 2017, Boris Ostrovsky wrote: On 04/07/2017 07:58 AM, Ian Jackson wrote: > tl;dr: > Please apply > > da72ff5

Re: [Xen-devel] [PATCH 1/2] xen, input: add xen-kbdfront module parameter for setting resolution

2017-04-10 Thread Juergen Gross
On 10/04/17 15:44, Oleksandr Andrushchenko wrote: > Hi, Juergen! > > On 03/21/2017 07:19 PM, Juergen Gross wrote: >> Add a parameter for setting the resolution of xen-kbdfront in order to >> be able to cope with a (virtual) frame buffer of arbitrary resolution. >> >> Signed-off-by: Juergen Gross

[Xen-devel] [ovmf test] 107329: all pass - PUSHED

2017-04-10 Thread osstest service owner
flight 107329 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/107329/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 1ea946d0f9ea7de963545fbe93cc7f781c03d0b2 baseline version: ovmf c137d95081690d4877fbe

Re: [Xen-devel] Please apply "partially revert "xen: Remove event channel..."

2017-04-10 Thread Juergen Gross
On 10/04/17 15:47, Boris Ostrovsky wrote: > On 04/07/2017 06:11 PM, Stefano Stabellini wrote: >> On Fri, 7 Apr 2017, Boris Ostrovsky wrote: >>> On 04/07/2017 01:36 PM, Stefano Stabellini wrote: On Fri, 7 Apr 2017, Boris Ostrovsky wrote: > On 04/07/2017 07:58 AM, Ian Jackson wrote: >> t

Re: [Xen-devel] [PATCH 1/2] xen, input: add xen-kbdfront module parameter for setting resolution

2017-04-10 Thread Oleksandr Andrushchenko
On 04/10/2017 04:50 PM, Juergen Gross wrote: On 10/04/17 15:44, Oleksandr Andrushchenko wrote: Hi, Juergen! On 03/21/2017 07:19 PM, Juergen Gross wrote: Add a parameter for setting the resolution of xen-kbdfront in order to be able to cope with a (virtual) frame buffer of arbitrary resolutio

[Xen-devel] [PATCH for-next 7/8] x86/domain: move PV specific code to pv/domain.c

2017-04-10 Thread Wei Liu
Move all the PV specific code along with the supporting code to pv/domain.c. This in turn requires exporting a few functions in header files. Export paravirt context switch functions in domain.h and create pv/pv.h for the rest. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/doma

[Xen-devel] [PATCH for-next 6/8] x86/domain: factor out pv_domain_initialise

2017-04-10 Thread Wei Liu
Lump everything PV related in arch_domain_create into pv_domain_initialise. Though domcr_flags is not necessary, the new function is given one to match hvm counterpart. Since it cleans up after itself there is no need to clean up in arch_domain_create in case of failure. No functional change. S

[Xen-devel] [PATCH for-next 2/8] x86/domain: factor out pv_vcpu_initialise

2017-04-10 Thread Wei Liu
No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/domain.c | 65 --- 1 file changed, 36 insertions(+), 29 deletions(-) diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index 90e2b1f82a..96c777c771 100644 --- a/xen/arch/x86/do

[Xen-devel] [PATCH for-next 8/8] x86/domain: move HVM specific code to hvm/domain.c

2017-04-10 Thread Wei Liu
There is only one function arch_set_info_hvm_guest is moved. The check_segment function is also moved since arch_set_info_hvm_guest is the only user. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/domain.c | 291 - xen/arch/x86/hvm/Make

[Xen-devel] [PATCH for-next 5/8] x86/domain: factor out pv_domain_destroy

2017-04-10 Thread Wei Liu
No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/domain.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index af060d8239..05885a103d 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @

[Xen-devel] [PATCH for-next 4/8] x86/domain: push some code down to hvm_domain_initialise

2017-04-10 Thread Wei Liu
We want to have a single entry point to initialise hvm guest. The timing to set hap bit and create per domain mapping is deferred, but that's not a problem. No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/domain.c | 11 ++- xen/arch/x86/hvm/hvm.c| 25 +

[Xen-devel] [PATCH for-next 3/8] x86/domain: factor out pv_vcpu_destroy

2017-04-10 Thread Wei Liu
No functional change. Signed-off-by: Wei Liu --- xen/arch/x86/domain.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index 96c777c771..ddebff6187 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c

[Xen-devel] [PATCH for-next 0/8] Refactor x86/domain.c

2017-04-10 Thread Wei Liu
This series refactors x86/domain.c to move HVM and PV specific code to their respective directory. The arch_set_info_guest is not touched yet. Refactoring that function will be in another series because 1) I need to touch ARM code as well; 2) I need to do some archaeology to know why it is done li

[Xen-devel] [PATCH for-next 1/8] xen.h: fix comment for vcpu_guest_context

2017-04-10 Thread Wei Liu
Use the correct vcpuop name and delete on trailing white space. Signed-off-by: Wei Liu --- xen/include/public/arch-x86/xen.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h index 8a9ba7982b..f21332e897

Re: [Xen-devel] PCI passthrough will cause unknown device appearance in device manager of Windows OS via xenstore keys

2017-04-10 Thread Wei Liu
On Mon, Apr 10, 2017 at 01:46:20PM +0100, Andrew Cooper wrote: > On 10/04/17 12:24, lidonglin wrote: > > > > Hi all: > > > > I have one question about PCI passthrough. I found > > that if I created a VM with host pci device(cfg file as below), there > > were some xenstore keys exsit

Re: [Xen-devel] [PATCH 1/2] xen, input: add xen-kbdfront module parameter for setting resolution

2017-04-10 Thread Juergen Gross
On 10/04/17 16:00, Oleksandr Andrushchenko wrote: > > > On 04/10/2017 04:50 PM, Juergen Gross wrote: >> On 10/04/17 15:44, Oleksandr Andrushchenko wrote: >>> Hi, Juergen! >>> >>> On 03/21/2017 07:19 PM, Juergen Gross wrote: Add a parameter for setting the resolution of xen-kbdfront in order

Re: [Xen-devel] Please apply "partially revert "xen: Remove event channel..."

2017-04-10 Thread Boris Ostrovsky
On 04/10/2017 09:57 AM, Juergen Gross wrote: > On 10/04/17 15:47, Boris Ostrovsky wrote: >> On 04/07/2017 06:11 PM, Stefano Stabellini wrote: >>> On Fri, 7 Apr 2017, Boris Ostrovsky wrote: On 04/07/2017 01:36 PM, Stefano Stabellini wrote: > On Fri, 7 Apr 2017, Boris Ostrovsky wrote: >>

Re: [Xen-devel] PCI passthrough will cause unknown device appearance in device manager of Windows OS via xenstore keys

2017-04-10 Thread Konrad Rzeszutek Wilk
On Mon, Apr 10, 2017 at 02:28:58PM +0100, Wei Liu wrote: > On Mon, Apr 10, 2017 at 01:46:20PM +0100, Andrew Cooper wrote: > > On 10/04/17 12:24, lidonglin wrote: > > > > > > Hi all: > > > > > > I have one question about PCI passthrough. I found > > > that if I created a VM with host

[Xen-devel] [PATCH for-4.9 v3 2/3] x86/atomic: fix clang build

2017-04-10 Thread Roger Pau Monne
The current code in dm_op breaks clang build with: dm.c:411:21: error: 'break' is bound to loop, GCC binds it to switch [-Werror,-Wgcc-compat] while ( read_atomic(&p2m->ioreq.entry_count) && ^ xen/include/asm/atomic.h:53:43: note: expanded from macro 'read_atomic'

[Xen-devel] [PATCH for-4.9 v3 1/3] xsm: fix clang 3.5 build after c47d1d

2017-04-10 Thread Roger Pau Monne
The changes introduced on c47d1d broke the clang build due to undefined references to __xsm_action_mismatch_detected, because clang hasn't optimized the code properly. The following patch allows the clang build to work again, while keeping the same functionality. Signed-off-by: Roger Pau Monné --

[Xen-devel] [PATCH for-4.9 v3 3/3] x86/atomic: fix cmpxchg16b inline assembly to work with clang

2017-04-10 Thread Roger Pau Monne
clang doesn't understand the "=A" register constrain when used with 64bits assembly and spits out an internal error: fatal error: error in backend: Cannot select: 0x7f9fb89c9390: i64 = build_pair 0x7f9fb89c92b0, 0x7f9fb89c9320 0x7f9fb89c92b0: i32,ch,glue = CopyFromReg 0x7f9fb89c9240, Regi

Re: [Xen-devel] [PATCH 1/2] xen, input: add xen-kbdfront module parameter for setting resolution

2017-04-10 Thread Oleksandr Andrushchenko
On 04/10/2017 05:11 PM, Juergen Gross wrote: On 10/04/17 16:00, Oleksandr Andrushchenko wrote: On 04/10/2017 04:50 PM, Juergen Gross wrote: On 10/04/17 15:44, Oleksandr Andrushchenko wrote: Hi, Juergen! On 03/21/2017 07:19 PM, Juergen Gross wrote: Add a parameter for setting the resolution

Re: [Xen-devel] PCI passthrough will cause unknown device appearance in device manager of Windows OS via xenstore keys

2017-04-10 Thread Andrew Cooper
On 10/04/17 15:12, Konrad Rzeszutek Wilk wrote: > On Mon, Apr 10, 2017 at 02:28:58PM +0100, Wei Liu wrote: >> On Mon, Apr 10, 2017 at 01:46:20PM +0100, Andrew Cooper wrote: >>> On 10/04/17 12:24, lidonglin wrote: Hi all: I have one question about PCI passthrough. I fo

Re: [Xen-devel] [PATCH 2/2] xen, input: repair xen-kbdfront resolution setting via xenstore

2017-04-10 Thread Oleksandr Andrushchenko
On 03/21/2017 07:19 PM, Juergen Gross wrote: Setting the pointing device resolution via Xenstore isn't working reliably: in case XenbusStateInitWait has been missed the resolution settings won't be read. Correct this. Cc: sta...@vger.kernel.org Signed-off-by: Juergen Gross --- drivers/input/m

Re: [Xen-devel] [PATCH for-4.9 v3 1/3] xsm: fix clang 3.5 build after c47d1d

2017-04-10 Thread Daniel De Graaf
On 04/10/2017 09:34 AM, Roger Pau Monne wrote: The changes introduced on c47d1d broke the clang build due to undefined references to __xsm_action_mismatch_detected, because clang hasn't optimized the code properly. The following patch allows the clang build to work again, while keeping the same f

Re: [Xen-devel] [PATCH for-4.9] xsm: fix clang 3.5 build after c47d1d

2017-04-10 Thread Daniel De Graaf
On 04/10/2017 04:41 AM, Roger Pau Monne wrote: On Fri, Apr 07, 2017 at 08:54:59AM -0600, Jan Beulich wrote: On 07.04.17 at 16:34, wrote: The changes introduced on c47d1d broke the clang build due to undefined references to __xsm_action_mismatch_detected, because clang hasn't optimized the code

Re: [Xen-devel] PCI passthrough will cause unknown device appearance in device manager of Windows OS via xenstore keys

2017-04-10 Thread Konrad Rzeszutek Wilk
On Mon, Apr 10, 2017 at 03:21:41PM +0100, Andrew Cooper wrote: > On 10/04/17 15:12, Konrad Rzeszutek Wilk wrote: > > On Mon, Apr 10, 2017 at 02:28:58PM +0100, Wei Liu wrote: > >> On Mon, Apr 10, 2017 at 01:46:20PM +0100, Andrew Cooper wrote: > >>> On 10/04/17 12:24, lidonglin wrote: > Hi all:

[Xen-devel] xl.cfg vfb list parsing issues

2017-04-10 Thread Doug Freed
Hi, This issue came up in the #xen IRC channel on freenode, and Andrew Cooper asked for somebody to email xen-devel so it could be fixed. A user had the following line in their domain config and couldn't figure out why it wasn't working correctly: vfb=['vnclisten="10.1.1.8:2"'] The answer is, o

Re: [Xen-devel] [PATCH for-next 5/8] x86/domain: factor out pv_domain_destroy

2017-04-10 Thread Andrew Cooper
On 10/04/17 14:27, Wei Liu wrote: > No functional change. > > Signed-off-by: Wei Liu Throughout this series, please make sure you add in proper NULL'ing of freed data. While this patch is no functional change at the moment, you have introduced a latent double-free bug for if (/when) pv_domain_de

Re: [Xen-devel] [PATCH for-next 5/8] x86/domain: factor out pv_domain_destroy

2017-04-10 Thread Andrew Cooper
On 10/04/17 16:12, Wei Liu wrote: > On Mon, Apr 10, 2017 at 04:04:22PM +0100, Andrew Cooper wrote: >> On 10/04/17 14:27, Wei Liu wrote: >>> No functional change. >>> >>> Signed-off-by: Wei Liu >> Throughout this series, please make sure you add in proper NULL'ing of >> freed data. >> >> While this

Re: [Xen-devel] [PATCH for-next 4/8] x86/domain: push some code down to hvm_domain_initialise

2017-04-10 Thread Andrew Cooper
On 10/04/17 14:27, Wei Liu wrote: > We want to have a single entry point to initialise hvm guest. The > timing to set hap bit and create per domain mapping is deferred, but > that's not a problem. > > No functional change. > > Signed-off-by: Wei Liu Two observations... > --- > xen/arch/x86/dom

Re: [Xen-devel] [PATCH for-4.9 v3 2/3] x86/atomic: fix clang build

2017-04-10 Thread Jan Beulich
>>> On 10.04.17 at 15:34, wrote: > --- a/xen/include/asm-x86/atomic.h > +++ b/xen/include/asm-x86/atomic.h > @@ -41,20 +41,42 @@ build_add_sized(add_u64_sized, "q", uint64_t, "ri") > #undef build_write_atomic > #undef build_add_sized > > -void __bad_atomic_size(void); > +/* > + * NB: read_atom

Re: [Xen-devel] [PATCH for-4.9 v3 3/3] x86/atomic: fix cmpxchg16b inline assembly to work with clang

2017-04-10 Thread Jan Beulich
>>> On 10.04.17 at 15:34, wrote: > clang doesn't understand the "=A" register constrain when used with 64bits > assembly and spits out an internal error: > > fatal error: error in backend: Cannot select: 0x7f9fb89c9390: i64 = > build_pair 0x7f9fb89c92b0, > 0x7f9fb89c9320 > 0x7f9fb89c92b0

[Xen-devel] [linux-linus test] 107320: regressions - trouble: broken/fail/pass

2017-04-10 Thread osstest service owner
flight 107320 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/107320/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale 2 hosts-allocate broken REGR. vs. 59254 test-armhf-armhf-xl

Re: [Xen-devel] [PATCH for-next 5/8] x86/domain: factor out pv_domain_destroy

2017-04-10 Thread Andrew Cooper
On 10/04/17 16:22, Wei Liu wrote: > On Mon, Apr 10, 2017 at 04:16:12PM +0100, Andrew Cooper wrote: >> On 10/04/17 16:12, Wei Liu wrote: >>> On Mon, Apr 10, 2017 at 04:04:22PM +0100, Andrew Cooper wrote: On 10/04/17 14:27, Wei Liu wrote: > No functional change. > > Signed-off-by: We

Re: [Xen-devel] [PATCH for-4.9 v3 1/3] xsm: fix clang 3.5 build after c47d1d

2017-04-10 Thread Julien Grall
Hi Roger, On 10/04/17 14:34, Roger Pau Monne wrote: The changes introduced on c47d1d broke the clang build due to undefined references to __xsm_action_mismatch_detected, because clang hasn't optimized the code properly. The following patch allows the clang build to work again, while keeping the

Re: [Xen-devel] Please apply "partially revert "xen: Remove event channel..."

2017-04-10 Thread Raslan, KarimAllah
Ahmed, Karim Allah karah...@amazon.de > On Apr 10, 2017, at 3:57 PM, Juergen Gross wrote: > > On 10/04/17 15:47, Boris Ostrovsky wrote: >> On 04/07/2017 06:11 PM, Stefano Stabellini wrote: >>> On Fri, 7 Apr 2017, Boris Ostrovsky wrote: On 04/07/2017 01:36 PM, Stefano Stabellini wrote: >>

Re: [Xen-devel] PCI passthrough will cause unknown device appearance in device manager of Windows OS via xenstore keys

2017-04-10 Thread Sander Eikelenboom
Monday, April 10, 2017, 4:44:47 PM, you wrote: > On Mon, Apr 10, 2017 at 03:21:41PM +0100, Andrew Cooper wrote: >> On 10/04/17 15:12, Konrad Rzeszutek Wilk wrote: >> > On Mon, Apr 10, 2017 at 02:28:58PM +0100, Wei Liu wrote: >> >> On Mon, Apr 10, 2017 at 01:46:20PM +0100, Andrew Cooper wrote: >>

Re: [Xen-devel] [PATCH for-next 5/8] x86/domain: factor out pv_domain_destroy

2017-04-10 Thread Wei Liu
On Mon, Apr 10, 2017 at 04:04:22PM +0100, Andrew Cooper wrote: > On 10/04/17 14:27, Wei Liu wrote: > > No functional change. > > > > Signed-off-by: Wei Liu > > Throughout this series, please make sure you add in proper NULL'ing of > freed data. > > While this patch is no functional change at the

Re: [Xen-devel] [PATCH for-next 5/8] x86/domain: factor out pv_domain_destroy

2017-04-10 Thread Wei Liu
On Mon, Apr 10, 2017 at 04:16:12PM +0100, Andrew Cooper wrote: > On 10/04/17 16:12, Wei Liu wrote: > > On Mon, Apr 10, 2017 at 04:04:22PM +0100, Andrew Cooper wrote: > >> On 10/04/17 14:27, Wei Liu wrote: > >>> No functional change. > >>> > >>> Signed-off-by: Wei Liu > >> Throughout this series, p

[Xen-devel] [xen-4.4-testing test] 107326: regressions - trouble: blocked/broken/fail/pass

2017-04-10 Thread osstest service owner
flight 107326 xen-4.4-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/107326/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xend-qemut-winxpsp3 9 windows-install fail REGR. vs. 106822 Tests which are

[Xen-devel] [libvirt test] 107325: tolerable FAIL - PUSHED

2017-04-10 Thread osstest service owner
flight 107325 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/107325/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-libvirt 13 saverestore-support-checkfail like 107298 test-armhf-armhf-libvirt-xsm 13

  1   2   >