On 10/04/17 13:24, Paul Durrant wrote: >> -----Original Message----- >> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] >> Sent: 10 April 2017 13:15 >> To: Xen-devel <xen-devel@lists.xen.org> >> Cc: Andrew Cooper <andrew.coop...@citrix.com>; Jan Beulich >> <jbeul...@suse.com>; Tim (Xen.org) <t...@xen.org>; Paul Durrant >> <paul.durr...@citrix.com>; Jun Nakajima <jun.nakaj...@intel.com>; Kevin >> Tian <kevin.t...@intel.com>; Julien Grall <julien.gr...@arm.com> >> Subject: [PATCH for-4.9] x86/emul: Drop more redundant >> ctxt.event_pending checks >> >> Since c/s 92cf67888a, x86_emulate_wrapper() asserts stricter behaviour >> about >> the relationship between X86EMUL_EXCEPTION and ctxt.event_pending. >> >> These removals should have been included in the aforementioned >> changeset, and >> were only omitted due an oversight. >> > As long as suitable assertions are in place... > > Reviewed-by: Paul Durrant <paul.durr...@citrix.com>
The assertion in question is ASSERT(ctxt->event_pending == (rc == X86EMUL_EXCEPTION)); in x86_emulate_wrapper() which transparently replaces x86_emulate() in debug builds. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
