Re: [Xen-devel] [PATCH v2 4/9] x86/pagewalk: Clean up guest_supports_* predicates

2017-03-24 Thread Jan Beulich
>>> On 23.03.17 at 18:32, wrote: > On 20/03/17 13:59, Jan Beulich wrote: > On 20.03.17 at 14:36, wrote: >>> On 20/03/17 08:45, Jan Beulich wrote: Also I'm still not really happy with the guest_supports_ prefixes for this and its L2 counterpart: The question here isn't whether the >>

Re: [Xen-devel] [PATCH v2] dm_op: Add xendevicemodel_modified_memory_bulk.

2017-03-24 Thread Jan Beulich
>>> On 23.03.17 at 19:44, wrote: > > On 23/03/17 15:58, Jan Beulich wrote: >>> On 22.03.17 at 20:55, wrote: >>> --- a/xen/arch/x86/hvm/dm.c >>> +++ b/xen/arch/x86/hvm/dm.c >>> @@ -119,56 +119,89 @@ static int set_isa_irq_level(struct domain *d, >>> uint8_t >>> >>> --- a

Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-03-24 Thread Bhupinder Thakur
Hi Julien, >> Three new HVM param handlers added for: >> - allocating a new VIRQ and return to the toolstack > > > This is not necessary. We could hardcode it. I will modify the code to use a fixed SPI for vpl011. > >> - allocating a new event channel for sending/receiving events from Xe

Re: [Xen-devel] [GSoC] GSoC Introduction : Fuzzing Xen hypercall interface

2017-03-24 Thread Felix Schmoll
Hi, this time for real: so I've been reading up on the task quite a bit now and I'd be thankful if you could clarify what exactly you're looking for with the execution path. The AFL-fuzzer seems to make use just of a rather simple representation of that (https://lwn.net/Articles/674854/), so you

Re: [Xen-devel] [PATCH v3 1/3] ring.h: introduce macros to handle monodirectional rings with multiple req sizes

2017-03-24 Thread Jan Beulich
>>> On 23.03.17 at 22:48, wrote: > On Thu, 23 Mar 2017, Stefano Stabellini wrote: >> CC'ing Jan As a first remark, I'm slightly confused by this being v3 when a standalone v3 had been sent on Feb 22 already. >> On Tue, 21 Mar 2017, Stefano Stabellini wrote: >> > +static inline void name##_read_p

Re: [Xen-devel] [PATCH v2 5/9] x86/pagewalk: Helpers for reserved bit handling

2017-03-24 Thread Jan Beulich
>>> On 23.03.17 at 18:35, wrote: > On 23/03/17 17:12, Tim Deegan wrote: >> At 17:02 + on 23 Mar (1490288548), Andrew Cooper wrote: >>> On 23/03/17 16:55, Tim Deegan wrote: At 16:31 + on 16 Mar (1489681899), Andrew Cooper wrote: > Some bits are unconditionally reserved in pagetable

[Xen-devel] [qemu-upstream-4.4-testing test] 106849: tolerable FAIL - PUSHED

2017-03-24 Thread osstest service owner
flight 106849 qemu-upstream-4.4-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/106849/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-winxpsp3 15 guest-localmigrate/x10 fail in 106824 pass in 106849 test-a

Re: [Xen-devel] [xen-unstable test] 106504: regressions - FAIL

2017-03-24 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Wednesday, March 22, 2017 8:48 PM > > > 3. We read RTE 3 times. 1st happens when we set vIRR. 2nd happens when > > pt_update_irq() returns. 3rd happens in pt_intr_post(). If guest > > changes the vector in RTE during the window, it will also i

[Xen-devel] [PATCH v3 2/3] xen/x86: use trampoline e820 buffer for BIOS interface only

2017-03-24 Thread Juergen Gross
Instead of using the E820 raw buffer for BIOS, EFI and multiboot based memory map information use it for the BIOS interface only. This will enable us to support more E820 entries than the limited trampoline located buffer can. Add a new raw e820 table for common purpose and copy the BIOS buffer to

[Xen-devel] [PATCH v3 0/3] xen: support of large memory maps

2017-03-24 Thread Juergen Gross
This patch series is the first part for adding support of large EFI memory maps (> the current limit of 128 entries) while reducing trampoline size. I'm not posting the final patch for making the trampoline size reduction effective in order not to add major rebase work to Daniel's multiboot2 serie

[Xen-devel] [PATCH v3 3/3] xen/x86: support larger memory map from EFI

2017-03-24 Thread Juergen Gross
Use a larger e820 map buffer for non-BIOS memory map sources. This requires to have different defines for the maximum number of E820 map entries for the raw BIOS buffer and the later used struct e820map. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V2: - define E820_BIOS_MAX in asse

[Xen-devel] [PATCH v3 1/3] xen/x86: split boot trampoline into permanent and temporary part

2017-03-24 Thread Juergen Gross
The hypervisor needs a trampoline in low memory for early boot and later for bringing up cpus and during wakeup from suspend. Today this trampoline is kept completely even if most of it isn't needed later. Split the trampoline into a permanent part and a temporary part needed at early boot only. I

Re: [Xen-devel] [PATCH v2 5/9] x86/pagewalk: Helpers for reserved bit handling

2017-03-24 Thread Jan Beulich
>>> On 24.03.17 at 06:45, wrote: > On 23/03/17 18:35, Andrew Cooper wrote: >> Would you prefer ~((uint64_t)_PAGE_PSE_PAT | (_PAGE_PSE_PAT - 1)) or >> ~(_PAGE_PSE_PAT | (_PAGE_PSE_PAT - 1) | 0ULL) > > Wouldn't it be better to just define the _PAGE_PSE bits accordingly? I don't think that's a good

Re: [Xen-devel] [PATCH v2 5/9] x86/pagewalk: Helpers for reserved bit handling

2017-03-24 Thread Juergen Gross
On 24/03/17 08:51, Jan Beulich wrote: On 24.03.17 at 06:45, wrote: >> On 23/03/17 18:35, Andrew Cooper wrote: >>> Would you prefer ~((uint64_t)_PAGE_PSE_PAT | (_PAGE_PSE_PAT - 1)) or >>> ~(_PAGE_PSE_PAT | (_PAGE_PSE_PAT - 1) | 0ULL) >> >> Wouldn't it be better to just define the _PAGE_PSE bit

Re: [Xen-devel] [PATCH 14/18] xen/arm: Unmask the Abort/SError bit in the exception entries

2017-03-24 Thread Wei Chen
Hi Stefano, On 2017/3/24 8:10, Stefano Stabellini wrote: > On Thu, 23 Mar 2017, Julien Grall wrote: >> Hi Wei, >> >> On 23/03/17 03:13, Wei Chen wrote: >>> On 2017/3/23 6:22, Stefano Stabellini wrote: On Wed, 22 Mar 2017, Julien Grall wrote: > Hi Wei, > > On 22/03/17 08:49, Wei Ch

Re: [Xen-devel] [PATCH] x86/mm: relax the check in get_pg_owner

2017-03-24 Thread Jan Beulich
>>> On 23.03.17 at 19:08, wrote: > PVH guest is actually an translated guest. It should be able to > manipulate page table for other domains when acting as Dom0. The same was true for PVHv1, so I'm afraid there's a little more to this. > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -30

Re: [Xen-devel] [xen-unstable test] 106504: regressions - FAIL

2017-03-24 Thread Jan Beulich
>>> On 24.03.17 at 08:48, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Wednesday, March 22, 2017 8:48 PM >> >> > 3. We read RTE 3 times. 1st happens when we set vIRR. 2nd happens when >> > pt_update_irq() returns. 3rd happens in pt_intr_post(). If guest >> > changes the vector

Re: [Xen-devel] [PATCH v2 5/9] x86/pagewalk: Helpers for reserved bit handling

2017-03-24 Thread Jan Beulich
>>> On 24.03.17 at 08:58, wrote: > On 24/03/17 08:51, Jan Beulich wrote: > On 24.03.17 at 06:45, wrote: >>> On 23/03/17 18:35, Andrew Cooper wrote: Would you prefer ~((uint64_t)_PAGE_PSE_PAT | (_PAGE_PSE_PAT - 1)) or ~(_PAGE_PSE_PAT | (_PAGE_PSE_PAT - 1) | 0ULL) >>> >>> Wouldn't it

Re: [Xen-devel] [xen-unstable test] 106504: regressions - FAIL

2017-03-24 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Friday, March 24, 2017 4:18 PM > > >>> On 24.03.17 at 08:48, wrote: > >> From: Jan Beulich [mailto:jbeul...@suse.com] > >> Sent: Wednesday, March 22, 2017 8:48 PM > >> > >> > 3. We read RTE 3 times. 1st happens when we set vIRR. 2nd happens

Re: [Xen-devel] [PATCH v2 5/9] x86/pagewalk: Helpers for reserved bit handling

2017-03-24 Thread Andrew Cooper
On 24/03/2017 07:47, Jan Beulich wrote: On 23.03.17 at 18:35, wrote: >> On 23/03/17 17:12, Tim Deegan wrote: >>> At 17:02 + on 23 Mar (1490288548), Andrew Cooper wrote: On 23/03/17 16:55, Tim Deegan wrote: > At 16:31 + on 16 Mar (1489681899), Andrew Cooper wrote: >> Some

Re: [Xen-devel] [PATCH v10 4/6] VT-d: introduce update_irte to update irte safely

2017-03-24 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Thursday, March 16, 2017 6:29 PM > > >>> On 15.03.17 at 23:39, wrote: > > On Wed, Mar 15, 2017 at 10:48:25AM -0600, Jan Beulich wrote: > > On 15.03.17 at 06:11, wrote: > >>> +/* > >>> + * The following method to update IR

Re: [Xen-devel] [xen-unstable test] 106504: regressions - FAIL

2017-03-24 Thread Tian, Kevin
> From: Tian, Kevin > Sent: Friday, March 24, 2017 4:26 PM > > > From: Jan Beulich [mailto:jbeul...@suse.com] > > Sent: Friday, March 24, 2017 4:18 PM > > > > >>> On 24.03.17 at 08:48, wrote: > > >> From: Jan Beulich [mailto:jbeul...@suse.com] > > >> Sent: Wednesday, March 22, 2017 8:48 PM > > >

[Xen-devel] [PATCH] xen/x86: use 64 bit mask when masking away mfn bits

2017-03-24 Thread Juergen Gross
When using _PAGE_PSE_PAT as base for a negated bit mask make sure it is propagated to 64 bits when applied to a 64 bit value. There seems to be only one place where this is a problem, so fix this by casting _PAGE_PSE_PAT to 64 bits there. Not doing so will probably lead to problems on hosts with

Re: [Xen-devel] [xen-unstable test] 106504: regressions - FAIL

2017-03-24 Thread Andrew Cooper
On 24/03/2017 08:17, Jan Beulich wrote: On 24.03.17 at 08:48, wrote: >>> From: Jan Beulich [mailto:jbeul...@suse.com] >>> Sent: Wednesday, March 22, 2017 8:48 PM >>> 3. We read RTE 3 times. 1st happens when we set vIRR. 2nd happens when pt_update_irq() returns. 3rd happens in pt_in

Re: [Xen-devel] [PATCH v2] xen-platform: separate unplugging of NVMe disks

2017-03-24 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 24 March 2017 00:51 > To: Paul Durrant > Cc: qemu-de...@nongnu.org; xen-de...@lists.xenproject.org; Stefano > Stabellini ; Anthony Perard > > Subject: Re: [PATCH v2] xen-platform: separate unplugging o

Re: [Xen-devel] [PATCH v2 5/9] x86/pagewalk: Helpers for reserved bit handling

2017-03-24 Thread Andrew Cooper
On 24/03/2017 05:45, Juergen Gross wrote: > On 23/03/17 18:35, Andrew Cooper wrote: >> On 23/03/17 17:12, Tim Deegan wrote: >>> At 17:02 + on 23 Mar (1490288548), Andrew Cooper wrote: On 23/03/17 16:55, Tim Deegan wrote: > At 16:31 + on 16 Mar (1489681899), Andrew Cooper wrote: >>>

Re: [Xen-devel] Oprofile Report

2017-03-24 Thread dhara buch
Hi, Yes, when I try to execute 'opreport --symbols --debug-info' command after doing profiling for a .c file (let operf ./test), I am expecting 'test.c:line_no' in linear info field as you are getting 'exact_counts.c:13' in the following: samples %linenr info image name

Re: [Xen-devel] [PATCH v9 2/5] x86/ioreq server: Add DMOP to map guest ram with p2m_ioreq_server to an ioreq server.

2017-03-24 Thread Yu Zhang
On 3/23/2017 4:57 PM, Jan Beulich wrote: On 23.03.17 at 04:23, wrote: On 3/22/2017 10:21 PM, Jan Beulich wrote: On 21.03.17 at 03:52, wrote: --- xen/arch/x86/hvm/dm.c| 37 ++-- xen/arch/x86/hvm/emulate.c | 65 --- xen

Re: [Xen-devel] [PATCH v9 4/5] x86/ioreq server: Asynchronously reset outstanding p2m_ioreq_server entries.

2017-03-24 Thread Yu Zhang
On 3/23/2017 5:00 PM, Jan Beulich wrote: On 23.03.17 at 04:23, wrote: On 3/22/2017 10:29 PM, Jan Beulich wrote: On 21.03.17 at 03:52, wrote: --- a/xen/arch/x86/hvm/ioreq.c +++ b/xen/arch/x86/hvm/ioreq.c @@ -949,6 +949,14 @@ int hvm_map_mem_type_to_ioreq_server(struct domain *d, ioservid_t

Re: [Xen-devel] [PATCH v9 5/5] x86/ioreq server: Synchronously reset outstanding p2m_ioreq_server entries when an ioreq server unmaps.

2017-03-24 Thread Yu Zhang
On 3/23/2017 5:02 PM, Jan Beulich wrote: On 23.03.17 at 04:23, wrote: On 3/22/2017 10:39 PM, Jan Beulich wrote: On 21.03.17 at 03:52, wrote: --- a/xen/arch/x86/hvm/dm.c +++ b/xen/arch/x86/hvm/dm.c @@ -385,16 +385,51 @@ static int dm_op(domid_t domid, case XEN_DMOP_map_mem_type_t

Re: [Xen-devel] [PATCH v9 2/5] x86/ioreq server: Add DMOP to map guest ram with p2m_ioreq_server to an ioreq server.

2017-03-24 Thread Tian, Kevin
> From: Yu Zhang [mailto:yu.c.zh...@linux.intel.com] > Sent: Wednesday, March 22, 2017 6:13 PM > > On 3/22/2017 3:49 PM, Tian, Kevin wrote: > >> From: Yu Zhang [mailto:yu.c.zh...@linux.intel.com] > >> Sent: Tuesday, March 21, 2017 10:53 AM > >> > >> A new DMOP - XEN_DMOP_map_mem_type_to_ioreq_serv

Re: [Xen-devel] [PATCH 1/3] x86/vlapic: Fix vLAPIC Timer to behave more like real-hw

2017-03-24 Thread Jan Beulich
>>> On 23.03.17 at 12:46, wrote: > This patch takes care of change of timer mode between periodic and > one-shot, because the timer is not reset this happen. So I have to admit that I have some general difficulties with a patch submission like this: The patch title is not really making clear whic

Re: [Xen-devel] [PATCH v9 4/5] x86/ioreq server: Asynchronously reset outstanding p2m_ioreq_server entries.

2017-03-24 Thread Tian, Kevin
> From: Yu Zhang [mailto:yu.c.zh...@linux.intel.com] > Sent: Wednesday, March 22, 2017 6:12 PM > > On 3/22/2017 4:10 PM, Tian, Kevin wrote: > >> From: Yu Zhang [mailto:yu.c.zh...@linux.intel.com] > >> Sent: Tuesday, March 21, 2017 10:53 AM > >> > >> After an ioreq server has unmapped, the remainin

Re: [Xen-devel] [PATCH 2/3] x86/vlapic: Handle change of timer Divide Configuration Register

2017-03-24 Thread Jan Beulich
>>> On 23.03.17 at 12:47, wrote: > When the divide value change, uptade the timer according to the new > value, and keep the Counter Register (TMCCT) value the same between > before and after the divisor change. General and formatting comments given on patch 1 apply here too, the logic looks okay

Re: [Xen-devel] [PATCH 3/3] x86/vlapic: Reset LAPIC Timer only on TSC Deadline mode change

2017-03-24 Thread Jan Beulich
>>> On 23.03.17 at 12:47, wrote: > For the LAPIC timer, switching between periodic and one-shot does not > reset anything on real-hardward, but switching from TSC deadline or to > it does reset the timer, according to Intel manual. Oh, I see that I've overlooked this when reviewing patch 1 (I was

[Xen-devel] [PATCH] tools/firmware: add ACPI device for Windows laptop/slate mode switch

2017-03-24 Thread Paul Durrant
Microsoft have defined an ACPI device to support switching Windows 10 between laptop/desktop mode and slate/tablet mode [1]. This patch adds an SSDT containing such a device. The presence of the device is controlled by a new 'acpi_conv' boolean in xl.cfg. The new device will not be present by defa

Re: [Xen-devel] [PATCH] tools/firmware: add ACPI device for Windows laptop/slate mode switch

2017-03-24 Thread Paul Durrant
> -Original Message- > From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: 24 March 2017 10:03 > To: xen-de...@lists.xenproject.org > Cc: Paul Durrant ; Owen Smith > ; Ian Jackson ; Wei Liu > ; Jan Beulich ; Andrew Cooper > > Subject: [PATCH] tools/firmware: add ACPI device for Win

Re: [Xen-devel] [PATCH] xen/x86: use 64 bit mask when masking away mfn bits

2017-03-24 Thread Jan Beulich
>>> On 24.03.17 at 09:50, wrote: > When using _PAGE_PSE_PAT as base for a negated bit mask make sure it is > propagated to 64 bits when applied to a 64 bit value. > > There seems to be only one place where this is a problem, so fix this > by casting _PAGE_PSE_PAT to 64 bits there. > > Not doing

[Xen-devel] [PATCH v2] tools/firmware: add ACPI device for Windows laptop/slate mode switch

2017-03-24 Thread Paul Durrant
Microsoft have defined an ACPI device to support switching Windows 10 between laptop/desktop mode and slate/tablet mode [1]. This patch adds an SSDT containing such a device. The presence of the device is controlled by a new 'acpi_conv' boolean in xl.cfg. The new device will not be present by defa

[Xen-devel] [PATCH] docs: update HVM emulated unplug protocol to cover NVMe disks

2017-03-24 Thread Paul Durrant
This patch defines a new bit in the mask used to instruct QEMU to unplug emulated devices. See thread [1] for the related discussion. [1] https://lists.xen.org/archives/html/xen-devel/2017-03/msg02924.html Signed-off-by: Paul Durrant --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc:

Re: [Xen-devel] [PATCH v9 2/5] x86/ioreq server: Add DMOP to map guest ram with p2m_ioreq_server to an ioreq server.

2017-03-24 Thread Jan Beulich
>>> On 24.03.17 at 10:05, wrote: > On 3/23/2017 4:57 PM, Jan Beulich wrote: > On 23.03.17 at 04:23, wrote: >>> On 3/22/2017 10:21 PM, Jan Beulich wrote: >>> On 21.03.17 at 03:52, wrote: > @@ -177,8 +178,64 @@ static int hvmemul_do_io( >break; >case X86EMUL

Re: [Xen-devel] [PATCH 0/2] libxl: add PV display device driver interface

2017-03-24 Thread Oleksandr Grytsov
On 23.03.17 17:55, al1img . wrote: On Thu, Mar 23, 2017 at 4:58 PM, Juergen Gross wrote: On 23/03/17 15:23, al1img . wrote: This example is clear. But still wrapper macro is required to make it visible for libxen client (xl): #define LIBXL_DEFINE_DEVICE_LIST_FREE(type) void libxl_device_

Re: [Xen-devel] [PATCH v9 4/5] x86/ioreq server: Asynchronously reset outstanding p2m_ioreq_server entries.

2017-03-24 Thread Jan Beulich
>>> On 24.03.17 at 10:05, wrote: > > On 3/23/2017 5:00 PM, Jan Beulich wrote: > On 23.03.17 at 04:23, wrote: >>> On 3/22/2017 10:29 PM, Jan Beulich wrote: >>> On 21.03.17 at 03:52, wrote: > --- a/xen/arch/x86/hvm/ioreq.c > +++ b/xen/arch/x86/hvm/ioreq.c > @@ -949,6 +949,14

Re: [Xen-devel] [PATCH 01/11] xen/arm: vpl011: Add pl011 uart emulation in Xen

2017-03-24 Thread Bhupinder Thakur
Hi Julien, On 23 March 2017 at 19:46, Julien Grall wrote: >>> It makes little sense to hardcode the MMIO region and not the SPI. Also, >>> I >>> would rather avoid to introduce new HVM_PARAM when not necessary. So >>> hardcoding the value looks more sensible to me. >>> >> So for reserving a SPI f

Re: [Xen-devel] [PATCH 1/2] xen/arm32: Introduce alternative runtime patching

2017-03-24 Thread Julien Grall
On 03/17/2017 06:35 AM, Wei Chen wrote: Hi Julien, Hi Wei, Sorry for the late answer, I missed that e-mail. On 2017/3/17 6:24, Julien Grall wrote: On 03/16/2017 09:53 AM, Wei Chen wrote: [...] +/* + * Decode the branch offset from a branch instruction's imm field. + * The branch offset

Re: [Xen-devel] [PATCH] docs: update HVM emulated unplug protocol to cover NVMe disks

2017-03-24 Thread George Dunlap
On 24/03/17 10:15, Paul Durrant wrote: > This patch defines a new bit in the mask used to instruct QEMU to unplug > emulated devices. See thread [1] for the related discussion. > > [1] https://lists.xen.org/archives/html/xen-devel/2017-03/msg02924.html I don't think including a link like this is

Re: [Xen-devel] [PATCH] docs: update HVM emulated unplug protocol to cover NVMe disks

2017-03-24 Thread Paul Durrant
> -Original Message- > From: George Dunlap [mailto:george.dun...@citrix.com] > Sent: 24 March 2017 10:49 > To: Paul Durrant ; xen-de...@lists.xenproject.org > Cc: Andrew Cooper ; George Dunlap > ; Ian Jackson ; Jan > Beulich ; Konrad Rzeszutek Wilk > ; Stefano Stabellini ; Tim > (Xen.org) ;

Re: [Xen-devel] [PATCH] docs: update HVM emulated unplug protocol to cover NVMe disks

2017-03-24 Thread George Dunlap
On 24/03/17 10:49, Paul Durrant wrote: >> -Original Message- >> From: George Dunlap [mailto:george.dun...@citrix.com] >> Sent: 24 March 2017 10:49 >> To: Paul Durrant ; xen-de...@lists.xenproject.org >> Cc: Andrew Cooper ; George Dunlap >> ; Ian Jackson ; Jan >> Beulich ; Konrad Rzeszutek W

[Xen-devel] [PATCH v2] tools/firmware: add ACPI device for Windows laptop/slate mode switch

2017-03-24 Thread Jan Beulich
>>> On 24.03.17 at 11:10, wrote: > @@ -406,6 +407,16 @@ static int construct_secondary_tables(struct acpi_ctxt > *ctxt, > printf("S4 disabled\n"); > } > > +if ( config->table_flags & ACPI_HAS_SSDT_CONV ) > +{ > +ssdt = ctxt->mem_ops.alloc(ctxt, sizeof(ssdt_conv), 1

Re: [Xen-devel] [PATCH v2] boot allocator: Use arch helper for virt_to_mfn on DIRECTMAP

2017-03-24 Thread Julien Grall
Hi Vijay, On 03/15/2017 05:11 AM, Vijay Kilari wrote: On Tue, Mar 14, 2017 at 9:02 PM, Julien Grall wrote: Hello Vijay, On 13/03/17 11:43, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K On ARM, virt_to_mfn uses the hardware for address translation. So if the virtual address is not map

Re: [Xen-devel] [PATCH v2 09/27] ARM: GICv3: introduce separate pending_irq structs for LPIs

2017-03-24 Thread Julien Grall
Hi Andre, On 03/23/2017 08:08 PM, André Przywara wrote: On 22/03/17 23:44, Stefano Stabellini wrote: On Thu, 16 Mar 2017, Andre Przywara wrote: For the same reason that allocating a struct irq_desc for each possible LPI is not an option, having a struct pending_irq for each LPI is also not fea

[Xen-devel] [PATCH v2] docs: update HVM emulated unplug protocol to cover NVMe disks

2017-03-24 Thread Paul Durrant
Recent discussions on xen-devel have highlighted that to properly support displacing emulated NVMe disks with PV equivalents will need updates to PV frontends. Therefore it is important that, if an emulated NVMe disk is exposed to a guest with an existing PV storage frontend, that frontend does not

Re: [Xen-devel] Oprofile Report

2017-03-24 Thread dhara buch
Actually, I am compiling a very simple c program test.c with gcc -g test.c -o test but it is not affecting output. Is there any way by which I can check whether the binary image generates debug info or not? On Fri, Mar 24, 2017 at 3:26 PM, Michael Petlan wrote: > Please read my previous messag

Re: [Xen-devel] [PATCH v2] tools/firmware: add ACPI device for Windows laptop/slate mode switch

2017-03-24 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 24 March 2017 10:53 > To: Paul Durrant > Cc: Andrew Cooper ; Owen Smith > ; Wei Liu ; Ian Jackson > ; xen-de...@lists.xenproject.org > Subject: [PATCH v2] tools/firmware: add ACPI device for Windows > laptop/slate

Re: [Xen-devel] [PATCH] x86/mm: relax the check in get_pg_owner

2017-03-24 Thread Wei Liu
On Fri, Mar 24, 2017 at 02:12:47AM -0600, Jan Beulich wrote: > >>> On 23.03.17 at 19:08, wrote: > > PVH guest is actually an translated guest. It should be able to > > manipulate page table for other domains when acting as Dom0. > > The same was true for PVHv1, so I'm afraid there's a little more

Re: [Xen-devel] [PATCH v2] tools/firmware: add ACPI device for Windows laptop/slate mode switch

2017-03-24 Thread Jan Beulich
>>> On 24.03.17 at 12:04, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 24 March 2017 10:53 >> The only other concern I have here is that the abbreviation "conv" >> used throughout the patch is sort of ambiguous. I think it means >> "convertible" here, but without knowing the con

Re: [Xen-devel] [PATCH] x86/mm: relax the check in get_pg_owner

2017-03-24 Thread Jan Beulich
>>> On 24.03.17 at 12:08, wrote: > On Fri, Mar 24, 2017 at 02:12:47AM -0600, Jan Beulich wrote: >> >>> On 23.03.17 at 19:08, wrote: >> > PVH guest is actually an translated guest. It should be able to >> > manipulate page table for other domains when acting as Dom0. >> >> The same was true for P

Re: [Xen-devel] [PATCH] x86/mm: relax the check in get_pg_owner

2017-03-24 Thread Wei Liu
On Fri, Mar 24, 2017 at 05:17:51AM -0600, Jan Beulich wrote: > >>> On 24.03.17 at 12:08, wrote: > > On Fri, Mar 24, 2017 at 02:12:47AM -0600, Jan Beulich wrote: > >> >>> On 23.03.17 at 19:08, wrote: > >> > PVH guest is actually an translated guest. It should be able to > >> > manipulate page tabl

Re: [Xen-devel] [PATCH v3 1/3] xen/x86: split boot trampoline into permanent and temporary part

2017-03-24 Thread Jan Beulich
>>> On 24.03.17 at 08:48, wrote: > The hypervisor needs a trampoline in low memory for early boot and > later for bringing up cpus and during wakeup from suspend. Today this > trampoline is kept completely even if most of it isn't needed later. > > Split the trampoline into a permanent part and a

Re: [Xen-devel] [RFC PATCH 9/9] xen: Add use_iommu flag to createdomain domctl

2017-03-24 Thread Oleksandr Tyshchenko
Hi Jan On Thu, Mar 23, 2017 at 7:05 PM, Jan Beulich wrote: On 23.03.17 at 17:36, wrote: >> On Wed, Mar 22, 2017 at 5:56 PM, Jan Beulich wrote: >> On 15.03.17 at 21:05, wrote: --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -66,6 +66,9 @@ struct xe

Re: [Xen-devel] [PATCH v2] tools/firmware: add ACPI device for Windows laptop/slate mode switch

2017-03-24 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 24 March 2017 11:16 > To: Paul Durrant > Cc: Andrew Cooper ; Ian Jackson > ; Owen Smith ; Wei Liu > ; xen-de...@lists.xenproject.org > Subject: RE: [PATCH v2] tools/firmware: add ACPI device for Windows > laptop/sl

Re: [Xen-devel] [PATCH v3 2/3] xen/x86: use trampoline e820 buffer for BIOS interface only

2017-03-24 Thread Jan Beulich
>>> On 24.03.17 at 08:48, wrote: > Instead of using the E820 raw buffer for BIOS, EFI and multiboot based > memory map information use it for the BIOS interface only. This will > enable us to support more E820 entries than the limited trampoline > located buffer can. > > Add a new raw e820 table

Re: [Xen-devel] [PATCH v2] tools/firmware: add ACPI device for Windows laptop/slate mode switch

2017-03-24 Thread Jan Beulich
>>> On 24.03.17 at 12:19, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 24 March 2017 11:16 >> To: Paul Durrant >> Cc: Andrew Cooper ; Ian Jackson >> ; Owen Smith ; Wei Liu >> ; xen-de...@lists.xenproject.org >> Subject: RE: [PATCH v2] tools/firmw

[Xen-devel] [PATCH v2] x86/mm: fix the check in get_pg_owner

2017-03-24 Thread Wei Liu
PVH (both v1 and v2) guest is actually an translated guest. It should be able to manipulate page table for other domains when acting as Dom0. The removal of PVHv1 deleted the special case for PVH guest but didn't add a check for HVM guest. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew C

Re: [Xen-devel] [RFC PATCH 9/9] xen: Add use_iommu flag to createdomain domctl

2017-03-24 Thread Jan Beulich
>>> On 24.03.17 at 12:19, wrote: > Hi Jan > > On Thu, Mar 23, 2017 at 7:05 PM, Jan Beulich wrote: > On 23.03.17 at 17:36, wrote: >>> On Wed, Mar 22, 2017 at 5:56 PM, Jan Beulich wrote: >>> On 15.03.17 at 21:05, wrote: > --- a/xen/include/public/domctl.h > +++ b/xen/include/pub

Re: [Xen-devel] [PATCH v2] x86/mm: fix the check in get_pg_owner

2017-03-24 Thread Jan Beulich
>>> On 24.03.17 at 12:34, wrote: > PVH (both v1 and v2) guest is actually an translated guest. It should be > able to manipulate page table for other domains when acting as Dom0. > > The removal of PVHv1 deleted the special case for PVH guest but didn't > add a check for HVM guest. > > Signed-of

Re: [Xen-devel] [PATCH] tools/libxenforeignmemory: add a call to restrict the handle

2017-03-24 Thread Wei Liu
On Wed, Mar 22, 2017 at 11:25:25AM +, Paul Durrant wrote: > Commit 8ef5f344d061 "tools/libxendevicemodel: add a call to restrict the > handle" added a function to the devicemodel interface to restrict > operations through the API to a specific domain, where a capable under- > lying privcmd driv

Re: [Xen-devel] [PATCH v2] tools/firmware: add ACPI device for Windows laptop/slate mode switch

2017-03-24 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 24 March 2017 11:33 > To: Paul Durrant > Cc: Andrew Cooper ; Ian Jackson > ; Owen Smith ; Wei Liu > ; xen-de...@lists.xenproject.org > Subject: RE: [PATCH v2] tools/firmware: add ACPI device for Windows > laptop/sl

Re: [Xen-devel] [PATCH v2 09/27] ARM: GICv3: introduce separate pending_irq structs for LPIs

2017-03-24 Thread Julien Grall
Hi Andre On 03/16/2017 11:20 AM, Andre Przywara wrote: diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c index 364d5f0..e5cfa54 100644 --- a/xen/arch/arm/vgic.c +++ b/xen/arch/arm/vgic.c @@ -30,6 +30,8 @@ #include #include +#include +#include I really don't want to see gic_v3_* hea

Re: [Xen-devel] [PATCH v2] docs: update HVM emulated unplug protocol to cover NVMe disks

2017-03-24 Thread Wei Liu
On Fri, Mar 24, 2017 at 11:00:13AM +, Paul Durrant wrote: > Recent discussions on xen-devel have highlighted that to properly > support displacing emulated NVMe disks with PV equivalents will need > updates to PV frontends. Therefore it is important that, if an emulated > NVMe disk is exposed t

Re: [Xen-devel] [PATCH v2 02/27] ARM: GICv3: allocate LPI pending and property table

2017-03-24 Thread Julien Grall
Hi Andre, On 03/23/2017 06:21 PM, Andre Przywara wrote: Hi, On 23/03/17 18:01, Stefano Stabellini wrote: On Thu, 23 Mar 2017, Julien Grall wrote: Hi Stefano, On 23/03/17 17:45, Stefano Stabellini wrote: On Thu, 23 Mar 2017, Julien Grall wrote: So as I mentioned before, I am happy to loose

Re: [Xen-devel] [PATCH] tools/firmware: use a canned config for seabios

2017-03-24 Thread Wei Liu
On Thu, Mar 23, 2017 at 05:03:09PM +, Paul Durrant wrote: > The use of seabios defconfig kills boot performance of Windows guests > because the default is for the int13 handler to use PIO when accessing > the emulated IDE device. > > By instead using a canned configuration with the ATA setting

Re: [Xen-devel] [PATCH] xen/Makefile: remove all temporary files for every architecture

2017-03-24 Thread Wei Liu
On Thu, Mar 23, 2017 at 02:31:37AM +0100, Luca Miccio wrote: > Execute the clean target for both arm and x86 architecture. > > When trying to build Xen for a different architecture in the same > tree, the command make clean will only remove temporary files for > the host architecture. > This will

Re: [Xen-devel] [PATCH v2 08/27] ARM: GICv3 ITS: introduce host LPI array

2017-03-24 Thread Julien Grall
Hi Stefano, On 03/23/2017 05:52 PM, Stefano Stabellini wrote: On Thu, 23 Mar 2017, Andre Przywara wrote: On Thu, 23 Mar 2017, Julien Grall wrote: Not answering directly to the question. But I think this is an improvement and not necessary for a first version. I would like to see this series me

Re: [Xen-devel] [PATCH] tools/firmware: use a canned config for seabios

2017-03-24 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 24 March 2017 11:47 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; Ian Jackson ; > Wei Liu > Subject: Re: [PATCH] tools/firmware: use a canned config for seabios > > On Thu, Mar 23, 2017 at 05:03:09PM +00

Re: [Xen-devel] [PATCH v2] docs: update HVM emulated unplug protocol to cover NVMe disks

2017-03-24 Thread George Dunlap
On 24/03/17 11:00, Paul Durrant wrote: > Recent discussions on xen-devel have highlighted that to properly > support displacing emulated NVMe disks with PV equivalents will need > updates to PV frontends. Therefore it is important that, if an emulated > NVMe disk is exposed to a guest with an exist

Re: [Xen-devel] [PATCH v2 10/27] ARM: GICv3: forward pending LPIs to guests

2017-03-24 Thread Julien Grall
Hi Andre, On 03/16/2017 11:20 AM, Andre Przywara wrote: Upon receiving an LPI, we need to find the right VCPU and virtual IRQ number to get this IRQ injected. Iterate our two-level LPI table to find this information quickly when the host takes an LPI. Call the existing injection function to let

Re: [Xen-devel] [PATCH v2 12/27] ARM: vGICv3: handle virtual LPI pending and property tables

2017-03-24 Thread Julien Grall
Hi Andre, On 03/16/2017 11:20 AM, Andre Przywara wrote: Allow a guest to provide the address and size for the memory regions it has reserved for the GICv3 pending and property tables. We sanitise the various fields of the respective redistributor registers and map those pages into Xen's address

Re: [Xen-devel] [GSoC] GSoC Introduction : Fuzzing Xen hypercall interface

2017-03-24 Thread Juergen Gross
Hi Felix, On 24/03/17 08:34, Felix Schmoll wrote: > On another note, would it be possible to apply for a second project > (Adding Floating Point support to Mini-OS) without having to do another > patch? Sure. In case both projects get selected you have to pick one of them. The patch you've sent

Re: [Xen-devel] [PATCH v3 2/3] xen/x86: use trampoline e820 buffer for BIOS interface only

2017-03-24 Thread Juergen Gross
On 24/03/17 12:24, Jan Beulich wrote: On 24.03.17 at 08:48, wrote: >> Instead of using the E820 raw buffer for BIOS, EFI and multiboot based >> memory map information use it for the BIOS interface only. This will >> enable us to support more E820 entries than the limited trampoline >> located

Re: [Xen-devel] [PATCH v2 13/27] ARM: vGICv3: Handle disabled LPIs

2017-03-24 Thread Julien Grall
Hi Andre, On 03/16/2017 11:20 AM, Andre Przywara wrote: If a guest disables an LPI, we do not forward this to the associated host LPI to avoid queueing commands to the host ITS command queue. So it may happen that an LPI fires nevertheless on the host. In this case we can bail out early, but hav

Re: [Xen-devel] [PATCH v9 2/5] x86/ioreq server: Add DMOP to map guest ram with p2m_ioreq_server to an ioreq server.

2017-03-24 Thread Yu Zhang
On 3/24/2017 5:26 PM, Tian, Kevin wrote: From: Yu Zhang [mailto:yu.c.zh...@linux.intel.com] Sent: Wednesday, March 22, 2017 6:13 PM On 3/22/2017 3:49 PM, Tian, Kevin wrote: From: Yu Zhang [mailto:yu.c.zh...@linux.intel.com] Sent: Tuesday, March 21, 2017 10:53 AM A new DMOP - XEN_DMOP_map_mem

Re: [Xen-devel] [PATCH v9 2/5] x86/ioreq server: Add DMOP to map guest ram with p2m_ioreq_server to an ioreq server.

2017-03-24 Thread Yu Zhang
On 3/24/2017 6:19 PM, Jan Beulich wrote: On 24.03.17 at 10:05, wrote: On 3/23/2017 4:57 PM, Jan Beulich wrote: On 23.03.17 at 04:23, wrote: On 3/22/2017 10:21 PM, Jan Beulich wrote: On 21.03.17 at 03:52, wrote: @@ -177,8 +178,64 @@ static int hvmemul_do_io( break; ca

Re: [Xen-devel] [PATCH v9 4/5] x86/ioreq server: Asynchronously reset outstanding p2m_ioreq_server entries.

2017-03-24 Thread Yu Zhang
On 3/24/2017 6:37 PM, Jan Beulich wrote: On 24.03.17 at 10:05, wrote: On 3/23/2017 5:00 PM, Jan Beulich wrote: On 23.03.17 at 04:23, wrote: On 3/22/2017 10:29 PM, Jan Beulich wrote: On 21.03.17 at 03:52, wrote: --- a/xen/arch/x86/hvm/ioreq.c +++ b/xen/arch/x86/hvm/ioreq.c @@ -949,6 +949

Re: [Xen-devel] [PATCH v2 14/27] ARM: vGICv3: introduce basic ITS emulation bits

2017-03-24 Thread Julien Grall
Hi Andre, On 03/16/2017 11:20 AM, Andre Przywara wrote: Create a new file to hold the emulation code for the ITS widget. For now we emulate the memory mapped ITS registers and provide a stub to introduce the ITS command handling framework (but without actually emulating any commands at this time

[Xen-devel] [linux-linus test] 106857: regressions - FAIL

2017-03-24 Thread osstest service owner
flight 106857 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/106857/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 11 guest-start fail REGR. vs. 59254 test-armhf-armhf-li

Re: [Xen-devel] [PATCH v9 4/5] x86/ioreq server: Asynchronously reset outstanding p2m_ioreq_server entries.

2017-03-24 Thread Yu Zhang
On 3/24/2017 5:37 PM, Tian, Kevin wrote: From: Yu Zhang [mailto:yu.c.zh...@linux.intel.com] Sent: Wednesday, March 22, 2017 6:12 PM On 3/22/2017 4:10 PM, Tian, Kevin wrote: From: Yu Zhang [mailto:yu.c.zh...@linux.intel.com] Sent: Tuesday, March 21, 2017 10:53 AM After an ioreq server has unm

Re: [Xen-devel] [GSoC] GSoC Introduction : Fuzzing Xen hypercall interface

2017-03-24 Thread Wei Liu
On Fri, Mar 24, 2017 at 08:34:46AM +0100, Felix Schmoll wrote: > Hi, > > this time for real: > > so I've been reading up on the task quite a bit now and I'd be thankful if > you could clarify what exactly you're looking for with the execution path. > The AFL-fuzzer seems to make use just of a rat

Re: [Xen-devel] [PATCH v2 15/27] ARM: vITS: introduce translation table walks

2017-03-24 Thread Julien Grall
Hi Andre, On 03/16/2017 11:20 AM, Andre Przywara wrote: The ITS stores the target (v)CPU and the (virtual) LPI number in tables. Introduce functions to walk those tables and translate an device ID - event ID pair into a pair of virtual LPI and vCPU. Since the final interrupt translation tables c

Re: [Xen-devel] [RFC PATCH 9/9] xen: Add use_iommu flag to createdomain domctl

2017-03-24 Thread Oleksandr Tyshchenko
On Fri, Mar 24, 2017 at 1:38 PM, Jan Beulich wrote: On 24.03.17 at 12:19, wrote: >> Hi Jan >> >> On Thu, Mar 23, 2017 at 7:05 PM, Jan Beulich wrote: >> On 23.03.17 at 17:36, wrote: On Wed, Mar 22, 2017 at 5:56 PM, Jan Beulich wrote: On 15.03.17 at 21:05, wrote: >> -

Re: [Xen-devel] [PATCH v9 2/5] x86/ioreq server: Add DMOP to map guest ram with p2m_ioreq_server to an ioreq server.

2017-03-24 Thread Jan Beulich
>>> On 24.03.17 at 13:35, wrote: > Besides, even the p2m_get_ioreq_server() is used here in > ept_p2m_type_to_flags(), it can only > provide a limited protection, there's a chance that returned flag in > ept_p2m_type_to_flags() > be outdated in above situation. > > So, since we do not really ca

[Xen-devel] [PATCH RFC] x86/emulate: implement hvmemul_cmpxchg() with an actual CMPXCHG

2017-03-24 Thread Razvan Cojocaru
hvmemul_cmpxchg() is no presently SMP-safe, as it ends up doing a memcpy(). Use an actual CMPXCHG instruction in the implementation. Signed-off-by: Razvan Cojocaru --- Questions: - I've used __cmpxchg(), as it's already there, but it always locks. In my tests and in x86_emulate()'s context,

[Xen-devel] [PATCH v3] tools/firmware: add ACPI device for Windows laptop/slate mode switch

2017-03-24 Thread Paul Durrant
Microsoft have defined an ACPI device to support switching Windows 10 between laptop/desktop mode and slate/tablet mode [1]. This patch adds an SSDT containing such a device. The presence of the device is controlled by a new 'acpi_conv' boolean in xl.cfg. The new device will not be present by defa

Re: [Xen-devel] [PATCH v3] tools/firmware: add ACPI device for Windows laptop/slate mode switch

2017-03-24 Thread Paul Durrant
> -Original Message- > From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: 24 March 2017 13:29 > To: xen-de...@lists.xenproject.org > Cc: Paul Durrant ; Owen Smith > ; Ian Jackson ; Wei Liu > ; Jan Beulich ; Andrew Cooper > > Subject: [PATCH v3] tools/firmware: add ACPI device for

[Xen-devel] [PATCH v4] tools/firmware: add ACPI device for Windows laptop/slate mode switch

2017-03-24 Thread Paul Durrant
Microsoft have defined an ACPI device to support switching Windows 10 between laptop/desktop mode and slate/tablet mode [1]. This patch adds an SSDT containing such a device. The presence of the device is controlled by a new 'acpi_laptop_slate' boolean in xl.cfg. The new device will not be present

[Xen-devel] [qemu-mainline test] 106866: tolerable FAIL - PUSHED

2017-03-24 Thread osstest service owner
flight 106866 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/106866/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-libvirt 13 saverestore-support-checkfail like 106828 test-amd64-i386-xl-qemuu-w

[Xen-devel] [PATCH v3] xen-platform: separate unplugging of NVMe disks

2017-03-24 Thread Paul Durrant
Commit 090fa1c8 "add support for unplugging NVMe disks..." extended the existing disk unplug flag to cover NVMe disks as well as IDE and SCSI. The recent thread on the xen-devel mailing list [1] has highlighted that this is not desirable behaviour: PV frontends should be able to distinguish NVMe d

[Xen-devel] [GIT PULL] xen: fix for 4.11 rc4

2017-03-24 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.11b-rc4-tag xen: fix for 4.11 rc4 It contains a fix for PM under Xen. Thanks. Juergen drivers/xen/xen-acpi-processor.c | 36 +++- 1 file changed,

Re: [Xen-devel] [PATCH 0/2 v2] xen/acpi: upload PM state from init-domain to Xen

2017-03-24 Thread Konrad Rzeszutek Wilk
On Thu, Mar 23, 2017 at 12:45:51PM -0400, Boris Ostrovsky wrote: > On 03/21/2017 06:43 PM, Ankur Arora wrote: > > This patch series re-enables the upload of PM data from initial-domain > > to Xen. This was broken in commit cd979883b9ede90643e019f33cb317933eb867b4. > > > > The upload now happens pos

[Xen-devel] [xen-unstable-smoke test] 106887: tolerable trouble: broken/fail/pass - PUSHED

2017-03-24 Thread osstest service owner
flight 106887 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/106887/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 12 mig

  1   2   >