Re: [Xen-devel] [PATCH v3] x86/apicv: Enhance posted-interrupt processing

2017-03-03 Thread Tian, Kevin
> From: Gao, Chao > Sent: Thursday, March 02, 2017 12:28 PM > > On Thu, Mar 02, 2017 at 02:41:55AM -0700, Jan Beulich wrote: > On 02.03.17 at 02:49, wrote: > >> +if ( cpu != smp_process_id() ) > > > >Did you not even build test this patch? I don't think the construct > >above compile

Re: [Xen-devel] [PATCH 1/2] x86/hvm: Don't raise #GP behind the emulators back for CR accesses

2017-03-03 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, March 02, 2017 11:00 PM > > hvm_set_cr{0,4}() are reachable from the emulator, but use > hvm_inject_hw_exception() directly. > > Alter the API to make the callers of hvm_set_cr{0,3,4}() responsible for > raising #GP, and a

Re: [Xen-devel] [PATCH v1 1/2] x86/vvmx: check vmcs address in vmread/vmwrite

2017-03-03 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Wednesday, March 01, 2017 11:40 PM > > >>> On 01.03.17 at 16:23, wrote: > > On Wed, 2017-03-01 at 07:28 -0700, Jan Beulich wrote: > >> > > > On 01.03.17 at 15:22, wrote: > >> > > >> > On Wed, 2017-03-01 at 07:04 -0700, Jan Beulich wrote: > >

[Xen-devel] [xen-unstable test] 106383: regressions - FAIL

2017-03-03 Thread osstest service owner
flight 106383 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/106383/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 15 guest-start/debian.repeat fail REGR. vs. 106351 Regressions whi

Re: [Xen-devel] [PATCH v1 2/2] x86/vvmx: add vmcs id check into vmptrld emulation

2017-03-03 Thread Tian, Kevin
> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] > Sent: Wednesday, March 01, 2017 5:14 PM > > If a guest will do vmptrld with an incorrect vmcs id: > > (XEN) Xen BUG at .../git/upstream/xen/xen/include/asm/hvm/vmx/vmx.h:333 > (XEN) [ Xen-4.9-unstable x86_64 debug=y Tainted:H ]

Re: [Xen-devel] [RFC PATCH] mm, hotplug: get rid of auto_online_blocks

2017-03-03 Thread Michal Hocko
On Thu 02-03-17 18:03:15, Igor Mammedov wrote: > On Thu, 2 Mar 2017 15:28:16 +0100 > Michal Hocko wrote: > > > On Thu 02-03-17 14:53:48, Igor Mammedov wrote: > > [...] > > > When trying to support memory unplug on guest side in RHEL7, > > > experience shows otherwise. Simplistic udev rule which o

Re: [Xen-devel] [PATCH v9 1/8] VMX: Permanently assign PI hook vmx_pi_switch_to()

2017-03-03 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Wednesday, March 01, 2017 3:42 PM > > >>> On 01.03.17 at 01:01, wrote: > > On Tue, Feb 28, 2017 at 09:43:09AM -0700, Jan Beulich wrote: > > On 27.02.17 at 02:45, wrote: > >>> --- a/xen/arch/x86/hvm/vmx/vmx.c > >>> +++ b/xen/arch/x86/hvm/

[Xen-devel] [libvirt test] 106394: tolerable FAIL - PUSHED

2017-03-03 Thread osstest service owner
flight 106394 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/106394/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-libvirt 13 saverestore-support-checkfail like 106352 test-armhf-armhf-libvirt-xsm 13

[Xen-devel] [PATCH] tools/xenstore: define off_t

2017-03-03 Thread Olaf Hering
talloc.h uses off_t, but did not include Fixes 7012548e0d ("xenstore: enhance control command support") Signed-off-by: Olaf Hering --- tools/xenstore/talloc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/xenstore/talloc.h b/tools/xenstore/talloc.h index c849bf61af..71a36e7be0 100

Re: [Xen-devel] [PATCH] tools/xenstore: define off_t

2017-03-03 Thread Wei Liu
On Fri, Mar 03, 2017 at 08:52:09AM +, Olaf Hering wrote: > talloc.h uses off_t, but did not include > Fixes 7012548e0d ("xenstore: enhance control command support") I think this issue is exposed by that particular commit. That commit is fine in itself. So I would simply delete the "Fixes ..."

Re: [Xen-devel] [PATCH] xen-netback: fix race condition on XenBus disconnect

2017-03-03 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 02 March 2017 22:57 > To: net...@vger.kernel.org; xen-de...@lists.xenproject.org > Cc: Paul Durrant ; jgr...@suse.com; Wei Liu > ; Igor Druzhinin > Subject: [PATCH] xen-netback: fix race condition on Xen

Re: [Xen-devel] [PATCH 1/6] xen: credit1: simplify csched_runq_steal() a little bit.

2017-03-03 Thread anshul makkar
On 02/03/17 10:38, Dario Faggioli wrote: Since we're holding the lock on the pCPU from which we are trying to steal, it can't have disappeared, so we can drop the check for that (and convert it in an ASSERT()). And since we try to steal only from busy pCPUs, it's unlikely for such pCPU to be i

[Xen-devel] [PATCH v4] x86/apicv: Fix wrong IPI suppression during posted interrupt delivery

2017-03-03 Thread Chao Gao
__vmx_deliver_posted_interrupt() wrongly used a softirq bit to decide whether to suppress an IPI. Its logic was: the first time an IPI was sent, we set the softirq bit. Next time, we would check that softirq bit before sending another IPI. If the 1st IPI arrived at the pCPU which was in non-root mo

[Xen-devel] [PATCH RFC 5/5] x86: clean up header files in domain_build.c

2017-03-03 Thread Wei Liu
Remove the ones that are no longer needed and sort them. Signed-off-by: Wei Liu --- xen/arch/x86/domain_build.c | 40 ++-- 1 file changed, 6 insertions(+), 34 deletions(-) diff --git a/xen/arch/x86/domain_build.c b/xen/arch/x86/domain_build.c index 64a978473d

[Xen-devel] [PATCH RFC 2/5] xen: include xen/types.h in domain.h

2017-03-03 Thread Wei Liu
The public header expects a few types to be present. This works in the code base only because types.h is included by some other headers which happen to be placed before the inclusion of domain.h. Include types.h before xen.h in domain.h to fix it properly. Signed-off-by: Wei Liu --- xen/includ

[Xen-devel] [PATCH RFC 4/5] x86: split PVH dom0 builder to domain_build_pv.c

2017-03-03 Thread Wei Liu
Long term we want to be able to disentangle PV and HVM code. Move the PVH domain builder to a dedicated file. It will later depends on CONFIG_HVM or CONFIG_PVH. This in turn requires exposing a few functions and variables via domain_build.h. Signed-off-by: Wei Liu --- xen/arch/x86/Makefile

[Xen-devel] [PATCH RFC 3/5] x86: split PV dom0 builder to domain_build_pv.c

2017-03-03 Thread Wei Liu
Long term we want to be able to disentangle PV and HVM code. Move the PV domain builder to a dedicated file. This in turn requires exposing a few functions and variables via a new header domain_build.h. Signed-off-by: Wei Liu --- xen/arch/x86/Makefile | 1 + xen/arch/x86/domain_build

[Xen-devel] [PATCH RFC 1/5] xen: move round_pg{up,down} to pfn.h

2017-03-03 Thread Wei Liu
They are going to be needed in multiple places. Instead of replicating more, move them to pfn.h. Signed-off-by: Wei Liu --- xen/arch/x86/domain_build.c | 3 --- xen/common/page_alloc.c | 4 +--- xen/include/xen/pfn.h | 3 +++ 3 files changed, 4 insertions(+), 6 deletions(-) diff --git

[Xen-devel] [PATCH RFC 0/5] Refactor x86 domain builder

2017-03-03 Thread Wei Liu
Long term we want to separate different sets of guest supporting code. We would like to have CONFIG_HVM and CONFIG_PV (maybe even CONFIG_PVH?). I will start to dientangle Xen code component by component. This is also somewhat related to the project to move PV interface inside a PVH container, whic

Re: [Xen-devel] [PATCH 2/6] xen: credit: (micro) optimize csched_runq_steal().

2017-03-03 Thread anshul makkar
On 02/03/17 10:38, Dario Faggioli wrote: Chacking whether or not a vCPU can be 'stolen' from a peer pCPU's runqueue is relatively cheap. Therefore, let's do that as early as possible, avoiding potentially useless complex checks, and cpumask manipulations. Signed-off-by: Dario Faggioli --- C

Re: [Xen-devel] [PATCH v2 5/5] xen: use libxendevicemodel when available

2017-03-03 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 02 March 2017 22:50 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; qemu-de...@nongnu.org; Stefano > Stabellini ; Anthony Perard > > Subject: Re: [PATCH v2 5/5] xen: use libxendevicemodel when

Re: [Xen-devel] [PATCH] x86/cpuid: Fix booting on AMD Phenom 6-core platform

2017-03-03 Thread Jan Beulich
>>> On 02.03.17 at 21:02, wrote: > c/s 5cecf60f4 "x86/cpuid: Handle leaf 0x1 in guest_cpuid()" causes Linux 4.10 > to crash during boot. > > It turns out to be because of the reported apic_id, which was altered to be > more consistent across guests. Revert back to the previous behaviour, by > li

Re: [Xen-devel] [PATCH RFC 0/5] Refactor x86 domain builder

2017-03-03 Thread Jan Beulich
>>> On 03.03.17 at 10:41, wrote: > Long term we want to separate different sets of guest supporting code. We > would > like to have CONFIG_HVM and CONFIG_PV (maybe even CONFIG_PVH?). I will start > to dientangle Xen code component by component. This is also somewhat related > to > the project t

Re: [Xen-devel] [PATCH RFC 1/5] xen: move round_pg{up, down} to pfn.h

2017-03-03 Thread Jan Beulich
>>> On 03.03.17 at 10:41, wrote: > --- a/xen/include/xen/pfn.h > +++ b/xen/include/xen/pfn.h > @@ -6,4 +6,7 @@ > #define PFN_DOWN(x) ((x) >> PAGE_SHIFT) > #define PFN_UP(x) (((x) + PAGE_SIZE-1) >> PAGE_SHIFT) > > +#define round_pgup(_p)(((_p)+(PAGE_SIZE-1))&PAGE_MASK) > +#define roun

Re: [Xen-devel] [PATCH RFC 2/5] xen: include xen/types.h in domain.h

2017-03-03 Thread Jan Beulich
>>> On 03.03.17 at 10:41, wrote: > The public header expects a few types to be present. > > This works in the code base only because types.h is included by some > other headers which happen to be placed before the inclusion of > domain.h. > > Include types.h before xen.h in domain.h to fix it pr

Re: [Xen-devel] [PATCH 1/2] x86/hvm: Don't raise #GP behind the emulators back for CR accesses

2017-03-03 Thread Jan Beulich
>>> On 02.03.17 at 15:59, wrote: > hvm_set_cr{0,4}() are reachable from the emulator, but use > hvm_inject_hw_exception() directly. > > Alter the API to make the callers of hvm_set_cr{0,3,4}() responsible for > raising #GP, and apply this change to all existing callers. As you're touching CR-wri

Re: [Xen-devel] [PATCH RFC 1/5] xen: move round_pg{up, down} to pfn.h

2017-03-03 Thread Wei Liu
On Fri, Mar 03, 2017 at 03:05:05AM -0700, Jan Beulich wrote: > >>> On 03.03.17 at 10:41, wrote: > > --- a/xen/include/xen/pfn.h > > +++ b/xen/include/xen/pfn.h > > @@ -6,4 +6,7 @@ > > #define PFN_DOWN(x) ((x) >> PAGE_SHIFT) > > #define PFN_UP(x) (((x) + PAGE_SIZE-1) >> PAGE_SHIFT) > > >

Re: [Xen-devel] [PATCH 2/2] x86/emul: Hold x86_emulate() to strict X86EMUL_EXCEPTION requirements

2017-03-03 Thread Jan Beulich
>>> On 02.03.17 at 15:59, wrote: > All known paths raising faults behind the back of the emulator have fixed. "have been fixed"? > Reinstate the original intended assertion concerning the behaviour of > X86EMUL_EXCEPTION and ctxt->event_pending. > > As x86_emulate_wrapper() now covers both PV a

Re: [Xen-devel] [PATCH 1/2] x86/hvm: Don't raise #GP behind the emulators back for CR accesses

2017-03-03 Thread Andrew Cooper
On 03/03/17 10:16, Jan Beulich wrote: On 02.03.17 at 15:59, wrote: >> hvm_set_cr{0,4}() are reachable from the emulator, but use >> hvm_inject_hw_exception() directly. >> >> Alter the API to make the callers of hvm_set_cr{0,3,4}() responsible for >> raising #GP, and apply this change to all e

Re: [Xen-devel] [PATCH 1/2] x86/hvm: Don't raise #GP behind the emulators back for CR accesses

2017-03-03 Thread Jan Beulich
>>> On 03.03.17 at 11:30, wrote: > On 03/03/17 10:16, Jan Beulich wrote: > On 02.03.17 at 15:59, wrote: >>> --- a/xen/arch/x86/hvm/vmx/vvmx.c >>> +++ b/xen/arch/x86/hvm/vmx/vvmx.c >>> @@ -1046,9 +1046,18 @@ static void load_shadow_guest_state(struct vcpu *v) >>> >>> nvcpu->guest_cr[0]

Re: [Xen-devel] [PATCH v2 5/5] xen: use libxendevicemodel when available

2017-03-03 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 02 March 2017 22:50 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; qemu-de...@nongnu.org; Stefano > Stabellini ; Anthony Perard > > Subject: Re: [PATCH v2 5/5] xen: use libxendevicemodel when

Re: [Xen-devel] [PATCH] x86/cpuid: Fix booting on AMD Phenom 6-core platform

2017-03-03 Thread Andrew Cooper
On 02/03/17 20:02, Andrew Cooper wrote: > c/s 5cecf60f4 "x86/cpuid: Handle leaf 0x1 in guest_cpuid()" causes Linux 4.10 > to crash during boot. > > It turns out to be because of the reported apic_id, which was altered to be > more consistent across guests. Revert back to the previous behaviour, by

Re: [Xen-devel] [PATCH] x86/cpuid: Fix booting on AMD Phenom 6-core platform

2017-03-03 Thread Sander Eikelenboom
On 03/03/17 11:40, Andrew Cooper wrote: > On 02/03/17 20:02, Andrew Cooper wrote: >> c/s 5cecf60f4 "x86/cpuid: Handle leaf 0x1 in guest_cpuid()" causes Linux 4.10 >> to crash during boot. >> >> It turns out to be because of the reported apic_id, which was altered to be >> more consistent across gue

Re: [Xen-devel] [PATCH] x86/cpuid: Fix booting on AMD Phenom 6-core platform

2017-03-03 Thread Andrew Cooper
On 03/03/17 10:47, Sander Eikelenboom wrote: > On 03/03/17 11:40, Andrew Cooper wrote: >> On 02/03/17 20:02, Andrew Cooper wrote: >>> c/s 5cecf60f4 "x86/cpuid: Handle leaf 0x1 in guest_cpuid()" causes Linux >>> 4.10 >>> to crash during boot. >>> >>> It turns out to be because of the reported apic_

Re: [Xen-devel] [PATCH v9 1/8] VMX: Permanently assign PI hook vmx_pi_switch_to()

2017-03-03 Thread Jan Beulich
>>> On 03.03.17 at 09:29, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Wednesday, March 01, 2017 3:42 PM >> Sounds good to me (read: Reviewed-by: Jan Beulich ). >> If Kevin would give his ack, I could replace the comment while committing, >> so you wouldn't need to re-send. >

Re: [Xen-devel] [PATCH v1 2/2] x86/vvmx: add vmcs id check into vmptrld emulation

2017-03-03 Thread Jan Beulich
>>> On 01.03.17 at 12:01, wrote: > On 01/03/17 09:13, Sergey Dyasli wrote: >> --- a/xen/arch/x86/hvm/vmx/vvmx.c >> +++ b/xen/arch/x86/hvm/vmx/vvmx.c >> @@ -1633,6 +1633,17 @@ int nvmx_handle_vmptrld(struct cpu_user_regs *regs) >> { >> if ( writable ) >> { >> +

Re: [Xen-devel] [PATCH RFC 0/5] Refactor x86 domain builder

2017-03-03 Thread Andrew Cooper
On 03/03/17 09:41, Wei Liu wrote: > Long term we want to separate different sets of guest supporting code. We > would > like to have CONFIG_HVM and CONFIG_PV (maybe even CONFIG_PVH?). Probably not PVH. The only differences between HVM and PVH from Xen's point of view are some of the emulation ch

Re: [Xen-devel] [PATCH RFC 0/5] Refactor x86 domain builder

2017-03-03 Thread Jan Beulich
>>> On 03.03.17 at 11:56, wrote: > On 03/03/17 09:41, Wei Liu wrote: > Jan: Would you be happy accepting my CONFIG_{PV,HVM} patch in its silent > form for now? If so, I will respin it. I think so, yes. >> This series is built on top of Roger's PVHv1 removal series. >> >> Wei Liu (5): >> xen:

Re: [Xen-devel] [PATCH RFC 3/5] x86: split PV dom0 builder to domain_build_pv.c

2017-03-03 Thread Roger Pau Monné
On Fri, Mar 03, 2017 at 09:41:09AM +, Wei Liu wrote: > Long term we want to be able to disentangle PV and HVM code. Move the PV > domain builder to a dedicated file. > > This in turn requires exposing a few functions and variables via > a new header domain_build.h. I would add: "No functional

Re: [Xen-devel] [PATCH RFC 0/5] Refactor x86 domain builder

2017-03-03 Thread Andrew Cooper
On 03/03/17 10:56, Andrew Cooper wrote: > On 03/03/17 09:41, Wei Liu wrote: >> This series is built on top of Roger's PVHv1 removal series. >> >> Wei Liu (5): >> xen: move round_pg{up,down} to pfn.h >> xen: include xen/types.h in domain.h >> x86: split PV dom0 builder to domain_build_pv.c >>

Re: [Xen-devel] [PATCH RFC 3/5] x86: split PV dom0 builder to domain_build_pv.c

2017-03-03 Thread Jan Beulich
>>> On 03.03.17 at 12:06, wrote: > On Fri, Mar 03, 2017 at 09:41:09AM +, Wei Liu wrote: >> Long term we want to be able to disentangle PV and HVM code. Move the PV >> domain builder to a dedicated file. >> >> This in turn requires exposing a few functions and variables via >> a new header dom

Re: [Xen-devel] [PATCH RFC 4/5] x86: split PVH dom0 builder to domain_build_pv.c

2017-03-03 Thread Roger Pau Monné
On Fri, Mar 03, 2017 at 09:41:10AM +, Wei Liu wrote: > Long term we want to be able to disentangle PV and HVM code. Move the > PVH domain builder to a dedicated file. It will later depends on > CONFIG_HVM or CONFIG_PVH. > > This in turn requires exposing a few functions and variables via > dom

[Xen-devel] [PATCH v2] x86/kconfig: Introduce CONFIG_PV and CONFIG_HVM

2017-03-03 Thread Andrew Cooper
Making PV and HVM guests individually compilable is useful as a reduction in hypervisor size, and as an aid to enforcing clean API boundaries. Introduce CONFIG_PV and CONFIG_HVM, although there is a lot of work to do until either can actually be disabled. Signed-off-by: Andrew Cooper --- CC: Jan

[Xen-devel] Linking issue with latest git pull

2017-03-03 Thread Praveen Kumar
Hi, Did a git pull and while building, I am getting below error : Just FYI, i reconfigured and also did git clean -fd and rebuild but the result is same. Any pointer will be helpful, how to resolve this issue. Thanks in advance. Error: /usr/bin/ld: warning: libxendevicemodel.so.1, n

Re: [Xen-devel] [PATCH 1/5] x86/vioapic: move domain out of hvm_vioapic struct

2017-03-03 Thread Jan Beulich
>>> On 23.02.17 at 12:52, wrote: > @@ -204,8 +205,7 @@ static void vioapic_write_indirect( > break; > } > > -vioapic_write_redirent( > -vioapic, redir_index, vioapic->ioregsel&1, val); > +vioapic_write_redirent(d, redir_index, vioapic->ioregsel&1

Re: [Xen-devel] [PATCH v2] x86/kconfig: Introduce CONFIG_PV and CONFIG_HVM

2017-03-03 Thread Jan Beulich
>>> On 03.03.17 at 12:22, wrote: > Making PV and HVM guests individually compilable is useful as a reduction in > hypervisor size, and as an aid to enforcing clean API boundaries. > > Introduce CONFIG_PV and CONFIG_HVM, although there is a lot of work to do > until either can actually be disabled

[Xen-devel] [PATCH v3 4/5] configure: detect presence of libxendevicemodel

2017-03-03 Thread Paul Durrant
This patch adds code in configure to set CONFIG_XEN_CTRL_INTERFACE_VERSION to a new value of 490 if libxendevicemodel is present in the build environment. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Stefano Stabellini --- configure | 19 +++ 1 file changed,

[Xen-devel] [PATCH v3 2/5] xen: rename xen_modified_memory() to xen_hvm_modified_memory()

2017-03-03 Thread Paul Durrant
This patch is a purely cosmetic change that avoids a name collision in a subsequent patch. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Paolo Bonzini Cc: Stefano Stabellini --- include/exec/ram_addr.h | 4 ++-- include/hw/xen/xen.h| 2 +- xen-hvm-stub.c | 2 +-

[Xen-devel] [PATCH v3 5/5] xen: use libxendevicemodel when available

2017-03-03 Thread Paul Durrant
This patch modifies the wrapper functions in xen_common.h to use the new xendevicemodel interface if it is available along with compatibility code to use the old libxenctrl interface if it is not. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Stefano Stabellini NOTE: Xen patc

[Xen-devel] [PATCH v3 0/5] xen: use new xendevicemodel library

2017-03-03 Thread Paul Durrant
My recent patches to Xen [1] introduced a new library to support running device models for HVM guests. This series ports QEMU onto the new library if it is available in the build environment. [1] Patches starting with http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=b108240265deea37601f1a60591

[Xen-devel] [PATCH v3 3/5] xen: create wrappers for all other uses of xc_hvm_XXX() functions

2017-03-03 Thread Paul Durrant
This patch creates inline wrapper functions in xen_common.h for all open coded calls to xc_hvm_XXX() functions outside of xen_common.h so that use of xen_xc can be made implicit. This again is in preparation for the move to using libxendevicemodel. Signed-off-by: Paul Durrant Reviewed-by: Anthony

[Xen-devel] [PATCH v3 1/5] xen: make use of xen_xc implicit in xen_common.h inlines

2017-03-03 Thread Paul Durrant
Doing this will make the transition to using the new libxendevicemodel interface less intrusive on the callers of these functions, since using the new library will require a change of handle. NOTE: The patch also moves the 'externs' for xen_xc and xen_fmem from xen_backend.h to xen_common.h,

Re: [Xen-devel] [PATCH v9 3/8] VMX: Properly handle pi when all the assigned devices are removed

2017-03-03 Thread Tian, Kevin
> From: Gao, Chao > Sent: Monday, February 27, 2017 9:46 AM > > From: Feng Wu > > This patch handles some corner cases when the last assigned device > is removed from the domain. In this case we should carefully handle > pi descriptor and the per-cpu blocking list, to make sure: > - all the PI d

Re: [Xen-devel] [PATCH v9 1/8] VMX: Permanently assign PI hook vmx_pi_switch_to()

2017-03-03 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Friday, March 03, 2017 6:49 PM > > >>> On 03.03.17 at 09:29, wrote: > >> From: Jan Beulich [mailto:jbeul...@suse.com] > >> Sent: Wednesday, March 01, 2017 3:42 PM > >> Sounds good to me (read: Reviewed-by: Jan Beulich ). > >> If Kevin would

[Xen-devel] [ovmf test] 106390: regressions - FAIL

2017-03-03 Thread osstest service owner
flight 106390 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/106390/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 105963 test-amd64-amd64-xl-qemuu-

Re: [Xen-devel] Linking issue with latest git pull

2017-03-03 Thread Paul Durrant
Please don't post HTML... --- From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Praveen Kumar Sent: 03 March 2017 11:23 To: xen-de...@lists.xenproject.org Subject: [Xen-devel] Linking issue with latest git pull Hi, Did a git pull and while building, I am getting below error

Re: [Xen-devel] [PATCH 2/5] x86/vioapic: allow the vIO APIC to have a variable number of pins

2017-03-03 Thread Jan Beulich
>>> On 23.02.17 at 12:52, wrote: > @@ -424,40 +424,141 @@ void vioapic_update_EOI(struct domain *d, u8 vector) > spin_unlock(&d->arch.hvm_domain.irq_lock); > } > > -static int ioapic_save(struct domain *d, hvm_domain_context_t *h) > +#define VIOAPIC_SAVE_CONST offsetof(struct hvm_hw_vioapi

Re: [Xen-devel] [PATCH 01/10] x86: assembly, ENTRY for fn, GLOBAL for data

2017-03-03 Thread Jiri Slaby
On 03/01/2017, 11:27 AM, Ingo Molnar wrote: > But no strong feelings either way, I just try to sneak in these small > namespace > structure tricks when nobody's looking! ;-) So I assume to introduce two underscores. thanks, -- js suse labs ___ Xen-d

[Xen-devel] [linux-linus test] 106388: regressions - FAIL

2017-03-03 Thread osstest service owner
flight 106388 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/106388/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvh-intel 11 guest-start fail REGR. vs. 59254 test-armhf-armhf-xl

[Xen-devel] [PATCH v4 0/4] x86: remove PVHv1

2017-03-03 Thread Roger Pau Monne
Hello, This patch series removes the PVHv1 code, both from the hypervisor and the tools, and also gets rid of the has_hvm_container_{domain/vcpu} macro, since from Xen's point of view there are only two types of guests: PV or HVM. Last patch is a minor code movement to have all the domain build P

[Xen-devel] [PATCH v3 1/4] ocaml/gen: fix ocaml type/code generator from IDL

2017-03-03 Thread Roger Pau Monne
From: Ian Jackson This patch adds support for union members which have their own type name. Signed-off-by: Ian Jackson --- This is a pre-requisite for the PVHv1 removal patch. --- Cc: David Scott Cc: Ian Jackson Cc: Wei Liu --- tools/ocaml/libs/xl/genwrap.py | 4 ++-- 1 file changed, 2 inse

[Xen-devel] [PATCH v3 4/4] x86/PVHv2: move pvh_setup_e820 together with the other pvh functions

2017-03-03 Thread Roger Pau Monne
This function is only used by PVHv2 domain build, so move it together with the other PVH domain build functions. Just code motion, no functional change. Signed-off-by: Roger Pau Monné Acked-by: Jan Beulich --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/domain_build.c | 134 ++

[Xen-devel] [PATCH v3 2/4] x86: remove PVHv1 code

2017-03-03 Thread Roger Pau Monne
This removal applies to both the hypervisor and the toolstack side of PVHv1. Note that on the toolstack side a new PVH domain type is introduced to libxl. The "none" device model version is removed, together with the "pvh" field in the create info struct (the defines announcing those features are

[Xen-devel] [PATCH v3 3/4] x86: remove has_hvm_container_{domain/vcpu}

2017-03-03 Thread Roger Pau Monne
It is now useless since PVHv1 is removed and PVHv2 is a HVM domain from Xen's point of view. Signed-off-by: Roger Pau Monné Reviewed-by: Andrew Cooper Acked-by: Tim Deegan Reviewed-by: Kevin Tian Reviewed-by: Boris Ostrovsky Acked-by: George Dunlap --- Cc: Christoph Egger Cc: Jan Beulich C

Re: [Xen-devel] [RFC PATCH v1 16/21] ARM: NUMA: Extract proximity from SRAT table

2017-03-03 Thread Vijay Kilari
On Thu, Mar 2, 2017 at 10:51 PM, Julien Grall wrote: > (+ Jan as ACPI maintainer) > > Hello Vijay, > > On 09/02/17 15:57, vijay.kil...@gmail.com wrote: >> >> From: Vijaya Kumar K >> >> Register SRAT entry handler for type >> ACPI_SRAT_TYPE_GICC_AFFINITY to parse SRAT table >> and extract proximit

Re: [Xen-devel] [RFC PATCH v1 18/21] ARM: NUMA: update node_distance with ACPI support

2017-03-03 Thread Vijay Kilari
On Thu, Mar 2, 2017 at 10:54 PM, Julien Grall wrote: > Hello Vijay, > > > On 09/02/17 15:57, vijay.kil...@gmail.com wrote: >> >> From: Vijaya Kumar K >> >> Update node_distance() function to handle >> ACPI SLIT table information. >> >> Signed-off-by: Vijaya Kumar >> --- >> xen/arch/arm/numa.c |

Re: [Xen-devel] [RFC PATCH v1 19/21] ARM: NUMA: Initialize ACPI NUMA

2017-03-03 Thread Vijay Kilari
On Thu, Mar 2, 2017 at 10:55 PM, Julien Grall wrote: > Hello Vijay, > > > On 09/02/17 15:57, vijay.kil...@gmail.com wrote: >> >> From: Vijaya Kumar K >> >> Call ACPI NUMA initialization under CONFIG_ACPI_NUMA. >> >> Signed-off-by: Vijaya Kumar >> --- >> xen/arch/arm/numa.c | 12 +++- >>

Re: [Xen-devel] [PATCH 2/5] x86/vioapic: allow the vIO APIC to have a variable number of pins

2017-03-03 Thread Roger Pau Monne
On Fri, Mar 03, 2017 at 04:56:20AM -0700, Jan Beulich wrote: > >>> On 23.02.17 at 12:52, wrote: > > @@ -424,40 +424,141 @@ void vioapic_update_EOI(struct domain *d, u8 vector) > > spin_unlock(&d->arch.hvm_domain.irq_lock); > > } > > > > -static int ioapic_save(struct domain *d, hvm_domain_

Re: [Xen-devel] [PATCH 2/5] x86/vioapic: allow the vIO APIC to have a variable number of pins

2017-03-03 Thread Jan Beulich
>>> On 03.03.17 at 13:53, wrote: > On Fri, Mar 03, 2017 at 04:56:20AM -0700, Jan Beulich wrote: >> >>> On 23.02.17 at 12:52, wrote: >> > @@ -424,40 +424,141 @@ void vioapic_update_EOI(struct domain *d, u8 vector) >> > spin_unlock(&d->arch.hvm_domain.irq_lock); >> > } >> > >> > -static int

Re: [Xen-devel] [PATCH v2] x86/kconfig: Introduce CONFIG_PV and CONFIG_HVM

2017-03-03 Thread Wei Liu
On Fri, Mar 03, 2017 at 11:22:06AM +, Andrew Cooper wrote: > Making PV and HVM guests individually compilable is useful as a reduction in > hypervisor size, and as an aid to enforcing clean API boundaries. > > Introduce CONFIG_PV and CONFIG_HVM, although there is a lot of work to do > until ei

Re: [Xen-devel] [PATCH RFC 3/5] x86: split PV dom0 builder to domain_build_pv.c

2017-03-03 Thread Wei Liu
On Fri, Mar 03, 2017 at 04:15:19AM -0700, Jan Beulich wrote: > >>> On 03.03.17 at 12:06, wrote: > > On Fri, Mar 03, 2017 at 09:41:09AM +, Wei Liu wrote: > >> Long term we want to be able to disentangle PV and HVM code. Move the PV > >> domain builder to a dedicated file. > >> > >> This in tur

Re: [Xen-devel] [PATCH RFC 4/5] x86: split PVH dom0 builder to domain_build_pv.c

2017-03-03 Thread Wei Liu
On Fri, Mar 03, 2017 at 11:16:39AM +, Roger Pau Monné wrote: > On Fri, Mar 03, 2017 at 09:41:10AM +, Wei Liu wrote: > > Long term we want to be able to disentangle PV and HVM code. Move the > > PVH domain builder to a dedicated file. It will later depends on > > CONFIG_HVM or CONFIG_PVH. >

Re: [Xen-devel] [PATCH 1/6] xen: credit1: simplify csched_runq_steal() a little bit.

2017-03-03 Thread Dario Faggioli
On Fri, 2017-03-03 at 09:35 +, anshul makkar wrote: > On 02/03/17 10:38, Dario Faggioli wrote: > > --- a/xen/common/sched_credit.c > > +++ b/xen/common/sched_credit.c > > @@ -1593,64 +1593,65 @@ static struct csched_vcpu * > >   csched_runq_steal(int peer_cpu, int cpu, int pri, int > > balance_

Re: [Xen-devel] [PATCH RFC 0/5] Refactor x86 domain builder

2017-03-03 Thread Wei Liu
On Fri, Mar 03, 2017 at 04:06:00AM -0700, Jan Beulich wrote: > >>> On 03.03.17 at 11:56, wrote: > > On 03/03/17 09:41, Wei Liu wrote: > > Jan: Would you be happy accepting my CONFIG_{PV,HVM} patch in its silent > > form for now? If so, I will respin it. > > I think so, yes. > > >> This series i

[Xen-devel] [xen-unstable-smoke test] 106402: tolerable trouble: broken/fail/pass - PUSHED

2017-03-03 Thread osstest service owner
flight 106402 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/106402/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a build-arm64 5 xen

Re: [Xen-devel] [RFC PATCH v1 16/21] ARM: NUMA: Extract proximity from SRAT table

2017-03-03 Thread Julien Grall
Hello Vijay, On 03/03/17 12:39, Vijay Kilari wrote: On Thu, Mar 2, 2017 at 10:51 PM, Julien Grall wrote: diff --git a/xen/drivers/acpi/numa.c b/xen/drivers/acpi/numa.c index 50bf9f8..ce22e88 100644 --- a/xen/drivers/acpi/numa.c +++ b/xen/drivers/acpi/numa.c @@ -25,9 +25,11 @@ #include #incl

Re: [Xen-devel] [RFC PATCH v1 18/21] ARM: NUMA: update node_distance with ACPI support

2017-03-03 Thread Julien Grall
Hello Vijay, On 03/03/17 12:43, Vijay Kilari wrote: On Thu, Mar 2, 2017 at 10:54 PM, Julien Grall wrote: Hello Vijay, On 09/02/17 15:57, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K Update node_distance() function to handle ACPI SLIT table information. Signed-off-by: Vijaya Kumar

Re: [Xen-devel] [RFC PATCH v1 16/21] ARM: NUMA: Extract proximity from SRAT table

2017-03-03 Thread Vijay Kilari
On Fri, Mar 3, 2017 at 7:14 PM, Julien Grall wrote: > Hello Vijay, > > On 03/03/17 12:39, Vijay Kilari wrote: >> >> On Thu, Mar 2, 2017 at 10:51 PM, Julien Grall >> wrote: diff --git a/xen/drivers/acpi/numa.c b/xen/drivers/acpi/numa.c index 50bf9f8..ce22e88 100644 --- a/xen/dr

Re: [Xen-devel] [RFC PATCH v1 16/21] ARM: NUMA: Extract proximity from SRAT table

2017-03-03 Thread Julien Grall
On 03/03/17 13:50, Vijay Kilari wrote: On Fri, Mar 3, 2017 at 7:14 PM, Julien Grall wrote: This is quite disgusting. We should avoid any #ifdef CONFIG_{X86,ARM} in common header. Also, x2apic and gicc are respectively x86-specific and arm-specific. So I think we should move the parsing in a

Re: [Xen-devel] [PATCH 2/6] xen: credit: (micro) optimize csched_runq_steal().

2017-03-03 Thread Dario Faggioli
On Fri, 2017-03-03 at 09:48 +, anshul makkar wrote: > On 02/03/17 10:38, Dario Faggioli wrote: > > --- a/xen/common/sched_credit.c > > +++ b/xen/common/sched_credit.c > > @@ -708,12 +708,10 @@ static inline int > >   __csched_vcpu_is_migrateable(struct vcpu *vc, int dest_cpu, > > cpumask_t *mas

Re: [Xen-devel] [PATCH] xen-netback: fix race condition on XenBus disconnect

2017-03-03 Thread Igor Druzhinin
On 03/03/17 09:18, Paul Durrant wrote: >> -Original Message- >> From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] >> Sent: 02 March 2017 22:57 >> To: net...@vger.kernel.org; xen-de...@lists.xenproject.org >> Cc: Paul Durrant ; jgr...@suse.com; Wei Liu >> ; Igor Druzhinin >> Subject:

Re: [Xen-devel] [PATCH] xen-netback: fix race condition on XenBus disconnect

2017-03-03 Thread Igor Druzhinin
On 03/03/17 09:18, Paul Durrant wrote: >> -Original Message- >> From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] >> Sent: 02 March 2017 22:57 >> To: net...@vger.kernel.org; xen-de...@lists.xenproject.org >> Cc: Paul Durrant ; jgr...@suse.com; Wei Liu >> ; Igor Druzhinin >> Subject:

Re: [Xen-devel] [PATCH] xen-netback: fix race condition on XenBus disconnect

2017-03-03 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin > Sent: 03 March 2017 13:56 > To: Paul Durrant ; net...@vger.kernel.org; xen- > de...@lists.xenproject.org > Cc: jgr...@suse.com; Wei Liu > Subject: Re: [PATCH] xen-netback: fix race condition on XenBus disconnect > > On 03/03/17 09:18, Paul Dur

Re: [Xen-devel] [PATCH] xen-netback: fix race condition on XenBus disconnect

2017-03-03 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin > Sent: 03 March 2017 13:54 > To: Paul Durrant ; net...@vger.kernel.org; xen- > de...@lists.xenproject.org > Cc: jgr...@suse.com; Wei Liu > Subject: Re: [PATCH] xen-netback: fix race condition on XenBus disconnect > > On 03/03/17 09:18, Paul Dur

[Xen-devel] [qemu-mainline test] 106395: tolerable FAIL - PUSHED

2017-03-03 Thread osstest service owner
flight 106395 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/106395/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stopfail like 106356 test-amd64-i386-xl-qemuu-w

[Xen-devel] [PATCH] x86/tboot: remove dead declarations

2017-03-03 Thread Jan Beulich
These aren't needed anymore as of c9a4a1c419 ("x86/layout: Correct Xen's idea of its own memory layout"). Signed-off-by: Jan Beulich --- a/xen/arch/x86/tboot.c +++ b/xen/arch/x86/tboot.c @@ -48,8 +48,6 @@ static uint64_t __initdata sinit_base, _ #define TXTCR_HEAP_BASE 0x0300 #defi

[Xen-devel] [PATCH v2] x86/SVM: correct boot time cpu_data[] handling

2017-03-03 Thread Jan Beulich
start_svm() already runs after cpu_data[] was set up, so it shouldn't modify it anymore (at least not directly). Constify the involved pointers. Furthermore LMSLE feature detection was broken by 566ddbe833 ("x86: Fail CPU bringup cleanly if it cannot initialise HVM"), as Andrew Cooper has pointed

[Xen-devel] [PATCH] AMD-Vi: allocate root table on demand

2017-03-03 Thread Jan Beulich
This was my originally intended fix for the AMD side of XSA-207: There's no need to unconditionally allocate the root table, and with that there's then also no way to leak it when a guest has no devices assigned. Signed-off-by: Jan Beulich --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/

Re: [Xen-devel] [PATCH] x86/tboot: remove dead declarations

2017-03-03 Thread Andrew Cooper
On 03/03/17 14:27, Jan Beulich wrote: > These aren't needed anymore as of c9a4a1c419 ("x86/layout: Correct > Xen's idea of its own memory layout"). > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xe

Re: [Xen-devel] [PATCH v2] x86/SVM: correct boot time cpu_data[] handling

2017-03-03 Thread Andrew Cooper
On 03/03/17 14:28, Jan Beulich wrote: > start_svm() already runs after cpu_data[] was set up, so it shouldn't > modify it anymore (at least not directly). Constify the involved > pointers. > > Furthermore LMSLE feature detection was broken by 566ddbe833 ("x86: > Fail CPU bringup cleanly if it canno

Re: [Xen-devel] [PATCH RFC 3/5] x86: split PV dom0 builder to domain_build_pv.c

2017-03-03 Thread Jan Beulich
>>> On 03.03.17 at 14:35, wrote: > On Fri, Mar 03, 2017 at 04:15:19AM -0700, Jan Beulich wrote: >> >>> On 03.03.17 at 12:06, wrote: >> > On Fri, Mar 03, 2017 at 09:41:09AM +, Wei Liu wrote: >> However, with ... >> >> >> diff --git a/xen/arch/x86/domain_build_pv.c >> >> b/xen/arch/x86/domain

Re: [Xen-devel] [PATCH RFC 0/5] Refactor x86 domain builder

2017-03-03 Thread Jan Beulich
>>> On 03.03.17 at 14:41, wrote: > On Fri, Mar 03, 2017 at 04:06:00AM -0700, Jan Beulich wrote: >> >>> On 03.03.17 at 11:56, wrote: >> > On 03/03/17 09:41, Wei Liu wrote: >> > Jan: Would you be happy accepting my CONFIG_{PV,HVM} patch in its silent >> > form for now? If so, I will respin it. >>

Re: [Xen-devel] [PATCH v2 1/5] golang/xenlight: Create stub package

2017-03-03 Thread George Dunlap
On 02/03/17 16:07, Ronald Rojas wrote: > Create a basic Makefile to build and install libxenlight Golang > bindings. Also add a stub package which only opens libxl context. > > Include a global xenlight.Ctx variable which can be used as the > default context by the entire program if desired. > >

Re: [Xen-devel] [PATCH RFC 0/5] Refactor x86 domain builder

2017-03-03 Thread Wei Liu
On Fri, Mar 03, 2017 at 07:34:18AM -0700, Jan Beulich wrote: > >>> On 03.03.17 at 14:41, wrote: > > On Fri, Mar 03, 2017 at 04:06:00AM -0700, Jan Beulich wrote: > >> >>> On 03.03.17 at 11:56, wrote: > >> > On 03/03/17 09:41, Wei Liu wrote: > >> > Jan: Would you be happy accepting my CONFIG_{PV,HV

Re: [Xen-devel] [PATCH RFC 3/5] x86: split PV dom0 builder to domain_build_pv.c

2017-03-03 Thread Wei Liu
On Fri, Mar 03, 2017 at 07:33:35AM -0700, Jan Beulich wrote: > >>> On 03.03.17 at 14:35, wrote: > > On Fri, Mar 03, 2017 at 04:15:19AM -0700, Jan Beulich wrote: > >> >>> On 03.03.17 at 12:06, wrote: > >> > On Fri, Mar 03, 2017 at 09:41:09AM +, Wei Liu wrote: > >> However, with ... > >> > >>

Re: [Xen-devel] [RFC PATCH v1 16/21] ARM: NUMA: Extract proximity from SRAT table

2017-03-03 Thread Vijay Kilari
On Fri, Mar 3, 2017 at 7:22 PM, Julien Grall wrote: > > > On 03/03/17 13:50, Vijay Kilari wrote: >> >> On Fri, Mar 3, 2017 at 7:14 PM, Julien Grall wrote: > > This is quite disgusting. We should avoid any #ifdef CONFIG_{X86,ARM} > in > common header. > > Also, x2apic and g

Re: [Xen-devel] [PATCH v2] x86/SVM: correct boot time cpu_data[] handling

2017-03-03 Thread Boris Ostrovsky
On 03/03/2017 09:28 AM, Jan Beulich wrote: > start_svm() already runs after cpu_data[] was set up, so it shouldn't > modify it anymore (at least not directly). Constify the involved > pointers. > > Furthermore LMSLE feature detection was broken by 566ddbe833 ("x86: > Fail CPU bringup cleanly if it

Re: [Xen-devel] [PATCH v2 2/5] golang/xenlight: Add error constants and standard handling

2017-03-03 Thread George Dunlap
On 02/03/17 16:07, Ronald Rojas wrote: > Create error type Errorxl for throwing proper xenlight > errors. > > Update Ctx functions to throw Errorxl errors. > > Signed-off-by: Ronald Rojas There are a couple of `go fmt` changes which should be in the previous patch (including the stray semicolon

[Xen-devel] [PATCH v5 00/17] x86emul: MMX/SSEn support

2017-03-03 Thread Jan Beulich
This includes support for AVX counterparts of them as well as a few later SSE additions (basically covering the entire 0f-prefixed opcode space, but not the 0f38 and 0f3a ones, nor 3dnow). 1: support most memory accessing MMX/SSE{,2,3} insns 2: support MMX/SSE{,2,3} moves 3: support MMX/SSE/SSE

Re: [Xen-devel] [PATCH RFC 3/5] x86: split PV dom0 builder to domain_build_pv.c

2017-03-03 Thread Andrew Cooper
On 03/03/17 14:45, Wei Liu wrote: > On Fri, Mar 03, 2017 at 07:33:35AM -0700, Jan Beulich wrote: > On 03.03.17 at 14:35, wrote: >>> On Fri, Mar 03, 2017 at 04:15:19AM -0700, Jan Beulich wrote: >>> On 03.03.17 at 12:06, wrote: > On Fri, Mar 03, 2017 at 09:41:09AM +, Wei Liu wrote:

  1   2   >