On 03/03/17 13:50, Vijay Kilari wrote:
On Fri, Mar 3, 2017 at 7:14 PM, Julien Grall <julien.gr...@arm.com> wrote:This is quite disgusting. We should avoid any #ifdef CONFIG_{X86,ARM} in common header. Also, x2apic and gicc are respectively x86-specific and arm-specific. So I think we should move the parsing in a separate arch-depend function to avoid those ifdery. By that I mean having a function acpi_table_arch_parse_srat that will parse x2apci on x86 and gicc on ARM. Jan, what do you think?Linux also follows similar approach https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/linux/acpi.h?id=refs/tags/v4.10#n265So? What are you trying to prove? The linux version is much readable than yours. Anyway, we should limit CONFIG_{X86,ARM} ifdefery in common code. Currently, I see no point to have those ifdefery when it is possible to add an arch-depend function.This is because in xen we have another level of config CONFIG_ACPI_NUMA. I have plans to reuse cpu and memory part next revision.
This does not explain why you want to do like Linux. -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
