[Xen-devel] [ovmf test] 106133: regressions - FAIL

2017-02-26 Thread osstest service owner
flight 106133 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/106133/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 105963 test-amd64-i386-xl-qemuu-

[Xen-devel] [xen-4.4-testing test] 106130: regressions - FAIL

2017-02-26 Thread osstest service owner
flight 106130 xen-4.4-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/106130/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xend-qemut-winxpsp3 15 guest-localmigrate/x10 fail in 106051 REGR. vs. 105835

[Xen-devel] [xen-unstable-coverity test] 106144: all pass - PUSHED

2017-02-26 Thread osstest service owner
flight 106144 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/106144/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 1f24be6c945c8f8e25547aed4a56c092133df713 baseline version: xen b908

[Xen-devel] [linux-linus test] 106139: regressions - FAIL

2017-02-26 Thread osstest service owner
flight 106139 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/106139/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvh-intel 11 guest-start fail REGR. vs. 59254 test-armhf-armhf-xl

[Xen-devel] [PATCH 1/2] x86: fix memory leak in pvh_setup_acpi_madt

2017-02-26 Thread Wei Liu
Switch to use goto style error handling to avoid leaking madt. Coverity-ID: 1401534 Signed-off-by: Wei Liu --- xen/arch/x86/domain_build.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/domain_build.c b/xen/arch/x86/domain_build.c index 05348

[Xen-devel] [PATCH 2/2] x86: fix memory leak in pvh_setup_acpi_xsdt

2017-02-26 Thread Wei Liu
Switch to use goto style error handling to avoid leaking xsdt. Coverity-ID: 1401535 Signed-off-by: Wei Liu --- xen/arch/x86/domain_build.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/domain_build.c b/xen/arch/x86/domain_build.c index 1f

[Xen-devel] [PATCH 0/2] Two PVH dom0 series fixes

2017-02-26 Thread Wei Liu
Wei Liu (2): x86: fix memory leak in pvh_setup_acpi_madt x86: fix memory leak in pvh_setup_acpi_xsdt xen/arch/x86/domain_build.c | 37 ++--- 1 file changed, 26 insertions(+), 11 deletions(-) -- 2.11.0 ___ Xen-deve

Re: [Xen-devel] RFC/PATCH: xen: race during domain destruction [Re: [xen-4.7-testing test] 105948: regressions - FAIL]

2017-02-26 Thread Dario Faggioli
On Fri, 2017-02-24 at 17:14 +0100, Dario Faggioli wrote: > On Wed, 2017-02-22 at 01:46 -0700, Jan Beulich wrote: > > However, comparing with the staging version of the file > > (which is heavily different), the immediate code involved here > > isn't > > all that different, so I wonder whether (a) t

[Xen-devel] [ovmf test] 106145: regressions - FAIL

2017-02-26 Thread osstest service owner
flight 106145 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/106145/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 105963 test-amd64-i386-xl-qemuu-

[Xen-devel] [xen-unstable test] 106138: regressions - FAIL

2017-02-26 Thread osstest service owner
flight 106138 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/106138/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt 6 xen-boot fail REGR. vs. 105933 test-amd64-i386-fr

[Xen-devel] [qemu-mainline test] 106141: tolerable FAIL - PUSHED

2017-02-26 Thread osstest service owner
flight 106141 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/106141/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-libvirt-xsm 13 saverestore-support-checkfail like 106086 test-amd64-amd64-xl-qemuu-

Re: [Xen-devel] [linux-linus test] 106139: regressions - FAIL

2017-02-26 Thread Boris Ostrovsky
On 02/26/2017 10:32 AM, osstest service owner wrote: flight 106139 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/106139/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvh-intel 11 guest-st

Re: [Xen-devel] [PATCH v8 02/24] x86: refactor psr: remove L3 CAT/CDP codes.

2017-02-26 Thread Wei Liu
On Wed, Feb 15, 2017 at 04:49:17PM +0800, Yi Sun wrote: > The current cache allocation codes in psr.c do not consider > future features addition and are not friendly to extend. > > To make psr.c be more flexible to add new features and fulfill > the program principle, open for extension but closed

Re: [Xen-devel] [PATCH v8 01/24] docs: create Cache Allocation Technology (CAT) and Code and Data Prioritization (CDP) feature document

2017-02-26 Thread Wei Liu
On Wed, Feb 15, 2017 at 04:49:16PM +0800, Yi Sun wrote: > This patch creates CAT and CDP feature document in doc/features/. It describes > key points to implement L3 CAT/CDP and L2 CAT which is described in details in > Intel SDM "INTEL® RESOURCE DIRECTOR TECHNOLOGY (INTEL® RDT) ALLOCATION > FEATU

Re: [Xen-devel] [PATCH v8 06/24] x86: refactor psr: implement get hw info flow.

2017-02-26 Thread Wei Liu
On Wed, Feb 15, 2017 at 04:49:21PM +0800, Yi Sun wrote: [...] > /* L3 CAT functions implementation. */ > static void l3_cat_init_feature(struct cpuid_leaf regs, > struct feat_node *feat, > @@ -225,8 +247,22 @@ static unsigned int l3_cat_get_cos_max(const struct >

Re: [Xen-devel] [PATCH v8 05/24] x86: refactor psr: implement Domain init/free and schedule flows.

2017-02-26 Thread Wei Liu
On Wed, Feb 15, 2017 at 04:49:20PM +0800, Yi Sun wrote: > +static inline unsigned int get_max_cos_max(const struct psr_socket_info > *info) > +{ > +const struct feat_node *feat; > +unsigned int cos_max = 0; > + > +list_for_each_entry(feat, &info->feat_list, list) > +cos_max = m

Re: [Xen-devel] [PATCH v8 04/24] x86: refactor psr: implement CPU init and free flow.

2017-02-26 Thread Wei Liu
On Wed, Feb 15, 2017 at 04:49:19PM +0800, Yi Sun wrote: > This patch implements the CPU init and free flow including L3 CAT > initialization and feature list free. > > Signed-off-by: Yi Sun Either you need to use a separate patch to move cpuid_count_leaf or you should state it is moved in the co

Re: [Xen-devel] [PATCH v8 08/24] x86: refactor psr: set value: implement framework.

2017-02-26 Thread Wei Liu
On Wed, Feb 15, 2017 at 04:49:23PM +0800, Yi Sun wrote: [...] > +int psr_set_val(struct domain *d, unsigned int socket, > +uint64_t val, enum cbm_type type) IMHO it would be far better to use goto style error handling in such a complex function. You can avoid missing one of the exi

Re: [Xen-devel] [PATCH v8 10/24] x86: refactor psr: set value: implement cos finding flow.

2017-02-26 Thread Wei Liu
On Wed, Feb 15, 2017 at 04:49:25PM +0800, Yi Sun wrote: > Continue with patch: > 'x86: refactor psr: set value: assemble features value array' > > We can try to find if there is a COS ID on which all features' COS registers > values are same as the array assembled before. > > Signed-off-by: Yi Su

Re: [Xen-devel] [PATCH v8 09/24] x86: refactor psr: set value: assemble features value array.

2017-02-26 Thread Wei Liu
On Wed, Feb 15, 2017 at 04:49:24PM +0800, Yi Sun wrote: [...] > > +static unsigned int l3_cat_get_cos_num(const struct feat_node *feat) > +{ > +return 1; > +} > + > +static int l3_cat_get_old_val(uint64_t val[], And the length of val is? How can you bound-check the access? But I *think* thi

Re: [Xen-devel] [PATCH v8 11/24] x86: refactor psr: set value: implement cos id picking flow.

2017-02-26 Thread Wei Liu
On Wed, Feb 15, 2017 at 04:49:26PM +0800, Yi Sun wrote: > static int pick_avail_cos(const struct psr_socket_info *info, >const uint64_t *val, uint32_t array_len, >unsigned int old_cos, >enum psr_feat_type feat_type

Re: [Xen-devel] [PATCH v8 14/24] x86: refactor psr: implement get hw info flow for CDP.

2017-02-26 Thread Wei Liu
On Wed, Feb 15, 2017 at 04:49:29PM +0800, Yi Sun wrote: [...] > > static void __init parse_psr_bool(char *s, char *value, char *feature, > diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c > index e340baa..568bfe9 100644 > --- a/xen/arch/x86/sysctl.c > +++ b/xen/arch/x86/sysctl.c > @@ -

Re: [Xen-devel] [PATCH v8 16/24] x86: refactor psr: implement set value callback functions for CDP.

2017-02-26 Thread Wei Liu
On Wed, Feb 15, 2017 at 04:49:31PM +0800, Yi Sun wrote: > This patch implements L3 CDP set value related callback functions. > > With this patch, 'psr-cat-cbm-set' command can work for L3 CDP. > > Signed-off-by: Yi Sun > --- > v8: > - modify 'l3_cdp_write_msr' to 'void'. > --- > xen/arch/x8

Re: [Xen-devel] [PATCH 7/7] tools/xen-mceinj: fix the type of cpu number

2017-02-26 Thread Wei Liu
On Fri, Feb 24, 2017 at 06:52:56PM +0800, Haozhong Zhang wrote: > Use "unsigned int" rather than "int" to align to the type "uint32_t" > of xen_mc_physcpuinfo.ncpus. > > Signed-off-by: Haozhong Zhang Acked-by: Wei Liu ___ Xen-devel mailing list Xen-d

Re: [Xen-devel] [PATCH v8 00/24] Enable L2 Cache Allocation Technology & Refactor psr.c

2017-02-26 Thread Wei Liu
Hi Yi I went through this series and made some comments -- since I needed to answer your questions about behaviour of toolstack. I'm not a x86 maintainer so my suggestions could be wrong. Please wait until x86 maintainers review your series before resending. Wei. ___

[Xen-devel] [xen-4.4-testing test] 106146: regressions - FAIL

2017-02-26 Thread osstest service owner
flight 106146 xen-4.4-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/106146/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xend-qemut-winxpsp3 15 guest-localmigrate/x10 fail in 106051 REGR. vs. 105835

Re: [Xen-devel] [PATCH 1/1] xen/arm: Add pl011 uart support in Xen for guest domains

2017-02-26 Thread Julien Grall
Hi Konrad, On 02/17/2017 03:27 PM, Konrad Rzeszutek Wilk wrote: On Thu, Feb 16, 2017 at 02:34:30PM +, Julien Grall wrote: On 15/02/17 15:38, Konrad Rzeszutek Wilk wrote: On Wed, Feb 15, 2017 at 12:53:34PM +0530, Bhupinder Thakur wrote: We already have some HVM param that are x86 specific

[Xen-devel] [ovmf test] 106159: regressions - FAIL

2017-02-26 Thread osstest service owner
flight 106159 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/106159/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 105963 test-amd64-i386-xl-qemuu-

[Xen-devel] [linux-linus test] 106152: regressions - trouble: blocked/broken/fail/pass

2017-02-26 Thread osstest service owner
flight 106152 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/106152/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvh-intel 11 guest-start fail REGR. vs. 59254 build-i386-pvops

Re: [Xen-devel] [PATCH 01/11] xen/arm: vpl011: Add pl011 uart emulation in Xen

2017-02-26 Thread Julien Grall
Hi Bhupinder, On 02/21/2017 11:25 AM, Bhupinder Thakur wrote: Add emulation code to emulate read/write access to pl011 registers and pl011 interrupts: - It emulates DR read/write by reading and writing from/to the IN and OUT ring buffers and raising an event to dom0 when there is

[Xen-devel] [linux-linus bisection] complete build-i386-pvops

2017-02-26 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-i386-pvops testid kernel-build Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git *** Found and reproduced problem changeset *** Bug is in tre

[Xen-devel] [PATCH RFC 8/8] mm: Print number of unscrubbed pages in 'H' debug handler

2017-02-26 Thread Boris Ostrovsky
Signed-off-by: root --- xen/common/page_alloc.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index a39afd4..027 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2198,6 +2198,13 @@ static

[Xen-devel] [PATCH RFC 4/8] mm: Scrub memory from idle loop

2017-02-26 Thread Boris Ostrovsky
Signed-off-by: Boris Ostrovsky --- xen/arch/x86/domain.c |3 ++- xen/common/page_alloc.c | 29 - xen/include/xen/mm.h|1 + 3 files changed, 23 insertions(+), 10 deletions(-) diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index 7d3071e..ce1d

[Xen-devel] [PATCH RFC 3/8] mm: Scrub pages in alloc_heap_pages() if needed

2017-02-26 Thread Boris Ostrovsky
When allocating pages in alloc_heap_pages() first look for clean pages. If none is found then retry, take pages marked as unscrubbed and scrub them. Note that we shouldn't find unscrubbed pages in alloc_heap_pages() yet. However, this will become possible when we stop scrubbing from free_heap_page

[Xen-devel] [PATCH RFC 0/8] Memory scrubbing from idle loop

2017-02-26 Thread Boris Ostrovsky
When a domain is destroyed the hypervisor must scrub domain's pages before giving them to another guest in order to prevent leaking the deceased guest's data. Currently this is done during guest's destruction, possibly causing very lengthy cleanup process. This series adds support for scrubbing re

[Xen-devel] [PATCH RFC 1/8] mm: Separate free page chunk merging into its own routine

2017-02-26 Thread Boris Ostrovsky
This is needed for subsequent changes to memory scrubbing. Signed-off-by: Boris Ostrovsky --- xen/common/page_alloc.c | 82 --- 1 files changed, 49 insertions(+), 33 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index b

[Xen-devel] [PATCH RFC 6/8] spinlock: Introduce _spin_lock_cond()

2017-02-26 Thread Boris Ostrovsky
Because _spin_trylock() doesn't take lock ticket it may take a long time until the lock is taken. Add _spin_lock_cond() that waits for the lock while periodically checking condition that may cause the lock request to be dropped. Signed-off-by: Boris Ostrovsky --- xen/common/spinlock.c |

[Xen-devel] [PATCH RFC 5/8] mm: Do not discard already-scrubbed pages softirqs are pending

2017-02-26 Thread Boris Ostrovsky
Signed-off-by: Boris Ostrovsky --- xen/common/page_alloc.c | 65 +- 1 files changed, 58 insertions(+), 7 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index ac15406..3469185 100644 --- a/xen/common/page_alloc.c +++ b/xen

[Xen-devel] [PATCH RFC 2/8] mm: Place unscrubbed pages at the end of pagelist

2017-02-26 Thread Boris Ostrovsky
. so that it's easy to find pages that need to be scrubbed (those pages are now marked with _PGC_need_scrub bit). Signed-off-by: Boris Ostrovsky --- xen/common/page_alloc.c | 97 +++-- xen/include/asm-x86/mm.h |4 ++ 2 files changed, 79 insertions(+

[Xen-devel] [PATCH RFC 7/8] mm: Keep pages available for allocation while scrubbing

2017-02-26 Thread Boris Ostrovsky
Instead of scrubbing pages while holding heap lock we can mark buddy's head as being scrubbed and drop the lock temporarily. If someone (most likely alloc_heap_pages()) tries to access this chunk it will signal the scrubber to abort scrub by setting head's PAGE_SCRUB_ABORT bit. The scrubber checks

[Xen-devel] [PATCH RESEND RFC 2/8] mm: Place unscrubbed pages at the end of pagelist

2017-02-26 Thread Boris Ostrovsky
. so that it's easy to find pages that need to be scrubbed (those pages are now marked with _PGC_need_scrub bit). Signed-off-by: Boris Ostrovsky --- xen/common/page_alloc.c | 97 +++-- xen/include/asm-x86/mm.h |4 ++ 2 files changed, 79 insertions(+

[Xen-devel] [PATCH RESEND RFC 5/8] mm: Do not discard already-scrubbed pages softirqs are pending

2017-02-26 Thread Boris Ostrovsky
Signed-off-by: Boris Ostrovsky --- xen/common/page_alloc.c | 65 +- 1 files changed, 58 insertions(+), 7 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index ac15406..3469185 100644 --- a/xen/common/page_alloc.c +++ b/xen

[Xen-devel] [PATCH RESEND RFC 4/8] mm: Scrub memory from idle loop

2017-02-26 Thread Boris Ostrovsky
Signed-off-by: Boris Ostrovsky --- xen/arch/x86/domain.c |3 ++- xen/common/page_alloc.c | 29 - xen/include/xen/mm.h|1 + 3 files changed, 23 insertions(+), 10 deletions(-) diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index 7d3071e..ce1d

[Xen-devel] [PATCH RESEND RFC 7/8] mm: Keep pages available for allocation while scrubbing

2017-02-26 Thread Boris Ostrovsky
Instead of scrubbing pages while holding heap lock we can mark buddy's head as being scrubbed and drop the lock temporarily. If someone (most likely alloc_heap_pages()) tries to access this chunk it will signal the scrubber to abort scrub by setting head's PAGE_SCRUB_ABORT bit. The scrubber checks

[Xen-devel] [PATCH RESEND RFC 8/8] mm: Print number of unscrubbed pages in 'H' debug handler

2017-02-26 Thread Boris Ostrovsky
Signed-off-by: root --- xen/common/page_alloc.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index a39afd4..027 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2198,6 +2198,13 @@ static

[Xen-devel] [PATCH RESEND RFC 3/8] mm: Scrub pages in alloc_heap_pages() if needed

2017-02-26 Thread Boris Ostrovsky
When allocating pages in alloc_heap_pages() first look for clean pages. If none is found then retry, take pages marked as unscrubbed and scrub them. Note that we shouldn't find unscrubbed pages in alloc_heap_pages() yet. However, this will become possible when we stop scrubbing from free_heap_page

[Xen-devel] [PATCH RESEND RFC 1/8] mm: Separate free page chunk merging into its own routine

2017-02-26 Thread Boris Ostrovsky
This is needed for subsequent changes to memory scrubbing. Signed-off-by: Boris Ostrovsky --- xen/common/page_alloc.c | 82 --- 1 files changed, 49 insertions(+), 33 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index b

[Xen-devel] [PATCH RESEND RFC 0/8] Memory scrubbing from idle loop

2017-02-26 Thread Boris Ostrovsky
(Resending with corrected Tim's address, sorry) When a domain is destroyed the hypervisor must scrub domain's pages before giving them to another guest in order to prevent leaking the deceased guest's data. Currently this is done during guest's destruction, possibly causing very lengthy cleanup pr

[Xen-devel] [PATCH RESEND RFC 6/8] spinlock: Introduce _spin_lock_cond()

2017-02-26 Thread Boris Ostrovsky
Because _spin_trylock() doesn't take lock ticket it may take a long time until the lock is taken. Add _spin_lock_cond() that waits for the lock while periodically checking condition that may cause the lock request to be dropped. Signed-off-by: Boris Ostrovsky --- xen/common/spinlock.c |

Re: [Xen-devel] [PATCH v3 1/3] x86/vmx: introduce vmx_find_msr()

2017-02-26 Thread Tian, Kevin
> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] > Sent: Thursday, February 23, 2017 5:33 PM > > Modify vmx_add_msr() to use a variation of insertion sort algorithm: > find a place for the new entry and shift all subsequent elements before > insertion. > > The new vmx_find_msr() exploits t

Re: [Xen-devel] [PATCH v3 3/3] x86/vmx: fix vmentry failure with TSX bits in LBR

2017-02-26 Thread Tian, Kevin
> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] > Sent: Thursday, February 23, 2017 5:33 PM > > During VM entry, H/W will automatically load guest's MSRs from MSR-load > area in the same way as they would be written by WRMSR. > > However, under the following conditions: > > 1. LBR (L

Re: [Xen-devel] [PATCH v2] iommu: Elaborate the usage of RMRR specification on the command line

2017-02-26 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Friday, February 24, 2017 4:56 PM > > >>> On 23.02.17 at 18:03, wrote: > > As some users have suggested, elaborate the usage of RMRR specification > > on the command line, and provide a usage example. > > > > Also, always treat the specified

Re: [Xen-devel] [PATCH v3 1/2] x86/vpmu: Add get/put_vpmu() and VPMU_AVAILABLE

2017-02-26 Thread Tian, Kevin
> From: Boris Ostrovsky [mailto:boris.ostrov...@oracle.com] > Sent: Thursday, February 23, 2017 2:24 AM > > vpmu_enabled() (used by hvm/pv_cpuid() to properly report 0xa leaf > for Intel processors) is based on the value of VPMU_CONTEXT_ALLOCATED > bit. This is problematic: > * For HVM guests VPMU

Re: [Xen-devel] [PATCH v3 2/2] x86/vpmu: Disable VPMU if guest's CPUID indicates no PMU support

2017-02-26 Thread Tian, Kevin
> From: Boris Ostrovsky [mailto:boris.ostrov...@oracle.com] > Sent: Thursday, February 23, 2017 2:24 AM > > When toolstack overrides Intel CPUID leaf 0xa's PMU version with an > invalid value VPMU should not be available to the guest. > > Signed-off-by: Boris Ostrovsky Reviewed-by: Kevin Tian

Re: [Xen-devel] [PATCH 2/3] x86: remove has_hvm_container_{domain/vcpu}

2017-02-26 Thread Tian, Kevin
> From: Roger Pau Monne [mailto:roger@citrix.com] > Sent: Friday, February 24, 2017 11:13 PM > > It is now useless since PVHv1 is removed and PVHv2 is a HVM domain from Xen's > point of view. > > Signed-off-by: Roger Pau Monné Reviewed-by: Kevin Tian ___

[Xen-devel] [qemu-mainline baseline-only test] 68616: regressions - trouble: blocked/broken/fail/pass

2017-02-26 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 68616 qemu-mainline real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68616/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvh-amd 6 xen-boot

[Xen-devel] [PATCH v3 1/2] xen/x86: ensure copying runstate/time to L1 rather than L2

2017-02-26 Thread Haozhong Zhang
For a HVM domain, if a vcpu is in the nested guest mode, __raw_copy_to_guest(), __copy_to_guest() and __copy_field_to_guest() used by update_runstate_area() and update_secondary_system_time() will copy data to L2 guest rather than the L1 guest. This commit temporally clears the nested guest flag b

[Xen-devel] [PATCH v3 2/2] x86/hvm: check HAP before enabling nested VMX

2017-02-26 Thread Haozhong Zhang
The current implementation of nested VMX cannot work without HAP. Signed-off-by: Haozhong Zhang --- Changes since v2: * Add the check by dropping the cpu_has_svm check. --- xen/arch/x86/hvm/hvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/ar

[Xen-devel] [qemu-mainline test] 106163: regressions - FAIL

2017-02-26 Thread osstest service owner
flight 106163 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/106163/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 6 xen-boot fail REGR. vs. 106141 Regressions which

Re: [Xen-devel] [RFC 01/16] docs: create Memory Bandwidth Allocation (MBA) feature document.

2017-02-26 Thread Yi Sun
On 17-02-24 10:53:16, Meng Xu wrote: > >> > +# References > >> > + > >> > +"INTEL® RESOURCE DIRECTOR TECHNOLOGY (INTEL® RDT) ALLOCATION FEATURES" > >> > [Intel® 64 and IA-32 Architectures Software Developer Manuals, > >> > vol3](http://www.intel.com/content/www/us/en/processors/architectures-soft

[Xen-devel] [PATCH v2 4/7] x86/vmce: fill MSR_IA32_MCG_STATUS on all vcpus in broadcast case

2017-02-26 Thread Haozhong Zhang
The current implementation only fills MC MSRs on vcpu0 and leaves MC MSRs on other vcpus empty in the broadcast case. When guest reads 0 from MSR_IA32_MCG_STATUS on vcpuN (N > 0), it may think it's not possible to recover the execution on that vcpu and then get panic, although MSR_IA32_MCG_STATUS f

[Xen-devel] [PATCH v2 6/7] xen/mce: remove ASSERT's about mce_dhandler_num in mce_action()

2017-02-26 Thread Haozhong Zhang
The current production build works fine even though those ASSERT's are violated. Remove them to make the debug build work as well. Signed-off-by: Haozhong Zhang --- Cc: Christoph Egger Cc: Jan Beulich Cc: Andrew Cooper Changes since v1: * Remove those ASSERT's rather than making them Intel-o

[Xen-devel] [PATCH v2 2/7] xen/mce: remove unused x86_mcinfo_add()

2017-02-26 Thread Haozhong Zhang
c/s 9d13fd9fd320a7740c6446c048ff6a2990095966 turned to update the mcinfo buffer in-place instead of using x86_mcinfo_add(). The last uses of x86_mcinfo_add() were removed by that commit as well. Therefore, x86_mcinfo_add() was deprecated in fact. Signed-off-by: Haozhong Zhang Reviewed-by: Jan Beu

[Xen-devel] [PATCH v2 1/7] xen/mce: adjust comment of callback register functions

2017-02-26 Thread Haozhong Zhang
c/s e966818264908e842e2847f579ca4d94e586eaac added mce_need_clearbank_register below the comment of x86_mce_callback_register(). This commit (1) adjusts the first paragraph of comment to be a general statement of all callback register functions, and (2) moves the second paragraph to the front of x8

[Xen-devel] [PATCH v2 0/7] MCE code cleanup and bugfix

2017-02-26 Thread Haozhong Zhang
Changes in v2: * Only patch 6 is changed, which removes ASSERT's rather than modifying them. * Take R-b in patch 2 - 5, and A-b in patch 7. * Patch 1 in v1 (it only adjusts the code comment) hasn't got any R-b or A-b. This patch series separates the uncommitted code cleanup and bugfix pat

[Xen-devel] [PATCH v2 3/7] x86/mce: set mcinfo_comm.type and .size in x86_mcinfo_reserve()

2017-02-26 Thread Haozhong Zhang
All existing calls to x86_mcinfo_reserve() are followed by statements that set the size and the type of the reserved space, so move them into x86_mcinfo_reserve() to simplify the code. Signed-off-by: Haozhong Zhang Reviewed-by: Jan Beulich --- Cc: Christoph Egger Cc: Jan Beulich Cc: Andrew Coo

[Xen-devel] [PATCH v2 7/7] tools/xen-mceinj: fix the type of cpu number

2017-02-26 Thread Haozhong Zhang
Use "unsigned int" rather than "int" to align to the type "uint32_t" of xen_mc_physcpuinfo.ncpus. Signed-off-by: Haozhong Zhang Acked-by: Wei Liu --- Cc: Ian Jackson Cc: Wei Liu --- tools/tests/mce-test/tools/xen-mceinj.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) dif

[Xen-devel] [PATCH v2 5/7] x86/mce: clear MSR_IA32_MCG_STATUS by writing 0

2017-02-26 Thread Haozhong Zhang
On Intel CPU, an attemp to write to MSR_IA32_MCG_STATUS with any non-zero value would result in #GP. This commit writes 0 on AMD CPU as well instead of just clearing MCIP bit, because all non-reserved bits of MSR_IA32_MCG_STATUS have been handled at this point. Signed-off-by: Haozhong Zhang Revi

[Xen-devel] [xen-4.4-testing test] 106168: regressions - FAIL

2017-02-26 Thread osstest service owner
flight 106168 xen-4.4-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/106168/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xend-qemut-winxpsp3 15 guest-localmigrate/x10 fail in 106051 REGR. vs. 105835

[Xen-devel] [xen-unstable test] 106160: regressions - trouble: blocked/broken/fail/pass

2017-02-26 Thread osstest service owner
flight 106160 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/106160/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-amd64 6 xen-boot fail REGR. vs. 105933 test-amd64-i386-xl

[Xen-devel] [ovmf test] 106173: regressions - FAIL

2017-02-26 Thread osstest service owner
flight 106173 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/106173/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 105963 test-amd64-i386-xl-qemuu-

Re: [Xen-devel] [PATCH v8 04/24] x86: refactor psr: implement CPU init and free flow.

2017-02-26 Thread Yi Sun
On 17-02-26 17:41:08, Wei Liu wrote: > On Wed, Feb 15, 2017 at 04:49:19PM +0800, Yi Sun wrote: > > This patch implements the CPU init and free flow including L3 CAT > > initialization and feature list free. > > > > Signed-off-by: Yi Sun > > Either you need to use a separate patch to move cpuid_c

Re: [Xen-devel] [PATCH v3] ring.h: introduce macros to handle monodirectional rings with multiple req sizes

2017-02-26 Thread Oleksandr Andrushchenko
On 02/23/2017 08:45 PM, Stefano Stabellini wrote: On Thu, 23 Feb 2017, Oleksandr Andrushchenko wrote: Hi, Stefano! On 02/22/2017 07:10 PM, Stefano Stabellini wrote: On Wed, 22 Feb 2017, Oleksandr Andrushchenko wrote: Hi, Stefano, Jan! 1. Stefano, are you still NOT considering adding functiona

Re: [Xen-devel] [PATCH v8 08/24] x86: refactor psr: set value: implement framework.

2017-02-26 Thread Yi Sun
On 17-02-26 17:41:43, Wei Liu wrote: > On Wed, Feb 15, 2017 at 04:49:23PM +0800, Yi Sun wrote: > [...] > > +int psr_set_val(struct domain *d, unsigned int socket, > > +uint64_t val, enum cbm_type type) > > IMHO it would be far better to use goto style error handling in such a > com

Re: [Xen-devel] [PATCH v8 09/24] x86: refactor psr: set value: assemble features value array.

2017-02-26 Thread Yi Sun
On 17-02-26 17:43:04, Wei Liu wrote: > On Wed, Feb 15, 2017 at 04:49:24PM +0800, Yi Sun wrote: > [...] > > > > +static unsigned int l3_cat_get_cos_num(const struct feat_node *feat) > > +{ > > +return 1; > > +} > > + > > +static int l3_cat_get_old_val(uint64_t val[], > > And the length of val

Re: [Xen-devel] [PATCH v8 10/24] x86: refactor psr: set value: implement cos finding flow.

2017-02-26 Thread Yi Sun
On 17-02-26 17:43:20, Wei Liu wrote: > On Wed, Feb 15, 2017 at 04:49:25PM +0800, Yi Sun wrote: > > Continue with patch: > > 'x86: refactor psr: set value: assemble features value array' > > > > We can try to find if there is a COS ID on which all features' COS registers > > values are same as the

Re: [Xen-devel] [PATCH v8 16/24] x86: refactor psr: implement set value callback functions for CDP.

2017-02-26 Thread Yi Sun
On 17-02-26 17:43:55, Wei Liu wrote: > On Wed, Feb 15, 2017 at 04:49:31PM +0800, Yi Sun wrote: > > This patch implements L3 CDP set value related callback functions. > > > > With this patch, 'psr-cat-cbm-set' command can work for L3 CDP. > > > > Signed-off-by: Yi Sun > > --- > > v8: > > - mo

Re: [Xen-devel] [PATCH] [linux-next] xenbus: Remove duplicate inclusion of linux/init.h

2017-02-26 Thread Juergen Gross
On 26/02/17 08:15, Masanari Iida wrote: > This patch remove duplicate inclusion of linux/init.h in > xenbus_dev_frontend.c. > Confirm successfully compile after remove the line. > > Signed-off-by: Masanari Iida Reviewed-by: Juergen Gross Thanks, Juergen _