Re: [Xen-devel] [PATCH v4] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-22 Thread Jan Beulich
>>> On 21.12.16 at 06:44, wrote: > --- a/xen/arch/x86/hvm/vmx/intr.c > +++ b/xen/arch/x86/hvm/vmx/intr.c > @@ -315,9 +315,13 @@ void vmx_intr_assist(void) > * Set eoi_exit_bitmap for periodic timer interrup to cause > EOI-induced VM > * exit, then pending periodic time interrups

[Xen-devel] [PATCH v1] displif: add ABI for para-virtual display

2016-12-22 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko This is the ABI for the two halves of a para-virtualized display driver. Changes since initial: * DRM changed to DISPL, protocol made generic * major re-work addressing issues raised for sndif Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Oleksandr Gryts

[Xen-devel] [PATCH v1] displif: add ABI for para-virtual display

2016-12-22 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko This protocol aims to provide a unified protocol which fits more sophisticated use-cases than a framebuffer device can handle. At the moment basic functionality is supported with the intention to extend: o multiple dynamically allocated/destroyed framebuffers o buf

[Xen-devel] [linux-3.18 test] 103786: regressions - trouble: broken/fail/pass

2016-12-22 Thread osstest service owner
flight 103786 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/103786/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-amd64 6 xen-bootfail REGR. vs. 101675 test-amd64-amd64-xl-

Re: [Xen-devel] [PATCH 1/2] x86/emul: Correct the return value handling of VMFUNC

2016-12-22 Thread Jan Beulich
>>> On 21.12.16 at 17:32, wrote: > The bracketing of x86_emulate() calling the ops->vmfunc() hook is wrong with > respect to the assignment to rc, which can trip the new assertions in > x86_emulate_wrapper(). > > The hvmemul_vmfunc() hook should only raise #UD if X86EMUL_EXCEPTION is > returned.

Re: [Xen-devel] [PATCH 2/2] x86/emul: Pass shadow register state to the vmfunc() hook

2016-12-22 Thread Jan Beulich
>>> On 21.12.16 at 17:32, wrote: > vmfunc can in principle modify register state, so should operate on the shadow > register state rather than the starting state of emulation. > > Signed-off-by: Andrew Cooper While in principle this is fine, I'd rather see the register state constified for now,

[Xen-devel] [PATCH 0/2] x86/VMX: XSA-203 follow-up

2016-12-22 Thread Jan Beulich
Patch 1 effectively is an alternative proposal to https://lists.xenproject.org/archives/html/xen-devel/2016-12/msg02567.html 1: x86/HVM: constify VMFUNC emulation hook 2: x86/VMX: don't needlessly install VMFUNC emulation hook Signed-off-by: Jan Beulich

Re: [Xen-devel] [PATCH v3] libacpi: Don't build x86-only AML for ARM64 mk_dsdt

2016-12-22 Thread Jan Beulich
>>> On 21.12.16 at 22:07, wrote: > @@ -99,20 +100,23 @@ static void decision_tree( > decision_tree(s, (s+e)/2, var, leaf); > pop_block(); > } > +#endif > > static struct option options[] = { > { "maxcpu", 1, 0, 'c' }, > +#if defined(CONFIG_X86) > { "dm-version", 1, 0, 'q' }

[Xen-devel] [PATCH 1/2] x86/HVM: constify VMFUNC emulation hook

2016-12-22 Thread Jan Beulich
... to clarify that the register state does not get altered (behind the back of the emulator). Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2006,7 +2006,7 @@ static void vmx_vcpu_update_vmfunc_ve(st vmx_vmcs_exit(v); } -static int vmx_v

[Xen-devel] [PATCH 2/2] x86/VMX: don't needlessly install VMFUNC emulation hook

2016-12-22 Thread Jan Beulich
Instead of checking cpu_has_vmx_vmfunc inside the hook, use it to determine whether to install the hook in the first place. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2011,7 +2011,7 @@ static int vmx_vcpu_emulate_vmfunc(const int rc = X8

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-22 Thread Jan Beulich
>>> On 20.12.16 at 20:46, wrote: > Signed-off-by: Alistair Francis Without some rationale given I don't think such changes are acceptable at all. And then, as already pointed out others, the use of -Werror is there not just for fun. If anything I think an override to that default could be accept

Re: [Xen-devel] [PATCH v2 2/5] config/StdGNU.mk: Allows users to pass in EXTRA_CFLAGS

2016-12-22 Thread Jan Beulich
>>> On 20.12.16 at 20:46, wrote: > --- a/config/StdGNU.mk > +++ b/config/StdGNU.mk > @@ -35,6 +35,9 @@ UTIL_LIBS = -lutil > SONAME_LDFLAG = -soname > SHLIB_LDFLAGS = -shared > > +# Allow users to add extra CFLAGS > +CFLAGS += $(EXTRA_CFLAGS) Along the lines of Wei's reply - please remember th

Re: [Xen-devel] [PATCH 1/2] config/StdGNU.mk: use CONFIG_LTO

2016-12-22 Thread Jan Beulich
>>> On 21.12.16 at 17:44, wrote: > The lto symbol is superseded by CONFIG_LTO now. Considering that this affects both tools and hypervisor build - is that true for both? Or if it's always been meant for the hypervisor build only, should is perhaps move out of config/ at once? Jan _

Re: [Xen-devel] [PATCH 2/2] INSTALL: remove stale lto build instruction

2016-12-22 Thread Jan Beulich
>>> On 21.12.16 at 17:44, wrote: > Signed-off-by: Wei Liu Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] build: move debug_symbols to tools/Rules.mk

2016-12-22 Thread Jan Beulich
>>> On 21.12.16 at 17:44, wrote: > --- a/Config.mk > +++ b/Config.mk > @@ -19,7 +19,6 @@ or = $(if $(strip $(1)),$(1),$(if $(strip > $(2)),$(2),$(if $(strip $(3)),$( > # A debug build of tools? > # Hypervisor debug build is controlled by Kconfig. > debug ?= y > -debug_symbols ?= $(debug)

[Xen-devel] [xen-4.7-testing test] 103790: regressions - trouble: broken/fail/pass

2016-12-22 Thread osstest service owner
flight 103790 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/103790/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 3 host-install(3)broken REGR. vs. 103769 test-amd64-amd6

[Xen-devel] [xen-unstable test] 103788: regressions - trouble: broken/fail/pass

2016-12-22 Thread osstest service owner
flight 103788 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/103788/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 3 host-install(3)broken REGR. vs. 103466 test-amd64-i386-li

Re: [Xen-devel] [PATCH v2] xen/setup: Don't relocate p2m over existing one

2016-12-22 Thread Juergen Gross
On 12/12/16 15:35, Ross Lagerwall wrote: > When relocating the p2m, take special care not to relocate it so > that is overlaps with the current location of the p2m/initrd. This is > needed since the full extent of the current location is not marked as a > reserved region in the e820. > > This was

Re: [Xen-devel] [PATCH] xen/evtchn: use rb_entry()

2016-12-22 Thread Juergen Gross
On 20/12/16 15:02, Geliang Tang wrote: > To make the code clearer, use rb_entry() instead of container_of() to > deal with rbtree. > > Signed-off-by: Geliang Tang Committed to xen/tip.git for-linus-4.10 Juergen > --- > drivers/xen/evtchn.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 delet

[Xen-devel] [PATCH] libxl/libxl_qmp.c: Fix code style in qmp_next()

2016-12-22 Thread Zhang Chen
Make select loop more readable. Signed-off-by: Zhang Chen --- tools/libxl/libxl_qmp.c | 123 1 file changed, 61 insertions(+), 62 deletions(-) diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c index ad22ad4..123a6bf 100644 --- a/tool

Re: [Xen-devel] [PATCH v4] x86/apicv: fix RTC periodic timer and apicv issue

2016-12-22 Thread Chao Gao
On Thu, Dec 22, 2016 at 03:48:48PM +0800, Tian, Kevin wrote: >sent too quick. I meant please add your tested-by here. :-) Yes, of course. Tested-by: Chao Gao > >> From: Tian, Kevin >> Sent: Thursday, December 22, 2016 3:48 PM >> >> Thanks a lot! >> >> > From: Gao, Chao >> > Sent: Thursday, Dec

Re: [Xen-devel] [PATCH 1/2] config/StdGNU.mk: use CONFIG_LTO

2016-12-22 Thread Wei Liu
On Thu, Dec 22, 2016 at 01:48:41AM -0700, Jan Beulich wrote: > >>> On 21.12.16 at 17:44, wrote: > > The lto symbol is superseded by CONFIG_LTO now. > > Considering that this affects both tools and hypervisor build - is that > true for both? Or if it's always been meant for the hypervisor build >

[Xen-devel] elbling1 (was Re: [xen-unstable test] 103788: regressions - trouble: broken/fail/pass)

2016-12-22 Thread Ian Jackson
osstest service owner writes ("[xen-unstable test] 103788: regressions - trouble: broken/fail/pass"): > flight 103788 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/103788/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which

[Xen-devel] [xen-4.4-testing baseline-only test] 68256: regressions - FAIL

2016-12-22 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 68256 xen-4.4-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68256/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-intel 6 xen-

Re: [Xen-devel] [PATCH v4 14/14] xen/x86: setup PVHv2 Dom0 ACPI tables

2016-12-22 Thread Roger Pau Monne
On Wed, Dec 21, 2016 at 10:04:20AM -0700, Jan Beulich wrote: > >>> On 21.12.16 at 17:32, wrote: > > On Mon, Dec 12, 2016 at 06:56:36AM -0700, Jan Beulich wrote: > >> >>> On 30.11.16 at 17:49, wrote: > >> > +static int __init hvm_setup_acpi_madt(struct domain *d, paddr_t *addr) > >> > +{ > >> > +

[Xen-devel] elbling1 (was Re: [xen-unstable test] 103788: regressions - trouble: broken/fail/pass)

2016-12-22 Thread Jan Beulich
>>> On 22.12.16 at 11:28, wrote: > osstest service owner writes ("[xen-unstable test] 103788: regressions - > trouble: broken/fail/pass"): >> flight 103788 xen-unstable real [real] >> http://logs.test-lab.xenproject.org/osstest/logs/103788/ >> >> Regressions :-( >> >> Tests which did not succe

Re: [Xen-devel] [PATCH] libxl/libxl_qmp.c: Fix code style in qmp_next()

2016-12-22 Thread Wei Liu
Also CC Anthony, who wrote the original code. On Thu, Dec 22, 2016 at 05:53:07PM +0800, Zhang Chen wrote: > Make select loop more readable. The behaviour of this function is changed. The changes are not necessarily wrong, but we need to have clear commit message for why the change of behaviour is

Re: [Xen-devel] [XEN KEXEC PATCH] Corrected comment typo "count not" to "could not"

2016-12-22 Thread Wei Liu
On Wed, Dec 21, 2016 at 04:39:22PM -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Dec 21, 2016 at 01:37:31PM -0800, Eric DeVolder wrote: > > Fix cut-n-paste typo; changed the words "count not" to "could not". > > > > No functional changes > > > > Signed-off-by: Eric DeVolder > > Reviewed-by: Kon

Re: [Xen-devel] [PATCH] init/FreeBSD: fix incorrect usage of $rc_pids in xendriverdomain

2016-12-22 Thread Roger Pau Monne
On Wed, Dec 21, 2016 at 04:53:52PM +, Wei Liu wrote: > On Wed, Dec 21, 2016 at 04:47:26PM +, Roger Pau Monne wrote: > > It should be rc_pid. > > > > Signed-off-by: Roger Pau Monné > > Reported-by: Nathan Friess > > Acked + applied. > > I suspect all the patches to fix FreeBSD init scri

Re: [Xen-devel] [PATCH v2 5/5] tools/blktap2/drivers: Remove non-existent sys/sysctl.h include

2016-12-22 Thread Wei Liu
On Tue, Dec 20, 2016 at 11:47:00AM -0800, Alistair Francis wrote: > To avoid build errors related to missing file 'sys/sysctl.h' by removing > the #include statement. > > Signed-off-by: Alistair Francis I can find this in Linux. Maybe this is also due to the libc you're using? On the flip side,

Re: [Xen-devel] [PATCH] init/FreeBSD: fix incorrect usage of $rc_pids in xendriverdomain

2016-12-22 Thread Ian Jackson
Roger Pau Monne writes ("Re: [PATCH] init/FreeBSD: fix incorrect usage of $rc_pids in xendriverdomain"): > On Wed, Dec 21, 2016 at 04:53:52PM +, Wei Liu wrote: > > I suspect all the patches to fix FreeBSD init script should be > > backported? > > Yes, that would be nice. I plan to apply them

Re: [Xen-devel] [PATCH v4 14/14] xen/x86: setup PVHv2 Dom0 ACPI tables

2016-12-22 Thread Jan Beulich
>>> On 22.12.16 at 11:43, wrote: > On Wed, Dec 21, 2016 at 10:04:20AM -0700, Jan Beulich wrote: >> I'm not convinced these table entries are tied to >255 CPUs - I'm >> seeing them on systems with far less. Hence I simply wonder what >> functionality we may miss to offer to OSes with these tables >

Re: [Xen-devel] [RFC PATCH 3/9] x86/HVM: Call vlapic_destroy after vcpu_destroy

2016-12-22 Thread Jan Beulich
>>> On 19.09.16 at 07:52, wrote: > Since vlapic_init() is called before vcpu_initialise(). > We should also follow the same order here. s/same/inverse/? Also the ordering issue extends to other calls, and I think if at all possible we should then do all the teardown in reverse order of init. Ja

Re: [Xen-devel] [RFC PATCH 4/9] x86/SVM: Modify VMCB fields to add AVIC support

2016-12-22 Thread Jan Beulich
>>> On 19.09.16 at 07:52, wrote: > --- a/xen/include/asm-x86/hvm/svm/vmcb.h > +++ b/xen/include/asm-x86/hvm/svm/vmcb.h > @@ -328,14 +328,15 @@ typedef union __packed > struct > { > u64 tpr: 8; > -u64 irq: 1; > +u64 irq: 1; /* disabled

Re: [Xen-devel] [PATCH v2 0/5] General Build Fixes

2016-12-22 Thread Wei Liu
On Tue, Dec 20, 2016 at 11:46:55AM -0800, Alistair Francis wrote: > tools/blktap2/vhd: Remove unused struct stat stats > tools/blktap2: Fix missing header file I've pushed these two to staging. ___ Xen-devel mailing list Xen-devel@lists.xen.org http

Re: [Xen-devel] [RFC PATCH 5/9] x86/HVM/SVM: Add AVIC initialization code

2016-12-22 Thread Jan Beulich
>>> On 19.09.16 at 07:52, wrote: > +int svm_avic_init_vcpu(struct vcpu *v) > +{ > +struct vlapic *vlapic = vcpu_vlapic(v); > +struct arch_svm_struct *s = &v->arch.hvm_svm; > + > +if ( svm_avic ) > +s->avic_bk_pg = vlapic->regs_page; Why this copying? Can't consuming code not u

Re: [Xen-devel] [PATCH 1/2] build: move debug_symbols to tools/Rules.mk

2016-12-22 Thread Wei Liu
On Thu, Dec 22, 2016 at 01:51:28AM -0700, Jan Beulich wrote: > >>> On 21.12.16 at 17:44, wrote: > > --- a/Config.mk > > +++ b/Config.mk > > @@ -19,7 +19,6 @@ or = $(if $(strip $(1)),$(1),$(if $(strip > > $(2)),$(2),$(if $(strip $(3)),$( > > # A debug build of tools? > > # Hypervisor debug

Re: [Xen-devel] [RFC PATCH 6/9] x86/SVM: Add AVIC vmexit handlers

2016-12-22 Thread Jan Beulich
>>> On 19.09.16 at 07:52, wrote: > +void svm_avic_vmexit_do_incomp_ipi(struct cpu_user_regs *regs) > +{ > +struct vcpu *v = current; Please name such variables "curr", which at once avoids the need for the unusual name ... > +struct vmcb_struct *vmcb = v->arch.hvm_svm.vmcb; > +u32 ic

Re: [Xen-devel] [RFC PATCH 7/9] x86/SVM: Add vcpu scheduling support for AVIC

2016-12-22 Thread Jan Beulich
>>> On 19.09.16 at 07:52, wrote: > --- a/xen/arch/x86/hvm/svm/avic.c > +++ b/xen/arch/x86/hvm/svm/avic.c > @@ -45,6 +45,83 @@ avic_get_phy_ait_entry(struct vcpu *v, int index) > } > > /*** > + * AVIC VCPU SCHEDULING > + */ > +static v

Re: [Xen-devel] [RFC PATCH 8/9] x86/SVM: Add interrupt management code via AVIC

2016-12-22 Thread Jan Beulich
>>> On 19.09.16 at 07:52, wrote: > Also, the AVIC hardware automatically synchronizes TPR and CR8/vTPR, when > values are updated. Therefore, xen does not need to handle this when enable > AVIC. I'm having trouble matching this up with ... > --- a/xen/arch/x86/hvm/svm/vmcb.c > +++ b/xen/arch/x86

Re: [Xen-devel] [RFC PATCH 0/9] Introduce AMD SVM AVIC

2016-12-22 Thread Jan Beulich
>>> On 19.09.16 at 07:52, wrote: > Suravee Suthikulpanit (9): > x86/HVM: Introduce struct hvm_pi_ops > x86/vLAPIC: Declare vlapic_read_aligned() and vlapic_reg_write() as > non-static > x86/HVM: Call vlapic_destroy after vcpu_destroy > x86/SVM: Modify VMCB fields to add AVIC support >

Re: [Xen-devel] [RFC PATCH 9/9] x86/SVM: Hook up miscellaneous AVIC functions

2016-12-22 Thread Jan Beulich
>>> On 19.09.16 at 07:52, wrote: > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -1495,6 +1495,16 @@ const struct hvm_function_table * __init > start_svm(void) > svm_function_table.hap_capabilities = HVM_HAP_SUPERPAGE_2MB | > ((cpuid_edx(0x8001) & 0x04

Re: [Xen-devel] elbling1 (was Re: [xen-unstable test] 103788: regressions - trouble: broken/fail/pass)

2016-12-22 Thread Andrew Cooper
On 22/12/16 10:45, Jan Beulich wrote: On 22.12.16 at 11:28, wrote: osstest service owner writes ("[xen-unstable test] 103788: regressions - trouble: broken/fail/pass"): flight 103788 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/103788/ Regressions :-( Tests which

Re: [Xen-devel] [PATCH v2 2/4] arm: store vcpu id in struct irq_pending

2016-12-22 Thread Andrew Cooper
On 22/12/16 02:15, Stefano Stabellini wrote: diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h index 467333c..fde5b32 100644 --- a/xen/include/asm-arm/vgic.h +++ b/xen/include/asm-arm/vgic.h @@ -72,6 +72,8 @@ struct pending_irq #define GIC_INVALID_LR (uint8_t)~0

Re: [Xen-devel] [RFC XEN PATCH 03/16] xen/x86: add a hypercall XENPF_pmem_add to report host pmem regions

2016-12-22 Thread Jan Beulich
>>> On 10.10.16 at 02:32, wrote: > --- /dev/null > +++ b/xen/arch/x86/pmem.c I wonder whether this should really be x86-specific: It's all ACPI based, isn't it? I notice that you already place pmem.h that way. > +static int is_included(unsigned long s1, unsigned long e1, > +

[Xen-devel] [xen-4.5-testing test] 103791: regressions - trouble: broken/fail/pass

2016-12-22 Thread osstest service owner
flight 103791 xen-4.5-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/103791/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-migrupgrade 3 host-install/src_host(3) broken REGR. vs. 103770 test-amd64-amd

[Xen-devel] Xenstore watch interface in the kernel

2016-12-22 Thread Juergen Gross
While working on the Linux xenbus kernel driver I stumbled over a rather strange interface: a Xenstore watch event is delivered via a callback defined as: void (*callback)(struct xenbus_watch *, const char **vec, unsigned int len); vec is an array of strings and len the n

[Xen-devel] [xen-unstable-smoke test] 103804: tolerable all pass - PUSHED

2016-12-22 Thread osstest service owner
flight 103804 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/103804/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [Xen-devel] [PATCH v4 14/14] xen/x86: setup PVHv2 Dom0 ACPI tables

2016-12-22 Thread Roger Pau Monne
On Thu, Dec 22, 2016 at 04:03:12AM -0700, Jan Beulich wrote: > >>> On 22.12.16 at 11:43, wrote: > > On Wed, Dec 21, 2016 at 10:04:20AM -0700, Jan Beulich wrote: > >> > Since Xen is the one that sets the local APIC address in the MADT, and it > >> > always matches the position of the emulated local

Re: [Xen-devel] [RFC XEN PATCH 04/16] xen/x86: add XENMEM_populate_pmemmap to map host pmem pages to guest

2016-12-22 Thread Jan Beulich
>>> On 10.10.16 at 02:32, wrote: > +static int pmem_assign_pages(struct domain *d, > + struct page_info *pg, unsigned int order) What is the order parameter good for here, when the only caller passes zero? > +{ > +int rc = 0; > +unsigned long i; > + > +spi

Re: [Xen-devel] elbling1 (was Re: [xen-unstable test] 103788: regressions - trouble: broken/fail/pass)

2016-12-22 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] elbling1 (was Re: [xen-unstable test] 103788: regressions - trouble: broken/fail/pass)"): > No. No similar problems I am aware of anywhere in XenRT (which haven't > ended up being down to human intervention in the firmware) Indeed. I asked some XenRT folk

Re: [Xen-devel] Xenstore watch interface in the kernel

2016-12-22 Thread Ian Jackson
Juergen Gross writes ("Xenstore watch interface in the kernel"): > While working on the Linux xenbus kernel driver I stumbled over a rather > strange interface: a Xenstore watch event is delivered via a callback > defined as: > > void (*callback)(struct xenbus_watch *, > c

Re: [Xen-devel] [RFC XEN PATCH 05/16] xen/x86: release pmem pages at domain destroy

2016-12-22 Thread Jan Beulich
>>> On 10.10.16 at 02:32, wrote: > --- a/xen/arch/x86/pmem.c > +++ b/xen/arch/x86/pmem.c > @@ -282,3 +282,44 @@ int pmem_populate(struct xen_pmemmap_args *args) > args->nr_done = i; > return rc; > } > + > +static int pmem_teardown_preemptible(struct domain *d, int *preempted) > +{ > +

Re: [Xen-devel] elbling1 (was Re: [xen-unstable test] 103788: regressions - trouble: broken/fail/pass)

2016-12-22 Thread Jan Beulich
>>> On 22.12.16 at 13:19, wrote: > Perhaps it would be worth telling Xen not to reboot on crash... I think that's worth giving a try (I assume that some timeout will cause the machine to get rebooted at some point anyway, to make it available again). Jan ___

Re: [Xen-devel] elbling1 (was Re: [xen-unstable test] 103788: regressions - trouble: broken/fail/pass)

2016-12-22 Thread Andrew Cooper
On 22/12/16 12:19, Ian Jackson wrote: Andrew Cooper writes ("Re: [Xen-devel] elbling1 (was Re: [xen-unstable test] 103788: regressions - trouble: broken/fail/pass)"): No. No similar problems I am aware of anywhere in XenRT (which haven't ended up being down to human intervention in the firmwar

Re: [Xen-devel] [PATCH 2/2] x86/emul: Pass shadow register state to the vmfunc() hook

2016-12-22 Thread Andrew Cooper
On 22/12/16 08:27, Jan Beulich wrote: On 21.12.16 at 17:32, wrote: vmfunc can in principle modify register state, so should operate on the shadow register state rather than the starting state of emulation. Signed-off-by: Andrew Cooper While in principle this is fine, I'd rather see the regis

Re: [Xen-devel] Xenstore watch interface in the kernel

2016-12-22 Thread Sander Eikelenboom
Thursday, December 22, 2016, 1:22:06 PM, you wrote: > Juergen Gross writes ("Xenstore watch interface in the kernel"): >> While working on the Linux xenbus kernel driver I stumbled over a rather >> strange interface: a Xenstore watch event is delivered via a callback >> defined as: >> >> void (*

Re: [Xen-devel] Xenstore watch interface in the kernel

2016-12-22 Thread Juergen Gross
On 22/12/16 13:49, Sander Eikelenboom wrote: > > Thursday, December 22, 2016, 1:22:06 PM, you wrote: > >> Juergen Gross writes ("Xenstore watch interface in the kernel"): >>> While working on the Linux xenbus kernel driver I stumbled over a rather >>> strange interface: a Xenstore watch event is

Re: [Xen-devel] [PATCH v15] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other.

2016-12-22 Thread Konrad Rzeszutek Wilk
On December 22, 2016 2:21:26 AM EST, Oleksandr Andrushchenko wrote: >Hi, Konrad! > >I see no comments for almost 3 weeks now, so >probably there are no objections against this protocol. >Can we please move on on this? Sorry, I had been busy with internal high priority items. Let me take a look a

Re: [Xen-devel] Xenstore watch interface in the kernel

2016-12-22 Thread Andrew Cooper
On 22/12/16 12:59, Juergen Gross wrote: On 22/12/16 13:49, Sander Eikelenboom wrote: Thursday, December 22, 2016, 1:22:06 PM, you wrote: Juergen Gross writes ("Xenstore watch interface in the kernel"): While working on the Linux xenbus kernel driver I stumbled over a rather strange interface:

Re: [Xen-devel] [PATCH 1/2] x86/HVM: constify VMFUNC emulation hook

2016-12-22 Thread Andrew Cooper
On 22/12/16 08:36, Jan Beulich wrote: ... to clarify that the register state does not get altered (behind the back of the emulator). Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org https://l

Re: [Xen-devel] [PATCH 2/2] x86/VMX: don't needlessly install VMFUNC emulation hook

2016-12-22 Thread Andrew Cooper
On 22/12/16 08:37, Jan Beulich wrote: Instead of checking cpu_has_vmx_vmfunc inside the hook, use it to determine whether to install the hook in the first place. Signed-off-by: Jan Beulich I am not so sure about this. vmfunc is reachable in the instruction emulator on hardware which doesn't

Re: [Xen-devel] elbling1 (was Re: [xen-unstable test] 103788: regressions - trouble: broken/fail/pass)

2016-12-22 Thread Ian Jackson
Jan Beulich writes ("Re: [Xen-devel] elbling1 (was Re: [xen-unstable test] 103788: regressions - trouble: broken/fail/pass)"): > On 22.12.16 at 13:19, wrote: > > Perhaps it would be worth telling Xen not to reboot on crash... > > I think that's worth giving a try (I assume that some timeout will

Re: [Xen-devel] Xenstore watch interface in the kernel

2016-12-22 Thread Ian Jackson
Sander Eikelenboom writes ("Re: [Xen-devel] Xenstore watch interface in the kernel"): > Something I did ran into while trying to use xenstore, was that the > callbacks don't give back the previous and current value. Others have replied to this, and I agree with them, but: this makes me think you

Re: [Xen-devel] [PATCH v5 04/14] tables.h: add linker table support

2016-12-22 Thread Andy Shevchenko
On Wed, 2016-12-21 at 18:38 -0800, Luis R. Rodriguez wrote: > A linker table is a data structure that is stitched together from > items > in multiple object files. Linux has historically implicitly used > linker > tables for ages, however they were all built in an adhoc manner which > requires link

Re: [Xen-devel] [PATCH v5 09/14] jump_label: port __jump_table to linker tables

2016-12-22 Thread Andy Shevchenko
On Wed, 2016-12-21 at 18:38 -0800, Luis R. Rodriguez wrote: > Move the __jump_table from the a custom section solution > to a generic solution, this avoiding extra vmlinux.lds.h > customizations. > > This also demos the use of the .data linker table and of > the shared asm call push_section_tbl().

[Xen-devel] [xen-4.8-testing test] 103792: trouble: broken/fail/pass

2016-12-22 Thread osstest service owner
flight 103792 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/103792/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-13 host-install(3)broken REGR. vs. 10

Re: [Xen-devel] [PATCH 2/2] x86/VMX: don't needlessly install VMFUNC emulation hook

2016-12-22 Thread Jan Beulich
>>> On 22.12.16 at 14:47, wrote: > On 22/12/16 08:37, Jan Beulich wrote: >> Instead of checking cpu_has_vmx_vmfunc inside the hook, use it to >> determine whether to install the hook in the first place. >> >> Signed-off-by: Jan Beulich > > I am not so sure about this. > > vmfunc is reachable in

[Xen-devel] [distros-debian-wheezy test] 68259: all pass

2016-12-22 Thread Platform Team regression test user
flight 68259 distros-debian-wheezy real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68259/ Perfect :-) All tests in this flight passed as required baseline version: flight 68223 jobs: build-amd64 pass build-armh

[Xen-devel] [xen-unstable-smoke test] 103806: tolerable all pass - PUSHED

2016-12-22 Thread osstest service owner
flight 103806 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/103806/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [Xen-devel] [BUG] Xen-4.8.0 efi/buildid.o: file not recognized/Ambiguous

2016-12-22 Thread Jan Beulich
>>> On 07.12.16 at 16:57, wrote: > efi/buildid.o: file not recognized: File format is ambiguous > efi/buildid.o: matching formats: coff-x86-64 pe-x86-64 Just fyi: After some analysis of the binutils sources I have come to the conclusion that this needs help from the binutils folks. I've

Re: [Xen-devel] elbling1 (was Re: [xen-unstable test] 103788: regressions - trouble: broken/fail/pass)

2016-12-22 Thread Jan Beulich
>>> On 22.12.16 at 14:47, wrote: > Jan Beulich writes ("Re: [Xen-devel] elbling1 (was Re: [xen-unstable test] > 103788: regressions - trouble: broken/fail/pass)"): >> On 22.12.16 at 13:19, wrote: >> > Perhaps it would be worth telling Xen not to reboot on crash... >> >> I think that's worth giv

Re: [Xen-devel] [PATCH 2/2] x86/VMX: don't needlessly install VMFUNC emulation hook

2016-12-22 Thread Jan Beulich
>>> On 22.12.16 at 15:31, wrote: On 22.12.16 at 14:47, wrote: >> On 22/12/16 08:37, Jan Beulich wrote: >>> Instead of checking cpu_has_vmx_vmfunc inside the hook, use it to >>> determine whether to install the hook in the first place. >>> >>> Signed-off-by: Jan Beulich >> >> I am not so su

[Xen-devel] [PATCH] tools/tests/x86_emulate: #define unlikely in x86 emulator test harness

2016-12-22 Thread Ian Jackson
"x86emul: in_longmode() should not ignore ->read_msr() errors" aka c/s 122dd9575c7a introduced a use of unlikely() in xen/arch/x86/x86_emulate/x86_emulate.c. I think this is probably intentional and fine. However, there is no definition of unlikely in the x86 emulator test harness, under tools.

Re: [Xen-devel] [PATCH] tools/tests/x86_emulate: #define unlikely in x86 emulator test harness

2016-12-22 Thread Andrew Cooper
On 22/12/16 14:58, Ian Jackson wrote: "x86emul: in_longmode() should not ignore ->read_msr() errors" aka c/s 122dd9575c7a introduced a use of unlikely() in xen/arch/x86/x86_emulate/x86_emulate.c. I think this is probably intentional and fine. However, there is no definition of unlikely in the x

[Xen-devel] [PATCH] docs: Clarify scope of reboot= and noreboot Xen command line options

2016-12-22 Thread Ian Jackson
Signed-off-by: Ian Jackson CC: Jan Beulich --- docs/misc/xen-command-line.markdown | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown index 0138978..68c81e6 100644 --- a/docs/misc/xen-command-line.mar

Re: [Xen-devel] [PATCH 2/2] x86/VMX: don't needlessly install VMFUNC emulation hook

2016-12-22 Thread Andrew Cooper
On 22/12/16 14:58, Jan Beulich wrote: On 22.12.16 at 15:31, wrote: On 22.12.16 at 14:47, wrote: On 22/12/16 08:37, Jan Beulich wrote: Instead of checking cpu_has_vmx_vmfunc inside the hook, use it to determine whether to install the hook in the first place. Signed-off-by: Jan Beulich I am

Re: [Xen-devel] [PATCH] tools/tests/x86_emulate: #define unlikely in x86 emulator test harness

2016-12-22 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH] tools/tests/x86_emulate: #define unlikely in x86 emulator test harness"): > On 22/12/16 14:58, Ian Jackson wrote: > > "x86emul: in_longmode() should not ignore ->read_msr() errors" aka > > c/s 122dd9575c7a introduced a use of unlikely() in > > xen/arch/x86/x86_em

[Xen-devel] [PATCH RFC] tools/xenlight: Create xenlight Makefile

2016-12-22 Thread Ronald Rojas
Create a basic Makefile to build and install libxenlight Golang bindings. Also add a stub package. --- Eventually this patch will contain the actual bindings package; for now it just includes a stub package. To Do: - Have configure detect golang bindings properly CC: xen-devel CC: Ian Jackson

Re: [Xen-devel] [PATCH] tools/tests/x86_emulate: #define unlikely in x86 emulator test harness

2016-12-22 Thread Jan Beulich
>>> On 22.12.16 at 16:10, wrote: > I did not find this important build fix for a regression in 4.8.0 > because: I wonder why you consider this important - the harness doesn't get built by default, and is of little use for other than smoke testing a limited set of changes to the insn emulator. >

Re: [Xen-devel] [PATCH] xsm: allow relevant permission during migrate and gpu-passthrough.

2016-12-22 Thread Doug Goldstein
On 12/20/16 3:37 AM, Anshul Makkar wrote: > On 20/12/2016 04:03, Doug Goldstein wrote: >> On 12/19/16 10:02 AM, Doug Goldstein wrote: >>> On 12/14/16 3:09 PM, Daniel De Graaf wrote: On 12/12/2016 09:00 AM, Anshul Makkar wrote: > During guest migrate allow permission to prevent > spurio

Re: [Xen-devel] [PATCH] docs: Clarify scope of reboot= and noreboot Xen command line options

2016-12-22 Thread Jan Beulich
>>> On 22.12.16 at 16:02, wrote: > @@ -1356,7 +1357,9 @@ The following resources are available: > > > Default: `0` > > -Specify the host reboot method. > +Specify the host reboot method, > +used when Xen crashes. > +(This does not affect deliberate reboots initiated by dom0.) This should be

Re: [Xen-devel] [PATCH] xsm: allow relevant permission during migrate and gpu-passthrough.

2016-12-22 Thread Jan Beulich
>>> On 22.12.16 at 16:28, wrote: > On 12/20/16 3:37 AM, Anshul Makkar wrote: >> On 20/12/2016 04:03, Doug Goldstein wrote: >>> On 12/19/16 10:02 AM, Doug Goldstein wrote: On 12/14/16 3:09 PM, Daniel De Graaf wrote: > On 12/12/2016 09:00 AM, Anshul Makkar wrote: >> During guest migrate

Re: [Xen-devel] [PATCH 2/2] x86/VMX: don't needlessly install VMFUNC emulation hook

2016-12-22 Thread Jan Beulich
>>> On 22.12.16 at 16:14, wrote: > On 22/12/16 14:58, Jan Beulich wrote: > On 22.12.16 at 15:31, wrote: >> On 22.12.16 at 14:47, wrote: On 22/12/16 08:37, Jan Beulich wrote: > Instead of checking cpu_has_vmx_vmfunc inside the hook, use it to > determine whether to install th

Re: [Xen-devel] [PATCH 1/3] xen: xenbus driver must not accept invalid transaction ids

2016-12-22 Thread Boris Ostrovsky
On 12/22/2016 02:19 AM, Juergen Gross wrote: > When accessing Xenstore in a transaction the user is specifying a > transaction id which he normally obtained from Xenstore when starting > the transaction. Xenstore is validating a transaction id against all > known transaction ids of the connection t

Re: [Xen-devel] [PATCH v2 5/5] tools/blktap2/drivers: Remove non-existent sys/sysctl.h include

2016-12-22 Thread Alistair Francis
On Thu, Dec 22, 2016 at 2:54 AM, Wei Liu wrote: > On Tue, Dec 20, 2016 at 11:47:00AM -0800, Alistair Francis wrote: >> To avoid build errors related to missing file 'sys/sysctl.h' by removing >> the #include statement. >> >> Signed-off-by: Alistair Francis > > I can find this in Linux. Maybe this

Re: [Xen-devel] [PATCH v2 5/5] tools/blktap2/drivers: Remove non-existent sys/sysctl.h include

2016-12-22 Thread Doug Goldstein
On 12/20/16 1:47 PM, Alistair Francis wrote: > To avoid build errors related to missing file 'sys/sysctl.h' by removing > the #include statement. > > Signed-off-by: Alistair Francis > --- > tools/blktap2/drivers/block-remus.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/blktap2

Re: [Xen-devel] [PATCH 2/3] xen: return xenstore command failures via response instead of rc

2016-12-22 Thread Boris Ostrovsky
On 12/22/2016 02:19 AM, Juergen Gross wrote: > When the xenbus driver does some special handling for a Xenstore > command any error condition related to the command should be returned > via an error response instead of letting the related write operation > fail. Otherwise the user land handler migh

Re: [Xen-devel] [PATCH 3/3] xen: remove stale xs_input_avail() from header

2016-12-22 Thread Boris Ostrovsky
On 12/22/2016 02:19 AM, Juergen Gross wrote: > In drivers/xen/xenbus/xenbus_comms.h there is a stale declaration of > xs_input_avail(). Remove it. > > Signed-off-by: Juergen Gross > Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@li

Re: [Xen-devel] [PATCH 1/3] xen: xenbus driver must not accept invalid transaction ids

2016-12-22 Thread Juergen Gross
On 22/12/16 16:38, Boris Ostrovsky wrote: > On 12/22/2016 02:19 AM, Juergen Gross wrote: >> When accessing Xenstore in a transaction the user is specifying a >> transaction id which he normally obtained from Xenstore when starting >> the transaction. Xenstore is validating a transaction id against

Re: [Xen-devel] [PATCH 2/3] xen: return xenstore command failures via response instead of rc

2016-12-22 Thread Juergen Gross
On 22/12/16 16:49, Boris Ostrovsky wrote: > On 12/22/2016 02:19 AM, Juergen Gross wrote: >> When the xenbus driver does some special handling for a Xenstore >> command any error condition related to the command should be returned >> via an error response instead of letting the related write operati

Re: [Xen-devel] [PATCH 2/3] xen: return xenstore command failures via response instead of rc

2016-12-22 Thread Boris Ostrovsky
On 12/22/2016 10:55 AM, Juergen Gross wrote: > On 22/12/16 16:49, Boris Ostrovsky wrote: >> On 12/22/2016 02:19 AM, Juergen Gross wrote: >>> When the xenbus driver does some special handling for a Xenstore >>> command any error condition related to the command should be returned >>> via an error re

Re: [Xen-devel] [PATCH v4 02/24] x86: refactor psr: remove L3 CAT/CDP codes.

2016-12-22 Thread Jan Beulich
>>> On 14.12.16 at 05:07, wrote: > The current cache allocation codes in psr.c do not consider > future features addition and are not friendly to extend. > > To make psr.c be more flexible to add new features and fulfill > the program principle, open for extension but closed for > modification, w

Re: [Xen-devel] [PATCH 08/10] x86/vm-event: use unambiguous register names

2016-12-22 Thread Razvan Cojocaru
On 12/20/2016 12:42 PM, Jan Beulich wrote: > This is in preparation of eliminating the mis-naming of 64-bit fields > with 32-bit register names (eflags instead of rflags etc). > > Signed-off-by: Jan Beulich Acked-by: Razvan Cojocaru Thanks, Razvan

Re: [Xen-devel] [PATCH v4 03/24] x86: refactor psr: implement main data structures.

2016-12-22 Thread Jan Beulich
>>> On 14.12.16 at 05:07, wrote: > To construct an extendible framework, we need analyze PSR features > and abstract the common things and feature specific things. Then, > encapsulate them into different data structures. > > By analyzing PSR features, we can get below map. > +

Re: [Xen-devel] [PATCH v4 14/14] xen/x86: setup PVHv2 Dom0 ACPI tables

2016-12-22 Thread Boris Ostrovsky
On 12/22/2016 07:17 AM, Roger Pau Monne wrote: > On Thu, Dec 22, 2016 at 04:03:12AM -0700, Jan Beulich wrote: > On 22.12.16 at 11:43, wrote: >>> On Wed, Dec 21, 2016 at 10:04:20AM -0700, Jan Beulich wrote: > Since Xen is the one that sets the local APIC address in the MADT, and it > al

Re: [Xen-devel] [PATCH v4 14/14] xen/x86: setup PVHv2 Dom0 ACPI tables

2016-12-22 Thread Jan Beulich
>>> On 22.12.16 at 17:17, wrote: > On 12/22/2016 07:17 AM, Roger Pau Monne wrote: >> Maybe Boris has some ideas about how to do CPU hotplug for Dom0? > > Why would Xen need to be able to parse the AML that is intended to be > executed by dom0? I'd think that all the hypervisor would need to do is

[Xen-devel] [xen-unstable-smoke test] 103808: tolerable all pass - PUSHED

2016-12-22 Thread osstest service owner
flight 103808 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/103808/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [Xen-devel] [PATCH v4 14/14] xen/x86: setup PVHv2 Dom0 ACPI tables

2016-12-22 Thread Roger Pau Monne
On Thu, Dec 22, 2016 at 09:24:02AM -0700, Jan Beulich wrote: > >>> On 22.12.16 at 17:17, wrote: > > On 12/22/2016 07:17 AM, Roger Pau Monne wrote: > >> Maybe Boris has some ideas about how to do CPU hotplug for Dom0? > > > > Why would Xen need to be able to parse the AML that is intended to be >

Re: [Xen-devel] [PATCH] tools/tests/x86_emulate: #define unlikely in x86 emulator test harness

2016-12-22 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH] tools/tests/x86_emulate: #define unlikely in x86 emulator test harness"): > On 22.12.16 at 16:10, wrote: > > I did not find this important build fix for a regression in 4.8.0 > > because: > > I wonder why you consider this important - the harness doesn't > get bu

  1   2   >