Re: [Xen-devel] [PATCH v2] x86/apicv: fix RTC periodic timer and apicv issue

2016-10-24 Thread Tian, Kevin
> From: Xuquan (Quan Xu) [mailto:xuqu...@huawei.com] > Sent: Monday, October 17, 2016 5:28 PM > > >> > >>Back to the main open before holiday - multiple EOIs may come to clear > >>irq_issued before guest actually handles the very vpt injection > >>(possible if vpt vector is shared with other sourc

Re: [Xen-devel] [PATCH v5 4/7] VMX: Make sure PI is in proper state before install the hooks

2016-10-24 Thread Jan Beulich
>>> On 17.10.16 at 08:26, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Wednesday, October 12, 2016 9:45 PM >> >>> On 11.10.16 at 02:57, wrote: >> > static void pi_desc_init(struct vcpu *v) >> > { >> > -uint32_t dest; >> > - >> > v->arch.hvm_vmx.pi_desc.nv = posted_in

Re: [Xen-devel] [PATCH v5 5/7] VT-d: No need to set irq affinity for posted format IRTE

2016-10-24 Thread Jan Beulich
>>> On 17.10.16 at 09:02, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Wednesday, October 12, 2016 9:56 PM >> >>> On 11.10.16 at 02:57, wrote: >> > --- a/xen/drivers/passthrough/vtd/intremap.c >> > +++ b/xen/drivers/passthrough/vtd/intremap.c >> > @@ -547,6 +547,49 @@ static in

Re: [Xen-devel] [PATCH v5 4/7] VMX: Make sure PI is in proper state before install the hooks

2016-10-24 Thread Wu, Feng
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Monday, October 24, 2016 3:23 PM > To: Wu, Feng > Cc: andrew.coop...@citrix.com; dario.faggi...@citrix.com; > george.dun...@eu.citrix.com; Tian, Kevin ; xen- > de...@lists.xen.org > Subject: RE: [PATCH v5 4/7] VM

Re: [Xen-devel] [PATCH v5 4/7] VMX: Make sure PI is in proper state before install the hooks

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 09:45, wrote: > >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Monday, October 24, 2016 3:23 PM >> To: Wu, Feng >> Cc: andrew.coop...@citrix.com; dario.faggi...@citrix.com; >> george.dun...@eu.citrix.com; Tian, Kevin ; xen- >> de...@lis

Re: [Xen-devel] [PATCH v5 5/7] VT-d: No need to set irq affinity for posted format IRTE

2016-10-24 Thread Wu, Feng
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Monday, October 24, 2016 3:28 PM > To: Wu, Feng > Cc: andrew.coop...@citrix.com; dario.faggi...@citrix.com; > george.dun...@eu.citrix.com; Tian, Kevin ; xen- > de...@lists.xen.org > Subject: RE: [PATCH v5 5/7] VT

Re: [Xen-devel] [PATCH v9 06/13] efi: create new early memory allocator

2016-10-24 Thread Daniel Kiper
On Wed, Oct 12, 2016 at 06:59:52AM -0600, Jan Beulich wrote: > >>> On 12.10.16 at 14:51, wrote: > > Hello Jan, > > > > On 12/10/2016 12:45, Jan Beulich wrote: > > On 11.10.16 at 15:39, wrote: > >>> On 06/10/16 13:21, Jan Beulich wrote: > >>> On 05.10.16 at 20:30, wrote: > > On 30/09/

Re: [Xen-devel] [PATCH] x86/emul: Reorder the user segments in x86_segment to match SReg3 encoding

2016-10-24 Thread Jan Beulich
>>> On 14.10.16 at 18:13, wrote: > @@ -2980,8 +2964,8 @@ x86_emulate( > break; > > case 0x8c: /* mov Sreg,r/m */ > -seg = decode_segment(modrm_reg); > -generate_exception_if(seg == decode_segment_failed, EXC_UD, -1); > +seg = modrm_reg; You need to mask wit

Re: [Xen-devel] [PATCH] x86/emul: Correctly annotate all push/pop %sreg instructions

2016-10-24 Thread Jan Beulich
>>> On 19.10.16 at 18:30, wrote: > c/s 373923ed9c2 "x86emul: fix pushing of selector registers" redirected > all push %sreg instructions into the general push path. However, this > ends up hitting the assertion at the head of the push path. > > Annotate All push and pop %sreg instructions as Mov

Re: [Xen-devel] [PATCH for-4.8] tools: Handle existing link to acpi directory

2016-10-24 Thread Wei Liu
On Sun, Oct 23, 2016 at 07:09:19PM -0400, Boris Ostrovsky wrote: > The link to acpi include directory is not removed by Makefile's 'clean' > target. This can lead to make failure when making xen/.dir target if > we try to create the link again. > > We can prevent this failure by (1) removing acpi

Re: [Xen-devel] [PATCH 1/3] xen/x86: Fixup misc stale issues

2016-10-24 Thread Jan Beulich
>>> On 14.10.16 at 18:02, wrote: > * Dom0 does now have an arch_config passed. > * hypercall() and smp_alloc_memory() no longer exist. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xen.org https:

Re: [Xen-devel] [PATCH] x86/emul: Reorder the user segments in x86_segment to match SReg3 encoding

2016-10-24 Thread Andrew Cooper
On 24/10/16 10:16, Jan Beulich wrote: On 14.10.16 at 18:13, wrote: >> @@ -2980,8 +2964,8 @@ x86_emulate( >> break; >> >> case 0x8c: /* mov Sreg,r/m */ >> -seg = decode_segment(modrm_reg); >> -generate_exception_if(seg == decode_segment_failed, EXC_UD, -1); >> +

[Xen-devel] [distros-debian-sid test] 67925: tolerable FAIL

2016-10-24 Thread Platform Team regression test user
flight 67925 distros-debian-sid real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/67925/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-i386-sid-netboot-pvgrub 9 debian-di-install fail like 67893 test-amd64-i386-amd

Re: [Xen-devel] [PATCH] RFC x86/hvm: Don't truncate the hvm hypercall index before range checking it

2016-10-24 Thread Jan Beulich
>>> On 14.10.16 at 17:51, wrote: > When the compat hypercall ABI was added for HVM guests (i.e. supporting 32bit > operating systems making hypercalls against a 64bit Xen), an ABI breakage was > introduced for non-compat guests, as the 64bit hypercall index became > truncated to 32 bits. > > This

Re: [Xen-devel] [PATCH v5 5/7] VT-d: No need to set irq affinity for posted format IRTE

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 10:57, wrote: > >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Monday, October 24, 2016 3:28 PM >> To: Wu, Feng >> Cc: andrew.coop...@citrix.com; dario.faggi...@citrix.com; >> george.dun...@eu.citrix.com; Tian, Kevin ; xen- >> de...@lis

Re: [Xen-devel] [PATCH] x86/emul: Correctly annotate all push/pop %sreg instructions

2016-10-24 Thread Wei Liu
On Mon, Oct 24, 2016 at 03:23:01AM -0600, Jan Beulich wrote: > >>> On 19.10.16 at 18:30, wrote: > > c/s 373923ed9c2 "x86emul: fix pushing of selector registers" redirected > > all push %sreg instructions into the general push path. However, this > > ends up hitting the assertion at the head of th

Re: [Xen-devel] [PATCH] RFC x86/hvm: Don't truncate the hvm hypercall index before range checking it

2016-10-24 Thread Andrew Cooper
On 24/10/16 10:33, Jan Beulich wrote: On 14.10.16 at 17:51, wrote: >> When the compat hypercall ABI was added for HVM guests (i.e. supporting 32bit >> operating systems making hypercalls against a 64bit Xen), an ABI breakage was >> introduced for non-compat guests, as the 64bit hypercall inde

Re: [Xen-devel] [PATCH v9 06/13] efi: create new early memory allocator

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 11:03, wrote: > On Wed, Oct 12, 2016 at 06:59:52AM -0600, Jan Beulich wrote: >> >>> On 12.10.16 at 14:51, wrote: >> > Hello Jan, >> > >> > On 12/10/2016 12:45, Jan Beulich wrote: >> > On 11.10.16 at 15:39, wrote: >> >>> On 06/10/16 13:21, Jan Beulich wrote: >> >>> On 0

Re: [Xen-devel] [PATCH] x86/emul: Correctly annotate all push/pop %sreg instructions

2016-10-24 Thread Andrew Cooper
On 24/10/16 10:54, Wei Liu wrote: > On Mon, Oct 24, 2016 at 03:23:01AM -0600, Jan Beulich wrote: > On 19.10.16 at 18:30, wrote: >>> c/s 373923ed9c2 "x86emul: fix pushing of selector registers" redirected >>> all push %sreg instructions into the general push path. However, this >>> ends up hit

Re: [Xen-devel] [PATCH] libxl: only free vcpu info list when it is allocated

2016-10-24 Thread Wei Liu
On Fri, Oct 21, 2016 at 07:26:16PM +0200, Dario Faggioli wrote: > On Fri, 2016-10-21 at 18:17 +0100, Wei Liu wrote: > > Clang complains nr_dom_vcpus may be used uninitialized after > > 4a6070ea9. > > > > The real issue is vinfo can be NULL and nr_dom_vcpus remains > > uninitialized if previous cal

Re: [Xen-devel] [PULL 0/3] tags/xen-20161021-tag

2016-10-24 Thread Peter Maydell
On 21 October 2016 at 21:06, Stefano Stabellini wrote: > The following changes since commit b49e452fe994f8fbcd22bf5a87b79a2355481318: > > Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20160921' > into staging (2016-10-21 13:49:58 +0100) > > are available in the git repository

Re: [Xen-devel] [PATCH] x86/emul: Reorder the user segments in x86_segment to match SReg3 encoding

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 11:28, wrote: > On 24/10/16 10:16, Jan Beulich wrote: > On 14.10.16 at 18:13, wrote: >>> @@ -2980,8 +2964,8 @@ x86_emulate( >>> break; >>> >>> case 0x8c: /* mov Sreg,r/m */ >>> -seg = decode_segment(modrm_reg); >>> -generate_exception_if(seg

Re: [Xen-devel] [osstest test] 101467: regressions - FAIL [and 3 more messages]

2016-10-24 Thread Ian Jackson
Ian Jackson writes ("Re: [osstest test] 101467: regressions - FAIL"): > osstest service owner writes ("[osstest test] 101467: regressions - FAIL"): > > test-armhf-armhf-libvirt13 > > saverestore-support-check fail REGR. vs. 101410 ... > This is due to fixing the saverestore-support-check

Re: [Xen-devel] [PATCH] RFC x86/hvm: Don't truncate the hvm hypercall index before range checking it

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 11:55, wrote: > On 24/10/16 10:33, Jan Beulich wrote: > On 14.10.16 at 17:51, wrote: >>> When the compat hypercall ABI was added for HVM guests (i.e. supporting >>> 32bit >>> operating systems making hypercalls against a 64bit Xen), an ABI breakage >>> was >>> introduced

[Xen-devel] [PATCH v2] libxl: initialise nr_dom_vcpus to fix 4a6070ea9

2016-10-24 Thread Wei Liu
Clang complains nr_dom_vcpus may be used uninitialised after 4a6070ea9. The real issue is vinfo can be NULL and nr_dom_vcpus remains uninitialised if previous call fails. Initialise nr_dom_vcpus to 0 at the beginning of the loop to fix the issue. Signed-off-by: Wei Liu --- Cc: Ian Jackson Cc:

Re: [Xen-devel] [PATCH 1/3] xen/x86: Fixup misc stale issues

2016-10-24 Thread Wei Liu
On Mon, Oct 24, 2016 at 03:26:20AM -0600, Jan Beulich wrote: > >>> On 14.10.16 at 18:02, wrote: > > * Dom0 does now have an arch_config passed. > > * hypercall() and smp_alloc_memory() no longer exist. > > > > Signed-off-by: Andrew Cooper > > Acked-by: Jan Beulich Release-acked-by: Wei Liu

Re: [Xen-devel] [PATCH v5 5/7] VT-d: No need to set irq affinity for posted format IRTE

2016-10-24 Thread Wu, Feng
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Monday, October 24, 2016 5:54 PM > To: Wu, Feng > Cc: andrew.coop...@citrix.com; dario.faggi...@citrix.com; > george.dun...@eu.citrix.com; Tian, Kevin ; xen- > de...@lists.xen.org > Subject: RE: [PATCH v5 5/7] VT

Re: [Xen-devel] PCI passthrough to QEMU traditional stubdom not working when option ROM present

2016-10-24 Thread Jan Beulich
>>> On 21.10.16 at 15:23, wrote: > Eric Shelton, on Fri 21 Oct 2016 09:01:43 -0400, wrote: >> ERROR: PCI region size must be pow2 type=0x8, size=0xdf08 > >> u32 u = pci_read_long(d, reg); >> if (u != 0x) >> - d->rom_base_addr = u; >> +{ >> +

Re: [Xen-devel] [PATCH v2] libxl: initialise nr_dom_vcpus to fix 4a6070ea9

2016-10-24 Thread Dario Faggioli
On Mon, 2016-10-24 at 11:11 +0100, Wei Liu wrote: > Clang complains nr_dom_vcpus may be used uninitialised after > 4a6070ea9. > > The real issue is vinfo can be NULL and nr_dom_vcpus remains > uninitialised if previous call fails. > > Initialise nr_dom_vcpus to 0 at the beginning of the loop to f

Re: [Xen-devel] [PATCH] RFC x86/hvm: Don't truncate the hvm hypercall index before range checking it

2016-10-24 Thread Andrew Cooper
On 24/10/16 11:09, Jan Beulich wrote: On 24.10.16 at 11:55, wrote: >> On 24/10/16 10:33, Jan Beulich wrote: >> On 14.10.16 at 17:51, wrote: When the compat hypercall ABI was added for HVM guests (i.e. supporting 32bit operating systems making hypercalls against a 64bit Xe

Re: [Xen-devel] [PATCH v2] libxl: initialise nr_dom_vcpus to fix 4a6070ea9

2016-10-24 Thread Ian Jackson
Wei Liu writes ("[PATCH v2] libxl: initialise nr_dom_vcpus to fix 4a6070ea9"): > Clang complains nr_dom_vcpus may be used uninitialised after > 4a6070ea9. > > The real issue is vinfo can be NULL and nr_dom_vcpus remains > uninitialised if previous call fails. > > Initialise nr_dom_vcpus to 0 at t

Re: [Xen-devel] 3.18.y missing "x86/cpu: Fix SMAP check in PVOPS environments"

2016-10-24 Thread Ian Jackson
Levin, Alexander writes ("Re: 3.18.y missing "x86/cpu: Fix SMAP check in PVOPS environments""): > On Tue, Oct 18, 2016 at 12:46:31PM -0400, Ian Jackson wrote: > > Hi. It appears that 3.18.y is lacking 581b7f158fe0 "x86/cpu: Fix SMAP > > check in PVOPS environments". Without this, it crashes when

Re: [Xen-devel] [PATCH] Xen: Force non-irq keyhandler to be run in tasklet when receive a debugkey from serial port

2016-10-24 Thread Jan Beulich
>>> On 22.10.16 at 13:23, wrote: > __serial_rx() runs in either irq handler or timer handler and non-irq > keyhandler should not run in these contexts. So always force non-irq > keyhandler to run in tasklet when receive a debugkey from serial port > > Signed-off-by: Lan Tianyu > --- > xen/drive

Re: [Xen-devel] [PATCH v5 5/7] VT-d: No need to set irq affinity for posted format IRTE

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 12:18, wrote: > >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Monday, October 24, 2016 5:54 PM >> To: Wu, Feng >> Cc: andrew.coop...@citrix.com; dario.faggi...@citrix.com; >> george.dun...@eu.citrix.com; Tian, Kevin ; xen- >> de...@lis

Re: [Xen-devel] [PATCH v5 5/7] VT-d: No need to set irq affinity for posted format IRTE

2016-10-24 Thread Wu, Feng
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Monday, October 24, 2016 6:57 PM > To: Wu, Feng > Cc: andrew.coop...@citrix.com; dario.faggi...@citrix.com; > george.dun...@eu.citrix.com; Tian, Kevin ; xen- > de...@lists.xen.org > Subject: RE: [PATCH v5 5/7] VT

Re: [Xen-devel] [PATCH] RFC x86/hvm: Don't truncate the hvm hypercall index before range checking it

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 12:25, wrote: > On 24/10/16 11:09, Jan Beulich wrote: > On 24.10.16 at 11:55, wrote: >>> On 24/10/16 10:33, Jan Beulich wrote: >>> On 14.10.16 at 17:51, wrote: > When the compat hypercall ABI was added for HVM guests (i.e. supporting > 32bit > operating sy

Re: [Xen-devel] Hardware Random Number Generator (RNG) access from Xen VMs, providing more entropy to guests

2016-10-24 Thread John Haxby
On 23/10/16 21:48, Pasi Kärkkäinen wrote: > Has anyone thought of writing Xen RNG (PV) driver? > > Afaik currently there's no access to hardware accelerated RNGs from Xen VMs, > so for example SSL/TLS operations can result in low entropy and blocking > /dev/random in Xen VMs, resulting in poor

Re: [Xen-devel] [RFC PATCH 7/9] x86/SVM: Add vcpu scheduling support for AVIC

2016-10-24 Thread Jan Beulich
>>> On 14.10.16 at 17:31, wrote: > On Mon, Sep 19, 2016 at 12:52:46AM -0500, Suravee Suthikulpanit wrote: >> + * APIC ID > 0xff is reserved. >> + */ >> +h_phy_apic_id = cpu_data[v->processor].apicid; >> +if ( h_phy_apic_id >= AVIC_PHY_APIC_ID_MAX ) > > What does that mean to

[Xen-devel] [PATCH] docs: remove wrong statement about bug in xenstore

2016-10-24 Thread Juergen Gross
docs/misc/xenstore.txt states that xenstored will use "0" as a valid transaction id after 2^32 transactions. This is not true. Remove that statement. Signed-off-by: Juergen Gross --- docs/misc/xenstore.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/docs/misc/xenstore.txt b/docs/misc/xe

Re: [Xen-devel] [PATCH v5 5/7] VT-d: No need to set irq affinity for posted format IRTE

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 13:10, wrote: > >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Monday, October 24, 2016 6:57 PM >> To: Wu, Feng >> Cc: andrew.coop...@citrix.com; dario.faggi...@citrix.com; >> george.dun...@eu.citrix.com; Tian, Kevin ; xen- >> de...@lis

Re: [Xen-devel] [PATCH] Xen: Force non-irq keyhandler to be run in tasklet when receive a debugkey from serial port

2016-10-24 Thread Wei Liu
On Mon, Oct 24, 2016 at 04:53:17AM -0600, Jan Beulich wrote: > >>> On 22.10.16 at 13:23, wrote: > > __serial_rx() runs in either irq handler or timer handler and non-irq > > keyhandler should not run in these contexts. So always force non-irq > > keyhandler to run in tasklet when receive a debugke

Re: [Xen-devel] Livepatch for Xen 4.9

2016-10-24 Thread Ross Lagerwall
On 10/03/2016 03:16 PM, Konrad Rzeszutek Wilk wrote: Hey! [CC-ing xen-devel] Xen 4.8-rc1 is out and means taking a break from some of the Livepatch hypervisor parts for me. Thanks for all the work you put in! My plan for 4.8 is to concentrate on any livepatch fallout and doing OSSTest al

Re: [Xen-devel] [PATCH] docs: remove wrong statement about bug in xenstore

2016-10-24 Thread Wei Liu
On Mon, Oct 24, 2016 at 01:27:17PM +0200, Juergen Gross wrote: > docs/misc/xenstore.txt states that xenstored will use "0" as a valid > transaction id after 2^32 transactions. This is not true. Remove that > statement. > > Signed-off-by: Juergen Gross Can you point me to the relevant code snippe

Re: [Xen-devel] [PATCH] docs: remove wrong statement about bug in xenstore

2016-10-24 Thread Juergen Gross
On 24/10/16 13:41, Wei Liu wrote: > On Mon, Oct 24, 2016 at 01:27:17PM +0200, Juergen Gross wrote: >> docs/misc/xenstore.txt states that xenstored will use "0" as a valid >> transaction id after 2^32 transactions. This is not true. Remove that >> statement. >> >> Signed-off-by: Juergen Gross > >

Re: [Xen-devel] [PATCH] docs: remove wrong statement about bug in xenstore

2016-10-24 Thread Andrew Cooper
On 24/10/16 12:49, Juergen Gross wrote: > On 24/10/16 13:41, Wei Liu wrote: >> On Mon, Oct 24, 2016 at 01:27:17PM +0200, Juergen Gross wrote: >>> docs/misc/xenstore.txt states that xenstored will use "0" as a valid >>> transaction id after 2^32 transactions. This is not true. Remove that >>> statem

[Xen-devel] [PATCH] x86emul: fix XOP decode

2016-10-24 Thread Jan Beulich
Commit f09902c456 ("x86emul: add XOP decoding") ended up overwriting b prior to the last use of its previously stored value. SLightly defer fetching the main opcode byte. Reported-by: Andrew Cooper Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_em

[Xen-devel] [PATCH] x86: MISALIGNSSE feature depends on SSE

2016-10-24 Thread Jan Beulich
Suggested-by: Andrew Cooper Signed-off-by: Jan Beulich --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -196,8 +196,9 @@ def crunch_numbers(state): # SSE is taken to mean support for the %XMM registers as well as the # instructions. Several futher instruction set

Re: [Xen-devel] [PATCH] docs: remove wrong statement about bug in xenstore

2016-10-24 Thread Juergen Gross
On 24/10/16 14:06, Andrew Cooper wrote: > On 24/10/16 12:49, Juergen Gross wrote: >> On 24/10/16 13:41, Wei Liu wrote: >>> On Mon, Oct 24, 2016 at 01:27:17PM +0200, Juergen Gross wrote: docs/misc/xenstore.txt states that xenstored will use "0" as a valid transaction id after 2^32 transact

[Xen-devel] [xen-unstable test] 101636: tolerable trouble: blocked/broken/fail/pass

2016-10-24 Thread osstest service owner
flight 101636 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/101636/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-multivcpu 19 capture-logs(19)broken pass in 101626 test-armhf-armhf-libvirt-xsm 6

Re: [Xen-devel] PCI passthrough to QEMU traditional stubdom not working when option ROM present

2016-10-24 Thread Eric Shelton
On Mon, Oct 24, 2016 at 6:19 AM, Jan Beulich wrote: On 21.10.16 at 15:23, wrote: >> Eric Shelton, on Fri 21 Oct 2016 09:01:43 -0400, wrote: >>> ERROR: PCI region size must be pow2 type=0x8, size=0xdf08 >> >>> u32 u = pci_read_long(d, reg); >>> if (u != 0x) >>>

Re: [Xen-devel] [PATCH for-4.8 2/3] libacpi: require ACPI_BUILD_DIR to be set

2016-10-24 Thread Jan Beulich
>>> On 14.10.16 at 19:02, wrote: > It's better to have a explicit error than a build failure returned by > gcc. > > Signed-off-by: Wei Liu Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] PCI passthrough to QEMU traditional stubdom not working when option ROM present

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 14:30, wrote: > As best as I can tell, the current code already writes out the proper > value for sizing ("pci_write_long(d, reg, ~0)" in the above code > snippet). No - for sizing a ROM BAR, only the address portion is supposed to be written with all 1s as per the PCI spec. In

Re: [Xen-devel] PCI passthrough to QEMU traditional stubdom not working when option ROM present

2016-10-24 Thread Eric Shelton
On Mon, Oct 24, 2016 at 8:47 AM, Jan Beulich wrote: On 24.10.16 at 14:30, wrote: >> As best as I can tell, the current code already writes out the proper >> value for sizing ("pci_write_long(d, reg, ~0)" in the above code >> snippet). > > No - for sizing a ROM BAR, only the address portion i

Re: [Xen-devel] [PATCH] docs: remove wrong statement about bug in xenstore

2016-10-24 Thread Wei Liu
On Mon, Oct 24, 2016 at 02:18:17PM +0200, Juergen Gross wrote: > On 24/10/16 14:06, Andrew Cooper wrote: > > On 24/10/16 12:49, Juergen Gross wrote: > >> On 24/10/16 13:41, Wei Liu wrote: > >>> On Mon, Oct 24, 2016 at 01:27:17PM +0200, Juergen Gross wrote: > docs/misc/xenstore.txt states that

Re: [Xen-devel] PCI passthrough to QEMU traditional stubdom not working when option ROM present

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 15:01, wrote: > On Mon, Oct 24, 2016 at 8:47 AM, Jan Beulich wrote: > On 24.10.16 at 14:30, wrote: >>> As best as I can tell, the current code already writes out the proper >>> value for sizing ("pci_write_long(d, reg, ~0)" in the above code >>> snippet). >> >> No - for si

Re: [Xen-devel] Test Xen 4.8 RC3 FULL SUCCESS 21.10.16

2016-10-24 Thread Juergen Schinker
> > still start up Problem with xenstored/oxenstored - I have to start it manually > > must be in Correlation with systemd > > xen 4.8-rc2 configure > [ http://paste.ubuntu.net/23366138/ | http://paste.ubuntu.net/23366138/ ] > > Above is a link to my `./configure` call in Xenial when building

[Xen-devel] [libvirt test] 101640: regressions - all pass

2016-10-24 Thread osstest service owner
flight 101640 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/101640/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-raw 12 saverestore-support-check fail REGR. vs. 101477 test-armhf-armhf-libvi

Re: [Xen-devel] PCI passthrough to QEMU traditional stubdom not working when option ROM present

2016-10-24 Thread Samuel Thibault
Jan Beulich, on Mon 24 Oct 2016 07:12:27 -0600, wrote: > And btw - is it really qemu that does this? It's pciaccess which does it. > I didn't think it would be a user space app doing any such sizing; I > thought this would get done elsewhere in stubdom/mini-os. mini-os just lets libpciaccess use

Re: [Xen-devel] Test Xen 4.8 RC3 FULL SUCCESS 21.10.16

2016-10-24 Thread Wei Liu
On Mon, Oct 24, 2016 at 02:14:26PM +0100, Juergen Schinker wrote: > > > > > still start up Problem with xenstored/oxenstored - I have to start it > > manually > > > > must be in Correlation with systemd > > > > xen 4.8-rc2 configure > > [ http://paste.ubuntu.net/23366138/ | http://paste.ubunt

[Xen-devel] [PATCH v2] docs: remove wrong statement about bug in xenstore

2016-10-24 Thread Juergen Gross
docs/misc/xenstore.txt states that xenstored will use "0" as a valid transaction id after 2^32 transactions. This is not true. Only oxenstored has this bug. Signed-off-by: Juergen Gross --- v2: oxenstored has this bug --- docs/misc/xenstore.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deleti

Re: [Xen-devel] [PATCH] Xen: Force non-irq keyhandler to be run in tasklet when receive a debugkey from serial port

2016-10-24 Thread Lan, Tianyu
On 10/24/2016 8:19 AM, Konrad Rzeszutek Wilk wrote: On Sat, Oct 22, 2016 at 07:23:03PM +0800, Lan Tianyu wrote: __serial_rx() runs in either irq handler or timer handler and non-irq keyhandler should not run in these contexts. So always force non-irq keyhandler to run in tasklet when receive a d

Re: [Xen-devel] [PATCH] Xen: Force non-irq keyhandler to be run in tasklet when receive a debugkey from serial port

2016-10-24 Thread Konrad Rzeszutek Wilk
On Mon, Oct 24, 2016 at 09:29:53PM +0800, Lan, Tianyu wrote: > On 10/24/2016 8:19 AM, Konrad Rzeszutek Wilk wrote: > > On Sat, Oct 22, 2016 at 07:23:03PM +0800, Lan Tianyu wrote: > > > __serial_rx() runs in either irq handler or timer handler and non-irq > > > keyhandler should not run in these con

[Xen-devel] [xen-unstable-smoke test] 101643: tolerable all pass - PUSHED

2016-10-24 Thread osstest service owner
flight 101643 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/101643/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [Xen-devel] [PATCH Altp2m cleanup 2/3 v11 1/2] Move altp2m specific functions to altp2m files.

2016-10-24 Thread Jan Beulich
>>> On 19.10.16 at 22:32, wrote: > @@ -499,26 +500,21 @@ int hap_enable(struct domain *d, u32 mode) > goto out; > } > > -if ( hvm_altp2m_supported() ) > +if ( (rv = altp2m_domain_init(d)) < 0 ) > { > -/* Init alternate p2m data */ > -if ( (d->arch.al

Re: [Xen-devel] [PATCH] Xen: Force non-irq keyhandler to be run in tasklet when receive a debugkey from serial port

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 15:29, wrote: > On 10/24/2016 8:19 AM, Konrad Rzeszutek Wilk wrote: >> On Sat, Oct 22, 2016 at 07:23:03PM +0800, Lan Tianyu wrote: >>> __serial_rx() runs in either irq handler or timer handler and non-irq >>> keyhandler should not run in these contexts. So always force non-irq >

Re: [Xen-devel] PCI passthrough to QEMU traditional stubdom not working when option ROM present

2016-10-24 Thread Eric Shelton
On Mon, Oct 24, 2016 at 9:12 AM, Jan Beulich wrote: On 24.10.16 at 15:01, wrote: >> On Mon, Oct 24, 2016 at 8:47 AM, Jan Beulich wrote: >> On 24.10.16 at 14:30, wrote: As best as I can tell, the current code already writes out the proper value for sizing ("pci_write_long(d, r

Re: [Xen-devel] [PATCH v2] docs: remove wrong statement about bug in xenstore

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 15:29, wrote: > --- a/docs/misc/xenstore.txt > +++ b/docs/misc/xenstore.txt > @@ -229,8 +229,10 @@ TRANSACTION_START| > | > tx_id request header field. When transaction is started whole > db is copied; reads and writes happen on the co

Re: [Xen-devel] [PATCH] Xen: Force non-irq keyhandler to be run in tasklet when receive a debugkey from serial port

2016-10-24 Thread Lan, Tianyu
On 10/24/2016 6:53 PM, Jan Beulich wrote: On 22.10.16 at 13:23, wrote: __serial_rx() runs in either irq handler or timer handler and non-irq keyhandler should not run in these contexts. So always force non-irq keyhandler to run in tasklet when receive a debugkey from serial port Signed-off-b

Re: [Xen-devel] PCI passthrough to QEMU traditional stubdom not working when option ROM present

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 15:56, wrote: > On Mon, Oct 24, 2016 at 9:12 AM, Jan Beulich wrote: > On 24.10.16 at 15:01, wrote: >>> On Mon, Oct 24, 2016 at 8:47 AM, Jan Beulich wrote: >>> On 24.10.16 at 14:30, wrote: > As best as I can tell, the current code already writes out the proper >>>

Re: [Xen-devel] [PATCH] x86: MISALIGNSSE feature depends on SSE

2016-10-24 Thread Andrew Cooper
On 24/10/16 13:17, Jan Beulich wrote: > Suggested-by: Andrew Cooper > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper > > --- a/xen/tools/gen-cpuid.py > +++ b/xen/tools/gen-cpuid.py > @@ -196,8 +196,9 @@ def crunch_numbers(state): > > # SSE is taken to mean support for the %XM

Re: [Xen-devel] [PATCH] Xen: Force non-irq keyhandler to be run in tasklet when receive a debugkey from serial port

2016-10-24 Thread Lan, Tianyu
On 10/24/2016 9:38 PM, Konrad Rzeszutek Wilk wrote: On Mon, Oct 24, 2016 at 09:29:53PM +0800, Lan, Tianyu wrote: On 10/24/2016 8:19 AM, Konrad Rzeszutek Wilk wrote: On Sat, Oct 22, 2016 at 07:23:03PM +0800, Lan Tianyu wrote: __serial_rx() runs in either irq handler or timer handler and non-i

Re: [Xen-devel] [PATCH] Xen: Force non-irq keyhandler to be run in tasklet when receive a debugkey from serial port

2016-10-24 Thread Lan, Tianyu
On 10/24/2016 9:54 PM, Jan Beulich wrote: On 24.10.16 at 15:29, wrote: On 10/24/2016 8:19 AM, Konrad Rzeszutek Wilk wrote: On Sat, Oct 22, 2016 at 07:23:03PM +0800, Lan Tianyu wrote: __serial_rx() runs in either irq handler or timer handler and non-irq keyhandler should not run in these con

Re: [Xen-devel] [PATCH] x86: MISALIGNSSE feature depends on SSE

2016-10-24 Thread Wei Liu
On Mon, Oct 24, 2016 at 03:10:49PM +0100, Andrew Cooper wrote: > On 24/10/16 13:17, Jan Beulich wrote: > > Suggested-by: Andrew Cooper > > Signed-off-by: Jan Beulich > > Reviewed-by: Andrew Cooper > Release-acked-by: Wei Liu ___ Xen-devel mailing

[Xen-devel] [ovmf test] 101639: all pass - PUSHED

2016-10-24 Thread osstest service owner
flight 101639 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/101639/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b8e54b012126a90911e9602b9f6e10d4e16d01d9 baseline version: ovmf 0bfb9ee855d0433efdb2b

Re: [Xen-devel] [PATCH] Xen: Force non-irq keyhandler to be run in tasklet when receive a debugkey from serial port

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 16:01, wrote: > On 10/24/2016 6:53 PM, Jan Beulich wrote: > On 22.10.16 at 13:23, wrote: >>> __serial_rx() runs in either irq handler or timer handler and non-irq >>> keyhandler should not run in these contexts. So always force non-irq >>> keyhandler to run in tasklet when

Re: [Xen-devel] [RFC PATCH 02/24] ARM: GICv3: allocate LPI pending and property table

2016-10-24 Thread Vijay Kilari
On Wed, Sep 28, 2016 at 11:54 PM, Andre Przywara wrote: > The ARM GICv3 ITS provides a new kind of interrupt called LPIs. > The pending bits and the configuration data (priority, enable bits) for > those LPIs are stored in tables in normal memory, which software has to > provide to the hardware. >

Re: [Xen-devel] [PATCH] Xen: Force non-irq keyhandler to be run in tasklet when receive a debugkey from serial port

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 16:12, wrote: > > On 10/24/2016 9:38 PM, Konrad Rzeszutek Wilk wrote: >> On Mon, Oct 24, 2016 at 09:29:53PM +0800, Lan, Tianyu wrote: >>> On 10/24/2016 8:19 AM, Konrad Rzeszutek Wilk wrote: On Sat, Oct 22, 2016 at 07:23:03PM +0800, Lan Tianyu wrote: > __serial_rx() ru

Re: [Xen-devel] [RFC PATCH 03/24] ARM: GICv3 ITS: allocate device and collection table

2016-10-24 Thread Vijay Kilari
On Wed, Sep 28, 2016 at 11:54 PM, Andre Przywara wrote: > Each ITS maps a pair of a DeviceID (usually the PCI b/d/f triplet) and > an EventID (the MSI payload or interrupt ID) to a pair of LPI number > and collection ID, which points to the target CPU. > This mapping is stored in the device and co

Re: [Xen-devel] [PATCH] Xen: Force non-irq keyhandler to be run in tasklet when receive a debugkey from serial port

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 16:15, wrote: > > On 10/24/2016 9:54 PM, Jan Beulich wrote: > On 24.10.16 at 15:29, wrote: >>> On 10/24/2016 8:19 AM, Konrad Rzeszutek Wilk wrote: On Sat, Oct 22, 2016 at 07:23:03PM +0800, Lan Tianyu wrote: > __serial_rx() runs in either irq handler or timer hand

Re: [Xen-devel] [RFC PATCH 04/24] ARM: GICv3 ITS: map ITS command buffer

2016-10-24 Thread Vijay Kilari
On Wed, Sep 28, 2016 at 11:54 PM, Andre Przywara wrote: > Instead of directly manipulating the tables in memory, an ITS driver > sends commands via a ring buffer to the ITS h/w to create or alter the > LPI mappings. > Allocate memory for that buffer and tell the ITS about it to be able > to send I

Re: [Xen-devel] libxencall/linux: prevent page migration for hypercall buffers

2016-10-24 Thread David Vrabel
On 03/08/16 18:27, David Vrabel wrote: > This is the libxencall side of the "xen/privcmd: prevent page > migration for hypercall buffers​" series for Linux. It calls the > necessary LOCK/UNLOCK ioctls. > > This should not be applied until after the Linux series is applied. This solution wasn't g

Re: [Xen-devel] [PATCH] x86emul: fix XOP decode

2016-10-24 Thread Andrew Cooper
On 24/10/16 13:17, Jan Beulich wrote: > Commit f09902c456 ("x86emul: add XOP decoding") ended up overwriting b > prior to the last use of its previously stored value. SLightly defer > fetching the main opcode byte. > > Reported-by: Andrew Cooper > Signed-off-by: Jan Beulich Reviewed-by: Andrew C

Re: [Xen-devel] [PATCH] Xen: Force non-irq keyhandler to be run in tasklet when receive a debugkey from serial port

2016-10-24 Thread Lan, Tianyu
On 10/24/2016 10:31 PM, Jan Beulich wrote: On 24.10.16 at 16:15, wrote: On 10/24/2016 9:54 PM, Jan Beulich wrote: On 24.10.16 at 15:29, wrote: On 10/24/2016 8:19 AM, Konrad Rzeszutek Wilk wrote: On Sat, Oct 22, 2016 at 07:23:03PM +0800, Lan Tianyu wrote: __serial_rx() runs in either i

Re: [Xen-devel] [PATCH] x86emul: fix XOP decode

2016-10-24 Thread Wei Liu
On Mon, Oct 24, 2016 at 03:40:03PM +0100, Andrew Cooper wrote: > On 24/10/16 13:17, Jan Beulich wrote: > > Commit f09902c456 ("x86emul: add XOP decoding") ended up overwriting b > > prior to the last use of its previously stored value. SLightly defer > > fetching the main opcode byte. > > > > Repor

Re: [Xen-devel] [PATCH v2] docs: remove wrong statement about bug in xenstore

2016-10-24 Thread Juergen Gross
On 24/10/16 15:57, Jan Beulich wrote: On 24.10.16 at 15:29, wrote: >> --- a/docs/misc/xenstore.txt >> +++ b/docs/misc/xenstore.txt >> @@ -229,8 +229,10 @@ TRANSACTION_START | >> | >> tx_id request header field. When transaction is started whole >> db is

Re: [Xen-devel] [PATCH v2] docs: remove wrong statement about bug in xenstore

2016-10-24 Thread Wei Liu
On Mon, Oct 24, 2016 at 04:43:59PM +0200, Juergen Gross wrote: > On 24/10/16 15:57, Jan Beulich wrote: > On 24.10.16 at 15:29, wrote: > >> --- a/docs/misc/xenstore.txt > >> +++ b/docs/misc/xenstore.txt > >> @@ -229,8 +229,10 @@ TRANSACTION_START | > >> | > >>tx_

Re: [Xen-devel] [PATCH v2] docs: remove wrong statement about bug in xenstore

2016-10-24 Thread Juergen Gross
On 24/10/16 16:47, Wei Liu wrote: > On Mon, Oct 24, 2016 at 04:43:59PM +0200, Juergen Gross wrote: >> On 24/10/16 15:57, Jan Beulich wrote: >> On 24.10.16 at 15:29, wrote: --- a/docs/misc/xenstore.txt +++ b/docs/misc/xenstore.txt @@ -229,8 +229,10 @@ TRANSACTION_START |

Re: [Xen-devel] [PATCH] Xen: Force non-irq keyhandler to be run in tasklet when receive a debugkey from serial port

2016-10-24 Thread Konrad Rzeszutek Wilk
On Mon, Oct 24, 2016 at 10:43:57PM +0800, Lan, Tianyu wrote: > > > On 10/24/2016 10:31 PM, Jan Beulich wrote: > > > > > On 24.10.16 at 16:15, wrote: > > > > > > > > On 10/24/2016 9:54 PM, Jan Beulich wrote: > > > > > > > On 24.10.16 at 15:29, wrote: > > > > > On 10/24/2016 8:19 AM, Konrad Rze

Re: [Xen-devel] [PATCH v2] docs: remove wrong statement about bug in xenstore

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 16:43, wrote: > On 24/10/16 15:57, Jan Beulich wrote: > On 24.10.16 at 15:29, wrote: >>> --- a/docs/misc/xenstore.txt >>> +++ b/docs/misc/xenstore.txt >>> @@ -229,8 +229,10 @@ TRANSACTION_START | >>> | >>> tx_id request header field. When tr

Re: [Xen-devel] [PATCH] Xen: Force non-irq keyhandler to be run in tasklet when receive a debugkey from serial port

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 16:43, wrote: > > On 10/24/2016 10:31 PM, Jan Beulich wrote: > On 24.10.16 at 16:15, wrote: >> >>> >>> On 10/24/2016 9:54 PM, Jan Beulich wrote: >>> On 24.10.16 at 15:29, wrote: > On 10/24/2016 8:19 AM, Konrad Rzeszutek Wilk wrote: >> On Sat, Oct 22, 2016 at

Re: [Xen-devel] [PATCH v2] docs: remove wrong statement about bug in xenstore

2016-10-24 Thread Wei Liu
On Mon, Oct 24, 2016 at 04:51:07PM +0200, Juergen Gross wrote: > On 24/10/16 16:47, Wei Liu wrote: > > On Mon, Oct 24, 2016 at 04:43:59PM +0200, Juergen Gross wrote: > >> On 24/10/16 15:57, Jan Beulich wrote: > >> On 24.10.16 at 15:29, wrote: > --- a/docs/misc/xenstore.txt > +++ b/do

Re: [Xen-devel] [PATCH v3 2/2] x86/Intel: virtualize support for cpuid faulting

2016-10-24 Thread Boris Ostrovsky
On 10/24/2016 12:18 AM, Kyle Huey wrote: > > The anomalies we see appear to be related to, or at least triggerable > by, the performance monitoring interrupt. The following program runs > a loop of roughly 2^25 conditional branches. It takes one argument, > the number of conditional branches to p

Re: [Xen-devel] [PATCH] Xen: Force non-irq keyhandler to be run in tasklet when receive a debugkey from serial port

2016-10-24 Thread Lan, Tianyu
On 10/24/2016 10:28 PM, Jan Beulich wrote: On 24.10.16 at 16:01, wrote: On 10/24/2016 6:53 PM, Jan Beulich wrote: On 22.10.16 at 13:23, wrote: __serial_rx() runs in either irq handler or timer handler and non-irq keyhandler should not run in these contexts. So always force non-irq keyhandl

[Xen-devel] [PATCH v2 RESEND] xenbus: prefer list_for_each()

2016-10-24 Thread Jan Beulich
This is more efficient than list_for_each_safe() when list modification is accompanied by breaking out of the loop. Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross --- v2: Avoid commit message to continue from subject. --- drivers/xen/xenbus/xenbus_dev_frontend.c |4 ++-- 1 file chang

[Xen-devel] [PATCH v2 RESEND] xen-netback: prefer xenbus_scanf() over xenbus_gather()

2016-10-24 Thread Jan Beulich
For single items being collected this should be preferred as being more typesafe (as the compiler can check format string and to-be-written-to variable match) and more efficient (requiring one less parameter to be passed). Signed-off-by: Jan Beulich --- v2: Avoid commit message to continue from s

Re: [Xen-devel] [PATCH] Xen: Force non-irq keyhandler to be run in tasklet when receive a debugkey from serial port

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 17:03, wrote: > > On 10/24/2016 10:28 PM, Jan Beulich wrote: > On 24.10.16 at 16:01, wrote: >>> On 10/24/2016 6:53 PM, Jan Beulich wrote: >>> On 22.10.16 at 13:23, wrote: > __serial_rx() runs in either irq handler or timer handler and non-irq > keyhandler sho

[Xen-devel] [PATCH RESEND] xenbus: check return value of xenbus_scanf()

2016-10-24 Thread Jan Beulich
Don't ignore errors here: Set backend state to unknown when unsuccessful. Signed-off-by: Jan Beulich --- drivers/xen/xenbus/xenbus_probe_frontend.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- 4.9-rc2/drivers/xen/xenbus/xenbus_probe_frontend.c +++ 4.9-rc2-xenbus-xenbus_scanf/

Re: [Xen-devel] [PATCH RFC 0/2] Fix PAGE_SIZE issues in public headers

2016-10-24 Thread Ian Jackson
Stefano Stabellini writes ("Re: [PATCH RFC 0/2] Fix PAGE_SIZE issues in public headers"): > Yes, as long as we backport the fixes to the Xen stable trees as soon as > possible. I have queued both of these for backport: d93539cc486aa6022195305dbea5fe12f90b69fe vscsiif.h: replace PAGE_SIZE with VS

Re: [Xen-devel] [RFC PATCH 07/24] ARM: GICv3 ITS: introduce device mapping

2016-10-24 Thread Vijay Kilari
On Wed, Sep 28, 2016 at 11:54 PM, Andre Przywara wrote: > The ITS uses device IDs to map LPIs to a device. Dom0 will later use > those IDs, which we directly pass on to the host. > For this we have to map each device that Dom0 may request to a host > ITS device with the same identifier. > Allocate

Re: [Xen-devel] [RFC PATCH 12/24] ARM: vGICv3: introduce basic ITS emulation bits

2016-10-24 Thread Vijay Kilari
On Wed, Sep 28, 2016 at 11:54 PM, Andre Przywara wrote: > Create a new file to hold the emulation code for the ITS widget. > For now we emulate the memory mapped ITS registers and provide a stub > to introduce the ITS command handling framework (but without actually > emulating any commands at thi

  1   2   >