Re: [Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem

On 2016/9/22 22:32, Wei Liu wrote: FAOD: I think all the issues I found so far in this patch and other patch(es) are mostly cosmetic. I would be happy to accept incremental patches on top of this series to make those changes. Ok, thanks for your review. No need to resend just yet unless th

Re: [Xen-devel] [PATCH v6 1/4] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server.

On 9/22/2016 5:12 PM, Yu Zhang wrote: On 9/21/2016 9:04 PM, George Dunlap wrote: On Fri, Sep 9, 2016 at 6:51 AM, Yu Zhang wrote: On 9/2/2016 6:47 PM, Yu Zhang wrote: A new HVMOP - HVMOP_map_mem_type_to_ioreq_server, is added to let one ioreq server claim/disclaim its responsibility for th

Re: [Xen-devel] [PATCH v6 1/4] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server.

On 9/23/2016 6:35 PM, George Dunlap wrote: On 22/09/16 17:02, Yu Zhang wrote: On 9/22/2016 7:32 PM, George Dunlap wrote: On Thu, Sep 22, 2016 at 10:12 AM, Yu Zhang wrote: On 9/21/2016 9:04 PM, George Dunlap wrote: On Fri, Sep 9, 2016 at 6:51 AM, Yu Zhang wrote: On 9/2/2016 6:47 PM, Yu Z

Re: [Xen-devel] [PATCH 04/17] x86emul: complete decoding of two-byte instructions

>>> On 23.09.16 at 18:34, wrote: > It would be helpful if you listed all of the decoding modified. > > From the looks of things, the instructions changed are: I don't see the point: If any of them got proper emulation added, I'd agree. But with the purpose of the patch being to simply add corre

[Xen-devel] [PATCH] block: xen-blkback: don't get/put blkif ref for each queue

xen_blkif_get/put() for each queue is useless, and introduces a bug: If there is I/O inflight when removing device, xen_blkif_disconnect() will return -EBUSY and xen_blkif_put() not be called. Which means the references are leaked, then even if I/O completed, the xen_blkif_put() won't call xen_blk

Re: [Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem

On Mon, Sep 26, 2016 at 03:08:43PM +0800, Shannon Zhao wrote: > > > On 2016/9/22 22:32, Wei Liu wrote: > >FAOD: > > > >I think all the issues I found so far in this patch and other patch(es) > >are mostly cosmetic. I would be happy to accept incremental patches on > >top of this series to make th

[Xen-devel] [xen-unstable test] 101148: tolerable FAIL

flight 101148 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/101148/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-qcow2 6 xen-boot fail pass in 101141 test-armhf-armhf-xl-rtds 16

Re: [Xen-devel] [Outreachy] Consolidating adhoc parsers in xl

Hi, Nimisha On Sun, Sep 25, 2016 at 04:05:44PM +0530, nimisha agarwal wrote: > Hello, > I wish to take part in the Outreach Program this time. I am interested in > the project *consolidating adhoc parsers in xl *. I have a good > understanding of C, still need to get familiar with GNU make and aut

Re: [Xen-devel] Xen 4.6.1 crash with altp2menabledbydefault

>>> On 22.09.16 at 17:11, wrote: > Here is a call stack from dmesg. > Keep in mind that the compiler omits some function names (most importantly > the vmx_fpu_leave) and also that vmx_vmenter_helper is not actually called. > The backtrace just thinks it is called because the ud2 which panics the >

[Xen-devel] [distros-debian-sid test] 67762: tolerable FAIL

flight 67762 distros-debian-sid real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/67762/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-i386-sid-netboot-pvgrub 9 debian-di-install fail blocked in 67729 test-amd64-i386

Re: [Xen-devel] [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries

On Fri, Sep 23, 2016 at 03:14:20PM -0400, Boris Ostrovsky wrote: > diff --git a/tools/firmware/hvmloader/acpi/gpl/mk_dsdt_gpl.sh > b/tools/firmware/hvmloader/acpi/gpl/mk_dsdt_gpl.sh > new file mode 100755 > index 000..28a0dd7 > --- /dev/null > +++ b/tools/firmware/hvmloader/acpi/gpl/mk_dsdt_gp

Re: [Xen-devel] [Help] Trigger Watchdog when adding an IPI in vcpu_wake

On Sat, 2016-09-24 at 11:39 +0800, Wei Yang wrote: > On Thu, Sep 22, 2016 at 11:12:15AM +0200, Dario Faggioli wrote: > > _Almost_ correct. However, the problem is more that vcpu_wake() can > > happen in response to an IRQ, and when you grab a spinlock in IRQ > > context, you need to disable IRQs. >

Re: [Xen-devel] [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries

Wei Liu writes ("Re: [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries"): > On Fri, Sep 23, 2016 at 03:14:20PM -0400, Boris Ostrovsky wrote: > > +links="ABCD" > > + > > +for i in $(seq 0 3) > > +do > > +link=${links:$i:1} > > This is not portable. > > Use following in

Re: [Xen-devel] [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries

On Mon, Sep 26, 2016 at 11:20:50AM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH v6] acpi: Prevent GPL-only code from seeping into > non-GPL binaries"): > > On Fri, Sep 23, 2016 at 03:14:20PM -0400, Boris Ostrovsky wrote: > > > +links="ABCD" > > > + > > > +for i in $(seq 0 3) > > > +do >

Re: [Xen-devel] [PATCH v4] x86/vm_event: Allow overwriting Xen's i-cache used for emulation

>>> On 22.09.16 at 20:54, wrote: > When emulating instructions Xen's emulator maintains a small i-cache fetched > from the guest memory. This patch extends the vm_event interface to allow > overwriting this i-cache via a buffer returned in the vm_event response. > > When responding to a SOFTWARE_

Re: [Xen-devel] [PATCH v7 01/14] x86: move xen ELF end of image to 16 MiB

>>> On 23.09.16 at 23:47, wrote: > It seems that from xen ELF image POV _end symbol properly determine > image end. However, taking into account that initial Xen image mapping > covers 16 MiB it looks that it is not sufficient. Currently bootloader > potentially may load xen ELF image at 1 MiB and

Re: [Xen-devel] [PATCH v7 02/14] x86: properly calculate xen ELF end of image address

>>> On 23.09.16 at 23:47, wrote: > Currently xen ELF end of image address is calculated using first line from > "nm -nr xen/xen-syms" output. However, sometimes it may contain random > symbol address not related to the end of image in any way. There's nothing random here, or at least you fail to

Re: [Xen-devel] Json config and stubdomain

On Sat, Sep 24, 2016 at 12:42:45PM +0200, Marek Marczykowski-Górecki wrote: > Hi, > > Debugging stubdomain continuation... > When stubdomain is started, it has no json config created. This results > in multiple problems: > - impossible to dynamically attach additional devices > - starting a doma

Re: [Xen-devel] Fwd: Openindiana, using -machine pc, accel=xen in qemu

On Thu, Sep 22, 2016 at 10:37:14AM -0400, jim burns wrote: > Pls cc me with any replies. > > On Thursday, 22 September 2016, 12:22:02 EDT, Anthony PERARD wrote: > > On Wed, Sep 21, 2016 at 06:20:16PM -0400, jim burns wrote: > > > I didn't get any responses in xen-users, so I'm posting here. My use

Re: [Xen-devel] [PATCH v7 01/14] x86: move xen ELF end of image to 16 MiB

On Mon, Sep 26, 2016 at 04:39:37AM -0600, Jan Beulich wrote: > >>> On 23.09.16 at 23:47, wrote: > > It seems that from xen ELF image POV _end symbol properly determine > > image end. However, taking into account that initial Xen image mapping > > covers 16 MiB it looks that it is not sufficient. C

Re: [Xen-devel] [PATCH v4 1/6] VMX: Statically assign two PI hooks

>>> On 21.09.16 at 04:37, wrote: > PI hooks: vmx_pi_switch_from() and vmx_pi_switch_to() are > needed even when any previously assigned device is detached > from the domain. Since 'SN' bit is also used to control the > CPU side PI and we change the state of SN bit in these two > functions, then ev

Re: [Xen-devel] Json config and stubdomain

On Mon, Sep 26, 2016 at 12:01:01PM +0100, Wei Liu wrote: > On Sat, Sep 24, 2016 at 12:42:45PM +0200, Marek Marczykowski-Górecki wrote: > > So, the question is, whether json config should be created and properly > > maintained for stubdomain, or not created at all (assuming all the > > configuration

Re: [Xen-devel] [PATCH v4 2/6] VMX: Properly handle pi when all the assigned devices are removed

>>> On 21.09.16 at 04:37, wrote: > +static void vmx_pi_list_cleanup(struct vcpu *v) > +{ > +vmx_pi_list_remove(v); > +} Please avoid such a no-op wrapper - the caller can easily call vmx_pi_list_remove() directly. > @@ -215,13 +225,28 @@ void vmx_pi_hooks_assign(struct domain *d) > /* This

Re: [Xen-devel] [PATCH v7 02/14] x86: properly calculate xen ELF end of image address

On Mon, Sep 26, 2016 at 04:45:25AM -0600, Jan Beulich wrote: > >>> On 23.09.16 at 23:47, wrote: > > Currently xen ELF end of image address is calculated using first line from > > "nm -nr xen/xen-syms" output. However, sometimes it may contain random > > symbol address not related to the end of ima

Re: [Xen-devel] [PATCH v4 1/6] VMX: Statically assign two PI hooks

>>> On 26.09.16 at 13:37, wrote: On 21.09.16 at 04:37, wrote: >> PI hooks: vmx_pi_switch_from() and vmx_pi_switch_to() are >> needed even when any previously assigned device is detached >> from the domain. Since 'SN' bit is also used to control the >> CPU side PI and we change the state of S

[Xen-devel] [PATCH v2 0/1] [STUBDOM] Added COPYING files and README.source files

Added a COPYING file as a boilerplate to explain license oddities in this directory Added a vtpm/COPYING file which contains MIT licensed files only Added a vtpmmgr/README.source file which contains many BSD-3-Clause files that originally came from tools/vtpm_manager Signed-off-by: Lars Kurth -

[Xen-devel] [PATCH v2 0/2] Clarify License information : stubdom, tools/blktap2

This series contains some of the easier license clean-up cases, which can be fixed by adding COPYING files or README.source files. The series specially contains: stubdom Added a COPYING file as a boilerplate to explain license oddities in this directory Added a vtpm/COPYING file which contains M

[Xen-devel] [PATCH 2/2] blktap2: Added COPYING file

Blktap2 has some complexity, as some files do not have (c) headers and the directory did not have a COPYING file. At this stage, we have not verified the intention of (c) holders. We may do this in future, if the need arises. Signed-off-by: Lars Kurth --- tools/blktap2/COPYING | 72 +

[Xen-devel] [PATCH] x86/AMD: apply erratum 665 workaround

From: Emanuel Czirai AMD F12h machines have an erratum which can cause DIV/IDIV to behave unpredictably. The workaround is to set MSRC001_1029[31] but sometimes there is no BIOS update containing that workaround so let's do it ourselves unconditionally. It is simple enough. [ Borislav: Wrote com

Re: [Xen-devel] [PATCH v7 01/14] x86: move xen ELF end of image to 16 MiB

>>> On 26.09.16 at 13:34, wrote: > On Mon, Sep 26, 2016 at 04:39:37AM -0600, Jan Beulich wrote: >> >>> On 23.09.16 at 23:47, wrote: >> > It seems that from xen ELF image POV _end symbol properly determine >> > image end. However, taking into account that initial Xen image mapping >> > covers 16 M

Re: [Xen-devel] [PATCH v2 0/1] [STUBDOM] Added COPYING files and README.source files

On Mon, Sep 26, 2016 at 01:16:33PM +0100, Lars Kurth wrote: > Added a COPYING file as a boilerplate to explain license oddities in > this directory > > Added a vtpm/COPYING file which contains MIT licensed files only > > Added a vtpmmgr/README.source file which contains many BSD-3-Clause > files

Re: [Xen-devel] [PATCH v7 02/14] x86: properly calculate xen ELF end of image address

>>> On 26.09.16 at 14:06, wrote: > On Mon, Sep 26, 2016 at 04:45:25AM -0600, Jan Beulich wrote: >> >>> On 23.09.16 at 23:47, wrote: >> > Currently xen ELF end of image address is calculated using first line from >> > "nm -nr xen/xen-syms" output. However, sometimes it may contain random >> > symb

Re: [Xen-devel] [PATCH 2/2] blktap2: Added COPYING file

On Mon, Sep 26, 2016 at 01:16:34PM +0100, Lars Kurth wrote: > Blktap2 has some complexity, as some files do not have (c) headers > and the directory did not have a COPYING file. At this stage, we > have not verified the intention of (c) holders. We may do this in > future, if the need arises. > >

[Xen-devel] [PATCH 0/2] Xen pvUSB correction

Trying to use pvUSB in a Xen guest with a qemu emulated USB controller will crash qemu as it tries to attach a pvUSB device to the emulated controller. This can be avoided by adding a unique id to each pvUSB controller which can be used when attaching the pvUSB device. In order to make this possib

[Xen-devel] [PATCH 1/2] xen: add an own bus for xen backend devices

Add a bus for Xen backend devices in order to be able to establish a dedicated device path for pluggable devices. Signed-off-by: Juergen Gross --- hw/xen/xen_backend.c | 19 --- include/hw/xen/xen_backend.h | 4 2 files changed, 20 insertions(+), 3 deletions(-) dif

[Xen-devel] [PATCH 2/2] xen: add qemu device for each pvusb backend

In order to be able to specify to which pvusb controller a new pvusb device should be added we need a qemu device for each pvusb controller with an associated id. Add such a device when a new controller is requested and attach the usb bus of that controller to the new device. Any device connected

Re: [Xen-devel] [PATCH v4 4/6] VMX: Make sure PI is in proper state before install the hooks

>>> On 21.09.16 at 04:37, wrote: > We may hit the ASSERT() in vmx_vcpu_block in the current code, There are three of them - please be explicit which one is what gets dealt with here. > --- a/xen/arch/x86/hvm/vmx/vmcs.c > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > @@ -956,16 +956,13 @@ void virtual_vmcs

Re: [Xen-devel] [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries

On 09/26/2016 02:46 AM, Jan Beulich wrote: On 23.09.16 at 21:14, wrote: >> Changes in v6: >> * Replaced script's printf in most case with "here document" (for multi-line >> text) or echo for single line. Left printf for formatted output. >> (Note that in one case paramter expansion is nec

Re: [Xen-devel] [PATCH] x86/AMD: apply erratum 665 workaround

On 26/09/16 13:27, Jan Beulich wrote: > From: Emanuel Czirai > > AMD F12h machines have an erratum which can cause DIV/IDIV to behave > unpredictably. The workaround is to set MSRC001_1029[31] but sometimes > there is no BIOS update containing that workaround so let's do it > ourselves uncondition

Re: [Xen-devel] [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries

On 09/26/2016 06:24 AM, Wei Liu wrote: > On Mon, Sep 26, 2016 at 11:20:50AM +0100, Ian Jackson wrote: >> Wei Liu writes ("Re: [PATCH v6] acpi: Prevent GPL-only code from seeping >> into non-GPL binaries"): >>> On Fri, Sep 23, 2016 at 03:14:20PM -0400, Boris Ostrovsky wrote: +links="ABCD"

Re: [Xen-devel] [PATCH v4 5/6] VT-d: No need to set irq affinity for posted format IRTE

>>> On 21.09.16 at 04:37, wrote: > We don't set the affinity for posted format IRTE, since the > destination of these interrupts is vCPU and the vCPU affinity > is set during vCPU scheduling. I'm quite sure I did point out before that you talk about just affinity changes here, yet ... > --- a/xe

[Xen-devel] Outreachy Round 13 .Reg

Hi, I am Harini, an undergraduate pursuing Bachelors Of Engineering in Information Science having some prior experience with coding in C and Golang. I am interested in applying for Outreachy Round 13 in golang bindings for libxl project. Can I know the first contributions to be made for the same

Re: [Xen-devel] [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries

On Mon, Sep 26, 2016 at 08:58:00AM -0400, Boris Ostrovsky wrote: > On 09/26/2016 06:24 AM, Wei Liu wrote: > > On Mon, Sep 26, 2016 at 11:20:50AM +0100, Ian Jackson wrote: > >> Wei Liu writes ("Re: [PATCH v6] acpi: Prevent GPL-only code from seeping > >> into non-GPL binaries"): > >>> On Fri, Sep 2

Re: [Xen-devel] [PATCH v4 6/6] VMX: Fixup PI descritpor when cpu is offline

>>> On 21.09.16 at 04:37, wrote: > +void vmx_pi_desc_fixup(int cpu) > +{ > +unsigned int new_cpu, dest; > +unsigned long flags; > +struct arch_vmx_struct *vmx, *tmp; > +spinlock_t *new_lock, *old_lock = &per_cpu(vmx_pi_blocking, cpu).lock; > +struct list_head *blocked_vcpus = &

Re: [Xen-devel] [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries

>>> On 26.09.16 at 14:49, wrote: > On 09/26/2016 02:46 AM, Jan Beulich wrote: > On 23.09.16 at 21:14, wrote: >>> Changes in v6: >>> * Replaced script's printf in most case with "here document" (for multi-line >>> text) or echo for single line. Left printf for formatted output. >>> (Note t

Re: [Xen-devel] Outreachy Round 13 .Reg

On 26/09/16 13:59, Harini V Reddy wrote: > Hi, > > I am Harini, an undergraduate pursuing Bachelors Of Engineering > in Information Science having some prior experience with coding > in C and Golang. > > I am interested in applying for Outreachy Round 13 in golang bindings > for libxl project. >

Re: [Xen-devel] [PATCH v7 03/14] x86: add multiboot2 protocol support

>>> On 23.09.16 at 23:47, wrote: > +static multiboot_info_t *mbi2_reloc(u32 mbi_in) > +{ > +const multiboot2_fixed_t *mbi_fix = _p(mbi_in); > +const multiboot2_memory_map_t *mmap_src; > +const multiboot2_tag_t *tag; > +module_t *mbi_out_mods = NULL; > +memory_map_t *mmap_dst; >

Re: [Xen-devel] [PATCH v2 0/2] Clarify License information : stubdom, tools/blktap2

On Mon, Sep 26, 2016 at 01:16:32PM +0100, Lars Kurth wrote: > This series contains some of the easier license clean-up cases, which can be > fixed > by adding COPYING files or README.source files. The series specially contains: > > stubdom > Added a COPYING file as a boilerplate to explain licens

Re: [Xen-devel] [PATCH RFC v7 07/14] efi: create new early memory allocator

>>> On 23.09.16 at 23:47, wrote: > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -79,6 +79,10 @@ static size_t wstrlen(const CHAR16 * s); > static int set_color(u32 mask, int bpp, u8 *pos, u8 *sz); > static bool_t match_guid(const EFI_GUID *guid1, const EFI_GUID *guid2); > > +

Re: [Xen-devel] [PATCH] x86emul: correct loading of %ss

On 21/09/16 10:05, Jan Beulich wrote: > - Instead of #NP, #SS needs to be raised for non-present descriptors. > - Loading a null selector is fine in 64-bit mode at CPL != 3, as long > as RPL == CPL. > - Don't lose the low two selector bits on null selector loads (also > applies to %ds, %es, %fs

Re: [Xen-devel] [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries

On 09/26/2016 09:08 AM, Jan Beulich wrote: On 26.09.16 at 14:49, wrote: >> On 09/26/2016 02:46 AM, Jan Beulich wrote: >> On 23.09.16 at 21:14, wrote: Changes in v6: * Replaced script's printf in most case with "here document" (for multi-line text) or echo for singl

Re: [Xen-devel] [PATCH v7 08/14] x86: add multiboot2 protocol support for EFI platforms

>>> On 23.09.16 at 23:47, wrote: > This way Xen can be loaded on EFI platforms using GRUB2 and > other boot loaders which support multiboot2 protocol. > > Signed-off-by: Daniel Kiper > Acked-by: Jan Beulich > --- > v7 - suggestions/fixes: >- do not allocate twice memory for trampoline if we

Re: [Xen-devel] [PATCH v7 09/14] x86/boot: implement early command line parser in C

>>> On 23.09.16 at 23:47, wrote: > Current early command line parser implementation in assembler > is very difficult to change to relocatable stuff using segment > registers. This requires a lot of changes in very weird and > fragile code. So, reimplement this functionality in C. This > way code w

Re: [Xen-devel] [PATCH] x86emul: don't allow null selector for LTR

On 22/09/16 07:38, Jan Beulich wrote: > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries

>>> On 26.09.16 at 15:43, wrote: > On 09/26/2016 09:08 AM, Jan Beulich wrote: > On 26.09.16 at 14:49, wrote: >>> On 09/26/2016 02:46 AM, Jan Beulich wrote: >>> On 23.09.16 at 21:14, wrote: > Changes in v6: > * Replaced script's printf in most case with "here document" (for >

Re: [Xen-devel] [PATCH] x86emul: correct loading of %ss

>>> On 26.09.16 at 15:40, wrote: > On 21/09/16 10:05, Jan Beulich wrote: >> @@ -1248,7 +1254,6 @@ protmode_load_seg( >> >> dpl = (desc.b >> 13) & 3; >> rpl = sel & 3; > > ... it occurs to me that the calculation of rpl can be moved up to its > declaration, which allows you to check (c

Re: [Xen-devel] [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries

On 09/26/2016 06:04 AM, Wei Liu wrote: > On Fri, Sep 23, 2016 at 03:14:20PM -0400, Boris Ostrovsky wrote: >> diff --git a/tools/firmware/hvmloader/acpi/gpl/mk_dsdt_gpl.sh >> b/tools/firmware/hvmloader/acpi/gpl/mk_dsdt_gpl.sh >> new file mode 100755 >> index 000..28a0dd7 >> --- /dev/null >> +++

Re: [Xen-devel] [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries

On Mon, Sep 26, 2016 at 10:01:37AM -0400, Boris Ostrovsky wrote: > On 09/26/2016 06:04 AM, Wei Liu wrote: > > On Fri, Sep 23, 2016 at 03:14:20PM -0400, Boris Ostrovsky wrote: > >> diff --git a/tools/firmware/hvmloader/acpi/gpl/mk_dsdt_gpl.sh > >> b/tools/firmware/hvmloader/acpi/gpl/mk_dsdt_gpl.sh

Re: [Xen-devel] [PATCH] x86/HVM: correct segment register loading during task switch

On 23/09/16 11:09, Jan Beulich wrote: > Instead of #NP, #SS needs to be raised for a non-present %ss > descriptor. > > Don't lose the low two selector bits on null selector loads. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel

Re: [Xen-devel] [PATCH] block: xen-blkback: don't get/put blkif ref for each queue

On Mon, Sep 26, 2016 at 03:36:24PM +0800, Bob Liu wrote: > xen_blkif_get/put() for each queue is useless, and introduces a bug: > > If there is I/O inflight when removing device, xen_blkif_disconnect() will > return -EBUSY and xen_blkif_put() not be called. > Which means the references are leaked,

Re: [Xen-devel] [PATCH v7 08/14] x86: add multiboot2 protocol support for EFI platforms

On 23/09/16 22:47, Daniel Kiper wrote: > +/* > + * Initialize BSS (no nasty surprises!). > + * It must be done earlier than in BIOS case > + * because efi_multiboot2() touches it. > + */ > +lea .startof.(.bss)(%rip),%edi > +mov $.sizeo

Re: [Xen-devel] [PATCH v4] x86/vm_event: Allow overwriting Xen's i-cache used for emulation

On 09/26/2016 01:33 PM, Jan Beulich wrote: On 22.09.16 at 20:54, wrote: >> When emulating instructions Xen's emulator maintains a small i-cache fetched >> from the guest memory. This patch extends the vm_event interface to allow >> overwriting this i-cache via a buffer returned in the vm_even

Re: [Xen-devel] [PATCH v7 08/14] x86: add multiboot2 protocol support for EFI platforms

>>> On 26.09.16 at 16:19, wrote: > On 23/09/16 22:47, Daniel Kiper wrote: >> +/* >> + * Initialize BSS (no nasty surprises!). >> + * It must be done earlier than in BIOS case >> + * because efi_multiboot2() touches it. >> + */ >> +lea .startof.(.

Re: [Xen-devel] [PATCH v7 08/14] x86: add multiboot2 protocol support for EFI platforms

On 26/09/16 15:33, Jan Beulich wrote: On 26.09.16 at 16:19, wrote: >> On 23/09/16 22:47, Daniel Kiper wrote: >>> +/* >>> + * Initialize BSS (no nasty surprises!). >>> + * It must be done earlier than in BIOS case >>> + * because efi_multiboot2() touches it. >>>

[Xen-devel] [PATCH] x86/svm: Drop the set_segment_register() macro

Replace its sole users with a single piece of inline assembly which is more flexable about its register constraints, rather than forcing the use of %ax. While editing this area, reflow the comment to remove trailing whitespace and use fewer lines. No functional change. Signed-off-by: Andrew Coop

Re: [Xen-devel] [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries

Boris Ostrovsky writes ("Re: [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries"): > There are two interdependent variables that I need to print. The C > equivalent is > > for ( i = 0; i < 4; i++ ) > printf("%d %c\n", i, 'A'+i); > > The character value is deriv

Re: [Xen-devel] Outreachy Winter Internship

On Wed, Sep 14, 2016 at 5:28 PM, George Dunlap wrote: > On 11/09/16 11:52, Kavya Sharma wrote: >> Hello Sir,I am Kavya Sharma, an aspiring Outreachy intern.It would be my >> privilege to be an intern with xenproject.org this winter.I have read >> about Xen Hypervisor Userspace Tools and I am inter

Re: [Xen-devel] [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries

Boris Ostrovsky writes ("Re: [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries"): > On 09/26/2016 06:04 AM, Wei Liu wrote: > > On Fri, Sep 23, 2016 at 03:14:20PM -0400, Boris Ostrovsky wrote: > >> diff --git a/tools/firmware/hvmloader/acpi/gpl/mk_dsdt_gpl.sh > >> b/tools/f

Re: [Xen-devel] [PATCH v4] x86/vm_event: Allow overwriting Xen's i-cache used for emulation

On Sep 26, 2016 08:29, "Razvan Cojocaru" wrote: > > On 09/26/2016 01:33 PM, Jan Beulich wrote: > On 22.09.16 at 20:54, wrote: > >> When emulating instructions Xen's emulator maintains a small i-cache fetched > >> from the guest memory. This patch extends the vm_event interface to allow > >>

[Xen-devel] [ovmf test] 101151: all pass - PUSHED

flight 101151 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/101151/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 065ae7d717f9e49c3be12dada109d60dead0bb90 baseline version: ovmf 587e9dfbbafe7d4e772c1

Re: [Xen-devel] [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries

On 09/26/2016 10:45 AM, Ian Jackson wrote: > Boris Ostrovsky writes ("Re: [PATCH v6] acpi: Prevent GPL-only code from > seeping into non-GPL binaries"): >> There are two interdependent variables that I need to print. The C >> equivalent is >> >> for ( i = 0; i < 4; i++ ) >> printf("%d

Re: [Xen-devel] Fwd: Openindiana, using -machine pc, accel=xen in qemu

On Monday, 26 September 2016, 12:32:01 EDT, Anthony PERARD wrote: > On Thu, Sep 22, 2016 at 10:37:14AM -0400, jim burns wrote: > > Pls cc me with any replies. > > > > On Thursday, 22 September 2016, 12:22:02 EDT, Anthony PERARD wrote: > > > On Wed, Sep 21, 2016 at 06:20:16PM -0400, jim burns wrote

Re: [Xen-devel] [PATCH v7 12/14] x86: make Xen early boot code relocatable

>>> On 23.09.16 at 23:47, wrote: > @@ -426,32 +453,65 @@ trampoline_bios_setup: > xor %cl, %cl > > trampoline_setup: > +/* > + * Called on legacy BIOS and EFI platforms. > + * > + * Initialize 0-15 bits of BOOT_FS segment descriptor base address. > +

Re: [Xen-devel] [PATCH v7 08/14] x86: add multiboot2 protocol support for EFI platforms

>>> On 26.09.16 at 16:40, wrote: > On 26/09/16 15:33, Jan Beulich wrote: > On 26.09.16 at 16:19, wrote: >>> On 23/09/16 22:47, Daniel Kiper wrote: +/* + * Initialize BSS (no nasty surprises!). + * It must be done earlier than in BIOS case +

Re: [Xen-devel] [PATCH] x86/svm: Drop the set_segment_register() macro

>>> On 26.09.16 at 16:45, wrote: > Replace its sole users with a single piece of inline assembly which is more > flexable about its register constraints, rather than forcing the use of %ax. > > While editing this area, reflow the comment to remove trailing whitespace and > use fewer lines. > > N

Re: [Xen-devel] [PATCH] x86/svm: Drop the set_segment_register() macro

On 09/26/2016 10:45 AM, Andrew Cooper wrote: > Replace its sole users with a single piece of inline assembly which is more > flexable about its register constraints, rather than forcing the use of %ax. > > While editing this area, reflow the comment to remove trailing whitespace and > use fewer lin

[Xen-devel] [PATCH] Added COPYING and README.patch files to xen/common and xen/tools

This patch adds information related to non-GPL licenses and code imports from 3rd party projects. The aim of this patch, is to make it easier for future contributors, to perform a review of the codebase. Signed-off-by: Lars Kurth --- xen/common/COPYING | 16 + xen/common

Re: [Xen-devel] [PATCH] x86emul: correct loading of %ss

>>> On 26.09.16 at 15:40, wrote: > On 21/09/16 10:05, Jan Beulich wrote: >> - Instead of #NP, #SS needs to be raised for non-present descriptors. >> - Loading a null selector is fine in 64-bit mode at CPL != 3, as long >> as RPL == CPL. >> - Don't lose the low two selector bits on null selector

Re: [Xen-devel] [PATCH v4] x86/vm_event: Allow overwriting Xen's i-cache used for emulation

On 09/26/2016 05:55 PM, Tamas K Lengyel wrote: > On Sep 26, 2016 08:29, "Razvan Cojocaru" > wrote: >> >> On 09/26/2016 01:33 PM, Jan Beulich wrote: >> On 22.09.16 at 20:54, > wrote: >> >> When emulating instructions Xen's e

Re: [Xen-devel] [PATCH] x86emul: correct loading of %ss

On 26/09/16 16:25, Jan Beulich wrote: On 26.09.16 at 15:40, wrote: >> On 21/09/16 10:05, Jan Beulich wrote: >>> - Instead of #NP, #SS needs to be raised for non-present descriptors. >>> - Loading a null selector is fine in 64-bit mode at CPL != 3, as long >>> as RPL == CPL. >>> - Don't lose

Re: [Xen-devel] [PATCH v7 13/14] x86/boot: rename sym_phys() to sym_offs()

>>> On 23.09.16 at 23:47, wrote: > This way macro name better describes its function. I'd appreciate if you could mention the change in function, so that it ends up being quite obvious why the name change is desirable. With that: Acked-by: Jan Beulich Jan

Re: [Xen-devel] [PATCH] Added COPYING and README.patch files to xen/common and xen/tools

On Mon, Sep 26, 2016 at 04:23:27PM +0100, Lars Kurth wrote: > This patch adds information related to non-GPL licenses and code > imports from 3rd party projects. The aim of this patch, is to > make it easier for future contributors, to perform a review > of the codebase. I see a lot 'amd' instead

Re: [Xen-devel] [PATCH v7 14/14] x86: add multiboot2 protocol support for relocatable images

>>> On 23.09.16 at 23:47, wrote: > @@ -383,10 +390,19 @@ __start: > cmp %edi,MB2_fixed_total_size(%ebx) > jbe trampoline_bios_setup > > +/* Get Xen image load base address from Multiboot2 information. */ > +cmpl$MULTIBOOT2_TAG_TYPE_LOAD_BASE_ADDR,MB2

Re: [Xen-devel] [PATCH] Added COPYING and README.patch files to xen/common and xen/tools

On 26/09/2016 16:49, "Konrad Rzeszutek Wilk" wrote: >On Mon, Sep 26, 2016 at 04:23:27PM +0100, Lars Kurth wrote: >> This patch adds information related to non-GPL licenses and code >> imports from 3rd party projects. The aim of this patch, is to >> make it easier for future contributors, to per

Re: [Xen-devel] [PATCH v4] x86/vm_event: Allow overwriting Xen's i-cache used for emulation

> -Original Message- > From: Tamas K Lengyel [mailto:tamas.leng...@zentific.com] > Sent: 22 September 2016 19:54 > To: xen-de...@lists.xenproject.org > Cc: Tamas K Lengyel ; Paul Durrant > ; Jan Beulich ; Andrew > Cooper ; Jun Nakajima > ; Kevin Tian ; George > Dunlap ; Stefano Stabellini >

Re: [Xen-devel] [PATCH Altp2m cleanup v5 1/3] altp2m cleanup work.

>>> On 13.09.16 at 18:46, wrote: > Indent goto labels by one space. > Inline (header) altp2m functions. > In do_altp2m_op(), during the sanity check of the passed command, > return -ENONSYS if not a valid command. > In do_altp2m_op(), when evaluating a command, ASSERT_UNREACHABLE() > if the comman

[Xen-devel] [PATCH v2] Added COPYING and README.patch files to xen/common and xen/tools

This patch adds information related to non-GPL licenses and code imports from 3rd party projects. The aim of this patch, is to make it easier for future contributors, to perform a review of the codebase. Signed-off-by: Lars Kurth Reviewed-by: Konrad Rzeszutek Wilk --- Changes since v1 Fixed typ

Re: [Xen-devel] Question about VPID during MOV-TO-CR3

On Mon, Sep 26, 2016 at 12:24 AM, Jan Beulich wrote: On 23.09.16 at 22:45, wrote: >> On Fri, Sep 23, 2016 at 9:50 AM, Tamas K Lengyel >> wrote: >>> On Fri, Sep 23, 2016 at 9:39 AM, Jan Beulich wrote: >>> On 23.09.16 at 17:26, wrote: > On Fri, Sep 23, 2016 at 2:24 AM, Jan Beulich

Re: [Xen-devel] [PATCH RFC 07/12] xen/x86: parse Dom0 kernel for PVHv2

>>> On 29.07.16 at 18:29, wrote: > Introduce a helper to parse the Dom0 kernel. It would help if you clarified why this needs to be different from the PV ELF parsing - to me, ELF is ELF, so no duplication should be necessary from a very high level perspective. Jan _

Re: [Xen-devel] [PATCH RFC 08/12] xen/x86: setup PVHv2 Dom0 CPUs

>>> On 29.07.16 at 18:29, wrote: > Initialize Dom0 BSP/APs and setup the memory and IO permissions. > > Signed-off-by: Roger Pau Monné > --- > Cc: Jan Beulich > Cc: Andrew Cooper > --- > The logic used to setup the CPUID leaves is extremely simplistic (and > probably wrong for hardware differe

Re: [Xen-devel] Fwd: Openindiana, using -machine pc, accel=xen in qemu

On Mon, Sep 26, 2016 at 11:02:44AM -0400, jim burns wrote: > On Monday, 26 September 2016, 12:32:01 EDT, Anthony PERARD wrote: > > On Thu, Sep 22, 2016 at 10:37:14AM -0400, jim burns wrote: > > > Pls cc me with any replies. > > > > > > On Thursday, 22 September 2016, 12:22:02 EDT, Anthony PERARD w

Re: [Xen-devel] [PATCH RFC 09/12] xen/x86: setup PVHv2 Dom0 ACPI tables

>>> On 29.07.16 at 18:29, wrote: > This maps all the regions in the e820 marked as E820_ACPI or E820_NVS to > Dom0 1:1. It also shadows the page(s) where the native MADT is placed by > mapping a RAM page over it, copying the original data and modifying it > afterwards in order to represent the rea

Re: [Xen-devel] [PATCH RFC 01/12] PVHv2 Dom0

>>> On 29.07.16 at 18:28, wrote: > This is a very rough implementation of a PVHv2 Dom0. There are still a bunch > > of things that will not work properly (like SR-IOV, MSI, MSI-X...), but it > *should* be able to boot a Dom0 kernel and it doesn't require using PIRQs. It's been a long time sinc

Re: [Xen-devel] [Wg-test-framework] osstest Massachusetts test lab resource usage investigation

Ian Jackson writes ("Re: [Wg-test-framework] osstest Massachusetts test lab resource usage investigation"): > I have now completed the investigation into db queries. I've been looking at the bisector too. I captured a history snapshot containing two bisections chosen arbitrarily, and wrote some

[Xen-devel] [OSSTEST PATCH 1/3] Add *.tmp to .gitignore

Signed-off-by: Ian Jackson --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index bccf488..69f7743 100644 --- a/.gitignore +++ b/.gitignore @@ -1,6 +1,7 @@ *~ *.bak tmp +*.tmp bisection.ps bisection.dot bisection.html -- 2.1.4 ___

[Xen-devel] [OSSTEST PATCH 2/3] mg-bisect-activity-*: New rather ad-hoc scripts for wall clock timing analysys

Signed-off-by: Ian Jackson --- .gitignore| 2 + README.bisect-wallclock-analysis | 85 ++ mg-bisect-activity-collect-emails | 55 mg-bisect-activity-collect-tmpdir | 94 mg-bisect-activity-create-db | 17 m

[Xen-devel] [OSSTEST PATCH 3/3] mg-bisect-activity-dump-periods: Split out windows-install steps

Signed-off-by: Ian Jackson --- mg-bisect-activity-dump-periods | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mg-bisect-activity-dump-periods b/mg-bisect-activity-dump-periods index 0c04720..00576a0 100755 --- a/mg-bisect-activity-dump-periods +++ b/mg-bisect-activity-dump-pe

[Xen-devel] [PATCH 2/2] tools/configure: fix --with-system-{ovmf/seabios}

Current configure code doesn't define {SEABIOS/OVMF}_PATH when --with-system-{ovmf/seabios} is used. Fix this by making sure those defines are always set if the internal {ovmf/seabios}_path variables are also set. Signed-off-by: Roger Pau Monné Cc: Wei Liu Cc: Ian Jackson --- Please re-run auto

[Xen-devel] [PATCH 1/2] lib/gnttab: fix build of gnttab_unimp.c

Fix the definition of the xengnttab_grant_copy function so it's inline with the prototypes in xengnttab.h. This unbreaks the tools build on systems that don't have a gnttab device. Signed-off-by: Roger Pau Monné Cc: Ian Jackson Cc: Wei Liu --- tools/libs/gnttab/gnttab_unimp.c | 4 ++-- 1 file

[Xen-devel] [PATCH 0/2] tools: misc fixes

Two fixes for the tools, one is a typo fix and the other one is a fix for configure. Roger. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

  1   2   >