>>> On 29.07.16 at 18:29, <roger....@citrix.com> wrote: > This maps all the regions in the e820 marked as E820_ACPI or E820_NVS to > Dom0 1:1. It also shadows the page(s) where the native MADT is placed by > mapping a RAM page over it, copying the original data and modifying it > afterwards in order to represent the real CPU topology exposed to Dom0. > > Signed-off-by: Roger Pau Monné <roger....@citrix.com> > --- > Cc: Jan Beulich <jbeul...@suse.com> > Cc: Andrew Cooper <andrew.coop...@citrix.com> > --- > FWIW, I think that the current approach that I've used in order to craft the > MADT is not the best one, IMHO it would be better to place the MADT at the > end of the E820_ACPI region (expanding it's size one page), and modify the > XSDT/RSDT in order to point to it, that way we avoid shadowing any other > ACPI data that might be at the same page as the native MADT (and that needs > to be modified by Dom0) .
I think I agree. Problem is that you can't be sure there is any space left after the E820_ACPI region, so I think the placement aspect would need relaxation. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
