Re: [Xen-devel] [PATCH v2 23/23] libxc/xc_dom_core: Copy ACPI tables to guest space

2016-08-15 Thread Shannon Zhao
Hi Boris On 2016/8/5 5:06, Boris Ostrovsky wrote: > Load ACPI modules into guest space > > Signed-off-by: Boris Ostrovsky > --- > v2: > * New patch, loosely based on Shannon's ARM patch > > tools/libxc/xc_dom_core.c | 92 > +++ > 1 file changed, 92

Re: [Xen-devel] [PATCH 2/2] x86/EFI: use less crude way of generating the build ID

2016-08-15 Thread Jan Beulich
>>> On 15.08.16 at 01:42, wrote: >> --- a/xen/arch/x86/efi/Makefile >> +++ b/xen/arch/x86/efi/Makefile >> @@ -9,6 +9,9 @@ efi := $(if $(efi),$(shell $(CC) $(filte >> efi := $(if $(efi),$(shell $(LD) -mi386pep --subsystem=10 -o check.efi >> check.o 2>disabled && echo y)) >> efi := $(if $(efi),$(

Re: [Xen-devel] [PATCH v1 6/9] livepatch: Initial ARM64 support.

2016-08-15 Thread Jan Beulich
>>> On 15.08.16 at 01:07, wrote: > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -222,7 +222,7 @@ endmenu > config LIVEPATCH > bool "Live patching support (TECH PREVIEW)" > default n > - depends on X86 && HAS_BUILD_ID = "y" > + depends on (X86 || ARM_64) && HAS_BUIL

[Xen-devel] [PATCH 0/4] x86emul: more misc small adjustments

2016-08-15 Thread Jan Beulich
Along the lines of and on top of https://lists.xenproject.org/archives/html/xen-devel/2016-08/msg01744.html here are a few more. 1: remove dead code 2: drop RIP-relative special case for TEST 3: drop SrcInvalid 4: use DstEax also for XCHG Signed-off-by: Jan Beulich

[Xen-devel] [PATCH 1/4] x86emul: remove dead code

2016-08-15 Thread Jan Beulich
As of commit 989cdfa9b4 ("x86emul: don't special case fetching unsigned 8-bit immediates") the conditional being removed has been always false. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -1856,9 +1856,6 @@ x86_emulate(

[Xen-devel] [xen-unstable test] 100488: tolerable FAIL

2016-08-15 Thread osstest service owner
flight 100488 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/100488/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 15 guest-start/debian.repeatfail like 100470 test-amd64-amd64-xl-rtds

[Xen-devel] [PATCH 2/4] x86emul: drop RIP-relative special case for TEST

2016-08-15 Thread Jan Beulich
Moving ahead the "early operand adjustments" logic, the "test $imm,r/m" special logic in the determination of the instruction boundary is no longer necessary. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -1742,6 +1742,66

[Xen-devel] [PATCH 3/4] x86emul: drop SrcInvalid

2016-08-15 Thread Jan Beulich
As of commit a800e4f611 ("x86emul: drop pointless and add useful default cases") we no longer need the early bailing when "d == 0" (the default cases in the main switch() statements take care of that), removal of which renders internal_error() wrong and SrcInvalid useless. Drop them, as they're goi

[Xen-devel] [PATCH 4/4] x86emul: use DstEax also for XCHG

2016-08-15 Thread Jan Beulich
Just like said in commit c0bc0adf24 ("x86emul: use DstEax where possible"): While it avoids just a few instructions, we should nevertheless make use of generic code as much as possible. Here we can arrange for that by simply swapping source and destination (as they're interchangeable). Signed-off-

[Xen-devel] [ovmf test] 100489: all pass - PUSHED

2016-08-15 Thread osstest service owner
flight 100489 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/100489/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf de74668f5ea713b7e91e01318f0d15d2bf0effce baseline version: ovmf adb6ac256338329883e4d

Re: [Xen-devel] [win-pv-devel] rtc timeoffset not being set on TZ changes?

2016-08-15 Thread Paul Durrant
Hi Nathan, Are you using upstream QEMU? If you are then you’re problem is expected. The code in xen-hvm.c:handle_ioreq() completely ignores RTC updates from Xen, as can be seen at http://xenbits.xen.org/gitweb/?p=qemu-upstream-unstable.git;a=blob;f=xen-hvm.c;hb=HEAD#l927 whereas QEMU trad ha

Re: [Xen-devel] [PATCH v7 05/15] libxl: Load guest BIOS from file

2016-08-15 Thread Shannon Zhao
On 2016/7/28 18:50, Anthony PERARD wrote: > The path to the BIOS blob can be overriden by the xl's > bios_path_override option, or provided by u.hvm.bios_firmware in the > domain_build_info struct by other libxl user. > > Signed-off-by: Anthony PERARD > Acked-by: Wei Liu > > --- > Changes in

Re: [Xen-devel] [PATCH v7 05/15] libxl: Load guest BIOS from file

2016-08-15 Thread Wei Liu
On Mon, Aug 15, 2016 at 05:04:20PM +0800, Shannon Zhao wrote: [...] > > > > +const char *libxl__seabios_path(void) > > +{ > > +return SEABIOS_PATH; > > +} > > + > > +const char *libxl__ovmf_path(void) > > +{ > > +return OVMF_PATH; > > +} > > + > Hi, I got bellow errors when compiling on A

Re: [Xen-devel] [PATCH v7 05/15] libxl: Load guest BIOS from file

2016-08-15 Thread Shannon Zhao
On 2016/8/15 17:09, Wei Liu wrote: > On Mon, Aug 15, 2016 at 05:04:20PM +0800, Shannon Zhao wrote: > [...] >>> > > >>> > > +const char *libxl__seabios_path(void) >>> > > +{ >>> > > +return SEABIOS_PATH; >>> > > +} >>> > > + >>> > > +const char *libxl__ovmf_path(void) >>> > > +{ >>> > > +

Re: [Xen-devel] [PATCH v7 05/15] libxl: Load guest BIOS from file

2016-08-15 Thread Wei Liu
On Mon, Aug 15, 2016 at 05:14:43PM +0800, Shannon Zhao wrote: > > > On 2016/8/15 17:09, Wei Liu wrote: > > On Mon, Aug 15, 2016 at 05:04:20PM +0800, Shannon Zhao wrote: > > [...] > >>> > > > >>> > > +const char *libxl__seabios_path(void) > >>> > > +{ > >>> > > +return SEABIOS_PATH; > >>> >

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-08-15 Thread George Dunlap
On 12/08/16 12:50, Jan Beulich wrote: On 12.08.16 at 11:44, wrote: >> On 09/08/16 12:30, Jan Beulich wrote: >> On 09.08.16 at 12:48, wrote: Jan Beulich writes ("Re: Device model operation hypercall (DMOP, re qemu depriv)"): > Actually, having thought about this some more,

Re: [Xen-devel] [PATCH 2/2] make use of .startof.() and .sizeof.() assembler expressions

2016-08-15 Thread Andrew Cooper
On 12/08/16 15:48, Jan Beulich wrote: > Section start symbols frequently obscure the actual symbol name living > at the start of the section. Eliminate them where they can be replaced > by linker resolved .startof.* symbols. (Section end symbols may have > the same undesirable effect, but they're l

Re: [Xen-devel] [PATCH v2 1/2] x86emul: fold SrcImmByte fetching

2016-08-15 Thread Andrew Cooper
On 12/08/16 16:07, Jan Beulich wrote: > There's no need for having identical code spelled out twice. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 6/7] arm64: xen: Enable user access before a privcmd hvc call

2016-08-15 Thread Julien Grall
Hi Catalin, I have CCed Stefano who is maintaining the Xen ARM code in Linux. On 12/08/2016 17:27, Catalin Marinas wrote: Privcmd calls are issued by the userspace. The kernel needs to enable access to TTBR0_EL1 as the hypervisor would issue stage 1 translations to user memory via AT instructio

[Xen-devel] [xen-unstable-smoke test] 100490: tolerable all pass - PUSHED

2016-08-15 Thread osstest service owner
flight 100490 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/100490/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [Xen-devel] [PATCH 2/2] make use of .startof.() and .sizeof.() assembler expressions

2016-08-15 Thread Jan Beulich
>>> On 15.08.16 at 11:43, wrote: > On 12/08/16 15:48, Jan Beulich wrote: >> Section start symbols frequently obscure the actual symbol name living >> at the start of the section. Eliminate them where they can be replaced >> by linker resolved .startof.* symbols. (Section end symbols may have >> th

Re: [Xen-devel] [RFC 18/22] xen/arm: p2m: Introduce p2m_set_entry and __p2m_set_entry

2016-08-15 Thread Sergej Proskurin
Hi Julien, [...] > +static int p2m_set_entry(struct p2m_domain *p2m, > + gfn_t sgfn, > + unsigned long todo, > + mfn_t smfn, > + p2m_type_t t, > + p2m_access_t a) > +{ > +in

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-08-15 Thread Jan Beulich
>>> On 15.08.16 at 11:39, wrote: > On 12/08/16 12:50, Jan Beulich wrote: > On 12.08.16 at 11:44, wrote: >>> On 09/08/16 12:30, Jan Beulich wrote: >>> On 09.08.16 at 12:48, wrote: > Jan Beulich writes ("Re: Device model operation hypercall (DMOP, re qemu > depriv)"): >> Actua

Re: [Xen-devel] [RFC 00/22] xen/arm: Rework the P2M code to follow break-before-make sequence

2016-08-15 Thread Julien Grall
Hi Stefano, Do you have any comments on this series? Cheers, On 28/07/2016 16:51, Julien Grall wrote: Hello all, The ARM architecture mandates the use of a break-before-make sequence when changing translation entries if the page table is shared between multiple CPUs whenever a valid entry is

Re: [Xen-devel] [PATCH v2] Remove ambiguities in the COPYING file; add CONTRIBUTING file

2016-08-15 Thread Andrew Cooper
On 12/08/16 10:37, Lars Kurth wrote: > COPYING file: > The motivation of this change is to make it easier for new > contributors to conduct a license and patent review, WITHOUT > changing any licenses. > - Remove references to BSD-style licenses as we have more > common license exceptions and rep

Re: [Xen-devel] [PATCH v3 1/9] livepatch: Clear .bss when payload is reverted

2016-08-15 Thread Jan Beulich
>>> On 14.08.16 at 23:52, wrote: > @@ -374,7 +376,18 @@ static int move_payload(struct payload *payload, struct > livepatch_elf *elf) > elf->name, elf->sec[i].name, elf->sec[i].load_addr); > } > else > -memset(elf->sec[i].load_add

Re: [Xen-devel] [PATCH v3 2/9] livepatch: Deal with payloads without any .text

2016-08-15 Thread Jan Beulich
>>> On 14.08.16 at 23:52, wrote: > It is possible. Especially if the only thing they do is > NOP functions - in which case there is only .livepatch.funcs > sections. > > Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Jan Beulich ___ Xen-devel ma

Re: [Xen-devel] [PATCH v3 3/9] version/livepatch: Move xen_build_id_check to version.h

2016-08-15 Thread Jan Beulich
>>> On 14.08.16 at 23:52, wrote: > It makes more sense for it to be there. However that > means the version.h has now a dependency on > as the Elf_Note is a macro. > > The elfstructs.h has a dependency on types.h as well so > we need that. We cannot put that #include > in elfstructs.h as that f

Re: [Xen-devel] [PATCH v3 4/9] livepatch: Sync cache of build-id before using it first time.

2016-08-15 Thread Jan Beulich
>>> On 14.08.16 at 23:52, wrote: > We don't print at bootup time the build-id. The reason is > that xen_build_init and livepatch_init are both __initcall > type routines. This meant that when livepatch_init called > xen_build_id, it would return -ENODATA as build_id_len was > not setup yet (b/c xe

Re: [Xen-devel] [PATCH v3 5/9] livepatch: Move code from prepare_payload to own routine

2016-08-15 Thread Jan Beulich
>>> On 14.08.16 at 23:52, wrote: > --- a/xen/common/livepatch.c > +++ b/xen/common/livepatch.c > @@ -232,6 +232,29 @@ static const char *livepatch_symbols_lookup(unsigned > long addr, > return n; > } > > +static int lookup_symbol(struct livepatch_func *f, struct livepatch_elf *elf) The l

[Xen-devel] [OSSTEST PATCH] ts-coverity-upload: Double coverity upload timeout

2016-08-15 Thread Ian Jackson
From 3600s to 7200s. It failed in flight 100483 in the Mass colo, with a timeout, having uploaded 95% (151Mby) in 3600s. Ideally we would like to release the build host, but there is no infrastructure for doing that right now. Signed-off-by: Ian Jackson --- ts-coverity-upload | 2 +- 1 file ch

Re: [Xen-devel] [PATCH v3 4/9] livepatch: Sync cache of build-id before using it first time.

2016-08-15 Thread Andrew Cooper
On 15/08/16 11:38, Jan Beulich wrote: On 14.08.16 at 23:52, wrote: >> We don't print at bootup time the build-id. The reason is >> that xen_build_init and livepatch_init are both __initcall >> type routines. This meant that when livepatch_init called >> xen_build_id, it would return -ENODATA

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-08-15 Thread George Dunlap
On 15/08/16 11:19, Jan Beulich wrote: On 15.08.16 at 11:39, wrote: >> On 12/08/16 12:50, Jan Beulich wrote: >> On 12.08.16 at 11:44, wrote: On 09/08/16 12:30, Jan Beulich wrote: On 09.08.16 at 12:48, wrote: >> Jan Beulich writes ("Re: Device model operation hypercall (

Re: [Xen-devel] [PATCH v2 6/7] libxenstat: honour XEN_RUN_DIR

2016-08-15 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v2 6/7] libxenstat: honour XEN_RUN_DIR"): > On Wed, Jul 20, 2016 at 03:40:56PM +0100, Ian Jackson wrote: > > Wei Liu writes ("[PATCH v2 6/7] libxenstat: honour XEN_RUN_DIR"): > > > Backport candidate. > > > > Thanks. Can you let me know when it's applied to staging ? >

[Xen-devel] [RFC PATCH] tools: remove blktap2 related code and documentation

2016-08-15 Thread Wei Liu
Blktap2 is effectively dead code for a few years. Notable changes in this patch: 0. Unhook blktap2 from build system 1. Now libxl no longer supports TAP ask backend, appropriate assertions are added and some code paths now return ERROR_FAIL 2. Tap is no longer a supported backend in doc 3. Rem

Re: [Xen-devel] [PATCH v3 6/9] livepatch: Add parsing for the symbol+0x/

2016-08-15 Thread Jan Beulich
>>> On 14.08.16 at 23:52, wrote: > in case we want to patch at specific offsets inside > a function. (for example if we want to do NOP patching). > > We also assume that the 'len' is only the size of > an isns that would be for a call opcode (so 5 bytes > on x86, and 4 on ARM 32/64). Which makes

Re: [Xen-devel] [XTF PATCH v2] xtf-runner: support two modes for getting output

2016-08-15 Thread Wei Liu
On Fri, Aug 12, 2016 at 10:51:37AM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [XTF PATCH v2] xtf-runner: support two modes for getting > output"): > > On Thu, Aug 11, 2016 at 07:29:00PM +0100, Ian Jackson wrote: > > > We don't care when xenconsoled closes the logfile. We care about when > >

Re: [Xen-devel] [PATCH 3/3] Significant changes to decision making; some new roles and minor changes

2016-08-15 Thread Tim Deegan
Hi, At 00:13 +0100 on 12 Aug (1470960826), Lars Kurth wrote: > +### Conflict Resolution {#conflict} > + > +Sub-projects and teams hosted on Xenproject.org are not democracies but > +meritocracies. In situations where there is disagreement on issues related > to > +the day-to-day running of the

Re: [Xen-devel] [PATCH v3 7/9] livepatch: NOP if func->new_[addr, size] is zero.

2016-08-15 Thread Jan Beulich
>>> On 14.08.16 at 23:52, wrote: > The NOP functionality will NOP any of the code at > the 'old_addr' or at 'name' if the 'new_addr' and 'new_size' > are both zero. The purpose of this is to NOP out calls, such as: > > e9 <4-bytes-offset> Except that E9 is JMP; CALL is E8. > (5 byte insn), or

Re: [Xen-devel] [PATCH v3 8/9] symbols: Generate an xen-sym.map

2016-08-15 Thread Jan Beulich
>>> On 14.08.16 at 23:52, wrote: > --- a/xen/arch/x86/Makefile > +++ b/xen/arch/x86/Makefile > @@ -136,8 +136,12 @@ $(TARGET)-syms: prelink.o xen.lds > $(BASEDIR)/common/symbols-dummy.o > | $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort > --warn-dup \ > >$(@D)/

Re: [Xen-devel] [PATCH v3 9/9] livepach: Add .livepatch.hooks functions and test-case

2016-08-15 Thread Jan Beulich
>>> On 14.08.16 at 23:52, wrote: > v4..v11: Defered for v4.8 > v12: s/xsplice/livepatch/ > v13: Clarify the comments about spin_debug_enable (Side note: v13 here vs v3 in the subject.) > Rename one of the hooks to lower-case (Z->z) to guarantee it being > called last. Does lower case

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-08-15 Thread Jan Beulich
>>> On 15.08.16 at 12:47, wrote: > On 15/08/16 11:19, Jan Beulich wrote: >> Well, none of the options considered so far are really nice or >> readily available. I think the easiest to use for both the caller and >> the implementation of the hypercall would be the auxiliary >> hypercall for a kerne

Re: [Xen-devel] [V4 PATCH 1/2] x86/panic: Replace smp_send_stop() with kdump friendly version in panic path

2016-08-15 Thread 河合英宏 / KAWAI,HIDEHIRO
Hi Dave, Thank you for the review. > From: Dave Young [mailto:dyo...@redhat.com] > Sent: Friday, August 12, 2016 12:17 PM > > Thanks for the update. > On 08/10/16 at 05:09pm, Hidehiro Kawai wrote: > > Daniel Walker reported problems which happens when > > crash_kexec_post_notifiers kernel option

Re: [Xen-devel] [V4 PATCH 2/2] mips/panic: Replace smp_send_stop() with kdump friendly version in panic path

2016-08-15 Thread 河合英宏 / KAWAI,HIDEHIRO
Hi Corey, > From: Corey Minyard [mailto:cminy...@mvista.com] > Sent: Friday, August 12, 2016 10:56 PM > I'll try to test this, but I have one comment inline... Thank you very much! > On 08/11/2016 10:17 PM, Dave Young wrote: > > On 08/10/16 at 05:09pm, Hidehiro Kawai wrote: [snip] > >> diff --gi

Re: [Xen-devel] [OSSTEST PATCH] ts-coverity-upload: Double coverity upload timeout

2016-08-15 Thread Andrew Cooper
On 15/08/16 11:46, Ian Jackson wrote: > From 3600s to 7200s. It failed in flight 100483 in the Mass colo, > with a timeout, having uploaded 95% (151Mby) in 3600s. > > Ideally we would like to release the build host, but there is no > infrastructure for doing that right now. > > Signed-off-by: Ian

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-08-15 Thread Ian Jackson
Jan Beulich writes ("Re: Device model operation hypercall (DMOP, re qemu depriv)"): > On 15.08.16 at 12:47, wrote: > > What about including in the "fixed" part of the hypercall a virtual > > address range that all pointers must be in? That wouldn't even require > > a user/kernel flag actually; a

Re: [Xen-devel] [PATCH] xentop: Adds options for tabs-separators, and including the domain ID in the output.

2016-08-15 Thread Wei Liu
On Sat, Aug 13, 2016 at 05:51:21PM +, Stefan Wieser wrote: > This change adds two options to xentop: > > -T adds a tabulator (\t) character after each field, to allow > easier and more robust parsing. This affects batch mode only. > -I includes a colum

Re: [Xen-devel] [PATCH 0/4] Clarify License information : m4, stubdom, tools/blktap2, xen/crypto

2016-08-15 Thread Wei Liu
Cc Ian's correct email address On Fri, Aug 12, 2016 at 06:32:32PM +0100, Lars Kurth wrote: > This series contains some of the easier license clean-up cases, which can be > fixed > by adding COPYING files or README.source files. The series specially contains: > > xen/crypto and xen/include/crypto

Re: [Xen-devel] [PATCH] xentop: Adds options for tabs-separators, and including the domain ID in the output.

2016-08-15 Thread Wei Liu
On Mon, Aug 15, 2016 at 01:09:32PM +0100, Wei Liu wrote: > On Sat, Aug 13, 2016 at 05:51:21PM +, Stefan Wieser wrote: > > This change adds two options to xentop: > > > > -T adds a tabulator (\t) character after each field, to allow > > easier and more robust parsin

[Xen-devel] [xen-unstable-smoke test] 100493: tolerable all pass - PUSHED

2016-08-15 Thread osstest service owner
flight 100493 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/100493/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [Xen-devel] [PATCH v2 00/23] Make ACPI builder available to components other than hvmloader

2016-08-15 Thread Boris Ostrovsky
On 08/15/2016 02:37 AM, Shannon Zhao wrote: > > On 2016/8/5 5:06, Boris Ostrovsky wrote: >> The goal here is to build ACPI tables for PVHv2/HVMlite guests while reusing >> existing >> hvmloader's ACPI builder code. The builder is provided as a library in >> tools/libacpi. >> >> This version is bu

Re: [Xen-devel] [PATCH v2 23/23] libxc/xc_dom_core: Copy ACPI tables to guest space

2016-08-15 Thread Boris Ostrovsky
On 08/15/2016 03:48 AM, Shannon Zhao wrote: > Hi Boris > > On 2016/8/5 5:06, Boris Ostrovsky wrote: >> Load ACPI modules into guest space >> >> Signed-off-by: Boris Ostrovsky >> --- >> v2: >> * New patch, loosely based on Shannon's ARM patch >> >> tools/libxc/xc_dom_core.c | 92 >> ++

Re: [Xen-devel] [PATCH] acpi: Re-license ACPI builder files from GPLv2 to LGPLv2.1

2016-08-15 Thread Boris Ostrovsky
On 08/01/2016 09:56 AM, Boris Ostrovsky wrote: > Simon, Keir, Simon, ping? > > > In case you didn't realize --- this needs your ACK. > > Jan, now that I checked the logs more carefully, you are the only one > from Suse/Novell who touched these files so your ACK is needed as well. > > Thanks. >

Re: [Xen-devel] [Very RFC PATCH 3/3] livepatch: Initial ARM32/64 support.

2016-08-15 Thread Julien Grall
Hi Konrad, On 12/08/2016 22:50, Konrad Rzeszutek Wilk wrote: On Fri, Aug 12, 2016 at 05:00:47PM +0200, Julien Grall wrote: diff --git a/xen/include/asm-arm/current.h b/xen/include/asm-arm/current.h index 65c0cdf..f4fcfd6 100644 --- a/xen/include/asm-arm/current.h +++ b/xen/include/asm-arm/curre

Re: [Xen-devel] [PATCH] xentop: Adds options for tabs-separators, and including the domain ID in the output.

2016-08-15 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] xentop: Adds options for tabs-separators, and including the domain ID in the output."): > On Sat, Aug 13, 2016 at 05:51:21PM +, Stefan Wieser wrote: > > This change adds two options to xentop: > > > > -T adds a tabulator (\t) character after each fiel

Re: [Xen-devel] [PATCH 1/4] x86emul: remove dead code

2016-08-15 Thread Andrew Cooper
On 15/08/16 09:34, Jan Beulich wrote: > As of commit 989cdfa9b4 ("x86emul: don't special case fetching unsigned > 8-bit immediates") the conditional being removed has been always false. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-

Re: [Xen-devel] [PATCH v1 6/9] livepatch: Initial ARM64 support.

2016-08-15 Thread Konrad Rzeszutek Wilk
On Mon, Aug 15, 2016 at 02:21:48AM -0600, Jan Beulich wrote: > >>> On 15.08.16 at 01:07, wrote: > > --- a/xen/common/Kconfig > > +++ b/xen/common/Kconfig > > @@ -222,7 +222,7 @@ endmenu > > config LIVEPATCH > > bool "Live patching support (TECH PREVIEW)" > > default n > > - depends on X

Re: [Xen-devel] [PATCH 2/2] x86/EFI: use less crude way of generating the build ID

2016-08-15 Thread Konrad Rzeszutek Wilk
On Mon, Aug 15, 2016 at 01:58:47AM -0600, Jan Beulich wrote: > >>> On 15.08.16 at 01:42, wrote: > >> --- a/xen/arch/x86/efi/Makefile > >> +++ b/xen/arch/x86/efi/Makefile > >> @@ -9,6 +9,9 @@ efi := $(if $(efi),$(shell $(CC) $(filte > >> efi := $(if $(efi),$(shell $(LD) -mi386pep --subsystem=10 -o

Re: [Xen-devel] [PATCH v1 6/9] livepatch: Initial ARM64 support.

2016-08-15 Thread Jan Beulich
>>> On 15.08.16 at 16:09, wrote: > On Mon, Aug 15, 2016 at 02:21:48AM -0600, Jan Beulich wrote: >> >>> On 15.08.16 at 01:07, wrote: >> > @@ -711,9 +711,15 @@ static int prepare_payload(struct payload *payload, >> > return -EINVAL; >> > } >> > } >> > +#ifndef

Re: [Xen-devel] [PATCH 2/4] x86emul: drop RIP-relative special case for TEST

2016-08-15 Thread Andrew Cooper
On 15/08/16 09:34, Jan Beulich wrote: > @@ -1851,11 +1911,6 @@ x86_emulate( > ((op_bytes == 8) ? 4 : op_bytes); > else if ( (d & SrcMask) == SrcImmByte ) > ea.mem.off += 1; > -else if ( !ext && ((b & 0xfe) == 0xf6) && >

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-08-15 Thread Jan Beulich
>>> On 15.08.16 at 14:07, wrote: > Jan Beulich writes ("Re: Device model operation hypercall (DMOP, re qemu > depriv)"): >> On 15.08.16 at 12:47, wrote: >> > What about including in the "fixed" part of the hypercall a virtual >> > address range that all pointers must be in? That wouldn't even r

Re: [Xen-devel] [PATCH v3 1/9] livepatch: Clear .bss when payload is reverted

2016-08-15 Thread Konrad Rzeszutek Wilk
On Mon, Aug 15, 2016 at 04:27:38AM -0600, Jan Beulich wrote: > >>> On 14.08.16 at 23:52, wrote: > > @@ -374,7 +376,18 @@ static int move_payload(struct payload *payload, > > struct livepatch_elf *elf) > > elf->name, elf->sec[i].name, > > elf->sec[i].load_addr); > >

Re: [Xen-devel] [PATCH v3 4/9] livepatch: Sync cache of build-id before using it first time.

2016-08-15 Thread Konrad Rzeszutek Wilk
On Mon, Aug 15, 2016 at 11:46:13AM +0100, Andrew Cooper wrote: > On 15/08/16 11:38, Jan Beulich wrote: > On 14.08.16 at 23:52, wrote: > >> We don't print at bootup time the build-id. The reason is > >> that xen_build_init and livepatch_init are both __initcall > >> type routines. This meant t

Re: [Xen-devel] [PATCH v3 6/9] livepatch: Add parsing for the symbol+0x/

2016-08-15 Thread Konrad Rzeszutek Wilk
On Mon, Aug 15, 2016 at 04:53:48AM -0600, Jan Beulich wrote: > >>> On 14.08.16 at 23:52, wrote: > > in case we want to patch at specific offsets inside > > a function. (for example if we want to do NOP patching). > > > > We also assume that the 'len' is only the size of > > an isns that would be

[Xen-devel] [PATCH 0/2] Convert to new CPU hotplug framework

2016-08-15 Thread Boris Ostrovsky
New CPU hotplug framework was introduced recently. These patches convert Xen CPU hotplug code to this infrastructure. The patches (patch 1 specifically) will apply on top of https://lists.xenproject.org/archives/html/xen-devel/2016-08/msg00562.html (I will be out of the office starting tomorrow

[Xen-devel] [PATCH 2/2] xen/events: Convert to hotplug state machine

2016-08-15 Thread Boris Ostrovsky
From: Sebastian Andrzej Siewior Install the callbacks via the state machine. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Boris Ostrovsky --- Changes from Sebastian's original version: * Renamed hotplug state from CPUHP_XEN_EV_PREPEARE to CPUHP_XEN_EVTCHN_PREPARE * Dropped suggestio

[Xen-devel] [PATCH 1/2] xen/x86: Convert to hotplug state machine

2016-08-15 Thread Boris Ostrovsky
Switch to new CPU hotplug infrastructure. Signed-off-by: Boris Ostrovsky Suggested-by: Sebastian Andrzej Siewior --- arch/x86/xen/enlighten.c | 115 +--- include/linux/cpuhotplug.h |2 + 2 files changed, 67 insertions(+), 50 deletions(-) diff --gi

Re: [Xen-devel] [PATCH v3 7/9] livepatch: NOP if func->new_[addr, size] is zero.

2016-08-15 Thread Konrad Rzeszutek Wilk
On Mon, Aug 15, 2016 at 04:59:52AM -0600, Jan Beulich wrote: > >>> On 14.08.16 at 23:52, wrote: > > The NOP functionality will NOP any of the code at > > the 'old_addr' or at 'name' if the 'new_addr' and 'new_size' > > are both zero. The purpose of this is to NOP out calls, such as: > > > > e9 <

Re: [Xen-devel] [PATCH v3 9/9] livepach: Add .livepatch.hooks functions and test-case

2016-08-15 Thread Konrad Rzeszutek Wilk
On Mon, Aug 15, 2016 at 05:15:28AM -0600, Jan Beulich wrote: > >>> On 14.08.16 at 23:52, wrote: > > v4..v11: Defered for v4.8 > > v12: s/xsplice/livepatch/ > > v13: Clarify the comments about spin_debug_enable > > (Side note: v13 here vs v3 in the subject.) > > > Rename one of the hooks to

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-08-15 Thread David Vrabel
On 09/08/16 11:29, Jan Beulich wrote: On 08.08.16 at 15:46, wrote: >> Jan Beulich writes ("Re: Device model operation hypercall (DMOP, re qemu >> depriv)"): >>> On 05.08.16 at 18:28, wrote: That is, a bug of class 2 would allow the unprivileged qemu process in dom0 to cause damage

Re: [Xen-devel] [PATCH v1] Livepatch ARM 64 implementation

2016-08-15 Thread Julien Grall
On 15/08/2016 01:07, Konrad Rzeszutek Wilk wrote: Hey! Hi Konrad, This is the first (non RFC) posting of the enablement of Livepatch under ARM64. The patches are based on: [PATCH v3] Livepatch fixes and features for v4.8. (https://lists.xen.org/archives/html/xen-devel/2016-08/msg01825.html

[Xen-devel] [XTF PATCH v3] xtf-runner: support two modes for getting output

2016-08-15 Thread Wei Liu
We need two modes for getting output: 1. Use console directly with newer (>=4.8) Xen 2. Use log files for older Xen This patch implements both. The default behaviour is to use the console mode. Signed-off-by: Wei Liu --- v3: 1. use os module for opening log file 2. poll up to 1 second for final

Re: [Xen-devel] [PATCH 3/3] Significant changes to decision making; some new roles and minor changes

2016-08-15 Thread Lars Kurth
Hi Tim, >At 00:13 +0100 on 12 Aug (1470960826), Lars Kurth wrote: >> +### Conflict Resolution {#conflict} >> + >> +Sub-projects and teams hosted on Xenproject.org are not democracies >>but >> +meritocracies. In situations where there is disagreement on issues >>related to >> +the day-to-day runn

Re: [Xen-devel] [PATCH v1 6/9] livepatch: Initial ARM64 support.

2016-08-15 Thread Julien Grall
Hi Jan and Konrad, On 15/08/2016 16:23, Jan Beulich wrote: On 15.08.16 at 16:09, wrote: On Mon, Aug 15, 2016 at 02:21:48AM -0600, Jan Beulich wrote: On 15.08.16 at 01:07, wrote: @@ -711,9 +711,15 @@ static int prepare_payload(struct payload *payload, return -EINVAL;

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-08-15 Thread George Dunlap
On 15/08/16 12:20, Jan Beulich wrote: On 15.08.16 at 12:47, wrote: >> On 15/08/16 11:19, Jan Beulich wrote: >>> Well, none of the options considered so far are really nice or >>> readily available. I think the easiest to use for both the caller and >>> the implementation of the hypercall woul

[Xen-devel] [PATCH] xenbus: don't look up transaction IDs for ordinary writes

2016-08-15 Thread Jan Beulich
This should really only be done for XS_TRANSACTION_END messages, or else at least some of the xenstore-* tools don't work anymore. Fixes: 0beef634b8 ("xenbus: don't BUG() on user mode induced condition") Reported-by: Richard Schütz Cc: Signed-off-by: Jan Beulich Tested-by: Richard Schütz ---

Re: [Xen-devel] [Very RFC PATCH 3/3] livepatch: Initial ARM32/64 support.

2016-08-15 Thread Konrad Rzeszutek Wilk
On Mon, Aug 15, 2016 at 03:27:08PM +0200, Julien Grall wrote: > Hi Konrad, > > On 12/08/2016 22:50, Konrad Rzeszutek Wilk wrote: > > On Fri, Aug 12, 2016 at 05:00:47PM +0200, Julien Grall wrote: > > > > diff --git a/xen/include/asm-arm/current.h > > > > b/xen/include/asm-arm/current.h > > > > ind

Re: [Xen-devel] [PATCH 2/2] xen/events: Convert to hotplug state machine

2016-08-15 Thread David Vrabel
On 15/08/16 15:46, Boris Ostrovsky wrote: > From: Sebastian Andrzej Siewior > > Install the callbacks via the state machine. [...] > +static int xen_evtchn_cpu_dead(unsigned int cpu) > +{ > + __evtchn_fifo_handle_events(cpu, true); > + return 0; > +} I'm not familiar with the new state m

Re: [Xen-devel] [PATCH 2/4] x86emul: drop RIP-relative special case for TEST

2016-08-15 Thread Jan Beulich
>>> On 15.08.16 at 16:25, wrote: > On 15/08/16 09:34, Jan Beulich wrote: >> @@ -1851,11 +1911,6 @@ x86_emulate( >> ((op_bytes == 8) ? 4 : op_bytes); >> else if ( (d & SrcMask) == SrcImmByte ) >> ea.mem.off += 1; >> -els

Re: [Xen-devel] [PATCH v3 1/9] livepatch: Clear .bss when payload is reverted

2016-08-15 Thread Jan Beulich
>>> On 15.08.16 at 16:29, wrote: > On Mon, Aug 15, 2016 at 04:27:38AM -0600, Jan Beulich wrote: >> >>> On 14.08.16 at 23:52, wrote: >> > @@ -1034,6 +1047,9 @@ static int revert_payload(struct payload *data) >> > list_del_rcu(&data->applied_list); >> > unregister_virtual_region(&data->re

Re: [Xen-devel] [RFC 00/22] xen/arm: Rework the P2M code to follow break-before-make sequence

2016-08-15 Thread Edgar E. Iglesias
On Thu, Jul 28, 2016 at 03:51:23PM +0100, Julien Grall wrote: > Hello all, > > The ARM architecture mandates the use of a break-before-make sequence when > changing translation entries if the page table is shared between multiple > CPUs whenever a valid entry is replaced by another valid entry (se

Re: [Xen-devel] [PATCH v3 6/9] livepatch: Add parsing for the symbol+0x/

2016-08-15 Thread Jan Beulich
>>> On 15.08.16 at 16:35, wrote: > On Mon, Aug 15, 2016 at 04:53:48AM -0600, Jan Beulich wrote: >> >>> On 14.08.16 at 23:52, wrote: >> > in case we want to patch at specific offsets inside >> > a function. (for example if we want to do NOP patching). >> > >> > We also assume that the 'len' is on

Re: [Xen-devel] [PATCH v3 9/9] livepach: Add .livepatch.hooks functions and test-case

2016-08-15 Thread Jan Beulich
>>> On 15.08.16 at 16:46, wrote: > On Mon, Aug 15, 2016 at 05:15:28AM -0600, Jan Beulich wrote: >> >>> On 14.08.16 at 23:52, wrote: >> > @@ -72,7 +73,11 @@ struct payload { >> > struct livepatch_build_id dep; /* >> > ELFNOTE_DESC(.livepatch.depends). */ >> > void *bss;

Re: [Xen-devel] [PATCH v1 6/9] livepatch: Initial ARM64 support.

2016-08-15 Thread Konrad Rzeszutek Wilk
On Mon, Aug 15, 2016 at 04:57:26PM +0200, Julien Grall wrote: > Hi Jan and Konrad, > > On 15/08/2016 16:23, Jan Beulich wrote: > > > > > On 15.08.16 at 16:09, wrote: > > > On Mon, Aug 15, 2016 at 02:21:48AM -0600, Jan Beulich wrote: > > > > > > > On 15.08.16 at 01:07, wrote: > > > > > @@ -711,9

Re: [Xen-devel] [PATCH v1 6/9] livepatch: Initial ARM64 support.

2016-08-15 Thread Julien Grall
Hi Konrad, On 15/08/2016 01:07, Konrad Rzeszutek Wilk wrote: [...] diff --git a/xen/arch/arm/arm32/Makefile b/xen/arch/arm/arm32/Makefile index b20db64..5966de0 100644 --- a/xen/arch/arm/arm32/Makefile +++ b/xen/arch/arm/arm32/Makefile @@ -4,8 +4,8 @@ obj-$(EARLY_PRINTK) += debug.o obj-y += d

Re: [Xen-devel] [PATCH v3 6/9] livepatch: Add parsing for the symbol+0x/

2016-08-15 Thread Konrad Rzeszutek Wilk
On Mon, Aug 15, 2016 at 09:12:21AM -0600, Jan Beulich wrote: > >>> On 15.08.16 at 16:35, wrote: > > On Mon, Aug 15, 2016 at 04:53:48AM -0600, Jan Beulich wrote: > >> >>> On 14.08.16 at 23:52, wrote: > >> > in case we want to patch at specific offsets inside > >> > a function. (for example if we w

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-08-15 Thread Jan Beulich
>>> On 15.08.16 at 16:57, wrote: > On 15/08/16 12:20, Jan Beulich wrote: > On 15.08.16 at 12:47, wrote: >>> On 15/08/16 11:19, Jan Beulich wrote: Well, none of the options considered so far are really nice or readily available. I think the easiest to use for both the caller and

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-08-15 Thread Jan Beulich
>>> On 15.08.16 at 16:50, wrote: > On 09/08/16 11:29, Jan Beulich wrote: > On 08.08.16 at 15:46, wrote: >>> Jan Beulich writes ("Re: Device model operation hypercall (DMOP, re qemu >>> depriv)"): On 05.08.16 at 18:28, wrote: > That is, a bug of class 2 would allow the unprivileged

Re: [Xen-devel] [PATCH v1 6/9] livepatch: Initial ARM64 support.

2016-08-15 Thread Julien Grall
On 15/08/2016 17:17, Konrad Rzeszutek Wilk wrote: On Mon, Aug 15, 2016 at 04:57:26PM +0200, Julien Grall wrote: Hi Jan and Konrad, On 15/08/2016 16:23, Jan Beulich wrote: On 15.08.16 at 16:09, wrote: On Mon, Aug 15, 2016 at 02:21:48AM -0600, Jan Beulich wrote: On 15.08.16 at 01:07, wrote

Re: [Xen-devel] [PATCH v1 6/9] livepatch: Initial ARM64 support.

2016-08-15 Thread Andrew Cooper
On 15/08/16 16:25, Julien Grall wrote: > > > On 15/08/2016 17:17, Konrad Rzeszutek Wilk wrote: >> On Mon, Aug 15, 2016 at 04:57:26PM +0200, Julien Grall wrote: >>> Hi Jan and Konrad, >>> >>> On 15/08/2016 16:23, Jan Beulich wrote: >>> On 15.08.16 at 16:09, wrote: > On Mon, Aug 15, 2016 at

[Xen-devel] [PATCH] tools: delete gtraceview and gtracestat

2016-08-15 Thread Wei Liu
There has not been any substantial update to them since 2011. My quick check shows that they don't work. Just delete them. It would be easy to resurrect them from git log should people still need them. Signed-off-by: Wei Liu --- Cc: Ian Jackson --- .gitignore |2 - .hgignore

Re: [Xen-devel] [PATCH v1] Livepatch ARM 64 implementation

2016-08-15 Thread Konrad Rzeszutek Wilk
On Mon, Aug 15, 2016 at 04:52:58PM +0200, Julien Grall wrote: > > > On 15/08/2016 01:07, Konrad Rzeszutek Wilk wrote: > > Hey! > > Hi Konrad, > > > This is the first (non RFC) posting of the enablement of Livepatch under > > ARM64. > > > > The patches are based on: [PATCH v3] Livepatch fixes

Re: [Xen-devel] [PATCH 2/2] xen/events: Convert to hotplug state machine

2016-08-15 Thread Boris Ostrovsky
On 08/15/2016 11:06 AM, David Vrabel wrote: > On 15/08/16 15:46, Boris Ostrovsky wrote: >> From: Sebastian Andrzej Siewior >> >> Install the callbacks via the state machine. > [...] >> +static int xen_evtchn_cpu_dead(unsigned int cpu) >> +{ >> +__evtchn_fifo_handle_events(cpu, true); >> +r

Re: [Xen-devel] [PATCH v2 23/25] arm/altp2m: Extend libxl to activate altp2m on ARM.

2016-08-15 Thread Sergej Proskurin
Hi Wei, On 08/11/2016 06:00 PM, Wei Liu wrote: > Sorry for the late reply. > No worries, it's all good :) Thanks for your reply. [...] ("smbios_firmware", string), ("acpi_firmware",string),

Re: [Xen-devel] [win-pv-devel] rtc timeoffset not being set on TZ changes?

2016-08-15 Thread Nathan March
Hi Paul, Nope, I’m using qemu provided by xen-runtime in the centos packages (https://cbs.centos.org/koji/packageinfo?packageID=88). root 1462 0.2 0.3 406856 21016 ?SLsl Aug13 9:37 /usr/lib64/xen/bin/qemu-system-i386 -xen-domid 31 -chardev socket,id=libxl-cmd,path=/var/r

Re: [Xen-devel] [V4 PATCH 2/2] mips/panic: Replace smp_send_stop() with kdump friendly version in panic path

2016-08-15 Thread Corey Minyard
On 08/15/2016 06:35 AM, 河合英宏 / KAWAI,HIDEHIRO wrote: Hi Corey, From: Corey Minyard [mailto:cminy...@mvista.com] Sent: Friday, August 12, 2016 10:56 PM I'll try to test this, but I have one comment inline... Thank you very much! On 08/11/2016 10:17 PM, Dave Young wrote: On 08/10/16 at 05:09p

Re: [Xen-devel] [Qemu-devel] [RFC for 2.8 0/3] Drop support for 64 bit guests on 32 bit hosts

2016-08-15 Thread Stefano Stabellini
On Wed, 10 Aug 2016, Gerd Hoffmann wrote: > On Di, 2016-08-09 at 16:55 +0100, Alex Bennée wrote: > > Hi, > > > > I'm proposing for the 2.8 cycle we officially drop supporting 64 bit > > guests on 32 bit hosts. For most of the KVM targets it doesn't make > > any sense anyway and for TCG it makes th

Re: [Xen-devel] [PATCH 6/7] arm64: xen: Enable user access before a privcmd hvc call

2016-08-15 Thread Stefano Stabellini
On Mon, 15 Aug 2016, Julien Grall wrote: > Hi Catalin, > > I have CCed Stefano who is maintaining the Xen ARM code in Linux. > > On 12/08/2016 17:27, Catalin Marinas wrote: > > Privcmd calls are issued by the userspace. The kernel needs to enable > > access to TTBR0_EL1 as the hypervisor would is

Re: [Xen-devel] [V4 PATCH 2/2] mips/panic: Replace smp_send_stop() with kdump friendly version in panic path

2016-08-15 Thread Corey Minyard
On 08/15/2016 12:06 PM, Corey Minyard wrote: On 08/15/2016 06:35 AM, 河合英宏 / KAWAI,HIDEHIRO wrote: Hi Corey, From: Corey Minyard [mailto:cminy...@mvista.com] Sent: Friday, August 12, 2016 10:56 PM I'll try to test this, but I have one comment inline... Thank you very much! On 08/11/2016 10:1

[Xen-devel] [xen-4.7-testing test] 100491: regressions - FAIL

2016-08-15 Thread osstest service owner
flight 100491 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/100491/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 19 guest-start/debian.repeat fail REGR. vs. 99972 Regressions whi

  1   2   >