>>> On 14.08.16 at 23:52, <konrad.w...@oracle.com> wrote: > It makes more sense for it to be there. However that > means the version.h has now a dependency on <xen/elfstructs.h> > as the Elf_Note is a macro. > > The elfstructs.h has a dependency on types.h as well so > we need that. We cannot put that #include <xen/types.h> > in elfstructs.h as that file is used by tools and they > do not have such file.
I think that's acceptable, as the number of places this header gets included is pretty limited. Hence the alternative of making the declaration conditional upon Elf_Note being defined is likely the uglier one (as it would impose ordering constraints on the #include-s used by respective source files). > Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> Reviewed-by: Jan Beulich <jbeul...@suse.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
