[Xen-devel] [distros-debian-sid test] 44297: tolerable trouble: blocked/broken

2016-04-11 Thread Platform Team regression test user
flight 44297 distros-debian-sid real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/44297/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): build-armhf 3 host-install(3) broken like 44283 build-armhf-pvops

Re: [Xen-devel] [PATCH v9 2/3] VT-d: wrap a _sync version for all VT-d flush interfaces

2016-04-11 Thread Tian, Kevin
> From: Xu, Quan > Sent: Friday, April 08, 2016 10:21 AM > > On April 07, 2016 11:29pm, Jan Beulich wrote: > > >>> On 07.04.16 at 09:44, wrote: > > > On April 05, 2016 5:35pm, Jan Beulich wrote: > > >> >>> On 01.04.16 at 16:47, wrote: > > >> > +{ > > >> > +queue_invalidate_context(iommu, d

Re: [Xen-devel] Regarding Outreachy project on Improving CR Dashboard

2016-04-11 Thread Jesus M. Gonzalez-Barahona
On Fri, 2016-04-08 at 19:33 +0530, Priya wrote: > Hello, > > I tried running the same command in new version of perceval.  I found > the following missing message id errors in perceval_mbox_parse.log > file. I am working on the testing part and I will be able to finish > it in one or two days. >

Re: [Xen-devel] [PATCH v1 0/2] x86/init: extend quirk use

2016-04-11 Thread Sebastian Andrzej Siewior
On 04/09/2016 02:22 AM, Luis R. Rodriguez wrote: > What seems a bit odd is CE4100 leaves RTC enabled, can someone > confirm if indeed it really needs it, or can it also disable it > as with Xen, lguest, and Intel MID ? So what you do with "x86_platform.legacy.rtc" is to skip add_rtc_cmos(). For ce

Re: [Xen-devel] [PATCH v9 2/3] VT-d: wrap a _sync version for all VT-d flush interfaces

2016-04-11 Thread Xu, Quan
On April 11, 2016 2:53pm, Tian, Kevin wrote: > > From: Xu, Quan > > Sent: Thursday, April 07, 2016 3:45 PM > > > > On April 05, 2016 5:35pm, Jan Beulich wrote: > > > >>> On 01.04.16 at 16:47, wrote: > > > > The dev_invalidate_iotlb() scans ats_devices list to flush ATS > > > > devices, and the in

Re: [Xen-devel] [PATCH v5 13/28] xsplice, symbols: Implement symbol name resolution on address.

2016-04-11 Thread Ross Lagerwall
On 04/08/2016 06:38 PM, Jan Beulich wrote: (Did you drop all Cc-s for a reason?) No. Re-adding CCs. On 08.04.16 at 18:04, wrote: On 04/01/2016 04:11 PM, Jan Beulich wrote: +nsyms = 0; +strtab_len = 0; +for ( i = 1; i < elf->nsym; i++ ) +{ +if ( is_core_symbol(elf,

[Xen-devel] xenpm and scheduler

2016-04-11 Thread tutu sky
hi, Does xenpm 'cpufreq' or 'cpuidle' feature, has any effect on scheduling decisions? thanks a lot. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v5 15/28] xsplice: Add .xsplice.hooks functions and test-case

2016-04-11 Thread Ross Lagerwall
On 04/08/2016 06:39 PM, Jan Beulich wrote: On 08.04.16 at 17:57, wrote: On 04/07/2016 02:15 AM, Jan Beulich wrote: Martin Pohlack 04/06/16 8:42 AM >>> On 06.04.2016 04:42, Konrad Rzeszutek Wilk wrote: The normal use-case is to modify structures values where we have to be delicate about it a

[Xen-devel] [PATCH for-4.7] x86/pv: Correctly fold vIOPL back into vcpu_guest_context

2016-04-11 Thread Andrew Cooper
c/s f71ecb6 "x86: introduce a new VMASSIST for architectural behaviour of iopl" shifted the vcpu iopl field by 12, but didn't update the logic which reconstructs the guests eflags for migration. Existing guest kernels set a vIOPL of 1, to prevent them from faulting when accessing IO ports. This b

Re: [Xen-devel] [PATCH v9 2/3] VT-d: wrap a _sync version for all VT-d flush interfaces

2016-04-11 Thread Xu, Quan
On April 11, 2016 3:25pm, Tian, Kevin wrote: > > From: Xu, Quan > > Sent: Friday, April 08, 2016 10:21 AM > > > > On April 07, 2016 11:29pm, Jan Beulich wrote: > > > >>> On 07.04.16 at 09:44, wrote: > > > > On April 05, 2016 5:35pm, Jan Beulich wrote: > > > >> >>> On 01.04.16 at 16:47, wrote:

Re: [Xen-devel] [PATCH v7 06/24] arm/x86/vmap: Add vmalloc_xen, vfree_xen and vm_init_type

2016-04-11 Thread Andrew Cooper
On 10/04/16 22:14, Konrad Rzeszutek Wilk wrote: > For those users who want to use the virtual addresses that > are in the hypervisor's virtual address space - these threej new Technically, all space is "the hypervisor's". Perhaps "the hypervisor's code/data region" instead? Also, is this new thr

Re: [Xen-devel] [PATCH for-4.7] x86/pv: Correctly fold vIOPL back into vcpu_guest_context

2016-04-11 Thread Wei Liu
On Mon, Apr 11, 2016 at 10:03:55AM +0100, Andrew Cooper wrote: > c/s f71ecb6 "x86: introduce a new VMASSIST for architectural behaviour of > iopl" shifted the vcpu iopl field by 12, but didn't update the logic which > reconstructs the guests eflags for migration. > > Existing guest kernels set a v

Re: [Xen-devel] [PATCH v3 2/5] xentrace: Memory/Page Mapping support for DOMID_XEN on ARM

2016-04-11 Thread George Dunlap
On Fri, Apr 8, 2016 at 6:58 PM, Andrew Cooper wrote: > On 08/04/16 16:49, Jan Beulich wrote: > On 08.04.16 at 12:42, wrote: >>> On 04/04/16 19:48, Benjamin Sanda wrote: +else +{ +/* retrieve the page to determine read/write or read only mapping */ +

Re: [Xen-devel] [PATCH v7 10/24] xsplice: Implement support for applying/reverting/replacing patches.

2016-04-11 Thread Andrew Cooper
On 10/04/16 22:14, Konrad Rzeszutek Wilk wrote: > diff --git a/xen/common/xsplice.c b/xen/common/xsplice.c > index cbee264..9a53cf4 100644 > --- a/xen/common/xsplice.c > +++ b/xen/common/xsplice.c > @@ -3,6 +3,7 @@ > * > */ > > +#include > #include > #include > #include > @@ -11,17 +12

Re: [Xen-devel] [PATCH] docs: add misc/qemu-backends.txt

2016-04-11 Thread Wei Liu
On Sun, Apr 10, 2016 at 01:00:46PM -0700, Stefano Stabellini wrote: > On Thu, 7 Apr 2016, Juergen Gross wrote: > > Document the interface between qemu and libxl regarding backends > > supported by qemu. > > > > Signed-off-by: Juergen Gross > > --- > > docs/misc/qemu-backends.txt | 19 +++

Re: [Xen-devel] [RFC PATCH v6 00/28] libxl: Deprivilege qemu

2016-04-11 Thread Wei Liu
On Sun, Apr 10, 2016 at 12:36:26PM -0700, Stefano Stabellini wrote: > I take that this series is going to miss 4.7 at this stage, right? > Correct. Wei. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] REST MAINTAINERS feedback requested Was:Re: [PATCH v5 01/28] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane.

2016-04-11 Thread Ian Jackson
Jan Beulich writes ("Re: REST MAINTAINERS feedback requested Was:Re: [Xen-devel] [PATCH v5 01/28] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane."): > On 08.04.16 at 19:41, wrote: > > The interface for the old version was sufficiently useless that build_id > > can't be added to i

Re: [Xen-devel] pv-grub guest booting fail with recent qemu-xen

2016-04-11 Thread Wei Liu
On Sun, Apr 10, 2016 at 10:14:46PM +0200, Samuel Thibault wrote: > Hello, > > > > > > +if (prod - out_cons >= XENFB_OUT_RING_LEN) { > > > > > +return; > > > > > +} > > This test seems overzealous to me: AIUI, the producer can produce > XENFB_OUT_RING_LEN events, and thus prod - ou

Re: [Xen-devel] [PATCH] docs: add misc/qemu-backends.txt

2016-04-11 Thread Juergen Gross
On 11/04/16 12:33, Wei Liu wrote: > On Sun, Apr 10, 2016 at 01:00:46PM -0700, Stefano Stabellini wrote: >> On Thu, 7 Apr 2016, Juergen Gross wrote: >>> Document the interface between qemu and libxl regarding backends >>> supported by qemu. >>> >>> Signed-off-by: Juergen Gross >>> --- >>> docs/mis

Re: [Xen-devel] Stub domain crash on Xen v4.6.1

2016-04-11 Thread Wei Liu
On Thu, Apr 07, 2016 at 06:51:11PM +0200, Fanny Dwargee wrote: > I'm sorry but this is my first attempt to use stubdom. > > This is a test machine so feel free to propose xen recompilation adding > printk's/obscured options or settings modification. > > With regards, Sorry for the late reply. I

Re: [Xen-devel] [PATCH v2 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server

2016-04-11 Thread Yu, Zhang
On 4/8/2016 9:33 PM, Andrew Cooper wrote: On 31/03/16 11:53, Yu Zhang wrote: A new HVMOP - HVMOP_map_mem_type_to_ioreq_server, is added to let one ioreq server claim/disclaim its responsibility for the handling of guest pages with p2m type p2m_ioreq_server. Users of this HVMOP can specify whet

Re: [Xen-devel] [PATCH v2 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server

2016-04-11 Thread Yu, Zhang
On 4/9/2016 6:28 AM, Jan Beulich wrote: On 31.03.16 at 12:53, wrote: +static int mem_write(const struct hvm_io_handler *handler, + uint64_t addr, + uint32_t size, + uint64_t data) +{ +struct domain *currd = current->domain; +

Re: [Xen-devel] [PATCH v2 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server

2016-04-11 Thread Yu, Zhang
On 4/8/2016 7:01 PM, George Dunlap wrote: On 08/04/16 11:10, Yu, Zhang wrote: [snip] BTW, I noticed your reply has not be CCed to mailing list, and I also wonder if we should raise this last question in community? Oops -- that was a mistake on my part. :-) I appreciate the discretion; just

Re: [Xen-devel] [PATCH] Fix cpumap setting before passing to XEN

2016-04-11 Thread Wei Liu
On Mon, Apr 11, 2016 at 09:42:57AM +0800, Zhenzhong Duan wrote: > It's tool's duty to pass a correct cpumap to XEN. On a host with less than > 64 > CPUS, it just shows below error. > > [root@localhost /]# xm vcpu-pin 3 all all > Error: Cannot pin vcpu: 0 to cpu: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10,

Re: [Xen-devel] pv-grub guest booting fail with recent qemu-xen

2016-04-11 Thread Wei Liu
On Mon, Apr 11, 2016 at 11:54:06AM +0100, Wei Liu wrote: > On Sun, Apr 10, 2016 at 10:14:46PM +0200, Samuel Thibault wrote: > > Hello, > > > > > > > > +if (prod - out_cons >= XENFB_OUT_RING_LEN) { > > > > > > +return; > > > > > > +} > > > > This test seems overzealous to me: AIUI,

Re: [Xen-devel] [PATCH] docs: add misc/qemu-backends.txt

2016-04-11 Thread Wei Liu
On Mon, Apr 11, 2016 at 12:57:27PM +0200, Juergen Gross wrote: > On 11/04/16 12:33, Wei Liu wrote: > > On Sun, Apr 10, 2016 at 01:00:46PM -0700, Stefano Stabellini wrote: > >> On Thu, 7 Apr 2016, Juergen Gross wrote: > >>> Document the interface between qemu and libxl regarding backends > >>> suppo

Re: [Xen-devel] xenpm and scheduler

2016-04-11 Thread Meng Xu
On Mon, Apr 11, 2016 at 10:16 AM, tutu sky wrote: > > hi, > Does xenpm 'cpufreq' or 'cpuidle' feature, has any effect on scheduling > decisions? > ​Please do not cross post. No effect on RTDS scheduler. May I ask a question: why do you need to consider this? Thanks, Meng -- --- Meng

Re: [Xen-devel] [PATCH v7 17/24] build_id: Provide ld-embedded build-ids

2016-04-11 Thread Andrew Cooper
On 10/04/16 22:14, Konrad Rzeszutek Wilk wrote: > diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile > index d210bb7..e8cd757 100644 > --- a/xen/arch/x86/Makefile > +++ b/xen/arch/x86/Makefile > @@ -76,6 +76,12 @@ efi-y := $(shell if [ ! -r > $(BASEDIR)/include/xen/compile.h -o \ >

[Xen-devel] [PATCH for-4.7] libxl/save: set domain_suspend_state->domid in do_domain_soft_reset()

2016-04-11 Thread Vitaly Kuznetsov
c/s d5c693d "libxl/save: Refactor libxl__domain_suspend_state" broke soft reset as libxl__domain_suspend_device_model() now fails when domid in not set in libxl__domain_suspend_state. Signed-off-by: Vitaly Kuznetsov --- tools/libxl/libxl_create.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [Xen-devel] [PATCH v2 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server

2016-04-11 Thread Andrew Cooper
On 11/04/16 12:14, Yu, Zhang wrote: > > > On 4/8/2016 9:33 PM, Andrew Cooper wrote: >> On 31/03/16 11:53, Yu Zhang wrote: >>> A new HVMOP - HVMOP_map_mem_type_to_ioreq_server, is added to >>> let one ioreq server claim/disclaim its responsibility for the >>> handling of guest pages with p2m type p2

Re: [Xen-devel] [RFC PATCH] Data integrity extension support for xen-block

2016-04-11 Thread Bob Liu
On 04/08/2016 10:32 PM, David Vrabel wrote: > On 08/04/16 15:20, Ian Jackson wrote: >> David Vrabel writes ("Re: [RFC PATCH] Data integrity extension support for >> xen-block"): >>> You need to read the relevant SCSI specification and find out what >>> interfaces and behaviour the hardware has so

Re: [Xen-devel] [PATCH for-4.7] libxl/save: set domain_suspend_state->domid in do_domain_soft_reset()

2016-04-11 Thread Wei Liu
Sorry for breaking it! On Mon, Apr 11, 2016 at 02:20:04PM +0200, Vitaly Kuznetsov wrote: > c/s d5c693d "libxl/save: Refactor libxl__domain_suspend_state" broke soft > reset as libxl__domain_suspend_device_model() now fails when domid in not set > in libxl__domain_suspend_state. > > Signed-off-by:

Re: [Xen-devel] [PATCH v7 07/24] x86/mm: Introduce modify_xen_mappings()

2016-04-11 Thread George Dunlap
On Sun, Apr 10, 2016 at 10:14 PM, Konrad Rzeszutek Wilk wrote: > From: Andrew Cooper > > To simply change the permissions on existing Xen mappings. The existing > destroy_xen_mappings() is altered to support a change the PTE permissions. > > A new destroy_xen_mappings() is introduced, as the spe

Re: [Xen-devel] [PATCH for-4.7] libxl/save: set domain_suspend_state->domid in do_domain_soft_reset()

2016-04-11 Thread Vitaly Kuznetsov
Wei Liu writes: > Sorry for breaking it! > Np! > On Mon, Apr 11, 2016 at 02:20:04PM +0200, Vitaly Kuznetsov wrote: >> c/s d5c693d "libxl/save: Refactor libxl__domain_suspend_state" broke soft >> reset as libxl__domain_suspend_device_model() now fails when domid in not set >> in libxl__domain_su

Re: [Xen-devel] [PATCH v11 1/2] libxl: add support for vscsi

2016-04-11 Thread Olaf Hering
On Fri, Apr 08, Olaf Hering wrote: > +r = sscanf(be_path,"/local/domain/%d/backend/%15[^/]/%d", > + &be_domid, be_type, &fe_domid); Why are these values parsed as signed integers, and then placed in uint32? Was this just an oversight during review? Olaf ___

Re: [Xen-devel] [PATCH v7 07/24] x86/mm: Introduce modify_xen_mappings()

2016-04-11 Thread Andrew Cooper
On 11/04/16 13:51, George Dunlap wrote: > On Sun, Apr 10, 2016 at 10:14 PM, Konrad Rzeszutek Wilk > wrote: >> From: Andrew Cooper >> >> To simply change the permissions on existing Xen mappings. The existing >> destroy_xen_mappings() is altered to support a change the PTE permissions. >> >> A ne

Re: [Xen-devel] [PATCH v11 1/2] libxl: add support for vscsi

2016-04-11 Thread Wei Liu
On Mon, Apr 11, 2016 at 02:57:20PM +0200, Olaf Hering wrote: > On Fri, Apr 08, Olaf Hering wrote: > > > +r = sscanf(be_path,"/local/domain/%d/backend/%15[^/]/%d", > > + &be_domid, be_type, &fe_domid); > > Why are these values parsed as signed integers, and then placed in > uint3

[Xen-devel] [PATCH v2] docs: add misc/qemu-backends.txt

2016-04-11 Thread Juergen Gross
Document the interface between qemu and libxl regarding backends supported by qemu. Signed-off-by: Juergen Gross --- v2: - replace variable Xenstore path parts () with bash-like syntax ($XYZ) as requested by Konrad Wilk - add remark about de-privileged qemu as requested by Stefano

[Xen-devel] [PATCH for-4.7] libxl: pvusb: use %u to convert unsigned number

2016-04-11 Thread Wei Liu
Both be_domid and fe_domid are unsigned. Reported-by: Olaf Hering Signed-off-by: Wei Liu --- Cc: Ian Jackson Cc: Juergen Gross Cc: Chunyan Liu --- tools/libxl/libxl_pvusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_pvusb.c b/tools/libxl/libxl_pvusb

Re: [Xen-devel] [PATCH for-4.7] libxl/save: set domain_suspend_state->domid in do_domain_soft_reset()

2016-04-11 Thread Wei Liu
On Mon, Apr 11, 2016 at 02:53:21PM +0200, Vitaly Kuznetsov wrote: > Wei Liu writes: > > > Sorry for breaking it! > > > > Np! > > > On Mon, Apr 11, 2016 at 02:20:04PM +0200, Vitaly Kuznetsov wrote: > >> c/s d5c693d "libxl/save: Refactor libxl__domain_suspend_state" broke soft > >> reset as libxl

Re: [Xen-devel] [PATCH for-4.7] libxl: pvusb: use %u to convert unsigned number

2016-04-11 Thread Juergen Gross
On 11/04/16 15:08, Wei Liu wrote: > Both be_domid and fe_domid are unsigned. > > Reported-by: Olaf Hering > Signed-off-by: Wei Liu Reviewed-by: Juergen Gross > --- > Cc: Ian Jackson > Cc: Juergen Gross > Cc: Chunyan Liu > --- > tools/libxl/libxl_pvusb.c | 2 +- > 1 file changed, 1 inserti

Re: [Xen-devel] [PATCH v7 10/24] xsplice: Implement support for applying/reverting/replacing patches.

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 11:14:46AM +0100, Andrew Cooper wrote: > On 10/04/16 22:14, Konrad Rzeszutek Wilk wrote: > > diff --git a/xen/common/xsplice.c b/xen/common/xsplice.c > > index cbee264..9a53cf4 100644 > > --- a/xen/common/xsplice.c > > +++ b/xen/common/xsplice.c > > @@ -3,6 +3,7 @@ > > * >

Re: [Xen-devel] [PATCH v7 06/24] arm/x86/vmap: Add vmalloc_xen, vfree_xen and vm_init_type

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 10:39:59AM +0100, Andrew Cooper wrote: > On 10/04/16 22:14, Konrad Rzeszutek Wilk wrote: > > For those users who want to use the virtual addresses that > > are in the hypervisor's virtual address space - these threej new > > Technically, all space is "the hypervisor's". Pe

Re: [Xen-devel] [PATCH v7 17/24] build_id: Provide ld-embedded build-ids

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 01:17:38PM +0100, Andrew Cooper wrote: > On 10/04/16 22:14, Konrad Rzeszutek Wilk wrote: > > diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile > > index d210bb7..e8cd757 100644 > > --- a/xen/arch/x86/Makefile > > +++ b/xen/arch/x86/Makefile > > @@ -76,6 +76,12 @@ ef

[Xen-devel] [for-4.7 v2 4/5] xen/arm: acpi: Remove uncessary check in acpi_map_gic_cpu_interface

2016-04-11 Thread Julien Grall
This part of the code will never be executed when the entry corresponds to the boot CPU. Also print an error message rather when arch_cpu_init has failed. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini Reviewed-by: Shannon Zhao --- Changes in v2: - Add Stefano's and S

[Xen-devel] [for-4.7 v2 1/5] drivers/pl011: ACPI: The interrupt should always be high level triggered

2016-04-11 Thread Julien Grall
The SPCR does not specify if the interrupt is edge or level triggered. So the configuration needs to be hardcoded in the code. Based on the PL011 TRM (see 2.2.8 in ARM DDI 0183G), the interrupt generated will be active high. Whilst the wording may be interpreted differently, the SBSA (section 4.3.

[Xen-devel] [for-4.7 v2 3/5] xen/arm: acpi: Fix SMP support when booting with ACPI

2016-04-11 Thread Julien Grall
The variable enabled_cpus is used to know the number of CPU enabled in the MADT. Currently this variable is used to check the validity of the boot CPU. It will be considered invalid when "enabled_cpus > 1". However, this condition also means that multiple CPUs are present on the system. So second

[Xen-devel] [for-4.7 v2 0/5] xen/arm: acpi: Bunch of fixes to use ACPI with SMP and PL011

2016-04-11 Thread Julien Grall
Hello, This patch series fixes secondary CPUs bring up and the use of the PL011 UART driver when Xen boots using ACPI. For all the changes see in each patch. Regards, Cc: wei.l...@citrix.com Julien Grall (5): drivers/pl011: ACPI: The interrupt should always be high level triggered xen/

[Xen-devel] [for-4.7 v2 2/5] xen/arm: acpi: The boot CPU does not always match the first entry in the MADT

2016-04-11 Thread Julien Grall
Since the ACPI 6.0 errata document [1], the first entry in the MADT does not have to correspond to the boot CPU. Introduce a new variable to know if a MADT entry matching the boot CPU is found. Furthermore, it's not necessary to check if the MPIDR is duplicated for the boot CPU. So the rest of the

[Xen-devel] [for-4.7 v2 5/5] xen/arm: acpi: Print more error messages in acpi_map_gic_cpu_interface

2016-04-11 Thread Julien Grall
It's helpful to spot any error without having to modify the hypervisor code. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini Reviewed-by: Shannon Zhao --- Changes in v2: - Add Stefano's and Shannon's reviewed-by --- xen/arch/arm/acpi/boot.c | 7 +++ 1 file changed,

Re: [Xen-devel] [PATCH v7 17/24] build_id: Provide ld-embedded build-ids

2016-04-11 Thread Andrew Cooper
On 11/04/16 14:31, Konrad Rzeszutek Wilk wrote: > On Mon, Apr 11, 2016 at 01:17:38PM +0100, Andrew Cooper wrote: >> On 10/04/16 22:14, Konrad Rzeszutek Wilk wrote: >>> diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile >>> index d210bb7..e8cd757 100644 >>> --- a/xen/arch/x86/Makefile >>> ++

Re: [Xen-devel] [PATCH v2] docs: add misc/qemu-backends.txt

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 03:04:09PM +0200, Juergen Gross wrote: > Document the interface between qemu and libxl regarding backends > supported by qemu. > > Signed-off-by: Juergen Gross Reviewed-by: Konrad Rzeszutek Wilk > --- > v2: - replace variable Xenstore path parts () with bash-like syntax

Re: [Xen-devel] [PATCH v5 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-11 Thread Boris Ostrovsky
On 04/08/2016 07:40 PM, Luis R. Rodriguez wrote: diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h index 1ae89a2721d6..8bb8c1a4615a 100644 --- a/arch/x86/include/asm/x86_init.h +++ b/arch/x86/include/asm/x86_init.h @@ -142,6 +142,15 @@ struct x86_cpuinit_ops { struct

Re: [Xen-devel] REST MAINTAINERS feedback requested Was:Re: [PATCH v5 01/28] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane.

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 11:50:25AM +0100, Ian Jackson wrote: > Jan Beulich writes ("Re: REST MAINTAINERS feedback requested Was:Re: > [Xen-devel] [PATCH v5 01/28] HYPERCALL_version_op. New hypercall mirroring > XENVER_ but sane."): > > On 08.04.16 at 19:41, wrote: > > > The interface for the old

Re: [Xen-devel] [for-4.7 v2 0/5] xen/arm: acpi: Bunch of fixes to use ACPI with SMP and PL011

2016-04-11 Thread Wei Liu
On Mon, Apr 11, 2016 at 02:33:32PM +0100, Julien Grall wrote: > Hello, > > This patch series fixes secondary CPUs bring up and the use of the PL011 UART > driver when Xen boots using ACPI. > > For all the changes see in each patch. > > Regards, > > Cc: wei.l...@citrix.com > > Julien Grall (5):

[Xen-devel] [PATCH v7.1 07/24] x86/mm: Introduce modify_xen_mappings()

2016-04-11 Thread Andrew Cooper
To simply change the permissions on existing Xen mappings. The existing destroy_xen_mappings() is altered to support a change the PTE permissions. A new destroy_xen_mappings() is introduced, as the special case of not passing _PAGE_PRESENT to modify_xen_mappings(). As cleanup (and an ideal funct

Re: [Xen-devel] [for-4.7 v2 1/5] drivers/pl011: ACPI: The interrupt should always be high level triggered

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 02:33:33PM +0100, Julien Grall wrote: > The SPCR does not specify if the interrupt is edge or level triggered. > So the configuration needs to be hardcoded in the code. > > Based on the PL011 TRM (see 2.2.8 in ARM DDI 0183G), the interrupt generated > will be active high. W

Re: [Xen-devel] [PATCH for-4.7] x86/pv: Correctly fold vIOPL back into vcpu_guest_context

2016-04-11 Thread Boris Ostrovsky
On 04/11/2016 05:03 AM, Andrew Cooper wrote: c/s f71ecb6 "x86: introduce a new VMASSIST for architectural behaviour of iopl" shifted the vcpu iopl field by 12, but didn't update the logic which reconstructs the guests eflags for migration. Existing guest kernels set a vIOPL of 1, to prevent them

Re: [Xen-devel] [for-4.7 v2 4/5] xen/arm: acpi: Remove uncessary check in acpi_map_gic_cpu_interface

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 02:33:36PM +0100, Julien Grall wrote: > This part of the code will never be executed when the entry > corresponds to the boot CPU. > > Also print an error message rather when arch_cpu_init has failed. > > Signed-off-by: Julien Grall > Reviewed-by: Stefano Stabellini > Re

Re: [Xen-devel] [for-4.7 v2 2/5] xen/arm: acpi: The boot CPU does not always match the first entry in the MADT

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 02:33:34PM +0100, Julien Grall wrote: > Since the ACPI 6.0 errata document [1], the first entry in the MADT > does not have to correspond to the boot CPU. > > Introduce a new variable to know if a MADT entry matching the boot CPU > is found. Furthermore, it's not necessary

Re: [Xen-devel] [for-4.7 v2 3/5] xen/arm: acpi: Fix SMP support when booting with ACPI

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 02:33:35PM +0100, Julien Grall wrote: > The variable enabled_cpus is used to know the number of CPU enabled in > the MADT. > > Currently this variable is used to check the validity of the boot CPU. > It will be considered invalid when "enabled_cpus > 1". > > However, this

Re: [Xen-devel] [for-4.7 v2 5/5] xen/arm: acpi: Print more error messages in acpi_map_gic_cpu_interface

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 02:33:37PM +0100, Julien Grall wrote: > It's helpful to spot any error without having to modify the hypervisor > code. > > Signed-off-by: Julien Grall > Reviewed-by: Stefano Stabellini > Reviewed-by: Shannon Zhao Applied. ___

Re: [Xen-devel] [PATCH for-4.7] x86/pv: Correctly fold vIOPL back into vcpu_guest_context

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 10:08:58AM -0400, Boris Ostrovsky wrote: > On 04/11/2016 05:03 AM, Andrew Cooper wrote: > >c/s f71ecb6 "x86: introduce a new VMASSIST for architectural behaviour of > >iopl" shifted the vcpu iopl field by 12, but didn't update the logic which > >reconstructs the guests eflag

Re: [Xen-devel] Question about the XEN platform pci

2016-04-11 Thread Konrad Rzeszutek Wilk
On Fri, Apr 08, 2016 at 08:52:08AM +, Wu, Bob wrote: > > Sorry bother, I read the XEN source code recently, and found the XEN platform > PCI code under drivers/xen/platform-pci.c, > and I can't fully under this driver's affect, can anybody explain a little > for me? > > Is the platform PCI

Re: [Xen-devel] REST MAINTAINERS feedback requested Was:Re: [PATCH v5 01/28] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane.

2016-04-11 Thread Ian Jackson
Konrad Rzeszutek Wilk writes ("Re: REST MAINTAINERS feedback requested Was:Re: [Xen-devel] [PATCH v5 01/28] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane."): > On Mon, Apr 11, 2016 at 11:50:25AM +0100, Ian Jackson wrote: > > I don't think I would be content with simply adding a n

Re: [Xen-devel] [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-04-11 Thread Toshi Kani
On Sat, 2016-04-09 at 04:04 +0200, Luis R. Rodriguez wrote: > On Thu, Mar 17, 2016 at 03:56:47PM -0600, Toshi Kani wrote: > > > > On Wed, 2016-03-16 at 00:29 +0100, Luis R. Rodriguez wrote: > > > > > > On x86 Linux code we now have ioremap_uc() that can't use MTRR behind > > > the scenes, why wou

Re: [Xen-devel] [PATCH v3 04/11] xen: sched: close potential races when switching scheduler to CPUs

2016-04-11 Thread Konrad Rzeszutek Wilk
On Fri, Apr 08, 2016 at 03:11:23PM +0200, Dario Faggioli wrote: > On Fri, 2016-04-08 at 14:00 +0100, George Dunlap wrote: > > On 08/04/16 13:52, George Dunlap wrote: > > > On 08/04/16 02:23, Dario Faggioli wrote: > > > > Signed-off-by: Dario Faggioli > > > Thanks! > > > > > > Reviewed-by: George

Re: [Xen-devel] [PATCH v3 00/11] Fixes and improvement (including hard affinity!) for Credit2 [and 1 more messages]

2016-04-11 Thread Konrad Rzeszutek Wilk
On Fri, Apr 08, 2016 at 04:13:56PM +0100, Ian Jackson wrote: > Dario Faggioli writes ("[Xen-devel] [PATCH v3 00/11] Fixes and improvement > (including hard affinity!) for Credit2"): > > Now it's only these two patches that need being Acked: > > > > 04/11 xen: sched: close potential races when s

[Xen-devel] [PATCH OSSTEST] ts-libvirt-build: disable qemu, vmware and openvz drivers

2016-04-11 Thread Wei Liu
We don't care about those drivers but they are enabled by default. Signed-off-by: Wei Liu --- ts-libvirt-build | 1 + 1 file changed, 1 insertion(+) diff --git a/ts-libvirt-build b/ts-libvirt-build index f764b53..2a531b9 100755 --- a/ts-libvirt-build +++ b/ts-libvirt-build @@ -62,6 +62,7 @@ sub

Re: [Xen-devel] [PATCH v3 3/5] xentrace: Timestamp support for ARM platform

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 04, 2016 at 02:48:45PM -0400, Benjamin Sanda wrote: > Moved get_cycles() to time.c and modified to return the core timestamp > tick count for use by the trace buffer timestamping routines in > xentrace. get_cycles() was moved to the C file to avoid including the > register specific head

Re: [Xen-devel] [RFC PATCH] Data integrity extension support for xen-block

2016-04-11 Thread Konrad Rzeszutek Wilk
> * A filesystem in Guest that is integrity-aware can prepare I/Os with > metadata attached. > * Filesystems in Guest are capable of transferring metadata from user space. > Those metadata get lost if we don't pass them through in blkfront. > > You may have a look at: > [1] http://lwn.net/Article

Re: [Xen-devel] [PATCH v7] xSplice v1 design and implementation.

2016-04-11 Thread Konrad Rzeszutek Wilk
> *Hypervisor Maintainers* > > Jan, the hypervisor patches #2, #5-#17, #21-#23 need your Ack. s/Ack./Ack please./ > *Are there any TODOs left from v5 or v6 reviews?* > > One I hope can be deferred - that is xensyms_read which we use in > "[PATCH v7 12/24] xsplice,symbols: Implement symbol name re

[Xen-devel] xenstore tools -s option behaviour

2016-04-11 Thread James Dingwall
Hi, I was investigating the behaviour of the -s option and I'm not sure if the behaviour of xs_open() is exactly as intended. In my case I am running xenstored in the dom0. Running a strace on xenstore-read with/without the -s option shows the tool always using xenstore socket. The flag whi

[Xen-devel] [linux-3.18 test] 90846: regressions - FAIL

2016-04-11 Thread osstest service owner
flight 90846 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/90846/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 21 guest-migrate/src_host/dst_host fail REGR. vs. 86513 build-armhf

Re: [Xen-devel] [PATCH v5 11/28] xsplice: Implement support for applying/reverting/replacing patches.

2016-04-11 Thread Jan Beulich
>>> On 09.04.16 at 16:42, wrote: > On Thu, Apr 07, 2016 at 09:38:53AM -0600, Jan Beulich wrote: >> >>> On 07.04.16 at 05:05, wrote: >> >> >> > +/* All CPUs are waiting, now signal to disable IRQs. */ >> >> >> > +xsplice_work.ready = 1; >> >> >> > +smp_wmb(); >> >> >> > + >

[Xen-devel] Is: ARM maintainers advice ..Was:Re: [PATCH v5 11/28] xsplice: Implement support for applying/reverting/replacing patches.

2016-04-11 Thread Jan Beulich
>>> On 10.04.16 at 21:47, wrote: > That allows the size and offsets to be the same. I checked under ARM32 > builds: > > > struct xsplice_patch_func_internal { > const char * name; /* 0 4 */ > uint32_t _pad0;/* 4

Re: [Xen-devel] [PATCH v5 11/28] xsplice: Implement support for applying/reverting/replacing patches.

2016-04-11 Thread Jan Beulich
>>> On 10.04.16 at 04:45, wrote: > On Sat, Apr 09, 2016 at 10:36:00PM -0400, Konrad Rzeszutek Wilk wrote: >> On Thu, Apr 07, 2016 at 09:43:38AM -0600, Jan Beulich wrote: >> > >>> On 07.04.16 at 05:09, wrote: >> > >> > +uint8_t *old_ptr; >> > >> > + >> > >> > +BUILD_BUG_ON(PATCH_INSN_SIZE

Re: [Xen-devel] [PATCH v7.1 07/24] x86/mm: Introduce modify_xen_mappings()

2016-04-11 Thread George Dunlap
On 11/04/16 15:04, Andrew Cooper wrote: > To simply change the permissions on existing Xen mappings. The existing > destroy_xen_mappings() is altered to support a change the PTE permissions. > > A new destroy_xen_mappings() is introduced, as the special case of not passing > _PAGE_PRESENT to modi

Re: [Xen-devel] REST MAINTAINERS feedback requested Was:Re: [PATCH v5 01/28] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane.

2016-04-11 Thread Jan Beulich
>>> On 11.04.16 at 16:22, wrote: > Konrad Rzeszutek Wilk writes ("Re: REST MAINTAINERS feedback requested > Was:Re: [Xen-devel] [PATCH v5 01/28] HYPERCALL_version_op. New hypercall > mirroring XENVER_ but sane."): >> On Mon, Apr 11, 2016 at 11:50:25AM +0100, Ian Jackson wrote: >> > I don't think

Re: [Xen-devel] [PATCH v7] xSplice v1 design and implementation.

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 10:32:20AM -0400, Konrad Rzeszutek Wilk wrote: > > *Hypervisor Maintainers* > > > > Jan, the hypervisor patches #2, #5-#17, #21-#23 need your Ack. > > s/Ack./Ack please./ > > *Are there any TODOs left from v5 or v6 reviews?* > > > > One I hope can be deferred - that is xens

Re: [Xen-devel] Is: ARM maintainers advice ..Was:Re: [PATCH v5 11/28] xsplice: Implement support for applying/reverting/replacing patches.

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 09:44:55AM -0600, Jan Beulich wrote: > >>> On 10.04.16 at 21:47, wrote: > > That allows the size and offsets to be the same. I checked under ARM32 > > builds: > > > > > > struct xsplice_patch_func_internal { > > const char * name; /*

Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-11 Thread Jan Beulich
>>> On 09.04.16 at 02:37, wrote: > On Fri, Apr 08, 2016 at 04:50:10PM -0600, Jan Beulich wrote: >> >>> On 09.04.16 at 00:45, wrote: >> > On Fri, Apr 08, 2016 at 03:18:09PM -0600, Jan Beulich wrote: >> >> >>> On 08.04.16 at 23:10, wrote: >> >> >> > +int arch_xsplice_perform_rela(struct xsplice_el

Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 09:53:06AM -0600, Jan Beulich wrote: > >>> On 09.04.16 at 02:37, wrote: > > On Fri, Apr 08, 2016 at 04:50:10PM -0600, Jan Beulich wrote: > >> >>> On 09.04.16 at 00:45, wrote: > >> > On Fri, Apr 08, 2016 at 03:18:09PM -0600, Jan Beulich wrote: > >> >> >>> On 08.04.16 at 23:

Re: [Xen-devel] Is: ARM maintainers advice ..Was:Re: [PATCH v5 11/28] xsplice: Implement support for applying/reverting/replacing patches.

2016-04-11 Thread Jan Beulich
>>> On 11.04.16 at 17:50, wrote: > On Mon, Apr 11, 2016 at 09:44:55AM -0600, Jan Beulich wrote: >> >>> On 10.04.16 at 21:47, wrote: >> > That allows the size and offsets to be the same. I checked under ARM32 >> > builds: >> > >> > >> > struct xsplice_patch_func_internal { >> > const char *

Re: [Xen-devel] [PATCH v9 3/3] VT-d: Fix vt-d Device-TLB flush timeout issue

2016-04-11 Thread Jan Beulich
>>> On 10.04.16 at 16:28, wrote: > On April 05, 2016 5:48pm, Jan Beulich wrote: >> >>> On 01.04.16 at 16:47, wrote: >> > +{ >> > +ASSERT(pdev->domain); >> > +list_del(&pdev->domain_list); >> > +pdev->domain = NULL; >> > +pci_hide_existing_d

Re: [Xen-devel] [PATCH v2 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server

2016-04-11 Thread Jan Beulich
>>> On 11.04.16 at 14:20, wrote: > On 11/04/16 12:14, Yu, Zhang wrote: >> >> >> On 4/8/2016 9:33 PM, Andrew Cooper wrote: >>> On 31/03/16 11:53, Yu Zhang wrote: A new HVMOP - HVMOP_map_mem_type_to_ioreq_server, is added to let one ioreq server claim/disclaim its responsibility for the >>

[Xen-devel] [PATCH] xen: sched: fix spinlock issue in schedule_cpu_switch().

2016-04-11 Thread Dario Faggioli
Commit 94734ab7c3f5 ("xen: sched: close potential races when switching scheduler to CPUs") buggily replaced a call to pcpu_schedule_lock_irq() with just pcpu_schedule_lock(), causing the relevant irq_safe vs. non-irq_safe ASSERT() in check_lock() to trigger. Fix that. Signed-off-by: Dario Faggiol

Re: [Xen-devel] [PATCH v2 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server

2016-04-11 Thread Jan Beulich
>>> On 11.04.16 at 13:14, wrote: > On 4/9/2016 6:28 AM, Jan Beulich wrote: > On 31.03.16 at 12:53, wrote: >>> @@ -168,13 +226,72 @@ static int hvmemul_do_io( >>> break; >>> case X86EMUL_UNHANDLEABLE: >>> { >>> -struct hvm_ioreq_server *s = >>> -hvm_se

Re: [Xen-devel] REST MAINTAINERS feedback requested Was:Re: [PATCH v5 01/28] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane.

2016-04-11 Thread Ian Jackson
Jan Beulich writes ("Re: REST MAINTAINERS feedback requested Was:Re: [Xen-devel] [PATCH v5 01/28] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane."): > On 11.04.16 at 16:22, wrote: > > But to an extent some of this conversation seems to be on matters of > > taste. > > Agreed. >

Re: [Xen-devel] [PATCH 09/46] tools/hotplug: use XEN_LOCK_DIR instead of hardcoded path

2016-04-11 Thread George Dunlap
On Mon, Sep 22, 2014 at 1:59 PM, Olaf Hering wrote: > Use XEN_LOCK_DIR because it is a compiletime setting. > > Signed-off-by: Olaf Hering > Acked-by: Ian Campbell > --- > tools/hotplug/Linux/xendomains | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/tools/hotplug

Re: [Xen-devel] [PATCH 2/2] IOMMU/MMU: Adjust low level functions for VT-d Device-TLB flush error.

2016-04-11 Thread Jan Beulich
>>> On 11.04.16 at 05:27, wrote: > On April 11, 2016 11:10am, wrote: >> On March 29, 2016 3:37pm, Jan Beulich wrote: >> > >>> On 25.03.16 at 10:27, wrote: >> > > On March 18, 2016 6:20pm, wrote: >> > >> >>> On 17.03.16 at 07:54, wrote: >> > >> > --- a/xen/drivers/passthrough/iommu.c >> > >> >

Re: [Xen-devel] [PATCH v6 09/24] xsplice: Implement payload loading

2016-04-11 Thread Konrad Rzeszutek Wilk
On Mon, Apr 11, 2016 at 12:03:49PM -0400, Konrad Rzeszutek Wilk wrote: > On Mon, Apr 11, 2016 at 09:53:06AM -0600, Jan Beulich wrote: > > >>> On 09.04.16 at 02:37, wrote: > > > On Fri, Apr 08, 2016 at 04:50:10PM -0600, Jan Beulich wrote: > > >> >>> On 09.04.16 at 00:45, wrote: > > >> > On Fri, Ap

[Xen-devel] [OSSTEST PATCH 1/6] mg-list-all-branches: avoid mistakenly generating `.' in the output

2016-04-11 Thread Ian Jackson
The regex in mg-list-all-branches assumes that the BRANCHES= will either be a singleton entry separated from the following command by a hard tab or a single quoted list of space separated entries, however the xen-unstable-coverity line is singleton separated from the command by a single space. We

[Xen-devel] [OSSTEST PATCH 5/6] make-distros-flight: Always set guest_suite and defguestsuite

2016-04-11 Thread Ian Jackson
Abolish the shell variables $gsuite and $debian_suite (which were referred to only in make-distros-flight) and set and use the variables guest_suite and defguestsuite. These variables are used by the machinery in mfi-common to populate the runvars. No functional change (as seen in standalone-gene

[Xen-devel] [xen-unstable-smoke test] 90970: tolerable FAIL - PUSHED

2016-04-11 Thread osstest service owner
flight 90970 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/90970/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): build-amd64-libvirt 5 libvirt-buildfail like 90828 Tests which did not suc

[Xen-devel] [OSSTEST PATCH 6/6] mfi-common: Do not set di_version runvar to empty string

2016-04-11 Thread Ian Jackson
Specifically, do not set all_host_di_version to the shell variable $di_version unless the latter has a nonempty value. A set but empty value for all_host_di_version does not default to the version for the specific suite. So this produces install failures. This bug seems to have been introduced f

[Xen-devel] [OSSTEST PATCH 3/6] make-distros-flight: Key "snapshot" special case off $branch

2016-04-11 Thread Ian Jackson
This eliminates two places where $debian_suite is expected to contain "snapshot" rather than a suite. We want to change debian_suite to always contain a real suite, so that we can fold its uses in to other suite variables. No functional change for existing branches. Signed-off-by: Ian Jackson -

[Xen-devel] [PATCH] xen: Filter out MSR write events

2016-04-11 Thread Razvan Cojocaru
This patch only allows introspection-related MSR write events to be sent out, improving performance. Should additional events be required, they can then simply be added to the list of vmx_introspection_force_enabled_msrs[]. Signed-off-by: Razvan Cojocaru --- xen/arch/x86/hvm/hvm.c | 14 +

[Xen-devel] [OSSTEST PATCH 0/6] make-distros-flight runvar fixes

2016-04-11 Thread Ian Jackson
I hope this series will fix the Cambridge osstest instance's failure to build anything in its distros-debian-* tests. I'm going to push it shortly. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

[Xen-devel] [OSSTEST PATCH 4/6] make-flight: Make debian_suite always contain a suite

2016-04-11 Thread Ian Jackson
The setting of the suite to "sid" in the snapshot case now occurs in the case at the top of the script. This means that gsuite always contains the actual suite name, and the special cases which set it to sid can be removed. No functional change. Signed-off-by: Ian Jackson --- make-distros-flig

  1   2   >