Re: [Xen-devel] abstract model of IOMMU unmaping/mapping failures

2016-04-06 Thread Xu, Quan
On April 01, 2016 7:57pm, wrote: > >>> On 31.03.16 at 11:06, wrote: > > 4. __gnttab_unmap_common():rollback (no change) > > > > (Existing code) > >>>... > > if ( !kind ) > > err = iommu_unmap_page(ld, op->frame); > > else if ( !(kind & MAPKIND_WRITE) ) > >

[Xen-devel] [ovmf test] 88801: regressions - FAIL

2016-04-06 Thread osstest service owner
flight 88801 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/88801/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 65543 test-amd64-amd64-xl-qemuu-ov

Re: [Xen-devel] Bug in x86 instruction emulator?

2016-04-06 Thread Andrew Cooper
On 06/04/16 00:57, Mihai Donțu wrote: > On Wed, 06 Apr 2016 01:38:32 +0200 wo...@openmailbox.org wrote: >> I'm running Xen 4.6.1 with Alpine Linux 3.3.3 in dom0. In a HVM domU >> with vga="qxl", Xorg will segfault instantly if tried started. Multiple >> Linux distros have been tested and Xorg seg

Re: [Xen-devel] [PATCH RFC v1 09/14] Makefile: delete STUBDOMPATH target

2016-04-06 Thread Xu, Quan
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Wei > Liu > Sent: Friday, April 01, 2016 6:03 PM > To: Xu, Quan > Cc: Xen-devel; Daniel De Graaf; Wei Liu > Subject: Re: [Xen-devel] [PATCH RFC v1 09/14] Makefile: delete STUBDOMPATH > target > >

Re: [Xen-devel] [PATCH RFC v1 09/14] Makefile: delete STUBDOMPATH target

2016-04-06 Thread Wei Liu
On Wed, Apr 06, 2016 at 09:09:22AM +, Xu, Quan wrote: > > > > -Original Message- > > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Wei > > Liu > > Sent: Friday, April 01, 2016 6:03 PM > > To: Xu, Quan > > Cc: Xen-devel; Daniel De Graaf; Wei Liu > > Subject: Re:

Re: [Xen-devel] HVMLite / PVHv2 - using x86 EFI boot entry

2016-04-06 Thread David Vrabel
On 06/04/16 03:40, Luis R. Rodriguez wrote: > > * You don't need full EFI emulation I think needing any EFI emulation inside Xen (which is where it would need to be for dom0) is not suitable because of the increase in hypervisor ABI. I also still do not understand your objection to the curre

Re: [Xen-devel] [PATCH 0/3] COLO: only build on Linux

2016-04-06 Thread Wei Liu
On Wed, Apr 06, 2016 at 09:24:26AM +0800, Wen Congyang wrote: > On 04/06/2016 04:05 AM, Wei Liu wrote: > > COLO depends on netlink which is only available on Linux. This series > > cleans up > > COLO code and make it only build on Linux. This should fix FreeBSD build. > > > > Congyang and Changlo

Re: [Xen-devel] [PATCH 0/3] COLO: only build on Linux

2016-04-06 Thread Wen Congyang
On 04/06/2016 06:17 PM, Wei Liu wrote: > On Wed, Apr 06, 2016 at 09:24:26AM +0800, Wen Congyang wrote: >> On 04/06/2016 04:05 AM, Wei Liu wrote: >>> COLO depends on netlink which is only available on Linux. This series >>> cleans up >>> COLO code and make it only build on Linux. This should fix Fr

Re: [Xen-devel] [PATCH 0/3] COLO: only build on Linux

2016-04-06 Thread Wei Liu
On Wed, Apr 06, 2016 at 06:20:52PM +0800, Wen Congyang wrote: > On 04/06/2016 06:17 PM, Wei Liu wrote: > > On Wed, Apr 06, 2016 at 09:24:26AM +0800, Wen Congyang wrote: > >> On 04/06/2016 04:05 AM, Wei Liu wrote: > >>> COLO depends on netlink which is only available on Linux. This series > >>> cle

Re: [Xen-devel] [PATCH 3/3] libxl: colo: only build COLO on Linux

2016-04-06 Thread Wei Liu
On Tue, Apr 05, 2016 at 09:06:02PM +0100, Wei Liu wrote: > Linux's netlink is required when initialising COLO, so make sure only to > compile COLO on Linux. > > Provide necessary stub functions in case COLO is disabled. This should > fix libxl build on FreeBSD. > > Signed-off-by: Wei Liu > --- >

[Xen-devel] [PATCH] libxl: replace the usage of uuid_t with a char array

2016-04-06 Thread Roger Pau Monne
The internals of the uuid_t struct don't match a big endian octet stream on *BSD systems, which means that it cannot be directly casted to a uint8_t[16]. In order to solve that change the type to be an unsigned char[16], which doesn't imply any other change on Linux. On *BSDs change the helpers so

Re: [Xen-devel] [PATCH 09/10] libxl: Fix libxl_set_memory_target return value

2016-04-06 Thread Paulina Szubarczyk
On 4 April 2016 at 12:40, George Dunlap wrote: > > On 01/04/16 15:55, Roger Pau Monné wrote: > > On Fri, 1 Apr 2016, Paulina Szubarczyk wrote: > >> libxl_set_memory_target seems to have the following return values: > >> > >> * 1 on failure, if the failure happens because of a xenstore error *or* >

[Xen-devel] Shortlist of people for Committer and Security Team member election

2016-04-06 Thread Lars Kurth
Dear Community members, you may remember the following e-mail called "Call for nominations for new Hypervisor subproject maintainers and committers" (also see http://lists.xenproject.org/archives/html/xen-devel/2016-02/msg03459.html) We had quite a few nominations for maintainers, committers a

Re: [Xen-devel] ARMv8: New board bring up hangs in kernel start?

2016-04-06 Thread Julien Grall
On 04/04/2016 16:44, Dirk Behme wrote: Hi Julien, Hello Dirk, On 01.04.2016 18:34, Julien Grall wrote: On 31/03/16 18:41, Dirk Behme wrote: Also have you tried a newer version of Xen? I've switched to the recent master a6f2cdb63 x86/hvm/viridian: keep APIC assist page mapped now. N

[Xen-devel] [PATCH v2 3/4] build: rename CONFIG_REMUS_NETBUF to CONFIG_LIBNL

2016-04-06 Thread Wei Liu
COLO and Remus net buffer support both depend on the availability of libnl. Use a generic name. No functional changes. Signed-off-by: Wei Liu --- I committed configure changes as well. Feel free to rerun autogen.sh. --- config/Tools.mk.in | 2 +- tools/configure | 10 +++

[Xen-devel] [PATCH v2 0/4] COLO: only build when libnl is available

2016-04-06 Thread Wei Liu
COLO depends on netlink which is only available on Linux. This series cleans up COLO code and make it only build when libnl is available. This should fix FreeBSD build. Tested building on Linux with and without libnl-3-dev and libnl3-route-dev. git rebase -i HEAD~4 --exec \ './configure --disa

[Xen-devel] [PATCH v2 2/4] libxl: colo: move netlink related stuff to libxl_colo_proxy.c

2016-04-06 Thread Wei Liu
They are only used there, no need to expose them to other parts of libxl. This is necessary to make libxl build on FreeBSD again because FreeBSD doesn't have netlink. Signed-off-by: Wei Liu --- tools/libxl/libxl_colo.h | 12 tools/libxl/libxl_colo_proxy.c | 13 +

[Xen-devel] [PATCH v2 1/4] libxl: colo: rearrange things in header files

2016-04-06 Thread Wei Liu
We need to separate COLO code from common code as clean as possible. With this patch, all COLO structures are now in libxl_colo.h. It does the following: 1. Move two typedefs for libxl__domain_create_state{,cb} back to libxl_internal.h. 2. Move libxl__colo_save_state to libxl_colo.h. 3. Include

[Xen-devel] [PATCH v2 4/4] libxl: colo: make it depend on availability of libnl

2016-04-06 Thread Wei Liu
Netlink is required when initialising COLO, so make sure only to compile COLO when netlink is available. Change the inclusion of linux/netlink.h to netlink/netlink.h. Provide necessary stub functions in case COLO is disabled. This should fix build on FreeBSD because there is no netlink there. It w

Re: [Xen-devel] [PATCH] libxl: replace the usage of uuid_t with a char array

2016-04-06 Thread Roger Pau Monné
On Wed, 6 Apr 2016, Roger Pau Monne wrote: > diff --git a/tools/libxl/libxl_uuid.h b/tools/libxl/libxl_uuid.h > index c5041c7..c4ffc23 100644 > --- a/tools/libxl/libxl_uuid.h > +++ b/tools/libxl/libxl_uuid.h > @@ -20,19 +20,19 @@ > #define LIBXL__UUID_BYTES(uuid) uuid[0], uuid[1], uuid[2], uuid[3]

Re: [Xen-devel] [PATCH v2 0/4] COLO: only build when libnl is available

2016-04-06 Thread Wei Liu
On Wed, Apr 06, 2016 at 12:01:12PM +0100, Wei Liu wrote: > COLO depends on netlink which is only available on Linux. This series cleans > up > COLO code and make it only build when libnl is available. This should fix > FreeBSD build. > > Tested building on Linux with and without libnl-3-dev and

Re: [Xen-devel] HVMLite / PVHv2 - using x86 EFI boot entry

2016-04-06 Thread George Dunlap
On Wed, Apr 6, 2016 at 3:40 AM, Luis R. Rodriguez wrote: > A huge summary of the discussion over EFI boot option for HVMLite is now on a > wiki [2], below I'll just provide the outline of the discussion. Consider > this a > request for more public review, feel free to take any of the items below

Re: [Xen-devel] Stub domain crash on Xen v4.6.1

2016-04-06 Thread Wei Liu
On Tue, Apr 05, 2016 at 05:17:00PM +0200, Fanny Dwargee wrote: > Hi, > > after adding the 'device_model_stubdomain_override = 1' to an otherwise > fine configuration the domain crashes on start. > > Xen is v4.6.1 compiled from source on Debian Jessie 64bits this way: > >- ./configure --enabl

[Xen-devel] [PATCH v2] libxl: replace the usage of uuid_t with a char array

2016-04-06 Thread Roger Pau Monne
The internals of the uuid_t struct don't match a big endian octet stream on *BSD systems, which means that it cannot be directly casted to a uint8_t[16]. In order to solve that change the type to be an unsigned char[16], which doesn't imply any other change on Linux. On *BSDs change the helpers so

Re: [Xen-devel] HVMLite / PVHv2 - using x86 EFI boot entry

2016-04-06 Thread Daniel Kiper
On Wed, Apr 06, 2016 at 04:40:27AM +0200, Luis R. Rodriguez wrote: > Boris sent out the first HVMLite series of patches to add a new Xen guest type > February 1, 2016 [0]. We've been talking off list with a few folks now over > the prospect of instead of adding yet-another-boot-entry we instead fix

Re: [Xen-devel] [PATCH v2] libxl: replace the usage of uuid_t with a char array

2016-04-06 Thread Wei Liu
On Wed, Apr 06, 2016 at 01:11:05PM +0200, Roger Pau Monne wrote: > The internals of the uuid_t struct don't match a big endian octet stream on > *BSD systems, which means that it cannot be directly casted to a > uint8_t[16]. > > In order to solve that change the type to be an unsigned char[16], wh

Re: [Xen-devel] [PATCH] libxl: libxl_domain_create_restore has an extra argument

2016-04-06 Thread Wei Liu
On Tue, Apr 05, 2016 at 04:12:57PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH] libxl: libxl_domain_create_restore has an extra > argument"): > > CC Jim as well > > > > On Tue, Apr 05, 2016 at 03:20:12PM +0100, Wei Liu wrote: > > > In the latest libxenlight code, libxl_domain_create_r

Re: [Xen-devel] [PATCH v2 3/4] build: rename CONFIG_REMUS_NETBUF to CONFIG_LIBNL

2016-04-06 Thread Andrew Cooper
On 06/04/16 12:01, Wei Liu wrote: > diff --git a/tools/configure.ac b/tools/configure.ac > index 5b5dda4..79ff25e 100644 > --- a/tools/configure.ac > +++ b/tools/configure.ac > @@ -410,12 +410,12 @@ PKG_CHECK_MODULES(LIBNL3, [libnl-3.0 >= 3.2.8 > libnl-route-3.0 >= 3.2.8], > [libnl3_lib="y"],

Re: [Xen-devel] [PATCH v2 3/4] build: rename CONFIG_REMUS_NETBUF to CONFIG_LIBNL

2016-04-06 Thread Wei Liu
On Wed, Apr 06, 2016 at 12:29:34PM +0100, Andrew Cooper wrote: > On 06/04/16 12:01, Wei Liu wrote: > > diff --git a/tools/configure.ac b/tools/configure.ac > > index 5b5dda4..79ff25e 100644 > > --- a/tools/configure.ac > > +++ b/tools/configure.ac > > @@ -410,12 +410,12 @@ PKG_CHECK_MODULES(LIBNL3,

Re: [Xen-devel] [PATCH v10 00/17] Add ACPI support for Xen Dom0 on ARM64

2016-04-06 Thread Julien Grall
Hi Shannon, On 01/04/2016 16:48, Shannon Zhao wrote: This patch set adds ACPI support for Xen Dom0 on ARM64. The relevant Xen ACPI on ARM64 design document could be found from [1]. This patch set adds a new FDT node "uefi" under /hypervisor to pass UEFI information. Introduce a bus notifier of

[Xen-devel] [PATCH 1/1] libxl: Fix uninitialized pointer when passing an empty cdrom

2016-04-06 Thread George Dunlap
Commit 3fec17d4bb56567d139d7806392f4d8702d3f6a7 introduced a bug where an empty cdrom would cause target_path to be uninitialized. Initialize target_path to NULL instead. The other option here would have been to set target_path to NULL only on the LIBXL_DISK_FORMAT_EMPTY path. That would potenti

Re: [Xen-devel] [PATCH v10 02/17] xen/grant-table: Move xlated_setup_gnttab_pages to common place

2016-04-06 Thread Julien Grall
Hi Shannon, On 01/04/2016 16:49, Shannon Zhao wrote: Move xlated_setup_gnttab_pages to common place, so it can be reused by ARM to setup grant table. Rename it to xen_xlate_map_ballooned_pages. Signed-off-by: Shannon Zhao Reviewed-by: Stefano Stabellini Reviewed-by: Julien Grall Regards,

Re: [Xen-devel] [PATCH v10 03/17] Xen: xlate: Use page_to_xen_pfn instead of page_to_pfn

2016-04-06 Thread Julien Grall
Hi Shannon, On 01/04/2016 16:49, Shannon Zhao wrote: Make xen_xlate_map_ballooned_pages work with 64K pages. In that case Kernel pages are 64K in size but Xen pages remain 4K in size. Xen pfns refer to 4K pages. Signed-off-by: Shannon Zhao Reviewed-by: Stefano Stabellini Reviewed-by: Julien

Re: [Xen-devel] [PATCH v10 04/17] arm/xen: Use xen_xlate_map_ballooned_pages to setup grant table

2016-04-06 Thread Julien Grall
Hi Shannon, On 01/04/2016 16:49, Shannon Zhao wrote: Use xen_xlate_map_ballooned_pages to setup grant table. Then it doesn't rely on DT or ACPI to pass the start address and size of grant table. Signed-off-by: Shannon Zhao Acked-by: Stefano Stabellini Reviewed-by: Julien Grall Regards, -

Re: [Xen-devel] [PATCH v10 05/17] xen: memory : Add new XENMAPSPACE type XENMAPSPACE_dev_mmio

2016-04-06 Thread Julien Grall
Hi Shannon, On 01/04/2016 16:49, Shannon Zhao wrote: Add a new type of Xen map space for Dom0 to map device's MMIO region. Signed-off-by: Shannon Zhao Reviewed-by: Julien Grall Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists

[Xen-devel] [PATCH v2 00/10] xl: improve coding style and return more failure on failure for more xl commands

2016-04-06 Thread Paulina Szubarczyk
This is my bite-sized outreachy project [1][2]. The patch aims to improve coding_style and return failure for more xl commands: - pci-* -- tmem-* After rebase to staging it seems that the patch {09} cleaning libxl_set_memory_target() to return useful error codes from [0] is not applied I resen

[Xen-devel] [PATCH v2 05/10] xl_cmdimpl: improve return codes for memset commands

2016-04-06 Thread Paulina Szubarczyk
- Use EXIT_{SUCCESS,FAILURE} for main_mem*() function - Use 0/1 as return values of set_memory_{max,target} Signed-off-by: Paulina Szubarczyk --- Changed since v1 * Changed exit() calls to 'return 1;' --- tools/libxl/xl_cmdimpl.c | 24 1 file changed, 16 insertions(+)

[Xen-devel] [PATCH v2 03/10] libxl: fix return value of libxl__device_pci_destroy_all

2016-04-06 Thread Paulina Szubarczyk
Return rc value instead of always 0. Signed-off-by: Paulina Szubarczyk Acked-by: Roger Pau Monné --- tools/libxl/libxl_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c index 8549378..b667dba 100644 --- a/tools/libxl/libx

[Xen-devel] [PATCH v2 08/10] libxl: improve main_tmem_* return codes

2016-04-06 Thread Paulina Szubarczyk
Functions libxl_tmem_freeze(), libxl_tmem_thaw(), libxl_tmem_set() and libxl_tmem_shared_auth() located in libxl.c file return ERROR_FAIL/ERROR_INVAL or internal error codes from libxc library improve main_tmem_* return codes by returning EXIT_{SUCCESS/FAILURE} accordingly to return codes of those

[Xen-devel] [PATCH v2 01/10] libxl_pci: improve return codes for more xl commands

2016-04-06 Thread Paulina Szubarczyk
Return error code instead of always 0. Remove assigned-only ret variable. Signed-off-by: Paulina Szubarczyk --- Changed since v1: * The function libxl__device_from_pcidev() initialize the values of libxl__device and does not return any error code. Make it return void instead 0. --- tools

[Xen-devel] [PATCH v2 07/10] xl_cmdimpl - Add return codes for pci-detach, pci-attach, pci-asssignable-add, and pci-assignable-remove.

2016-04-06 Thread Paulina Szubarczyk
From: George Dunlap Returning error codes makes it easier for shell scripts to tell if a command has failed or succeeded. NB this violates the CODING_STYLE preference for not initializing the return-value variable at declaration; but in these cases, having a "goto out" that jumped over nothing b

[Xen-devel] [PATCH v2 04/10] xl: improve return code for freemem function

2016-04-06 Thread Paulina Szubarczyk
- Return 0 or 1 for freemem function - Correct the condition of checking return values of freemem Signed-off-by: Paulina Szubarczyk --- tools/libxl/xl_cmdimpl.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c

[Xen-devel] [PATCH v2 02/10] libxl-pci: removing the extra 'out_closedir' cleaning path

2016-04-06 Thread Paulina Szubarczyk
Signed-off-by: Paulina Szubarczyk --- Changed since v1: * Modify the libxl_device_pci_assignable_list() function to use only one 'out' cleaning path. --- tools/libxl/libxl_pci.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/tools/libxl/libxl_

[Xen-devel] [PATCH v2 09/10] libxl: Fix libxl_set_memory_target return value

2016-04-06 Thread Paulina Szubarczyk
From: George Dunlap libxl_set_memory_target seems to have the following return values: * 1 on failure, if the failure happens because of a xenstore error *or* * invalid target * -1 if the setmaxmem hypercall * -errno if the set_pod_target hypercall target fails * 0 on success Make it consist

[Xen-devel] [PATCH v2 06/10] xl_cmdimpl: improve return codes for cd-insert commands

2016-04-06 Thread Paulina Szubarczyk
- Use EXIT_{SUCCESS,FAILURE} for main_cd*() function - Use 0/1 as return values of cd_insert function Signed-off-by: Paulina Szubarczyk Acked-by: Roger Pau Monné --- tools/libxl/xl_cmdimpl.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/tools/libxl/xl_c

[Xen-devel] [PATCH v2 10/10] libxl: libxl_tmem functions improving coding style

2016-04-06 Thread Paulina Szubarczyk
In accordance with CODING_SYTLE: - Use 'r' for return values to functions whose return values are a different error space (like xc_tmem_control, xc_tmem_auth) Signed-off-by: Paulina Szubarczyk --- Changed since v1: * Added the error cleanup path 'out'. * Replaced return with set-and-goto stat

Re: [Xen-devel] Regarding Outreachy project on Improving CR Dashboard

2016-04-06 Thread Priya
Hello, Thanks for your suggestions. I have made the appropriate changes as you had mentioned. It took a little time to change from python3 to python3.4 as perceval supports python3.4. I have updated the changes in my github. You can see my git repo [1] [1]:https://github.com/priya299/Dashboard

Re: [Xen-devel] [PATCH 1/1] libxl: Fix uninitialized pointer when passing an empty cdrom

2016-04-06 Thread Andrew Cooper
On 06/04/16 12:34, George Dunlap wrote: > Commit 3fec17d4bb56567d139d7806392f4d8702d3f6a7 introduced a bug where > an empty cdrom would cause target_path to be uninitialized. Initialize > target_path to NULL instead. > > The other option here would have been to set target_path to NULL only > on th

Re: [Xen-devel] [PATCH v10 06/17] Xen: ARM: Add support for mapping platform device mmio

2016-04-06 Thread Julien Grall
Hi Shannon, Sorry to come late in the review process. On 01/04/2016 16:49, Shannon Zhao wrote: Add a bus_notifier for platform bus device in order to map the device mmio regions when DOM0 booting with ACPI. Signed-off-by: Shannon Zhao Acked-by: Stefano Stabellini --- drivers/xen/Makefile

[Xen-devel] [xen-unstable test] 88799: regressions - FAIL

2016-04-06 Thread osstest service owner
flight 88799 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/88799/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 5 libvirt-build fail REGR. vs. 86491 build-i386-libvirt

Re: [Xen-devel] [PATCH v10 07/17] Xen: ARM: Add support for mapping AMBA device mmio

2016-04-06 Thread Julien Grall
Hi Shannon, On 01/04/2016 16:49, Shannon Zhao wrote: Add a bus_notifier for AMBA bus device in order to map the device mmio regions when DOM0 booting with ACPI. Signed-off-by: Shannon Zhao Reviewed-by: Stefano Stabellini Reviewed-by: Julien Grall Regards, -- Julien Grall ___

Re: [Xen-devel] [PATCH v10 09/17] xen/hvm/params: Add a new delivery type for event-channel in HVM_PARAM_CALLBACK_IRQ

2016-04-06 Thread Julien Grall
Hi Shannon, On 01/04/2016 16:49, Shannon Zhao wrote: This new delivery type which is for ARM shares the same value with HVM_PARAM_CALLBACK_TYPE_VECTOR which is for x86. val[15:8] is flag: val[7:0] is a PPI. To the flag, bit 8 stands the interrupt mode is edge(1) or level(0) and bit 9 stands the

Re: [Xen-devel] [PATCH v10 10/17] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI

2016-04-06 Thread Julien Grall
Hi Shannon, On 01/04/2016 16:49, Shannon Zhao wrote: The kernel will get the event-channel IRQ through HVM_PARAM_CALLBACK_IRQ. Signed-off-by: Shannon Zhao Reviewed-by: Stefano Stabellini Reviewed-by: Julien Grall Regards, -- Julien Grall ___ X

Re: [Xen-devel] [PATCH v10 11/17] ARM: XEN: Move xen_early_init() before efi_init()

2016-04-06 Thread Julien Grall
Hi Shannon, On 01/04/2016 16:49, Shannon Zhao wrote: Move xen_early_init() before efi_init(), then when calling efi_init() could initialize Xen specific UEFI. Check if it runs on Xen hypervisor through the flat dts. Cc: Russell King Signed-off-by: Shannon Zhao Reviewed-by: Stefano Stabellini

Re: [Xen-devel] [PATCH 2/2] xen/balloon: Fix crash when ballooning on x86 32 bit PAE

2016-04-06 Thread David Vrabel
These two have been applied to for-linus-4.6, thanks. I tagged them for stable since they are regression in 4.4. On 17/03/16 16:52, Ross Lagerwall wrote: > When ballooning on an x86 32 bit PAE system with close to 64 GiB of memory, > the > address returned by allocate_resource may be above 64 Gi

Re: [Xen-devel] Stub domain crash on Xen v4.6.1

2016-04-06 Thread Fanny Dwargee
Hi Wei, first: thanks for your effort. :) Find attached the 'xl create' output and the /var/log/xen/console/hypervisor.log files after creating the same domain without the 'device_model_stubdomain_override' configuration option. 'xl list' command output... Name ID Mem VCPUs

Re: [Xen-devel] [PATCH v2 09/10] libxl: Fix libxl_set_memory_target return value

2016-04-06 Thread George Dunlap
On Wed, Apr 6, 2016 at 12:46 PM, Paulina Szubarczyk wrote: > From: George Dunlap > > libxl_set_memory_target seems to have the following return values: > > * 1 on failure, if the failure happens because of a xenstore error *or* > * invalid target > > * -1 if the setmaxmem hypercall > > * -errno i

[Xen-devel] [PATCH OSSTEST RFC 1/2] Testsupport: rename guest_editconfig_nocd to _postinstall

2016-04-06 Thread Wei Liu
It does more than just replacing the disc in cdrom. It also modifies guest reboot action. No functional change. Signed-off-by: Wei Liu --- Osstest/TestSupport.pm | 4 ++-- ts-debian-hvm-install | 2 +- ts-redhat-install | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git

[Xen-devel] [PATCH OSSTEST RFC 0/2] Test booting hvm guest with empty cdrom drive

2016-04-06 Thread Wei Liu
This can only go in after the bug is fixed and possibly backported to all the trees we care about. It won't pass osstest self pushgate otherwise. Wei. Wei Liu (2): Testsupport: rename guest_editconfig_nocd to _postinstall Make guest cdrom empty after installation completes Osstest/TestSuppo

[Xen-devel] [PATCH OSSTEST RFC 2/2] Make guest cdrom empty after installation completes

2016-04-06 Thread Wei Liu
Previously an iso image that contains nothing was inserted to cdrom after guest installation had finished. With this patch we make cdrom really empty. This helps catch bug that prevents booting hvm guest with empty cdrom drive. Remove empty iso image generate in ts-{debian-hvm,redhat}-install as

Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions

2016-04-06 Thread David Vrabel
On 04/04/16 13:32, Anna-Maria Gleixner wrote: > Xen guests do not offline/online CPUs during suspend/resume and > therefore FROZEN notifier transitions are not required. Add this > explanation as a comment in the code to get not confused why > CPU_TASKS_FROZEN masked transitions are not considered.

Re: [Xen-devel] [PATCH v2] x86/hvm: separate ioreq server code from generic hvm code

2016-04-06 Thread Wei Liu
On Mon, Apr 04, 2016 at 12:07:25PM -0400, Boris Ostrovsky wrote: > On 04/01/2016 03:54 AM, Paul Durrant wrote: > >The code in hvm/hvm.c related to handling I/O emulation using the ioreq > >server framework is large and mostly self-contained. > > > >This patch separates the ioreq server code into a

Re: [Xen-devel] [PATCH v2 09/10] libxl: Fix libxl_set_memory_target return value

2016-04-06 Thread Paulina Szubarczyk
On Wed, 2016-04-06 at 13:54 +0100, George Dunlap wrote: > On Wed, Apr 6, 2016 at 12:46 PM, Paulina Szubarczyk > wrote: > > From: George Dunlap > > > > libxl_set_memory_target seems to have the following return values: > > > > * 1 on failure, if the failure happens because of a xenstore error *or*

Re: [Xen-devel] [PATCH v2] x86/hvm: separate ioreq server code from generic hvm code

2016-04-06 Thread Wei Liu
On Wed, Apr 06, 2016 at 02:20:04PM +0100, Wei Liu wrote: > On Mon, Apr 04, 2016 at 12:07:25PM -0400, Boris Ostrovsky wrote: > > On 04/01/2016 03:54 AM, Paul Durrant wrote: > > >The code in hvm/hvm.c related to handling I/O emulation using the ioreq > > >server framework is large and mostly self-con

Re: [Xen-devel] [PATCH 2/3] libxl: colo: move netlink related stuff to libxl_colo_proxy.c

2016-04-06 Thread Ian Jackson
Wei Liu writes ("[PATCH 2/3] libxl: colo: move netlink related stuff to libxl_colo_proxy.c"): > They are only used there, no need to expose them to other parts of > libxl. > > This is necessary to make libxl build on FreeBSD again because FreeBSD > doesn't have netlink. > > Signed-off-by: Wei Li

Re: [Xen-devel] [PATCH 0/5] COLO fixes

2016-04-06 Thread Wei Liu
On Tue, Apr 05, 2016 at 01:23:47PM +0800, Changlong Xie wrote: > On 04/05/2016 01:34 AM, Wei Liu wrote: > >Wei Liu (5): > > libxc: colo: don't leak pfns and iov in send_checkpoint_dirty_pfn_list > > libxl: colo: simplify colo_proxy_async_wait_for_checkpoint > > libxl: colo: add missing break

Re: [Xen-devel] [PATCH 1/3] libxl: colo: rearrange things in header files

2016-04-06 Thread Ian Jackson
Wei Liu writes ("[PATCH 1/3] libxl: colo: rearrange things in header files"): > We need to separate COLO code from common code as clean as possible. > With this patch, all COLO structures are now in libxl_colo.h. > > It does the following: > 1. Move two typedefs for libxl__domain_create_state{,cb}

Re: [Xen-devel] [PATCH] libxl: fix POLLHUP handling

2016-04-06 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] libxl: fix POLLHUP handling"): > On Thu, Mar 31, 2016 at 02:50:07PM +0200, Roger Pau Monne wrote: > > The current code in bootloader_copyfail will error out on expected POLLHUPs > > because of a missing "else" in the if clause. > > > > The behaviour that triggers this

Re: [Xen-devel] [PATCH v2 3/4] build: rename CONFIG_REMUS_NETBUF to CONFIG_LIBNL

2016-04-06 Thread Ian Jackson
Wei Liu writes ("[PATCH v2 3/4] build: rename CONFIG_REMUS_NETBUF to CONFIG_LIBNL"): > COLO and Remus net buffer support both depend on the availability of > libnl. Use a generic name. > > No functional changes. > > Signed-off-by: Wei Liu > --- > I committed configure changes as well. Feel free

Re: [Xen-devel] [PATCH v2 4/4] libxl: colo: make it depend on availability of libnl

2016-04-06 Thread Ian Jackson
Wei Liu writes ("[PATCH v2 4/4] libxl: colo: make it depend on availability of libnl"): > Netlink is required when initialising COLO, so make sure only to compile > COLO when netlink is available. Change the inclusion of linux/netlink.h > to netlink/netlink.h. > > Provide necessary stub functions

Re: [Xen-devel] [PATCH v2 09/10] libxl: Fix libxl_set_memory_target return value

2016-04-06 Thread George Dunlap
On Wed, Apr 6, 2016 at 2:21 PM, Paulina Szubarczyk wrote: > On Wed, 2016-04-06 at 13:54 +0100, George Dunlap wrote: >> On Wed, Apr 6, 2016 at 12:46 PM, Paulina Szubarczyk >> wrote: >> > From: George Dunlap >> > >> > libxl_set_memory_target seems to have the following return values: >> > >> > * 1

Re: [Xen-devel] [PATCH 1/1] libxl: Fix uninitialized pointer when passing an empty cdrom

2016-04-06 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH 1/1] libxl: Fix uninitialized pointer when passing an empty cdrom"): > On 06/04/16 12:34, George Dunlap wrote: > > Commit 3fec17d4bb56567d139d7806392f4d8702d3f6a7 introduced a bug where > > an empty cdrom would cause target_path to be uninitialized. Initialize >

Re: [Xen-devel] [PATCH] libxl/CODING_STYLE: Clarify the singular statement in a conditional statement explanation.

2016-04-06 Thread Ian Jackson
Konrad Rzeszutek Wilk writes ("[PATCH] libxl/CODING_STYLE: Clarify the singular statement in a conditional statement explanation."): > It takes a bit of thinking to parse the original statement. It looks > like it is missing an ',' - right after the 'braced' to make it > obvious that: Acked-by: I

Re: [Xen-devel] [PATCH v2 0/4] COLO: only build when libnl is available

2016-04-06 Thread Wei Liu
On Wed, Apr 06, 2016 at 12:04:23PM +0100, Wei Liu wrote: > On Wed, Apr 06, 2016 at 12:01:12PM +0100, Wei Liu wrote: > > COLO depends on netlink which is only available on Linux. This series > > cleans up > > COLO code and make it only build when libnl is available. This should fix > > FreeBSD bui

Re: [Xen-devel] [PATCH 0/5] COLO fixes

2016-04-06 Thread Ian Jackson
Wei Liu writes ("[PATCH 0/5] COLO fixes"): > Wei Liu (5): > libxc: colo: don't leak pfns and iov in send_checkpoint_dirty_pfn_list > libxl: colo: simplify colo_proxy_async_wait_for_checkpoint > libxl: colo: add missing break in qemu_disk_scsi_drive_string > libxl: colo: fix indentation of a

Re: [Xen-devel] [PATCH v6 0/6] libxl: add support for qemu base pvusb backend

2016-04-06 Thread Ian Jackson
Juergen Gross writes ("[PATCH v6 0/6] libxl: add support for qemu base pvusb backend"): > This patch series is meant to be applied on top of Chunyan's series > to support pvusb in libxl. Thanks. Thanks also for the git branch. Queued all 6. Ian. ___

Re: [Xen-devel] [PREEMPT-RT] [PATCH] xen: Add comment for missing FROZEN notifier transitions

2016-04-06 Thread Anna-Maria Gleixner
On Wed, 6 Apr 2016, David Vrabel wrote: > On 04/04/16 13:32, Anna-Maria Gleixner wrote: > > Xen guests do not offline/online CPUs during suspend/resume and > > therefore FROZEN notifier transitions are not required. Add this > > explanation as a comment in the code to get not confused why > > CPU_

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-04-06 Thread Ian Jackson
Doug Goldstein writes ("[PATCH 2/2] tools: detect appropriate debug optimization level"): > The build should not use -O0 as that results in miscompilations. There > have been a few instances on the ML where users were told to switch > from -O0 to -O1 or -O2 or to set debug=n and their issue went a

[Xen-devel] [PATCH v5 1/6] xen: sync xen header

2016-04-06 Thread Juergen Gross
Import the actual version of include/xen/interface/sched.h from Xen. Signed-off-by: Juergen Gross Acked-by: David Vrabel --- include/xen/interface/sched.h | 100 ++ 1 file changed, 82 insertions(+), 18 deletions(-) diff --git a/include/xen/interface/sche

[Xen-devel] [PATCH v5 2/6] virt, sched: add generic vcpu pinning support

2016-04-06 Thread Juergen Gross
Add generic virtualization support for pinning the current vcpu to a specified physical cpu. As this operation isn't performance critical (a very limited set of operations like BIOS calls and SMIs is expected to need this) just add a hypervisor specific indirection. Signed-off-by: Juergen Gross -

[Xen-devel] [PATCH v5 0/6] Support calling functions on dedicated physical cpu

2016-04-06 Thread Juergen Gross
Some hardware (e.g. Dell Studio laptops) require special functions to be called on physical cpu 0 in order to avoid occasional hangs. When running as dom0 under Xen this could be achieved only via special boot parameters (vcpu pinning) limiting the hypervisor in it's scheduling decisions. This pat

[Xen-devel] [PATCH v5 5/6] dcdbas: make use of smp_call_on_cpu()

2016-04-06 Thread Juergen Gross
Use smp_call_on_cpu() to raise SMI on cpu 0. Make call secure by adding get_online_cpus() to avoid e.g. suspend resume cycles in between. Signed-off-by: Juergen Gross --- V4: add call to get_online_cpus() --- drivers/firmware/dcdbas.c | 51 --- 1 file

[Xen-devel] [PATCH v5 3/6] smp: add function to execute a function synchronously on a cpu

2016-04-06 Thread Juergen Gross
On some hardware models (e.g. Dell Studio 1555 laptop) some hardware related functions (e.g. SMIs) are to be executed on physical cpu 0 only. Instead of open coding such a functionality multiple times in the kernel add a service function for this purpose. This will enable the possibility to take sp

[Xen-devel] [PATCH v5 6/6] hwmon: use smp_call_on_cpu() for dell-smm i8k

2016-04-06 Thread Juergen Gross
Use the smp_call_on_cpu() function to call system management mode on cpu 0. Make call secure by adding get_online_cpus() to avoid e.g. suspend resume cycles in between. Signed-off-by: Juergen Gross --- V4: add call to get_online_cpus() --- drivers/hwmon/dell-smm-hwmon.c | 35

[Xen-devel] [PATCH v5 4/6] xen: add xen_pin_vcpu() to support calling functions on a dedicated pcpu

2016-04-06 Thread Juergen Gross
Some hardware models (e.g. Dell Studio 1555 laptops) require calls to the firmware to be issued on cpu 0 only. As Dom0 might have to use these calls, add xen_pin_vcpu() to achieve this functionality. In case either the domain doesn't have the privilege to make the related hypercall or the hypervis

Re: [Xen-devel] [PATCH v2 0/4] COLO: only build when libnl is available

2016-04-06 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v2 0/4] COLO: only build when libnl is available"): > I've made change per Andrew's request and folded in all the acks. Thank you. > Please pull from > > git://xenbits.xen.org/people/liuw/xen.git wip.colo-freebsd-fix-v3 Queued. Thanks, Ian. _

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-04-06 Thread George Dunlap
On Wed, Apr 6, 2016 at 3:07 PM, Ian Jackson wrote: > Doug Goldstein writes ("[PATCH 2/2] tools: detect appropriate debug > optimization level"): >> The build should not use -O0 as that results in miscompilations. There >> have been a few instances on the ML where users were told to switch >> from

Re: [Xen-devel] [PATCH v5 17/28] xsplice: Add support for exception tables.

2016-04-06 Thread Konrad Rzeszutek Wilk
On Fri, Apr 01, 2016 at 10:06:54AM -0600, Jan Beulich wrote: > >>> On 24.03.16 at 21:00, wrote: > > --- a/xen/common/xsplice.c > > +++ b/xen/common/xsplice.c > > @@ -573,6 +573,25 @@ static int prepare_payload(struct payload *payload, > > region->frame[i].n_bugs = sec->sec->sh_size / size

Re: [Xen-devel] [PATCH v3 3/8] libxl: refactor the FreeBSD hotplug script code

2016-04-06 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v3 3/8] libxl: refactor the FreeBSD hotplug script code"): > This factors out the nic hotplug specific code from the common code path in > order to make it easier to add support for disk hotplug scripts. It > shouldn't include any functional change. Acked-by: Ian J

Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-06 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS"): > On Thu, Mar 31, 2016 at 11:59:45PM -0500, Chong Li wrote: > > Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set > > functions to support per-VCPU settings. > > > > Signed-off-by: Chong Li

Re: [Xen-devel] [PATCH] blktap2: Invalid logic detecting unaligned buffers in vhd_write_block

2016-04-06 Thread Ian Jackson
Ross Philipson writes ("[Xen-devel] [PATCH] blktap2: Invalid logic detecting unaligned buffers in vhd_write_block"): > It seems the logic is meant to detect sector unaligned buffers for block > writes. The NOTing of the logic instead masks off any unaligned bits and > also would cause the function

Re: [Xen-devel] [PATCH v3 1/8] blkif: document how FreeBSD uses the physical-device backend node

2016-04-06 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v3 1/8] blkif: document how FreeBSD uses the physical-device backend node"): > FreeBSD blkback uses the physical-device-path xenstore node in order to > fetch the path to the underlying backing storage (either a block device or > raw image). This node is set by the

Re: [Xen-devel] [PATCH v3 0/8] libxl: add support for FreeBSD block hotplug scripts

2016-04-06 Thread Ian Jackson
Roger Pau Monne writes ("[Xen-devel] [PATCH v3 0/8] libxl: add support for FreeBSD block hotplug scripts"): > This series enables using hotplug scripts with the FreeBSD blkback > implementation. Since FreeBSD blkback can use both block devices and regular > RAW files as disks, the physical-device-

Re: [Xen-devel] [PATCH OSSTEST RFC 1/2] Testsupport: rename guest_editconfig_nocd to _postinstall

2016-04-06 Thread Ian Jackson
Wei Liu writes ("[PATCH OSSTEST RFC 1/2] Testsupport: rename guest_editconfig_nocd to _postinstall"): > It does more than just replacing the disc in cdrom. It also modifies > guest reboot action. I think this probably ought to be called `midinstall' or something. The installation isn't complete u

Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-06 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS"): > Wei Liu writes ("Re: [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU > parameter for RTDS"): > > These two functions LGTM, so I shall ack this patch again: > > > > Acked-by: Wei Liu > > I hav

Re: [Xen-devel] HVMLite / PVHv2 - using x86 EFI boot entry

2016-04-06 Thread Matt Fleming
On Wed, 06 Apr, at 12:07:36PM, George Dunlap wrote: > > So rather than make a new entry point which does just the minimal > amount of work to run on a software interface (Xen), you want to take > an interface designed for hardware (EFI) and put in hacks so that it > knows that sometimes some EFI s

Re: [Xen-devel] [PATCH OSSTEST RFC 2/2] Make guest cdrom empty after installation completes

2016-04-06 Thread Ian Jackson
Wei Liu writes ("[PATCH OSSTEST RFC 2/2] Make guest cdrom empty after installation completes"): > Previously an iso image that contains nothing was inserted to cdrom > after guest installation had finished. > > With this patch we make cdrom really empty. This helps catch bug that > prevents boot

Re: [Xen-devel] [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-04-06 Thread Wei Liu
On Wed, Apr 06, 2016 at 03:55:25PM +0100, Ian Jackson wrote: > Ian Jackson writes ("Re: [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU > parameter for RTDS"): > > Wei Liu writes ("Re: [PATCH v9 for Xen 4.7 3/4] libxl: enable per-VCPU > > parameter for RTDS"): > > > These two functions LGTM, so

Re: [Xen-devel] [PATCH OSSTEST RFC 2/2] Make guest cdrom empty after installation completes

2016-04-06 Thread Wei Liu
On Wed, Apr 06, 2016 at 04:02:21PM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH OSSTEST RFC 2/2] Make guest cdrom empty after > installation completes"): > > Previously an iso image that contains nothing was inserted to cdrom > > after guest installation had finished. > > > > With this pat

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-04-06 Thread Ian Jackson
George Dunlap writes ("Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level"): > On Wed, Apr 6, 2016 at 3:07 PM, Ian Jackson wrote: > > Doug, would you like to, for now, propose a patch that uses -Og if it > > is available, but otherwise falls back to -O0 ? NB that if >

  1   2   3   >