On Wed, Apr 06, 2016 at 01:11:05PM +0200, Roger Pau Monne wrote: > The internals of the uuid_t struct don't match a big endian octet stream on > *BSD systems, which means that it cannot be directly casted to a > uint8_t[16]. > > In order to solve that change the type to be an unsigned char[16], which > doesn't imply any other change on Linux. On *BSDs change the helpers so that > the uuid is always stored as a big endian byte stream. > > NB: tested on FreeBSD and Linux only. > > Signed-off-by: Roger Pau Monné <roger....@citrix.com> > Discussed-with: Ian Jackson <ian.jack...@eu.citrix.com> > Discussed-with: Wei Liu <wei.l...@citrix.com> > --- > Cc: Ian Jackson <ian.jack...@eu.citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> > --- > NB2: AFAICT the NetBSD version of libxl_uuid_from_string *could* be switched > to the FreeBSD one (because NetBSD also has uuid_from_string), but I don't > have a NetBSD box in order to test it.
Haven't looked at the code but maybe it's a good idea to CC netbsd port-xen list? Wei. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
