Re: [Xen-devel] Restoring FPU exception state

>>> On 18.02.16 at 07:30, wrote: > Interesting. Let me also have a check internally whether there is other > architectural alternative. BTW, not quite related. Could I think finally > Xen may allow user to specify OS type as a general per-domain control, > and then Xen can do free optimizations un

Re: [Xen-devel] Xen PV IOMMU interface draft D

> From: Malcolm Crossley [mailto:malcolm.cross...@citrix.com] > Sent: Wednesday, February 10, 2016 6:09 PM As Konrad commented, it's better to add this doc as 1st patch in your series then it's easier to review it with other patches together. Also it's always good to include such design doc in the

Re: [Xen-devel] [PATCH v5 7/7] VT-d: Fix vt-d Device-TLB flush timeout issue.

>>> On 18.02.16 at 08:36, wrote: >> On February 17, 2016 10:41pm, wrote: >> >>> On 05.02.16 at 11:18, wrote: >> > --- a/xen/drivers/passthrough/vtd/qinval.c >> > +++ b/xen/drivers/passthrough/vtd/qinval.c >> > +if ( pci_hide_device(bus, devfn) ) >> >> But now I'm _really_ puzzled:

Re: [Xen-devel] Restoring FPU exception state

> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 18 February 2016 08:16 > To: Kevin Tian > Cc: Andrew Cooper; David Vrabel; Paul Durrant; Feng Wu; xen-devel > Subject: RE: Restoring FPU exception state > > >>> On 18.02.16 at 07:30, wrote: > > Interesting. Let me

Re: [Xen-devel] [PATCH v2] x86: avoid flush IPI when possible

>>> On 17.02.16 at 15:48, wrote: > On 16/02/16 10:14, Jan Beulich wrote: >> --- a/xen/arch/x86/smp.c >> +++ b/xen/arch/x86/smp.c >> @@ -205,26 +205,30 @@ static unsigned int flush_flags; >> >> void invalidate_interrupt(struct cpu_user_regs *regs) >> { >> +unsigned int flags = flush_flags;

Re: [Xen-devel] [PATCH v5 7/7] VT-d: Fix vt-d Device-TLB flush timeout issue.

> On February 18, 2016 4:36pm, wrote: > >>> On 18.02.16 at 08:36, wrote: > >> On February 17, 2016 10:41pm, wrote: > >> >>> On 05.02.16 at 11:18, wrote: > >> > --- a/xen/drivers/passthrough/vtd/qinval.c > >> > +++ b/xen/drivers/passthrough/vtd/qinval.c > >> > +if ( pci_hide_device(

Re: [Xen-devel] Restoring FPU exception state

>>> On 18.02.16 at 09:41, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 18 February 2016 08:16 >> To: Kevin Tian >> Cc: Andrew Cooper; David Vrabel; Paul Durrant; Feng Wu; xen-devel >> Subject: RE: Restoring FPU exception state >> >> >>> On 18.02.1

Re: [Xen-devel] [PATCH v5 4/7] VT-d: Refactor iommu_ops .iotlb_flush() and iotlb_flush_all()

> On February 17, 2016 10:20pm, wrote: > >>> On 05.02.16 at 11:18, wrote: > > (Side note: The VT-d: prefix of the subject seems inadequate here.) > > > to pass down a flag indicating whether the lock is being held. > > "the lock" being which one? "pcidevs_lock". > > --- a/xen/arch/arm/p2m.c

Re: [Xen-devel] Restoring FPU exception state

> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 18 February 2016 08:50 > To: Paul Durrant; Kevin Tian > Cc: Andrew Cooper; David Vrabel; Feng Wu; xen-devel > Subject: RE: Restoring FPU exception state > > >>> On 18.02.16 at 09:41, wrote: > >> -Original Mes

Re: [Xen-devel] [PATCH v5 7/7] VT-d: Fix vt-d Device-TLB flush timeout issue.

>>> On 18.02.16 at 09:47, wrote: >> On February 18, 2016 4:36pm, wrote: >> >>> On 18.02.16 at 08:36, wrote: >> >> On February 17, 2016 10:41pm, wrote: >> >> >>> On 05.02.16 at 11:18, wrote: >> >> > --- a/xen/drivers/passthrough/vtd/qinval.c >> >> > +++ b/xen/drivers/passthrough/vtd/qinval.c

Re: [Xen-devel] Restoring FPU exception state

>>> On 18.02.16 at 09:54, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 18 February 2016 08:50 >> To: Paul Durrant; Kevin Tian >> Cc: Andrew Cooper; David Vrabel; Feng Wu; xen-devel >> Subject: RE: Restoring FPU exception state >> >> >>> On 18.02.1

Re: [Xen-devel] Restoring FPU exception state

> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 18 February 2016 09:24 > To: Paul Durrant > Cc: Andrew Cooper; David Vrabel; Feng Wu; Kevin Tian; xen-devel > Subject: RE: Restoring FPU exception state > > >>> On 18.02.16 at 09:54, wrote: > >> -Original Mes

Re: [Xen-devel] [PATCH v5 7/7] VT-d: Fix vt-d Device-TLB flush timeout issue.

> On February 18, 2016 5:21pm, wrote: > >>> On 18.02.16 at 09:47, wrote: > >> On February 18, 2016 4:36pm, wrote: > >> >>> On 18.02.16 at 08:36, wrote: > >> >> On February 17, 2016 10:41pm, wrote: > >> >> >>> On 05.02.16 at 11:18, wrote: > >> >> > --- a/xen/drivers/passthrough/vtd/qinval.

[Xen-devel] Uninitialized variables in hvm_event_breakpoint (Re: New Defects reported by Coverity Scan for XenProject)

On Wed, 2016-02-17 at 16:02 -0800, scan-ad...@coverity.com wrote: > Hi, > > Please find the latest report on new defect(s) introduced to XenProject > found with Coverity Scan. > > 1 new defect(s) introduced to XenProject found with Coverity Scan. > 4 defect(s), reported by Coverity Scan earlier,

Re: [Xen-devel] [PATCH] MAINTAINERS: add myself as seabios maintainer

On Wed, 2016-02-17 at 16:47 +, Wei Liu wrote: > On Wed, Feb 17, 2016 at 11:45:58AM -0500, Konrad Rzeszutek Wilk wrote: > > On Wed, Feb 17, 2016 at 09:48:28AM +, Ian Campbell wrote: > > > On Tue, 2016-02-16 at 17:54 +, Ian Jackson wrote: > > > > Wei Liu writes ("[PATCH] MAINTAINERS: add

Re: [Xen-devel] Uninitialized variables in hvm_event_breakpoint (Re: New Defects reported by Coverity Scan for XenProject)

On 2/18/2016 12:01 PM, Ian Campbell wrote: On Wed, 2016-02-17 at 16:02 -0800, scan-ad...@coverity.com wrote: Hi, Please find the latest report on new defect(s) introduced to XenProject found with Coverity Scan. 1 new defect(s) introduced to XenProject found with Coverity Scan. 4 defect(s), rep

Re: [Xen-devel] [PATCH v3 01/10] xen: make xen loader callable multiple times

On Wed, Feb 17, 2016 at 06:19:28PM +0100, Juergen Gross wrote: > The loader for xen paravirtualized environment isn't callable multiple > times as it won't free any memory in case of failure. > > Call grub_relocator_unload() as other modules do it before allocating Do you mean grub_xen_reset? > a

Re: [Xen-devel] Uninitialized variables in hvm_event_breakpoint (Re: New Defects reported by Coverity Scan for XenProject)

On 02/18/2016 12:01 PM, Ian Campbell wrote: > On Wed, 2016-02-17 at 16:02 -0800, scan-ad...@coverity.com wrote: >> Hi, >> >> Please find the latest report on new defect(s) introduced to XenProject >> found with Coverity Scan. >> >> 1 new defect(s) introduced to XenProject found with Coverity Scan.

Re: [Xen-devel] [PATCH] xen/arm64: Make sure we get all debug output

On Wed, 2016-02-17 at 17:49 +0100, Dirk Behme wrote: > Could this be applied, then? Yes, sorry, this fell through the cracks somehow. I've applied it to #staging now (from where automated testing will push it into #master). I also added the same change to arm32/head.S and noted that I'd done so i

Re: [Xen-devel] Uninitialized variables in hvm_event_breakpoint (Re: New Defects reported by Coverity Scan for XenProject)

On 02/18/2016 12:13 PM, Corneliu ZUZU wrote: > On 2/18/2016 12:01 PM, Ian Campbell wrote: >> On Wed, 2016-02-17 at 16:02 -0800, scan-ad...@coverity.com wrote: >>> Hi, >>> >>> Please find the latest report on new defect(s) introduced to XenProject >>> found with Coverity Scan. >>> >>> 1 new defect(s

Re: [Xen-devel] [PATCH] tools: remove xenpmd

On Wed, 2016-02-17 at 12:05 -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Feb 17, 2016 at 02:41:14PM +, Ian Campbell wrote: > > It has four instances of the same CID 1198719 (strncpy(..., 32) into a > > 32-byte buffer). > > > > However ever since it was checked in in 2008 it has contained a >

Re: [Xen-devel] [PATCH] xen/arm64: Make sure we get all debug output

>>> On 18.02.16 at 11:15, wrote: > On Wed, 2016-02-17 at 17:49 +0100, Dirk Behme wrote: >> Could this be applied, then? > > Yes, sorry, this fell through the cracks somehow. I've applied it to > #staging now (from where automated testing will push it into #master). > > I also added the same chan

Re: [Xen-devel] [PATCH 3/3] docs: add more info about target= in disk config

On Wed, 2016-02-17 at 10:24 -0700, Jim Fehlig wrote: > > > > > The general concept of escaping metacharaters is not mentioned in this doc > > at all, i.e. there is no mention of which characters need such escaping nor > > of the various "special" codes (\t and \n etc), nor of the octal and hex >

Re: [Xen-devel] [PATCH v3 02/10] xen: reduce number of global variables in xen loader

On Wed, Feb 17, 2016 at 06:19:29PM +0100, Juergen Gross wrote: > The loader for xen paravirtualized environment is using lots of global > variables. Reduce the number by making them either local or by putting > them into a single state structure. > > Signed-off-by: Juergen Gross Just two nitpicks

Re: [Xen-devel] [PATCH V2 3/3] docs: add more info about target= in disk config

On Wed, 2016-02-17 at 10:20 -0700, Jim Fehlig wrote: > target= in disk config can be used to convey arbitrary > configuration information to backends. Add a bit more info > to xl-disk-configuration.txt to clarify this, including some > simple nbd and rbd qdisk configurations. > > Signed-off-by: Ji

Re: [Xen-devel] Stabilising some tools only HVMOPs?

On Wed, 2016-02-17 at 17:28 +, Wei Liu wrote: > Hi all > > Tools people are in the process of splitting libxenctrl into a set of > stable libraries. One of the proposed libraries is libxendevicemodel > which has a collection of APIs that can be used by device model. > > Currently we use QEMU

Re: [Xen-devel] [PATCH v6] libxl: allow 'phy' backend to use empty files

Hi Roger, I have tested and applied the patch locally, and can confirm that the issue reported is now resolved. Best regards, Alex -Original Message- From: Roger Pau Monne [mailto:roger@citrix.com] Sent: Thursday, 18 February 2016 4:21 AM To: xen-de...@lists.xenproject.org Cc: Rog

Re: [Xen-devel] [PATCH v3 03/10] xen: add elfnote.h to avoid using numbers instead of constants

On Wed, Feb 17, 2016 at 06:19:30PM +0100, Juergen Gross wrote: > Various features and parameters of a pv-kernel are specified via > elf notes in the kernel image. Those notes are part of the interface > between the Xen hypervisor and the kernel. > > Instead of using num,bers in the code when interp

Re: [Xen-devel] Stabilising some tools only HVMOPs?

>>> On 17.02.16 at 18:28, wrote: > Hi all > > Tools people are in the process of splitting libxenctrl into a set of > stable libraries. One of the proposed libraries is libxendevicemodel > which has a collection of APIs that can be used by device model. > > Currently we use QEMU as reference to

Re: [Xen-devel] [PATCH v3 01/10] xen: make xen loader callable multiple times

On 18/02/16 11:12, Daniel Kiper wrote: > On Wed, Feb 17, 2016 at 06:19:28PM +0100, Juergen Gross wrote: >> The loader for xen paravirtualized environment isn't callable multiple >> times as it won't free any memory in case of failure. >> >> Call grub_relocator_unload() as other modules do it before

Re: [Xen-devel] [PATCH v2 01/16] xen: sched: __runq_tickle takes a useless cpu parameter

On 16/02/16 18:11, Dario Faggioli wrote: > as it is always acts on v->processor of the vcpu that > we are tickling. > > Getting rid of it makes the code easier to understand > and better looking. > > While there, remove a spurious blank line. > > Signed-off-by: Dario Faggioli > Reviewed-by: Kon

Re: [Xen-devel] [PATCH v3 04/10] xen: synchronize xen header

On Wed, Feb 17, 2016 at 06:19:31PM +0100, Juergen Gross wrote: > Get actual version of include/xen/xen.h from the Xen repository in > order to be able to use constants defined there. > > Signed-off-by: Juergen Gross Reviewed-by: Daniel Kiper Daniel _

Re: [Xen-devel] [PATCH v3 02/10] xen: reduce number of global variables in xen loader

On 18/02/16 11:22, Daniel Kiper wrote: > On Wed, Feb 17, 2016 at 06:19:29PM +0100, Juergen Gross wrote: >> The loader for xen paravirtualized environment is using lots of global >> variables. Reduce the number by making them either local or by putting >> them into a single state structure. >> >> Si

Re: [Xen-devel] [PATCH v2 02/16] xen: sched: move up the trace record for vcpu_wake and vcpu_sleep

On 16/02/16 18:11, Dario Faggioli wrote: > vcpu_wake() and vcpu_sleep() are called before the specific > schedulers wakeup and sleep routines (in fact, it is them > that calls those specific routine). > > Make the trace reflect that, by moving the records up. In > fact, it is more natural and easy

Re: [Xen-devel] [PATCH v3 03/10] xen: add elfnote.h to avoid using numbers instead of constants

On 18/02/16 11:30, Daniel Kiper wrote: > On Wed, Feb 17, 2016 at 06:19:30PM +0100, Juergen Gross wrote: >> Various features and parameters of a pv-kernel are specified via >> elf notes in the kernel image. Those notes are part of the interface >> between the Xen hypervisor and the kernel. >> >> Ins

Re: [Xen-devel] Stabilising some tools only HVMOPs?

On Thu, Feb 18, 2016 at 03:31:49AM -0700, Jan Beulich wrote: > >>> On 17.02.16 at 18:28, wrote: > > Hi all > > > > Tools people are in the process of splitting libxenctrl into a set of > > stable libraries. One of the proposed libraries is libxendevicemodel > > which has a collection of APIs that

Re: [Xen-devel] Stabilising some tools only HVMOPs?

>>> On 18.02.16 at 11:24, wrote: > On Wed, 2016-02-17 at 17:28 +, Wei Liu wrote: >> The list of tools only HVMOPs used by QEMU are: >> >> #define HVMOP_track_dirty_vram6 >> #define HVMOP_modified_memory7 >> #define HVMOP_set_mem_type8 >> #define HVMOP_inject_msi 16

Re: [Xen-devel] [PATCH v3 05/10] xen: factor out p2m list allocation into separate function

On Wed, Feb 17, 2016 at 06:19:32PM +0100, Juergen Gross wrote: > Do the p2m list allocation of the to be loaded kernel in a separate > function. This will allow doing the p2m list allocation at different > times of the boot preparations depending on the features the kernel > is supporting. > > Whil

Re: [Xen-devel] [PATCH v3 06/10] xen: factor out allocation of special pages into separate function

On Wed, Feb 17, 2016 at 06:19:33PM +0100, Juergen Gross wrote: > Do the allocation of special pages (start info, console and xenbus > ring buffers) in a separate function. This will allow to do the > allocation at different times of the boot preparations depending on > the features the kernel is su

[Xen-devel] [PATCH] x86/hvm_event: fix uninitialized struct field usage introduced by c/s f5365e6

c/s f5365e6: "xen/vm-events: Move parts of monitor_domctl code to common-side", introduced a use without initialization issue. hvm_event_breakpoint calls hvm_event_traps(&req) and if sync is true that ors some bits into req->flags which was never initialised. Reported by Coverity Scan. Initializes

Re: [Xen-devel] Stabilising some tools only HVMOPs?

On Thu, Feb 18, 2016 at 03:37:06AM -0700, Jan Beulich wrote: > >>> On 18.02.16 at 11:24, wrote: > > On Wed, 2016-02-17 at 17:28 +, Wei Liu wrote: > >> The list of tools only HVMOPs used by QEMU are: > >> > >> #define HVMOP_track_dirty_vram6 > >> #define HVMOP_modified_memory7 > >>

Re: [Xen-devel] Stabilising some tools only HVMOPs?

On Thu, 2016-02-18 at 03:31 -0700, Jan Beulich wrote: > > > > On 17.02.16 at 18:28, wrote: > > Hi all > > > > Tools people are in the process of splitting libxenctrl into a set of > > stable libraries. One of the proposed libraries is libxendevicemodel > > which has a collection of APIs that can

Re: [Xen-devel] [PATCH] x86/hvm_event: fix uninitialized struct field usage introduced by c/s f5365e6

On 02/18/2016 12:45 PM, Corneliu ZUZU wrote: > c/s f5365e6: "xen/vm-events: Move parts of monitor_domctl code to > common-side", > introduced a use without initialization issue. > hvm_event_breakpoint calls hvm_event_traps(&req) and if sync is true that > ors some bits into req->flags which was ne

Re: [Xen-devel] [PATCH v3 07/10] xen: factor out allocation of page tables into separate function

On Wed, Feb 17, 2016 at 06:19:34PM +0100, Juergen Gross wrote: > Do the allocation of page tables in a separate function. This will > allow to do the allocation at different times of the boot preparations > depending on the features the kernel is supporting. > > Signed-off-by: Juergen Gross Revie

Re: [Xen-devel] [PATCH] x86/hvm_event: fix uninitialized struct field usage introduced by c/s f5365e6

On 18/02/16 10:45, Corneliu ZUZU wrote: > c/s f5365e6: "xen/vm-events: Move parts of monitor_domctl code to > common-side", > introduced a use without initialization issue. > hvm_event_breakpoint calls hvm_event_traps(&req) and if sync is true that > ors some bits into req->flags which was never i

Re: [Xen-devel] Stabilising some tools only HVMOPs?

On Thu, 2016-02-18 at 10:45 +, Wei Liu wrote: > On Thu, Feb 18, 2016 at 03:37:06AM -0700, Jan Beulich wrote: > > > > > On 18.02.16 at 11:24, wrote: > > > On Wed, 2016-02-17 at 17:28 +, Wei Liu wrote: > > > > The list of tools only HVMOPs used by QEMU are: > > > > > > > >   #define HVMOP_t

[Xen-devel] [PATCH] x86/monitor: minor left-shift undefined behavior checks

This minor patch adds a range-check to avoid left-shift caused undefined behavior. Also replaces '1 <<' w/ '1U <<' @ x86 monitor.h in an effort to avoid a future potential '1 << 31' that would cause a similar issue. Signed-off-by: Corneliu ZUZU --- xen/arch/x86/monitor.c| 13 +---

Re: [Xen-devel] Stabilising some tools only HVMOPs?

On Thu, Feb 18, 2016 at 10:53:00AM +, Ian Campbell wrote: > On Thu, 2016-02-18 at 10:45 +, Wei Liu wrote: > > On Thu, Feb 18, 2016 at 03:37:06AM -0700, Jan Beulich wrote: > > > > > > On 18.02.16 at 11:24, wrote: > > > > On Wed, 2016-02-17 at 17:28 +, Wei Liu wrote: > > > > > The list o

Re: [Xen-devel] Stabilising some tools only HVMOPs?

>>> On 18.02.16 at 11:44, wrote: > On Thu, 2016-02-18 at 03:31 -0700, Jan Beulich wrote: >> > > > On 17.02.16 at 18:28, wrote: >> > Hi all >> > >> > Tools people are in the process of splitting libxenctrl into a set of >> > stable libraries. One of the proposed libraries is libxendevicemodel >>

Re: [Xen-devel] Stabilising some tools only HVMOPs?

>>> On 18.02.16 at 11:45, wrote: > On Thu, Feb 18, 2016 at 03:37:06AM -0700, Jan Beulich wrote: >> >>> On 18.02.16 at 11:24, wrote: >> > On Wed, 2016-02-17 at 17:28 +, Wei Liu wrote: >> >> The list of tools only HVMOPs used by QEMU are: >> >> >> >> #define HVMOP_track_dirty_vram6 >> >>

Re: [Xen-devel] Stabilising some tools only HVMOPs?

On Thu, Feb 18, 2016 at 03:55:36AM -0700, Jan Beulich wrote: > >>> On 18.02.16 at 11:44, wrote: > > On Thu, 2016-02-18 at 03:31 -0700, Jan Beulich wrote: > >> > > > On 17.02.16 at 18:28, wrote: > >> > Hi all > >> > > >> > Tools people are in the process of splitting libxenctrl into a set of > >>

[Xen-devel] [PATCH] docs: document handling of metacharacter escape in xl disk format

Signed-off-by: Ian Campbell Cc: Jim Fehlig --- docs/misc/xl-disk-configuration.txt | 18 ++ 1 file changed, 18 insertions(+) diff --git a/docs/misc/xl-disk-configuration.txt b/docs/misc/xl-disk-configuration.txt index 6a2118d..a03ad10 100644 --- a/docs/misc/xl-disk-configuratio

Re: [Xen-devel] [PATCH] [VERY RFC] Clang: Issues with .data.rel.ro relocations

On 18/02/16 10:50, Jan Beulich wrote: On 17.02.16 at 21:42, wrote: >> Clang-3.8 generates several .data.rel.ro sections when compiling Xen. >> >> c/s eb2952b4 "x86: move alternative.c data fully into .init.*" cited "While >> at >> it also drop the non-local section names from SPECIAL_DATA_SE

Re: [Xen-devel] [PATCH v2 03/16] xen: sched: improve domain creation tracing

On 16/02/16 18:11, Dario Faggioli wrote: > by doing the following two things: > > - move TRC_SCHED_DOM_{ADD,REM}, into the functions >that do the actual scheduling-related domain >initialization; > > - add two 'generic' DOM_{ADD,REM} events. They're >made part of the TRC_DOM0 tracin

Re: [Xen-devel] [PATCH V2 0/4] libxl: support qemu's network-based block backends

On Wed, 2016-02-17 at 17:33 -0700, Jim Fehlig wrote: > xl/libxl already supports qemu's network-based block backends > such as nbd and rbd. libvirt has supported configuring network > disks for long time too. This series marries the two in the > libxl driver and in the xl<->xml converter. Only rbd

Re: [Xen-devel] [PATCH v2 04/16] xen: credit2: pack trace data better for xentrace_format

On 16/02/16 18:11, Dario Faggioli wrote: > when tracing runstate changes, the vcpu and domain IDs > are encoded in the lower and higher, respectively, parts > of a 32 bits integer. When decoding a trace with > xentrace_format, this makes it possible to display > such events like this: > > CPU0 83

Re: [Xen-devel] [PATCH] [VERY RFC] Clang: Issues with .data.rel.ro relocations

>>> On 17.02.16 at 21:42, wrote: > Clang-3.8 generates several .data.rel.ro sections when compiling Xen. > > c/s eb2952b4 "x86: move alternative.c data fully into .init.*" cited "While at > it also drop the non-local section names from SPECIAL_DATA_SECTIONS - they > can't be safely converted." wi

Re: [Xen-devel] [PATCH v3 08/10] xen: add capability to load initrd outside of initial mapping

On Wed, Feb 17, 2016 at 06:19:35PM +0100, Juergen Gross wrote: > Modern pvops linux kernels support an initrd not covered by the initial > mapping. This capability is flagged by an elf-note. > > In case the elf-note is set by the kernel don't place the initrd into > the initial mapping. This will a

Re: [Xen-devel] [PATCH v2] tools: libxl: make it illegal to pass libxl__realloc(gc) a non-gc ptr

On Thu, 2016-02-11 at 09:23 +, Ian Campbell wrote: > That is, if gc is not NOGC and ptr is not NULL then ptr must be > associated gc. > > Currently in this case the new_ptr would not be registered with any > gc, which Coverity rightly points out (in various different places) > would be a memor

Re: [Xen-devel] [PATCH v2 05/16] xen: RTDS: pack trace data better for xentrace_format

On 16/02/16 18:11, Dario Faggioli wrote: > when tracing runstate changes, the vcpu and domain IDs > are encoded in the lower and higher, respectively, parts > of a 32 bits integer. When decoding a trace with > xentrace_format, this makes it possible to display > such events like this: > > CPU0 83

Re: [Xen-devel] [PATCH v2 06/16] xen: sched: tracing: enable TSC tracing for all events

On 17/02/16 09:52, Dario Faggioli wrote: > On Tue, 2016-02-16 at 13:21 -0500, Meng Xu wrote: >> Hi Dario, >> >> Since this patch did some obvious change, I will reply with >> reviewed-by, although my reviewed-by does not count much. ;-) >> > That can't be less true. First of all, you're the origina

Re: [Xen-devel] Stabilising some tools only HVMOPs?

>>> On 18.02.16 at 11:59, wrote: > On Thu, Feb 18, 2016 at 03:55:36AM -0700, Jan Beulich wrote: >> >>> On 18.02.16 at 11:44, wrote: >> > On Thu, 2016-02-18 at 03:31 -0700, Jan Beulich wrote: >> >> > > > On 17.02.16 at 18:28, wrote: >> >> > Hi all >> >> > >> >> > Tools people are in the process

Re: [Xen-devel] [PATCH v2] tools: libxl: make it illegal to pass libxl__realloc(gc) a non-gc ptr

On 18/02/16 11:30, Ian Campbell wrote: > On Thu, 2016-02-11 at 09:23 +, Ian Campbell wrote: >> That is, if gc is not NOGC and ptr is not NULL then ptr must be >> associated gc. >> >> Currently in this case the new_ptr would not be registered with any >> gc, which Coverity rightly points out (in

Re: [Xen-devel] [PATCH v2] tools: libxl: make it illegal to pass libxl__realloc(gc) a non-gc ptr

On Thu, 2016-02-18 at 11:55 +, Andrew Cooper wrote: > On 18/02/16 11:30, Ian Campbell wrote: > > On Thu, 2016-02-11 at 09:23 +, Ian Campbell wrote: > > > That is, if gc is not NOGC and ptr is not NULL then ptr must be > > > associated gc. > > > > > > Currently in this case the new_ptr woul

Re: [Xen-devel] [PATCH v3] libxc: fix leak of t_info in xc_tbuf_get_size()

On Fri, 2016-02-12 at 12:34 +, Wei Liu wrote: > On Fri, Feb 12, 2016 at 04:38:32PM +0530, Harmandeep Kaur wrote: > > Avoid leaking the memory mapping of the trace buffer > > > > Coverity ID 1351228 > > > > Signed-off-by: Harmandeep Kaur > > Reviewed-by: Dario Faggioli > > Acked-by: Wei Liu

Re: [Xen-devel] [PATCH v8 05/13] tools/libxc: support to resume uncooperative HVM guests

On Thu, Feb 18, 2016 at 10:43:15AM +0800, Wen Congyang wrote: > Before this patch: > 1. suspend > a. PVHVM and PV: we use the same way to suspend the guest (send the suspend >request to the guest). If the guest doesn't support evtchn, the xenstore >variant will be used, suspending the guest

Re: [Xen-devel] [PATCH v2 15/30] xen/x86: Improvements to in-hypervisor cpuid sanity checks

On 17/02/16 14:45, Jan Beulich wrote: On 17.02.16 at 15:02, wrote: >> On 17/02/16 10:55, Jan Beulich wrote: >> On 17.02.16 at 11:43, wrote: On 16/02/16 10:06, Jan Beulich wrote: On 15.02.16 at 18:12, wrote: >> On 15/02/16 15:43, Jan Beulich wrote: >> On 05.02.1

[Xen-devel] [PATCH] xen/x86: Annotate deliberate fallthrough cases from XSA-154

Coverity objects otherwise. Signed-off-by: Andrew Cooper --- CC: Jan Beulich --- xen/arch/x86/mm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index a05edc3..0bff7dd 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -924,10 +924,15 @@ g

Re: [Xen-devel] [PATCH v2 07/16] xentrace: formats: update format of scheduling events

On 16/02/16 18:12, Dario Faggioli wrote: > to include the vcpu IDs, in a way that matches > how the "dom:vcpu" couple is displayed in other > events (runstate changes). > > Also add the trace for TRC_SCHED_SHUTDOWN_CODE which > was missing and was done via SCHEDOP_shutdown_code hypercall. > (TRC_S

Re: [Xen-devel] [PATCH v8 01/13] libxl/remus: init checkpoint callback in Remus setup callback

On Thu, Feb 18, 2016 at 10:43:11AM +0800, Wen Congyang wrote: > Init stream {read/write} state checkpoint_callback, suspend/resume/checkpoint > callback in Remus setup callback. > There's no functional change, it's just refactoring so that we can move > all remus code into one file. > > Signed-off

Re: [Xen-devel] [PATCH v2 16/30] x86/cpu: Move set_cpumask() calls into c_early_init()

On 17/02/16 10:58, Jan Beulich wrote: On 17.02.16 at 11:45, wrote: >> On 16/02/16 14:10, Jan Beulich wrote: >> On 05.02.16 at 14:42, wrote: Before c/s 44e24f8567 "x86: don't call generic_identify() redundantly", the commandline-provided masks would take effect in Xen's view of

Re: [Xen-devel] [PATCH v3 08/10] xen: add capability to load initrd outside of initial mapping

On 18/02/16 12:18, Daniel Kiper wrote: > On Wed, Feb 17, 2016 at 06:19:35PM +0100, Juergen Gross wrote: >> Modern pvops linux kernels support an initrd not covered by the initial >> mapping. This capability is flagged by an elf-note. >> >> In case the elf-note is set by the kernel don't place the i

Re: [Xen-devel] [PATCH v2 21/30] x86/pv: Provide custom cpumasks for PV domains

On 17/02/16 11:14, Jan Beulich wrote: On 17.02.16 at 12:03, wrote: >> On 17/02/16 08:13, Jan Beulich wrote: >> On 05.02.16 at 14:42, wrote: --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -208,7 +208,9 @@ static void __init noinline probe_masking_msrs(void) >>

Re: [Xen-devel] Stabilising some tools only HVMOPs?

On Wed, Feb 17, 2016 at 05:28:08PM +, Wei Liu wrote: > Hi all > > Tools people are in the process of splitting libxenctrl into a set of > stable libraries. One of the proposed libraries is libxendevicemodel > which has a collection of APIs that can be used by device model. > > Currently we us

Re: [Xen-devel] [PATCH v2 15/30] xen/x86: Improvements to in-hypervisor cpuid sanity checks

>>> On 18.02.16 at 13:17, wrote: > On 17/02/16 14:45, Jan Beulich wrote: > On 17.02.16 at 15:02, wrote: >>> On 17/02/16 10:55, Jan Beulich wrote: >>> On 17.02.16 at 11:43, wrote: > On 16/02/16 10:06, Jan Beulich wrote: > On 15.02.16 at 18:12, wrote: >>> On 15/02/16 15:43

Re: [Xen-devel] [PATCH] xen/x86: Annotate deliberate fallthrough cases from XSA-154

>>> On 18.02.16 at 13:26, wrote: > Coverity objects otherwise. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > --- > xen/arch/x86/mm.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c > index a05edc3..0bff7dd 100644 > --- a/xen/arc

Re: [Xen-devel] [PATCH v2 24/30] tools/libxc: Modify bitmap operations to take void pointers

On 10/02/16 10:18, Ian Campbell wrote: > On Wed, 2016-02-10 at 10:07 +, Andrew Cooper wrote: >> On 08/02/16 16:36, Ian Campbell wrote: >>> On Mon, 2016-02-08 at 16:23 +, Tim Deegan wrote: At 13:42 + on 05 Feb (1454679737), Andrew Cooper wrote: > The type of the pointer to a bit

Re: [Xen-devel] [PATCH v2 04/16] xen: credit2: pack trace data better for xentrace_format

On Thu, 2016-02-18 at 11:10 +, George Dunlap wrote: > On 16/02/16 18:11, Dario Faggioli wrote: > > when tracing runstate changes, the vcpu and domain IDs > > are encoded in the lower and higher, respectively, parts > > of a 32 bits integer. When decoding a trace with > > xentrace_format, this m

Re: [Xen-devel] [PATCH] x86/monitor: minor left-shift undefined behavior checks

On 02/18/2016 12:53 PM, Corneliu ZUZU wrote: > This minor patch adds a range-check to avoid left-shift caused undefined > behavior. Also replaces '1 <<' w/ '1U <<' @ x86 monitor.h in an effort to > avoid > a future potential '1 << 31' that would cause a similar issue. > > Signed-off-by: Corneliu

Re: [Xen-devel] [PATCH] x86/hvm_event: fix uninitialized struct field usage introduced by c/s f5365e6

On Feb 18, 2016 03:46, "Razvan Cojocaru" wrote: > > On 02/18/2016 12:45 PM, Corneliu ZUZU wrote: > > c/s f5365e6: "xen/vm-events: Move parts of monitor_domctl code to common-side", > > introduced a use without initialization issue. > > hvm_event_breakpoint calls hvm_event_traps(&req) and if sync i

Re: [Xen-devel] [PATCH] xen/x86: Annotate deliberate fallthrough cases from XSA-154

On 18/02/16 13:38, Jan Beulich wrote: On 18.02.16 at 13:26, wrote: >> Coverity objects otherwise. >> >> Signed-off-by: Andrew Cooper >> --- >> CC: Jan Beulich >> --- >> xen/arch/x86/mm.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c

Re: [Xen-devel] [PATCH] x86/hvm_event: fix uninitialized struct field usage introduced by c/s f5365e6

On 02/18/2016 04:10 PM, Tamas K Lengyel wrote: > > On Feb 18, 2016 03:46, "Razvan Cojocaru" > wrote: >> >> On 02/18/2016 12:45 PM, Corneliu ZUZU wrote: >> > c/s f5365e6: "xen/vm-events: Move parts of monitor_domctl code to > common-side", >> > introduced a use wi

Re: [Xen-devel] [PATCH] x86/hvm_event: fix uninitialized struct field usage introduced by c/s f5365e6

On 18/02/16 14:16, Razvan Cojocaru wrote: > On 02/18/2016 04:10 PM, Tamas K Lengyel wrote: >> On Feb 18, 2016 03:46, "Razvan Cojocaru" > > wrote: >>> On 02/18/2016 12:45 PM, Corneliu ZUZU wrote: c/s f5365e6: "xen/vm-events: Move parts of monitor_domctl code to

[Xen-devel] [PATCH] travis: Drop bridge-utils and iproute2

These packages are not permitted inside travis, and are not necessary for building Xen. Signed-off-by: Andrew Cooper --- CC: Doug Goldstein CC: Ian Campbell CC: Ian Jackson CC: Wei Liu --- .travis.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index c7227b

Re: [Xen-devel] [PATCH v2 05/16] xen: RTDS: pack trace data better for xentrace_format

I'm sorry for replying late. Somehow, I forgot to reply this patch email. :-( On Tue, Feb 16, 2016 at 1:11 PM, Dario Faggioli wrote: > when tracing runstate changes, the vcpu and domain IDs > are encoded in the lower and higher, respectively, parts > of a 32 bits integer. When decoding a trace wi

Re: [Xen-devel] Is: PVH dom0 - MWAIT detection logic to get deeper C-states exposed in ACPI AML code. Was:Re: [PATCH v2 10/30] xen/x86: Annotate VM applicability in featureset

El 17/2/16 a les 20:02, Konrad Rzeszutek Wilk ha escrit: > On Mon, Feb 15, 2016 at 03:41:41PM +, Andrew Cooper wrote: >> On 15/02/16 15:02, Jan Beulich wrote: >> On 15.02.16 at 15:53, wrote: On 15/02/16 14:50, Jan Beulich wrote: On 15.02.16 at 15:38, wrote: >> On 15/02/1

Re: [Xen-devel] Is: PVH dom0 - MWAIT detection logic to get deeper C-states exposed in ACPI AML code. Was:Re: [PATCH v2 10/30] xen/x86: Annotate VM applicability in featureset

On 18/02/16 15:02, Roger Pau Monné wrote: > El 17/2/16 a les 20:02, Konrad Rzeszutek Wilk ha escrit: >> On Mon, Feb 15, 2016 at 03:41:41PM +, Andrew Cooper wrote: >>> On 15/02/16 15:02, Jan Beulich wrote: >>> On 15.02.16 at 15:53, wrote: > On 15/02/16 14:50, Jan Beulich wrote:

Re: [Xen-devel] [PATCH v2 14/16] xenalyze: handle Credit2 scheduler events

On 16/02/16 18:13, Dario Faggioli wrote: > so the trace will show properly decoded info, > rather than just a bunch of hex codes. > > Signed-off-by: Dario Faggioli > Reviewed-by: Konrad Rzeszutek Wilk Acked-by: George Dunlap > --- > Cc: George Dunlap > Cc: Ian Jackson > Cc: Ian Campbell >

Re: [Xen-devel] [PATCH v2 12/16] xenalyze: handle scheduling events

On 16/02/16 18:12, Dario Faggioli wrote: > so the trace will show properly decoded info, > rather than just a bunch of hex codes. > > Signed-off-by: Dario Faggioli > Reviewed-by: Konrad Rzeszutek Wilk Acked-by: George Dunlap > --- > Cc: George Dunlap > Cc: Ian Jackson > Cc: Ian Campbell >

Re: [Xen-devel] Is: PVH dom0 - MWAIT detection logic to get deeper C-states exposed in ACPI AML code. Was:Re: [PATCH v2 10/30] xen/x86: Annotate VM applicability in featureset

On 18/02/16 15:02, Roger Pau Monné wrote: > El 17/2/16 a les 20:02, Konrad Rzeszutek Wilk ha escrit: >> On Mon, Feb 15, 2016 at 03:41:41PM +, Andrew Cooper wrote: >>> On 15/02/16 15:02, Jan Beulich wrote: >>> On 15.02.16 at 15:53, wrote: > On 15/02/16 14:50, Jan Beulich wrote:

Re: [Xen-devel] [PATCH v2 13/16] xenalyze: handle Credit1 scheduler events

On 16/02/16 18:12, Dario Faggioli wrote: > so the trace will show properly decoded info, > rather than just a bunch of hex codes. > > Signed-off-by: Dario Faggioli > Reviewed-by: Konrad Rzeszutek Wilk Acked-by: George Dunlap > --- > Cc: George Dunlap > Cc: Ian Jackson > Cc: Ian Campbell >

Re: [Xen-devel] [PATCH v2 15/16] xenalyze: handle RTDS scheduler events

On 16/02/16 18:13, Dario Faggioli wrote: > so the trace will show properly decoded info, > rather than just a bunch of hex codes. > > Signed-off-by: Dario Faggioli > Reviewed-by: Konrad Rzeszutek Wilk > --- > Cc: George Dunlap > Cc: Meng Xu > Cc: Tianyang Chen > Cc: Ian Jackson > Cc: Ian Cam

Re: [Xen-devel] [PATCH v2 13/16] xenalyze: handle Credit1 scheduler events

On 16/02/16 18:12, Dario Faggioli wrote: > so the trace will show properly decoded info, > rather than just a bunch of hex codes. > > Signed-off-by: Dario Faggioli > Reviewed-by: Konrad Rzeszutek Wilk > --- > Cc: George Dunlap > Cc: Ian Jackson > Cc: Ian Campbell > Cc: Wei Liu > Cc: Olaf Her

[Xen-devel] False positive coverity bug id: 1351218

This is about a Coverity bug (included in the end), which I think is a false positive. I don't think pagesize can be zero in any case. pagesize = 1 << (((flags >> TMEM_POOL_PAGESIZE_SHIFT) & TMEM_POOL_PAGESIZE_MASK) + 12); Which means "pagesize > bufsize" will always be

Re: [Xen-devel] [PATCH] x86/hvm_event: fix uninitialized struct field usage introduced by c/s f5365e6

On Thu, Feb 18, 2016 at 7:18 AM, Andrew Cooper wrote: > On 18/02/16 14:16, Razvan Cojocaru wrote: > > On 02/18/2016 04:10 PM, Tamas K Lengyel wrote: > >> On Feb 18, 2016 03:46, "Razvan Cojocaru" >> > wrote: > >>> On 02/18/2016 12:45 PM, Corneliu ZUZU wrote: > >>

Re: [Xen-devel] [PATCH] tools/xenalyze: Fix build with clang

On 12/02/16 19:06, Andrew Cooper wrote: > 1) EXIT_REASON_EXCEPTION_NMI is 0, and Clang complains: > > xenalyze.c:513:33: error: initializer overrides prior initialization of this > subobject [-Werror,-Winitializer-overrides] > [EXIT_REASON_EXCEPTION_NMI]="EXCEPTION_NMI", >

[Xen-devel] libxl_device handling for nic and vtmp

What is the point of libxl__update_config_nic and libxl__update_config_vtmp? In libxl__device_type_add (called from DEFINE_DEVICE_ADD) the input type is copied with libxl_device_type_copy to type_saved, which is a 1:1 copy. If needed, a new devid is assigned to the input. Later the copy is updated

Re: [Xen-devel] False positive coverity bug id: 1351218

On 18/02/16 15:36, Harmandeep Kaur wrote: > This is about a Coverity bug (included in the end), which I think is > a false positive. I don't think pagesize can be zero in any case. > pagesize = 1 << (((flags >> TMEM_POOL_PAGESIZE_SHIFT) & > TMEM_POOL_PAGESIZE_MASK) + 12)

Re: [Xen-devel] libxl_device handling for nic and vtmp

On Thu, Feb 18, 2016 at 04:13:21PM +0100, Olaf Hering wrote: > What is the point of libxl__update_config_nic and > libxl__update_config_vtmp? > > In libxl__device_type_add (called from DEFINE_DEVICE_ADD) the input > type is copied with libxl_device_type_copy to type_saved, which is a > 1:1 copy. I

Re: [Xen-devel] [PATCH] travis: Drop bridge-utils and iproute2

On 2/18/16 8:36 AM, Andrew Cooper wrote: > These packages are not permitted inside travis, and are not necessary for > building Xen. > > Signed-off-by: Andrew Cooper > --- > CC: Doug Goldstein > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu > --- Reviewed-by: Doug Goldstein -- Doug Gol

  1   2   >