On Thu, 2016-02-18 at 11:10 +0000, George Dunlap wrote: > On 16/02/16 18:11, Dario Faggioli wrote: > > when tracing runstate changes, the vcpu and domain IDs > > are encoded in the lower and higher, respectively, parts > > of a 32 bits integer. When decoding a trace with > > xentrace_format, this makes it possible to display > > such events like this: > > > > CPU0 833435853624 (+ 768) running_to_runnable [ dom:vcpu = > > 0x7fff0000 ] > > CPU0 833435854416 (+ 792) runnable_to_running [ dom:vcpu = > > 0x00000007 ] > > > > For consistency, we should do the same when displaying > > the events coming from the Credit2 scheduler (when using > > the same tool), and to do that, we need to invert the > > order in which the fields are being put in the trace > > struct right now. > > > > Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com> > > Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > > I was going to say, "We should change xentrace_format and xenalyze in > lockstep", but it turns out that they don't support these trace > records > yet! I must have some patches to xenalyze in a local branch > somewhere > that I never upstreamed properly. > If I understand what you mean, I'm doing exactly that in the second half of this series (and per the latest email, the xentrace_format part, you've seen it already). :-)
> So, all is well: > > Acked-by: George Dunlap <george.dun...@citrix.com> > Thanks, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
