Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Jan Beulich
>>> On 11.02.16 at 20:41, wrote: > On 11/02/16 19:25, Andrew Cooper wrote: >> --- a/xen/arch/x86/flushtlb.c >> +++ b/xen/arch/x86/flushtlb.c >> @@ -141,10 +141,10 @@ void flush_area_local(const void *va, unsigned int >> flags) >> { >> alternative(ASM_NOP3, "sfence", X86_FEAT

Re: [Xen-devel] [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side.

2016-02-12 Thread Corneliu ZUZU
On 2/12/2016 8:05 AM, Corneliu ZUZU wrote: On 2/11/2016 5:44 PM, Tamas K Lengyel wrote: * the #ifdefs make it possible for that code to be put in common => that makes it *clear* that those code parts are NOT architecture specific and their implementation can be safely used for a

Re: [Xen-devel] [PATCH v2 4/6] xen: add capability to load initrd outside of initial mapping

2016-02-12 Thread Daniel Kiper
Hey Juergen, On Fri, Feb 12, 2016 at 07:25:02AM +0100, Juergen Gross wrote: [...] > Okay, let me do some cleanup work on the xen loader: > > - add the possibility to call it multiple times (state reset, free the > allocated memory) > - merge all necessary global variables into one state struct

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Jan Beulich
>>> On 11.02.16 at 20:25, wrote: > CentOS 7 gets into trouble when compiling Xen citing: > > flushtlb.c: Assembler messages: > flushtlb.c:149: Error: value of 256 too large for field of 1 bytes at 1 > > The line number is wrong, and the error message not helpful. It turns out > that the int

Re: [Xen-devel] [PATCH v3 1/5] hypervisor/arm/keyhandler: Declare struct cpu_user_regs;

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 04:08, wrote: > in the keyhandler.h file. Otherwise on ARM builds if we > just use the keyhandler file - the compile will fail. > > CC: ian.campb...@citrix.com > CC: wei.l...@citrix.com > CC: stefano.stabell...@citrix.com > Signed-off-by: Konrad Rzeszutek Wilk See commit d

[Xen-devel] [PATCH] vm_event: Remove xc_mem_access_enable_emulate() and friends

2016-02-12 Thread Razvan Cojocaru
xc_mem_access_enable_emulate() and xc_mem_access_disable_emulate() are currently no-ops, that is all they do is set a flag that nobody else checks. The user can already set the EMULATE flags in the vm_event response if emulation is desired, and having an extra check above that is not inherently saf

Re: [Xen-devel] [PATCH v2 2/2] vm_event: consolidate hvm_event_fill_regs and p2m_vm_event_fill_regs

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 01:22, wrote: > --- a/xen/arch/x86/hvm/event.c > +++ b/xen/arch/x86/hvm/event.c > @@ -23,40 +23,9 @@ > #include > #include > #include > +#include > #include > > -static void hvm_event_fill_regs(vm_event_request_t *req) > -{ > -const struct cpu_user_regs *regs = gu

Re: [Xen-devel] [PATCH] vm_event: Remove xc_mem_access_enable_emulate() and friends

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 10:04, wrote: > --- a/xen/include/public/memory.h > +++ b/xen/include/public/memory.h > @@ -390,8 +390,6 @@ DEFINE_XEN_GUEST_HANDLE(xen_mem_paging_op_t); > #define XENMEM_access_op21 > #define XENMEM_access_op_set_access 0 > #define XENMEM_access_o

Re: [Xen-devel] [PATCH v2 1/2] hvm/vmx: save dr7 during vmx_vmcs_save

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 01:22, wrote: > Sending the dr7 register during vm_events is useful for various applications, > but the current way the register value is gathered is incorrent. In this > patch > we extend vmx_vmcs_save so that we get the correct value. > > Suggested-by: Andrew Cooper Iirc A

Re: [Xen-devel] [PATCH] vm_event: Remove xc_mem_access_enable_emulate() and friends

2016-02-12 Thread Razvan Cojocaru
On 02/12/2016 11:10 AM, Jan Beulich wrote: On 12.02.16 at 10:04, wrote: >> --- a/xen/include/public/memory.h >> +++ b/xen/include/public/memory.h >> @@ -390,8 +390,6 @@ DEFINE_XEN_GUEST_HANDLE(xen_mem_paging_op_t); >> #define XENMEM_access_op21 >> #define XENMEM_access_o

Re: [Xen-devel] [PATCH] xen/common: Uniformally use __ varients for attribute names

2016-02-12 Thread Jan Beulich
>>> On 11.02.16 at 20:51, wrote: > Otherwise, debug code such as "void __attribute__((noreturn)) foobar()" fails > to compile when the noreturn itself gets expanded, resulting in > __attribute__((__attribute__((noreturn. Well, why would the debugging code not use plain "noreturn" then, instea

Re: [Xen-devel] [PATCH 1/4] xen/pciback: Check PF instead of VF for PCI_COMMAND_MEMORY

2016-02-12 Thread Jan Beulich
>>> On 11.02.16 at 22:10, wrote: > c/s 408fb0e5aa7fda0059db282ff58c3b2a4278baa0 > "xen/pciback: Don't allow MSI-X ops if PCI_COMMAND_MEMORY is not set." > would check the device for PCI_COMMAND_MEMORY which is great. > Except that VF devices are unique - for example they have no > legacy interrupt

Re: [Xen-devel] [PATCH 2/4] xen/pciback: Save the number of MSI-X entries to be copied later.

2016-02-12 Thread Jan Beulich
>>> On 11.02.16 at 22:10, wrote: > c/s 8135cf8b092723dbfcc611fe6fdcb3a36c9951c5 > "xen/pciback: Save xen_pci_op commands before processing it" > would copyback the processed values - which was great. > > However it missed the case that xen_pcibk_enable_msix - when > completing would overwrite op

[Xen-devel] [PATCH v2 1/2] xen: credit1: trace vCPU boost/unboost

2016-02-12 Thread Dario Faggioli
Add tracepoints and a performance counter for boosting and unboosting in Credit1. Note that they (the trace points) do not cover the case of the idle vCPU being boosted to run a tasklet, as there already is TRC_CSCHED_SCHED_TASKLET for that. Signed-off-by: Dario Faggioli --- Cc: George Dunlap

[Xen-devel] [PATCH 0/2] xen: sched: Credit1 shouldn't boost vcpus being migrated.

2016-02-12 Thread Dario Faggioli
Hi again, Here it comes v2, redone following Jan's suggestion, which allowed to get rid of patch 2, and do everything in sched_credit.c. So, in summary, because of the fact that vcpu_migrate() forces the vcpus into a sleep+wakeup cycle, vcpus being migrated to a new pcpu, were also being granted

[Xen-devel] Anyone know where the official qemu(1) man pages are hosted?

2016-02-12 Thread Lars Kurth
I noticed that the qemu(1) links in http://xenbits.xen.org/docs/unstable/man/xl.cfg.5.html (and probably other docs) are broken. They go to http://man.he.net/man1/qemu, which does not exist any more Lars ___ Xen-devel mailing list Xen-devel@lists.xen.o

[Xen-devel] [PATCH v2 2/2] xen: credit1: avoid boosting vCPUs being "just" migrated

2016-02-12 Thread Dario Faggioli
Moving a vCPU to a different pCPU means offlining it and then waking it up, on the new pCPU. Credit1 grants BOOST priority to vCPUs that wakes up, with the aim of improving I/O latency. The net effect of this all is that vCPUs get boosted when migrating, which shouldn't happen. For instance, this

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Andrew Cooper
On 12/02/16 08:13, Jan Beulich wrote: On 11.02.16 at 20:41, wrote: >> On 11/02/16 19:25, Andrew Cooper wrote: >>> --- a/xen/arch/x86/flushtlb.c >>> +++ b/xen/arch/x86/flushtlb.c >>> @@ -141,10 +141,10 @@ void flush_area_local(const void *va, unsigned int >>> flags) >>> { >>>

Re: [Xen-devel] [PATCH v2 2/2] xen: credit1: avoid boosting vCPUs being "just" migrated

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 10:37, wrote: > @@ -787,6 +788,16 @@ _csched_cpu_pick(const struct scheduler *ops, struct > vcpu *vc, bool_t commit) > static int > csched_cpu_pick(const struct scheduler *ops, struct vcpu *vc) > { > +struct csched_vcpu *svc = CSCHED_VCPU(vc); > + > +/* > + * We

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Andrew Cooper
On 12/02/16 08:23, Jan Beulich wrote: On 11.02.16 at 20:25, wrote: >> CentOS 7 gets into trouble when compiling Xen citing: >> >> flushtlb.c: Assembler messages: >> flushtlb.c:149: Error: value of 256 too large for field of 1 bytes at 1 >> >> The line number is wrong, and the error messag

Re: [Xen-devel] [PATCH v2 2/2] vm_event: consolidate hvm_event_fill_regs and p2m_vm_event_fill_regs

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 01:22, wrote: > --- a/xen/arch/x86/vm_event.c > +++ b/xen/arch/x86/vm_event.c > @@ -122,6 +122,65 @@ void vm_event_set_registers(struct vcpu *v, > vm_event_response_t *rsp) > v->arch.user_regs.eip = rsp->data.regs.x86.rip; > } > > +void vm_event_fill_regs(vm_event_reque

Re: [Xen-devel] [PATCH] xen/common: Uniformally use __ varients for attribute names

2016-02-12 Thread Andrew Cooper
On 12/02/16 09:16, Jan Beulich wrote: On 11.02.16 at 20:51, wrote: >> Otherwise, debug code such as "void __attribute__((noreturn)) foobar()" fails >> to compile when the noreturn itself gets expanded, resulting in >> __attribute__((__attribute__((noreturn. > Well, why would the debugging

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 10:51, wrote: > On 12/02/16 08:23, Jan Beulich wrote: > On 11.02.16 at 20:25, wrote: >>> CentOS 7 gets into trouble when compiling Xen citing: >>> >>> flushtlb.c: Assembler messages: >>> flushtlb.c:149: Error: value of 256 too large for field of 1 bytes at 1 >>> >>> The

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Andrew Cooper
On 12/02/16 10:00, Jan Beulich wrote: On 12.02.16 at 10:51, wrote: >> On 12/02/16 08:23, Jan Beulich wrote: >> On 11.02.16 at 20:25, wrote: CentOS 7 gets into trouble when compiling Xen citing: flushtlb.c: Assembler messages: flushtlb.c:149: Error: value of 256 to

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 11:02, wrote: > On 12/02/16 10:00, Jan Beulich wrote: > On 12.02.16 at 10:51, wrote: >>> On 12/02/16 08:23, Jan Beulich wrote: >>> On 11.02.16 at 20:25, wrote: > CentOS 7 gets into trouble when compiling Xen citing: > > flushtlb.c: Assembler messages: >>>

Re: [Xen-devel] [PATCH v2 2/2] vm_event: consolidate hvm_event_fill_regs and p2m_vm_event_fill_regs

2016-02-12 Thread Razvan Cojocaru
On 02/12/2016 11:57 AM, Jan Beulich wrote: On 12.02.16 at 01:22, wrote: >> --- a/xen/arch/x86/vm_event.c >> +++ b/xen/arch/x86/vm_event.c >> @@ -122,6 +122,65 @@ void vm_event_set_registers(struct vcpu *v, >> vm_event_response_t *rsp) >> v->arch.user_regs.eip = rsp->data.regs.x86.rip; >

[Xen-devel] [PATCH net-next v1 1/8] skbuff: store hash type in socket buffer...

2016-02-12 Thread Paul Durrant
...rather than a boolean merely indicating a canonical L4 hash. skb_set_hash() takes a hash type (from enum pkt_hash_types) as an argument but information is lost since only a single bit in the skb stores whether that hash type is PKT_HASH_TYPE_L4 or not. By using two bits it's possible to store

[Xen-devel] [PATCH net-next v1 6/8] xen-netback: add an implementation of toeplitz hashing...

2016-02-12 Thread Paul Durrant
...for receive-side packets. My recent patch to include/xen/interface/io/netif.h defines a set of control messages that can be used by a VM frontend driver to configure toeplitz hashing of receive-side packets and consequent steering of those packets to particular queues. This patch introduces an

[Xen-devel] [PATCH net-next v1 2/8] xen-netback: re-import canonical netif header

2016-02-12 Thread Paul Durrant
The canonical netif header (in the Xen source repo) and the Linux variant have diverged significantly. Recently much documentation has been added to the canonical header and new definitions and types to support packet hash configuration. Subsequent patches in this series add support for packet hash

[Xen-devel] [PATCH net-next v1 0/8] xen-netback: support toeplitz hashing

2016-02-12 Thread Paul Durrant
This patch series adds support for frontend-configurable toeplitz hashing in xen-netback (on the guest receive side). This support has been testing against a Windows frontend and has proven to be sufficient to pass the Microsoft HCK NDIS RSS tests. For convenience my development branch is availabl

[Xen-devel] [PATCH net-next v1 8/8] xen-netback: use toeplitz hash value from the frontend

2016-02-12 Thread Paul Durrant
This patch adds code to xen-netback to use the value in a toeplitz hash extra info fragment passed from the VM frontend in a transmit-side packet to set the skb hash accordingly. Signed-off-by: Paul Durrant Cc: Ian Campbell Cc: Wei Liu --- drivers/net/xen-netback/netback.c | 29 +++

[Xen-devel] [PATCH net-next v1 7/8] xen-netback: pass toeplitz hash value to the frontend

2016-02-12 Thread Paul Durrant
My recent patch to include/xen/interface/io/netif.h defines a new extra info type that can be used to pass toeplitz hash values between backend and VM frontend. This patch adds code to xen-netback to pass hash values calculated for receive-side packets to the VM frontend. Signed-off-by: Paul Durr

[Xen-devel] [PATCH net-next v1 5/8] xen-netback: add support for the control ring

2016-02-12 Thread Paul Durrant
My recent patch to include/xen/interface/io/netif.h defines a new shared ring (in addition to the rx and tx rings) for passing control messages from a VM frontend driver to a backend driver. This patch adds the necessary code to xen-netback to map this new shared ring, should it be created by a fr

[Xen-devel] [PATCH net-next v1 4/8] xen-netback: reduce log spam

2016-02-12 Thread Paul Durrant
Remove the "prepare for reconnect" pr_info in xenbus.c. It's largely uninteresting and the states of the frontend and backend can easily be observed by watching the (o)xenstored log. Signed-off-by: Paul Durrant Cc: Ian Campbell Cc: Wei Liu --- drivers/net/xen-netback/xenbus.c | 2 -- 1 file ch

[Xen-devel] [PATCH net-next v1 3/8] xen-netback: support multiple extra info fragments passed from frontend

2016-02-12 Thread Paul Durrant
The code does not currently support a frontend passing multiple extra info fragments to the backend in a tx request. The xenvif_get_extras() function handles multiple extra_info fragments but make_tx_response() assumes there is only ever a single extra info fragment. This patch modifies xenvif_get

Re: [Xen-devel] [PATCH v2 2/2] vm_event: consolidate hvm_event_fill_regs and p2m_vm_event_fill_regs

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 11:19, wrote: > On 02/12/2016 11:57 AM, Jan Beulich wrote: > On 12.02.16 at 01:22, wrote: >>> --- a/xen/arch/x86/vm_event.c >>> +++ b/xen/arch/x86/vm_event.c >>> @@ -122,6 +122,65 @@ void vm_event_set_registers(struct vcpu *v, > vm_event_response_t *rsp) >>> v->arch.u

Re: [Xen-devel] [PATCH v2 2/2] xen: credit1: avoid boosting vCPUs being "just" migrated

2016-02-12 Thread Dario Faggioli
On Fri, 2016-02-12 at 02:50 -0700, Jan Beulich wrote: > > > > On 12.02.16 at 10:37, wrote: > > @@ -787,6 +788,16 @@ _csched_cpu_pick(const struct scheduler *ops, > > struct vcpu *vc, bool_t commit) > >  static int > >  csched_cpu_pick(const struct scheduler *ops, struct vcpu *vc) > >  { > > +s

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Andrew Cooper
On 12/02/16 10:12, Jan Beulich wrote: On 12.02.16 at 11:02, wrote: >> On 12/02/16 10:00, Jan Beulich wrote: >> On 12.02.16 at 10:51, wrote: On 12/02/16 08:23, Jan Beulich wrote: On 11.02.16 at 20:25, wrote: >> CentOS 7 gets into trouble when compiling Xen citing: >

Re: [Xen-devel] [PATCH] libxl: fix handling returns in libxl_get_version_info()

2016-02-12 Thread Harmandeep Kaur
On Thu, Feb 11, 2016 at 3:18 PM, Dario Faggioli wrote: > Hi Harmandeep, > > So, I think the code in this patch is ok. Still, a few comments... > > On Thu, 2016-02-11 at 14:00 +0530, Harmandeep Kaur wrote: >> Avoid handling issue of the return value of xc_version() in many >> cases. >> > This can b

Re: [Xen-devel] [PATCH net-next v1 0/8] xen-netback: support toeplitz hashing

2016-02-12 Thread David Miller
From: Paul Durrant Date: Fri, 12 Feb 2016 10:13:17 + > This patch series adds support for frontend-configurable toeplitz hashing > in xen-netback (on the guest receive side). This support has been testing > against a Windows frontend and has proven to be sufficient to pass the > Microsoft HCK

[Xen-devel] [qemu-upstream-4.5-testing test] 81790: regressions - FAIL

2016-02-12 Thread osstest service owner
flight 81790 qemu-upstream-4.5-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/81790/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64 9 debian-hvm-install fail REGR. vs. 77858 te

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 11:50, wrote: > On 12/02/16 10:12, Jan Beulich wrote: > On 12.02.16 at 11:02, wrote: >>> On 12/02/16 10:00, Jan Beulich wrote: >>> On 12.02.16 at 10:51, wrote: > On 12/02/16 08:23, Jan Beulich wrote: > On 11.02.16 at 20:25, wrote: >>> CentOS 7 gets int

Re: [Xen-devel] [PATCH] libxl: fix handling returns in libxl_get_version_info()

2016-02-12 Thread Dario Faggioli
On Fri, 2016-02-12 at 16:22 +0530, Harmandeep Kaur wrote: > On Thu, Feb 11, 2016 at 3:18 PM, Dario Faggioli > wrote: > >  > > Another thing that you should check, and probably quickly mention > > too, > > is whether or not the callers of these functions --the ones inside > > xen.git of course-- ar

Re: [Xen-devel] [PATCH] libxl: fix handling returns in libxl_get_version_info()

2016-02-12 Thread Harmandeep Kaur
On Fri, Feb 12, 2016 at 4:30 PM, Dario Faggioli wrote: > On Fri, 2016-02-12 at 16:22 +0530, Harmandeep Kaur wrote: >> On Thu, Feb 11, 2016 at 3:18 PM, Dario Faggioli >> wrote: >> > >> > Another thing that you should check, and probably quickly mention >> > too, >> > is whether or not the callers

Re: [Xen-devel] Anyone know where the official qemu(1) man pages are hosted?

2016-02-12 Thread Stefano Stabellini
On Fri, 12 Feb 2016, Lars Kurth wrote: > I noticed that the qemu(1) links in > http://xenbits.xen.org/docs/unstable/man/xl.cfg.5.html (and probably other > docs) are broken. They go to http://man.he.net/man1/qemu, which does not > exist any more It doesn't look like QEMU maintains a traditional

Re: [Xen-devel] [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available"

2016-02-12 Thread Andrew Cooper
On 12/02/16 10:57, Jan Beulich wrote: On 12.02.16 at 11:50, wrote: >> On 12/02/16 10:12, Jan Beulich wrote: >> On 12.02.16 at 11:02, wrote: On 12/02/16 10:00, Jan Beulich wrote: On 12.02.16 at 10:51, wrote: >> On 12/02/16 08:23, Jan Beulich wrote: >> On 11.02.1

Re: [Xen-devel] [PATCH net-next v1 0/8] xen-netback: support toeplitz hashing

2016-02-12 Thread Paul Durrant
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of David Miller > Sent: 12 February 2016 10:54 > To: Paul Durrant > Cc: net...@vger.kernel.org; xen-de...@lists.xenproject.org > Subject: Re: [PATCH net-next v1 0/8] xen-netback: sup

[Xen-devel] [PATCH v3] libxc: fix leak of t_info in xc_tbuf_get_size()

2016-02-12 Thread Harmandeep Kaur
Avoid leaking the memory mapping of the trace buffer Coverity ID 1351228 Signed-off-by: Harmandeep Kaur Reviewed-by: Dario Faggioli --- v2: call to unmapping function reduced to one from two v3: passed correct argument sysctl.u.tbuf_op.size in xenforeignmemory_unmap() --- tools/libxc/xc_t

Re: [Xen-devel] [PATCH] libxl: fix handling returns in libxl_get_version_info()

2016-02-12 Thread Dario Faggioli
On Fri, 2016-02-12 at 16:34 +0530, Harmandeep Kaur wrote: > On Fri, Feb 12, 2016 at 4:30 PM, Dario Faggioli > wrote: > >  > Sorry I actually meant, > tools/libxl/xl_cmdimpl.c:vinfo = libxl_get_version_info(ctx); > > vinfo = libxl_get_version_info(ctx); > if (vinfo) { > Which again checks

Re: [Xen-devel] [PATCH v3 2/5] arm/config: Declare ELFSIZE_[32|64] respectively.

2016-02-12 Thread Stefano Stabellini
On Thu, 11 Feb 2016, Konrad Rzeszutek Wilk wrote: > Otherwise any code that tries to use Elf_* macros instead of > Elf32_ or Elf_64 fails to compile. > > CC: ian.campb...@citrix.com > CC: wei.l...@citrix.com > CC: stefano.stabell...@citrix.com > Signed-off-by: Konrad Rzeszutek Wilk > --- > xen/i

[Xen-devel] [PATCH v2] libxl: fix handling of returns in libxl_get_version_info()

2016-02-12 Thread Harmandeep Kaur
Check the return value of xc_version() and return NULL if it fails. libxl_get_version_info() can also return NULL now. Callers of the function libxl_get_version_info() are already prepared to deal with returning NULL on failure of xc_version(). Coverity ID 1351217 Signed-off-by: Harmandeep Kaur

Re: [Xen-devel] [PATCH v3 1/5] hypervisor/arm/keyhandler: Declare struct cpu_user_regs;

2016-02-12 Thread Stefano Stabellini
On Thu, 11 Feb 2016, Konrad Rzeszutek Wilk wrote: > in the keyhandler.h file. Otherwise on ARM builds if we > just use the keyhandler file - the compile will fail. > > CC: ian.campb...@citrix.com > CC: wei.l...@citrix.com > CC: stefano.stabell...@citrix.com > Signed-off-by: Konrad Rzeszutek Wilk

Re: [Xen-devel] [PATCH v4 01/17] Xen: ACPI: Hide UART used by Xen

2016-02-12 Thread Stefano Stabellini
On Thu, 11 Feb 2016, Rafael J. Wysocki wrote: > On Thursday, February 11, 2016 04:04:14 PM Stefano Stabellini wrote: > > On Wed, 10 Feb 2016, Rafael J. Wysocki wrote: > > > On Tuesday, February 09, 2016 11:19:02 AM Stefano Stabellini wrote: > > > > On Mon, 8 Feb 2016, Rafael J. Wysocki wrote: > > >

[Xen-devel] [xen-unstable-smoke test] 82125: tolerable all pass - PUSHED

2016-02-12 Thread osstest service owner
flight 82125 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/82125/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

Re: [Xen-devel] [PATCH] vm_event: Remove xc_mem_access_enable_emulate() and friends

2016-02-12 Thread Wei Liu
On Fri, Feb 12, 2016 at 11:04:34AM +0200, Razvan Cojocaru wrote: > xc_mem_access_enable_emulate() and xc_mem_access_disable_emulate() > are currently no-ops, that is all they do is set a flag that > nobody else checks. The user can already set the EMULATE flags in > the vm_event response if emulati

Re: [Xen-devel] [PATCH v3 1/5] hypervisor/arm/keyhandler: Declare struct cpu_user_regs;

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 12:37, wrote: > On Thu, 11 Feb 2016, Konrad Rzeszutek Wilk wrote: >> --- a/xen/include/xen/keyhandler.h >> +++ b/xen/include/xen/keyhandler.h >> @@ -19,6 +19,7 @@ >> */ >> typedef void (keyhandler_fn_t)(unsigned char key); >> >> +struct cpu_user_regs; >> /* >> * Callback

Re: [Xen-devel] [PATCH v2 3/6] xen: factor out allocation of page tables into separate function

2016-02-12 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 11.02.2016 13:53, Juergen Gross wrote: > On 11/02/16 13:27, Daniel Kiper wrote: >> On Thu, Feb 11, 2016 at 08:53:23AM +0100, Juergen Gross wrote: >>> Do the allocation of page tables in a separate function. This will >>> allow to do the allocation at different times of the boot preparations >>>

Re: [Xen-devel] [PATCH v2 4/6] xen: add capability to load initrd outside of initial mapping

2016-02-12 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 11.02.2016 15:13, Juergen Gross wrote: > On 11/02/16 13:33, Daniel Kiper wrote: >> On Thu, Feb 11, 2016 at 08:53:24AM +0100, Juergen Gross wrote: >>> Modern pvops linux kernels support an initrd not covered by the initial >>> mapping. This capability is flagged by an elf-note. >>> >>> In case th

Re: [Xen-devel] [PATCH v2] libxl: fix handling of returns in libxl_get_version_info()

2016-02-12 Thread Wei Liu
On Fri, Feb 12, 2016 at 05:00:40PM +0530, Harmandeep Kaur wrote: > Check the return value of xc_version() and return NULL if it > fails. libxl_get_version_info() can also return NULL now. > Callers of the function libxl_get_version_info() are already > prepared to deal with returning NULL on failur

Re: [Xen-devel] [PATCH v3] libxc: fix leak of t_info in xc_tbuf_get_size()

2016-02-12 Thread Wei Liu
On Fri, Feb 12, 2016 at 04:38:32PM +0530, Harmandeep Kaur wrote: > Avoid leaking the memory mapping of the trace buffer > > Coverity ID 1351228 > > Signed-off-by: Harmandeep Kaur > Reviewed-by: Dario Faggioli Acked-by: Wei Liu Thanks ___ Xen-devel

Re: [Xen-devel] [PATCH v3 1/5] hypervisor/arm/keyhandler: Declare struct cpu_user_regs;

2016-02-12 Thread Stefano Stabellini
On Fri, 12 Feb 2016, Jan Beulich wrote: > >>> On 12.02.16 at 12:37, wrote: > > On Thu, 11 Feb 2016, Konrad Rzeszutek Wilk wrote: > >> --- a/xen/include/xen/keyhandler.h > >> +++ b/xen/include/xen/keyhandler.h > >> @@ -19,6 +19,7 @@ > >> */ > >> typedef void (keyhandler_fn_t)(unsigned char key);

Re: [Xen-devel] [PATCH v2 2/2] vm_event: consolidate hvm_event_fill_regs and p2m_vm_event_fill_regs

2016-02-12 Thread Lengyel, Tamas
On Feb 12, 2016 03:41, "Jan Beulich" wrote: > > >>> On 12.02.16 at 11:19, wrote: > > On 02/12/2016 11:57 AM, Jan Beulich wrote: > > On 12.02.16 at 01:22, wrote: > >>> --- a/xen/arch/x86/vm_event.c > >>> +++ b/xen/arch/x86/vm_event.c > >>> @@ -122,6 +122,65 @@ void vm_event_set_registers(stru

Re: [Xen-devel] [PATCH v2 1/2] hvm/vmx: save dr7 during vmx_vmcs_save

2016-02-12 Thread Lengyel, Tamas
On Feb 12, 2016 02:12, "Jan Beulich" wrote: > > >>> On 12.02.16 at 01:22, wrote: > > Sending the dr7 register during vm_events is useful for various applications, > > but the current way the register value is gathered is incorrent. In this > > patch > > we extend vmx_vmcs_save so that we get the

Re: [Xen-devel] [PATCH v4 01/17] Xen: ACPI: Hide UART used by Xen

2016-02-12 Thread Rafael J. Wysocki
On Fri, Feb 12, 2016 at 12:50 PM, Stefano Stabellini wrote: > On Thu, 11 Feb 2016, Rafael J. Wysocki wrote: >> On Thursday, February 11, 2016 04:04:14 PM Stefano Stabellini wrote: >> > On Wed, 10 Feb 2016, Rafael J. Wysocki wrote: >> > > On Tuesday, February 09, 2016 11:19:02 AM Stefano Stabellini

Re: [Xen-devel] [PATCH v2] libxl: fix handling of returns in libxl_get_version_info()

2016-02-12 Thread Dario Faggioli
On Fri, 2016-02-12 at 12:31 +, Wei Liu wrote: > On Fri, Feb 12, 2016 at 05:00:40PM +0530, Harmandeep Kaur wrote: > >  > > +info->xen_version_major = r >> 16; > > +info->xen_version_minor = r & 0xFF; > >   > > -xc_version(ctx->xch, XENVER_extraversion, &u.xen_extra); > > +r = xc_

Re: [Xen-devel] [PATCH v3 1/5] hypervisor/arm/keyhandler: Declare struct cpu_user_regs;

2016-02-12 Thread Konrad Rzeszutek Wilk
On Fri, Feb 12, 2016 at 01:51:28AM -0700, Jan Beulich wrote: > >>> On 12.02.16 at 04:08, wrote: > > in the keyhandler.h file. Otherwise on ARM builds if we > > just use the keyhandler file - the compile will fail. > > > > CC: ian.campb...@citrix.com > > CC: wei.l...@citrix.com > > CC: stefano.s

Re: [Xen-devel] xl dev-detach hangs with missing frontends

2016-02-12 Thread Wei Liu
CC'ing other tools maintainer. On Thu, Feb 11, 2016 at 11:37:49AM +0100, Olaf Hering wrote: > How should libxl__initiate_device_generic_remove deal with devices which I think you meant libxl__initiate_device_remove. There is no function called libxl__initiate_device_generic _remove. > have no fr

Re: [Xen-devel] [PATCH v3 3/5] build: remove .config from /boot when uninstalling.

2016-02-12 Thread Doug Goldstein
On 2/11/16 9:08 PM, Konrad Rzeszutek Wilk wrote: > c/s 361b4f9f0f0d4adc19df428e224a7b8fa62cd392 > "build: save generated xen .config" forgot to remove > the config file when uninstalling. > > CC: ian.campb...@citrix.com > CC: jbeul...@suse.com > CC: car...@cardoe.com > CC: ian.jack...@eu.citrix.co

Re: [Xen-devel] [PATCH v2 2/2] xen: credit1: avoid boosting vCPUs being "just" migrated

2016-02-12 Thread Dario Faggioli
[Yes, replying to myself] On Fri, 2016-02-12 at 11:50 +0100, Dario Faggioli wrote: > On Fri, 2016-02-12 at 02:50 -0700, Jan Beulich wrote: > > > > > On 12.02.16 at 10:37, wrote: > > > @@ -787,6 +788,16 @@ _csched_cpu_pick(const struct scheduler > > > *ops, > > > struct vcpu *vc, bool_t commit) >

Re: [Xen-devel] [PATCH v3 2/5] arm/config: Declare ELFSIZE_[32|64] respectively.

2016-02-12 Thread Konrad Rzeszutek Wilk
On Fri, Feb 12, 2016 at 11:26:10AM +, Stefano Stabellini wrote: > On Thu, 11 Feb 2016, Konrad Rzeszutek Wilk wrote: > > Otherwise any code that tries to use Elf_* macros instead of > > Elf32_ or Elf_64 fails to compile. > > > > CC: ian.campb...@citrix.com > > CC: wei.l...@citrix.com > > CC: st

Re: [Xen-devel] [PATCH v2 4/6] xen: add capability to load initrd outside of initial mapping

2016-02-12 Thread Juergen Gross
On 12/02/16 13:24, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 11.02.2016 15:13, Juergen Gross wrote: >> On 11/02/16 13:33, Daniel Kiper wrote: >>> On Thu, Feb 11, 2016 at 08:53:24AM +0100, Juergen Gross wrote: Modern pvops linux kernels support an initrd not covered by the initial

[Xen-devel] [distros-debian-jessie test] 38740: tolerable all pass

2016-02-12 Thread Platform Team regression test user
flight 38740 distros-debian-jessie real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/38740/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-armhf-jessie-netboot-pygrub 12 saverestore-support-check fail never pass test-armhf-ar

Re: [Xen-devel] xl dev-detach hangs with missing frontends

2016-02-12 Thread Olaf Hering
On Fri, Feb 12, Wei Liu wrote: > CC'ing other tools maintainer. > > On Thu, Feb 11, 2016 at 11:37:49AM +0100, Olaf Hering wrote: > > How should libxl__initiate_device_generic_remove deal with devices which > > I think you meant libxl__initiate_device_remove. There is no function > called libxl__

Re: [Xen-devel] [PATCH v3 1/5] hypervisor/arm/keyhandler: Declare struct cpu_user_regs;

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 13:46, wrote: > On Fri, 12 Feb 2016, Jan Beulich wrote: >> and then this is the "include everything everywhere" attitude >> which tends to needlessly slow down builds (avoiding the need >> to include everything everywhere is actually one of the >> purposes of such forward declar

[Xen-devel] [COVERITY ACCESS] Request for access to Coverity

2016-02-12 Thread Stefano Stabellini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I agree to the conditions in the XenProject Coverity contribution guidelines [0]. I'm a developer working for Citrix Systems UK, Ltd. I've been active in the Xen community since 2008; I currently maintain Xen on ARM, Xen support for the ARM and ARM64

Re: [Xen-devel] [PATCH v3 1/5] hypervisor/arm/keyhandler: Declare struct cpu_user_regs;

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 15:06, wrote: > On Fri, Feb 12, 2016 at 01:51:28AM -0700, Jan Beulich wrote: >> >>> On 12.02.16 at 04:08, wrote: >> > in the keyhandler.h file. Otherwise on ARM builds if we >> > just use the keyhandler file - the compile will fail. >> > >> > CC: ian.campb...@citrix.com >> >

Re: [Xen-devel] [COVERITY ACCESS] Request for access to Coverity

2016-02-12 Thread Andrew Cooper
On 12/02/16 14:53, Stefano Stabellini wrote: > I agree to the conditions in the XenProject Coverity contribution > guidelines [0]. > > I'm a developer working for Citrix Systems UK, Ltd. I've been active > in the Xen community since 2008; I currently maintain Xen on ARM, Xen > support for the ARM

Re: [Xen-devel] [PATCH v2 2/2] vm_event: consolidate hvm_event_fill_regs and p2m_vm_event_fill_regs

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 13:50, wrote: > On Feb 12, 2016 03:41, "Jan Beulich" wrote: >> In which case ASSERT(is_hvm_vcpu(curr)) would be the common >> way to document this (at once avoiding the open coding of >> is_hvm_vcpu()). >> > > I don't think we need an assert here. The function is fine for pv g

[Xen-devel] [qemu-upstream-4.6-testing test] 81798: regressions - FAIL

2016-02-12 Thread osstest service owner
flight 81798 qemu-upstream-4.6-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/81798/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 9 debian-hvm-install fail REGR. vs. 77722 t

Re: [Xen-devel] [PATCH v2 2/6] relocator: Do not use memory region if its starta is smaller than size

2016-02-12 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Applied, thanks On 20.07.2015 16:35, Daniel Kiper wrote: > malloc_in_range() should not use memory region if its starta is smaller > than size. Otherwise target wraps around and points to region which is > usually not a RAM, e.g.: > > loader/multiboot.c:93: segment 0: paddr=0x80, memsz=0x3f800

[Xen-devel] [PATCH] xen/x86: Fix errors arising from c/s dab76ff

2016-02-12 Thread Andrew Cooper
Coverity correctly identifies that the changes in mtrr_attrib_to_str() introduce dead code. strings[] is a 2d array, rather than an array of strings, which means that strings[x] will never be a NULL pointer. Adjust the check to compenstate, by looking for a NUL in strings[x][0] instead. Curiousl

Re: [Xen-devel] [PATCH v2 1/2] hvm/vmx: save dr7 during vmx_vmcs_save

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 13:57, wrote: > On Feb 12, 2016 02:12, "Jan Beulich" wrote: >> >> >>> On 12.02.16 at 01:22, wrote: >> > Sending the dr7 register during vm_events is useful for various > applications, >> > but the current way the register value is gathered is incorrent. In this >> > patch >> >

Re: [Xen-devel] [PATCH v3 2/5] arm/config: Declare ELFSIZE_[32|64] respectively.

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 15:17, wrote: > --- a/xen/include/asm-arm/config.h > +++ b/xen/include/asm-arm/config.h > @@ -15,8 +15,10 @@ > > #if defined(CONFIG_ARM_64) > # define LONG_BYTEORDER 3 > +# define ELFSIZE 64 > #else > # define LONG_BYTEORDER 2 > +# define ELFSIZE 64 > #endif Leaving the

Re: [Xen-devel] [PATCH] xen/x86: Fix errors arising from c/s dab76ff

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 15:59, wrote: > Coverity correctly identifies that the changes in mtrr_attrib_to_str() > introduce dead code. strings[] is a 2d array, rather than an array of > strings, which means that strings[x] will never be a NULL pointer. > > Adjust the check to compenstate, by looking f

Re: [Xen-devel] [PATCH] xen/x86: Fix errors arising from c/s dab76ff

2016-02-12 Thread Andrew Cooper
On 12/02/16 15:13, Jan Beulich wrote: On 12.02.16 at 15:59, wrote: >> Coverity correctly identifies that the changes in mtrr_attrib_to_str() >> introduce dead code. strings[] is a 2d array, rather than an array of >> strings, which means that strings[x] will never be a NULL pointer. >> >> Ad

[Xen-devel] Clang tools build

2016-02-12 Thread Andrew Cooper
Hello, Now that Clang 3.5 can build the hypervisor, I was just preparing a patch to README, and encountered this: In file included from xc_altp2m.c:23: In file included from ./xc_private.h:35: In file included from ./include/xenctrl.h:53: /local/xen.git/tools/libxc/../../tools/include/xen/foreign

Re: [Xen-devel] [PATCH v3 2/5] arm/config: Declare ELFSIZE_[32|64] respectively.

2016-02-12 Thread Stefano Stabellini
On Fri, 12 Feb 2016, Jan Beulich wrote: > >>> On 12.02.16 at 15:17, wrote: > > --- a/xen/include/asm-arm/config.h > > +++ b/xen/include/asm-arm/config.h > > @@ -15,8 +15,10 @@ > > > > #if defined(CONFIG_ARM_64) > > # define LONG_BYTEORDER 3 > > +# define ELFSIZE 64 > > #else > > # define LON

Re: [Xen-devel] [COVERITY ACCESS] Request for access to Coverity

2016-02-12 Thread Konrad Rzeszutek Wilk
On Fri, Feb 12, 2016 at 02:53:21PM +, Stefano Stabellini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > I agree to the conditions in the XenProject Coverity contribution > guidelines [0]. +1 > > I'm a developer working for Citrix Systems UK, Ltd. I've been active > in the Xen

Re: [Xen-devel] [PATCH v3 2/5] arm/config: Declare ELFSIZE_[32|64] respectively.

2016-02-12 Thread Konrad Rzeszutek Wilk
On Fri, Feb 12, 2016 at 03:26:14PM +, Stefano Stabellini wrote: > On Fri, 12 Feb 2016, Jan Beulich wrote: > > >>> On 12.02.16 at 15:17, wrote: > > > --- a/xen/include/asm-arm/config.h > > > +++ b/xen/include/asm-arm/config.h > > > @@ -15,8 +15,10 @@ > > > > > > #if defined(CONFIG_ARM_64) >

Re: [Xen-devel] [PATCH v3 2/5] arm/config: Declare ELFSIZE_[32|64] respectively.

2016-02-12 Thread Stefano Stabellini
On Fri, 12 Feb 2016, Konrad Rzeszutek Wilk wrote: > On Fri, Feb 12, 2016 at 03:26:14PM +, Stefano Stabellini wrote: > > On Fri, 12 Feb 2016, Jan Beulich wrote: > > > >>> On 12.02.16 at 15:17, wrote: > > > > --- a/xen/include/asm-arm/config.h > > > > +++ b/xen/include/asm-arm/config.h > > > > @

Re: [Xen-devel] Clang tools build

2016-02-12 Thread Jan Beulich
>>> On 12.02.16 at 16:25, wrote: > Hello, > > Now that Clang 3.5 can build the hypervisor, I was just preparing a > patch to README, and encountered this: > > In file included from xc_altp2m.c:23: > In file included from ./xc_private.h:35: > In file included from ./include/xenctrl.h:53: > /local

Re: [Xen-devel] Clang tools build

2016-02-12 Thread Andrew Cooper
On 12/02/16 16:04, Jan Beulich wrote: On 12.02.16 at 16:25, wrote: >> Hello, >> >> Now that Clang 3.5 can build the hypervisor, I was just preparing a >> patch to README, and encountered this: >> >> In file included from xc_altp2m.c:23: >> In file included from ./xc_private.h:35: >> In file i

Re: [Xen-devel] [PATCH v2 05/30] xen/public: Export cpu featureset information in the public API

2016-02-12 Thread Jan Beulich
>>> On 05.02.16 at 14:41, wrote: > +/* Intel-defined CPU features, CPUID level 0x0001.edx, word 0 */ > +#define X86_FEATURE_FPU ( 0*32+ 0) /* Onboard FPU */ Regardless of you limiting the interface to tools only, I'm not convinced exposing constants starting with X86_* here is app

[Xen-devel] [PATCH v3 0/2] xen: sched: Credit1 shouldn't boost vcpus being migrated.

2016-02-12 Thread Dario Faggioli
Hi, take 3 of this series. Only change wrt v2 is the atomic-safeness fix in patch 2. While there, I've also added a comment about the need for such atomic-safeness when accessing Credit1's svc->flags. History is here: v2: http://lists.xenproject.org/archives/html/xen-devel/2016-02/msg01750.htm

[Xen-devel] [PATCH v3 1/2] xen: credit1: trace vCPU boost/unboost

2016-02-12 Thread Dario Faggioli
Add tracepoints and a performance counter for boosting and unboosting in Credit1. Note that they (the trace points) do not cover the case of the idle vCPU being boosted to run a tasklet, as there already is TRC_CSCHED_SCHED_TASKLET for that. Signed-off-by: Dario Faggioli --- Cc: George Dunlap

[Xen-devel] [PATCH v3 2/2] xen: credit1: avoid boosting vCPUs being "just" migrated

2016-02-12 Thread Dario Faggioli
Moving a vCPU to a different pCPU means offlining it and then waking it up, on the new pCPU. Credit1 grants BOOST priority to vCPUs that wakes up, with the aim of improving I/O latency. The net effect of this all is that vCPUs get boosted when migrating, which shouldn't happen. For instance, this

Re: [Xen-devel] [PATCH v2 06/30] xen/x86: Script to automatically process featureset information

2016-02-12 Thread Jan Beulich
>>> On 05.02.16 at 14:41, wrote: > This script consumes include/public/arch-x86/cpufeatureset.h and generates a > single include/asm-x86/cpuid-autogen.h containing all the processed > information. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich albeit ... > --- /dev/null > +++ b/xen/to

Re: [Xen-devel] [PATCH v2 07/30] xen/x86: Collect more cpuid feature leaves

2016-02-12 Thread Jan Beulich
>>> On 05.02.16 at 14:42, wrote: > New words are: > * 0x8007.edx - Contains Invarient TSC > * 0x8008.ebx - Newly used for AMD Zen processors > > In addition, replace some open-coded ITSC and EFRO manipulation. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich

[Xen-devel] [ovmf test] 81861: regressions - FAIL

2016-02-12 Thread osstest service owner
flight 81861 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/81861/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 17 guest-start/debianhvm.repeat fail REGR. vs. 65543 version targeted

Re: [Xen-devel] [PATCH net-next v1 0/8] xen-netback: support toeplitz hashing

2016-02-12 Thread David Miller
From: Paul Durrant Date: Fri, 12 Feb 2016 11:07:50 + > Windows *requires* use of Teoplitz so your position completely rules > out being able to support receive side scaling in Windows PV > frontends on Linux kernel backends, not only for Xen but for any > other hypervisor, which I think is to

  1   2   >