Avoid leaking the memory mapping of the trace buffer
Coverity ID 1351228
Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com>
Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com>
---
v2: call to unmapping function reduced to one from two
v3: passed correct argument sysctl.u.tbuf_op.size in
xenforeignmemory_unmap()
---
tools/libxc/xc_tbuf.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tools/libxc/xc_tbuf.c b/tools/libxc/xc_tbuf.c
index 695939a..283fbd1 100644
--- a/tools/libxc/xc_tbuf.c
+++ b/tools/libxc/xc_tbuf.c
@@ -70,11 +70,13 @@ int xc_tbuf_get_size(xc_interface *xch, unsigned long *size)
sysctl.u.tbuf_op.buffer_mfn);
if ( t_info == NULL || t_info->tbuf_size == 0 )
- return -1;
+ rc = -1;
+ else
+ *size = t_info->tbuf_size;
- *size = t_info->tbuf_size;
+ xenforeignmemory_unmap(xch->fmem, t_info, sysctl.u.tbuf_op.size);
- return 0;
+ return rc;
}
int xc_tbuf_enable(xc_interface *xch, unsigned long pages, unsigned long *mfn,
--
2.5.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
