Re: [Xen-devel] [PATCH v2 09/16] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI

2016-01-19 Thread Shannon Zhao
On 2016/1/18 22:38, Stefano Stabellini wrote: > On Fri, 15 Jan 2016, Shannon Zhao wrote: >> From: Shannon Zhao >> >> When booting with ACPI, it could get the event-channel irq through >> HVM_PARAM_CALLBACK_IRQ. >> >> Signed-off-by: Shannon Zhao >> --- >> arch/arm/xen/enlighten.c | 30 +

Re: [Xen-devel] [PATCH v2 5/5] libxl: Add explicit cast to libxl_psr_cat_set_cbm

2016-01-19 Thread Dario Faggioli
On Tue, 2016-01-19 at 00:58 -0500, Chester Lin wrote: > Fixes Coverity CID 1343299. The call to xc_psr_cat_set_domain_data() > expects type xc_psr_cat_type but is provided libxl_psr_cbm_type which > is defined in IDL. > > The two enums are deliberately identical and IDL only exists so that > libxl

Re: [Xen-devel] [PATCH v2 10/16] ARM: XEN: Move xen_early_init() before efi_init()

2016-01-19 Thread Shannon Zhao
On 2016/1/18 22:59, Stefano Stabellini wrote: > On Fri, 15 Jan 2016, Shannon Zhao wrote: >> From: Shannon Zhao >> >> Move xen_early_init() before efi_init(), then when calling efi_init() >> could initialize Xen specific UEFI. >> >> Check if it runs on Xen hypervisor through the flat dts. >> >> S

Re: [Xen-devel] [PATCH v4 09/10] arm/uart: Rename dt-uart.c to arm-uart.c

2016-01-19 Thread Jan Beulich
>>> On 19.01.16 at 04:36, wrote: > > On 2016/1/18 18:40, Jan Beulich wrote: > On 16.01.16 at 06:01, wrote: >>> > From: Shannon Zhao >>> > >>> > Since we will add ACPI initialization for UART in this file later, >>> > rename it with a generic name. >>> > >>> > Signed-off-by: Shannon Zhao

[Xen-devel] [PATCH V13 0/5] xen pvusb toolstack work

2016-01-19 Thread Chunyan Liu
This patch series is to add pvusb toolstack work, supporting hot add|remove USB device to|from guest and specify USB device in domain configuration file. Changes to V12: * update error handlings in libxl pvusb API (patch 3/5) * adjust order of patch 4/5 and 5/5, and in 5/5, reuse documentation g

[Xen-devel] [PATCH V13 2/5] libxl_utils: add internal function to read sysfs file contents

2016-01-19 Thread Chunyan Liu
Add a new function libxl_read_sysfs_file_contents to handle sysfs file specially. It would be used in later pvusb work. Signed-off-by: Chunyan Liu Acked-by: Ian Jackson --- tools/libxl/libxl_internal.h | 4 +++ tools/libxl/libxl_utils.c| 74 2 f

[Xen-devel] [PATCH V13 4/5] domcreate: support pvusb in configuration file

2016-01-19 Thread Chunyan Liu
Add code to support pvusb in domain config file. One could specify usbctrl and usb in domain's configuration file and create domain, then usb controllers will be created and usb device would be attached to guest automatically. One could specify usb controllers and usb devices in config file like t

[Xen-devel] [PATCH V13 1/5] libxl: export some functions for pvusb use

2016-01-19 Thread Chunyan Liu
Signed-off-by: Chunyan Liu Signed-off-by: Simon Cao Reviewed-by: Wei Liu Acked-by: Ian Jackson --- tools/libxl/libxl.c | 5 ++--- tools/libxl/libxl_internal.h | 3 +++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 00d9ec

[Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-01-19 Thread Chunyan Liu
Add pvusb commands: usbctrl-attach, usbctrl-detach, usb-list, usbdev-attach and usbdev-detach. To attach a usb device to guest through pvusb, one could follow following example: #xl usbctrl-attach test_vm version=1 ports=8 #xl usb-list test_vm will show the usb controllers and port usage unde

[Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-01-19 Thread Chunyan Liu
Add pvusb APIs, including: - attach/detach (create/destroy) virtual usb controller. - attach/detach usb device - list usb controller and usb devices - some other helper functions Signed-off-by: Chunyan Liu Signed-off-by: Simon Cao Signed-off-by: George Dunlap --- changes: * address error ha

Re: [Xen-devel] [PATCH v2 11/16] ARM64: ACPI: Check if it runs on Xen to enable or disable ACPI

2016-01-19 Thread Shannon Zhao
On 2016/1/18 23:07, Stefano Stabellini wrote: > On Mon, 18 Jan 2016, Mark Rutland wrote: >> > On Fri, Jan 15, 2016 at 02:55:24PM +0800, Shannon Zhao wrote: >>> > > From: Shannon Zhao >>> > > >>> > > When it's a Xen domain0 booting with ACPI, it will supply a /chosen and >>> > > a /hypervisor no

Re: [Xen-devel] [PATCH] xen: Improvements to clean and distclean targets

2016-01-19 Thread Jan Beulich
>>> On 18.01.16 at 19:19, wrote: > On 18/01/16 16:57, Jan Beulich wrote: > On 18.01.16 at 17:45, wrote: >>> On 18/01/16 16:41, Jan Beulich wrote: >>> On 18.01.16 at 17:27, wrote: > * Move '*~' and 'core' into the find rule. I don't understand this part: Where in the build proces

Re: [Xen-devel] [PATCH v4 09/10] arm/uart: Rename dt-uart.c to arm-uart.c

2016-01-19 Thread Shannon Zhao
On 2016/1/19 16:39, Jan Beulich wrote: On 19.01.16 at 04:36, wrote: >> > >> > On 2016/1/18 18:40, Jan Beulich wrote: >> > On 16.01.16 at 06:01, wrote: > >>> > From: Shannon Zhao > >>> > > >>> > Since we will add ACPI initialization for UART in this file later, >

Re: [Xen-devel] [PATCH v10 6/7] vmx: VT-d posted-interrupt core logic handling

2016-01-19 Thread Wu, Feng
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Monday, January 18, 2016 5:04 PM > To: Wu, Feng > Cc: andrew.coop...@citrix.com; dario.faggi...@citrix.com; > george.dun...@eu.citrix.com; Tian, Kevin ; xen- > de...@lists.xen.org; k...@xen.org > Subject: RE: RE:

Re: [Xen-devel] [PATCH] build: specify minimum versions of make and binutils

2016-01-19 Thread Jan Beulich
>>> On 18.01.16 at 18:21, wrote: > On 1/18/16 11:03 AM, Jan Beulich wrote: > On 18.01.16 at 17:53, wrote: >>> To help people avoid having to figure out what versions of make and >>> binutils need to be supported document them explicitly. The version of >>> binutils that had to be supported wa

Re: [Xen-devel] [PATCH v4 09/10] arm/uart: Rename dt-uart.c to arm-uart.c

2016-01-19 Thread Jan Beulich
>>> On 19.01.16 at 09:43, wrote: > > On 2016/1/19 16:39, Jan Beulich wrote: > On 19.01.16 at 04:36, wrote: >>> > >>> > On 2016/1/18 18:40, Jan Beulich wrote: >>> > On 16.01.16 at 06:01, wrote: >> >>> > From: Shannon Zhao >> >>> > >> >>> > Since we will add ACPI initi

[Xen-devel] [qemu-mainline test] 78421: tolerable FAIL - PUSHED

2016-01-19 Thread osstest service owner
flight 78421 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/78421/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-libvirt-qcow2 9 debian-di-install fail REGR. vs. 78223 test-armhf-armhf-xl-rtds

Re: [Xen-devel] [PATCH v2 2/5] libxl: make GC_FREE reachable in libxl_get_scheduler()

2016-01-19 Thread Dario Faggioli
On Tue, 2016-01-19 at 00:57 -0500, Chester Lin wrote: > Coverity CID 1343309 > > Make GC_FREE reachable in all cases in libxl_get_scheduler() by > eliminating the error-path return and instead storing the error code > in > the returned variable. > > To make this semantically consistent, change th

Re: [Xen-devel] [PATCH v2 1/5] libxl: tidy libxl_get_scheduler() according to CODING_STYLE

2016-01-19 Thread Dario Faggioli
On Tue, 2016-01-19 at 00:57 -0500, Chester Lin wrote: > To more closely follow the guidelines in CODING_STYLE, store the > result > of xc_sched_id() in the local variable r, and the check the result of > the call in a separate statement.  Change the type of the output > parameter given to xc_sched_

Re: [Xen-devel] [PATCH V6 5/5] x86/hvm: pkeys, add pkeys support for cpuid handling

2016-01-19 Thread Wei Liu
On Tue, Jan 19, 2016 at 03:30:59PM +0800, Huaitong Han wrote: > This patch adds pkeys support for cpuid handing. > > Pkeys hardware support is CPUID.7.0.ECX[3]:PKU. software support is > CPUID.7.0.ECX[4]:OSPKE and it reflects the support setting of CR4.PKE. > I will (again) defer this to x86 mai

Re: [Xen-devel] [PATCH v2 1/4] xen/elfnotes: check phys_entry against UNSET_ADDR32

2016-01-19 Thread Wei Liu
On Fri, Jan 15, 2016 at 03:59:40PM +0100, Roger Pau Monne wrote: > And introduce UNSET_ADDR32. > > Signed-off-by: Roger Pau Monné > Acked-by: Jan Beulich > --- > Cc: Ian Jackson > Cc: Ian Campbell > Cc: Wei Liu > --- > Changes since v1: > - Fix commit title. > --- > tools/libxc/xc_dom_elflo

Re: [Xen-devel] Load calculation refresh in credit2 (was in Re: Questions about the use of idle_vcpu[])

2016-01-19 Thread Dario Faggioli
On Mon, 2016-01-18 at 14:12 +, George Dunlap wrote: > [Changing the title to align with the current topic] >  > Load balancing only happens on a reset event; and the frequency of > reset > events will be CREDIT_INIT / (% utilization); so for a system at 1% > utilization that would be once every

Re: [Xen-devel] [PATCH v3 4/4] x86/PV: enable the emulated PIT

2016-01-19 Thread Ian Campbell
On Mon, 2016-01-18 at 18:03 +, Andrew Cooper wrote: > On 18/01/16 17:58, Roger Pau Monné wrote: > > El 18/01/16 a les 11.41, Andrew Cooper ha escrit: > > > On 18/01/16 09:44, Jan Beulich wrote: > > > > > > > On 18.01.16 at 10:29, wrote: > > > > > On 18/01/2016 07:43, Jan Beulich wrote: > > > >

Re: [Xen-devel] [PATCH] INSTALL: fix typo

2016-01-19 Thread Ian Campbell
On Mon, 2016-01-18 at 17:17 -0600, Doug Goldstein wrote: > There's a case of a missing T in the word 'the'. > > Signed-off-by: Doug Goldstein cked + pplied, hanks. Ian. > --- >  INSTALL | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/INSTALL b/INSTALL > index 3d2e86a.

[Xen-devel] [PATCH v10 2/3] Differentiate IO/mem resources tracked by ioreq server

2016-01-19 Thread Yu Zhang
Currently in ioreq server, guest write-protected ram pages are tracked in the same rangeset with device mmio resources. Yet unlike device mmio, which can be in big chunks, the guest write- protected pages may be discrete ranges with 4K bytes each. This patch uses a seperate rangeset for the guest r

[Xen-devel] [PATCH v10 0/3] Refactor ioreq server for better performance.

2016-01-19 Thread Yu Zhang
XenGT leverages ioreq server to track and forward the accesses to GPU I/O resources, e.g. the PPGTT(per-process graphic translation tables). Currently, ioreq server uses rangeset to track the BDF/ PIO/MMIO ranges to be emulated. To select an ioreq server, the rangeset is searched to see if the I/O

[Xen-devel] [PATCH 3/3] tools: introduce parameter max_ranges.

2016-01-19 Thread Yu Zhang
A new parameter - max_ranges is added to set the upper limit of ranges to be tracked inside one ioreq server rangeset. Ioreq server uses a group of rangesets to track the I/O or memory resources to be emulated. The default value of this limit is set to 256. Yet there are circumstances under which

[Xen-devel] [PATCH v10 1/3] Refactor rangeset structure for better performance.

2016-01-19 Thread Yu Zhang
This patch refactors struct rangeset to base it on the red-black tree structure, instead of on the current doubly linked list. By now, ioreq leverages rangeset to keep track of the IO/memory resources to be emulated. Yet when number of ranges inside one ioreq server is very high, traversing a doubl

Re: [Xen-devel] [PATCH] xen: Improvements to clean and distclean targets

2016-01-19 Thread Ian Campbell
On Tue, 2016-01-19 at 01:43 -0700, Jan Beulich wrote: > > > > On 18.01.16 at 19:19, wrote: > > On 18/01/16 16:57, Jan Beulich wrote: > > > > > > On 18.01.16 at 17:45, wrote: > > > > On 18/01/16 16:41, Jan Beulich wrote: > > > > > > > > On 18.01.16 at 17:27, wrote: > > > > > > * Move '*~' and 'co

Re: [Xen-devel] [PATCH] tools/toollog: Drop XTL_NEW_LOGGER()

2016-01-19 Thread Wei Liu
On Thu, Jan 14, 2016 at 08:13:45PM +, Andrew Cooper wrote: > XTL_NEW_LOGGER() makes a number of unreasonable assumptions about the symbols > visible in its scope, and as such is only usable by its sole caller. > > Remove it. > > Signed-off-by: Andrew Cooper Acked-by: Wei Liu _

Re: [Xen-devel] [PATCH] x86: Convert shadow-paging to Kconfig

2016-01-19 Thread Ian Campbell
On Mon, 2016-01-18 at 18:40 +, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper Does this have any impact on migration of either PV or HVM guests? What about nested virt? Are things which are defined in xen/arch/*/Rules.mk in this way overrideable from the old top-level .config or does on

Re: [Xen-devel] [PATCH v10 2/3] Differentiate IO/mem resources tracked by ioreq server

2016-01-19 Thread Paul Durrant
> -Original Message- > From: Yu Zhang [mailto:yu.c.zh...@linux.intel.com] > Sent: 19 January 2016 09:28 > To: xen-devel@lists.xen.org > Cc: Paul Durrant; Stefano Stabellini; Keir (Xen.org); jbeul...@suse.com; > Andrew Cooper; Wei Liu; Kevin Tian; zhiyuan...@intel.com > Subject: [PATCH v10 2

Re: [Xen-devel] [PATCH] xen: Improvements to clean and distclean targets

2016-01-19 Thread Juergen Gross
On 19/01/16 10:38, Ian Campbell wrote: > On Tue, 2016-01-19 at 01:43 -0700, Jan Beulich wrote: > On 18.01.16 at 19:19, wrote: >>> On 18/01/16 16:57, Jan Beulich wrote: >>> On 18.01.16 at 17:45, wrote: > On 18/01/16 16:41, Jan Beulich wrote: > On 18.01.16 at 17:27, wrote:

Re: [Xen-devel] [RFC/WIP] xen: clk: introudce pvclk for device passthrough

2016-01-19 Thread Ian Campbell
On Tue, 2016-01-19 at 10:43 +0800, Peng Fan wrote: > Hello Ian, > > On Mon, Jan 18, 2016 at 12:41:59PM +, Ian Campbell wrote: > > On Mon, 2016-01-18 at 11:24 +, David Vrabel wrote: > > > On 16/01/16 05:22, Peng Fan wrote: > > > > This patch was just a initial patch, not sure whether this w

Re: [Xen-devel] [PATCH v3 4/4] x86/PV: enable the emulated PIT

2016-01-19 Thread Andrew Cooper
On 19/01/16 09:24, Ian Campbell wrote: > On Mon, 2016-01-18 at 18:03 +, Andrew Cooper wrote: >> On 18/01/16 17:58, Roger Pau Monné wrote: >>> El 18/01/16 a les 11.41, Andrew Cooper ha escrit: On 18/01/16 09:44, Jan Beulich wrote: On 18.01.16 at 10:29, wrote: >> On 18/01/2016

Re: [Xen-devel] [PATCH] xen: Improvements to clean and distclean targets

2016-01-19 Thread Ian Campbell
On Tue, 2016-01-19 at 11:06 +0100, Juergen Gross wrote: > On 19/01/16 10:38, Ian Campbell wrote: > > On Tue, 2016-01-19 at 01:43 -0700, Jan Beulich wrote: > > > > > > On 18.01.16 at 19:19, wrote: > > > > On 18/01/16 16:57, Jan Beulich wrote: > > > > > > > > On 18.01.16 at 17:45, wrote: > > > > >

Re: [Xen-devel] [PATCH v2 12/16] ARM: Xen: Document UEFI support on Xen ARM virtual platforms

2016-01-19 Thread Shannon Zhao
On 2016/1/19 1:34, Stefano Stabellini wrote: > On Mon, 18 Jan 2016, Mark Rutland wrote: >> On Fri, Jan 15, 2016 at 02:55:25PM +0800, Shannon Zhao wrote: >>> From: Shannon Zhao >>> >>> Add a "uefi" node under /hypervisor node in FDT, then Linux kernel could >>> scan this to get the UEFI informati

[Xen-devel] [linux-mingo-tip-master test] 78486: regressions - FAIL

2016-01-19 Thread osstest service owner
flight 78486 linux-mingo-tip-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/78486/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-rumpuserxen-i386 10 guest-start fail REGR. vs. 60684 test-amd64

Re: [Xen-devel] [PATCH v3 4/4] x86/PV: enable the emulated PIT

2016-01-19 Thread Ian Campbell
On Tue, 2016-01-19 at 10:09 +, Andrew Cooper wrote: > On 19/01/16 09:24, Ian Campbell wrote: > > On Mon, 2016-01-18 at 18:03 +, Andrew Cooper wrote: > > > On 18/01/16 17:58, Roger Pau Monné wrote: > > > > El 18/01/16 a les 11.41, Andrew Cooper ha escrit: > > > > > On 18/01/16 09:44, Jan Beu

Re: [Xen-devel] [PATCHv5 1/3] rwlock: Add per-cpu reader-writer lock infrastructure

2016-01-19 Thread Malcolm Crossley
On 11/01/16 15:06, Malcolm Crossley wrote: > On 22/12/15 11:56, George Dunlap wrote: >> On 18/12/15 16:08, Malcolm Crossley wrote: >>> >>> + >>> +#ifndef NDEBUG >>> +#define PERCPU_RW_LOCK_UNLOCKED(owner) { RW_LOCK_UNLOCKED, 0, owner } >>> +static inline void _percpu_rwlock_owner_check(percpu_rwlo

Re: [Xen-devel] [PATCH v5 1/6] remus: don't do failover if we don't have an consistent state

2016-01-19 Thread Ian Campbell
On Tue, 2016-01-19 at 15:17 +0800, Wen Congyang wrote: > We will have an consistent state when a CHECKPOINT_END record "a consistent ..." (and in the subject too). > is received. After the first CHECKPOINT_END record is received, > we will buffer all records until the next CHECKPOINT_END record >

Re: [Xen-devel] [PATCH v2 12/16] ARM: Xen: Document UEFI support on Xen ARM virtual platforms

2016-01-19 Thread Mark Rutland
On Tue, Jan 19, 2016 at 06:25:25PM +0800, Shannon Zhao wrote: > > > On 2016/1/19 1:34, Stefano Stabellini wrote: > > On Mon, 18 Jan 2016, Mark Rutland wrote: > >> On Fri, Jan 15, 2016 at 02:55:25PM +0800, Shannon Zhao wrote: > >>> From: Shannon Zhao > >>> > >>> Add a "uefi" node under /hyperviso

Re: [Xen-devel] [PATCH v5 2/6] remus: don't call stream_continue() when doing failover

2016-01-19 Thread Ian Campbell
On Tue, 2016-01-19 at 15:17 +0800, Wen Congyang wrote: > stream_continue() is used for migration to read emulator > xenstore data and emulator context. For remus, if we do > failover, we have read it in the checkpoint cycle, and > we only need to complete the stream. > > Signed-off-by: Wen Congyan

[Xen-devel] [PATCH] xenpm: Add option to report average CPU frequency

2016-01-19 Thread Malcolm Crossley
The average is calculated over the period of time from the last xenpm report of the average CPU frequency. Reporting the average CPU frequency helps confirm the level of turbo boost being achieved per CPU. Signed-off-by: Malcolm Crossley --- tools/misc/xenpm.c | 42 +

Re: [Xen-devel] [PATCH v6 2/5] build: Hook the schedulers into Kconfig

2016-01-19 Thread Dario Faggioli
On Fri, 2016-01-15 at 11:01 -0600, Jonathan Creekmore wrote: > Allow the schedulers to be independently enabled or disabled at > compile-time. To match existing behavior, all four schedulers are > compiled in by default, although the Credit2, RTDS, and ARINC653 are > marked EXPERIMENTAL to match th

Re: [Xen-devel] [PATCH v3 4/4] x86/PV: enable the emulated PIT

2016-01-19 Thread Andrew Cooper
On 19/01/16 10:28, Ian Campbell wrote: > On Tue, 2016-01-19 at 10:09 +, Andrew Cooper wrote: >> On 19/01/16 09:24, Ian Campbell wrote: >>> On Mon, 2016-01-18 at 18:03 +, Andrew Cooper wrote: On 18/01/16 17:58, Roger Pau Monné wrote: > El 18/01/16 a les 11.41, Andrew Cooper ha escri

Re: [Xen-devel] [PATCH v5 3/6] remus: resume immediately if libxl__xc_domain_save_done() completes

2016-01-19 Thread Ian Campbell
On Tue, 2016-01-19 at 15:17 +0800, Wen Congyang wrote: > For example: if the secondary host is down, and we fail to send the data > to > the secondary host. xc_domain_save() returns 0. So in the function > libxl__xc_domain_save_done(), rc is 0 (the helper program exits > normally), > and retval is

Re: [Xen-devel] [PATCH v4 2/5] remus: resume immediately if libxl__xc_domain_save_done() completes

2016-01-19 Thread Ian Campbell
On Tue, 2016-01-19 at 09:01 +0800, Wen Congyang wrote: > On 01/19/2016 12:51 AM, Ian Campbell wrote: > > On Mon, 2016-01-18 at 13:40 +0800, Wen Congyang wrote: > > > For example: if the secondary host is down, and we fail to send the > > > data to > > > the secondary host. xc_domain_save() returns

Re: [Xen-devel] [PATCH] xenpm: Add option to report average CPU frequency

2016-01-19 Thread Ian Campbell
On Tue, 2016-01-19 at 10:50 +, Malcolm Crossley wrote: > The average is calculated over the period of time from the last > xenpm report of the average CPU frequency. > > Reporting the average CPU frequency helps confirm the level of turbo > boost being achieved per CPU. > > Signed-off-by: Mal

Re: [Xen-devel] [PATCH] xenpm: Add option to report average CPU frequency

2016-01-19 Thread Malcolm Crossley
On 19/01/16 11:06, Ian Campbell wrote: > On Tue, 2016-01-19 at 10:50 +, Malcolm Crossley wrote: >> The average is calculated over the period of time from the last >> xenpm report of the average CPU frequency. >> >> Reporting the average CPU frequency helps confirm the level of turbo >> boost be

Re: [Xen-devel] [PATCH v4 10/11] dma: rename dma_*_writecombine() to dma_*_wc()

2016-01-19 Thread Ingo Molnar
* Luis R. Rodriguez wrote: > On Tue, Aug 25, 2015 at 9:21 PM, Ingo Molnar wrote: > > > > * Andrew Morton wrote: > > > >> > There's a catch-22 issue here either way, for instance this rename patch > >> > has > >> > been being baked for probably 2 releases already but the difficulty has > >> >

Re: [Xen-devel] [PATCH v2 01/13] xsplice: Design document (v5).

2016-01-19 Thread Wei Liu
I skimmed this document and managed to do some non-technical nitpicks. :-) On Thu, Jan 14, 2016 at 04:46:59PM -0500, Konrad Rzeszutek Wilk wrote: [...] > +## Patching code > + > +The first mechanism to patch that comes in mind is in-place replacement. > +That is replace the affected code with new

Re: [Xen-devel] [PATCH v2 04/13] libxc: Implementation of XEN_XSPLICE_op in libxc (v4).

2016-01-19 Thread Wei Liu
On Thu, Jan 14, 2016 at 04:47:02PM -0500, Konrad Rzeszutek Wilk wrote: [...] > +int xc_xsplice_upload(xc_interface *xch, > + char *name, > + char *payload, > + uint32_t size) > +{ > +int rc; > +DECLARE_SYSCTL; > +DECLARE_HYP

Re: [Xen-devel] [PATCH v2 05/13] xen-xsplice: Tool to manipulate xsplice payloads (v3)

2016-01-19 Thread Wei Liu
On Thu, Jan 14, 2016 at 04:47:03PM -0500, Konrad Rzeszutek Wilk wrote: [...] > +/* This value was choosen adhoc. It could be 42 too. */ > +#define MAX_LEN 11 > +static int list_func(int argc, char *argv[]) > +{ > +unsigned int idx, done, left, i; > +xen_xsplice_status_t *info = NULL; > +

Re: [Xen-devel] [PATCH v2 10/13] xen_hello_world.xsplice: Test payload for patching 'xen_extra_version'.

2016-01-19 Thread Wei Liu
On Thu, Jan 14, 2016 at 04:47:08PM -0500, Konrad Rzeszutek Wilk wrote: > This change demonstrates how to generate an xSplice ELF payload. > > The idea here is that we want to patch in the hypervisor > the 'xen_version_extra' function with an function that will > return 'Hello World'. The 'xl info

Re: [Xen-devel] [PATCH] xenpm: Add option to report average CPU frequency

2016-01-19 Thread Andrew Cooper
On 19/01/16 10:50, Malcolm Crossley wrote: > @@ -343,10 +348,44 @@ void pxstat_func(int argc, char *argv[]) > show_pxstat_by_cpuid(xc_handle, cpuid); > } > > +static int show_cpufreq_by_cpuid(xc_interface *xc_handle, int cpuid) > +{ > +int ret = 0; > + > +ret = get_avgfreq_by_cp

[Xen-devel] [PATCHv2] xenpm: Add option to report average CPU frequency

2016-01-19 Thread Malcolm Crossley
The average is calculated over the period of time from the last xenpm report of the average CPU frequency. Reporting the average CPU frequency helps confirm the level of turbo boost being achieved per CPU. Signed-off-by: Malcolm Crossley --- tools/misc/xenpm.c | 37 +

Re: [Xen-devel] [PATCH v2 1/5] libxl: tidy libxl_get_scheduler() according to CODING_STYLE

2016-01-19 Thread Wei Liu
Hi Chester What we normally do for new version of patches is to send out a new series prefixed with "PATCH v2", instead of replying to old version of the patches. Could you collect Dario's Reviewed-by tags and send this series as v2. Thanks Wei. ___ X

Re: [Xen-devel] [PATCH v3] xenstat: handle more than 1024 domains

2016-01-19 Thread Ian Campbell
On Fri, 2016-01-15 at 16:22 +, Ian Campbell wrote: > On Fri, 2016-01-15 at 17:07 +0100, Juergen Gross wrote: > > get_domain_ids() in libxenstat used by read_attributes_qdisk() is > > limited to 1024 domains. Remove that limit. > > > > Signed-off-by: Juergen Gross > > --- > > V3: Obey 80 chara

Re: [Xen-devel] [PATCH v7 2/2] public/io/netif.h: document control ring and toeplitz hashing

2016-01-19 Thread Ian Campbell
(Re-adding the list and full quoting since I think that was just a button- o) On Mon, 2016-01-18 at 16:24 +, Paul Durrant wrote: > > -Original Message- > [snip] > > > > I noticed (after trimming the quotes unfortunately) that the request gained > > a data[2] in v5 (as part of handling

Re: [Xen-devel] [PATCH] xenpm: Add option to report average CPU frequency

2016-01-19 Thread Ian Campbell
On Tue, 2016-01-19 at 11:10 +, Malcolm Crossley wrote: > On 19/01/16 11:06, Ian Campbell wrote: > > On Tue, 2016-01-19 at 10:50 +, Malcolm Crossley wrote: > > > The average is calculated over the period of time from the last > > > xenpm report of the average CPU frequency. > > > > > > Repo

Re: [Xen-devel] [PATCH v2 1/5] libxl: tidy libxl_get_scheduler() according to CODING_STYLE

2016-01-19 Thread Ian Campbell
On Tue, 2016-01-19 at 11:28 +, Wei Liu wrote: > Hi Chester > > What we normally do for new version of patches is to send out a new > series prefixed with "PATCH v2", instead of replying to old version of > the patches. > > Could you collect Dario's Reviewed-by tags and send this series as v2.

Re: [Xen-devel] [PATCH 4/4] hvmloader: add support to load extra ACPI tables from qemu

2016-01-19 Thread Wei Liu
On Mon, Jan 18, 2016 at 01:46:29AM -0700, Jan Beulich wrote: > >>> On 18.01.16 at 01:52, wrote: > > On 01/15/16 10:10, Jan Beulich wrote: > >> >>> On 29.12.15 at 12:31, wrote: > >> > NVDIMM devices are detected and configured by software through > >> > ACPI. Currently, QEMU maintains ACPI tables

Re: [Xen-devel] [PATCH OSSTEST] sg-report-job-history: alternate color of osstest column only when it changes

2016-01-19 Thread Ian Campbell
On Wed, 2016-01-06 at 11:08 +, Ian Campbell wrote: ping? > Currently the bgcolor of the osstest column alternates on each line, > rather than only when it changes as the other revision columns do. > > A given flight might touch multiple osstest revisions (although in > practice they rarely d

Re: [Xen-devel] [PATCH] xenpm: Add option to report average CPU frequency

2016-01-19 Thread Malcolm Crossley
On 19/01/16 11:35, Ian Campbell wrote: > On Tue, 2016-01-19 at 11:10 +, Malcolm Crossley wrote: >> On 19/01/16 11:06, Ian Campbell wrote: >>> On Tue, 2016-01-19 at 10:50 +, Malcolm Crossley wrote: The average is calculated over the period of time from the last xenpm report of the

Re: [Xen-devel] [PATCH 4/4] hvmloader: add support to load extra ACPI tables from qemu

2016-01-19 Thread Jan Beulich
>>> On 19.01.16 at 12:37, wrote: > On Mon, Jan 18, 2016 at 01:46:29AM -0700, Jan Beulich wrote: >> >>> On 18.01.16 at 01:52, wrote: >> > On 01/15/16 10:10, Jan Beulich wrote: >> >> >>> On 29.12.15 at 12:31, wrote: >> >> > NVDIMM devices are detected and configured by software through >> >> > ACP

Re: [Xen-devel] [PATCH 3/3] tools: introduce parameter max_ranges.

2016-01-19 Thread Wei Liu
On Tue, Jan 19, 2016 at 05:27:58PM +0800, Yu Zhang wrote: > A new parameter - max_ranges is added to set the upper limit of ranges > to be tracked inside one ioreq server rangeset. > > Ioreq server uses a group of rangesets to track the I/O or memory > resources to be emulated. The default value o

[Xen-devel] [PATCH] docs: correct descriptions of gnttab_max_{, maptrack}_frames

2016-01-19 Thread Ian Campbell
gnttab_max_frames incorrectly referred to numbers of grant tab operations and gnttab_max_maptrack_frames was confusingly worded. Add the default for gnttab_max_frames while here (it's currently the same on all arches since no arch uses the available arch override) and adjust the default for gnttab

[Xen-devel] [PATCH] libxc: fix comment in xc__hypercall_bounce_pre

2016-01-19 Thread Wei Liu
Signed-off-by: Wei Liu --- Cc: Ian Campbell Cc: Ian Jackson Cc: Stefano Stabellini --- tools/libxc/xc_hcall_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxc/xc_hcall_buf.c b/tools/libxc/xc_hcall_buf.c index 6e3c958..4fc 100644 --- a/tools/libxc/xc_hcall

Re: [Xen-devel] [PATCH LIBVIRT] libxl: Support cmdline= in xl config files

2016-01-19 Thread Ian Campbell
I went to ping this but noticed that I had sent it to "jimfehlig" (i.e. no domain), so no wonder there was no reply! To: line fixed here, let me know if you would prefer a resend. Ian. On Wed, 2015-12-16 at 12:09 +, Ian Campbell wrote: > ... and consolidate the cmdline/extra/root parsing to

Re: [Xen-devel] [PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services

2016-01-19 Thread Stefano Stabellini
On Mon, 18 Jan 2016, Mark Rutland wrote: > On Mon, Jan 18, 2016 at 05:45:24PM +, Stefano Stabellini wrote: > > On Mon, 18 Jan 2016, Mark Rutland wrote: > > > On Fri, Jan 15, 2016 at 02:55:29PM +0800, Shannon Zhao wrote: > > > > +void __init xen_efi_runtime_setup(void) > > > > +{ > > > > +

Re: [Xen-devel] [PATCH] docs: correct descriptions of gnttab_max_{, maptrack}_frames

2016-01-19 Thread Ian Campbell
On Tue, 2016-01-19 at 11:56 +, Ian Campbell wrote: Should have been tagged, v2, sorry. > gnttab_max_frames incorrectly referred to numbers of grant tab > operations and gnttab_max_maptrack_frames was confusingly worded. > > Add the default for gnttab_max_frames while here (it's currently the

[Xen-devel] [xen-unstable-smoke test] 78511: tolerable all pass - PUSHED

2016-01-19 Thread osstest service owner
flight 78511 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/78511/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

Re: [Xen-devel] [PATCH v2 10/16] ARM: XEN: Move xen_early_init() before efi_init()

2016-01-19 Thread Stefano Stabellini
On Tue, 19 Jan 2016, Shannon Zhao wrote: > On 2016/1/18 22:59, Stefano Stabellini wrote: > > On Fri, 15 Jan 2016, Shannon Zhao wrote: > >> From: Shannon Zhao > >> > >> Move xen_early_init() before efi_init(), then when calling efi_init() > >> could initialize Xen specific UEFI. > >> > >> Check if

Re: [Xen-devel] [PATCH v2 12/16] ARM: Xen: Document UEFI support on Xen ARM virtual platforms

2016-01-19 Thread Stefano Stabellini
On Tue, 19 Jan 2016, Mark Rutland wrote: > On Tue, Jan 19, 2016 at 06:25:25PM +0800, Shannon Zhao wrote: > > >> We don't do this in Documentation/arm/uefi.txt, and I don't see why we > > >> should do so here. > > >> > > >> Does Xen handle arbitrary size memory map descriptors? I'm not sure what > >

Re: [Xen-devel] [PATCHv5 1/3] rwlock: Add per-cpu reader-writer lock infrastructure

2016-01-19 Thread George Dunlap
On 19/01/16 10:29, Malcolm Crossley wrote: > On 11/01/16 15:06, Malcolm Crossley wrote: >> On 22/12/15 11:56, George Dunlap wrote: >>> On 18/12/15 16:08, Malcolm Crossley wrote: + +#ifndef NDEBUG +#define PERCPU_RW_LOCK_UNLOCKED(owner) { RW_LOCK_UNLOCKED, 0, owner } +stati

Re: [Xen-devel] [PATCHv1 3/4] spinlock: shrink struct lock_debug

2016-01-19 Thread Jennifer Herbert
On 18/12/15 16:58, Jan Beulich wrote: On 18.12.15 at 15:09, wrote: --- a/xen/common/spinlock.c +++ b/xen/common/spinlock.c @@ -16,7 +16,7 @@ static atomic_t spin_debug __read_mostly = ATOMIC_INIT(0); static void check_lock(struct lock_debug *debug) { -int irq_safe = !local_irq_is_e

[Xen-devel] [PATCH OSSTEST v2] cs-adjust-flight: Add jobs-rename command which applies a perlop to job names

2016-01-19 Thread Ian Campbell
My intention was to allow creation of adhoc jobs based on a template but modified e.g. to enable/disable XSM with a sequence something like: ./cs-adjust-flight $flight copy-jobs $template test-foo-xsm ./cs-adjust-flight $flight jobs-rename test-foo-xsm 's/-xsm$//' ./cs-adjust-flight $flight runvar

[Xen-devel] [PATCH OSSTEST v2] make-flight: Support specifying a mini-os tree+revision

2016-01-19 Thread Ian Campbell
This is useful for standalone or adhoc use as well as (presumably) bisection. There is no ap-* or cr-daily-* integration here because I didn't need it (i.e. I'm not intending to create a new mini-os branch here). In order to cope with Xen <= 4.5 where extras/mini-os exists but is part of xen.git

Re: [Xen-devel] [PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services

2016-01-19 Thread Mark Rutland
On Tue, Jan 19, 2016 at 12:03:59PM +, Stefano Stabellini wrote: > On Mon, 18 Jan 2016, Mark Rutland wrote: > > On Mon, Jan 18, 2016 at 05:45:24PM +, Stefano Stabellini wrote: > > > On Mon, 18 Jan 2016, Mark Rutland wrote: > > > > On Fri, Jan 15, 2016 at 02:55:29PM +0800, Shannon Zhao wrote:

Re: [Xen-devel] [PATCHv1 3/4] spinlock: shrink struct lock_debug

2016-01-19 Thread Jan Beulich
>>> On 19.01.16 at 13:31, wrote: > On 18/12/15 16:58, Jan Beulich wrote: > On 18.12.15 at 15:09, wrote: >>> --- a/xen/common/spinlock.c >>> +++ b/xen/common/spinlock.c >>> @@ -16,7 +16,7 @@ static atomic_t spin_debug __read_mostly = ATOMIC_INIT(0); >>> >>> static void check_lock(struct l

Re: [Xen-devel] [PATCH] docs: correct descriptions of gnttab_max_{, maptrack}_frames

2016-01-19 Thread Jan Beulich
>>> On 19.01.16 at 12:56, wrote: > -Specify the maximum number of maptrack frames domain. > -The default value is 8 times **gnttab\_max\_frames**. > +> Default: `8 * gnttab_max_frames` No backslash escaping needed here? In any case, Acked-by: Jan Beulich __

Re: [Xen-devel] [PATCH] docs: correct descriptions of gnttab_max_{, maptrack}_frames

2016-01-19 Thread Ian Campbell
On Tue, 2016-01-19 at 06:06 -0700, Jan Beulich wrote: > > > > On 19.01.16 at 12:56, wrote: > > -Specify the maximum number of maptrack frames domain. > > -The default value is 8 times **gnttab\_max\_frames**. > > +> Default: `8 * gnttab_max_frames` > > No backslash escaping needed here? No, not

Re: [Xen-devel] [PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services

2016-01-19 Thread Shannon Zhao
On 2016/1/19 1:03, Stefano Stabellini wrote: On Fri, 15 Jan 2016, Shannon Zhao wrote: From: Shannon Zhao When running on Xen hypervisor, runtime services are supported through hypercall. So call Xen specific function to initialize runtime services. Signed-off-by: Shannon Zhao Thanks Shan

Re: [Xen-devel] [PATCH v2 12/16] ARM: Xen: Document UEFI support on Xen ARM virtual platforms

2016-01-19 Thread Mark Rutland
On Tue, Jan 19, 2016 at 12:23:17PM +, Stefano Stabellini wrote: > On Tue, 19 Jan 2016, Mark Rutland wrote: > > On Tue, Jan 19, 2016 at 06:25:25PM +0800, Shannon Zhao wrote: > > > >> We don't do this in Documentation/arm/uefi.txt, and I don't see why we > > > >> should do so here. > > > >> > > >

Re: [Xen-devel] [PATCH v2 12/16] ARM: Xen: Document UEFI support on Xen ARM virtual platforms

2016-01-19 Thread Ard Biesheuvel
On 19 January 2016 at 14:13, Mark Rutland wrote: > On Tue, Jan 19, 2016 at 12:23:17PM +, Stefano Stabellini wrote: >> On Tue, 19 Jan 2016, Mark Rutland wrote: >> > On Tue, Jan 19, 2016 at 06:25:25PM +0800, Shannon Zhao wrote: >> > > >> We don't do this in Documentation/arm/uefi.txt, and I don'

Re: [Xen-devel] [PATCH v2 14/16] Xen: EFI: Parse DT parameters for Xen specific UEFI

2016-01-19 Thread Shannon Zhao
On 2016/1/18 23:41, Stefano Stabellini wrote: CC'ing Matt Fleming On Fri, 15 Jan 2016, Shannon Zhao wrote: From: Shannon Zhao Add a new function to parse DT parameters for Xen specific UEFI just like the way for normal UEFI. Then it could reuse the existing codes. Signed-off-by: Shannon Zh

Re: [Xen-devel] [PATCH] x86: Convert shadow-paging to Kconfig

2016-01-19 Thread Jan Beulich
>>> On 19.01.16 at 10:46, wrote: > On Mon, 2016-01-18 at 18:40 +, Andrew Cooper wrote: >> Signed-off-by: Andrew Cooper > > Does this have any impact on migration of either PV or HVM guests? What > about nested virt? At least PV guests won't be migratable anymore when there's no shadow mode.

Re: [Xen-devel] [PATCH XEN v8 14/29] tools/libs/foreignmemory: Mention restrictions on fork in docs.

2016-01-19 Thread Wei Liu
On Fri, Jan 15, 2016 at 01:22:53PM +, Ian Campbell wrote: > Signed-off-by: Ian Campbell > --- > v6: Also discuss recovering the memory. > > v7: Further clarifications regarding forking based on ML discussions. > (Dropped Wei's ack) > --- > .../libs/foreignmemory/include/xenforeignmemory.

Re: [Xen-devel] [PATCH XEN v8 20/29] tools/libs/gnttab: Extensive updates to API documentation.

2016-01-19 Thread Wei Liu
On Fri, Jan 15, 2016 at 01:22:59PM +, Ian Campbell wrote: > In particular around error handling, behaviour on fork and the unmap > notification mechanism. > > Behaviour of xengnttab_map_*grant_refs and xengntshr_share_pages on > partial failure has been confirmed/inferred (by inspection) on Li

Re: [Xen-devel] [PATCH XEN v8 26/29] tools/libs/*: Use O_CLOEXEC on Linux and FreeBSD

2016-01-19 Thread Wei Liu
On Fri, Jan 15, 2016 at 01:23:05PM +, Ian Campbell wrote: > In some cases this replaces an FD_CLOEXEC dance, in others it is new. > > Linux has had O_CLOEXEC since 2.6.23 (October 2007), so we can rely on > it from Xen 4.7 I think. Some libc headers may still lack the > definition, so we take

Re: [Xen-devel] [PATCH XEN v8 18/29] tools/libs/evtchn: Use uint32_t for domid arguments

2016-01-19 Thread Wei Liu
On Fri, Jan 15, 2016 at 01:22:57PM +, Ian Campbell wrote: > Signed-off-by: Ian Campbell Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH XEN v8 24/29] tools/libs/call: linux: touch newly allocated pages after madvise lockdown

2016-01-19 Thread Wei Liu
On Fri, Jan 15, 2016 at 01:23:03PM +, Ian Campbell wrote: > This avoids a potential issue with a fork after allocation but before > madvise. > > Signed-off-by: Ian Campbell > --- > v7: New, replacing "tools/libs/call: linux: avoid forking between mmap > and madvise". > --- > tools/libs/c

Re: [Xen-devel] [PATCH XEN v8 28/29] tools/libs/*: Introduce APIs to restrict handles to a specific domain.

2016-01-19 Thread Wei Liu
On Fri, Jan 15, 2016 at 01:23:07PM +, Ian Campbell wrote: > These are intended to allow user space processes (in particular QEMU) > to lock down all the handles at start of day and then drop the > privileges which would allow them to open any new unrestricted handles > (e.g. setuid or similar).

Re: [Xen-devel] [PATCH XEN v8 25/29] tools/libs/{call, evtchn}: Document requirements around forking.

2016-01-19 Thread Wei Liu
On Fri, Jan 15, 2016 at 01:23:04PM +, Ian Campbell wrote: > Much like for gnttab and foreignmemory xencall hypercall buffers need > care. > > Evtchn is a bit simpler (no magic mappings) but may not work from > parent + child simultaneously, document "parent only" since it is > consistent with

Re: [Xen-devel] [PATCH] x86: Convert shadow-paging to Kconfig

2016-01-19 Thread Jan Beulich
>>> On 18.01.16 at 19:40, wrote: > --- a/xen/arch/x86/mm/shadow/Makefile > +++ b/xen/arch/x86/mm/shadow/Makefile > @@ -1,4 +1,4 @@ > -ifeq ($(shadow-paging),y) > +ifdef CONFIG_SHADOW_PAGING > obj-y += common.o guest_2.o guest_3.o guest_4.o > else > obj-y += none.o Why didn't you retain the ife

Re: [Xen-devel] [PATCH] x86: Convert shadow-paging to Kconfig

2016-01-19 Thread Andrew Cooper
On 19/01/16 13:23, Jan Beulich wrote: On 19.01.16 at 10:46, wrote: >> On Mon, 2016-01-18 at 18:40 +, Andrew Cooper wrote: >>> Signed-off-by: Andrew Cooper >> Does this have any impact on migration of either PV or HVM guests? What >> about nested virt? > At least PV guests won't be migrat

[Xen-devel] [xen-unstable test] 78433: regressions - trouble: broken/fail/pass

2016-01-19 Thread osstest service owner
flight 78433 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/78433/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 5 xen-install fail REGR. vs. 77892 test-amd64

Re: [Xen-devel] [PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services

2016-01-19 Thread Shannon Zhao
On 2016/1/19 21:03, Mark Rutland wrote: On Tue, Jan 19, 2016 at 12:03:59PM +, Stefano Stabellini wrote: On Mon, 18 Jan 2016, Mark Rutland wrote: On Mon, Jan 18, 2016 at 05:45:24PM +, Stefano Stabellini wrote: On Mon, 18 Jan 2016, Mark Rutland wrote: On Fri, Jan 15, 2016 at 02:55:29P

Re: [Xen-devel] [PATCH v2 3/5] n16550: add sanity check for reg_shift

2016-01-19 Thread Jan Beulich
>>> On 19.01.16 at 06:57, wrote: > Fix CID 1343302 by adding checking a check on the value of reg_shift. > This patch also rolls the multiplication by 8 into the shift. > No functional changes. > > Suggested-by: Jan Beulich I don't think so. > Signed-off-by: Chester Lin > --- > xen/drivers/c

  1   2   3   >