On Fri, 2016-01-15 at 11:01 -0600, Jonathan Creekmore wrote: > Allow the schedulers to be independently enabled or disabled at > compile-time. To match existing behavior, all four schedulers are > compiled in by default, although the Credit2, RTDS, and ARINC653 are > marked EXPERIMENTAL to match their not currently supported status. > > CC: George Dunlap <george.dun...@eu.citrix.com> > CC: Dario Faggioli <dario.faggi...@citrix.com> > Signed-off-by: Jonathan Creekmore <jonathan.creekm...@gmail.com> > Reviewed-by: Doug Goldstein <car...@cardoe.com> > > --- > > diff --git a/xen/common/Kconfig b/xen/common/Kconfig > index eadfc3b..7cc99c7 100644 > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > > diff --git a/xen/common/Makefile b/xen/common/Makefile > index 9f8b214..4df71ee 100644 > --- a/xen/common/Makefile > +++ b/xen/common/Makefile
The above changes looks fine to me, but I really speak almost no
Kconfig. :-/
On the rest of the patch, I only have one comment.
> diff --git a/xen/common/schedule.c b/xen/common/schedule.c
> index d121896..2f98a48 100644
> --- a/xen/common/schedule.c
> +++ b/xen/common/schedule.c
> @@ -65,10 +65,18 @@ DEFINE_PER_CPU(struct schedule_data,
> schedule_data);
> DEFINE_PER_CPU(struct scheduler *, scheduler);
>
> static const struct scheduler *schedulers[] = {
> +#ifdef CONFIG_SCHED_CREDIT
> &sched_credit_def,
> +#endif
>
If I understood correctly, Credit is always going to be there, so I
guess these #ifdef could go away?
However, since this is just killed later, I don't think it should block
the patch (series). So:
Acked-by: Dario Faggioli <dario.faggi...@citrix.com>
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
