[Xen-devel] [PATCH v1 0/3] Clean-up of datastructres and variable names in smmu.c

This series of patches is a clean-up on the naming of the datastructures and the variable names. It is sometimes hard to understand the flow of the code and current code readability for understanding flow and making changes it not intuitive. Based on these I will send next set of patches for PCI

[Xen-devel] [PATCH v1 1/3] xen/arm: smmu: Rename arm_smmu_xen_device with, device_iommu_info

arm_smmu_xen_device is not an intuitive name for a datastructure which represents device->archdata.iommu. Rename arm_smmu_xen_device with device_iommu_info Signed-off-by: Manish Jaggi --- xen/drivers/passthrough/arm/smmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Xen-devel] [PATCH v1 2/3] xen/arm: smmu: Renaming arm_smmu_xen_domain with, domain_iommu_info

The name arm_smmu_xen_domain was mapped to domain_hvm_iommu(d)->arch.priv. Also there are a lot of datastructre in smmu.c with name ending in domain it is not intuitive and code is hard to understand. domain_iommu_info is easy to understand that it refers to domain_hvm_iommu(d)->arch.priv. The i

[Xen-devel] [PATCH v1 3/3] xen/arm: smmu: Renaming struct iommu_domain *domain to, struct iommu_domain *iommu_domain

It is good for code readability as there are many structures ending with the name domain. Also a code like this one is now easy to understand with the rename old: dev_iommu_domain(dev) = domain; new: dev_iommu_domain(dev) = iommu_domain; Also in current code struct smmu_domain pointer variable n

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

On Thu, Mar 26, Ian Campbell wrote: > On Thu, 2015-03-26 at 13:55 +0100, Olaf Hering wrote: > > On Fri, Mar 13, Ian Campbell wrote: > > > Also, should this be a defbool or not? > > This is a good idea. I remmeber xend had code to make sure that all > > devices within a vhost had the same value for

Re: [Xen-devel] [PATCH v10 3/6] Support for BIOS interrupt handler

> -Original Message- > From: Xu, Quan > Sent: Friday, March 27, 2015 10:01 AM > To: 'Stefan Berger'; Kevin O'Connor > Cc: seab...@seabios.org; stefano.stabell...@eu.citrix.com > Subject: RE: [PATCH v10 3/6] Support for BIOS interrupt handler > > > > > -Original Message- > > Fro

Re: [Xen-devel] [PATCH V14 5/7] xen/arm: Instruction prefetch abort (X) mem_access event handling

On Fri, Mar 27, 2015 at 12:21 AM, Julien Grall wrote: > Hi Tamas, > > On 26/03/2015 22:05, Tamas K Lengyel wrote: > >> Add missing structure definition for iabt and update the trap handling >> mechanism to only inject the exception if the mem_access checker >> decides to do so. >> >> Signed-off-b

Re: [Xen-devel] [RFT] x86/pvh: disable all MTRR CPU features on cpuid for dom0

El 27/03/15 a les 0.33, Luis R. Rodriguez ha escrit: > From: "Luis R. Rodriguez" > > Commit 586ab6a by Roger disabled the main MTRR CPU feature > on the cpuid when on pvh in order to avoid having MTRR code > run on the OS on dom0. This missed the fact that not all CPUs > use this cpuid to identif

Re: [Xen-devel] [PATCH v1 09/47] vidoe: fbdev: atyfb: remove and fix MTRR MMIO "hole" work around

On Sat, Mar 21, 2015 at 11:15:14AM +0200, Ville Syrjälä wrote: > On Fri, Mar 20, 2015 at 04:17:59PM -0700, Luis R. Rodriguez wrote: > > diff --git a/drivers/video/fbdev/aty/atyfb_base.c > > b/drivers/video/fbdev/aty/atyfb_base.c > > index 8025624..8875e56 100644 > > --- a/drivers/video/fbdev/aty/a

Re: [Xen-devel] [PATCH v2] xen-blkback: enlarge the array size of blkback name

El 27/03/15 a les 14.15, Tao Chen ha escrit: > The blkback name is like blkback.domid.xvd[a-z], if domid has four digits > (means larger than 1000), then the backmost xvd wouldn't be fully shown. > > Define a BLKBACK_NAME_LEN macro to be 20, enlarge the array size of > blkback name, so it will be

[Xen-devel] [ovmf test] 36764: tolerable FAIL - PUSHED

flight 36764 ovmf real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36764/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-pair17 guest-migrate/src_host/dst_host fail like 36590 Tests which did not succeed, but are

Re: [Xen-devel] [PATCH OSSTEST 1/2] uboot: use "readlink -f"

On Tue, 2015-03-24 at 11:45 +, Wei Liu wrote: > If the path is not a symlink, readlink by default returns empty string. > Use "-f" to always return canonical path. This fixes the problem that > xenpolicy file not getting loaded (because it is not a symlink). > > Also change another spot that c

Re: [Xen-devel] [RFT] x86/pvh: disable all MTRR CPU features on cpuid for dom0

On 26/03/15 23:33, Luis R. Rodriguez wrote: From: "Luis R. Rodriguez" Commit 586ab6a by Roger disabled the main MTRR CPU feature on the cpuid when on pvh in order to avoid having MTRR code run on the OS on dom0. This missed the fact that not all CPUs use this cpuid to identify MTRR support, thi

Re: [Xen-devel] Dom0 kernel 3.18.10 with CONFIG_HYPERV_STORAGE and Xen 4.5.0 nested inside Hyper-V

>>> On 26.03.15 at 20:37, wrote: > Without Xen, first the disk is deliberately ignored: > > [3.728055] ata_piix :00:07.1: Hyper-V Virtual Machine detected, ATA > device ignore set > > And later picked up by hv_storevsc: > > [8.432089] scsi host0: storvsc_host_t > [8.432946] scsi

Re: [Xen-devel] [RFC v1 01/15] iommu: Add iommu_intpost to control VT-d Posted-Interrupts feature

>>> On 26.03.15 at 18:39, wrote: > On 25/03/15 12:31, Feng Wu wrote: >> @@ -51,6 +52,7 @@ bool_t __read_mostly iommu_passthrough; >> bool_t __read_mostly iommu_snoop = 1; >> bool_t __read_mostly iommu_qinval = 1; >> bool_t __read_mostly iommu_intremap = 1; >> +bool_t __read_mostly iommu_intp

Re: [Xen-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

On Fri, 2015-03-27 at 09:29 +0800, Chen, Tiejun wrote: > On 2015/3/26 18:06, Ian Campbell wrote: > > On Thu, 2015-03-26 at 08:53 +0800, Chen, Tiejun wrote: > >>> Hrm, OK. I suppose we can live with autodetect and igd both meaning igd > >>> and whoever adds a new type will have to remember to add a

Re: [Xen-devel] Strange memory balloning problem even if balloning is disabled

Il 03/03/2015 12:47, Fabio Fantoni ha scritto: Il 03/03/2015 12:09, David Vrabel ha scritto: On 03/03/15 09:05, Fabio Fantoni wrote: Il 02/03/2015 17:31, David Vrabel ha scritto: On 02/03/15 16:23, Jan Beulich wrote: On 02.03.15 at 16:52, wrote: On systems with wheezy as dom0 and kernel 3.2

Re: [Xen-devel] [RFC v1 01/15] iommu: Add iommu_intpost to control VT-d Posted-Interrupts feature

On 27/03/15 04:46, Wu, Feng wrote: * no-snoop Disable VT-d Snoop Control * no-qinval Disable VT-d Queued Invalidation * no-intremapDisable VT-d Interrupt Remapping + * no-intpost Disable VT-d Interrupt posting

Re: [Xen-devel] [RFC v1 06/15] vt-d: Extend struct iremap_entry to support VT-d Posted-Interrupts

>>> On 27.03.15 at 02:53, wrote: >> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] >> Sent: Friday, March 27, 2015 3:01 AM >> On 25/03/15 12:31, Feng Wu wrote: >> > --- a/xen/drivers/passthrough/vtd/iommu.h >> > +++ b/xen/drivers/passthrough/vtd/iommu.h >> > @@ -303,6 +303,18 @@ struct ire

Re: [Xen-devel] [RFC v1 07/15] vt-d: Add API to update IRTE when VT-d PI is used

>>> On 27.03.15 at 03:13, wrote: >> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] >> Sent: Friday, March 27, 2015 3:17 AM >> On 25/03/15 12:31, Feng Wu wrote: >> > + >> > +new_ire.lo_intpost.res_1 = 0; >> > +new_ire.lo_intpost.res_2 = 0; >> > +new_ire.lo_intpost.res_3 = 0; >>

Re: [Xen-devel] [PATCH V8 07/12] xen: Introduce monitor_op domctl

>>> On 26.03.15 at 22:06, wrote: > In preparation for allowing for introspecting ARM and PV domains the old > control interface via the hvm_op hypercall is retired. A new control > mechanism > is introduced via the domctl hypercall: monitor_op. > > This patch aims to establish a base API on whic

Re: [Xen-devel] [RFC v1 02/15] vt-d: VT-d Posted-Interrupts feature detection

On 27/03/15 01:21, Wu, Feng wrote: + * Remapping, and Posted Interrupt */ for_each_drhd_unit ( drhd ) { @@ -2146,7 +2148,13 @@ int __init intel_vtd_setup(void) iommu_qinval = 0; if ( iommu_intremap && !ecap_intr_remap(iommu->ecap) ) +{

[Xen-devel] Upcoming CfP's (April & May)

Hi all, just a reminder of CFP deadlines that are coming up in April - May. If you want to submit and need a reminder for any of the events, let me know and I will forward you a calendar reminder. Regards Lars March 31st: openSUSE Conference , May 01

Re: [Xen-devel] ARM: KVM/XEN: how should we support virt-what?

On Thu, Mar 26, 2015 at 07:50:06PM +0100, Ard Biesheuvel wrote: > On 26 March 2015 at 19:49, Ard Biesheuvel wrote: > > On 26 March 2015 at 19:45, Stefano Stabellini > > wrote: > >> On Thu, 26 Mar 2015, Andrew Jones wrote: > >>> On Wed, Mar 25, 2015 at 10:44:42AM +0100, Andrew Jones wrote: > >>> >

[Xen-devel] [PATCH] hotplug/Linux: add missing backslash in dom0_ip

Without it the actual error message is not written to xenstore. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/hotplug/Linux/vif-common.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/hotplug/Linux/vif-com

Re: [Xen-devel] question about suspending the guest

On Fri, 2015-03-27 at 14:04 +0800, Wen Congyang wrote: > When I test COLO, I find that suspending the primay guest will fail. > > static void domain_suspend_common_wait_guest(libxl__egc *egc, > libxl__domain_suspend_state2 > *dss2) > { > STATE_AO_G

Re: [Xen-devel] [RFT] x86/pvh: disable all MTRR CPU features on cpuid for dom0

>>> On 27.03.15 at 10:37, wrote: > On 26/03/15 23:33, Luis R. Rodriguez wrote: >> From: "Luis R. Rodriguez" >> >> Commit 586ab6a by Roger disabled the main MTRR CPU feature >> on the cpuid when on pvh in order to avoid having MTRR code >> run on the OS on dom0. This missed the fact that not all C

[Xen-devel] [PATCH OSSTEST v2 2/2] uboot: make flask loading address host property

From: Wei Liu Signed-off-by: Wei Liu Acked-by: Ian Campbell --- v2: [ijc] Rebase over change to preceding patch --- Osstest/Debian.pm | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index 3a0993b..3ca319c 100644 --- a/Osstest/Deb

Re: [Xen-devel] [PATCH 04/18] xen/x86: add multiboot2 protocol support

On Fri, Feb 20, 2015 at 04:06:26PM +, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > --- a/xen/arch/x86/boot/Makefile > > +++ b/xen/arch/x86/boot/Makefile > > @@ -1,6 +1,7 @@ > > obj-bin-y += head.o > > > > -RELOC_DEPS = $(BASEDIR)/include/asm-x86/config.h > > $(BASEDIR)/include/x

Re: [Xen-devel] [PATCH 00/18] x86: multiboot2 protocol support

On Fri, Jan 30, 2015 at 06:54:04PM +0100, Daniel Kiper wrote: > Hi, > > I am sending, long awaited, first version of multiboot2 protocol > support for legacy BIOS and EFI platforms. New version with relocatable Xen early boot code is under tests now. I hope that I will release new version in 2-3 w

[Xen-devel] [OSSTEST Nested PATCH v7 3/6] Changes on test step of debain hvm guest install

1. Increase disk size to accomodate to nested test requirment. 2. Since 'Debain-xxx-.iso' image will be stored there, therefore needs more disk capacity, increase root partition size in preseed generation. 3. In L1 installation context, assign more memory to it; Since it acts as a nested hypervisor

[Xen-devel] [OSSTEST Nested PATCH v7 5/6] Add test job for nest test case

1. This patch adds creation of the nested test job, when job creation procedure is invoked. 2. 'NESTED_OS_IMAGE' is the name of 'Debian ISO Images', which defined in standalone.config. 3. Set nested L1's vif model as e1000 by make-flight. Signed-off-by: longtao.pang --- Changes in v7: Set L1's vi

[Xen-devel] [OSSTEST Nested PATCH v7 6/6] Compose the main recipe of nested test job

Signed-off-by: longtao.pang --- Changes in v7: Add 'ts-guest-stop' and 'ts-guest-destroy' scripts to shutdown L2 and L1 after finishing test. --- sg-run-job | 11 +++ 1 file changed, 11 insertions(+) diff --git a/sg-run-job b/sg-run-job index a1ff24b..be55da8 100755 --- a/sg-run-job ++

[Xen-devel] [OSSTEST Nested PATCH v7 4/6] Add new script to custmize nested test configuration

1. In this script, make some appropriate runvars which selecthost would recognise. 2. Prepare the configurations for installing L2 guest VM. 3. Create a lv disk in L0 and hot-attach it to L1, need to restart L1 to make the block disk to be recognized by L1 system, then using this disk to create a V

[Xen-devel] [OSSTEST Nested PATCH v7 2/6] Edit some testsupport APIs for nested test

1. Designate vif model to 'e1000' by make-flight. 2. In L2 installation context, its host (L1) IP address is not queried from DNS, but after running "ts-nested-setup + host + nested", L1 IP is stored in runvar. Signed-off-by: longtao.pang --- Changes in v7: 1.set vif model as e1000 when make-flig

[Xen-devel] [OSSTEST Nested PATCH v7 1/6] parsing grub which has 'submenu' primitive

>From a hvm kernel build from Linux stable Kernel tree, the auto generated grub2 menu will have 'submenu' primitive, upon the 'menuentry' items. Xen boot entries will be grouped into a submenu. This patch adds capability to support such grub formats. Signed-off-by: longtao.pang --- Changes in v7:

[Xen-devel] [OSSTEST Nested PATCH v7 0/6] Introduction of netsted HVM test job

This patch set adds nested HVM test case for osstest. In this test case, a Xen hypervisor (L1) runs on top of another Xen hypervisor (L0). Upon L1 hypervisor, we will then create a nested guest (L2), and test if the Linux guest can then be installed and run well. About nested Xen virtualization,

[Xen-devel] [PATCH OSSTEST v2 1/2] uboot: do not use readlink on xsm policy

The policy is not a symlink, so readlink will return nothing. We cannot use readlink -f because that will return an absolute path and we need a path relative to the filesystem root (in this case /boot). Keep flaskpolicy=$flaskpolicy as a shell variable rather than unescaping the uses (so they are

Re: [Xen-devel] REGRESSION [PATCH v2 08/13] libxc: Check xc_domain_maximum_gpfn for negative return values

On Thu, 2015-03-26 at 21:07 +, Andrew Cooper wrote: > On 20/03/15 17:03, Ian Campbell wrote: > > On Fri, 2015-03-20 at 11:45 -0400, Konrad Rzeszutek Wilk wrote: > >> From 45bd7cd377b0b8364757cc2bc0bd8d6a13523a97 Mon Sep 17 00:00:00 2001 > >> From: Konrad Rzeszutek Wilk > >> Date: Fri, 13 Mar

Re: [Xen-devel] [PATCH 08/18] efi: build xen.gz with EFI code

On Mon, Mar 02, 2015 at 04:14:22PM +, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > --- a/xen/arch/x86/efi/Makefile > > +++ b/xen/arch/x86/efi/Makefile > > @@ -1,14 +1,14 @@ > > CFLAGS += -fshort-wchar > > > > -obj-y += stub.o > > +obj-y += boot.o > > +obj-y += compat.o > > +obj-y

Re: [Xen-devel] [PATCH 04/18] xen/x86: add multiboot2 protocol support

>>> On 27.03.15 at 11:56, wrote: > On Fri, Feb 20, 2015 at 04:06:26PM +, Jan Beulich wrote: >> >>> On 30.01.15 at 18:54, wrote: >> > --- a/xen/arch/x86/boot/Makefile >> > +++ b/xen/arch/x86/boot/Makefile >> > @@ -1,6 +1,7 @@ >> > obj-bin-y += head.o >> > >> > -RELOC_DEPS = $(BASEDIR)/include

Re: [Xen-devel] [RFC v1 08/15] Update IRTE according to guest interrupt config changes

On 27/03/15 05:49, Wu, Feng wrote: +/* + * Here we handle the following cases: + * - For lowest-priority interrupts, we find the destination vCPU from the + * guest vector using vector-hashing mechamisn and return true. This follows + * the hardware behavior, since modern Intel CPUs use vec

[Xen-devel] [tip:core/rcu] x86: Use common outgoing-CPU-notification code

Commit-ID: 2a442c9c6453d3d043dfd89f2e03a1deff8a6f06 Gitweb: http://git.kernel.org/tip/2a442c9c6453d3d043dfd89f2e03a1deff8a6f06 Author: Paul E. McKenney AuthorDate: Wed, 25 Feb 2015 11:42:15 -0800 Committer: Paul E. McKenney CommitDate: Wed, 11 Mar 2015 13:22:35 -0700 x86: Use common ou

Re: [Xen-devel] [PATCH 08/18] efi: build xen.gz with EFI code

>>> On 27.03.15 at 12:14, wrote: > IIRC, MS ABI is supported starting from GCC v4.0. Where did you find that? From all I know __attribute__((__ms_abi__)) is being supported only by 4.5 and newer. The mere support of the MS ABI via command line option doesn't help us, as we need to be able to mix

Re: [Xen-devel] [PATCH 08/18] efi: build xen.gz with EFI code

On 27/03/15 11:46, Jan Beulich wrote: On 27.03.15 at 12:14, wrote: IIRC, MS ABI is supported starting from GCC v4.0. Where did you find that? From all I know __attribute__((__ms_abi__)) is being supported only by 4.5 and newer. The mere support of the MS ABI via command line option doesn't hel

Re: [Xen-devel] [PATCH 16/18] efi: create efi_exit_boot()

On Mon, Mar 02, 2015 at 04:45:47PM +, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > ..which gets memory map and calls ExitBootServices(). We need this > > to support multiboot2 protocol on EFI platforms. > > Patches from 9 up to here all make sense on the basis that patch 18 > does

Re: [Xen-devel] [RFC v1 14/15] Suppress posting interrupts when 'SN' is set

On 27/03/15 03:00, Wu, Feng wrote: static void vmx_deliver_posted_intr(struct vcpu *v, u8 vector) { +int r, sn; + if ( pi_test_and_set_pir(vector, &v->arch.hvm_vmx.pi_desc) ) return; +/* + * Currently, we don't support urgent interrupt, all interrupts +

Re: [Xen-devel] [PATCH 16/18] efi: create efi_exit_boot()

>>> On 27.03.15 at 13:00, wrote: > Additionally, efi_start() > is architecture independent and efi_multiboot2() is x86 only and it should > live in x86 files. Is that really the case? Looking at the grub2 sources I see support for other than x86... Jan _

[Xen-devel] [BAND-AID PATCH] x86: partially undo (disable) d639e6a05a

As from osstest results it looks like commit ("x86: allow 64-bit PV guest kernels to suppress user mode exposure of M2P") is guilty in causing migration failures, comment out the meat of it without fully reverting, until it is understood what is causing the issue. Signed-off-by: Jan Beulich --- I

Re: [Xen-devel] [PATCH V14 5/7] xen/arm: Instruction prefetch abort (X) mem_access event handling

Hi Tamas, On 27/03/15 08:32, Tamas K Lengyel wrote: > +/* > + * Flush the TLB to make sure the DTLB is clear before > + * doing GVA->IPA translation. If we got here because of > + * an entry only present in the ITLB, this translation

Re: [Xen-devel] [PATCH 04/18] xen/x86: add multiboot2 protocol support

On Fri, Mar 27, 2015 at 11:20:10AM +, Jan Beulich wrote: > >>> On 27.03.15 at 11:56, wrote: > > On Fri, Feb 20, 2015 at 04:06:26PM +, Jan Beulich wrote: > >> >>> On 30.01.15 at 18:54, wrote: > >> > --- a/xen/arch/x86/boot/Makefile > >> > +++ b/xen/arch/x86/boot/Makefile > >> > @@ -1,6 +1,

Re: [Xen-devel] [BAND-AID PATCH] x86: partially undo (disable) d639e6a05a

At 12:19 + on 27 Mar (1427458745), Jan Beulich wrote: > As from osstest results it looks like commit ("x86: allow 64-bit PV > guest kernels to suppress user mode exposure of M2P") is guilty in > causing migration failures, comment out the meat of it without fully > reverting, until it is unders

Re: [Xen-devel] [BAND-AID PATCH] x86: partially undo (disable) d639e6a05a

>>> On 27.03.15 at 13:28, wrote: > At 12:19 + on 27 Mar (1427458745), Jan Beulich wrote: >> As from osstest results it looks like commit ("x86: allow 64-bit PV >> guest kernels to suppress user mode exposure of M2P") is guilty in >> causing migration failures, comment out the meat of it withou

Re: [Xen-devel] [PATCH 04/18] xen/x86: add multiboot2 protocol support

>>> On 27.03.15 at 13:22, wrote: > On Fri, Mar 27, 2015 at 11:20:10AM +, Jan Beulich wrote: >> >>> On 27.03.15 at 11:56, wrote: >> > On Fri, Feb 20, 2015 at 04:06:26PM +, Jan Beulich wrote: >> >> >>> On 30.01.15 at 18:54, wrote: >> >> > @@ -31,7 +38,16 @@ asm ( >> >> > ); >> >> > >>

Re: [Xen-devel] [PATCH 16/18] efi: create efi_exit_boot()

On Fri, Mar 27, 2015 at 12:10:56PM +, Jan Beulich wrote: > >>> On 27.03.15 at 13:00, wrote: > > Additionally, efi_start() > > is architecture independent and efi_multiboot2() is x86 only and it should > > live in x86 files. > > Is that really the case? Looking at the grub2 sources I see suppor

Re: [Xen-devel] [BAND-AID PATCH] x86: partially undo (disable) d639e6a05a

At 12:35 + on 27 Mar (1427459701), Jan Beulich wrote: > >>> On 27.03.15 at 13:28, wrote: > > At 12:19 + on 27 Mar (1427458745), Jan Beulich wrote: > >> As from osstest results it looks like commit ("x86: allow 64-bit PV > >> guest kernels to suppress user mode exposure of M2P") is guilty i

Re: [Xen-devel] [PATCH 17/18] x86/efi: create new early memory allocator

On Mon, Mar 02, 2015 at 05:23:49PM +, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > --- a/xen/arch/x86/efi/efi-boot.h > > +++ b/xen/arch/x86/efi/efi-boot.h > > @@ -103,9 +103,35 @@ static void __init relocate_trampoline(unsigned long > > phys) > > *(u16 *)(*trampoline_ptr

Re: [Xen-devel] [PATCH v1 0/3] Clean-up of datastructres and variable names in smmu.c

Hello Manish, As for the PCI support series, this patch series is not threaded. Please use git-send-email. It will thread correctly your patch series. Regards, On 27/03/15 07:17, Manish Jaggi wrote: > This series of patches is a clean-up on the naming of the datastructures > and the variable na

Re: [Xen-devel] [PATCH v1 1/3] xen/arm: smmu: Rename arm_smmu_xen_device with, device_iommu_info

Hi Manish, On 27/03/15 07:20, Manish Jaggi wrote: > arm_smmu_xen_device is not an intuitive name for a datastructure which > represents > device->archdata.iommu. Rename arm_smmu_xen_device with device_iommu_info device_iommu_info is not more intuitive... At least arm_smmu_xen_device shows that it

Re: [Xen-devel] [PATCH v1 2/3] xen/arm: smmu: Renaming arm_smmu_xen_domain with, domain_iommu_info

Hi Manish, On 27/03/15 07:22, Manish Jaggi wrote: > The name arm_smmu_xen_domain was mapped to domain_hvm_iommu(d)->arch.priv. > Also there are a lot of datastructre in smmu.c with name ending in domain data structure. > it is not intuitive and code is hard to understand. Now it's more difficul

Re: [Xen-devel] [PATCH v1 3/3] xen/arm: smmu: Renaming struct iommu_domain *domain to, struct iommu_domain *iommu_domain

Hi manish, On 27/03/15 07:24, Manish Jaggi wrote: > It is good for code readability as there are many structures ending with > the name domain. > Also a code like this one is now easy to understand with the rename > old: dev_iommu_domain(dev) = domain; > new: dev_iommu_domain(dev) = iommu_domain;

Re: [Xen-devel] [PATCH RFC] tcp: Allow sk_wmem_alloc to exceed sysctl_tcp_limit_output_bytes

On 26/03/15 17:14, Eric Dumazet wrote: On Thu, 2015-03-26 at 16:46 +, Jonathan Davies wrote: Network drivers with slow TX completion can experience poor network transmit throughput, limited by hitting the sk_wmem_alloc limit check in tcp_write_xmit. The limit is 128 KB (by default), which me

Re: [Xen-devel] [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > @@ -94,6 +111,17 @@ ENTRY(start) > > gdt_boot_descr: > > .word 6*8-1 > > .long sym_phys(trampoline_gdt) > > +.long 0 /* Needed for 64-bit lgdt */ > > + > > +cs32_swi

Re: [Xen-devel] [PATCH 16/18] efi: create efi_exit_boot()

On Fri, 2015-03-27 at 13:43 +0100, Daniel Kiper wrote: > On Fri, Mar 27, 2015 at 12:10:56PM +, Jan Beulich wrote: > > >>> On 27.03.15 at 13:00, wrote: > > > Additionally, efi_start() > > > is architecture independent and efi_multiboot2() is x86 only and it should > > > live in x86 files. > > >

Re: [Xen-devel] [PATCH v1 1/3] xen/arm: smmu: Rename arm_smmu_xen_device with, device_iommu_info

Regards, Manish Jaggi From: Julien Grall Sent: Friday, March 27, 2015 6:29 PM To: Jaggi, Manish; Xen Devel; Stefano Stabellini; Ian Campbell; prasun.kap...@cavium.com; Kumar, Vijaya Subject: Re: [PATCH v1 1/3] xen/arm: smmu: Rename arm_smmu_xen_device w

Re: [Xen-devel] [PATCH v1 2/3] xen/arm: smmu: Renaming arm_smmu_xen_domain with, domain_iommu_info

Regards, Manish Jaggi From: Julien Grall Sent: Friday, March 27, 2015 6:32 PM To: Jaggi, Manish; Xen Devel; prasun.kap...@cavium.com; Kumar, Vijaya; Ian Campbell; Stefano Stabellini Subject: Re: [PATCH v1 2/3] xen/arm: smmu: Renaming arm_smmu_xen_domain

Re: [Xen-devel] [PATCH v1 3/3] xen/arm: smmu: Renaming struct iommu_domain *domain to, struct iommu_domain *iommu_domain

Regards, Manish Jaggi From: Julien Grall Sent: Friday, March 27, 2015 6:34 PM To: Jaggi, Manish; Xen Devel; prasun.kap...@cavium.com; Kumar, Vijaya; Ian Campbell; Stefano Stabellini Subject: Re: [PATCH v1 3/3] xen/arm: smmu: Renaming struct iommu_domain

Re: [Xen-devel] [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

On Fri, Feb 20, 2015 at 04:17:35PM +, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > We need more fine grained knowledge about EFI environment and check > > for EFI platform and EFI loader separately to properly support > > multiboot2 protocol. > > ... because of ... (i.e. I can't s

Re: [Xen-devel] VM Migration on ARM

Hi Andrew, On Wed, Mar 25, 2015 at 9:32 PM, Andrew Cooper wrote: > On 20/03/15 13:17, Vijay Kilari wrote: >> >> Hi Andrew, >> >> On Wed, Mar 11, 2015 at 4:21 PM, Andrew Cooper >> wrote: >>> >>> On 11/03/15 05:32, Vijay Kilari wrote: Hi Andrew, From Ian & Stefano, I came

Re: [Xen-devel] [PATCH 17/18] x86/efi: create new early memory allocator

>>> On 27.03.15 at 13:57, wrote: > On Mon, Mar 02, 2015 at 05:23:49PM +, Jan Beulich wrote: >> >>> On 30.01.15 at 18:54, wrote: >> > +{ >> > +void *ptr; >> > + >> > +/* >> > + * Init __malloc_free on runtime. Static initialization >> > + * will not work because it puts virtual

Re: [Xen-devel] [PATCH v1 1/3] xen/arm: smmu: Rename arm_smmu_xen_device with, device_iommu_info

On 27/03/15 13:21, Jaggi, Manish wrote: > > > Regards, > Manish Jaggi Could you please try to configure you email client correctly? It's rather confusing the "regards, Manish Jaggi" at the beginning of the mail. > > From: Julien Grall > Sent: Friday, Ma

Re: [Xen-devel] [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

>>> On 27.03.15 at 14:06, wrote: > On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beulich wrote: >> >>> On 30.01.15 at 18:54, wrote: >> > +/* Skip Multiboot2 information fixed part */ >> > +lea MB2_fixed_sizeof(%ebx),%ecx >> >> Let's please not add more assumptions than necessa

Re: [Xen-devel] [PATCH v1 2/3] xen/arm: smmu: Renaming arm_smmu_xen_domain with, domain_iommu_info

On 27/03/15 13:24, Jaggi, Manish wrote: > Now it's more difficult to differentiate domain_iommu_info and iommu_domain. > > [manish] Please see my previous mail. Also please pick any other name there > are so many data structures which end up in domain. What is the difference > between arm_smmu_d

Re: [Xen-devel] [RFC v1 02/15] vt-d: VT-d Posted-Interrupts feature detection

> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Friday, March 27, 2015 6:06 PM > To: Wu, Feng; xen-devel@lists.xen.org > Cc: Zhang, Yang Z; Tian, Kevin; k...@xen.org; jbeul...@suse.com > Subject: Re: [Xen-devel] [RFC v1 02/15] vt-d: VT-d Posted-Interr

Re: [Xen-devel] [PATCH v1 3/3] xen/arm: smmu: Renaming struct iommu_domain *domain to, struct iommu_domain *iommu_domain

On 27/03/15 13:26, Jaggi, Manish wrote: > On 27/03/15 07:24, Manish Jaggi wrote: >> It is good for code readability as there are many structures ending with >> the name domain. >> Also a code like this one is now easy to understand with the rename >> old: dev_iommu_domain(dev) = domain; >> new: dev

Re: [Xen-devel] [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

>>> On 27.03.15 at 14:32, wrote: > On Fri, Feb 20, 2015 at 04:17:35PM +, Jan Beulich wrote: >> >>> On 30.01.15 at 18:54, wrote: >> > We need more fine grained knowledge about EFI environment and check >> > for EFI platform and EFI loader separately to properly support >> > multiboot2 protocol

Re: [Xen-devel] [RFC v1 14/15] Suppress posting interrupts when 'SN' is set

> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Friday, March 27, 2015 8:06 PM > To: Wu, Feng; xen-devel@lists.xen.org > Cc: Zhang, Yang Z; Tian, Kevin; k...@xen.org; jbeul...@suse.com > Subject: Re: [Xen-devel] [RFC v1 14/15] Suppress posting interru

Re: [Xen-devel] [PATCH v10 3/6] Support for BIOS interrupt handler

On 03/27/2015 03:58 AM, Xu, Quan wrote: -Original Message- From: Xu, Quan Sent: Friday, March 27, 2015 10:01 AM To: 'Stefan Berger'; Kevin O'Connor Cc: seab...@seabios.org; stefano.stabell...@eu.citrix.com Subject: RE: [PATCH v10 3/6] Support for BIOS interrupt handler -Original

Re: [Xen-devel] VM Migration on ARM

On 27/03/15 13:32, Vijay Kilari wrote: 2) Also does the Domain Image format specification for ARM is complete? The spec has certain sentinel values for ARM already where it made sense to just include them while writing. It has no specific thought to ARM migration, but an ARM virtual machine i

Re: [Xen-devel] [RFC v1 14/15] Suppress posting interrupts when 'SN' is set

On 27/03/15 13:45, Wu, Feng wrote: -Original Message- From: Andrew Cooper [mailto:andrew.coop...@citrix.com] Sent: Friday, March 27, 2015 8:06 PM To: Wu, Feng; xen-devel@lists.xen.org Cc: Zhang, Yang Z; Tian, Kevin; k...@xen.org; jbeul...@suse.com Subject: Re: [Xen-devel] [RFC v1 14/15]

Re: [Xen-devel] [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

On 27/03/15 13:43, Jan Beulich wrote: On 27.03.15 at 14:32, wrote: On Fri, Feb 20, 2015 at 04:17:35PM +, Jan Beulich wrote: On 30.01.15 at 18:54, wrote: We need more fine grained knowledge about EFI environment and check for EFI platform and EFI loader separately to properly support mult

Re: [Xen-devel] [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

>>> On 27.03.15 at 14:53, wrote: > On 27/03/15 13:43, Jan Beulich wrote: > On 27.03.15 at 14:32, wrote: >>> On Fri, Feb 20, 2015 at 04:17:35PM +, Jan Beulich wrote: >>> On 30.01.15 at 18:54, wrote: > We need more fine grained knowledge about EFI environment and check > for EF

Re: [Xen-devel] [PATCH 0/9] qspinlock stuff -v15

On Thu, Mar 26, 2015 at 09:21:53PM +0100, Peter Zijlstra wrote: > On Wed, Mar 25, 2015 at 03:47:39PM -0400, Konrad Rzeszutek Wilk wrote: > > Ah nice. That could be spun out as a seperate patch to optimize the existing > > ticket locks I presume. > > Yes I suppose we can do something similar for th

Re: [Xen-devel] [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

On Fri, Mar 27, 2015 at 02:04:22PM +, Jan Beulich wrote: > >>> On 27.03.15 at 14:53, wrote: > > On 27/03/15 13:43, Jan Beulich wrote: > > On 27.03.15 at 14:32, wrote: > >>> On Fri, Feb 20, 2015 at 04:17:35PM +, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > We need

Re: [Xen-devel] [PATCH v2] xen-blkback: enlarge the array size of blkback name

On Fri, Mar 27, 2015 at 09:52:49AM +0100, Roger Pau Monné wrote: > El 27/03/15 a les 14.15, Tao Chen ha escrit: > > The blkback name is like blkback.domid.xvd[a-z], if domid has four digits > > (means larger than 1000), then the backmost xvd wouldn't be fully shown. > > > > Define a BLKBACK_NAME_L

Re: [Xen-devel] REGRESSION [PATCH v2 08/13] libxc: Check xc_domain_maximum_gpfn for negative return values

On Fri, Mar 27, 2015 at 10:52:07AM +, Ian Campbell wrote: > On Thu, 2015-03-26 at 21:07 +, Andrew Cooper wrote: > > On 20/03/15 17:03, Ian Campbell wrote: > > > On Fri, 2015-03-20 at 11:45 -0400, Konrad Rzeszutek Wilk wrote: > > >> From 45bd7cd377b0b8364757cc2bc0bd8d6a13523a97 Mon Sep 17 0

Re: [Xen-devel] [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

>>> On 27.03.15 at 15:09, wrote: > On Fri, Mar 27, 2015 at 02:04:22PM +, Jan Beulich wrote: >> >>> On 27.03.15 at 14:53, wrote: >> > On 27/03/15 13:43, Jan Beulich wrote: >> > On 27.03.15 at 14:32, wrote: >> >>> On Fri, Feb 20, 2015 at 04:17:35PM +, Jan Beulich wrote: >> >>> On 3

Re: [Xen-devel] [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

On Fri, Mar 27, 2015 at 02:19:44PM +, Jan Beulich wrote: > >>> On 27.03.15 at 15:09, wrote: > > On Fri, Mar 27, 2015 at 02:04:22PM +, Jan Beulich wrote: > >> >>> On 27.03.15 at 14:53, wrote: > >> > On 27/03/15 13:43, Jan Beulich wrote: > >> > On 27.03.15 at 14:32, wrote: > >> >>> On

Re: [Xen-devel] [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

On Fri, Mar 27, 2015 at 01:36:32PM +, Jan Beulich wrote: > >>> On 27.03.15 at 14:06, wrote: > > On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beulich wrote: > >> >>> On 30.01.15 at 18:54, wrote: > >> > +/* Skip Multiboot2 information fixed part */ > >> > +lea MB2_fixed_siz

Re: [Xen-devel] [PATCH 17/18] x86/efi: create new early memory allocator

On Fri, Mar 27, 2015 at 01:35:11PM +, Jan Beulich wrote: > >>> On 27.03.15 at 13:57, wrote: > > On Mon, Mar 02, 2015 at 05:23:49PM +, Jan Beulich wrote: > >> >>> On 30.01.15 at 18:54, wrote: > >> > +{ > >> > +void *ptr; > >> > + > >> > +/* > >> > + * Init __malloc_free on runt

Re: [Xen-devel] [PATCH v2] x86_emulate: split the {reg, mem} union in struct operand.

>>> On 26.03.15 at 13:40, wrote: > @@ -1447,14 +1452,15 @@ x86_emulate( > unsigned int op_bytes, def_op_bytes, ad_bytes, def_ad_bytes; > bool_t lock_prefix = 0; > int override_seg = -1, rc = X86EMUL_OKAY; > -struct operand src, dst; > +struct operand src = { .reg = REG_POISO

[Xen-devel] [PATCH v4 12/15] xen: arm: handle remaining traps from userspace

CP14 dbg and general CP register access are both handled with unconditional injection of #undef from their respective handlers, so allow these even from 32-bit userspace on a 64-bit kernel. SMC32 and HVC32 should only come from a guest in AArch32 mode and SMC64 and HVC64 should only come from a gu

[Xen-devel] [PATCH v4 03/15] xen: arm: correctly handle vtimer traps from userspace

Previously 32-bit userspace on 32-bit kernel and 64-bit userspace on 64-bit kernel could access these registers irrespective of whether the kernel had configured them to be allowed to. To fix this: - Userspace access to CNTP_CTL_EL0 and CNTP_TVAL_EL0 should be gated on CNTKCTL_EL1.EL0PTEN. -

[Xen-devel] [PATCH v4 0/15] xen: arm: reenable support for 32-bit userspace running in 64-bit guest.

XSA-102/CVE-2014-5147[0] concerned a crash when trapping from 32-bit userspace in a 64-bit guest. Part of that security patch was c0020e09970 "xen: arm: Handle traps from 32-bit userspace on 64-bit kernel as undef fix" which turned the exploitable crash into a #undef to the guest (so as to kill the

[Xen-devel] [PATCH v4 07/15] xen: arm: do not handle traps accessing CLIDR_EL1 or CCSIDR_EL1

They are trapped only with HCR_EL2.TID2 which we don't set, and in any case we handled only for 32-bit. One day we may want to trap and emulate these, but for now don't bother with the dead code. Signed-off-by: Ian Campbell --- v4: New patch --- xen/arch/arm/traps.c | 18 -- 1

[Xen-devel] [PATCH v4 05/15] xen: arm: Use ARMv8 names for CNTHCTL_EL2 bits

Rather than using the v8 register names and the v7 bit names, which makes things needlessly difficult when reading. Signed-off-by: Ian Campbell Reviewed-by: Julien Grall --- v3: New patch. --- xen/arch/arm/time.c |2 +- xen/include/asm-arm/processor.h |4 ++-- 2 files change

[Xen-devel] [PATCH v4 14/15] xen: arm: Allow traps from 32 bit userspace on 64 bit hypervisors again

This removes the unconditional #undef injected in response to such traps which was added by the fixes to CVE-2014-5147 / XSA-102 in c0020e099702 "xen: arm: Handle traps from 32-bit userspace on 64-bit kernel as undef", we now handle such traps correctly. Signed-off-by: Ian Campbell Reviewed-by: J

[Xen-devel] [PATCH v4 09/15] xen: arm: Handle CP15 register traps from userspace

Previously userspace access to PM* would have been incorrectly (but benignly) implemented as RAZ/WI when running on a 32-bit kernel and would cause a hypervisor exception (host crash) when running a 64-bit kernel (this was already solved via the fix to XSA-102). PMINTENSET, PMINTENCLR are EL1 only

Re: [Xen-devel] [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

>>> On 27.03.15 at 15:26, wrote: > On Fri, Mar 27, 2015 at 01:36:32PM +, Jan Beulich wrote: >> >>> On 27.03.15 at 14:06, wrote: >> > On Tue, Mar 17, 2015 at 10:32:01AM +, Jan Beulich wrote: >> >> >>> On 30.01.15 at 18:54, wrote: >> >> > +/* Skip Multiboot2 information fixed part

[Xen-devel] [PATCH v4 15/15] xen: arm: always omit guest user stack in vcpu_show_execution_state

Using !usr_mode(regs) only catches arm32 usr mode and not arm64 user mode, switch to psr_mode_is_user instead. Signed-off-by: Ian Campbell --- v4: New patch --- xen/arch/arm/traps.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c

  1   2   >