Re: [Xen-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-18 Thread Chen, Tiejun
I think the _libxl_ message needs to be just "Unable to detect graphics passthru kind". i.e. it can't/shouldn't reference anything to do with xl config options etc (which would make no sense if libvirt was being used). That's not very user friendly though, so you may want to consider adding a new

Re: [Xen-devel] [PATCH] dpci: Put the dpci back on the list if scheduled from another CPU.

2015-03-18 Thread Jan Beulich
>>> On 17.03.15 at 18:15, wrote: > On Tue, Mar 17, 2015 at 04:06:14PM +, Jan Beulich wrote: >> >>> On 17.03.15 at 16:38, wrote: >> > --- a/xen/drivers/passthrough/io.c >> > +++ b/xen/drivers/passthrough/io.c >> > @@ -804,7 +804,17 @@ static void dpci_softirq(void) >> > d = pirq_dpci-

Re: [Xen-devel] [RFC PATCH] dpci: Put the dpci back on the list if running on another CPU.

2015-03-18 Thread Jan Beulich
>>> On 17.03.15 at 18:44, wrote: > As you can see to preserve the existing functionality such as > being able to schedule N amount of interrupt injections > for the N interrupts we might get - I modified '->masked' > to be an atomic counter. Why would that be? When an earlier interrupt wasn't ful

[Xen-devel] [PATCH 2/2] tools/libxl/libxl_qmp.c: Close fds on error path in qmp_open

2015-03-18 Thread PRAMOD DEVENDRA
From: Pramod Devendra Signed-off-by: Pramod Devendra CC: Ian Jackson CC: Stefano Stabellini CC: Ian Campbell CC: Wei Liu --- tools/libxl/libxl_qmp.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c ind

Re: [Xen-devel] [PATCH v2 2/2] sched_credit2.c: runqueue_per_core code

2015-03-18 Thread Jan Beulich
>>> On 17.03.15 at 19:18, wrote: > On Mon, 2015-03-16 at 12:56 +, Jan Beulich wrote: >> >>> On 16.03.15 at 13:51, wrote: >> > On 03/16/2015 12:48 PM, Jan Beulich wrote: >> My preferred solution would be, as said, to leverage system_state. >> Provided the state to look for is consistent betwee

Re: [Xen-devel] [PATCH 2/2] VT-d: extend XSA-59 workaround to XeonE5 v3 (Haswell)

2015-03-18 Thread Jan Beulich
>>> On 17.03.15 at 18:41, wrote: > Note that the following Haswell chipsets should also be included in this > list: > > Haswell - 0xc0f, 0xd00, 0xd04, 0xd08, 0xd0f, 0xa00, 0xa08, 0xa0f But these are desktop ones afaict, i.e. they'd belong in a separate patch (which I'll create in a minute). Ja

Re: [Xen-devel] [PATCH 1/2] VT-d: make XSA-59 workaround fully cover XeonE5/E7 v2

2015-03-18 Thread Jan Beulich
>>> On 17.03.15 at 18:39, wrote: > Note that the following Nehalem/Westmere chipsets should be included in this > list: > > Nehalem - 0x40, 0x2c01, 0x2c41, 0x313x > Westmere - 0x2c70, 0x2d81, 0xd15x 0x0040 is already there (as a desktop one). The others being server ones again would belong into

Re: [Xen-devel] [PATCH 1/6] x86: detect and initialize Intel CAT feature

2015-03-18 Thread Chao Peng
On Tue, Mar 17, 2015 at 09:00:27AM -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Mar 17, 2015 at 04:11:33PM +0800, Chao Peng wrote: > > On Fri, Mar 13, 2015 at 09:40:13AM -0400, Konrad Rzeszutek Wilk wrote: > > > On Fri, Mar 13, 2015 at 06:13:20PM +0800, Chao Peng wrote: > > > > Detect Intel Cache

Re: [Xen-devel] [PATCH v2 2/2] sched_credit2.c: runqueue_per_core code

2015-03-18 Thread Dario Faggioli
On Wed, 2015-03-18 at 07:56 +, Jan Beulich wrote: > >>> On 17.03.15 at 19:18, wrote: > > --- a/xen/common/sched_credit2.c > > +++ b/xen/common/sched_credit2.c > > @@ -1936,12 +1936,8 @@ static void init_pcpu(const struct scheduler *ops, > > int cpu) > > } > > > > /* Figure out wh

Re: [Xen-devel] [PATCH V2] Add flag to start info regarding virtual mapped p2m list

2015-03-18 Thread Ian Campbell
On Tue, 2015-03-17 at 06:50 +0100, Juergen Gross wrote: > On 03/04/2015 12:41 PM, Ian Campbell wrote: > > On Wed, 2015-03-04 at 12:22 +0100, Juergen Gross wrote: > >> It would either be used like intended, > > > > Which is how? That is what is really missing here. > > > > So far this appears to be

Re: [Xen-devel] [PATCH 1/3] tools/libxl/libxl_qmp.c: Make sure sun_path is NULL terminated in qmp_open

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 10:05 +, PRAMOD DEVENDRA wrote: Please can you arrange in the future to chain your series into a single thread. That means that each N/3 mail should have a References and/or In-reply-to header pointing at either the 0/N mail or the (N-1)/N mail in the series. http://wiki

Re: [Xen-devel] [PATCH 2/2] tools/libxl/libxl_qmp.c: Close fds on error path in qmp_open

2015-03-18 Thread Wei Liu
On Wed, Mar 18, 2015 at 06:50:35AM +, PRAMOD DEVENDRA wrote: > From: Pramod Devendra > > Signed-off-by: Pramod Devendra > CC: Ian Jackson > CC: Stefano Stabellini > CC: Ian Campbell > CC: Wei Liu Thanks. The patch content looks good. However the patch title and commit message are not

Re: [Xen-devel] Any work on sharing of large multi-page segments?

2015-03-18 Thread Ian Campbell
On Tue, 2015-03-17 at 17:45 -0600, Andrew Warkentin wrote: > On 3/17/15, Jan Beulich wrote: > > And how would that be significantly different from the batching > > that's already built into the grant table hypercall? > > > I guess it does do more or less what I want already. I was looking > more a

Re: [Xen-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-18 Thread Ian Campbell
On Wed, 2015-03-18 at 15:32 +0800, Chen, Tiejun wrote: > > I think the _libxl_ message needs to be just "Unable to detect graphics > > passthru kind". i.e. it can't/shouldn't reference anything to do with xl > > config options etc (which would make no sense if libvirt was being > > used). > > > > T

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-18 Thread David Vrabel
On 16/03/15 10:31, Juergen Gross wrote: > On 03/16/2015 11:03 AM, Daniel Kiper wrote: >> On Mon, Mar 16, 2015 at 06:35:04AM +0100, Juergen Gross wrote: >>> On 03/11/2015 04:40 PM, Boris Ostrovsky wrote: On 03/11/2015 10:42 AM, David Vrabel wrote: > On 10/03/15 13:35, Boris Ostrovsky wrote:

Re: [Xen-devel] [PATCH V2] Add flag to start info regarding virtual mapped p2m list

2015-03-18 Thread Juergen Gross
On 03/18/2015 10:59 AM, Ian Campbell wrote: On Tue, 2015-03-17 at 06:50 +0100, Juergen Gross wrote: On 03/04/2015 12:41 PM, Ian Campbell wrote: On Wed, 2015-03-04 at 12:22 +0100, Juergen Gross wrote: It would either be used like intended, Which is how? That is what is really missing here. S

Re: [Xen-devel] [PATCH v2 3/5] xen: print online pCPUs and free pCPUs when dumping

2015-03-18 Thread Jan Beulich
>>> On 17.03.15 at 16:33, wrote: > @@ -671,12 +678,17 @@ void dump_runq(unsigned char key) > sched_smt_power_savings? "enabled":"disabled"); > printk("NOW=0x%08X%08X\n", (u32)(now>>32), (u32)now); > > +print_cpumap("Online Cpus", &cpu_online_map); > +if ( cpumask_weigh

Re: [Xen-devel] [PATCH V2] Add flag to start info regarding virtual mapped p2m list

2015-03-18 Thread Ian Campbell
On Wed, 2015-03-18 at 11:59 +0100, Juergen Gross wrote: > > Is there not an ABI change somewhere else relating to the exposure of > > the cr3+vaddr+size? If so why is it not in this patch? > > Commit 50bd1f0825339dfacde471df7664729216fc46e3 > > > Ideally whichever file which needs to change in x

Re: [Xen-devel] [PATCH v3 4/6] tools/libxl: Allow limiting amount copied by datacopier

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 13:29 +, Ross Lagerwall wrote: > Currently, a datacopier will unconditionally read until EOF on its read fd. > > For migration v2, libxl needs to read records of a specific length out of the > migration stream, without reading any further data. > > Introduce a parameter,

Re: [Xen-devel] [PATCH v3 5/6] tools/libxl: Extend datacopier to support reading into a buffer

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 13:29 +, Ross Lagerwall wrote: > Currently a datacopier may source its data from an fd or local buffer, but its > destination must be an fd. For migration v2, libxl needs to read from the > migration stream into a local buffer. > > Implement a "read into local buffer" mo

Re: [Xen-devel] Upstream QEMU based stubdom and rump kernel

2015-03-18 Thread Martin Lucina
(Adding some of the Mirage folks to Cc:) wei.l...@citrix.com said: > Hi all > > I'm now working on upstream QEMU stubdom, and rump kernel seems to be a > good fit for this purpose. > > A bit background information. A stubdom is a service domain. With QEMU > stubdom we are able to run QEMU devic

Re: [Xen-devel] Upstream QEMU based stubdom and rump kernel

2015-03-18 Thread Martin Lucina
po...@rumpkernel.org said: > etfs isn't a file system, e.g. it doesn't allow listing files or > removing them, but it does give you complete control of what happens > when data is read or written for /some/path. But based on the other > posts, sounds like it might be enough for what you need. > >

Re: [Xen-devel] Upstream QEMU based stubdom and rump kernel

2015-03-18 Thread Martin Lucina
ian.campb...@citrix.com said: > On Tue, 2015-03-17 at 15:27 +, Wei Liu wrote: > > This looks most interesting as it implies we can easily pipe a console > > to it. > > BTW, rather than rawe consoles we should probably consider using the > channel extension: http://xenbits.xen.org/docs/unstable

Re: [Xen-devel] [PATCH v2 3/5] xen: print online pCPUs and free pCPUs when dumping

2015-03-18 Thread Dario Faggioli
On Wed, 2015-03-18 at 11:03 +, Jan Beulich wrote: > >>> On 17.03.15 at 16:33, wrote: > > @@ -671,12 +678,17 @@ void dump_runq(unsigned char key) > > sched_smt_power_savings? "enabled":"disabled"); > > printk("NOW=0x%08X%08X\n", (u32)(now>>32), (u32)now); > > > > +print

Re: [Xen-devel] Upstream QEMU based stubdom and rump kernel

2015-03-18 Thread Ian Campbell
On Wed, 2015-03-18 at 12:24 +0100, Martin Lucina wrote: > ian.campb...@citrix.com said: > > On Tue, 2015-03-17 at 15:27 +, Wei Liu wrote: > > > This looks most interesting as it implies we can easily pipe a console > > > to it. > > > > BTW, rather than rawe consoles we should probably consider

Re: [Xen-devel] [PATCH v3 6/6] tools/libxl: Adjust datacopiers POLLHUP handling when the fd is also readable

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 13:29 +, Ross Lagerwall wrote: > From: Andrew Cooper > > POLLHUP|POLLIN is a valid revent to receive when there is readable data in a > pipe, but the writable fd has been closed. This occurs in migration v2 when > the legacy conversion process (which transforms the data

Re: [Xen-devel] [PATCH v8 21/21] xl: vNUMA support

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 09:52 +, Wei Liu wrote: > This patch includes configuration options parser and documentation. > > Please find the hunk to xl.cfg.pod.5 for more information. > > Signed-off-by: Wei Liu Acked-by: Ian Campbell Ian. ___ Xen-d

Re: [Xen-devel] [PATCH v8 18/21] libxlu: record location when parsing values

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 09:52 +, Wei Liu wrote: > Originally only setting has line number recorded. Since we're moving to > more sophisticated API, record the location for individual value. It is > useful for error reporting. > > Signed-off-by: Wei Liu Acked-by: Ian Campbell > Cc: Ian Jackson

Re: [Xen-devel] [PATCH v2] Build: Fix stubdom vtpm build failure

2015-03-18 Thread Ian Campbell
On Tue, 2015-03-17 at 10:20 +0100, Olaf Hering wrote: > On Mon, Mar 16, Quan Xu wrote: > > > Typedefs are duplicated in stubdom/vtpmmgr/tcg.h and supported compilers > > do not cope with current staging branch. > > This version finally compiles. Thanks! Thanks. I translated this into a Tested-by

Re: [Xen-devel] [PATCH v3 0/6] tools/libxl: Improvements to libxl__datacopier

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 13:27 +, Ross Lagerwall wrote: > To support migration v2, we need far more flexibility out of the datacopier. Applied, thanks. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2] Build: Fix stubdom vtpm build failure

2015-03-18 Thread Xu, Quan
Thanks, ok. Quan > -Original Message- > From: Ian Campbell [mailto:ian.campb...@citrix.com] > Sent: Wednesday, March 18, 2015 8:02 PM > To: Olaf Hering > Cc: Xu, Quan; xen-devel@lists.xen.org; dgde...@tycho.nsa.gov; > andrew.coop...@citrix.com > Subject: Re: [PATCH v2] Build: Fix stubdom

Re: [Xen-devel] [PATCH 2/2] tools/libxl/libxl_qmp.c: Close fds on error path in qmp_open

2015-03-18 Thread Ian Campbell
On Wed, 2015-03-18 at 10:15 +, Wei Liu wrote: > On Wed, Mar 18, 2015 at 06:50:35AM +, PRAMOD DEVENDRA wrote: > > From: Pramod Devendra > > > > Signed-off-by: Pramod Devendra > > CC: Ian Jackson > > CC: Stefano Stabellini > > CC: Ian Campbell > > CC: Wei Liu > > Thanks. > > The patc

Re: [Xen-devel] [PATCH 1/3] libxl: In domain death search, start search at first domid we want

2015-03-18 Thread Ian Campbell
On Tue, 2015-03-17 at 09:30 -0600, Jim Fehlig wrote: > From: Ian Jackson > > From: Ian Jackson > > When domain_death_xswatch_callback needed a further call to > xc_domain_getinfolist it would restart it with the last domain it > found rather than the first one it wants. > > If it only wants on

Re: [Xen-devel] [PATCH 2/3] libxl: Domain destroy: unlock userdata earlier

2015-03-18 Thread Ian Campbell
On Tue, 2015-03-17 at 17:34 +, Wei Liu wrote: > On Tue, Mar 17, 2015 at 09:30:58AM -0600, Jim Fehlig wrote: > > From: Ian Jackson > > > > Unlock the userdata before we actually call xc_domain_destroy. This > > leaves open the possibility that other libxl callers will see the > > half-destroy

Re: [Xen-devel] [PATCH 3/3] libxl: Domain destroy: fork

2015-03-18 Thread Ian Campbell
On Tue, 2015-03-17 at 09:30 -0600, Jim Fehlig wrote: > From: Ian Jackson > > Call xc_domain_destroy in a subprocess. That allows us to do so > asynchronously, rather than blocking the whole process calling libxl. > > The changes in detail: > > * Provide an libxl__ev_child in libxl__domain_des

Re: [Xen-devel] [PATCH 3/3] libxl: Domain destroy: fork

2015-03-18 Thread Ian Campbell
On Tue, 2015-03-17 at 18:04 +, Wei Liu wrote: > > +} else { > > +LOGE(ERROR, > > + "xc_domain_destroy failed for %d (with difficult errno value %d)", > > Indentation is wrong. It is preferable to pull back the indentation of a string literal rather than wrap it in order to

Re: [Xen-devel] [PATCH] flask/policy: fix static device labeling examples

2015-03-18 Thread Ian Campbell
On Wed, 2015-03-11 at 10:59 -0400, Daniel De Graaf wrote: > The definitions of static device labels must be placed at the end of the > policy.conf before passing it to checkpolicy; the existing examples > (which are commented out) are in the wrong location. Create a new file > for device contexts

Re: [Xen-devel] [PATCH v8 00/21] Virtual NUMA for PV and HVM

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 09:52 +, Wei Liu wrote: > Hi all > > This is version 8 of this series rebased on top of master. Applied, thanks. (except patch #1 which was already in). Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.x

Re: [Xen-devel] [PATCH 2/3] tools/libxl/libxl_cpuid.c: Fix leak of resstr on error path

2015-03-18 Thread Ian Campbell
On Tue, 2015-03-17 at 15:44 +, Wei Liu wrote: > On Mon, Mar 16, 2015 at 10:06:17AM +, PRAMOD DEVENDRA wrote: > > From: Pramod Devendra > > > > Signed-off-by: Pramod Devendra > > CC: Ian Jackson > > CC: Stefano Stabellini > > CC: Ian Campbell > > CC: Wei Liu > > Acked-by: Wei Liu A

Re: [Xen-devel] [PATCH 3/3] tools/libxc/xc_linux_osdep.c: Don't leak mmap() mapping on map_foreign_bulk() error path

2015-03-18 Thread Ian Campbell
On Tue, 2015-03-17 at 15:45 +, Wei Liu wrote: > On Mon, Mar 16, 2015 at 10:06:50AM +, PRAMOD DEVENDRA wrote: > > From: Pramod Devendra > > > > Signed-off-by: Pramod Devendra > > CC: Ian Jackson > > CC: Stefano Stabellini > > CC: Ian Campbell > > CC: Wei Liu > > Acked-by: Wei Liu A

Re: [Xen-devel] [PATCH] tools/libxl: avoid comparing an unsigned int to -1

2015-03-18 Thread Ian Campbell
On Tue, 2015-03-17 at 15:55 +, Wei Liu wrote: > On Mon, Mar 16, 2015 at 10:12:34AM +, Koushik Chakravarty wrote: > > Signed-off-by: Koushik Chakravarty > > CC: Ian Jackson > > CC: Stefano Stabellini > > CC: Ian Campbell > > CC: Wei Liu > > Acked-by: Wei Liu Applied, thanks. > Ian J

[Xen-devel] [PATCH] tools/libxl: close the logfile_w and null file descriptors in libxl__spawn_qdisk_backend() error path

2015-03-18 Thread Koushik Chakravarty
Signed-off-by: Koushik Chakravarty CC: Ian Jackson CC: Stefano Stabellini CC: Ian Campbell CC: Wei Liu --- tools/libxl/libxl_dm.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index cb006df..2678be2 100644 --- a/t

Re: [Xen-devel] [PATCH v3 0/3] Xen/FLASK policy updates for device contexts

2015-03-18 Thread Stephen Smalley
On 03/17/2015 04:43 PM, Daniel De Graaf wrote: > In order to support assigning security lables to ARM device tree nodes > in Xen's XSM policy, a new ocontext type is needed in the security > policy. > > In addition to adding the new ocontext, the existing I/O memory range > ocontext is expanded to

[Xen-devel] (v2) VT-d Posted-interrupt (PI) design for XEN

2015-03-18 Thread Wu, Feng
VT-d Posted-interrupt (PI) design for XEN Background == With the development of virtualization, there are more and more device assignment requirements. However, today when a VM is running with assigned devices (such as, NIC), external interrupt handling for the assigned devices always need

Re: [Xen-devel] Upstream QEMU based stubdom and rump kernel

2015-03-18 Thread Stefano Stabellini
On Wed, 18 Mar 2015, Ian Campbell wrote: > On Wed, 2015-03-18 at 12:24 +0100, Martin Lucina wrote: > > ian.campb...@citrix.com said: > > > On Tue, 2015-03-17 at 15:27 +, Wei Liu wrote: > > > > This looks most interesting as it implies we can easily pipe a console > > > > to it. > > > > > > BTW

Re: [Xen-devel] [PATCH v2 1/5] libxl: Add ERROR_NOTFOUND for libxl_domain_info when it cannot find the domain

2015-03-18 Thread Ian Campbell
On Fri, 2015-03-13 at 16:26 -0400, Konrad Rzeszutek Wilk wrote: > And use that for all of its callers in the tree. I wonder -- is it better to have a generic ERROR_NOTFOUND for anything which is not found, or to have a specific ERROR_DOMAIN_NOTFOUND (likewise for other things). Any opinions? I'm

Re: [Xen-devel] [PATCH v2 2/5] libxl: vcpuset: Return error values.

2015-03-18 Thread Ian Campbell
On Fri, 2015-03-13 at 16:26 -0400, Konrad Rzeszutek Wilk wrote: > The function does not return any values at all. Convert the > internal libxl ones (ERROR_FAIL, ..., etc) to positive values > and for the other cases just return standard libxl values. It's not clear why you want to do this, in part

Re: [Xen-devel] [PATCH v2 2/5] libxl: vcpuset: Return error values.

2015-03-18 Thread Ian Campbell
On Wed, 2015-03-18 at 13:06 +, Ian Campbell wrote: > On Fri, 2015-03-13 at 16:26 -0400, Konrad Rzeszutek Wilk wrote: > > The function does not return any values at all. Convert the > > internal libxl ones (ERROR_FAIL, ..., etc) to positive values > > and for the other cases just return standard

Re: [Xen-devel] OpenStack - Libvirt+Xen CI overview : anyone interested in a walk/through or presentation on how it works

2015-03-18 Thread Lars Kurth
Hi, I added all the people who raised their hands so far to the TO list. As far as I can tell we have people from the following timezones: GMT, GMT+1, MTZ, ETZ - if I got this wrong, please let me know your timezone. Depending on when we have the presentation, we will need to consider daylight

Re: [Xen-devel] Upstream QEMU based stubdom and rump kernel

2015-03-18 Thread Antti Kantee
On 18/03/15 11:22, Martin Lucina wrote: po...@rumpkernel.org said: etfs isn't a file system, e.g. it doesn't allow listing files or removing them, but it does give you complete control of what happens when data is read or written for /some/path. But based on the other posts, sounds like it migh

Re: [Xen-devel] [PATCH v2 5/5] libxl: vcpu-set - allow to decrease vcpu count on overcommitted guests (v3)

2015-03-18 Thread Ian Campbell
On Fri, 2015-03-13 at 16:26 -0400, Konrad Rzeszutek Wilk wrote: > We have a check to warn the user if they are overcommitting. > But the check only checks the hosts CPU amount and does > not take into account the case when the user is trying to fix > the overcommit. That is - they want to limit the

Re: [Xen-devel] [PATCH v2 3/5] libxl: vcpuset: Check max_vcpus argument against the maximum number of vCPUs the guest has set.

2015-03-18 Thread Ian Campbell
On Fri, 2015-03-13 at 16:26 -0400, Konrad Rzeszutek Wilk wrote: > The maximum number of VCPUs the guest can have is determined during > domain creation and is set by 'maxvcpus' parameter (in the guest > config). Trying to set the amount of vCPUs above said value > in vcpuset will result in an error

Re: [Xen-devel] [PATCH] xenstore: use relative path for device-model node

2015-03-18 Thread Ian Campbell
On Fri, 2015-03-13 at 10:38 +, Wei Liu wrote: > Signed-off-by: Wei Liu I suppose that somewhere in the libxl series that QEMU_TRADITIONAL_REVISION will need updating to incorporate this. It might be useful to note where in that series this can safely be done.. > --- > xenstore.c | 24 ++

Re: [Xen-devel] [PATCH 1/5] libxl: remove DM path in libxl__device_model_destroy

2015-03-18 Thread Ian Campbell
On Fri, 2015-03-13 at 10:34 +, Wei Liu wrote: > ... because it is the right place to clean up device model stuffs. ... and not devices_destroy_cb because it is the right ... (also "stuff"). > And the path should use LIBXL_TOOLSTACK_DOMID instead of hardcoded 0. Between this and what is in t

Re: [Xen-devel] [PATCH v2 4/5] libxl: vcpuset: Remove useless limit on max_vcpus.

2015-03-18 Thread Ian Campbell
On Fri, 2015-03-13 at 16:26 -0400, Konrad Rzeszutek Wilk wrote: > The check is superflous. If the 'max_vcpus' (argument > value) is greater than pCPU and --ignore-host has not > been supplied we would print an warning and return > and not call this code. > > If the --ignore-host parameter had bee

Re: [Xen-devel] [PATCH 1/5] libxl: remove DM path in libxl__device_model_destroy

2015-03-18 Thread Ian Campbell
On Wed, 2015-03-18 at 13:21 +, Ian Campbell wrote: > On Fri, 2015-03-13 at 10:34 +, Wei Liu wrote: > > ... because it is the right place to clean up device model stuffs. > > ... and not devices_destroy_cb because it is the right ... > > (also "stuff"). > > > And the path should use LIBXL

Re: [Xen-devel] [PATCH 2/5] libxl: use LIBXL_TOOLSTACK_DOMID

2015-03-18 Thread Ian Campbell
On Fri, 2015-03-13 at 10:34 +, Wei Liu wrote: > The function in question is libxl__spawn_local_dm. We should use > LIBXL_TOOLSTACK_DOMID when constructing xenstore path. > > Currently LIBXL_TOOLSTACK_DOMID is 0, so this patch introduces no > functional change. As I mentioned on the previous p

Re: [Xen-devel] [PATCH 3/5] libxl: use new QEMU xenstore protocol

2015-03-18 Thread Ian Campbell
On Fri, 2015-03-13 at 10:34 +, Wei Liu wrote: > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > index 3dedad4..4a38455 100644 > --- a/tools/libxl/libxl_dm.c > +++ b/tools/libxl/libxl_dm.c > @@ -998,7 +998,7 @@ void libxl__spawn_stub_dm(libxl__egc *egc, > libxl__stub_dm_spawn_sta

Re: [Xen-devel] [PATCH 4/5] libxl: wait for stubdom to be ready

2015-03-18 Thread Ian Campbell
On Fri, 2015-03-13 at 10:34 +, Wei Liu wrote: > Watch /local/domain/$dm_domid/device-model/$domid/state, wait until > state turns "running" then unpause guest. > > LIBXL_STUBDOM_START_TIMEOUT is the timeout used wait for stubdom to be > ready. My test on a very old machine (Core 2 6400) showed

Re: [Xen-devel] [PATCH v2 2/5] libxl: vcpuset: Return error values.

2015-03-18 Thread Konrad Rzeszutek Wilk
On Wed, Mar 18, 2015 at 01:06:18PM +, Ian Campbell wrote: > On Fri, 2015-03-13 at 16:26 -0400, Konrad Rzeszutek Wilk wrote: > > The function does not return any values at all. Convert the > > internal libxl ones (ERROR_FAIL, ..., etc) to positive values > > and for the other cases just return s

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-18 Thread Juergen Gross
On 03/18/2015 11:36 AM, David Vrabel wrote: On 16/03/15 10:31, Juergen Gross wrote: On 03/16/2015 11:03 AM, Daniel Kiper wrote: On Mon, Mar 16, 2015 at 06:35:04AM +0100, Juergen Gross wrote: On 03/11/2015 04:40 PM, Boris Ostrovsky wrote: On 03/11/2015 10:42 AM, David Vrabel wrote: On 10/03/1

Re: [Xen-devel] [PATCH] dpci: Put the dpci back on the list if scheduled from another CPU.

2015-03-18 Thread Konrad Rzeszutek Wilk
On Wed, Mar 18, 2015 at 07:38:12AM +, Jan Beulich wrote: > >>> On 17.03.15 at 18:15, wrote: > > On Tue, Mar 17, 2015 at 04:06:14PM +, Jan Beulich wrote: > >> >>> On 17.03.15 at 16:38, wrote: > >> > --- a/xen/drivers/passthrough/io.c > >> > +++ b/xen/drivers/passthrough/io.c > >> > @@ -804

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-18 Thread David Vrabel
On 18/03/15 13:57, Juergen Gross wrote: > On 03/18/2015 11:36 AM, David Vrabel wrote: >> On 16/03/15 10:31, Juergen Gross wrote: >>> On 03/16/2015 11:03 AM, Daniel Kiper wrote: On Mon, Mar 16, 2015 at 06:35:04AM +0100, Juergen Gross wrote: > On 03/11/2015 04:40 PM, Boris Ostrovsky wrote: >

Re: [Xen-devel] [RFC PATCH] dpci: Put the dpci back on the list if running on another CPU.

2015-03-18 Thread Konrad Rzeszutek Wilk
On Wed, Mar 18, 2015 at 07:41:55AM +, Jan Beulich wrote: > >>> On 17.03.15 at 18:44, wrote: > > As you can see to preserve the existing functionality such as > > being able to schedule N amount of interrupt injections > > for the N interrupts we might get - I modified '->masked' > > to be an a

Re: [Xen-devel] [PATCH v2 2/5] libxl: vcpuset: Return error values.

2015-03-18 Thread Dario Faggioli
On Wed, 2015-03-18 at 13:08 +, Ian Campbell wrote: > On Wed, 2015-03-18 at 13:06 +, Ian Campbell wrote: > > On Fri, 2015-03-13 at 16:26 -0400, Konrad Rzeszutek Wilk wrote: > > > The function does not return any values at all. Convert the > > > internal libxl ones (ERROR_FAIL, ..., etc) to p

Re: [Xen-devel] [PATCH v3 22/24] tools/libxl: arm: Use an higher value for the GIC phandle

2015-03-18 Thread Julien Grall
Hi Ian, On 24/02/2015 10:08, Ian Campbell wrote: On Mon, 2015-02-23 at 22:02 +, Julien Grall wrote: On 23/02/2015 14:36, Ian Campbell wrote: On Thu, 2015-01-29 at 13:48 +, Julien Grall wrote: On 29/01/15 12:28, Stefano Stabellini wrote: On Thu, 29 Jan 2015, Julien Grall wrote: On 2

Re: [Xen-devel] [PATCH v2 2/5] libxl: vcpuset: Return error values.

2015-03-18 Thread Konrad Rzeszutek Wilk
On Wed, Mar 18, 2015 at 02:09:09PM +, Dario Faggioli wrote: > On Wed, 2015-03-18 at 13:08 +, Ian Campbell wrote: > > On Wed, 2015-03-18 at 13:06 +, Ian Campbell wrote: > > > On Fri, 2015-03-13 at 16:26 -0400, Konrad Rzeszutek Wilk wrote: > > > > The function does not return any values a

Re: [Xen-devel] OpenStack - Libvirt+Xen CI overview : anyone interested in a walk/through or presentation on how it works

2015-03-18 Thread Wei Liu
On Wed, Mar 18, 2015 at 01:12:50PM +, Lars Kurth wrote: > Hi, > > I added all the people who raised their hands so far to the TO list. As far > as I can tell we have people from the following timezones: GMT, GMT+1, MTZ, > ETZ - if I got this wrong, please let me know your timezone. Depending

Re: [Xen-devel] [PATCHv1] xen/balloon: disable memory hotplug in PV guests

2015-03-18 Thread Daniel Kiper
On Wed, Mar 18, 2015 at 01:59:58PM +, David Vrabel wrote: > On 18/03/15 13:57, Juergen Gross wrote: > > On 03/18/2015 11:36 AM, David Vrabel wrote: > >> On 16/03/15 10:31, Juergen Gross wrote: > >>> On 03/16/2015 11:03 AM, Daniel Kiper wrote: > On Mon, Mar 16, 2015 at 06:35:04AM +0100, Jue

Re: [Xen-devel] [PATCH v2 2/2] sched_credit2.c: runqueue_per_core code

2015-03-18 Thread George Dunlap
On 03/18/2015 08:53 AM, Dario Faggioli wrote: >>> @@ -1986,9 +1982,13 @@ static void init_pcpu(const struct scheduler *ops, >>> int cpu) >>> static void * >>> csched2_alloc_pdata(const struct scheduler *ops, int cpu) >>> { >>> -/* Check to see if the cpu is online yet */ >>> -/* Note: c

[Xen-devel] [PATCH V4] Add flag to start info regarding virtual mapped p2m list

2015-03-18 Thread Juergen Gross
Xen pv domains are using a domain private p2m list to convert guest pfns to mfns. This p2m list has to be updated by the Xen tools during domain restore and migration, as the mfns will most likely change. In order to locate the p2m list the Xen tools need an interface provided by the guest. Up to n

Re: [Xen-devel] [PATCH v2 0/7] Some (not only) cpupool related fixes and improvements

2015-03-18 Thread Ian Campbell
On Fri, 2015-03-13 at 12:08 +0100, Dario Faggioli wrote: > Dario Faggioli (7): > xl: turn some int local variable into bool > xl: add -c/--cpupool option to `xl list' > libxl: introduce libxl_cpupool_cpu{add,remove}_cpumap() > xl: enable using ranges of pCPUs when manipulati

Re: [Xen-devel] [PATCH v2 2/2] sched_credit2.c: runqueue_per_core code

2015-03-18 Thread Jan Beulich
>>> On 18.03.15 at 16:26, wrote: > In both cases there's a slight risk in using system_state to determine > whether to rely on cpu_data[] or not, because there's actually a window > for each processor after system_state == SYS_STATE_smp_boot where > cpu_data[] is *not* initialized, but it's not ob

Re: [Xen-devel] [PATCH] dpci: Put the dpci back on the list if scheduled from another CPU.

2015-03-18 Thread Jan Beulich
>>> On 18.03.15 at 14:58, wrote: > On Wed, Mar 18, 2015 at 07:38:12AM +, Jan Beulich wrote: >> >>> On 17.03.15 at 18:15, wrote: >> > The latest one (please see attached) would cause an dead-lock iff >> > on the CPU we are running the softirq and an do_IRQ comes for the >> > exact dpci we are

Re: [Xen-devel] [PATCH v2 2/2] sched_credit2.c: runqueue_per_core code

2015-03-18 Thread George Dunlap
On 03/18/2015 03:59 PM, Jan Beulich wrote: On 18.03.15 at 16:26, wrote: >> In both cases there's a slight risk in using system_state to determine >> whether to rely on cpu_data[] or not, because there's actually a window >> for each processor after system_state == SYS_STATE_smp_boot where >>

Re: [Xen-devel] (v2) VT-d Posted-interrupt (PI) design for XEN

2015-03-18 Thread Konrad Rzeszutek Wilk
On Wed, Mar 18, 2015 at 12:44:21PM +, Wu, Feng wrote: > VT-d Posted-interrupt (PI) design for XEN > > Background > == > With the development of virtualization, there are more and more device > assignment requirements. However, today when a VM is running with > assigned devices (such as

Re: [Xen-devel] [PATCH] dpci: Put the dpci back on the list if scheduled from another CPU.

2015-03-18 Thread Konrad Rzeszutek Wilk
On Wed, Mar 18, 2015 at 04:06:37PM +, Jan Beulich wrote: > >>> On 18.03.15 at 14:58, wrote: > > On Wed, Mar 18, 2015 at 07:38:12AM +, Jan Beulich wrote: > >> >>> On 17.03.15 at 18:15, wrote: > >> > The latest one (please see attached) would cause an dead-lock iff > >> > on the CPU we are

Re: [Xen-devel] [PATCH 01/14] libxc: Replaces tabs with spaces in xc_cpupool_freeinfo

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote: > The goto looks very wrong when the rest of the code > has spaces. > > Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Ian Campbell ___ Xen-devel mailing list Xen-devel@lists.xen.org

Re: [Xen-devel] [RFC PATCH] xen-netback: making the bandwidth limiter runtime settable

2015-03-18 Thread Imre Palik
On 03/17/15 12:17, Wei Liu wrote: > On Fri, Mar 13, 2015 at 01:51:05PM +0100, Imre Palik wrote: >> From: "Palik, Imre" >> >> With the current netback, the bandwidth limiter's parameters are only >> settable during vif setup time. This patch register a watch on them, and >> thus makes them runtime

Re: [Xen-devel] [PATCH 05/14] libxl: xc_physdev_map return -1 and populate errno.

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote: > The users of these (qemu) check for a negative value > so we are safe in regards to that. However they > also use the return value to inform the user of the > error. IIRC I saw a qemu patch go past to fix the callers? > Signed-off-

Re: [Xen-devel] [PATCH 06/14] libxl: Return negative value and propagate errno for xc_offline_page API

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote: > Instead of returning -Exx we now return -1 for error. > We could stash the -Exx values in errno values but why - the > underlaying functions we call all stash the proper errno > value. Hence we just propagate it up wherver it is need

Re: [Xen-devel] [PATCH 07/14] libxl: Fix xc_pm API calls to return negative error and stash error in errno.

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote: > Oddly enough the user of this API did the right thing - > check for return being negative and used 'errno' for the > real error. > > Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Ian Campbell _

Re: [Xen-devel] [PATCH 08/14] libxl: Fix xc_tmem_control to return proper error.

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote: > The API returns now negative values on error and stashes > the error in errno. Fix the user of this API. > > The 'xc_hypercall_bounce_pre' can fail - and if so it will > stash its errno values - no need to over-write it. > > Signed

Re: [Xen-devel] [PATCH v2] xentop: add support for qdisks

2015-03-18 Thread Ian Campbell
On Wed, 2015-03-11 at 11:51 -0600, Charles Arnold wrote: > Now that Xen uses qdisks by default and qemu does not write out > statistics to sysfs this patch queries the QMP for disk statistics. > > This patch depends on libyajl for parsing statistics returned from > QMP. The runtime requires libyaj

Re: [Xen-devel] [PATCH 05/14] libxl: xc_physdev_map return -1 and populate errno.

2015-03-18 Thread Konrad Rzeszutek Wilk
On Wed, Mar 18, 2015 at 04:21:52PM +, Ian Campbell wrote: > On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote: > > The users of these (qemu) check for a negative value > > so we are safe in regards to that. However they > > also use the return value to inform the user of the > > er

Re: [Xen-devel] [PATCH v2 2/2] sched_credit2.c: runqueue_per_core code

2015-03-18 Thread Dario Faggioli
On Wed, 2015-03-18 at 16:08 +, George Dunlap wrote: > On 03/18/2015 03:59 PM, Jan Beulich wrote: > On 18.03.15 at 16:26, wrote: > >> In both cases there's a slight risk in using system_state to determine > >> whether to rely on cpu_data[] or not, because there's actually a window > >> for

Re: [Xen-devel] [PATCH 02/14] libxl: Propagate errno from hypercall instead of anything else.

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote: > After we have done the hypercall - the errno has the failure > code. However our usage of pthread and munmap can trigger them > to manipulate the errno with their failure values. That would > be bad as what we care about is just the

Re: [Xen-devel] [PATCH 03/14] libxc: xc_core_arch_memory_map_get populate errno

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote: > with proper value (ENOMEM) when reporting failures. > > Signed-off-by: Konrad Rzeszutek Wilk > --- > [v1: errno before using PERROR] > --- > tools/libxc/xc_core_arm.c | 1 + > tools/libxc/xc_core_x86.c | 1 + > 2 files changed, 2

Re: [Xen-devel] [PATCH 04/14] libxc: Fix xc_domain_get_tsc_info to return -1 instead of -Exx.

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote: > We don't need to put fill errno because xc_hypercall_buffer_alloc > fills the errno with the appropiate errno values and we just > need to pass them up the stack. "appropriate" > Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Ian

Re: [Xen-devel] [PATCH 13/14] libxl: Don't assign return value to errno for E820 get/set xc_ calls.

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote: > We should be using the errno that the hypercall left > instead of overwritting it with the return value. "overwriting" > Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Ian Campbell __

Re: [Xen-devel] Any work on sharing of large multi-page segments?

2015-03-18 Thread George Dunlap
On Tue, Mar 17, 2015 at 11:45 PM, Andrew Warkentin wrote: > On 3/17/15, George Dunlap wrote: >> Any deduplication code would run in as a process probably in domain 0, >> and may be somewhat slow; but the actual mechanism of sharing is a >> generic mechanism in the hypervisor which any client can

Re: [Xen-devel] [PATCH v1] Fix libxc return -E misusage.

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote: > Hey, > > Please see the following set of patches which fix the various > usage of return -Exx instead of return -1 for errors (and > stashing the error value in errno). All of them, or just a subset of the callpaths? If it's all o

Re: [Xen-devel] [RFC PATCH] xen-netback: making the bandwidth limiter runtime settable

2015-03-18 Thread Wei Liu
On Wed, Mar 18, 2015 at 05:21:08PM +0100, Imre Palik wrote: > On 03/17/15 12:17, Wei Liu wrote: > > On Fri, Mar 13, 2015 at 01:51:05PM +0100, Imre Palik wrote: > >> From: "Palik, Imre" > >> > >> With the current netback, the bandwidth limiter's parameters are only > >> settable during vif setup ti

Re: [Xen-devel] [RFC PATCH] dpci: Put the dpci back on the list if running on another CPU.

2015-03-18 Thread Jan Beulich
>>> On 18.03.15 at 15:06, wrote: > On Wed, Mar 18, 2015 at 07:41:55AM +, Jan Beulich wrote: >> >>> On 17.03.15 at 18:44, wrote: >> > As you can see to preserve the existing functionality such as >> > being able to schedule N amount of interrupt injections >> > for the N interrupts we might ge

Re: [Xen-devel] [PATCH 09/14] libxl: Check xc_domain_maximum_gpfn for negative return values

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote: > Instead of assuming everything is always OK. > > Signed-off-by: Konrad Rzeszutek Wilk > --- > tools/libxc/xc_core_arm.c| 14 +++--- > tools/libxc/xc_core_x86.c| 21 + > tools/libxc/xc_domain_sav

Re: [Xen-devel] [PATCH 10/14] libxl: Check xc_maximum_ram_page for negative return values.

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote: > Instead of assuming everything is always OK. > > Signed-off-by: Konrad Rzeszutek Wilk > --- > tools/libxc/xg_save_restore.h | 3 +++ > tools/misc/xen-mfndump.c | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > di

Re: [Xen-devel] [PATCH 11/14] libxl: If xc_domain_add_to_physmap fails, include errno value

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote: $subject says libxl but means libxc. Actually, now I notice it so do almost all of the patches! Once fixed any acks I gave (or will give shortly) can still be applied. > Instead of just the return value. > > Signed-off-by: Konrad R

Re: [Xen-devel] [PATCH v2 2/2] sched_credit2.c: runqueue_per_core code

2015-03-18 Thread Dario Faggioli
On Wed, 2015-03-18 at 15:26 +, George Dunlap wrote: > On 03/18/2015 08:53 AM, Dario Faggioli wrote: > >>> @@ -1986,9 +1982,13 @@ static void init_pcpu(const struct scheduler *ops, > >>> int cpu) > >>> static void * > >>> csched2_alloc_pdata(const struct scheduler *ops, int cpu) > >>> { > >>

Re: [Xen-devel] [PATCH 12/14] libxl: Check xc_sharing_* for proper return values.

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote: > If there is a negative return value - check for that and > also use errno for the proper error value. Was xc_sharing_freed_pages fixed earlier in the series (which is strictly speaking a bisection hazard, but nevermind) or was the e

Re: [Xen-devel] [PATCH 14/14] libxl: Fix do_memory_op to return negative value on errors

2015-03-18 Thread Ian Campbell
On Mon, 2015-03-16 at 11:39 -0400, Konrad Rzeszutek Wilk wrote: > instead of the -Exx values (which should go in errno). > > This patch has HUGE implications. For such a small patch! > There is a lot of APIs > that are using do_memory_op. Fortunatly most of them "Fortunately". > check for 'if

  1   2   >