On Wed, Mar 18, 2015 at 05:21:08PM +0100, Imre Palik wrote: > On 03/17/15 12:17, Wei Liu wrote: > > On Fri, Mar 13, 2015 at 01:51:05PM +0100, Imre Palik wrote: > >> From: "Palik, Imre" <im...@amazon.de> > >> > >> With the current netback, the bandwidth limiter's parameters are only > >> settable during vif setup time. This patch register a watch on them, and > >> thus makes them runtime changeable. > >> > >> When the watch fires, the timer is reset. The timer's mutex is used for > >> fencing the change. > >> > > > > I think this is a valid idea. Just that this commit message is not > > complete. It doesn't describe everything this patch does. > > > >> Cc: Anthony Liguori <aligu...@amazon.com> > >> Signed-off-by: Imre Palik <im...@amazon.de> > >> --- > > [...] > >> queue->rx_queue_max = XENVIF_RX_QUEUE_BYTES; > >> diff --git a/drivers/net/xen-netback/netback.c > >> b/drivers/net/xen-netback/netback.c > >> index cab9f52..bcc1880 100644 > >> --- a/drivers/net/xen-netback/netback.c > >> +++ b/drivers/net/xen-netback/netback.c > >> @@ -641,7 +641,7 @@ static void tx_add_credit(struct xenvif_queue *queue) > >> queue->remaining_credit = min(max_credit, max_burst); > >> } > >> > >> -static void tx_credit_callback(unsigned long data) > >> +void xenvif_tx_credit_callback(unsigned long data) > > > > Please keep this function static. > > The trouble with that, is that now I am initialising credit_timeout.function > in > drivers/net/xen-netback/interface.c . >
Oh, yes. I misread the hunk of common.h. Sorry about the noise. Wei. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
