Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Dario Faggioli
On Fri, 2015-03-06 at 07:36 +, Jan Beulich wrote: > As pointed out in the discussion of the patch at > http://lists.xenproject.org/archives/html/xen-devel/2015-02/msg03256.html > generalizing the conditions here means code elsewhere doesn't need to > take into consideration internals of how lo

[Xen-devel] [PATCH 1/2] libxl: introduce libxl__is_igd_vga_passthru

2015-03-06 Thread Tiejun Chen
While working with qemu, IGD is a specific device in the case of pass through so we need to identify that to handle more later. Here we define a table to record all IGD types currently we can support. Also we need to introduce two helper functions to get vendor and device ids to lookup that table.

[Xen-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-06 Thread Tiejun Chen
Although we already have 'gfx_passthru' in b_info, this doesn' suffice after we want to handle IGD specifically. Now we define a new field of type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually this means we can benefit this to support other specific devices just by extending gf

[Xen-devel] [PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream

2015-03-06 Thread Tiejun Chen
When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,igd-passthru=on". This need to bring a change on tool side. After a discussion with Campbell, we'd like to construct a table to record all IGD dev

Re: [Xen-devel] [PATCH 1/5] x86: allow specifying the NUMA nodes Dom0 should run on

2015-03-06 Thread Jan Beulich
>>> On 03.03.15 at 11:51, wrote: > That would then leave introducing a "relaxed (or "strict", > depending on what we'd like to be the default) mode in the patch > here, controlling whether ->cpu_hard_affinity gets overridden > (and we'd always override ->cpu_soft_affinity). Having implemented thi

Re: [Xen-devel] [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-06 Thread Chen, Tiejun
On 2015/3/6 17:08, Tiejun Chen wrote: Although we already have 'gfx_passthru' in b_info, this doesn' suffice after we want to handle IGD specifically. Now we define a new field of type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually this means we can benefit this to support oth

[Xen-devel] [PATCH 1/5 v2] x86: allow specifying the NUMA nodes Dom0 should run on

2015-03-06 Thread Jan Beulich
... by introducing a "dom0_nodes" option augmenting the "dom0_mem" and "dom0_max_vcpus" ones. Note that this gives meaning to MEMF_exact_node specified alone (i.e. implicitly combined with NUMA_NO_NODE): In such a case any node inside the domain's node mask is acceptable, but no other node. This c

[Xen-devel] VT-d patch ping

2015-03-06 Thread Jan Beulich
Kevin, Yang, there are a number of patches requiring your ack or otherwise: http://lists.xenproject.org/archives/html/xen-devel/2014-12/msg01837.html http://lists.xenproject.org/archives/html/xen-devel/2015-02/msg03260.html http://lists.xenproject.org/archives/html/xen-devel/2015-02/msg03426.htm

Re: [Xen-devel] [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-06 Thread Chentao (Boby)
On 2015/3/5 0:32, Joe Perches wrote: On Wed, 2015-03-04 at 18:32 +, Tao Chen wrote: Defined the string of {xen-pvscsi: } as DRV_PFX, then use it in the pr sentences and DPRINTK. Also fixed up some comments just as eliminate redundant white spaces and format the code. These will make the

[Xen-devel] AMD IOMMU patch ping

2015-03-06 Thread Jan Beulich
Suravee, Aravind, there are two patches requiring your ack or otherwise: http://lists.xenproject.org/archives/html/xen-devel/2015-02/msg03261.html http://lists.xenproject.org/archives/html/xen-devel/2015-02/msg03459.html Please try to reply to patches in a timely manner, at least indicating when

[Xen-devel] [PATCH v5 03/29] xen/PCI: Don't use deprecated function pci_scan_bus_parented()

2015-03-06 Thread Yijing Wang
From: Arnd Bergmann Use pci_scan_root_bus() instead of deprecated function pci_scan_bus_parented(). Signed-off-by: Arnd Bergmann Signed-off-by: Yijing Wang CC: Konrad Rzeszutek Wilk CC: xen-de...@lists.xenproject.org Signed-off-by: Bjorn Helgaas --- drivers/pci/xen-pcifront.c | 11 +++

Re: [Xen-devel] Why gpa instead of mfn is directed used in emulated nic

2015-03-06 Thread Tim Deegan
At 10:14 +0800 on 06 Mar (1425633255), openlui wrote: > At 2015-03-05 19:09:41, "Tim Deegan" wrote: > >Hi, > > > >At 10:54 +0800 on 05 Mar (1425549262), openlui wrote: > >> 2. From the trace info and qemu-dm's log, it seems that it is "GPA" > >> (Guest Physical Address) instead of "MFN" in the IOR

Re: [Xen-devel] [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-06 Thread Chentao (Boby)
On 2015/3/4 18:34, David Vrabel wrote: On 04/03/15 18:32, Tao Chen wrote: Defined the string of {xen-pvscsi: } as DRV_PFX, then use it in the pr sentences and DPRINTK. Also fixed up some comments just as eliminate redundant white spaces and format the code. These will make the code easier to

Re: [Xen-devel] VT-d patch ping

2015-03-06 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Friday, March 06, 2015 5:33 PM > > Kevin, Yang, > > there are a number of patches requiring your ack or otherwise: sorry for delay. Just back from Chinese New Year holiday, and below bugs are on my review list planned to close early next we

Re: [Xen-devel] [PATCH v1 0/2] Add support for Xilinx ZynqMP SoC

2015-03-06 Thread Ian Campbell
On Fri, 2015-03-06 at 11:31 +1000, Edgar E. Iglesias wrote: > On Thu, Mar 05, 2015 at 04:50:15PM +, Ian Campbell wrote: > > On Thu, 2015-03-05 at 18:27 +1000, Edgar E. Iglesias wrote: > > > From: "Edgar E. Iglesias" > > > > > > Adds support for the Cadence UART in Xilinx ZynqMP. The > > > res

Re: [Xen-devel] VT-d Posted-interrupt (PI) design for XEN

2015-03-06 Thread Tim Deegan
At 02:07 + on 06 Mar (1425604054), Wu, Feng wrote: > > From: Tim Deegan [mailto:t...@xen.org] > > But I don't understand why we would need a new global vector for > > RUNSTATE_blocked rather than suppressing the posted interrupts as you > > suggest for RUNSTATE_runnable. (Or conversely why not

[Xen-devel] [PATCH v3 0/4] libbxl: add support for pvscsi, iteration 3

2015-03-06 Thread Olaf Hering
Port vscsi=[] and scsi-{attach,detach,list} commands from xend to libxl. Changes between v2 and v3: - Adjust change for vscsiif.h - Support "naa.wwn:lun" notation in pvops kernel - Add example for pvops kernel using targetcli patch required for python-rtslib: http://article.gmane.org/gman

[Xen-devel] [PATCH v3 2/4] docs: add vscsi to xenstore-paths.markdown

2015-03-06 Thread Olaf Hering
Signed-off-by: Olaf Hering Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- docs/misc/xenstore-paths.markdown | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/misc/xenstore-paths.markdown b/docs/misc/xenstore-paths.markdown index d94ea9

[Xen-devel] [PATCH v3 1/4] vscsiif.h: fix WWN notation for p-dev property

2015-03-06 Thread Olaf Hering
The pvops kernel expects either "naa.WWN:LUN" or "h:c:t:l" in the p-dev property. Add the missing :LUN part to the comment. Signed-off-by: Olaf Hering Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- xen/include/public/io/vscsiif.h | 2 +- 1 file changed,

Re: [Xen-devel] [PATCH 0/4] fix freemem loop

2015-03-06 Thread Ian Campbell
On Thu, 2015-03-05 at 21:08 -0700, Mike Latimer wrote: > On Thursday, March 05, 2015 05:49:35 PM Ian Campbell wrote: > > On Tue, 2015-03-03 at 11:08 +, Stefano Stabellini wrote: > > > Hi all, > > > > > > this patch series fixes the freemem loop on machines with very large > > > amount of memor

[Xen-devel] [PATCH v3 3/4] docs: add pvscsi.txt

2015-03-06 Thread Olaf Hering
Signed-off-by: Olaf Hering Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- docs/misc/pvscsi.txt | 188 +++ 1 file changed, 188 insertions(+) diff --git a/docs/misc/pvscsi.txt b/docs/misc/pvscsi.txt new file

[Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-06 Thread Olaf Hering
Port pvscsi support from xend to libxl. See pvscsi.txt for details. Outstanding work is listed in the TODO section. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/libxl/Makefile | 1 + tools/libxl/libxl.c

[Xen-devel] [PATCH] linux-2.6.18/sfc_netfront: deal with gcc5 warning

2015-03-06 Thread Jan Beulich
gcc5 warns about (!x == y) assuming !(x == y) may be meant, and the driver's Makefile enforcing -Werror results in this failing the build. Reported-by: Jiri Slaby Signed-off-by: Jan Beulich --- a/drivers/xen/sfc_netfront/falcon_event.c +++ b/drivers/xen/sfc_netfront/falcon_event.c @@ -110,7 +11

Re: [Xen-devel] [PATCH 0/4] fix freemem loop

2015-03-06 Thread Stefano Stabellini
On Thu, 5 Mar 2015, Ian Campbell wrote: > On Tue, 2015-03-03 at 11:08 +, Stefano Stabellini wrote: > > Hi all, > > > > this patch series fixes the freemem loop on machines with very large > > amount of memory, where the current wait time is not enough. > > > > In order to be able to handle ar

[Xen-devel] [PATCH v5 06/29] PCI: Pass PCI domain number combined with root bus number

2015-03-06 Thread Yijing Wang
Now we could pass PCI domain combined with bus number in u32 argu. Because in arm/arm64, PCI domain number is assigned by pci_bus_assign_domain_nr(). So we leave pci_scan_root_bus() and pci_create_root_bus() in arm/arm64 unchanged. A new function pci_host_assign_domain_nr() will be introduced for a

Re: [Xen-devel] [PATCH 0/4] fix freemem loop

2015-03-06 Thread Stefano Stabellini
On Fri, 6 Mar 2015, Ian Campbell wrote: > On Thu, 2015-03-05 at 21:08 -0700, Mike Latimer wrote: > > On Thursday, March 05, 2015 05:49:35 PM Ian Campbell wrote: > > > On Tue, 2015-03-03 at 11:08 +, Stefano Stabellini wrote: > > > > Hi all, > > > > > > > > this patch series fixes the freemem lo

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread George Dunlap
On 03/06/2015 07:36 AM, Jan Beulich wrote: > As pointed out in the discussion of the patch at > http://lists.xenproject.org/archives/html/xen-devel/2015-02/msg03256.html > generalizing the conditions here means code elsewhere doesn't need to > take into consideration internals of how load balancin

Re: [Xen-devel] [PATCH 0/4] fix freemem loop

2015-03-06 Thread Ian Campbell
On Fri, 2015-03-06 at 09:48 +, Stefano Stabellini wrote: > On Thu, 5 Mar 2015, Ian Campbell wrote: > > On Tue, 2015-03-03 at 11:08 +, Stefano Stabellini wrote: > > > Hi all, > > > > > > this patch series fixes the freemem loop on machines with very large > > > amount of memory, where the c

[Xen-devel] [xen-unstable test] 35887: regressions - FAIL

2015-03-06 Thread xen . org
flight 35887 xen-unstable real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/35887/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-rumpuserxen-amd64 11 rumpuserxen-demo-xenstorels/xenstorels fail REGR. vs. 35257

Re: [Xen-devel] [xen-unstable test] 35887: regressions - FAIL

2015-03-06 Thread Ian Campbell
On Fri, 2015-03-06 at 09:59 +, xen.org wrote: > flight 35887 xen-unstable real [real] > http://www.chiark.greenend.org.uk/~xensrcts/logs/35887/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-amd64-amd64-rumpuserxen-amd64

[Xen-devel] [PATCH OSSTEST] Debian: Log which kernel/initrd we failed to copy.

2015-03-06 Thread Ian Campbell
Helpful to trackdown which config var I've got wrong. Signed-off-by: Ian Campbell --- Osstest/Debian.pm | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index f6874af..c0af0b3 100644 --- a/Osstest/Debian.pm +++ b/Osstest/Debian.

[Xen-devel] [PATCH OSSTEST] allow: Allow rumpuserxen-demo-xenstorels/xenstorels failures on all branches

2015-03-06 Thread Ian Campbell
This test is subject to a heisenbug. The next step after this one is a repetition (50 times) of the same test which should reliably hit the issue. In the meantime this individual attempt sometimes hits and sometimes doesn't, causing unhelpful false regressions. The repeated test has never passed

Re: [Xen-devel] [PATCH 0/4] fix freemem loop

2015-03-06 Thread Ian Campbell
On Fri, 2015-03-06 at 09:52 +, Stefano Stabellini wrote: > On Fri, 6 Mar 2015, Ian Campbell wrote: > > On Thu, 2015-03-05 at 21:08 -0700, Mike Latimer wrote: > > > On Thursday, March 05, 2015 05:49:35 PM Ian Campbell wrote: > > > > On Tue, 2015-03-03 at 11:08 +, Stefano Stabellini wrote: >

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Jan Beulich
>>> On 06.03.15 at 10:53, wrote: > On 03/06/2015 07:36 AM, Jan Beulich wrote: >> As pointed out in the discussion of the patch at >> http://lists.xenproject.org/archives/html/xen-devel/2015-02/msg03256.html >> generalizing the conditions here means code elsewhere doesn't need to >> take into cons

Re: [Xen-devel] [xen-unstable test] 35887: regressions - FAIL

2015-03-06 Thread Jan Beulich
>>> On 06.03.15 at 11:03, wrote: > On Fri, 2015-03-06 at 09:59 +, xen.org wrote: >> flight 35887 xen-unstable real [real] >> http://www.chiark.greenend.org.uk/~xensrcts/logs/35887/ >> >> Regressions :-( >> >> Tests which did not succeed and are blocking, >> including tests which could not b

Re: [Xen-devel] [PATCH 0/4] fix freemem loop

2015-03-06 Thread Stefano Stabellini
On Fri, 6 Mar 2015, Ian Campbell wrote: > On Fri, 2015-03-06 at 09:52 +, Stefano Stabellini wrote: > > On Fri, 6 Mar 2015, Ian Campbell wrote: > > > On Thu, 2015-03-05 at 21:08 -0700, Mike Latimer wrote: > > > > On Thursday, March 05, 2015 05:49:35 PM Ian Campbell wrote: > > > > > On Tue, 2015-

Re: [Xen-devel] [PATCH 04/10] xen/blkfront: separate ring information to an new struct

2015-03-06 Thread Felipe Franciosi
> -Original Message- > From: Bob Liu [mailto:bob@oracle.com] > Sent: 05 March 2015 00:47 > To: Konrad Rzeszutek Wilk > Cc: Roger Pau Monne; Felipe Franciosi; David Vrabel; xen-devel@lists.xen.org; > linux-ker...@vger.kernel.org; ax...@fb.com; h...@infradead.org; > avanzini.aria...@gmail

[Xen-devel] [rumpuserxen test] 35897: regressions - FAIL

2015-03-06 Thread xen . org
flight 35897 rumpuserxen real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/35897/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-rumpuserxen5 rumpuserxen-build fail REGR. vs. 33866 build-amd64-rumpuserx

Re: [Xen-devel] [PATCH 1/5 v2] x86: allow specifying the NUMA nodes Dom0 should run on

2015-03-06 Thread Dario Faggioli
On Fri, 2015-03-06 at 09:19 +, Jan Beulich wrote: > ... by introducing a "dom0_nodes" option augmenting the "dom0_mem" and > "dom0_max_vcpus" ones. > > Note that this gives meaning to MEMF_exact_node specified alone (i.e. > implicitly combined with NUMA_NO_NODE): In such a case any node inside

Re: [Xen-devel] [PATCH 0/4] fix freemem loop

2015-03-06 Thread Ian Campbell
On Fri, 2015-03-06 at 10:22 +, Stefano Stabellini wrote: > On Fri, 6 Mar 2015, Ian Campbell wrote: > > On Fri, 2015-03-06 at 09:52 +, Stefano Stabellini wrote: > > > On Fri, 6 Mar 2015, Ian Campbell wrote: > > > > On Thu, 2015-03-05 at 21:08 -0700, Mike Latimer wrote: > > > > > On Thursday,

Re: [Xen-devel] [PATCH 1/5] x86: allow specifying the NUMA nodes Dom0 should run on

2015-03-06 Thread Dario Faggioli
On Fri, 2015-03-06 at 09:11 +, Jan Beulich wrote: > >>> On 03.03.15 at 11:51, wrote: > > That would then leave introducing a "relaxed (or "strict", > > depending on what we'd like to be the default) mode in the patch > > here, controlling whether ->cpu_hard_affinity gets overridden > > (and we

Re: [Xen-devel] [rumpuserxen test] 35897: regressions - FAIL

2015-03-06 Thread Ian Campbell
On Fri, 2015-03-06 at 10:38 +, xen.org wrote: > flight 35897 rumpuserxen real [real] > http://www.chiark.greenend.org.uk/~xensrcts/logs/35897/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-i386-rumpuserxen5 rum

Re: [Xen-devel] [PATCH 3/4] usb: Introduce Xen pvUSB backend

2015-03-06 Thread Pasi Kärkkäinen
On Wed, Mar 04, 2015 at 02:46:33PM +, Ian Campbell wrote: > On Wed, 2015-03-04 at 15:41 +0100, Juergen Gross wrote: > > On 03/04/2015 03:29 PM, Ian Campbell wrote: > > > On Wed, 2015-03-04 at 14:19 +, David Vrabel wrote: > > >> On 04/03/15 14:09, Juergen Gross wrote: > > >>> > > >>> The mai

Re: [Xen-devel] [xen-unstable test] 35887: regressions - FAIL

2015-03-06 Thread Ian Campbell
On Fri, 2015-03-06 at 10:19 +, Jan Beulich wrote: > >>> On 06.03.15 at 11:03, wrote: > > On Fri, 2015-03-06 at 09:59 +, xen.org wrote: > >> flight 35887 xen-unstable real [real] > >> http://www.chiark.greenend.org.uk/~xensrcts/logs/35887/ > >> > >> Regressions :-( > >> > >> Tests which

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Dario Faggioli
On Fri, 2015-03-06 at 09:53 +, George Dunlap wrote: > On 03/06/2015 07:36 AM, Jan Beulich wrote: > It looks like the comment above this line could use changing too; > It probably does. > --- > Hard affinity balancing is always necessary and must never be skipped. > But soft affinity need onl

Re: [Xen-devel] [rumpuserxen test] 35897: regressions - FAIL

2015-03-06 Thread Antti Kantee
On 06/03/15 10:49, Ian Campbell wrote: A new one to me: + cp 'rumpuserxen/rump-kernel*' dist/usr/local/lib/xen/rump-kernel cp: cannot stat `rumpuserxen/rump-kernel*': No such file or directory We think we figured out how to actually do things, and some repo-reorganizing was mandated. The chu

Re: [Xen-devel] [PATCH v2 3/5] libxc: split off xc_netbsd_evtchn.c

2015-03-06 Thread Wei Liu
On Thu, Mar 05, 2015 at 05:40:44PM +, Ian Campbell wrote: > On Tue, 2015-03-03 at 15:57 +, Wei Liu wrote: > > iff --git a/tools/libxc/xc_netbsd_evtchn.c > > b/tools/libxc/xc_netbsd_evtchn.c > > new file mode 100644 > > index 000..b5c2491 > > --- /dev/null > > +++ b/tools/libxc/xc_netbsd

[Xen-devel] [PATCH] test_x86_emulate: fix inline assembly in blowfish code

2015-03-06 Thread Jan Beulich
With certain gcc versions, commit 1166ecf781 ("tools/Rules.mk: Don't optimize debug builds; add macro debugging information") results in the file scope inline assembly no longer being emitted to the .text section without explicitly switching to it, which causes the blowfish test to signal SEGV. Si

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread George Dunlap
On 03/06/2015 10:16 AM, Jan Beulich wrote: On 06.03.15 at 10:53, wrote: >> On 03/06/2015 07:36 AM, Jan Beulich wrote: >>> As pointed out in the discussion of the patch at >>> http://lists.xenproject.org/archives/html/xen-devel/2015-02/msg03256.html >>> generalizing the conditions here means

Re: [Xen-devel] [PATCH 1/5] x86: allow specifying the NUMA nodes Dom0 should run on

2015-03-06 Thread Dario Faggioli
On Fri, 2015-03-06 at 10:46 +, Dario Faggioli wrote: > On Fri, 2015-03-06 at 09:11 +, Jan Beulich wrote: > > >>> On 03.03.15 at 11:51, wrote: > > Having implemented this "relaxed" addition (patch to be posted after > > a few more tests), I find that with Dom0 being restricted to half of >

[Xen-devel] [PATCH] libxc: use xc_dom_panic when decompressor is not supported

2015-03-06 Thread Wei Liu
State explicitly that specific decompressor is not supported by libxc. Without this change, libxc error message only says the provided kernel is invalid, which is misleading. Signed-off-by: Wei Liu Cc: Ian Campbell Cc: Ian Jackson Cc: svenvan@gmail.com --- tools/libxc/xc_dom_bzimageloader.

Re: [Xen-devel] [PATCH OSSTEST] allow: Allow rumpuserxen-demo-xenstorels/xenstorels failures on all branches

2015-03-06 Thread Ian Campbell
On Fri, 2015-03-06 at 10:12 +, Ian Campbell wrote: > This test is subject to a heisenbug. The next step after this one is a > repetition (50 times) of the same test which should reliably hit the > issue. > > In the meantime this individual attempt sometimes hits and sometimes > doesn't, causin

Re: [Xen-devel] [PATCH v6 20/23] libxlu: record line and column number when parsing values

2015-03-06 Thread Ian Jackson
Wei Liu writes ("[PATCH v6 20/23] libxlu: record line and column number when parsing values"): > Originally only setting has line number recorded. Since we're moving to > more sophisticated API, record line number and column number for > individual value. They are useful for error reporting. This

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread George Dunlap
On 03/06/2015 11:12 AM, Dario Faggioli wrote: > On Fri, 2015-03-06 at 09:53 +, George Dunlap wrote: >> On 03/06/2015 07:36 AM, Jan Beulich wrote: > >> It looks like the comment above this line could use changing too; >> > It probably does. > >> --- >> Hard affinity balancing is always necessa

Re: [Xen-devel] [PATCH v6 21/23] libxlu: introduce new APIs

2015-03-06 Thread Ian Jackson
Wei Liu writes ("[PATCH v6 21/23] libxlu: introduce new APIs"): > These APIs can be used to manipulate XLU_ConfigValue and XLU_ConfigList. Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Jan Beulich
>>> On 06.03.15 at 12:32, wrote: > On 03/06/2015 10:16 AM, Jan Beulich wrote: > On 06.03.15 at 10:53, wrote: >>> On 03/06/2015 07:36 AM, Jan Beulich wrote: As pointed out in the discussion of the patch at http://lists.xenproject.org/archives/html/xen-devel/2015-02/msg03256.html >>>

[Xen-devel] [PATCHv4] x86, fpu: remove the logic of non-eager fpu mem allocation at the first usage

2015-03-06 Thread David Vrabel
On 05/03/15 22:08, H. Peter Anvin wrote: > On 06/23/2014 06:08 AM, Konrad Rzeszutek Wilk wrote: >> On Wed, Mar 19, 2014 at 08:02:22AM -0700, H. Peter Anvin wrote: >>> On 03/19/2014 06:21 AM, Konrad Rzeszutek Wilk wrote: > > The following patch does the always eager allocation. It's a fixup

Re: [Xen-devel] [PATCH] test_x86_emulate: fix inline assembly in blowfish code

2015-03-06 Thread Andrew Cooper
On 06/03/2015 11:30, Jan Beulich wrote: > With certain gcc versions, commit 1166ecf781 ("tools/Rules.mk: Don't > optimize debug builds; add macro debugging information") results in the > file scope inline assembly no longer being emitted to the .text section > without explicitly switching to it, wh

Re: [Xen-devel] [PATCH 1/5] x86: allow specifying the NUMA nodes Dom0 should run on

2015-03-06 Thread Jan Beulich
>>> On 06.03.15 at 11:46, wrote: > One question, was there any other load in the system, especially on the > pCPUs with which Dom0's vCPUs have soft affinity? As said, there was no other load on the system (no DomU even present). Jan ___ Xen-devel ma

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread George Dunlap
On 03/06/2015 11:44 AM, Jan Beulich wrote: On 06.03.15 at 12:32, wrote: >> On 03/06/2015 10:16 AM, Jan Beulich wrote: >> On 06.03.15 at 10:53, wrote: On 03/06/2015 07:36 AM, Jan Beulich wrote: > As pointed out in the discussion of the patch at > http://lists.xenproject.org/a

Re: [Xen-devel] [PATCH v6 20/23] libxlu: record line and column number when parsing values

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 11:36:03AM +, Ian Jackson wrote: > Wei Liu writes ("[PATCH v6 20/23] libxlu: record line and column number when > parsing values"): > > Originally only setting has line number recorded. Since we're moving to > > more sophisticated API, record line number and column numb

Re: [Xen-devel] [PATCH 1/2] flask: clean up initialization and #defines

2015-03-06 Thread Wei Liu
On Tue, Mar 03, 2015 at 12:00:18PM -0500, Daniel De Graaf wrote: > This removes the FLASK_DEVELOP and FLASK_BOOTPARAM configuration > parameters which have never been settable by users. Disabling the > FLASK_DEVELOP configuration option has not produced a compiling > hypervisor for some time, and

Re: [Xen-devel] [PATCH 5/5] AMD IOMMU: widen NUMA nodes to be allocated from

2015-03-06 Thread Andrew Cooper
On 06/03/2015 07:50, Jan Beulich wrote: On 05.03.15 at 18:30, wrote: >> On 26/02/15 13:56, Jan Beulich wrote: >>> --- a/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h >>> +++ b/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h >>> @@ -158,12 +158,12 @@ static inline unsigned long region_to_pa >>>

Re: [Xen-devel] [PATCH 2/2] flask: create unified "flask=" boot parameter

2015-03-06 Thread Wei Liu
On Tue, Mar 03, 2015 at 12:00:19PM -0500, Daniel De Graaf wrote: [...] > diff --git a/docs/man/xl.pod.1 b/docs/man/xl.pod.1 > index 6b89ba8..48b8f98 100644 > --- a/docs/man/xl.pod.1 > +++ b/docs/man/xl.pod.1 > @@ -1441,8 +1441,8 @@ Determine if the FLASK security module is loaded and > enforcing i

Re: [Xen-devel] [PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 05:08:21PM +0800, Tiejun Chen wrote: > When we're working to support IGD GFX passthrough with qemu > upstream, instead of "-gfx_passthru" we'd like to make that > a machine option, "-machine xxx,igd-passthru=on". This need > to bring a change on tool side. > > After a discu

Re: [Xen-devel] [PATCH] xen: avoid NULL pointer dereference in dom0 on large machines

2015-03-06 Thread Juergen Gross
Ping? On 02/26/2015 06:52 AM, Juergen Gross wrote: Using the pvops kernel a NULL pointer dereference was detected on a large machine (144 processors) when booting as dom0 in evtchn_fifo_unmask() during assignment of a pirq. The event channel in question was the first to need a new entry in even

[Xen-devel] [PATCH v3] xen-scsiback: define a pr_fmt macro with xen-pvscsi

2015-03-06 Thread Tao Chen
Add the {xen-pvscsi: } prefix in pr_fmt and remove DPRINTK, then replace all DPRINTK with pr_debug. Also fixed up some comments just as eliminate redundant whitespace and format the code. These will make the code easier to read. Signed-off-by: Tao Chen --- drivers/xen/xen-scsiback.c | 72 +

Re: [Xen-devel] [PATCH 1/2] libxl: introduce libxl__is_igd_vga_passthru

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 05:08:22PM +0800, Tiejun Chen wrote: > While working with qemu, IGD is a specific device in the case of pass through > so we need to identify that to handle more later. Here we define a table to > record all IGD types currently we can support. Also we need to introduce two >

Re: [Xen-devel] [PATCH] libxc: use xc_dom_panic when decompressor is not supported

2015-03-06 Thread Andrew Cooper
On 06/03/2015 11:33, Wei Liu wrote: > State explicitly that specific decompressor is not supported by libxc. > Without this change, libxc error message only says the provided kernel > is invalid, which is misleading. > > Signed-off-by: Wei Liu > Cc: Ian Campbell > Cc: Ian Jackson > Cc: svenvan..

Re: [Xen-devel] [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-06 Thread Joe Perches
On Fri, 2015-03-06 at 17:33 +0800, Chentao (Boby) wrote: > #ifdef pr_fmt > #undef pr_fmt > #endif > #define pr_fmt(fmt) "xen-pvscsi: " fmt No, just use add #define pr_fmt(fmt) "xen-pvscsi: " fmt before the first #include. The #ifdef/#undef/#endif isn't necessary. > Then replace all DPRINTK with p

Re: [Xen-devel] [PATCH 3/4] usb: Introduce Xen pvUSB backend

2015-03-06 Thread Austin S Hemmelgarn
On 2015-03-04 09:09, Juergen Gross wrote: The main question whether it is worth to consider this alternative is the performance aspect. Does anyone have an idea which USB devices would typically be used via pvusb? I'd suspect memory sticks and USB disks and perhaps webcams being the most performa

Re: [Xen-devel] [PATCH v3] xen-scsiback: define a pr_fmt macro with xen-pvscsi

2015-03-06 Thread Juergen Gross
On 03/06/2015 09:34 PM, Tao Chen wrote: Add the {xen-pvscsi: } prefix in pr_fmt and remove DPRINTK, then replace all DPRINTK with pr_debug. Also fixed up some comments just as eliminate redundant whitespace and format the code. These will make the code easier to read. Signed-off-by: Tao Chen

Re: [Xen-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 05:08:23PM +0800, Tiejun Chen wrote: > Although we already have 'gfx_passthru' in b_info, this doesn' suffice > after we want to handle IGD specifically. Now we define a new field of > type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually > this means we ca

[Xen-devel] [PATCHv6 2/3] xen: unify foreign GFN map/unmap for auto-xlated physmap guests

2015-03-06 Thread David Vrabel
Auto-translated physmap guests (arm, arm64 and x86 PVHVM/PVH) map and unmap foreign GFNs using the same method (updating the physmap). Unify the two arm and x86 implementations into one commont one. Note that on arm and arm64, the correct error code will be returned (instead of always -EFAULT) and

[Xen-devel] [PATCHv6 0/3] xen: improve migration performance

2015-03-06 Thread David Vrabel
This series signficantly improves the performance of migration by speeding up privcmd's MMAPBATCH_V2 ioctl (for PV toolstack domains). Changes in v6: - unify PVH and ARM foreign mapping. - more fixes and refactoring than I can count. David ___ Xen-dev

Re: [Xen-devel] [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 05:18:36PM +0800, Chen, Tiejun wrote: > On 2015/3/6 17:08, Tiejun Chen wrote: > >Although we already have 'gfx_passthru' in b_info, this doesn' suffice > >after we want to handle IGD specifically. Now we define a new field of > >type, gfx_passthru_kind, to indicate we're try

[Xen-devel] [PATCHv6 1/3] arm: make __get_user() work for 8 byte values

2015-03-06 Thread David Vrabel
get_user(), __put_user(), and put_user() all worked with 8-byte values but __get_user() did not. Signed-off-by: David Vrabel --- Cc: Russell King Cc: linux-arm-ker...@lists.infradead.org --- arch/arm/include/asm/uaccess.h | 32 1 file changed, 32 insertions(+)

[Xen-devel] [PATCHv6 3/3] xen/privcmd: improve performance of MMAPBATCH_V2

2015-03-06 Thread David Vrabel
Make the IOCTL_PRIVCMD_MMAPBATCH_V2 (and older V1 version) map multiple frames at a time rather than one at a time, despite the pages being non-consecutive GFNs. xen_remap_foreign_mfn_array() is added which maps an array of GFNs (instead of a consecutive range of GFNs). Migrate times are signific

Re: [Xen-devel] [PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore

2015-03-06 Thread Wei Liu
Sorry for the late reply. On Thu, Feb 26, 2015 at 04:49:21PM -0700, Jim Fehlig wrote: > Wei Liu wrote: > > On Wed, Feb 11, 2015 at 10:18:18AM -0700, Jim Fehlig wrote: > > > >> At minimum, libvirt will populate the pdev_path, vdev, backend, and > >> format fields. If backend and format (which, i

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Jan Beulich
>>> On 06.03.15 at 13:00, wrote: > On 03/06/2015 11:44 AM, Jan Beulich wrote: > On 06.03.15 at 12:32, wrote: >>> On 03/06/2015 10:16 AM, Jan Beulich wrote: >>> On 06.03.15 at 10:53, wrote: > On 03/06/2015 07:36 AM, Jan Beulich wrote: >> As pointed out in the discussion of the pat

Re: [Xen-devel] [PATCH] xen: avoid NULL pointer dereference in dom0 on large machines

2015-03-06 Thread David Vrabel
On 26/02/15 05:52, Juergen Gross wrote: > Using the pvops kernel a NULL pointer dereference was detected on a > large machine (144 processors) when booting as dom0 in > evtchn_fifo_unmask() during assignment of a pirq. > > The event channel in question was the first to need a new entry in > event_

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Dario Faggioli
On Fri, 2015-03-06 at 12:00 +, George Dunlap wrote: > >> On 03/06/2015 10:16 AM, Jan Beulich wrote: > >>> Hmm, not sure. And I keep being confused whether soft means > >>> "allow" and hard means "prefer" or the other way around. > >>> > >> "hard" means allow (or not allow) > >> "soft" means p

Re: [Xen-devel] [PATCH 1/5] x86: allow specifying the NUMA nodes Dom0 should run on

2015-03-06 Thread Jan Beulich
>>> On 06.03.15 at 12:33, wrote: > I'll now apply your patch and see whether that changes thing (seems > unlikely, though). So with the change done that George pointed out is needed via his comment change request the anomaly is gone. I have to admit though that I can't see why that inversion caus

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Dario Faggioli
On Fri, 2015-03-06 at 11:38 +, George Dunlap wrote: > On 03/06/2015 11:12 AM, Dario Faggioli wrote: > > --- > > Hard affinity balancing is always necessary and must never be skipped. > > Soft affinity balancing is only useful if it, potentially, makes a > > difference. > > > > In more details

[Xen-devel] [PATCH v3] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Jan Beulich
As pointed out in the discussion of the patch at http://lists.xenproject.org/archives/html/xen-devel/2015-02/msg03256.html generalizing the conditions here means code elsewhere doesn't need to take into consideration internals of how load balancing in the credit scheduler works. Signed-off-by: Ja

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Jan Beulich
>>> On 06.03.15 at 14:23, wrote: > Which means that, yes, this part of the condition must loose the '!', or > have the arguments of the call to cpumask_subset() switched. I > personally prefer the former: > > return !cpumask_subset(cpupool_online_cpumask(vc->domain->cpupool), >

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Dario Faggioli
On Fri, 2015-03-06 at 13:32 +, Jan Beulich wrote: > >>> On 06.03.15 at 14:23, wrote: > > Which means that, yes, this part of the condition must loose the '!', or > > have the arguments of the call to cpumask_subset() switched. I > > personally prefer the former: > > > > return !cpumask_su

Re: [Xen-devel] [PATCH v3 3/4] docs: add pvscsi.txt

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 10:45:55AM +0100, Olaf Hering wrote: > Signed-off-by: Olaf Hering > Cc: Ian Campbell > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Keir Fraser > Cc: Tim Deegan > --- > docs/misc/pvscsi.txt | 188 > +++ > 1 file changed, 188

Re: [Xen-devel] [PATCH v3 2/4] docs: add vscsi to xenstore-paths.markdown

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 10:45:54AM +0100, Olaf Hering wrote: [...] > ~/backend/console/$DOMID/$DEVID/* [] > > A PV console backend. Described in [console.txt](console.txt) > @@ -403,6 +412,7 @@ ifb device used by Remus to buffer network output from > the associated vif. > [KBDIF]: > htt

[Xen-devel] [qemu-upstream-unstable test] 35890: regressions - FAIL

2015-03-06 Thread xen . org
flight 35890 qemu-upstream-unstable real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/35890/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-rhel6hvm-amd 6 leak-check/basis(6) running in 34247 [st=running!] test-a

Re: [Xen-devel] [PATCH v6 20/23] libxlu: record line and column number when parsing values

2015-03-06 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v6 20/23] libxlu: record line and column number when parsing values"): > Ack. This is how it looks like now. The changes are > > 1. Use YYLTYPE instead of line and column. This is better but why not have YYLTYPE inside XLU_ConfigValue ? > 2. Handle empty rule inside

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-06 Thread Wei Liu
This is a very big patch, I've only skimmed it so far. I think you need to fix some overly long lines. I won't mention them individually inline. Regarding all the parsing stuffs, you haven't defined vscsispec so I cannot review it. You might want to look at docs/misc/xl-disk-configuration.txt. I

Re: [Xen-devel] [PATCH v3] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread Dario Faggioli
On Fri, 2015-03-06 at 13:29 +, Jan Beulich wrote: > As pointed out in the discussion of the patch at > http://lists.xenproject.org/archives/html/xen-devel/2015-02/msg03256.html > generalizing the conditions here means code elsewhere doesn't need to > take into consideration internals of how lo

Re: [Xen-devel] [PATCH v3 3/4] docs: add pvscsi.txt

2015-03-06 Thread Olaf Hering
On Fri, Mar 06, Wei Liu wrote: > On Fri, Mar 06, 2015 at 10:45:55AM +0100, Olaf Hering wrote: > > +== TODO === > > + > > +How to do live migration? > > + - pdev will likely be evaluated again on the target host if it came from > > + domU.cfg. But what about pdev from 'xl scsi-attach pdev vdev'?

Re: [Xen-devel] [PATCH v2] credit: generalize __vcpu_has_soft_affinity()

2015-03-06 Thread George Dunlap
On 03/06/2015 01:31 PM, Dario Faggioli wrote: > On Fri, 2015-03-06 at 11:38 +, George Dunlap wrote: >> On 03/06/2015 11:12 AM, Dario Faggioli wrote: > >>> --- >>> Hard affinity balancing is always necessary and must never be skipped. >>> Soft affinity balancing is only useful if it, potentiall

Re: [Xen-devel] [PATCH v3 2/4] docs: add vscsi to xenstore-paths.markdown

2015-03-06 Thread Olaf Hering
On Fri, Mar 06, Wei Liu wrote: > On Fri, Mar 06, 2015 at 10:45:54AM +0100, Olaf Hering wrote: > [...] > > ~/backend/console/$DOMID/$DEVID/* [] > > > > A PV console backend. Described in [console.txt](console.txt) > > @@ -403,6 +412,7 @@ ifb device used by Remus to buffer network output fr

Re: [Xen-devel] [PATCH v2] sched: credit2: respect per-vcpu hard affinity

2015-03-06 Thread George Dunlap
On 03/03/2015 03:15 AM, Dario Faggioli wrote: > On Sun, 2015-02-08 at 17:45 -1000, Justin T. Weaver wrote: >> From: "Justin T. Weaver" >> >> by making sure that vcpus only run on the pcpu(s) they are allowed to >> run on based on their hard affinity cpu masks. >> > Ok, here I am reviewing this, at

Re: [Xen-devel] [PATCH v5] modify the IO_TLB_SEGSIZE and IO_TLB_DEFAULT_SIZE configurable as flexible requirement about SW-IOMMU.

2015-03-06 Thread Konrad Rzeszutek Wilk
. snip.. > Format: { ,force,,} is suitable I think. > And fixing "force" is follow the code design previously in > setup_io_tlb_npages. It is a bug. It should have been smart enough to deal with the 'force' being in any order. If you are willing to make a patch to fix this - either folded into

Re: [Xen-devel] [PATCH v3 3/4] docs: add pvscsi.txt

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 04:11:20PM +0100, Olaf Hering wrote: > On Fri, Mar 06, Wei Liu wrote: > > > On Fri, Mar 06, 2015 at 10:45:55AM +0100, Olaf Hering wrote: > > > +== TODO === > > > + > > > +How to do live migration? > > > + - pdev will likely be evaluated again on the target host if it came f

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-06 Thread Olaf Hering
On Fri, Mar 06, Wei Liu wrote: > I think you need to fix some overly long lines. I won't mention them > individually inline. Some are just copy&paste from other places. I will check what can be trimmed. > Regarding all the parsing stuffs, you haven't defined vscsispec so I > cannot review it. Yo

  1   2   >