Re: [Xen-devel] [PATCH v6 08/11] vpci/bars: add handlers to map the BARs

2017-10-05 Thread Jan Beulich
>>> On 05.10.17 at 14:02, wrote: > On Thu, Oct 05, 2017 at 11:55:39AM +, Jan Beulich wrote: >> >>> On 05.10.17 at 13:09, wrote: >> > On Thu, Oct 05, 2017 at 10:01:46AM +, Jan Beulich wrote: >> >> >>> On 05.10.17 at 11:20, wrote: >> >> > On Wed, Oct 04, 2017 at 08:33:33AM +, Jan Beuli

Re: [Xen-devel] [PATCH v6 08/11] vpci/bars: add handlers to map the BARs

2017-10-05 Thread Roger Pau Monné
On Thu, Oct 05, 2017 at 11:55:39AM +, Jan Beulich wrote: > >>> On 05.10.17 at 13:09, wrote: > > On Thu, Oct 05, 2017 at 10:01:46AM +, Jan Beulich wrote: > >> >>> On 05.10.17 at 11:20, wrote: > >> > On Wed, Oct 04, 2017 at 08:33:33AM +, Jan Beulich wrote: > >> >> >>> On 19.09.17 at 17:

Re: [Xen-devel] [PATCH v6 08/11] vpci/bars: add handlers to map the BARs

2017-10-05 Thread Jan Beulich
>>> On 05.10.17 at 13:09, wrote: > On Thu, Oct 05, 2017 at 10:01:46AM +, Jan Beulich wrote: >> >>> On 05.10.17 at 11:20, wrote: >> > On Wed, Oct 04, 2017 at 08:33:33AM +, Jan Beulich wrote: >> >> >>> On 19.09.17 at 17:29, wrote: >> >> > --- a/xen/include/xen/vpci.h >> >> > +++ b/xen/incl

Re: [Xen-devel] [PATCH v6 08/11] vpci/bars: add handlers to map the BARs

2017-10-05 Thread Roger Pau Monné
On Thu, Oct 05, 2017 at 10:56:20AM +, Julien Grall wrote: > Hi Roger, > > On 19/09/17 16:29, Roger Pau Monne wrote: > > +static int vpci_map_range(unsigned long s, unsigned long e, void *data, > > + unsigned long *c) > > +{ > > +const struct map_data *map = data; >

Re: [Xen-devel] [PATCH v6 08/11] vpci/bars: add handlers to map the BARs

2017-10-05 Thread Roger Pau Monné
On Thu, Oct 05, 2017 at 10:01:46AM +, Jan Beulich wrote: > >>> On 05.10.17 at 11:20, wrote: > > On Wed, Oct 04, 2017 at 08:33:33AM +, Jan Beulich wrote: > >> >>> On 19.09.17 at 17:29, wrote: > >> > +} > >> > + > >> > +rc = vpci_maybe_defer_map(pdev->domain, mem, map); > >> > +

Re: [Xen-devel] [PATCH v6 08/11] vpci/bars: add handlers to map the BARs

2017-10-05 Thread Julien Grall
Hi Roger, On 19/09/17 16:29, Roger Pau Monne wrote: +static int vpci_map_range(unsigned long s, unsigned long e, void *data, + unsigned long *c) +{ +const struct map_data *map = data; +int rc; + +for ( ; ; ) +{ +unsigned long size = e - s + 1; + +

Re: [Xen-devel] [PATCH v6 08/11] vpci/bars: add handlers to map the BARs

2017-10-05 Thread Jan Beulich
>>> On 05.10.17 at 11:20, wrote: > On Wed, Oct 04, 2017 at 08:33:33AM +, Jan Beulich wrote: >> >>> On 19.09.17 at 17:29, wrote: >> > +static int vpci_check_bar_overlap(const struct pci_dev *pdev, >> > + const struct vpci_bar *rom, >> > +

Re: [Xen-devel] [PATCH v6 08/11] vpci/bars: add handlers to map the BARs

2017-10-05 Thread Roger Pau Monné
On Wed, Oct 04, 2017 at 08:33:33AM +, Jan Beulich wrote: > >>> On 19.09.17 at 17:29, wrote: > > +static int vpci_check_bar_overlap(const struct pci_dev *pdev, > > + const struct vpci_bar *rom, > > + struct rangeset *mem) > > +{

Re: [Xen-devel] [PATCH v6 08/11] vpci/bars: add handlers to map the BARs

2017-10-04 Thread Jan Beulich
>>> On 19.09.17 at 17:29, wrote: > @@ -48,6 +49,9 @@ bool_t hvm_io_pending(struct vcpu *v) > struct domain *d = v->domain; > struct hvm_ioreq_server *s; > > +if ( has_vpci(v->domain) && vpci_check_pending(v) ) has_vpci(d) > + return 1; Indentation. > +static int vpci_map_r