Hi Roger,
On 19/09/17 16:29, Roger Pau Monne wrote:
+static int vpci_map_range(unsigned long s, unsigned long e, void *data,
+ unsigned long *c)
+{
+ const struct map_data *map = data;
+ int rc;
+
+ for ( ; ; )
+ {
+ unsigned long size = e - s + 1;
+
+ rc = (map->map ? map_mmio_regions : unmap_mmio_regions)
+ (map->d, _gfn(s), size, _mfn(s));
Again, this is relying on *map_mmio_regions to support preemption. This
is not the case on ARM.
I am not asking to add preemption in the ARM code. But we should at
least add a check similar to XEN_DOMCTL_memory_mapping ( if (size > 64)
) to remind us that *map_mmio_regions have to be fixed.
Similarly, on IRC said you will add a TODO regarding the lack of passing
the type of the BAR.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
