Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-17 Thread Julien Grall
On 17/07/15 16:34, Ian Campbell wrote: > On Fri, 2015-07-17 at 16:15 +0100, Julien Grall wrote: > Also, you have to translate the col_id into to a VCPU ID. >>> >>> This is virtual collection id which itself is vcpu id. isn't it? >> >> No. A collection can move between CPU, so you will en

Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-17 Thread Ian Campbell
On Fri, 2015-07-17 at 16:15 +0100, Julien Grall wrote: > >> > >> Also, you have to translate the col_id into to a VCPU ID. > > > > This is virtual collection id which itself is vcpu id. isn't it? > > No. A collection can move between CPU, so you will end up to have vCPUID > != vCID. Specificall

Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-17 Thread Julien Grall
On 17/07/15 15:12, Vijay Kilari wrote: > Hi Julien, Hi Vijay, > On Wed, Jul 15, 2015 at 6:27 PM, Julien Grall wrote: >> On 10/07/2015 09:42, vijay.kil...@gmail.com wrote: >>> >>> From: Vijaya Kumar K >>> >>> Add Virtual ITS command processing support to Virtual ITS driver >>> >>> Signed-off-by:

Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-17 Thread Vijay Kilari
Hi Ian, On Mon, Jul 13, 2015 at 5:07 PM, Ian Campbell wrote: > On Mon, 2015-07-13 at 16:45 +0530, Vijay Kilari wrote: > >> BTW, I want to know if atomic_t supports 64-bit access?. > > I don't know off the top of my head. I'm sure it would be apparent in > the code. atomic_t is 32 bit. But CREAD

Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-17 Thread Vijay Kilari
Hi Julien, On Wed, Jul 15, 2015 at 6:27 PM, Julien Grall wrote: > Hi Vijay, > > On 10/07/2015 09:42, vijay.kil...@gmail.com wrote: >> >> From: Vijaya Kumar K >> >> Add Virtual ITS command processing support to Virtual ITS driver >> >> Signed-off-by: Vijaya Kumar K >> >> --- >> v4: - Use helper

Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-15 Thread Ian Campbell
On Wed, 2015-07-15 at 15:02 +0200, Julien Grall wrote: > Hi Ian, > > On 10/07/2015 16:35, Ian Campbell wrote: > >> diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h > >> index 44c2317..fdd96c8 100644 > >> --- a/xen/include/asm-arm/gic.h > >> +++ b/xen/include/asm-arm/gic.h > >> @@

Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-15 Thread Julien Grall
Hi Ian, On 10/07/2015 16:35, Ian Campbell wrote: diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h index 44c2317..fdd96c8 100644 --- a/xen/include/asm-arm/gic.h +++ b/xen/include/asm-arm/gic.h @@ -24,6 +24,7 @@ #define NR_GIC_LPI 4096 #define MAX_LPI(FIRS

Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-15 Thread Julien Grall
Hi Vijay, On 10/07/2015 09:42, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K Add Virtual ITS command processing support to Virtual ITS driver Signed-off-by: Vijaya Kumar K --- v4: - Use helper function to read from command queue - Add MOVALL - Removed check for entry in device

Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-13 Thread Ian Campbell
On Mon, 2015-07-13 at 16:45 +0530, Vijay Kilari wrote: > BTW, I want to know if atomic_t supports 64-bit access?. I don't know off the top of my head. I'm sure it would be apparent in the code. Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org

Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-13 Thread Vijay Kilari
On Mon, Jul 13, 2015 at 2:52 PM, Ian Campbell wrote: > On Sat, 2015-07-11 at 20:19 +0530, Vijay Kilari wrote: >> >> +int vgic_its_process_cmd(struct vcpu *v, struct vgic_its *vits) >> >> +{ >> >> +its_cmd_block virt_cmd; >> >> + >> >> +ASSERT(spin_is_locked(&vits->lock)); >> >> + >> >> +

Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-13 Thread Ian Campbell
On Sat, 2015-07-11 at 20:19 +0530, Vijay Kilari wrote: > >> +int vgic_its_process_cmd(struct vcpu *v, struct vgic_its *vits) > >> +{ > >> +its_cmd_block virt_cmd; > >> + > >> +ASSERT(spin_is_locked(&vits->lock)); > >> + > >> +do { > >> +if ( vgic_its_read_virt_cmd(v, vits, &virt

Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-11 Thread Vijay Kilari
>> +int vgic_its_process_cmd(struct vcpu *v, struct vgic_its *vits) >> +{ >> +its_cmd_block virt_cmd; >> + >> +ASSERT(spin_is_locked(&vits->lock)); >> + >> +do { >> +if ( vgic_its_read_virt_cmd(v, vits, &virt_cmd) ) >> +goto err; >> +if ( vgic_its_parse_its_c

Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-10 Thread Ian Campbell
On Fri, 2015-07-10 at 13:12 +0530, vijay.kil...@gmail.com wrote: [...] > +static int vgic_its_process_int(struct vcpu *v, struct vgic_its *vits, > +its_cmd_block *virt_cmd) > +{ > [...] > + > +col_id = vitt_entry.vcollection; > +if ( col_id < d->max_vcpus )