Hi Ian,
On 10/07/2015 16:35, Ian Campbell wrote:
diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h
index 44c2317..fdd96c8 100644
--- a/xen/include/asm-arm/gic.h
+++ b/xen/include/asm-arm/gic.h
@@ -24,6 +24,7 @@
#define NR_GIC_LPI 4096
#define MAX_LPI (FIRST_GIC_LPI + NR_GIC_LPI)
#define MAX_RDIST_COUNT 4
+#define BIT_48_12_MASK 0xfffffffff000UL
I think you should use ~PAGE_MASK instead of defining this.
This used to get the physical address in the GITS_CBASER register. This
field is not based on the Xen page granularity neither 4KB granularity.
It's just a field containing the bits [47:12] of the address.
Therefore it would be very strange to use PAGE_MASK and an hypothetical
4K_MASK. Though I would prefer the latter.
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
