Re: [Xen-devel] [PATCH v2] xl: close nullfd after dup2'ing it to stdin

2016-03-01 Thread Ian Jackson
Ian Campbell writes ("[PATCH v2] xl: close nullfd after dup2'ing it to stdin"): > We assert that nullfd if not std{in,out,err} since that would result > in closing one of the just dup2'd fds. For this to happen > std{in,out,err} would have needed to be closed, at which point all > sorts of other th

Re: [Xen-devel] [PATCH v2] xl: close nullfd after dup2'ing it to stdin

2016-03-01 Thread Wei Liu
On Mon, Feb 29, 2016 at 10:45:51AM -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Feb 23, 2016 at 10:30:31AM +, Ian Campbell wrote: > > On Wed, 2016-02-17 at 10:39 +, Ian Campbell wrote: > > > We assert that nullfd if not std{in,out,err} since that would result > > > in closing one of the ju

Re: [Xen-devel] [PATCH v2] xl: close nullfd after dup2'ing it to stdin

2016-02-29 Thread Konrad Rzeszutek Wilk
On Tue, Feb 23, 2016 at 10:30:31AM +, Ian Campbell wrote: > On Wed, 2016-02-17 at 10:39 +, Ian Campbell wrote: > > We assert that nullfd if not std{in,out,err} since that would result > > in closing one of the just dup2'd fds. For this to happen > > std{in,out,err} would have needed to be c

Re: [Xen-devel] [PATCH v2] xl: close nullfd after dup2'ing it to stdin

2016-02-23 Thread Ian Campbell
On Wed, 2016-02-17 at 10:39 +, Ian Campbell wrote: > We assert that nullfd if not std{in,out,err} since that would result > in closing one of the just dup2'd fds. For this to happen > std{in,out,err} would have needed to be closed, at which point all > sorts of other things could go wrong. > >