Ian Campbell writes ("[PATCH v2] xl: close nullfd after dup2'ing it to stdin"): > We assert that nullfd if not std{in,out,err} since that would result > in closing one of the just dup2'd fds. For this to happen > std{in,out,err} would have needed to be closed, at which point all > sorts of other things could go wrong. > > CID: 1130519 > > It was previously hypothesised[0] that fixing 1130516 would solve this > too, but that appears to not have been the case. > > Compile tested only. > > [0] http://lists.xenproject.org/archives/html/xen-devel/2013-11/msg02931.html > > Signed-off-by: Ian Campbell <ian.campb...@citrix.com> > Cc: andrew.coop...@citrix.com > --- > v2: Assert logfile and nullfd are not stdio fds
Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> Committed-by: Ian Jackson <ian.jack...@eu.citrix.com> (The copy to ijc may bounce I guess...) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel