Re: [Xen-devel] [PATCH v1 3/3] blktap2: Silence warnings under GCC 5.1.1

2015-10-05 Thread Jan Beulich
>>> On 05.10.15 at 16:57, wrote: > On Mon, Oct 05, 2015 at 08:46:03AM -0600, Jan Beulich wrote: >> >>> On 05.10.15 at 16:26, wrote: >> > On Mon, Oct 05, 2015 at 04:46:55AM -0600, Jan Beulich wrote: >> >> >>> On 05.10.15 at 10:49, wrote: >> >> > On 03/10/15 19:39, Konrad Rzeszutek Wilk wrote: >>

Re: [Xen-devel] [PATCH v1 3/3] blktap2: Silence warnings under GCC 5.1.1

2015-10-05 Thread Konrad Rzeszutek Wilk
On Mon, Oct 05, 2015 at 08:46:03AM -0600, Jan Beulich wrote: > >>> On 05.10.15 at 16:26, wrote: > > On Mon, Oct 05, 2015 at 04:46:55AM -0600, Jan Beulich wrote: > >> >>> On 05.10.15 at 10:49, wrote: > >> > On 03/10/15 19:39, Konrad Rzeszutek Wilk wrote: > >> >> I get compile warnings telling me t

Re: [Xen-devel] [PATCH v1 3/3] blktap2: Silence warnings under GCC 5.1.1

2015-10-05 Thread Jan Beulich
>>> On 05.10.15 at 16:26, wrote: > On Mon, Oct 05, 2015 at 04:46:55AM -0600, Jan Beulich wrote: >> >>> On 05.10.15 at 10:49, wrote: >> > On 03/10/15 19:39, Konrad Rzeszutek Wilk wrote: >> >> I get compile warnings telling me that >> >>s->connections[i].fd == fd >> >> >> >> 'i' may be past the

Re: [Xen-devel] [PATCH v1 3/3] blktap2: Silence warnings under GCC 5.1.1

2015-10-05 Thread Konrad Rzeszutek Wilk
On Mon, Oct 05, 2015 at 04:46:55AM -0600, Jan Beulich wrote: > >>> On 05.10.15 at 10:49, wrote: > > On 03/10/15 19:39, Konrad Rzeszutek Wilk wrote: > >> I get compile warnings telling me that > >>s->connections[i].fd == fd > >> > >> 'i' may be past the array. Adding in an extra condition > >>

Re: [Xen-devel] [PATCH v1 3/3] blktap2: Silence warnings under GCC 5.1.1

2015-10-05 Thread Jan Beulich
>>> On 05.10.15 at 10:49, wrote: > On 03/10/15 19:39, Konrad Rzeszutek Wilk wrote: >> I get compile warnings telling me that >>s->connections[i].fd == fd >> >> 'i' may be past the array. Adding in an extra condition >> on the loop fixes that. >> >> Signed-off-by: Konrad Rzeszutek Wilk > > Re

Re: [Xen-devel] [PATCH v1 3/3] blktap2: Silence warnings under GCC 5.1.1

2015-10-05 Thread Andrew Cooper
On 03/10/15 19:39, Konrad Rzeszutek Wilk wrote: > I get compile warnings telling me that >s->connections[i].fd == fd > > 'i' may be past the array. Adding in an extra condition > on the loop fixes that. > > Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Andrew Cooper Furthermore, I can't