On Mon, Oct 05, 2015 at 04:46:55AM -0600, Jan Beulich wrote: > >>> On 05.10.15 at 10:49, <andrew.coop...@citrix.com> wrote: > > On 03/10/15 19:39, Konrad Rzeszutek Wilk wrote: > >> I get compile warnings telling me that > >> s->connections[i].fd == fd > >> > >> 'i' may be past the array. Adding in an extra condition > >> on the loop fixes that. > >> > >> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > > > > Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> > > > > Furthermore, I can't see any logic which prevents s->connected getting > > larger than MAX_CONNECTIONS > > Iirc Olaf had already suggested such a patch quite some time ago, > and not having seen the point back then I also don't see the point > now: ctl_accept() prevents ->connected from growing beyond 1, > and there's no other place where the value could get incremented.
Thoughts on what to do about the compiler warnings which make this compiler errors (since we compile with -Werror) and one can't compile Xen? A different fix (make s->connected not be an array?) > > Also, Konrad, regarding the subject (since this repeats from an > earlier patch of yours) - why do you reference a specific, non- > release version of gcc? Why not simply say 5.x? Because if the > problem is indeed only present in a non-release version, I don't > think we should bother working around such issues. I just ran 'gcc --version' and that is what it spit out. Since it is part of an official Fedora release I figured it is 'released' in some way? > > Jan > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
