Re: [Xen-devel] [PATCH RFC] make error codes a formal part of the ABI

2015-01-14 Thread Andrew Cooper
On 14/01/15 11:24, Ian Campbell wrote: > On Wed, 2015-01-14 at 10:52 +, Julien Grall wrote: >> Hi Ian, >> >> On 14/01/2015 10:28, Ian Campbell wrote: > (I suppose someone needs to patch libxc et al to actually use this) The primary consumer, as said in the description, is meant to be >

Re: [Xen-devel] [PATCH RFC] make error codes a formal part of the ABI

2015-01-14 Thread Ian Campbell
On Wed, 2015-01-14 at 11:18 +, Jan Beulich wrote: > >>> On 14.01.15 at 11:28, wrote: > > On Wed, 2015-01-14 at 08:46 +, Jan Beulich wrote: > >> >>> On 13.01.15 at 17:35, wrote: > >> > On Tue, 2015-01-13 at 16:21 +, Jan Beulich wrote: > >> >> --- /dev/null > >> >> +++ b/xen/include/pub

Re: [Xen-devel] [PATCH RFC] make error codes a formal part of the ABI

2015-01-14 Thread Ian Campbell
On Wed, 2015-01-14 at 10:52 +, Julien Grall wrote: > Hi Ian, > > On 14/01/2015 10:28, Ian Campbell wrote: > >>> (I suppose someone needs to patch libxc et al to actually use this) > >> > >> The primary consumer, as said in the description, is meant to be > >> hvmloader. But yes, other tools pa

Re: [Xen-devel] [PATCH RFC] make error codes a formal part of the ABI

2015-01-14 Thread Jan Beulich
>>> On 14.01.15 at 11:28, wrote: > On Wed, 2015-01-14 at 08:46 +, Jan Beulich wrote: >> >>> On 13.01.15 at 17:35, wrote: >> > On Tue, 2015-01-13 at 16:21 +, Jan Beulich wrote: >> >> --- /dev/null >> >> +++ b/xen/include/public/errno.h >> >> @@ -0,0 +1,94 @@ >> >> +#ifndef __XEN_PUBLIC_ERR

Re: [Xen-devel] [PATCH RFC] make error codes a formal part of the ABI

2015-01-14 Thread Julien Grall
Hi Ian, On 14/01/2015 10:28, Ian Campbell wrote: (I suppose someone needs to patch libxc et al to actually use this) The primary consumer, as said in the description, is meant to be hvmloader. But yes, other tools parts may also want to follow that. /me wonders how libxc has been getting awa

Re: [Xen-devel] [PATCH RFC] make error codes a formal part of the ABI

2015-01-14 Thread Ian Campbell
On Wed, 2015-01-14 at 08:46 +, Jan Beulich wrote: > >>> On 13.01.15 at 17:35, wrote: > > On Tue, 2015-01-13 at 16:21 +, Jan Beulich wrote: > >> --- /dev/null > >> +++ b/xen/include/public/errno.h > >> @@ -0,0 +1,94 @@ > >> +#ifndef __XEN_PUBLIC_ERRNO_H__ > >> + > >> +#ifndef __ASSEMBLY__ >

Re: [Xen-devel] [PATCH RFC] make error codes a formal part of the ABI

2015-01-14 Thread Jan Beulich
>>> On 13.01.15 at 17:40, wrote: > On 13/01/15 16:21, Jan Beulich wrote: >> Now that we have two cases where patches against hvmloader got >> submitted needing to include the hypervisor's errno.h (for the host's >> system header not necessarily reflecting the correct numbers), take >> this as a st

Re: [Xen-devel] [PATCH RFC] make error codes a formal part of the ABI

2015-01-14 Thread Jan Beulich
>>> On 13.01.15 at 17:35, wrote: > On Tue, 2015-01-13 at 16:21 +, Jan Beulich wrote: >> --- /dev/null >> +++ b/xen/include/public/errno.h >> @@ -0,0 +1,94 @@ >> +#ifndef __XEN_PUBLIC_ERRNO_H__ >> + >> +#ifndef __ASSEMBLY__ >> + >> +#define XEN_ERRNO(name, value) XEN_##name = value, >> +enum xe

Re: [Xen-devel] [PATCH RFC] make error codes a formal part of the ABI

2015-01-13 Thread Ian Campbell
On Tue, 2015-01-13 at 16:57 +, Ian Jackson wrote: > Ian Campbell writes ("Re: [PATCH RFC] make error codes a formal part of the > ABI"): > > On Tue, 2015-01-13 at 16:21 +, Jan Beulich wrote: > > > There's on small block commented with TBD left in the public header. > > > This is the main r

Re: [Xen-devel] [PATCH RFC] make error codes a formal part of the ABI

2015-01-13 Thread Jan Beulich
>>> On 13.01.15 at 17:57, wrote: > Ian Campbell writes ("Re: [PATCH RFC] make error codes a formal part of the > ABI"): >> On Tue, 2015-01-13 at 16:21 +, Jan Beulich wrote: >> > There's on small block commented with TBD left in the public header. >> > This is the main reason for the submissio

Re: [Xen-devel] [PATCH RFC] make error codes a formal part of the ABI

2015-01-13 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH RFC] make error codes a formal part of the ABI"): > On Tue, 2015-01-13 at 16:21 +, Jan Beulich wrote: > > There's on small block commented with TBD left in the public header. > > This is the main reason for the submission being RFC. While we don't > > currently

Re: [Xen-devel] [PATCH RFC] make error codes a formal part of the ABI

2015-01-13 Thread Andrew Cooper
On 13/01/15 16:21, Jan Beulich wrote: > Now that we have two cases where patches against hvmloader got > submitted needing to include the hypervisor's errno.h (for the host's > system header not necessarily reflecting the correct numbers), take > this as a strong sign that we need to make the error

Re: [Xen-devel] [PATCH RFC] make error codes a formal part of the ABI

2015-01-13 Thread Ian Campbell
On Tue, 2015-01-13 at 16:21 +, Jan Beulich wrote: > Now that we have two cases where patches against hvmloader got > submitted needing to include the hypervisor's errno.h (for the host's > system header not necessarily reflecting the correct numbers), take > this as a strong sign that we need t