Re: [Xen-devel] [PATCH 2/7] docs/build: Do not open-code $*

2015-04-21 Thread Ian Campbell
On Mon, 2015-04-20 at 11:49 +0100, Andrew Cooper wrote: > Sometimes there is already a round enough wheel to hand. I love the double use of sed and the unescaped .'s. > > No functional change. > > Signed-off-by: Andrew Cooper Acked-by: Ian Campbell (I agree with the conclusion of the subthre

Re: [Xen-devel] [PATCH 2/7] docs/build: Do not open-code $*

2015-04-20 Thread Jan Beulich
>>> On 20.04.15 at 13:55, wrote: > On 20/04/15 12:48, Jan Beulich wrote: > On 20.04.15 at 12:49, wrote: >>> --- a/docs/Makefile >>> +++ b/docs/Makefile >>> @@ -73,13 +73,11 @@ endif >>> >>> man1/%.1: man/%.pod.1 Makefile >>> $(INSTALL_DIR) $(@D) >>> - $(POD2MAN) --release=$(VERSION)

Re: [Xen-devel] [PATCH 2/7] docs/build: Do not open-code $*

2015-04-20 Thread Andrew Cooper
On 20/04/15 12:48, Jan Beulich wrote: On 20.04.15 at 12:49, wrote: >> --- a/docs/Makefile >> +++ b/docs/Makefile >> @@ -73,13 +73,11 @@ endif >> >> man1/%.1: man/%.pod.1 Makefile >> $(INSTALL_DIR) $(@D) >> -$(POD2MAN) --release=$(VERSION) --name=`echo $@ | sed 's/^man1.//'| \ >> -

Re: [Xen-devel] [PATCH 2/7] docs/build: Do not open-code $*

2015-04-20 Thread Jan Beulich
>>> On 20.04.15 at 12:49, wrote: > --- a/docs/Makefile > +++ b/docs/Makefile > @@ -73,13 +73,11 @@ endif > > man1/%.1: man/%.pod.1 Makefile > $(INSTALL_DIR) $(@D) > - $(POD2MAN) --release=$(VERSION) --name=`echo $@ | sed 's/^man1.//'| \ > - sed 's/.1//'` -s 1 -c "Xen" $< $