Re: [Xen-devel] [PATCH 10/25] libxl: create vIOMMU during domain construction

2017-07-05 Thread Wei Liu
On Wed, Jul 05, 2017 at 07:32:56PM +0800, Lan Tianyu wrote: > > Given the code needed is simply calling an xc function, I think it can > > be put into one of those hooks. > > > > OK. I got it. How about putting new code in libxl__arch_domain_create()? > Fine by me.

Re: [Xen-devel] [PATCH 10/25] libxl: create vIOMMU during domain construction

2017-07-05 Thread Lan Tianyu
On 2017年07月05日 19:19, Wei Liu wrote: > On Wed, Jul 05, 2017 at 06:53:31PM +0800, Lan Tianyu wrote: >> On 2017年07月04日 19:03, Wei Liu wrote: >>> On Tue, Jul 04, 2017 at 11:46:18AM +0100, Julien Grall wrote: Hi, On 06/29/2017 06:50 AM, Lan Tianyu wrote: > diff --git a/tools/libxl/li

Re: [Xen-devel] [PATCH 10/25] libxl: create vIOMMU during domain construction

2017-07-05 Thread Wei Liu
On Wed, Jul 05, 2017 at 06:53:31PM +0800, Lan Tianyu wrote: > On 2017年07月04日 19:03, Wei Liu wrote: > > On Tue, Jul 04, 2017 at 11:46:18AM +0100, Julien Grall wrote: > >> Hi, > >> > >> On 06/29/2017 06:50 AM, Lan Tianyu wrote: > >>> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.

Re: [Xen-devel] [PATCH 10/25] libxl: create vIOMMU during domain construction

2017-07-05 Thread Lan Tianyu
On 2017年07月04日 19:03, Wei Liu wrote: > On Tue, Jul 04, 2017 at 11:46:18AM +0100, Julien Grall wrote: >> Hi, >> >> On 06/29/2017 06:50 AM, Lan Tianyu wrote: >>> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c >>> index bffbc45..55119e2 100644 >>> --- a/tools/libxl/libxl_create.c

Re: [Xen-devel] [PATCH 10/25] libxl: create vIOMMU during domain construction

2017-07-04 Thread Wei Liu
On Tue, Jul 04, 2017 at 11:46:18AM +0100, Julien Grall wrote: > Hi, > > On 06/29/2017 06:50 AM, Lan Tianyu wrote: > > diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c > > index bffbc45..55119e2 100644 > > --- a/tools/libxl/libxl_create.c > > +++ b/tools/libxl/libxl_create.c > >

Re: [Xen-devel] [PATCH 10/25] libxl: create vIOMMU during domain construction

2017-07-04 Thread Julien Grall
Hi, On 06/29/2017 06:50 AM, Lan Tianyu wrote: diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c index bffbc45..55119e2 100644 --- a/tools/libxl/libxl_create.c +++ b/tools/libxl/libxl_create.c @@ -557,6 +557,12 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_co

Re: [Xen-devel] [PATCH 10/25] libxl: create vIOMMU during domain construction

2017-06-30 Thread Wei Liu
On Thu, Jun 29, 2017 at 01:50:42AM -0400, Lan Tianyu wrote: > From: Chao Gao > > > +int libxl__arch_create_viommu(libxl__gc *gc, > + const libxl_domain_config *d_config, > + uint32_t domid) > +{ > +int rc = 0; Please see CODING_STYL