Hi,

On 06/29/2017 06:50 AM, Lan Tianyu wrote:
diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index bffbc45..55119e2 100644
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -557,6 +557,12 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config 
*d_config,
          }
      }
+ rc = libxl__arch_create_viommu(gc, d_config, *domid);
+    if (rc < 0) {
+        LOGED(ERROR, *domid, "create vIOMMU fail");
+        goto out;
+    }
+

Rather than creating yet another arch helper, would not it be better to have a "post domain creation helper" that will do anything arch specific related (i.e creating vIOMMU, save config...)?


      rc = libxl__arch_domain_save_config(gc, d_config, xc_config) >       if (rc 
< 0)
          goto out;

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Reply via email to