Re: [Xen-devel] [PATCH] xen:rtds:fix bug in accounting budget

2016-10-21 Thread Meng Xu
On Fri, Oct 21, 2016 at 1:36 PM, Dario Faggioli wrote: > > On Wed, 2016-10-19 at 11:13 -0400, Meng Xu wrote: > > The bug is introduced in Xen 4.7 when we converted RTDS scheduler > > from quantum-driven model to event-driven model. > > We assumed rt_schedule() is always called for a VCPU > > befor

Re: [Xen-devel] [PATCH] xen:rtds:fix bug in accounting budget

2016-10-21 Thread Dario Faggioli
On Wed, 2016-10-19 at 11:13 -0400, Meng Xu wrote: > The bug is introduced in Xen 4.7 when we converted RTDS scheduler > from quantum-driven model to event-driven model. > We assumed rt_schedule() is always called for a VCPU > before the VCPUs budget replenished handler. > No, we didn't. Or at leas

Re: [Xen-devel] [PATCH] xen:rtds:fix bug in accounting budget

2016-10-19 Thread Wei Liu
On Wed, Oct 19, 2016 at 11:13:54AM -0400, Meng Xu wrote: > The bug is introduced in Xen 4.7 when we converted RTDS scheduler > from quantum-driven model to event-driven model. > We assumed rt_schedule() is always called for a VCPU > before the VCPUs budget replenished handler. > This assumption doe

Re: [Xen-devel] [PATCH] xen:rtds:fix bug in accounting budget

2016-10-19 Thread Meng Xu
[cc. Tianyang...] On Wed, Oct 19, 2016 at 11:45 AM, Wei Liu wrote: > On Wed, Oct 19, 2016 at 11:13:54AM -0400, Meng Xu wrote: >> The bug is introduced in Xen 4.7 when we converted RTDS scheduler >> from quantum-driven model to event-driven model. >> We assumed rt_schedule() is always called for a

Re: [Xen-devel] [PATCH] xen:rtds:fix bug in accounting budget

2016-10-19 Thread Meng Xu
On Wed, Oct 19, 2016 at 11:13 AM, Meng Xu wrote: > The bug is introduced in Xen 4.7 when we converted RTDS scheduler > from quantum-driven model to event-driven model. > We assumed rt_schedule() is always called for a VCPU > before the VCPUs budget replenished handler. > This assumption does not h