Re: [Xen-devel] [PATCH] x86/Centaur: drop __init annotations

2015-10-14 Thread Andrew Cooper
On 14/10/15 14:27, Jan Beulich wrote: On 14.10.15 at 15:22, wrote: >> On 14/10/15 14:06, Jan Beulich wrote: >>> Commit 6f8f53cc64 ("x86 cpu: Fix bug: unify cpu_dev attr as >>> __cpuinitdata") fixed centaur_cpu_dev's annotation without also fixing >>> the pointers hanging off of it. Even if CP

Re: [Xen-devel] [PATCH] x86/Centaur: drop __init annotations

2015-10-14 Thread Jan Beulich
>>> On 14.10.15 at 15:22, wrote: > On 14/10/15 14:06, Jan Beulich wrote: >> Commit 6f8f53cc64 ("x86 cpu: Fix bug: unify cpu_dev attr as >> __cpuinitdata") fixed centaur_cpu_dev's annotation without also fixing >> the pointers hanging off of it. Even if CPU hotplig support may be >> purely theoreti

Re: [Xen-devel] [PATCH] x86/Centaur: drop __init annotations

2015-10-14 Thread Andrew Cooper
On 14/10/15 14:06, Jan Beulich wrote: > Commit 6f8f53cc64 ("x86 cpu: Fix bug: unify cpu_dev attr as > __cpuinitdata") fixed centaur_cpu_dev's annotation without also fixing > the pointers hanging off of it. Even if CPU hotplig support may be > purely theoretical for Centaur, we should still not lea