>>> On 14.10.15 at 15:22, <andrew.coop...@citrix.com> wrote: > On 14/10/15 14:06, Jan Beulich wrote: >> Commit 6f8f53cc64 ("x86 cpu: Fix bug: unify cpu_dev attr as >> __cpuinitdata") fixed centaur_cpu_dev's annotation without also fixing >> the pointers hanging off of it. Even if CPU hotplig support may be >> purely theoretical for Centaur, we should still not leave this as is. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > > Surely they should be __cpuinit to match __cpuinitdata. > > This will have the same effect, as __cpuinit is empty on x86.
Actually all the __{cpu,dev}init{,data} should go away, which is why I wouldn't want to needlessly add them here. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel