Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-03-30 Thread Dario Faggioli
On Tue, 2017-03-28 at 19:30 +0100, Julien Grall wrote: > Hi Dario, > Hey, > On 02/02/17 13:32, Dario Faggioli wrote: > > On Thu, 2017-02-02 at 13:26 +, Julien Grall wrote: > > > > > Ok, sign me up for it then. We absolutely want it for 4.9, I agree. > > Do you have any update on this? This

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-03-28 Thread Julien Grall
Hi Dario, On 02/02/17 13:32, Dario Faggioli wrote: On Thu, 2017-02-02 at 13:26 +, Julien Grall wrote: On 02/02/17 12:51, Dario Faggioli wrote: So, I expect to be able to do something useful only, let's stay, from Mon 13th. If that's ok, do sign me up. If you're more in a hurry, feel free t

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-02-02 Thread Dario Faggioli
On Thu, 2017-02-02 at 13:26 +, Julien Grall wrote: > On 02/02/17 12:51, Dario Faggioli wrote: > > So, I expect to be able to do something useful only, let's stay, > > from > > Mon 13th. If that's ok, do sign me up. If you're more in a hurry, > > feel > > free to beat me. :-) > > I have plenty

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-02-02 Thread Julien Grall
Hi Dario, On 02/02/17 12:51, Dario Faggioli wrote: On Thu, 2017-02-02 at 12:18 +, Julien Grall wrote: Dario, are you going to look into the issue? Or shall I try to write a patch for it? I'd be up for looking into this. BUT, I'm travelling this weekend, and am probably going to be busy ne

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-02-02 Thread Dario Faggioli
On Thu, 2017-02-02 at 12:18 +, Julien Grall wrote: > Dario, are you going to look into the issue? Or shall I try to write > a  > patch for it? > I'd be up for looking into this. BUT, I'm travelling this weekend, and am probably going to be busy next week (sorry). So, I expect to be able to do

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-02-02 Thread Julien Grall
Hi, On 02/02/17 11:53, Wei Liu wrote: On Thu, Feb 02, 2017 at 04:22:53AM -0700, Jan Beulich wrote: On 01.02.17 at 19:21, wrote: On Tue, Jan 31, 2017 at 04:30:50PM +, Julien Grall wrote: Hi Dario, On 25/01/17 16:00, Dario Faggioli wrote: On Wed, 2017-01-25 at 12:38 +, Julien Grall w

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-02-02 Thread Dario Faggioli
On Thu, 2017-02-02 at 04:22 -0700, Jan Beulich wrote: > On 01.02.17 at 19:21, wrote: > > On Tue, Jan 31, 2017 at 04:30:50PM +, Julien Grall wrote: > > > Yeah, even the tiny RCU code is quite complex :/. I've looked at > > > our RCUcode and noticed there is a link in the header to [1]. > >

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-02-02 Thread Wei Liu
On Thu, Feb 02, 2017 at 04:22:53AM -0700, Jan Beulich wrote: > >>> On 01.02.17 at 19:21, wrote: > > On Tue, Jan 31, 2017 at 04:30:50PM +, Julien Grall wrote: > >> Hi Dario, > >> > >> On 25/01/17 16:00, Dario Faggioli wrote: > >> > On Wed, 2017-01-25 at 12:38 +, Julien Grall wrote: > >> >

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-02-02 Thread Jan Beulich
>>> On 01.02.17 at 19:21, wrote: > On Tue, Jan 31, 2017 at 04:30:50PM +, Julien Grall wrote: >> Hi Dario, >> >> On 25/01/17 16:00, Dario Faggioli wrote: >> > On Wed, 2017-01-25 at 12:38 +, Julien Grall wrote: >> > > On 25/01/17 11:10, Dario Faggioli wrote: >> > And a good one. I may be wr

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-02-01 Thread Wei Liu
On Tue, Jan 31, 2017 at 04:30:50PM +, Julien Grall wrote: > Hi Dario, > > On 25/01/17 16:00, Dario Faggioli wrote: > > On Wed, 2017-01-25 at 12:38 +, Julien Grall wrote: > > > On 25/01/17 11:10, Dario Faggioli wrote: > > And a good one. I may be wrong (I certainly wasn't around at the time

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-31 Thread Stefano Stabellini
On Tue, 31 Jan 2017, Julien Grall wrote: > Hi Dario, > > On 25/01/17 16:00, Dario Faggioli wrote: > > On Wed, 2017-01-25 at 12:38 +, Julien Grall wrote: > > > On 25/01/17 11:10, Dario Faggioli wrote: > > And a good one. I may be wrong (I certainly wasn't around at the time), > > but ISTR out R

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-31 Thread Julien Grall
Hi Dario, On 25/01/17 16:00, Dario Faggioli wrote: On Wed, 2017-01-25 at 12:38 +, Julien Grall wrote: On 25/01/17 11:10, Dario Faggioli wrote: And a good one. I may be wrong (I certainly wasn't around at the time), but ISTR out RCU code is imported/inspired by Linux... Looking there again

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-25 Thread Dario Faggioli
On Wed, 2017-01-25 at 12:38 +, Julien Grall wrote: > Hi Dario, > Hey, > On 25/01/17 11:10, Dario Faggioli wrote: > > My point was that, still from scheduling perspective, neither > > Credit1 > > nor Credit2 sets a wakeup timer for idle pCPUs. > > > > Well, in Credit1, the master_ticker timer

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-25 Thread Julien Grall
On 25/01/17 12:40, Andrew Cooper wrote: On 25/01/17 12:38, Julien Grall wrote: Hi Dario, On 25/01/17 11:10, Dario Faggioli wrote: On Tue, 2017-01-24 at 15:06 +, Julien Grall wrote: On 24/01/17 14:16, Dario Faggioli wrote: There, we have tracing (BTW, did that made it to ARM eventually?

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-25 Thread Andrew Cooper
On 25/01/17 12:38, Julien Grall wrote: > Hi Dario, > > On 25/01/17 11:10, Dario Faggioli wrote: >> On Tue, 2017-01-24 at 15:06 +, Julien Grall wrote: >>> On 24/01/17 14:16, Dario Faggioli wrote: There, we have tracing (BTW, did that made it to ARM eventually?) and there's TRC_PM_

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-25 Thread Julien Grall
Hi Dario, On 25/01/17 11:10, Dario Faggioli wrote: On Tue, 2017-01-24 at 15:06 +, Julien Grall wrote: On 24/01/17 14:16, Dario Faggioli wrote: There, we have tracing (BTW, did that made it to ARM eventually?) and there's TRC_PM_IDLE_ENTRY/EXIT which do pretty much the same of your printk-s

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-25 Thread Dario Faggioli
On Tue, 2017-01-24 at 15:06 +, Julien Grall wrote: > On 24/01/17 14:16, Dario Faggioli wrote: > > There, we have tracing (BTW, did that made it to ARM eventually?) > > and > > there's TRC_PM_IDLE_ENTRY/EXIT which do pretty much the same of > > your > > printk-s. > > There is patch on the ML fo

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-24 Thread Julien Grall
On 24/01/17 14:16, Dario Faggioli wrote: On Tue, 2017-01-24 at 13:49 +, Julien Grall wrote: On 24/01/17 13:40, Dario Faggioli wrote: Ah, wow... And how --forgive my naiveness-- do you measure / check that? I added a print in the interrupt path (gic_interrupt for ARM) to dump the interru

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-24 Thread Dario Faggioli
On Tue, 2017-01-24 at 13:49 +, Julien Grall wrote: > On 24/01/17 13:40, Dario Faggioli wrote: > > Ah, wow... And how --forgive my naiveness-- do you measure / check > > that? > > I added a print in the interrupt path (gic_interrupt for ARM) to > dump  > the interrupt number. This needs to be r

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-24 Thread Julien Grall
Hi, On 24/01/17 13:40, Dario Faggioli wrote: On Tue, 2017-01-24 at 13:24 +, Julien Grall wrote: On 24/01/17 13:19, Dario Faggioli wrote: How are Dom0 vCPUs pinned, exclusively (i.e., there are 2 pCPUs on which _only_ Dom0 and _no_ DomU can run)? I have dom0_vcpu_pins on Xen command line

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-24 Thread Dario Faggioli
On Tue, 2017-01-24 at 13:24 +, Julien Grall wrote: > On 24/01/17 13:19, Dario Faggioli wrote: > > How are Dom0 vCPUs pinned, exclusively (i.e., there are 2 pCPUs on > > which _only_ Dom0 and _no_ DomU can run)? > > I have dom0_vcpu_pins on Xen command line option (so I guess only  > pinned?),

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-24 Thread Julien Grall
On 24/01/17 13:19, Dario Faggioli wrote: On Tue, 2017-01-24 at 13:04 +, Julien Grall wrote: On 24/01/17 12:53, Dario Faggioli wrote: Do you have a script and/or some more info for letting me try to reproduce it (e.g., you say some otf the vCPUs are pinned, which one? etc)? That was ment

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-24 Thread Dario Faggioli
On Tue, 2017-01-24 at 13:04 +, Julien Grall wrote: > On 24/01/17 12:53, Dario Faggioli wrote: > > Do you have a script and/or some more info for letting me try to > > reproduce it (e.g., you say some otf the vCPUs are pinned, which > > one? > > etc)? > > That was mentioned in my first e-mail :

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-24 Thread Julien Grall
On 24/01/17 13:04, Julien Grall wrote: Hi Dario, On 24/01/17 12:53, Dario Faggioli wrote: On Tue, 2017-01-24 at 10:50 +, Julien Grall wrote: On 24/01/2017 08:20, Jan Beulich wrote: On 23.01.17 at 20:42, wrote: The function domain_destroy will setup the RCU callback (complete_domain_de

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-24 Thread Julien Grall
Hi Dario, On 24/01/17 12:53, Dario Faggioli wrote: On Tue, 2017-01-24 at 10:50 +, Julien Grall wrote: On 24/01/2017 08:20, Jan Beulich wrote: On 23.01.17 at 20:42, wrote: The function domain_destroy will setup the RCU callback (complete_domain_destroy) by calling call_rcu. call_rcu will

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-24 Thread Dario Faggioli
On Tue, 2017-01-24 at 10:50 +, Julien Grall wrote: > On 24/01/2017 08:20, Jan Beulich wrote: > > > > > On 23.01.17 at 20:42, wrote: > > > The function domain_destroy will setup the RCU callback > > > (complete_domain_destroy) by calling call_rcu. call_rcu will add > > > the > > > callback into

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-24 Thread Julien Grall
Hi Stefano, On 24/01/17 00:16, Stefano Stabellini wrote: On Mon, 23 Jan 2017, Julien Grall wrote: Hi all, Before someone dig into the scheduler, I don't think this is an issue in credit2 but the use of it highlight a bug in another component (I think RCU). Whilst testing other patches today,

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-24 Thread Julien Grall
Hi, On 24/01/17 11:02, Jan Beulich wrote: On 24.01.17 at 11:50, wrote: On 24/01/2017 08:20, Jan Beulich wrote: On 23.01.17 at 20:42, wrote: Whilst testing other patches today, I have noticed that some part of the resources allocated to a guest were not released during the destruction. The

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-24 Thread Jan Beulich
>>> On 24.01.17 at 11:50, wrote: > On 24/01/2017 08:20, Jan Beulich wrote: > On 23.01.17 at 20:42, wrote: >>> Whilst testing other patches today, I have noticed that some part of the >>> resources allocated to a guest were not released during the destruction. >>> >>> The configuration of the

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-24 Thread Julien Grall
Hi Jan, On 24/01/2017 08:20, Jan Beulich wrote: On 23.01.17 at 20:42, wrote: Whilst testing other patches today, I have noticed that some part of the resources allocated to a guest were not released during the destruction. The configuration of the test is: - ARM platform with 6 cores

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-24 Thread Jan Beulich
>>> On 23.01.17 at 20:42, wrote: > Whilst testing other patches today, I have noticed that some part of the > resources allocated to a guest were not released during the destruction. > > The configuration of the test is: > - ARM platform with 6 cores > - staging Xen with credit2 enab

Re: [Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-23 Thread Stefano Stabellini
On Mon, 23 Jan 2017, Julien Grall wrote: > Hi all, > > Before someone dig into the scheduler, I don't think this is an issue in > credit2 but the use of it highlight a bug in another component (I think RCU). > > Whilst testing other patches today, I have noticed that some part of the > resources

[Xen-devel] xen/arm: Domain not fully destroyed when using credit2

2017-01-23 Thread Julien Grall
Hi all, Before someone dig into the scheduler, I don't think this is an issue in credit2 but the use of it highlight a bug in another component (I think RCU). Whilst testing other patches today, I have noticed that some part of the resources allocated to a guest were not released during the