Re: [Xen-devel] libxl, flexarray_append_pair usage

2015-05-01 Thread Ian Campbell
On Fri, 2015-04-24 at 11:16 +0200, Olaf Hering wrote: > On Fri, Apr 24, Olaf Hering wrote: > > > flexarray_append(back, "state"); > > -flexarray_append(back, GCSPRINTF("%d", 1)); > > +flexarray_append(back, GCSPRINTF("%d", XenbusStateInitialising)); > > Should all such code be conver

Re: [Xen-devel] libxl, flexarray_append_pair usage

2015-04-24 Thread Wei Liu
On Fri, Apr 24, 2015 at 11:16:00AM +0200, Olaf Hering wrote: > On Fri, Apr 24, Olaf Hering wrote: > > > flexarray_append(back, "state"); > > -flexarray_append(back, GCSPRINTF("%d", 1)); > > +flexarray_append(back, GCSPRINTF("%d", XenbusStateInitialising)); > > Should all such code be

[Xen-devel] libxl, flexarray_append_pair usage

2015-04-24 Thread Olaf Hering
On Fri, Apr 24, Olaf Hering wrote: > flexarray_append(back, "state"); > -flexarray_append(back, GCSPRINTF("%d", 1)); > +flexarray_append(back, GCSPRINTF("%d", XenbusStateInitialising)); Should all such code be converted to flexarray_append_pair? To reduce line length a short macro sh