On Fri, 2015-04-24 at 11:16 +0200, Olaf Hering wrote:
> On Fri, Apr 24, Olaf Hering wrote:
>
> > flexarray_append(back, "state");
> > - flexarray_append(back, GCSPRINTF("%d", 1));
> > + flexarray_append(back, GCSPRINTF("%d", XenbusStateInitialising));
>
> Should all such code be converted to flexarray_append_pair?
If you are touching the line anyway then I suppose that would be a good
thing, although not mandatory.
I don't think it is worth going through and proactively changing things.
> To reduce line length a short macro should be added, like FLXAP or
> FLXPAIR or something else.
Not sure about this, the macro doesn't save very much and FLX is a bit
opaque, I'd be inclined to just do normal wrapping for now.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
